--- Log opened Thu May 24 00:00:02 2018 --- Day changed Thu May 24 2018 20180524 00:00:01<+discordbot> Hm, I didn't realize I got switched to the 1.1 OpenSSL dev package at some point. 20180524 00:00:35<+discordbot> It must've been during the Qt 5.9 → 5.10 upgrade. 20180524 00:05:19-!- travis-ci [~travis-ci@ec2-54-242-49-100.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 00:05:20< travis-ci> wesnoth/wesnoth#18333 (master - e8c803d : Iris Morelle): The build was broken. 20180524 00:05:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/382941982 20180524 00:05:21-!- travis-ci [~travis-ci@ec2-54-242-49-100.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 00:06:00<+discordbot> Wat. 20180524 00:06:49<+discordbot> the boost tests seem to have exploded 20180524 00:06:54<+discordbot> There's an enormous amount of things going wrong in that log, yeah. 20180524 00:07:06<+discordbot> dunno what's causing the image not found errors 20180524 00:07:27<+discordbot> Hang on a moment. 20180524 00:07:48<+discordbot> Vultraz, you didn't test your commit after adding the comment. 20180524 00:08:05<+discordbot> The comment is in the middle of a formula. It completely breaks the dialog because it's not valid formula syntax. 20180524 00:08:36<+discordbot> glorious 20180524 00:09:19< celticminstrel> Put a # at the end of the comment, then? 20180524 00:09:34<+discordbot> each line? 20180524 00:10:04< celticminstrel> WFL comments are # ... # IIRC so you only need two #'s total for the whole comment, you don't need one at the beginning of each line. 20180524 00:10:30< celticminstrel> And putting one at the beginning of each line will not work, tbough it might work if you had two at the beginning of each line other than the first... 20180524 00:10:45< celticminstrel> Or it would work if each line began and ended with # 20180524 00:10:55<+discordbot> The simple version: # foo # == /* */ ? 20180524 00:11:04< celticminstrel> Yeah. 20180524 00:11:14<+discordbot> I forgot the foo on the second. 20180524 00:15:29< irker286> wesnoth: Charles Dang wesnoth:1.14 9b75279aea9b / data/gui/window/wml_message.cfg: Fixup d379abc (WFL comment syntax) https://github.com/wesnoth/wesnoth/commit/9b75279aea9b2c371d8b81e689ef63e34fb398ef 20180524 00:16:01<+discordbot> eye twitch 20180524 00:16:56< irker286> wesnoth: Charles Dang wesnoth:master c48a8e7edd4f / data/gui/window/wml_message.cfg: Fixup 9bf7a4c (WFL comment syntax) https://github.com/wesnoth/wesnoth/commit/c48a8e7edd4f982d1633521ad3c3e12fbbeb91ad 20180524 00:17:19<+discordbot> Notice that you had to go through the effort of fetching the hash for the parent commit on both branches. 20180524 00:17:42< celticminstrel> At least he added an additional explanation though. 20180524 00:18:12<+discordbot> Also, while you are here and you confirmed that you do read the logs, vultraz, what's the reason for the holdup? 20180524 00:18:26<+discordbot> What are we waiting for before 1.14.2? 20180524 00:19:32<+discordbot> I wanted ancestral's hotkey PR :/ but it hasn't appeared. Just the cleanup PR. 20180524 00:22:40< celticminstrel> We're changing the default hotkeys in 1.14? 20180524 00:22:47< celticminstrel> That seems... a little ill-advised? 20180524 00:22:59<+discordbot> yes 20180524 00:23:04<+discordbot> I tagged some of the other PRs which I think can go in too 20180524 00:24:58<+discordbot> Tagged them with what tag? Urgent? 20180524 00:25:01<+discordbot> I'm going to assume the campaigns changes work 20180524 00:25:07<+discordbot> yes 20180524 00:25:18<+discordbot> I beg of you to not assume things in stable. <_< 20180524 00:25:42<+discordbot> I didn't exactly test them 20180524 00:27:12<+discordbot> wait, what? 20180524 00:27:17-!- travis-ci [~travis-ci@ec2-54-90-79-5.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 00:27:18< travis-ci> wesnoth/wesnoth#18334 (1.14 - cfc0c4f : Iris Morelle): The build was broken. 20180524 00:27:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/382942023 20180524 00:27:18-!- travis-ci [~travis-ci@ec2-54-90-79-5.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 00:30:54-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180524 01:03:48<+discordbot> Why are unit level up animations dark now? 20180524 01:05:00<+discordbot> They were white all the way from 0.9.5 through 1.12.x. 20180524 01:30:42<+discordbot> Some hidden but that happens randomly of which I don’t know the cause 20180524 01:43:37<+discordbot> sometimes it's white, sometimes it's black 20180524 01:46:08<+discordbot> @shadowm if you have a definite repro case let me know 20180524 01:46:21<+discordbot> Uhhh. 20180524 01:47:25<+discordbot> I can tell you that the first cutscene of AtS E3S0 always displays the issue for me. 20180524 01:47:42<+discordbot> let's see here.. 20180524 01:47:56<+discordbot> I believe that it uses the level up animation through TRANSFORM_UNIT or something, I'm not on my desktop right now. 20180524 01:49:04<+discordbot> ok, this is good.. 20180524 01:50:26<+discordbot> Okay, I SSH'd into my desktop. 20180524 01:50:38<+discordbot> It uses [animate_unit] manually for both halves of the animation. 20180524 01:53:31<+discordbot> Wait. 20180524 01:53:36<+discordbot> That's supposed to use a custom animation. 20180524 01:53:57<+discordbot> She's supposed to get tinted red instead of the engine default. 20180524 01:54:14<+discordbot> INTERESTING 20180524 01:54:28<+discordbot> Elyssa where you at 20180524 01:54:59<+discordbot> https://github.com/project-ethea/After_the_Storm/blob/master/units/shaxthal/Warlord_Elyssa.cfg#L185 20180524 01:55:58<+discordbot> WELL WELL WELL 20180524 01:57:14<+discordbot> the formatting is right... 20180524 01:57:15<+discordbot> rgb... 20180524 01:59:41-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20180524 02:02:16<+discordbot> (shouldn't you hide elyssa's bars in e3s0.2? 20180524 02:03:30<+discordbot> Not really? 20180524 02:03:58<+discordbot> I never hide unit bars while static. 20180524 02:04:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180524 02:04:29<+discordbot> The Memory Controller unit is the exception but that's because they're not supposed to actually be there. 20180524 02:16:13<+discordbot> trying blend color for frame units/shaxthal/warlord-elyssa-cutscene-1.png:1,units/shaxthal/warlord-elyssa-cutscene-1.png:250,units/shaxthal/warlord-elyssa-cutscene-1.png:1, blend c: (key blend_color) '' set blend color to 0 0 0 0 20180524 02:17:25<+discordbot> Yikes. 20180524 02:18:04<+discordbot> that might be for the defense anim, though... 20180524 02:18:31<+discordbot> units/shaxthal/warlord-elyssa-cutscene-2.png is never handled... 20180524 02:19:06<+discordbot> wait 20180524 02:23:50<+discordbot> @shadowm this works [levelout_anim] start_time=0 [frame] duration=1500 blend_ratio="0.0~1.0" blend_color="255,0,0" [/frame] [/levelout_anim] 20180524 02:24:38<+discordbot> That sounds like a bug. 20180524 02:24:46<+discordbot> meeeehhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh 20180524 02:24:52<+discordbot> I'm pretty sure this was working fine in 1.12. 20180524 02:25:07<+discordbot> Also I don't know what to make of your response. 20180524 02:26:17<+discordbot> It's also important to identify whether the bug is that the blend parameters are being clobbered by the defaults or ignored altogether. 20180524 02:26:31<+discordbot> Furthermore it's important to find out why the default appears to be black. 20180524 02:27:03<+discordbot> that's the default color 20180524 02:27:10<+discordbot> color_t color 20180524 02:27:41<+discordbot> I guessed as muhc. 20180524 02:27:45<+discordbot> if(c.empty()) { return null_color(); } 20180524 02:27:51<+discordbot> well 20180524 02:27:59<+discordbot> the default color_t color returned 20180524 02:27:59<+discordbot> But the default animations are supposed to use white. 20180524 02:28:07<+discordbot> These animations in particular. 20180524 02:28:18<+discordbot> a default constructed color is white 20180524 02:28:51<+discordbot> ...oo... 20180524 02:30:10<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/449036356082073620/levelup-anim.gz 20180524 02:30:32<+discordbot> There you have a simpler test case. This is Two Brothers scenario 1, and you've got a bat about to level up, and an enemy Elvish Lady. 20180524 02:30:44<+discordbot> I think you can figure out the rest. 20180524 02:32:26<+discordbot> I have a fix. 20180524 02:32:30<+discordbot> turns out it was my fault 20180524 02:35:59< irker286> wesnoth: Charles Dang wesnoth:1.14 60c93cf47b19 / changelog.md src/units/frame.cpp: Fixed animation-wide text_color and blend_color keys being overwritten https://github.com/wesnoth/wesnoth/commit/60c93cf47b19f8c1da6f6ee78d346feddebfcc07 20180524 02:37:12<+discordbot> it should fix the levelin/levelout problem 20180524 02:37:15<+discordbot> but im nt sure 20180524 02:37:15< irker286> wesnoth: Charles Dang wesnoth:master 27d0a6f6fe0a / changelog.md src/units/frame.cpp: Fixed animation-wide text_color and blend_color keys being overwritten https://github.com/wesnoth/wesnoth/commit/27d0a6f6fe0af877e4bd2f981b8bf4e98dcb2838 20180524 02:37:18<+discordbot> it fixes your case 20180524 02:37:21<+discordbot> which is important 20180524 02:37:29<+discordbot> Which case? 20180524 02:37:37<+discordbot> elyssa in e3s0 20180524 02:37:52<+discordbot> You can grab the TB save I just posted above and test too. 20180524 02:38:17<+discordbot> None of this stuff is serialized into saves so it doesn't matter that the save predates the fix. 20180524 02:39:01<+discordbot> it's white 20180524 02:39:28<+discordbot> but those animations would sometimes be white before too 20180524 02:40:38<+discordbot> I'm not sure I've seen them be white to be honest. 20180524 02:41:06<+discordbot> well it doesn't matter now 20180524 02:41:09<+discordbot> the bug is fixed 20180524 02:41:15<+discordbot> thanks for providing a good testcase 20180524 02:42:52<+discordbot> np 20180524 02:43:58<+discordbot> As for the animation not displaying, I believe back in the day the engine would skip animation frames if it decided it's missing a certain time target. 20180524 02:44:41<+discordbot> (Which could happen when the system is under load or if loading frames from disk for the first time took too long. The animation engine at least until 1.12.x did not load images in advance.) 20180524 02:56:04<+discordbot> seems AtS is a good vector for finding bugs 20180524 02:56:10<+discordbot> and regressions 20180524 02:58:59-!- travis-ci [~travis-ci@ec2-54-242-49-100.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 02:59:00< travis-ci> wesnoth/wesnoth#18335 (1.14 - 60c93cf : Charles Dang): The build was fixed. 20180524 02:59:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/382988084 20180524 02:59:00-!- travis-ci [~travis-ci@ec2-54-242-49-100.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 02:59:22< celticminstrel> So looking at SyntaxWML reminded me that I vaguely remember a parser error with << >> ... 20180524 03:02:36< celticminstrel> And that made me think, the parser could use some work in general. 20180524 03:03:24<+discordbot> parser error? 20180524 03:04:05< celticminstrel> IIRC I had something like << ... >> + {thing} + << ... >> and {thing} was not macro-substituted? Not quite sure though. 20180524 03:04:34<+discordbot> doesn't shadowm rely on that somewhere? 20180524 03:04:40< celticminstrel> Does she? 20180524 03:04:57< celticminstrel> Kinda hope not. 20180524 03:05:05<+discordbot> I think she does 20180524 03:06:20<+discordbot> @shadowm do you not? 20180524 03:06:26 * celticminstrel envisions a rather complicated way of parsing that... "oh we found a >... oh there's another one, maybe this is the end? ayup, now we have a + so the string must be over"... the idea being to allow use of the >> operator in embedded Lua code by only taking >> as the closing marker if it's either at the end of the line or followed by a + token. 20180524 03:07:23<+discordbot> Does this count? https://github.com/project-ethea/Invasion_from_the_Unknown/blob/master/base-loader.cfg#L67 20180524 03:08:03< celticminstrel> Well, that would seem to be a counter-example actually? 20180524 03:08:23< celticminstrel> Assuming you intend {LD dist/VERSION} to get substituted. 20180524 03:08:41<+discordbot> It is substituted. 20180524 03:09:09< celticminstrel> Okay, so if that bug exists I guess it's only when it's a one-liner, or something. Alternatively I may have imagined it, that happens sometimes. 20180524 03:10:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180524 03:12:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180524 03:18:02-!- travis-ci [~travis-ci@ec2-54-90-79-5.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 03:18:03< travis-ci> wesnoth/wesnoth#18336 (master - 27d0a6f : Charles Dang): The build was fixed. 20180524 03:18:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/382988456 20180524 03:18:03-!- travis-ci [~travis-ci@ec2-54-90-79-5.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 03:35:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180524 03:42:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180524 03:42:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180524 03:47:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 252 seconds] 20180524 04:23:17< irker286> wesnoth/wesnoth:1.14 gfgtdf ee50171d13 fix different carryover when loading sta AppVeyor: All builds passed 20180524 04:49:24<+discordbot> @shadowm Yes, the semantics of converting strings to numbers for configs haven't changed. There are unit tests to keep them from changing. 20180524 04:49:28<+discordbot> https://github.com/wesnoth/wesnoth/blob/1.14/src/tests/test_config.cpp 20180524 04:52:50<+discordbot> Actually, it sounds like they changed? 20180524 04:53:09<+discordbot> According to that module, "0x11" == 0. 20180524 04:55:48<+discordbot> Back when we had to "escape" usernames and passwords "0x11" == 17 would've held true instead. 20180524 04:57:15<+discordbot> Apparently "0x11" conversion to number has yielded zero as long as the unit tests have existed. 20180524 04:57:34<+discordbot> For the record, lexical_cast has code to explicitly maintain that behavior: https://github.com/wesnoth/wesnoth/blob/1.14/src/lexical_cast.hpp#L344 20180524 04:59:44<+discordbot> in a unit death animation 20180524 04:59:50<+discordbot> is there a way to make it fade out as the animation is going 20180524 04:59:58<+discordbot> without having it fade out again at the last frame 20180524 05:00:54<+discordbot> Maybe change the opacity of the frames? 20180524 05:00:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180524 05:01:38<+discordbot> I can do that but then the engine decides to set the opacity on the last frame to 100% 20180524 05:01:53<+discordbot> and does the fadeout all over again 20180524 05:09:51<+discordbot> I just casually came upon this while looking at the commit history: https://github.com/wesnoth/wesnoth/commit/67bb876ffaee4b995ab5ec82de954bc00adfb3a0 What else can WML do that I had no idea it could do? 20180524 05:10:59<+discordbot> Also Vultraz, it's probably worth mentioning in both changelogs that the animation fix has the side-effect of fixing unit level-up animations blending into black instead of white. 20180524 05:42:20-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180524 06:02:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180524 06:40:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180524 06:56:32< irker286> wesnoth/wesnoth:1.14 Charles Dang 9b75279aea Fixup d379abc (WFL comment syntax) AppVeyor: All builds passed 20180524 07:05:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer] 20180524 07:05:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180524 07:14:07-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180524 07:14:32-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180524 07:14:42-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180524 07:14:42-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180524 07:38:32-!- vn971 [~vasya@94.158.103.15] has left #wesnoth-dev ["Leaving."] --- Log opened Thu May 24 09:42:44 2018 20180524 09:42:53-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20180524 09:42:53-!- Topic for #wesnoth-dev: Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org 20180524 09:42:53-!- Topic set by shadowm [~iris@wesnoth/developer/shadowm] [Wed May 9 21:20:06 2018] 20180524 09:42:53[Users #wesnoth-dev] 20180524 09:42:53[ aeth ] [ esr ] [ Kawa[m] ] [ Rhonda ] 20180524 09:42:53[ AI0867 ] [ galegosimpatico] [ lobby ] [ TC01 ] 20180524 09:42:53[ aidanhs2 ] [ Gambit ] [ madmax28 ] [ TheJJ ] 20180524 09:42:53[ APic ] [ heirecka ] [ matthiaskrgr] [ timotei_ ] 20180524 09:42:53[ ChipmunkV[m] ] [ higgins ] [ minzbonbon ] [ valdar ] 20180524 09:42:53[ commavir ] [ iceiceice ] [ nore ] [ vihta ] 20180524 09:42:53[ crimson_penguin] [ irker286 ] [ nurupo ] [ vincent_c] 20180524 09:42:53[ DDR ] [ Ivanovic ] [ oldlaptop ] [ wedge009 ] 20180524 09:42:53[ DeFender1031 ] [ iwaim ] [ Polsaker ] [ zookeeper] 20180524 09:42:53[ elias ] [ janebot ] [ pydsigner ] 20180524 09:42:53[ EliDupree ] [ Jetrel_bot ] [ Ravana_ ] 20180524 09:42:53-!- Irssi: #wesnoth-dev: Total of 42 nicks [0 ops, 0 halfops, 0 voices, 42 normal] 20180524 09:42:53-!- Home page for #wesnoth-dev: https://www.wesnoth.org 20180524 09:43:01-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009 20180524 09:43:51-!- Irssi: Join to #wesnoth-dev was synced in 65 secs 20180524 09:48:26-!- shadowm [~iris@wesnoth/developer/shadowm] has joined #wesnoth-dev 20180524 09:48:28-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev 20180524 10:40:11-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has joined #wesnoth-dev 20180524 10:46:07< irker286> wesnoth/wesnoth:master Charles Dang 27d0a6f6fe Fixed animation-wide text_color and blen AppVeyor: All builds passed 20180524 10:58:39-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has quit [Remote host closed the connection] 20180524 10:58:50-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has joined #wesnoth-dev 20180524 11:24:47-!- gfgt [~androirc@ersc158.goemobile.de] has joined #wesnoth-dev 20180524 11:25:23-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180524 11:29:25-!- gfgt [~androirc@ersc158.goemobile.de] has quit [Ping timeout: 245 seconds] 20180524 11:29:33-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has joined #wesnoth-dev 20180524 11:31:59-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has quit [Client Quit] 20180524 11:32:14-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has joined #wesnoth-dev 20180524 11:33:19-!- fabi [~fabi@200116b82b71c3007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180524 11:33:54-!- fabi [~fabi@200116b82b71c3007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180524 11:33:54-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180524 11:37:25-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20180524 11:39:19-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180524 11:45:37-!- valdar [~atarocch@93.56.164.28] has quit [Ping timeout: 245 seconds] 20180524 11:47:58-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180524 11:48:00-!- valdar [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180524 11:56:09-!- discordbot1 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180524 11:56:12-!- mode/#wesnoth-dev [+v discordbot1] by ChanServ 20180524 12:34:13-!- gfg [~androirc@tmo-081-185.customers.d1-online.com] has quit [Remote host closed the connection] 20180524 13:48:01-!- irker286 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180524 14:13:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180524 14:20:21-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180524 15:29:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds] 20180524 16:27:21-!- irker399 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180524 16:27:21< irker399> wesnoth: ancestral wesnoth:cleanup_keys 98a904ea4276 / data/core/hotkeys.cfg: Added Redo (Ctrl/Cmd+Y) https://github.com/wesnoth/wesnoth/commit/98a904ea427666920a5acb49d060cd047d1766ea 20180524 16:38:55-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180524 16:39:21-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180524 16:50:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180524 16:50:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180524 16:52:44-!- travis-ci [~travis-ci@ec2-54-163-45-203.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 16:52:45< travis-ci> wesnoth/wesnoth#18338 (cleanup_keys - 98a904e : ancestral): The build was fixed. 20180524 16:52:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383281442 20180524 16:52:45-!- travis-ci [~travis-ci@ec2-54-163-45-203.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 17:05:11-!- APic [apic@apic.name] has quit [Ping timeout: 256 seconds] 20180524 17:36:50< irker399> wesnoth: Jyrki Vesterinen wesnoth:master f86188368395 / src/terrain/filter.cpp: Fix memory leak in terrain filter matching https://github.com/wesnoth/wesnoth/commit/f861883683956c45640d6f86e7ea01b3a4a8a34e 20180524 17:36:52< irker399> wesnoth: Jyrki Vesterinen wesnoth:master bd5be036b756 / src/terrain/filter.cpp: terrain_filter::match_internal(): use std::make_shared() https://github.com/wesnoth/wesnoth/commit/bd5be036b756b76c7485dd1ea5cb90a5451e85dc 20180524 17:36:54< irker399> wesnoth: Jyrki Vesterinen wesnoth:master f5609d6911ff / changelog.md players_changelog.md: Changelog entry for commit f861883683956c45640d6f86e7ea01b3a4a8a34e https://github.com/wesnoth/wesnoth/commit/f5609d6911ff1539ac39124be0402f7720f0396e 20180524 17:37:30< irker399> wesnoth: Jyrki Vesterinen wesnoth:1.14 57fd9cc5867d / src/terrain/filter.cpp: Fix memory leak in terrain filter matching https://github.com/wesnoth/wesnoth/commit/57fd9cc5867dabcedb951209e955043f51d3272d 20180524 17:37:32< irker399> wesnoth: Jyrki Vesterinen wesnoth:1.14 4e68c144db63 / src/terrain/filter.cpp: terrain_filter::match_internal(): use std::make_shared() https://github.com/wesnoth/wesnoth/commit/4e68c144db6386361b3e644bdf11f7105d17b174 20180524 17:37:34< irker399> wesnoth: Jyrki Vesterinen wesnoth:1.14 a094f4253bfc / changelog.md players_changelog.md: Changelog entry for commit 57fd9cc5867dabcedb951209e955043f51d3272d https://github.com/wesnoth/wesnoth/commit/a094f4253bfc845a9a3bf8c4b18b759028d69d9d 20180524 17:38:08<+discordbot1> That was the memory leak I had been chasing. Bye bye, we don't miss you. 😈 20180524 17:41:33<+discordbot1> gz 20180524 17:56:42-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180524 18:00:33-!- travis-ci [~travis-ci@ec2-54-163-45-203.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 18:00:34< travis-ci> wesnoth/wesnoth#18340 (master - f5609d6 : Jyrki Vesterinen): The build was broken. 20180524 18:00:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383312923 20180524 18:00:34-!- travis-ci [~travis-ci@ec2-54-163-45-203.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 18:14:09-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180524 18:15:43-!- APic [apic@apic.name] has joined #wesnoth-dev 20180524 19:33:58-!- Gambit is now known as Guest33538 20180524 19:33:58-!- vincent_c is now known as Guest4695 20180524 19:33:58-!- nore is now known as Guest21317 20180524 19:34:05-!- elias is now known as Guest79491 20180524 19:34:07-!- nurupo is now known as Guest60309 20180524 19:34:40< irker399> wesnoth: Nils Kneuper wesnoth:1.14 d47b27d2292f / po/wesnoth-lib/es.po: updated Spanish translation https://github.com/wesnoth/wesnoth/commit/d47b27d2292fd96155a24726e5040000de0eaf50 20180524 19:34:42< irker399> wesnoth: Nils Kneuper wesnoth:1.14 d3f8a35179eb / / (7 files in 7 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/d3f8a35179eb3a43873226c5ba4b86e0aac0ea8e 20180524 19:34:47< irker399> wesnoth: Nils Kneuper wesnoth:master 1122ea7264f7 / po/wesnoth-lib/es.po: updated Spanish translation https://github.com/wesnoth/wesnoth/commit/1122ea7264f7e920aa69af074f817cc339b2b102 20180524 19:34:49< irker399> wesnoth: Nils Kneuper wesnoth:master cb43b894eeff / / (7 files in 7 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/cb43b894eeff5fc1327a612a817bdc275762e629 20180524 19:35:12-!- Guest21317 is now known as nore 20180524 19:47:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180524 19:50:35-!- ToBeCloud is now known as ToBeFree 20180524 19:51:59< irker399> wesnoth/wesnoth:master newfrenchy83 750004e1d4 Update advancement.cpp AppVeyor: All builds passed 20180524 19:53:24-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180524 20:06:04-!- zookeeper_ [~lmsnie@95.175.104.87] has joined #wesnoth-dev 20180524 20:08:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20180524 20:14:58-!- travis-ci [~travis-ci@ec2-54-158-135-153.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 20:14:59< travis-ci> wesnoth/wesnoth#18343 (master - cb43b89 : Nils Kneuper): The build is still failing. 20180524 20:14:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383366092 20180524 20:14:59-!- travis-ci [~travis-ci@ec2-54-158-135-153.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 20:18:04<+discordbot1> travis y u do dis 20180524 20:20:46-!- Guest79491 is now known as elias 20180524 20:20:58<+discordbot1> ok really what's going on 20180524 20:21:15<+discordbot1> it are the xcode buils.... was ome file renamed? 20180524 20:21:15-!- elias is now known as Guest17822 20180524 20:22:14<+discordbot1> ./utils/travis/check_utf8.sh: line 13: isutf8: command not found 20180524 20:22:15<+discordbot1> odd 20180524 20:22:27<+discordbot1> it 20180524 20:22:31<+discordbot1> 's there 20180524 20:22:32-!- Guest17822 is now known as allefant 20180524 20:23:42< Soliton> how do you know it's there? 20180524 20:24:13< Soliton> that's not a standard tool. there is probably some package being installed that should have it though. 20180524 20:24:40<+discordbot1> we have such a file in the repo 20180524 20:25:10< Soliton> isutf8 is the thing that is missing. 20180524 20:25:14<+discordbot1> It's isutf8 that's not being found. 20180524 20:25:24< Soliton> "Install isutf8 program (from package "moreutils" at least in linux mint) in order to use this script." 20180524 20:25:46<+discordbot1> It may be a standard tool on macOS. MacOS ships with some Unix command-line tools. 20180524 20:25:47< Soliton> so perhaps that is not done or failed on osx. 20180524 20:26:03<+discordbot1> And it might have been removed in a recent update or something. 20180524 20:26:47< galegosimpatico> Mine comes from moreutils via homebrew. 20180524 20:27:00< Soliton> if "$TOOL" = "xcodebuild" then moreutils is not installed afaict. 20180524 20:27:44< galegosimpatico> From my place what I see is yarn errors, keychain errors, git clone failures... 20180524 20:34:48-!- zookeeper_ is now known as zookeeper 20180524 20:34:52-!- zookeeper [~lmsnie@95.175.104.87] has quit [Changing host] 20180524 20:34:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180524 20:35:14< galegosimpatico> Failed to download Ruby homebrew bottles... the Internet is broken, #gdpr to blame. 20180524 20:36:08-!- travis-ci [~travis-ci@ec2-54-163-45-203.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 20:36:11< travis-ci> wesnoth/wesnoth#18343 (master - cb43b89 : Nils Kneuper): The build is still failing. 20180524 20:36:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383366092 20180524 20:36:11-!- travis-ci [~travis-ci@ec2-54-163-45-203.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 20:47:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180524 20:47:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180524 21:09:11< irker399> wesnoth: Severin Glöckner wesnoth:1.14 3886afd519fe / data/campaigns/Descent_Into_Darkness/scenarios/05_Orc_War.cfg: Did S5: make campaign easier to debug https://github.com/wesnoth/wesnoth/commit/3886afd519fe9af08777ec669823074cd850dec0 20180524 21:09:13< irker399> wesnoth: Severin Glöckner wesnoth:1.14 c7cef07cc3b6 / data/campaigns/Descent_Into_Darkness/scenarios/ (08_A_Small_Favor2.cfg 09_A_Small_Favor3.cfg 10_Alone_at_Last.cfg): DiD: fix bug for units not being loyal anymore after leveling up https://github.com/wesnoth/wesnoth/commit/c7cef07cc3b6c705c139a1d3a52f35d31a9bd865 20180524 21:09:15< irker399> wesnoth: Severin Glöckner wesnoth:1.14 1e7c25a139f4 / data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg: EI S11: use same approach as in c7cef07 https://github.com/wesnoth/wesnoth/commit/1e7c25a139f48d70a3c0c96dba3a9a1a8415df1b 20180524 21:09:17< irker399> wesnoth: Severin Glöckner wesnoth:1.14 28a0547b0720 / data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg: DiD S11 & S12: transform all Mages instead of changing their advancements https://github.com/wesnoth/wesnoth/commit/28a0547b072084cedb9b0608e9eb0c306075c9a5 20180524 21:10:19<+discordbot1> I think that's a case that warrants Lua 20180524 21:12:05<+discordbot1> 28a0547? I opened the feature request above for it 20180524 21:12:53<+discordbot1> yes 20180524 21:13:30< gfgtdf> i agree your code also has the side effect of removing all obects. 20180524 21:13:51<+discordbot1> it'd be a lot shorter with Lua too 20180524 21:15:30<+discordbot1> Would surely be useful. But I never wrote lua (and the code I copied) 20180524 21:17:40< irker399> wesnoth: Severin Glöckner wesnoth:master 1315c660e73d / data/campaigns/Descent_Into_Darkness/scenarios/05_Orc_War.cfg: Did S5: make campaign easier to debug https://github.com/wesnoth/wesnoth/commit/1315c660e73d04a3ca80d11b43b52331f8b976b4 20180524 21:17:42< irker399> wesnoth: Severin Glöckner wesnoth:master 1e5816496138 / data/campaigns/Descent_Into_Darkness/scenarios/ (08_A_Small_Favor2.cfg 09_A_Small_Favor3.cfg 10_Alone_at_Last.cfg): DiD: fix bug for units not being loyal anymore after leveling up https://github.com/wesnoth/wesnoth/commit/1e5816496138ec7c5bdbf1d3a20d6a0a8ec3bd7a 20180524 21:17:43< irker399> wesnoth: Severin Glöckner wesnoth:master 0f511e8e55ac / data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg: EI S11: use same approach as in 1e58164 https://github.com/wesnoth/wesnoth/commit/0f511e8e55ac873d632366adc669266d8e5d5faf 20180524 21:17:46< irker399> wesnoth: Severin Glöckner wesnoth:master a24068ad021a / data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg: DiD S11 & S12: transform all Mages instead of changing their advancements https://github.com/wesnoth/wesnoth/commit/a24068ad021a45238d31e070ad563e98330216df 20180524 21:18:32<+discordbot1> @sevu something like this lua [lua] code = << for u in pairs(wesnoth.get_units { type = 'Dark Adept DiD, Dark Sorcerer DiD' }) do u:extract() if u.type == 'Dark Adept DiD' then u.type = 'Dark Adept' else if u.type == 'Dark Sorcerer DiD' then u.type == 'Dark Sorcerer' end u:to_recall(u.side) end >> [/lua] 20180524 21:19:50< gfgtdf> i don't think you ca set type directly, you probabyl need to call wesnoth.transform_unit (u:transform instead) 20180524 21:20:17<+discordbot1> why? 20180524 21:20:44< gfgtdf> becasue the luawml wiki says type is readonly. 20180524 21:21:00<+discordbot1> hm 20180524 21:21:08<+discordbot1> yes, the source code seems to support that 20180524 21:21:18<+discordbot1> I thought since it had been extracted it would work 20180524 21:21:52<+discordbot1> well then it's just a matter of u:transform('Dark Adept') 20180524 21:21:57< gfgtdf> ye 20180524 21:22:03< gfgtdf> extract is not like store_unit, the data is still in a unit object, not in a wml table. 20180524 21:22:51<+discordbot1> I should make type settable 20180524 21:23:02<+discordbot1> I made x,y,loc work for on-map units 20180524 21:23:14< gfgtdf> also wesnoth.get_units is onyl for on map unit, you probabbl ned wesnoth.get_recall_units 20180524 21:23:37<+discordbot1> does [store_unit] get recall units? 20180524 21:23:40<+discordbot1> by default? 20180524 21:24:28<+discordbot1> because sevu's code uses kill=yes but the comment mentions recall units 20180524 21:24:43< gfgtdf> dunno, i usually only use lua 20180524 21:25:11< gfgtdf> well you coudl make unit.type = a implement b basicially having the same effect as u:transform(a) 20180524 21:25:38<+discordbot1> ya 20180524 21:25:45<+discordbot1> @sevu what is your intent with thsi code? 20180524 21:25:55<+discordbot1> on-map units or recall units? 20180524 21:26:11<+discordbot1> only recall units - there simly exist no on map units 20180524 21:26:23< gfgtdf> the advatage woudl be that it somwhow easier to type, the advatage ot transform is that it makes it somehow clear that this is somehow a nontrivial am potentially slow operation. 20180524 21:26:37<+discordbot1> ok please try this: lua [lua] code = << for u in pairs(wesnoth.get_recall_units { type = 'Dark Adept DiD, Dark Sorcerer DiD' }) do u:extract() if u.type == 'Dark Adept DiD' then u:transform('Dark Adept') else if u.type == 'Dark Sorcerer DiD' then u:transform('Dark Sorcerer') end u:to_recall(u.side) end >> [/lua] 20180524 21:26:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20180524 21:26:57<+discordbot1> tho 20180524 21:26:58<+discordbot1> wait 20180524 21:27:02<+discordbot1> This is the same code aside from the u:transform? 20180524 21:27:17<+discordbot1> gfgtdf: do I need to extract/put to recall again if I use get_recall_units? 20180524 21:27:43< gfgtdf> i don't think so, but i am not 100% sure. 20180524 21:28:14<+discordbot1> @sevu ok could you just try this first: lua [lua] code = << for u in pairs(wesnoth.get_recall_units { type = 'Dark Adept DiD, Dark Sorcerer DiD' }) do if u.type == 'Dark Adept DiD' then u:transform('Dark Adept') else if u.type == 'Dark Sorcerer DiD' then u:transform('Dark Sorcerer') end end >> [/lua] 20180524 21:28:23<+discordbot1> if it doesn't work try the above 20180524 21:28:37<+discordbot1> (which is identical to the first except for transform and get_recall_units) 20180524 21:29:36<+discordbot1> the first one (with transform instead) didn't work.... Error is: 20180524 21:30:13<+discordbot1> [string "..."]:13 end expected to close for at line 2 20180524 21:30:53<+discordbot1> hm 20180524 21:30:57<+discordbot1> (Is there a way to get lua errors logged in stderr too?) 20180524 21:31:05<+discordbot1> try i, u in ipairs 20180524 21:31:23<+discordbot1> dunno if i used pairs right 20180524 21:31:46< gfgtdf> try 'else if' -> 'elseif' 20180524 21:32:01<+discordbot1> oh yeah 20180524 21:32:03<+discordbot1> that too 20180524 21:35:38<+discordbot1> works ! 🙀 20180524 21:35:47<+discordbot1> what's the final code that works? 20180524 21:36:13<+discordbot1> [lua] code = << for i, u in ipairs(wesnoth.get_recall_units { type = 'Dark Adept DiD, Dark Sorcerer DiD' }) do u:extract() if u.type == 'Dark Adept DiD' then u:transform('Dark Adept') elseif u.type == 'Dark Sorcerer DiD' then u:transform('Dark Sorcerer') end 20180524 21:36:13<+discordbot1> u:to_recall(u.side) end >> [/lua] 20180524 21:36:36<+discordbot1> uhm... how do you use syntax highlightling? 20180524 21:36:38<+discordbot1> it did not work sans extract/to_recall? 20180524 21:37:53< irker399> wesnoth: gfgtdf wesnoth:1.14 ad85d734a7d4 / src/scripting/game_lua_kernel.cpp: fix [animate_unit] freezing the game https://github.com/wesnoth/wesnoth/commit/ad85d734a7d43558778e1748995f1635d0c866f8 20180524 21:38:31<+discordbot1> without to_recall the units are gone 20180524 21:39:57<+discordbot1> without both it works 20180524 21:40:34< gfgtdf> ye then remove both and commit that i'd say 20180524 21:40:40-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180524 21:41:00<+discordbot1> yes remove both 20180524 21:41:12<+discordbot1> will do, also in SotA 20180524 21:44:58< gfgtdf> with that knowledge you can probaly also implement #3170 yourself 20180524 21:45:01< gfgtdf> although 20180524 21:45:16< gfgtdf> wesnoth.advance_unit will wn't work with units on the recall list 20180524 21:45:27< gfgtdf> ye so maybe not. 20180524 21:45:34<+discordbot1> ya 20180524 21:45:44<+discordbot1> this is simple enough 20180524 21:50:07-!- travis-ci [~travis-ci@ec2-54-158-135-153.compute-1.amazonaws.com] has joined #wesnoth-dev 20180524 21:50:08< travis-ci> wesnoth/wesnoth#18345 (master - a24068a : Severin Glöckner): The build was fixed. 20180524 21:50:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383410312 20180524 21:50:08-!- travis-ci [~travis-ci@ec2-54-158-135-153.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180524 21:59:45< irker399> wesnoth: Severin Glöckner wesnoth:1.14 fec9f448646f / data/campaigns/ (2 files in 2 dirs): DiD S11, Sota S18: move unit type transformation to lua https://github.com/wesnoth/wesnoth/commit/fec9f448646ff04db1e8cb0588bdfbda218596fe 20180524 22:00:07< irker399> wesnoth: Severin Glöckner wesnoth:master 51db9d01bf8c / data/campaigns/ (2 files in 2 dirs): DiD S11, Sota S18: move unit type transformation to lua https://github.com/wesnoth/wesnoth/commit/51db9d01bf8c690a0b9f74c7b254143c74056a3c 20180524 22:08:37<+discordbot1> shows the power of Lua 20180524 22:12:41<+discordbot1> i should learn to use [lua] (know just a bit) 20180524 22:14:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180524 22:32:15< irker399> wesnoth: Charles Dang wesnoth:1.14 e53b621cd512 / src/gui/dialogs/campaign_difficulty.cpp: Campaign Difficulty: colored description column gray https://github.com/wesnoth/wesnoth/commit/e53b621cd512a854d20d669eeb47edeecd0e681e 20180524 22:33:06< irker399> wesnoth: Charles Dang wesnoth:master e6183aa0d462 / src/gui/dialogs/campaign_difficulty.cpp: Campaign Difficulty: colored description column gray https://github.com/wesnoth/wesnoth/commit/e6183aa0d462c1a3e4f5a1a323b475c78a20ecaa 20180524 22:38:26< irker399> wesnoth/wesnoth:master ancestral b9df46c224 Added Redo (Ctrl/Cmd+Y) AppVeyor: All builds passed 20180524 23:05:15<+discordbot1> for #3070 ... I think the reason why anime_unit is used, is that we somehow need the information to what the unit would advance.... And it probably deals with the issue to choose one if there are multiple advancements 20180524 23:05:59<+discordbot1> *advance_unit 20180524 23:06:24< gfgtdf> yes 20180524 23:31:56<+discordbot1> From the WML perspective, the only difference beteween {ADVANCE_UNIT} (used [modify_unit] to change the type) and {TRANSFROM_UNIT} are that the later doesn't play the animation 20180524 23:38:32< gfgtdf> i don't know the wml tags, but the reason why wesnoth.advance_unit does not work with recall units is that it may want to fire events (advance, pre_advance) and wml events only work with on map units. 20180524 23:42:45<+discordbot1> @loonycyborg thoughts on this? https://forums.wesnoth.org/viewtopic.php?f=5&t=48244 20180524 23:55:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180524 23:56:12<+discordbot1> transform unit call advance_unit(unit, false, false), where the 1stfals is for animations, the last for events 20180524 23:57:03-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180524 23:59:55<+discordbot1> well, summing up, changing [transform_unit] to work on the recall list could only work if transform_to is set as well, everything else makes complications. --- Log closed Fri May 25 00:00:08 2018