--- Log opened Fri May 25 00:00:08 2018 20180525 00:00:26<+discordbot1> perhaps let's stick with our current implementation 20180525 00:00:29<+discordbot1> it's short and sweet 20180525 00:05:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180525 00:05:35-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180525 00:05:35-!- janebot_ is now known as janebot 20180525 00:12:41< celticminstrel> @ancestral please respond WRT the space hotkey. 20180525 00:14:10<+discordbot1> Agreed 20180525 00:16:20< irker399> wesnoth: Charles Dang wesnoth:1.14 38d5a7825c32 / / (7 files in 3 dirs): MP Lobby: removed manual player list sorting https://github.com/wesnoth/wesnoth/commit/38d5a7825c32d01b5e202cbc55d04d1dff3a9a24 20180525 00:16:23< irker399> wesnoth: Charles Dang wesnoth:1.14 98d39bc1078c / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/98d39bc1078ce16870f0787ae6d230200e1c1b12 20180525 00:18:15< irker399> wesnoth: Charles Dang wesnoth:master e754e64987b3 / / (7 files in 3 dirs): MP Lobby: removed manual player list sorting https://github.com/wesnoth/wesnoth/commit/e754e64987b3be3e97adebe0755f408066b2f41d 20180525 00:18:18< irker399> wesnoth: Charles Dang wesnoth:master 4300cb8263af / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/4300cb8263af283cd6c1d7baae40315474ba59dc 20180525 00:19:56<+discordbot1> celticminstrel: I was trying to test the continue hotkey, but I don't have a game that has that come up 20180525 00:20:22<+discordbot1> It’s my understanding these keys should be fine, but, the way to know would be to test 20180525 00:20:43< celticminstrel> @ancestral, space is already assigned to something else. 20180525 00:20:50<+discordbot1> To end unit turn 20180525 00:20:54< celticminstrel> Yes, exactly. 20180525 00:21:01< celticminstrel> I couldn't remember what it was called. 20180525 00:21:05<+discordbot1> But when continue shows up, shouldn't that take precedent? 20180525 00:21:11< celticminstrel> Not sure... 20180525 00:21:15<+discordbot1> Is there a mainline scenario where continue shows up in a screen? 20180525 00:21:32< celticminstrel> It only shows up if theres fog, I believe. 20180525 00:21:36< celticminstrel> ^there's 20180525 00:22:03< celticminstrel> So you could start literally any scenario with fog and move forward until you sight an enemy. 20180525 00:23:10-!- allefant is now known as elias 20180525 00:24:49<+discordbot1> I‘m not getting the "press BLAH to continue" 20180525 00:26:12< celticminstrel> Uh... 20180525 00:26:22< irker399> wesnoth: Charles Dang wesnoth:master b24de54fb90d / src/preferences/ (lobby.cpp lobby.hpp): Removed now-unused preference getters/setters https://github.com/wesnoth/wesnoth/commit/b24de54fb90de63acd4fb26e235d2f331b01ab10 20180525 00:26:39< celticminstrel> I guess, try moving as far as possible on each move? If you sight someone from the destination hex you don't get continue... 20180525 00:27:08< irker399> wesnoth: Charles Dang wesnoth:1.14 6318d66abdd4 / src/preferences/ (lobby.cpp lobby.hpp): Removed now-unused preference getters/setters https://github.com/wesnoth/wesnoth/commit/6318d66abdd4a5f8a2b73d3b327fb15c8e1165db 20180525 00:27:12< celticminstrel> Maybe you could like, debug-place a unit just outside the vision radius and then move towards it... (not sure if that would work) 20180525 00:27:30< celticminstrel> Oh right, that wouldn't work because it would be your unit... 20180525 00:28:28<+discordbot1> It’s pausing me from not going forward automatically 20180525 00:29:32<+discordbot1> Hmm 20180525 00:30:09<+discordbot1> Well 20180525 00:30:19<+discordbot1> Either I’m doing something wrong or 20180525 00:30:23<+discordbot1> I can’t use space 20180525 00:30:45< celticminstrel> Are you at least getting the "Press something to continue" prompt? 20180525 00:31:10<+discordbot1> I’m just getting the “enemy sighted!” and then the unit stop smoving 20180525 00:31:16< celticminstrel> Huh... 20180525 00:31:37< celticminstrel> So it does stop before reaching the target hex though? 20180525 00:31:55<+discordbot1> Okay, I got it to show up 20180525 00:32:00< celticminstrel> Yay! 20180525 00:32:19< celticminstrel> Does it work with space, then? 20180525 00:32:25< celticminstrel> And does it say "Press space to continue"? 20180525 00:32:52< celticminstrel> And does it end the moving unit's turn? 20180525 00:33:14<+discordbot1> Okay, I guess it is a conflict 20180525 00:33:19<+discordbot1> Darn 20180525 00:33:27< celticminstrel> Okay. 20180525 00:33:37< celticminstrel> What about enter? 20180525 00:33:43< celticminstrel> Is that used for anything else? 20180525 00:33:49<+discordbot1> No it doesn’t say “Press space” it just says “Press to continue” 20180525 00:33:54< celticminstrel> (return for Mac users) 20180525 00:33:55<+discordbot1> End unit turn 20180525 00:34:06< celticminstrel> Wasn't end unit turn assigned to space? 20180525 00:34:28<+discordbot1> I was hoping continue would take precedent 20180525 00:34:33<+discordbot1> Apparently not, so okay 20180525 00:34:36< celticminstrel> It would be nice, indeed. 20180525 00:34:51< celticminstrel> So wait, you're suggesting moving end unit turn to return and leaving continue on space? 20180525 00:35:12<+discordbot1> Well, return is set for cycle unit 20180525 00:35:22< celticminstrel> Oh, what used to be n? 20180525 00:35:27<+discordbot1> It’s also n 20180525 00:35:33< celticminstrel> Whatever. 20180525 00:35:46<+discordbot1> I believe many strategy games like Civ use return to select the next unit 20180525 00:36:11<+discordbot1> Let me think how to map continue 20180525 00:36:25< celticminstrel> I'm not sure if I like the idea of leaving the old hotkeys in... obviously it's required if we're doing this in 1.14 though. 20180525 00:36:51<+discordbot1> Maybe just c 20180525 00:36:56<+discordbot1> C for continue? 20180525 00:37:06< celticminstrel> Is C really not used anywhere else? 20180525 00:37:27<+discordbot1> Shift+C is used for create unit 20180525 00:37:33<+discordbot1> it's not required 20180525 00:37:34< celticminstrel> (At least for game hotkeys, no problem if it's used for an editor-only hotkey. :P ) 20180525 00:37:34<+discordbot1> Alt+C is used for chat log] 20180525 00:37:43< celticminstrel> Yes it is Vultraz. 20180525 00:39:36<+discordbot1> It is not required. 20180525 00:39:56< celticminstrel> Yes it is. 20180525 00:40:07<+discordbot1> No it's not 20180525 00:40:10< celticminstrel> Yes it is. 20180525 00:40:14<+discordbot1> No it's not 20180525 00:40:19< irker399> wesnoth: ancestral wesnoth:cleanup_keys f5522a832b75 / data/core/hotkeys.cfg: Changed continue to `c` https://github.com/wesnoth/wesnoth/commit/f5522a832b75602ff6ad1a2332f4521ebcc7613b 20180525 00:40:24< celticminstrel> Yes it is. 20180525 00:40:38<+discordbot1> Glad we’re all adults here. 20180525 00:42:04<+discordbot1> celticminstrel: I’m okay deprecating old keys with dev branch? 20180525 00:42:27<+discordbot1> just because it's a stable branch doesn't mean things like hotkeys can'tchange 20180525 00:42:28<+discordbot1> geez 20180525 00:42:37<+discordbot1> Well as it stands 20180525 00:42:45<+discordbot1> The keys are so dfiferent 20180525 00:42:49< celticminstrel> @ancestral IMO just remove the old hotkeys on master but leave them on 1.14. 20180525 00:42:56<+discordbot1> stable means API and we're-not-going-to-crash 20180525 00:42:56<+discordbot1> Only 6 HAVE to change 20180525 00:43:03< gfgtdf> also somehow the hotkey set is also part of the wml api: umcs [menu_item][default_hotkey] will no longer work if that hotkey now has a binding in core wesnoth. 20180525 00:43:51<+discordbot1> So I’m PR-ing to the wrong branch? 20180525 00:43:52< celticminstrel> gfgtdf: But I mean, that means it also won't work if a user has bound that hotkey, so... 20180525 00:44:03< celticminstrel> I'm not sure you can count that as "part of the API". 20180525 00:44:19< celticminstrel> The important think is that the menu item gets an entry in the hotkey prefs IMO. 20180525 00:44:21< celticminstrel> ^thing 20180525 00:45:41< irker399> wesnoth: Charles Dang wesnoth:1.14 2624bbf41959 / / (3 files in 3 dirs): Campaign Difficulty: rearranged entry layout https://github.com/wesnoth/wesnoth/commit/2624bbf41959b13e58a5ee153a65ae88605e2496 20180525 00:47:14< irker399> wesnoth: Charles Dang wesnoth:master 67530c437527 / / (3 files in 3 dirs): Campaign Difficulty: rearranged entry layout https://github.com/wesnoth/wesnoth/commit/67530c437527d525af90b484b9797dad84837d16 20180525 00:49:58<+discordbot1> ftr, the new layout is thus: 20180525 00:49:59<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/449373527015948313/unknown.png 20180525 00:50:58< celticminstrel> Thank you. 20180525 00:51:37< celticminstrel> Hmm. My only thought is, can we have the parentheses back? 20180525 00:52:04<+discordbot1> I just removed them 🤔 20180525 00:52:25<+discordbot1> but if you think it looks better with them I can add them back 20180525 00:53:51< celticminstrel> I think it might look better. 20180525 00:54:02< celticminstrel> I also think maybe the second line should be indented. 20180525 00:54:10< celticminstrel> Maybe both? 20180525 00:54:12< celticminstrel> Maybe just one? 20180525 00:54:15< celticminstrel> But at least one of those. 20180525 00:57:22< gfgtdf> i think its beter without also people can still add them in the string if they want. 20180525 00:57:35<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/449375444400209921/unknown.png 20180525 00:57:37<+discordbot1> celmin ^ 20180525 00:58:41< celticminstrel> I think that version looks good. 20180525 00:59:21< irker399> wesnoth: Charles Dang wesnoth:1.14 74833bde3982 / src/font/standard_colors.cpp: Bump font::GRAY_COLOR from #777 to #888 https://github.com/wesnoth/wesnoth/commit/74833bde39821f7b517f394d06f46d359f4756ae 20180525 00:59:24< irker399> wesnoth: Charles Dang wesnoth:1.14 01a9666acb88 / src/gui/dialogs/campaign_difficulty.cpp: Campaign Difficulty: restore the description parentheses on request https://github.com/wesnoth/wesnoth/commit/01a9666acb88baac4e7acbdff771fc5c4b53f4f1 20180525 00:59:42< gfgtdf> Vultraz: but then at least add an option not to add then, not everyoneevery addon wants gre backtes around their test in partcualar if the don't want the text to be in grex. 20180525 01:00:17< celticminstrel> I dunno. 20180525 01:00:25< irker399> wesnoth: Charles Dang wesnoth:master 47d766d3743a / src/font/standard_colors.cpp: Bump font::GRAY_COLOR from #777 to #888 https://github.com/wesnoth/wesnoth/commit/47d766d3743ad3cc1cecb04b608b3f898141f9ed 20180525 01:00:28< irker399> wesnoth: Charles Dang wesnoth:master 47bef433a96d / src/gui/dialogs/campaign_difficulty.cpp: Campaign Difficulty: restore the description parentheses on request https://github.com/wesnoth/wesnoth/commit/47bef433a96d91a7da0456213feb0c8095f39e64 20180525 01:00:30< celticminstrel> I think having the parentheses always actually makes more sense. 20180525 01:00:51<+discordbot1> In 1.12 everyone manually added parentheses 20180525 01:00:53< celticminstrel> See, the first string is a whimsical name for the difficulty. The second string is a descriptive name for the difficulty. 20180525 01:00:57<+discordbot1> in 1.14 they're automatically added 20180525 01:01:12< celticminstrel> So, putting the second in parentheses basically always makes sense. 20180525 01:01:13<+discordbot1> so you don't need to specify them 20180525 01:01:16< gfgtdf> but you cannot control their color. having for examle red text wapped by grey parentheses will look bad. 20180525 01:01:29< celticminstrel> gfgtdf: Well, that's easily solvable IMO? 20180525 01:01:40<+discordbot1> I dont want people to control the color 20180525 01:02:13< celticminstrel> ... 20180525 01:02:16< celticminstrel> Why not? 20180525 01:02:17< gfgtdf> but peole do that, iirc doofus addon did that for example to makes untested (possibly unbalanced) difficulcies 20180525 01:02:39< gfgtdf> to mark* 20180525 01:02:51< celticminstrel> (That said, if you don't like red text wrapped in grey parentheses you could use the colour only on the whimsical name...) 20180525 01:03:14<+discordbot1> because I don't want to start adding more keys to control whether parentheses are added, or what color various elements are... 20180525 01:05:29< gfgtdf> but iirc 1.12 allowed more control, in its current form the change only have disavantages for umc. 20180525 01:06:05< celticminstrel> @Vultraz - Well, a not-too-difficult way to allow colouring the parentheses would be to detect a span surrounding the entire string and insert the parentheses inside it. 20180525 01:17:42-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180525 01:38:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180525 01:39:09< irker399> wesnoth/wesnoth:1.14 Nils Kneuper d3f8a35179 updated Chinese (Simplified) translation AppVeyor: All builds passed 20180525 01:54:20-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180525 01:56:27-!- travis-ci [~travis-ci@ec2-54-161-178-88.compute-1.amazonaws.com] has joined #wesnoth-dev 20180525 01:56:28< travis-ci> wesnoth/wesnoth#18359 (1.14 - 01a9666 : Charles Dang): The build passed. 20180525 01:56:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383483082 20180525 01:56:28-!- travis-ci [~travis-ci@ec2-54-161-178-88.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180525 01:56:37-!- fabi [~fabi@200116b82b3003007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 01:56:37-!- fabi [~fabi@200116b82b3003007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 01:56:37-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 01:57:42-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 245 seconds] 20180525 01:59:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180525 02:02:20-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180525 02:03:27-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180525 02:06:00-!- fabi [~fabi@200116b82b01f7007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 02:06:00-!- fabi [~fabi@200116b82b01f7007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 02:06:00-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 02:10:15-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180525 02:11:11-!- Guest60309 is now known as nurupo 20180525 02:15:13-!- travis-ci [~travis-ci@ec2-54-158-135-153.compute-1.amazonaws.com] has joined #wesnoth-dev 20180525 02:15:14< travis-ci> wesnoth/wesnoth#18360 (master - 47bef43 : Charles Dang): The build passed. 20180525 02:15:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/383483440 20180525 02:15:14-!- travis-ci [~travis-ci@ec2-54-158-135-153.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180525 02:22:28-!- fabi [~fabi@200116b82b52b0007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 02:22:28-!- fabi [~fabi@200116b82b52b0007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 02:22:28-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 02:39:18<+discordbot1> celmin: what is the difference between pairs and ipairs if both return an element and an index? 20180525 03:09:09< celticminstrel> That's about the only thing they have in common? 20180525 03:09:20< celticminstrel> ipairs() returns the array elements in order. 20180525 03:09:30< celticminstrel> pairs() returns all elements in arbitrary order. 20180525 03:11:16<+discordbot1> ah 20180525 03:11:29<+discordbot1> so always use ipairs for tag element iteration 20180525 03:11:43< celticminstrel> Yeah, in WML tables, ipairs only covers the tags. 20180525 03:55:40-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180525 04:01:25-!- fabi [~fabi@200116b82bd2c3007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 04:01:25-!- fabi [~fabi@200116b82bd2c3007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 04:01:25-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 04:08:35-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180525 04:11:18-!- fabi [~fabi@200116b82b4095007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 04:11:18-!- fabi [~fabi@200116b82b4095007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 04:11:18-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 04:20:40-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180525 04:20:40-!- fabi_ [~fabi@200116b82bb47c007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 04:33:03-!- fabi [~fabi@200116b82b1e16007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 04:33:03-!- fabi [~fabi@200116b82b1e16007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 04:33:03-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 04:33:10-!- fabi_ [~fabi@200116b82bb47c007504bbe4add13221.dip.versatel-1u1.de] has quit [Ping timeout: 245 seconds] 20180525 04:49:54< irker399> wesnoth/wesnoth:1.14 Charles Dang e53b621cd5 Campaign Difficulty: colored description AppVeyor: All builds passed 20180525 04:52:20-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180525 04:52:27-!- fabi_ [~fabi@200116b82bb725007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 04:55:49-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180525 06:03:53-!- fabi [~fabi@200116b82ba57e007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 06:03:53-!- fabi [~fabi@200116b82ba57e007504bbe4add13221.dip.versatel-1u1.de] has quit [Changing host] 20180525 06:03:53-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 06:04:42-!- fabi_ [~fabi@200116b82bb725007504bbe4add13221.dip.versatel-1u1.de] has quit [Ping timeout: 260 seconds] 20180525 06:54:06< irker399> wesnoth/wesnoth:master ancestral ffffeae026 Changed continue to `c` AppVeyor: All builds passed 20180525 06:59:41-!- Guest4695 is now known as vincent_c 20180525 07:34:07-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180525 07:36:44-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 08:05:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180525 08:05:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180525 08:57:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180525 09:07:42< irker399> wesnoth/wesnoth:1.14 Charles Dang 01a9666acb Campaign Difficulty: restore the descrip AppVeyor: All builds passed 20180525 09:22:04-!- fabi_ [~fabi@200116b82b2156007504bbe4add13221.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 09:22:23-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180525 09:26:22-!- fabi_ [~fabi@200116b82b2156007504bbe4add13221.dip.versatel-1u1.de] has quit [Client Quit] 20180525 09:41:27-!- fabi [~fabi@200116b82b6fe800b9a75ed7fd6aae0b.dip.versatel-1u1.de] has joined #wesnoth-dev 20180525 09:41:27-!- fabi [~fabi@200116b82b6fe800b9a75ed7fd6aae0b.dip.versatel-1u1.de] has quit [Changing host] 20180525 09:41:27-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180525 10:55:11< zookeeper> any conceivable reason why the rod of justice in NR doesn't have the magical special? 20180525 10:56:58< zookeeper> or, rather, why it shouldn't have it 20180525 11:09:27< irker399> wesnoth/wesnoth:master Charles Dang 47bef433a9 Campaign Difficulty: restore the descrip AppVeyor: All builds passed 20180525 11:52:48<+discordbot1> If you don't know, probably there's no reason 20180525 11:53:22<+discordbot1> My favorit quote from grepping from it: 20180525 11:53:23<+discordbot1> "The Rod of Justice? I have never heard of it." 20180525 11:55:57<+discordbot1> " ... However, the fact remains, we much reach the Rod of Justice." Should that be must istead _much? 20180525 11:56:14< zookeeper> yes 20180525 11:57:03<+discordbot1> Note that it can't be fixed right now. We're in string freeze. 20180525 11:58:18< zookeeper> isn't pofixing possible in a string freeze? 20180525 11:59:26<+discordbot1> Ah, right. Indeed, pofix remains usable. 20180525 12:07:29< zookeeper> @Vultraz, so those difficulty menu changes have no potential for breaking any existing markup-using difficulty labels? 20180525 12:21:56<+discordbot1> NR S5b: "Note: The work on this branch of the campaign is in progress." 20180525 12:32:33< irker399> wesnoth: ln-zookeeper wesnoth:1.14 e161dab24b72 / data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg: NR: Gave the Rod of Justice the magical special and improved animation https://github.com/wesnoth/wesnoth/commit/e161dab24b7299f463423d45f1ea29e47f87338e 20180525 12:34:01< irker399> wesnoth: ln-zookeeper wesnoth:master 8b467104bf4c / data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg: NR: Gave the Rod of Justice the magical special and improved animation https://github.com/wesnoth/wesnoth/commit/8b467104bf4caeac8a8afd6217ec0bbe689a22e7 20180525 13:13:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180525 13:25:33<+discordbot1> @zookeeper it won’t break but it won’t look good 20180525 13:25:34<+discordbot1> 1.12 basically gave you the ability to set the string to whatever you want how you want 20180525 13:26:21<+discordbot1> In 1.14 I made it so parentheses are automatically added around text 20180525 13:26:34<+discordbot1> And now there’s automatic formatting applied to the entire string 20180525 13:27:12<+discordbot1> So as gfgtdf said if people tried to color them they’d get gray parentheses around their different color text 20180525 13:27:14<+discordbot1> But meh 20180525 13:27:22<+discordbot1> I don’t really want people formatting that text anyway 20180525 13:51:41< Ravana_> what you think about adding WML tag for reading file? something like: function wesnoth.wml_actions.read_file(cfg) wml.variables[cfg.variable or "file"] = wesnoth.read_file(cfg.name) end 20180525 13:52:08<+discordbot1> Why? 20180525 13:52:44< Ravana_> just to not require either directly using Lua or preprocessing entire file into WML 20180525 13:53:12<+discordbot1> why not use lua? 20180525 13:53:17<+discordbot1> we want to encourage more use of lua 20180525 13:53:58<+discordbot1> personally, all lua I use is behind WML tags. 20180525 13:56:22<+discordbot1> though my entire add-on is about persistent WML variables and a giant [message]/[option] menu, so I may be the outlier in that. 20180525 13:56:54<+discordbot1> I do that too 20180525 13:56:58<+discordbot1> and shadowm does that 20180525 13:57:29<+discordbot1> i think most people do that 20180525 13:57:37<+discordbot1> but really, i don't see the use of such a tag here 20180525 13:57:40-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180525 13:58:54<+discordbot1> read_file also doesn't always read the contents of a file, so there's that 20180525 13:59:27<+discordbot1> "If the path is a directory, this instead returns an array of the directory contents, with directories first, followed by files. The special key ndirs contains the number of directories." 20180525 13:59:46< Ravana_> if such tag had existed I would not have created changelogs as including 0.3mb of text to addon WML https://i.imgur.com/RCusgL3.png 20180525 14:01:59<+discordbot1> @Ravana Couldn't you have written the WML tag yourself though? 20180525 14:02:18< Ravana_> well, no, because it is 1.13.5+ 20180525 14:03:20< Ravana_> recently I made such tag, and I think it could be useful for others too https://github.com/ProditorMagnus/Ageless-for-1-14/blob/master/lua/preload.lua#L36 20180525 14:19:04<+discordbot1> @Ravana .....what? "because it is 1.13.5+"? 20180525 14:19:25< Ravana_> yes, I wrote that code before 20180525 14:19:33<+discordbot1> we're in 1.14.1! 20180525 14:19:38<+discordbot1> I see 20180525 14:20:05<+discordbot1> so change it now 20180525 14:25:17-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 256 seconds] 20180525 14:27:14-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev 20180525 14:29:39<+discordbot1> Why was this spider portrait added... Ugh.... 20180525 14:29:50<+discordbot1> Is it bad? 20180525 14:29:55<+discordbot1> scary 20180525 14:30:22<+discordbot1> I just saw a big spider on the left bottom edge of my laptop 20180525 14:30:28<+discordbot1> Heh 20180525 15:14:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180525 15:16:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180525 15:25:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180525 15:26:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180525 15:31:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180525 15:34:27-!- irker399 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180525 15:46:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180525 15:47:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180525 16:13:27-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180525 16:16:43-!- DeFender1031 [~DeFender1@89-138-79-9.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180525 17:04:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180525 17:10:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180525 17:19:08-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 256 seconds] 20180525 17:21:10<+discordbot1> Anyone who knows Lua could tell me why the condition in if o.value:match('^[0-9]+%.([0-9]+%.)*x$') then never holds true when o.value is "1.14.x"? 20180525 17:25:27<+discordbot1> Try removing the asterisk. 20180525 17:26:11<+discordbot1> Lua's pattern engine doesn't have full regex support. From what I can tell from the documentation, * can apply only to a character class, not to a capture. 20180525 17:26:21<+discordbot1> Ohhhh. 😐 20180525 17:26:59<+discordbot1> That's greatly disappointing. 20180525 17:27:02<+discordbot1> And yeah it works, thanks. 20180525 17:49:30-!- irker765 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180525 17:49:30< irker765> wesnoth: Severin Glöckner wesnoth:1.14 a45d8a964888 / data/campaigns/Northern_Rebirth/ (7 files in 2 dirs): NR Path B: https://github.com/wesnoth/wesnoth/commit/a45d8a9648886c2a59e6cd47b219fe61d5394297 20180525 17:50:50< irker765> wesnoth: Severin Glöckner wesnoth:master cca5b6f77608 / data/campaigns/Northern_Rebirth/ (7 files in 2 dirs): NR Path B: https://github.com/wesnoth/wesnoth/commit/cca5b6f77608bdb11865e57fa944b1240ca1e938 20180525 18:19:14< Ravana_> I see that ABILITY_LEADERSHIP uses undocumented feature of using formula in value. Can this behaviour be relied on? 20180525 18:20:16<+discordbot1> I think so. In general, formulae can be used almost anywhere. 20180525 18:34:19< irker765> wesnoth: Severin Glöckner wesnoth:1.14 3592c09b686e / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: make villages unattractive https://github.com/wesnoth/wesnoth/commit/3592c09b686e81887cdf87f66ad718a618787482 20180525 18:35:03< irker765> wesnoth: Severin Glöckner wesnoth:master c0d6d4ed944e / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: make villages unattractive https://github.com/wesnoth/wesnoth/commit/c0d6d4ed944ed11fef788778c332fd91362e3a2a 20180525 18:37:26< Ravana_> seems that value must be surrounded with () to be considered formula 20180525 18:41:10< Ravana_> and / is used as integer division 20180525 18:51:10< irker765> wesnoth: Severin Glöckner wesnoth:1.14 bf792a959f3f / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: compensate -1 income with +1 support https://github.com/wesnoth/wesnoth/commit/bf792a959f3f730645710cc6c31bb9e3a4e1b8c6 20180525 18:51:34< irker765> wesnoth: Severin Glöckner wesnoth:master 9f37896f32ea / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: compensate -1 income with +1 support https://github.com/wesnoth/wesnoth/commit/9f37896f32ea34fa77e5035494ecc4565b673195 20180525 19:15:53< irker765> wesnoth/wesnoth:1.14 ln-zookeeper e161dab24b NR: Gave the Rod of Justice the magical AppVeyor: All builds passed 20180525 19:16:05<+discordbot1> can any one explain where the code to spawn an enemy leader goes? In my scenario no enemy leader spawns like I want it to and it just insta wins the game 20180525 19:16:58< zookeeper> directly in the [side] tag, usually 20180525 19:18:32< zookeeper> if the map has a starting position for that side, all that you need is a type= key, the rest is optional. 20180525 19:46:15<+discordbot1> aight got it working 20180525 19:46:46<+discordbot1> now I need to make it perpetually night and lock the enemy into one faction 20180525 19:48:51< zookeeper> @sinda, perhaps an iOS-specific bug: https://forums.wesnoth.org/viewtopic.php?f=3&t=48243 20180525 19:54:06<+discordbot1> For th perpetual night, you can just delete all other times from the standard-code 20180525 19:54:19<+discordbot1> or use {underground} instead 20180525 20:01:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180525 20:01:51-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180525 20:01:51-!- janebot_ is now known as janebot 20180525 20:02:18<+discordbot1> where'd I place {underground}? 20180525 20:03:25<+discordbot1> Where you playe the daycycle 20180525 20:03:30<+discordbot1> it substitutes for it 20180525 20:15:06-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180525 20:19:38-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 260 seconds] 20180525 20:21:29<+discordbot1> @zookeeper, thanks. Handling it. 20180525 20:21:48< zookeeper> @sinda, so to clarify, i couldn't reproduce it on windows. 20180525 20:23:34<+discordbot1> On the latest 1.14? 20180525 20:24:13< zookeeper> on a pretty recent 1.14.1+ build. but i'm pretty sure that bug has not existed in 1.14 at any point. 20180525 20:25:57<+discordbot1> Hm. There was a moment when I had to update Lua configuration in iOS, but I think his fix was published already. I need to check iOS release history. 20180525 20:34:51<+discordbot1> thanks @SaloGhost , got it running 20180525 20:42:56-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180525 20:43:53< vn971> Is it a knowh bug when wesnoth client hangs when attempting to observe a particular game? 20180525 20:44:30< vn971> It's "reproducible": happens each time I observe a game now played in MP server. 20180525 20:44:42< vn971> happened just now under gdb. 20180525 20:45:31< vn971> CPU usage is low, so it's "not a loop". 20180525 20:46:39< Ravana_> which game? 20180525 20:46:47< vn971> Game in question is "Falco's game", Afterlife map, Ageless Era, two add-ons. 20180525 20:46:51< vn971> Ravana_: ^ 20180525 20:48:10< Ravana_> nice 20180525 20:48:16< vn971> happens on turn 6, actually pretty fast to get to the hanging point. 20180525 20:48:25< Ravana_> it has the symptoms of query_location issue 20180525 20:48:45< Ravana_> also https://github.com/wesnoth/wesnoth/issues/3028 20180525 20:49:12< Ravana_> it is not entirely stuck, you can use rightclick to force redraw 20180525 20:49:49< vn971> Ravana_: indeed. 20180525 20:50:18< Ravana_> it seems to start happening when something does 2 damage 20180525 20:50:55< Ravana_> bleeding it seems 20180525 20:52:04< irker765> wesnoth/wesnoth:master ln-zookeeper 8b467104bf NR: Gave the Rod of Justice the magical AppVeyor: All builds passed 20180525 20:52:16<+discordbot1> a reliable way to reproduce it sounds like a good thing to add to that bug report. 20180525 20:53:22< vn971> Pentarctagon: problem is: it only reproduces now while the game is active. If it disappears from MP, I'm not sure it'll be the same with a replay. After all, players don't seem to notice anything bad, they're on turn 15+ now (bug is on turn6). 20180525 20:53:45< Ravana_> problem does not happen if I have quick replays off 20180525 20:54:32< vn971> so anyone interested probably has to check right now, or it'll go away. I've actually seen this once already (don't remember why I couldn't raise issue at that time). 20180525 20:54:32<+discordbot1> vn971: perhaps it could be rehosted from an earlier turn save? 20180525 20:55:39< vn971> @Pentarctagon: maybe? IDK. 20180525 20:55:50< vn971> But now it's the best chance to investigate this, it seems. 20180525 20:56:47< vn971> UPD: OK, not anymore, game neded anyway. My hung wesnoth client inside gdb is still open. 20180525 20:58:16< Ravana_> https://i.imgur.com/EoblSFs.jpg I have whatever it offered to save at that point 20180525 20:58:52< Ravana_> I use newer EoMa version though, so I had oos that I ignored, no idea if that affects save 20180525 21:00:19< vn971> On another topic. I also see this in lobby user list: https://pointsgame.net/vn971/temp/2018.05.25_23:59:24_1be4c3a.png 20180525 21:00:51< Ravana_> https://github.com/wesnoth/wesnoth/issues/2989 20180525 21:04:47< vn971> Ok, gotta sleep now. Nice weekend, thanks for listening. 20180525 21:14:41-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Quit: I'll Be Back!] 20180525 21:14:51-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev 20180525 21:24:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180525 21:25:46-!- gfgtdf [~chatzilla@x4e3633e0.dyn.telefonica.de] has joined #wesnoth-dev 20180525 21:26:29< gfgtdf> vn971: if you are using 'quick replays' and you are using wesnoth 1.14.1 then yes 20180525 21:27:17< Ravana_> I used 1.14.0 and with quick replays it happened 20180525 21:28:42< gfgtdf> ye i basicially meant 'not using latest 1.14+dev' 20180525 21:31:28< gfgtdf> Ravana_: also yes, formula in abilitires value is supported, in both abilitites ansd weapon specials iirc 20180525 21:32:36< Ravana_> is it documented anywhere (where and what variables are available)? 20180525 21:33:56< gfgtdf> 'other' and trhe lua self variable (both units) seem to be te oynl suportd sceoped varaibles, and no it's not yet documented afaik 20180525 21:34:16< gfgtdf> you can look in the code though https://github.com/wesnoth/wesnoth/blob/master/src/units/abilities.cpp#L502 20180525 21:36:07-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180525 21:49:52< irker765> wesnoth: gfgtdf wesnoth:1.14 7fd8755385f9 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/7fd8755385f980a1f564dd118dd655144b19bc30 20180525 21:56:43< irker765> wesnoth: gfgtdf wesnoth:1.14 bd9864ad5466 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/bd9864ad5466692e7ec55a6923e1d5645a5b0567 20180525 22:13:02-!- travis-ci [~travis-ci@ec2-54-147-5-167.compute-1.amazonaws.com] has joined #wesnoth-dev 20180525 22:13:03< travis-ci> Pentarctagon/wesnoth#44 (goblin-spearman-desc - 3494926 : Pentarctagon): The build passed. 20180525 22:13:03< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/383895416 20180525 22:13:03-!- travis-ci [~travis-ci@ec2-54-147-5-167.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180525 22:31:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180525 22:35:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180525 23:13:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180525 23:15:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180525 23:34:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180525 23:49:35-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180525 23:49:54<+discordbot1> This is a mess: https://pastebin.com/RPYg4bGZ 20180525 23:50:56<+discordbot1> --log-debug=filesystem isn't telling me how on Earth the game arrived to this stupid decision? 20180525 23:51:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180525 23:52:51<+discordbot1> Okay, so apparently --config-dir expects an absolute path. 20180525 23:53:07<+discordbot1> Or a path relative to the home dir instead of cwd. 20180525 23:53:52<+discordbot1> So the correct invocation turns out to be wesnoth-1.14 --config-dir \readlink -e .`` 20180525 23:55:33< celticminstrel> That's kinda silly... 20180525 23:56:24< Ravana_> I reported that in https://github.com/wesnoth/wesnoth/issues/2000 --- Log closed Sat May 26 00:00:09 2018