--- Log opened Thu May 31 00:00:45 2018 20180531 00:02:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 00:14:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180531 00:22:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 00:22:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 00:36:56< mattsc> When there’s an anticipated release date, where can I look that up these days? (I’m talking about what used to be in the irc dev channel topic.) 20180531 00:45:22< irker203> wesnoth: loonycyborg wesnoth:1.14 8a1d50799e13 / SConstruct: Enable ASLR and NX bit security features for mingw builds https://github.com/wesnoth/wesnoth/commit/8a1d50799e137ffbc468609f41bee8509f314e3f 20180531 00:59:59-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180531 01:01:08< celticminstrel> mattsc: Honestly I think the easiest way is probably just to bug Vultraz about it... but it might also be on Discord somewhere? 20180531 01:02:18< mattsc> Well, I’m also logged in to Discord at the moment, but have not found it yet, that’s why I’m asking. 20180531 01:02:39< celticminstrel> @Vultraz ^ 20180531 01:04:18< mattsc> So I’d like to know whether I am too stupid to find it, or whether there is no announcement at the moment. :) 20180531 01:05:47-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180531 01:10:27<+discordbot4> We don't have one right now. 20180531 01:10:34<+discordbot4> At least as far as I know. 20180531 01:11:56< mattsc> Okay. That means I have time to get my MAI optimization patch worked on … 20180531 01:12:10< mattsc> Where would it be if there were one though? 20180531 01:14:16<+discordbot4> @mattsc here on discord in the channeltopic 20180531 01:15:09< mattsc> @Vultraz. Okay. And where’s the channel topic. :P The thing that just says ‘#development’ right now? 20180531 01:15:25<+discordbot4> underneath that, yes 20180531 01:15:41< mattsc> Okay, cool. Thanks. 20180531 01:16:20<+discordbot4> well, next to it 20180531 01:16:23<+discordbot4> just set a date for 1.14.3 20180531 01:16:30< mattsc> I thought I had seen something along those lines before, but could not find it any more. I there just isn’t anything right this moment, ... 20180531 01:16:33< mattsc> Ooo, there it is. 20180531 01:17:01< mattsc> May 10th? 2019? ;) 20180531 01:17:55<+discordbot4> 2020 😛 20180531 01:18:15< mattsc> Good. Lots of time. 20180531 01:18:24< mattsc> But you might want to change May -> June anyway. 20180531 01:18:48<+discordbot4> .....oops 20180531 01:18:49<+discordbot4> 😬 20180531 01:25:12-!- irker203 [~irker@uruz.ai0867.net] has quit [Ping timeout: 260 seconds] 20180531 01:34:51< celticminstrel> XD 20180531 01:35:04< celticminstrel> (Would be nice if someone also did it on the IRC side.) 20180531 01:54:08-!- irker723 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180531 01:54:08< irker723> wesnoth/wesnoth:master Byteron 7f2a8f7c19 TSG: Deoran can't recruit Peasants anymo AppVeyor: All builds passed 20180531 01:55:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 02:15:39< celticminstrel> Anyone know how to get the backtrace information after a pcall error? Is it even possible? I know the error object is returned by pcall but AFAIK there's no guarantee that it's anything other than a string. 20180531 02:16:00< celticminstrel> A string is fine though, as long as the backtrace can somehow also be found... 20180531 02:38:35<+discordbot4> wml variables need a pipe if not followed by a space right 20180531 02:39:32<+discordbot4> ie side_$SIDE_turn_$TURN needs to be side_$SIDE|_turn_$TURN 20180531 02:40:30<+discordbot4> (this is for a c++ change but I'm assuming the semantics of using interpolate_variables_into_string is the same) 20180531 02:40:47<+discordbot4> Yes, unless the variable you mean to evaluate is the one whose name is the result of evaluating the concatenation of side_ and $SIDE_turn_$TURN. 20180531 02:41:20<+discordbot4> (Do the same logic recursively for the latter.) 20180531 02:42:06-!- fabi_ [~fabi@200116b82b738e00d88e2aeed76c55f9.dip.versatel-1u1.de] has joined #wesnoth-dev 20180531 02:42:41-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 276 seconds] 20180531 02:43:45<+discordbot4> but with spaces the pipe isn't necessary, yes? 20180531 02:43:57<+discordbot4> Spaces cannot be part of WML variable names. 20180531 02:44:44<+discordbot4> ok, good 20180531 02:44:45<+discordbot4> thanks 20180531 02:47:30<+discordbot4> as for what I'm doing, I'm switching from string constants for hardcoded event names to an enum to provide stricter validation to guard against accidental event names changes. 20180531 02:48:54<+discordbot4> or typos 20180531 02:49:46<+discordbot4> (ie, imagine someone comes along and says, "ok, I want the code to fire a moveto event..." but they use the string "move to". Bam. event doesn't fire.) 20180531 02:50:52<+discordbot4> (on the engine side) 20180531 03:14:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 03:18:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 03:20:33< celticminstrel> @Vultraz Technically, they only need a pipe if followed by a letter, number, underscore, period, or square bracket. 20180531 03:30:53< celticminstrel> (I guess the usual vgettext function takes a map instead of a config as arguments so you can't actually have subvariables, but you'd still need a pipe anyway if there's a dot or bracket.) 20180531 03:30:57<+discordbot4> I'm leaving the names spaced 20180531 03:31:10< celticminstrel> ??? 20180531 03:31:15<+discordbot4> "side $SIDE turn $TURN refresh" 20180531 03:31:20< celticminstrel> Ah, sure. 20180531 03:34:08<+discordbot4> hmm 20180531 03:34:19<+discordbot4> what's a better name than "standard_event" for the enum 20180531 03:34:24<+discordbot4> game_events::standard_event:: is a pretty long and redundant prefix 20180531 03:36:37<+discordbot4> "standard"? 20180531 03:36:40<+discordbot4> "presets"? 20180531 03:36:59<+discordbot4> "type"? 20180531 03:37:33<+discordbot4> what does celmin think 20180531 03:45:51< celticminstrel> I think I need more context. 20180531 03:46:18<+discordbot4> I have an enum class named standard_event in the game_events namespace 20180531 03:46:27< celticminstrel> And, what's it for? 20180531 03:46:45<+discordbot4> it lists all the predefined game event names 20180531 03:46:49< celticminstrel> Hmm. 20180531 03:47:06<+discordbot4> for example,game_events::standard_event::preload 20180531 03:47:31< celticminstrel> So custom events don't go through it at all, or do they go into a catch-all at the bottom? 20180531 03:47:47<+discordbot4> former. 20180531 03:48:00<+discordbot4> custom events are just strings 20180531 03:48:03< celticminstrel> Do you use it only when firing the event or also when adding an event? 20180531 03:48:06<+discordbot4> event names* 20180531 03:48:24< celticminstrel> Curious how it works for the X+Y events too. 20180531 03:48:33< celticminstrel> I see you're using the interpolation for it but... 20180531 03:48:37<+discordbot4> firing, since that's really the only place the string constants are used. 20180531 03:49:00< celticminstrel> I guess you actually couldn't use it for adding the event because variable interpolation doesn't take place until the event is fired, usually, right? 20180531 03:49:23<+discordbot4> so the X+y would be, for example, std::string event = game_events::standard_event::side_X_turn_Y_refresh and then you interpolate your TURN and SIDE variables. 20180531 03:49:43<+discordbot4> (i used the nomenclature from the wiki) 20180531 03:49:48< celticminstrel> So it's directly convertible to string, huh. 20180531 03:49:56< celticminstrel> BTW, there's also the "menu item $ID" event. 20180531 03:49:59<+discordbot4> er, actuall, no 20180531 03:50:23< celticminstrel> Well anyway you were asking for a name... 20180531 03:50:25<+discordbot4> forgot you need game_events::get_event_name(game_events::standard_event::side_X_turn_Y_refresh) 20180531 03:50:40< celticminstrel> game_events::builtin_t maybe? 20180531 03:50:41<+discordbot4> enums don't have conversion operators 20180531 03:51:07<+discordbot4> would actually be a useful feature, though 20180531 03:51:11<+discordbot4> 🤔 20180531 03:51:17< celticminstrel> I guess the way it's used makes it more like a namespace than a type though... 20180531 03:51:25<+discordbot4> yes 20180531 03:51:28<+discordbot4> maybe just builtin? 20180531 03:51:35< celticminstrel> Actually would it maybe be better to just make it a namespace full of string variables? 20180531 03:52:15< celticminstrel> I don't think I like "builtin" or "standard" or "preset" as a type name, and _t is a standard prefix meaning "this is a type", so... 20180531 03:52:24 * celticminstrel shrug 20180531 03:53:32<+discordbot4> free-standing implicit conversion operators that take an enum member aren't allowed, right? 20180531 03:53:58< celticminstrel> Sorry what? 20180531 03:54:36<+discordbot4> ie, operator std::string(const enum_t foo) { do something with foo that returns a string } in the global namespace 20180531 03:55:45< celticminstrel> Ah yeah conversion operators can only be defined in a class. The operators that could work for an enum conversion operator are ! & ~ * 20180531 03:56:08< celticminstrel> Though & is obviously out of the question, and ~ would be really weird, so that leaves ~ or * if you really want a conversion operator. 20180531 03:57:13< celticminstrel> Sorry, ! is the one that would be really weird. 20180531 03:57:20<+discordbot4> I could use << 20180531 03:57:22<+discordbot4> 🤔 20180531 03:57:31< celticminstrel> Personally I like * for getting rich data out of enums, though there's no precedent in Wesnoth for it. 20180531 03:57:46< celticminstrel> Well, << means you need two parameters, but yes, perhaps you could think of a way to make that make sense. 20180531 03:58:14<+discordbot4> how would * work? 20180531 03:58:33< celticminstrel> * is the indirection operator. 20180531 03:58:37< celticminstrel> So, *your_enum 20180531 03:58:44< celticminstrel> Maybe you thought I meant multiplication? 20180531 03:59:02< celticminstrel> The reason & is out of the question is because it's the address-of operator (I wasn't suggesting bitwise and). 20180531 03:59:24< celticminstrel> ~ is bitwise not, and ! is logical not. 20180531 04:00:36<+discordbot4> so I could define std::string operator*(const enum_t foo)? that seems weird... 20180531 04:00:55< celticminstrel> There are reasons to overload the address-of operator, but they are extremely few and far between... and yes you could totally do that. 20180531 04:01:19<+discordbot4> oddddd 20180531 04:01:21< celticminstrel> I've done exactly that for a lot of enums in some personal projects. 20180531 04:01:30< celticminstrel> I only wish I could use -> instead. 20180531 04:02:01< celticminstrel> Since my enum operator* functions all return structs. 20180531 04:03:58<+discordbot4> this is very interesting... 20180531 04:04:18< celticminstrel> FTR -> is one of the operators that is only permitted to be defined inside a class. 20180531 04:04:32< celticminstrel> Along with [] and () and type conversion operators and I think there might be one other... 20180531 04:04:47< celticminstrel> Oh assignment. 20180531 04:04:58< celticminstrel> Augmented assignment (eg +=) can be global though. 20180531 04:05:07< celticminstrel> And ++ and -- too. 20180531 04:05:25< celticminstrel> Even ->* can be global IIRC? 20180531 04:06:16<+discordbot4> are you sure operator* takes 1 argument 20180531 04:06:18< celticminstrel> Oh there's also an unary operator + which can be overloaded, I believe, that can probably be global too... (but probably isn't appropriate here). 20180531 04:06:23< celticminstrel> Yes I'm sure it takes one argument. 20180531 04:06:45< celticminstrel> I mean you can define it with two as well, both forms are allowed, but then you need to write a*b instead of *x. 20180531 04:07:34< celticminstrel> AFAIK the only operators that can't be overloaded are , and ?: ( and :: if you count that, it's a bit questionable though). 20180531 04:07:44< celticminstrel> That was supposed to be a dot not a comma. 20180531 04:07:52<+discordbot4> I wonder about <=> 20180531 04:07:57< celticminstrel> Doesn't exist. 20180531 04:08:00<+discordbot4> it does 20180531 04:08:02<+discordbot4> in 20 20180531 04:08:08< celticminstrel> Oh. 20180531 04:08:20<+discordbot4> http://en.cppreference.com/w/cpp/language/operator_comparison#Three-way_comparison 20180531 04:08:35< celticminstrel> I remember overloading operator. was talked about too, that isn't in a standard yet though is it? 20180531 04:09:02< celticminstrel> Ooh nice they're bringing in C99 designated initializers! I loved that feature. 20180531 04:09:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 04:10:24<+discordbot4> struct { .f = f }?` 20180531 04:10:36< celticminstrel> Uhh, that's not really a good way to put it? 20180531 04:10:48<+discordbot4> I mean is that what you're referring to 20180531 04:10:54<+discordbot4> the .f = f part 20180531 04:10:57<+discordbot4> in initilization 20180531 04:11:00< celticminstrel> If you have struct Thing {int f;}; then it means you can writ Thing x {.f = 5}; 20180531 04:11:02< celticminstrel> ^write 20180531 04:11:08<+discordbot4> yeah that 20180531 04:11:19< celticminstrel> And it also means that you can write char stuff[22] {[5] = 'g'}; 20180531 04:11:24<+discordbot4> mentioned that the other day 20180531 04:11:30< celticminstrel> ie it works for structs and arrays. 20180531 04:11:33<+discordbot4> it's actually something I've looked for twice now 😛 20180531 04:11:38-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180531 04:11:49< celticminstrel> I should probably have included an = in there since I'm technically describing the C99 feature. 20180531 04:11:57< celticminstrel> Which doesn't have the =-less initializers. 20180531 04:12:18< celticminstrel> I don't know for sure if the C++ proposal is identical... I'd expect it to be, for compatibility, but I can't be 100% certain. 20180531 04:12:21<+discordbot4> apparently that thing i tried the other day with non-complete aggregate initialization isn't supported in the standard, but only in MSVC 20180531 04:12:57<+discordbot4> but we're getting designated initializers in 20 so it's basically that 20180531 04:13:04< celticminstrel> Well no it's a little different? 20180531 04:13:14<+discordbot4> syntax-wise 20180531 04:13:17<+discordbot4> but it does what I wanted 20180531 04:13:19< celticminstrel> I think you can actually mix designated and positional initializers. 20180531 04:13:45<+discordbot4> foo_t bar { .f = 0 } means any member besides f is default-initialized 20180531 04:14:08< celticminstrel> Like if you have struct Thing {int a,b,c; float x,y,z}; you could write Thing m {1,2,3, .z = 4.5}; 20180531 04:14:19<+discordbot4> can you? 20180531 04:14:22< celticminstrel> And a,b,c would be 1,2,3, x,y would be 0, and z would be 4.5. 20180531 04:14:25< celticminstrel> I think. 20180531 04:14:30< celticminstrel> Not 100% sure, but I think that does work. 20180531 04:14:50< celticminstrel> In C99 at least. 20180531 04:15:01< celticminstrel> GCC lets you use it in C++ as a nonstandard extension. 20180531 04:15:15< celticminstrel> And clang too of course, because they want to be GCC-compatible. 20180531 04:15:33<+discordbot4> "Note: out-of-order designated initialization, nested designated initialization, mixing of designated initializers and regular initializers, and designated initialization of arrays are all supported in the C programming language, but are not allowed in C++." 20180531 04:15:47<+discordbot4> 😦 20180531 04:15:49< celticminstrel> Well that's not very nice. Oh well. 20180531 04:16:04< celticminstrel> The last one is really not nice at all. 20180531 04:16:07<+discordbot4> i mean who knows, the 20 standard isn't ratified 20180531 04:16:21< celticminstrel> True, but leaving out arrays IMO is pretty stupid. 20180531 04:16:32< celticminstrel> Maybe they're trying to encourage not using arrays, but... 20180531 04:16:44<+discordbot4> they'll probably add it in 23 🙄 20180531 04:17:07<+discordbot4> the committee always leaves out obvious stuff only to add it later 20180531 04:17:13< celticminstrel> VS2015 has the experimental modules, huh? Weird. 20180531 04:17:16<+discordbot4> see also: std::make_unique 20180531 04:17:30< celticminstrel> Are they seriously considering reflection... is that even possible... 20180531 04:17:40<+discordbot4> oh? 20180531 04:17:41<+discordbot4> where 20180531 04:17:52< celticminstrel> This is where I'm looking https://en.wikipedia.org/wiki/C%2B%2B20 20180531 04:18:10< celticminstrel> Sounds like they're giving concepts another try, too. 20180531 04:18:30< celticminstrel> I wonder if they'll use a version with axioms. Those looked kinda cool but I dunno. 20180531 04:18:54< celticminstrel> IIRC they were only in older drafts. 20180531 04:19:18< celticminstrel> (it was basically a way to formalize eg the equivalence between a==b and !(a!=b)) 20180531 04:19:49<+discordbot4> I dunno why the committee always seems to add stuff that's cool and then leave out half of it 20180531 04:19:56< celticminstrel> But TBH I don't know what most of the stuff listed there is. 20180531 04:20:03<+discordbot4> or define it in such a way that it can be unusable 20180531 04:20:09<+discordbot4> see also: std::filesystem 20180531 04:20:23< celticminstrel> Only really interesting thing TBH is the designated initializers, and I can already use those anyway since I use clang. 20180531 04:20:33< celticminstrel> ...stupid underline coming out of nowhere. 20180531 04:20:43<+discordbot4> hehe 20180531 04:20:45< celticminstrel> (BTW does Discord have underline? Can you see my underlines?) 20180531 04:20:53<+discordbot4> I saw it 20180531 04:21:00< celticminstrel> What about bold? 20180531 04:21:04<+discordbot4> saw it 20180531 04:21:07< celticminstrel> Yay. 20180531 04:21:16<+discordbot4> btw 20180531 04:21:27<+discordbot4> the VS people fixed that bug with the dispatcher template type 20180531 04:21:31<+discordbot4> based on my report 20180531 04:21:32< celticminstrel> No, italics is not next. The IRC de-facto CTCP doesn't support italics for some reason. 20180531 04:21:46< celticminstrel> Niiiice! :O 20180531 04:22:09< celticminstrel> So wait, std::filesystem isn't in C++17? 20180531 04:22:29<+discordbot4> it is 20180531 04:22:39< celticminstrel> So why'd you bring it up? 20180531 04:23:03<+discordbot4> https://developercommunity.visualstudio.com/content/problem/251213/stdfilesystemfile-time-type-does-not-allow-easy-co.html 20180531 04:23:16<+discordbot4> the standard makes it possible for this to arise 20180531 04:23:39<+discordbot4> if the compiler doesn't implement file_time_type as system_clock 20180531 04:23:48<+discordbot4> and if they don't it renders last_write_time useless 20180531 04:24:12< celticminstrel> I'm sure there's still some way to convert it... 20180531 04:24:33<+discordbot4> and I know the committee realized this because they addressed file_time_type definition in 20 20180531 04:25:03<+discordbot4> from implementation-defined to a specific type with conversion to system_clock 20180531 04:26:20< celticminstrel> Anyway need to sleep 20180531 04:26:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180531 04:26:28<+discordbot4> indeed 20180531 04:33:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 04:33:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180531 05:12:04<+discordbot4> file_time_type would be possible to convert to other types if its epoch and tick rate were documented. 20180531 05:12:20<+discordbot4> But the standard doesn't require implementations to document them either... 20180531 05:17:13<+discordbot4> I've discovered two undocumented events 🤔 20180531 05:18:05<+discordbot4> What are they called? 20180531 05:18:54<+discordbot4> local_victory and local_defeat 20180531 05:19:13<+discordbot4> they seem to be unsynced versions of victory and defeat 20180531 05:30:53-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180531 05:37:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 05:37:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 05:43:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180531 05:46:37-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 244 seconds] 20180531 05:53:03-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180531 06:21:46-!- gallaecio [~quassel@220.red-79-150-211.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180531 06:22:15< irker723> wesnoth: Pentarctagon wesnoth:master d913aafc534c / data/core/units/ (dunefolk/Wyvern_Rider.cfg monsters/Jinn.cfg monsters/Wild_Wyvern.cfg): Add a couple missing things from the PR that added the units. https://github.com/wesnoth/wesnoth/commit/d913aafc534ccaeb239cc910bd963893e313fdcf 20180531 06:23:15<+discordbot4> @Vultraz Any objection if I merge https://github.com/wesnoth/wesnoth/pull/3175 into master and 1.14? 20180531 06:24:20-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 244 seconds] 20180531 06:46:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 06:47:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 06:47:55<+discordbot4> looks alright 20180531 06:50:01< irker723> wesnoth: Pentarctagon wesnoth:master 0b7ca63a8615 / data/core/units/goblins/Spearman.cfg: Updated goblin spearman description. https://github.com/wesnoth/wesnoth/commit/0b7ca63a86157b8d6a82c1d59858bdd1713685f4 20180531 06:52:54< irker723> wesnoth: Pentarctagon wesnoth:1.14 2ffa6b13bae4 / data/core/units/goblins/Spearman.cfg: Updated goblin spearman description. https://github.com/wesnoth/wesnoth/commit/2ffa6b13bae446d75088d1c0bbfc60938ed4be3f 20180531 06:55:06-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me] 20180531 06:55:33-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20180531 07:29:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180531 07:32:08< irker723> wesnoth/wesnoth:1.14 loonycyborg 8a1d50799e Enable ASLR and NX bit security features AppVeyor: All builds passed 20180531 07:37:44-!- nemaara [442bb2e7@gateway/web/freenode/ip.68.43.178.231] has joined #wesnoth-dev 20180531 07:38:37-!- nemaara [442bb2e7@gateway/web/freenode/ip.68.43.178.231] has quit [Client Quit] 20180531 07:59:14< zookeeper> @Pentarctagon, i was under the impression you wanted to remove the part about bloodlines. not that i'm complaining, naturally. 20180531 08:00:28<+discordbot4> ...I could have sworn that I did 20180531 08:04:15< irker723> wesnoth: Pentarctagon wesnoth:1.14 315b0895c1d0 / data/core/units/goblins/Spearman.cfg: Fixup goblin description. https://github.com/wesnoth/wesnoth/commit/315b0895c1d0e8c4d2f72302d04bfe4e91f358b0 20180531 08:05:41< irker723> wesnoth: Pentarctagon wesnoth:master 9242a5ffd0db / data/core/units/goblins/Spearman.cfg: Fixup goblin description. https://github.com/wesnoth/wesnoth/commit/9242a5ffd0db9a6bdeb65c498a7e3db852d60f21 20180531 08:06:14<+discordbot4> there we go 20180531 08:10:47< irker723> wesnoth: Severin Glöckner wesnoth:1.14 389653151cf6 / src/gui/dialogs/multiplayer/mp_create_game.cpp: GUI: add a translation prefix https://github.com/wesnoth/wesnoth/commit/389653151cf6ba6fb0e58446d57255f679df23e1 20180531 08:10:49< irker723> wesnoth: Severin Glöckner wesnoth:1.14 aca56489b82d / doc/man/wesnoth.6: manpages: clarify deprecation logdomain https://github.com/wesnoth/wesnoth/commit/aca56489b82d2a1242d3d7781007e834a25fb377 20180531 08:10:50< irker723> wesnoth: Celtic Minstrel wesnoth:1.14 40d1fbefa715 / doc/man/wesnoth.6: Documentation for the translation completeness command-line flags https://github.com/wesnoth/wesnoth/commit/40d1fbefa715ac2582acd369592c8b249856b3aa 20180531 08:10:53< irker723> wesnoth: gfgtdf wesnoth:1.14 30c08cd78562 / src/actions/advancement.cpp: fix untranslatable string. https://github.com/wesnoth/wesnoth/commit/30c08cd785623e498b28eb88c1d6b2a86754ef33 20180531 08:10:54< irker723> wesnoth: Celtic Minstrel wesnoth:1.14 4062c1ef2585 / src/units/attack_type.cpp: Fix effects being unable to decrease weapon parry/accuracy https://github.com/wesnoth/wesnoth/commit/4062c1ef2585125ceee90bcc1e22f10635952f16 20180531 08:22:14< irker723> wesnoth: Charles Dang wesnoth:master 8c3673dfa0dc / src/gui/widgets/chatbox.cpp: GUI2/Chatbox: removed spurious newline from initial PM notice https://github.com/wesnoth/wesnoth/commit/8c3673dfa0dcc0bc056a20374ab6a3e48e2d3d43 20180531 08:22:17< irker723> wesnoth: gfgtdf wesnoth:master af6559af75ef / src/units/filter.cpp: fix unit filter always evaluating [and] even if it is not needed. https://github.com/wesnoth/wesnoth/commit/af6559af75efcb0cc7ff06b25f87f6135d167034 20180531 08:22:19< irker723> wesnoth: gfgtdf wesnoth:master f69af8533a31 / src/generators/default_map_generator_job.cpp: add mapgen debug info. https://github.com/wesnoth/wesnoth/commit/f69af8533a31e9820f188916e9466136360973e5 20180531 08:22:21< irker723> wesnoth: gfgtdf wesnoth:master 8e3ee5c5976a / src/generators/default_map_generator_job.cpp: add mapgen debug info. https://github.com/wesnoth/wesnoth/commit/8e3ee5c5976a91a97acc7efaca69c1a370863e7f 20180531 08:22:23< irker723> wesnoth: gfgtdf wesnoth:master 84d94ca30549 / src/generators/default_map_generator_job.cpp: add mapgen debug info. https://github.com/wesnoth/wesnoth/commit/84d94ca30549ffa60fead6330f119accd8392d85 20180531 08:22:25< irker723> wesnoth: gfgtdf wesnoth:master 0dd382eab32e / src/scripting/mapgen_lua_kernel.cpp: fix seed not resetting in lua mapgen. https://github.com/wesnoth/wesnoth/commit/0dd382eab32ed2255689d4bec7418d4d0bf5d040 20180531 08:22:36< irker723> wesnoth: Charles Dang wesnoth:1.14 844c17463cc5 / src/gui/widgets/chatbox.cpp: GUI2/Chatbox: removed spurious newline from initial PM notice https://github.com/wesnoth/wesnoth/commit/844c17463cc5c1f4847693418d6c28451b3f0b01 20180531 08:29:21< zookeeper> gfgtdf, WRT "fix unit filter always evaluating [and] even if it is not needed" <- so is evaluation of [and] now only skipped if the other filtering has already excluded the unit from matching? 20180531 08:31:01< Soliton> yes. 20180531 08:31:27< zookeeper> okay, cool 20180531 08:31:44< Soliton> he just used the short circuit logic of c++. 20180531 08:32:51< Soliton> same for or if the result is already true no need to evaluate the next condition. 20180531 08:33:41< zookeeper> would a side 1 unit have matched a filter like "side=2 [and] side=1,2 [/and]" before? 20180531 08:35:47< Soliton> i don't think so. before the and was just evaluated but false && true would still be false. 20180531 08:35:48< zookeeper> i'm guessing not, but just a thought. 20180531 08:35:52< zookeeper> right 20180531 08:41:17< irker723> wesnoth: Charles Dang wesnoth:1.14 c5c5392bc4d2 / src/game_initialization/lobby_data.hpp: MP Lobby: display self before friends in player list (fixes #3185) https://github.com/wesnoth/wesnoth/commit/c5c5392bc4d21a8280a9c4451828e51a4d6be77d 20180531 08:41:20< irker723> wesnoth: Charles Dang wesnoth:1.14 15f7b4b71a04 / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: removed gender tooltip (resolves #2998) https://github.com/wesnoth/wesnoth/commit/15f7b4b71a0416ac8d604d0e9353e20d4e2f9027 20180531 08:41:48< irker723> wesnoth: Charles Dang wesnoth:master 6cc91794f544 / src/game_initialization/lobby_data.hpp: MP Lobby: display self before friends in player list (fixes #3185) https://github.com/wesnoth/wesnoth/commit/6cc91794f544e16f2feca3cf0e26c070548d9483 20180531 08:41:51< irker723> wesnoth: Charles Dang wesnoth:master 3d8d38983d1c / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: removed gender tooltip (resolves #2998) https://github.com/wesnoth/wesnoth/commit/3d8d38983d1c5a6bfe542ee756b6ce3ac3471bd3 20180531 08:55:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 08:56:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 08:56:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180531 08:57:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 08:57:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180531 08:57:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 08:58:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180531 08:59:44< irker723> wesnoth: loonycyborg wesnoth:1.14 ee638bc89202 / SConstruct: Typo fix https://github.com/wesnoth/wesnoth/commit/ee638bc89202c2f066c94f67488de3d1bb8e7205 20180531 09:02:36-!- fabi_ [~fabi@200116b82b738e00d88e2aeed76c55f9.dip.versatel-1u1.de] has quit [Quit: Konversation terminated!] 20180531 09:04:33-!- travis-ci [~travis-ci@ec2-54-163-68-221.compute-1.amazonaws.com] has joined #wesnoth-dev 20180531 09:04:34< travis-ci> wesnoth/wesnoth#18435 (master - 0dd382e : gfgtdf): The build was broken. 20180531 09:04:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/386072989 20180531 09:04:34-!- travis-ci [~travis-ci@ec2-54-163-68-221.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180531 09:08:09< irker723> wesnoth: loonycyborg wesnoth:master 8b1a5c0dde9e / SConstruct: Enable ASLR and NX bit security features for mingw builds https://github.com/wesnoth/wesnoth/commit/8b1a5c0dde9e1a36531e6d104737b40531e59cd0 20180531 09:30:53-!- travis-ci [~travis-ci@ec2-54-163-68-221.compute-1.amazonaws.com] has joined #wesnoth-dev 20180531 09:30:54< travis-ci> wesnoth/wesnoth#18437 (1.14 - 15f7b4b : Charles Dang): The build passed. 20180531 09:30:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/386079217 20180531 09:30:54-!- travis-ci [~travis-ci@ec2-54-163-68-221.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180531 10:02:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 10:02:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 10:07:52-!- travis-ci [~travis-ci@ec2-54-158-14-200.compute-1.amazonaws.com] has joined #wesnoth-dev 20180531 10:07:53< travis-ci> wesnoth/wesnoth#18440 (master - 8b1a5c0 : loonycyborg): The build was fixed. 20180531 10:07:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/386087970 20180531 10:07:53-!- travis-ci [~travis-ci@ec2-54-158-14-200.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180531 10:15:13<+discordbot4> @loonycyborg will you be able to make 64 bit windows pakages? 20180531 10:15:17<+discordbot4> using mingw? 20180531 10:16:10<+discordbot4> yes 20180531 10:16:47<+discordbot4> the question is maybe it's good time to drop 32bit builds even 20180531 10:16:53<+discordbot4> yes 20180531 10:16:58<+discordbot4> it is 20180531 10:20:03<+discordbot4> is there a way to lookup steam stats somehow on which systems people use for wesnoth? 20180531 10:20:16<+discordbot4> 32bit vs 64bit that is 20180531 10:20:20< zookeeper> don't they at least need a healthy amount of testing to discover possible problems? i mean, i'd imagine that whatever release you introduce 64bit builds for, you still need to provide a 32bit version too in case serious problems crop up. 20180531 10:20:37<+discordbot4> not so 20180531 10:21:11<+discordbot4> iOS 11 basically dropped compatibility for 32 bit apps, for example. 20180531 10:21:12< zookeeper> unless you happen to know there's no potential for problems... which seems unlikely considering for how long we've been unable to make 64bit builds in the first place. 20180531 10:21:24<+discordbot4> uhh 20180531 10:21:40<+discordbot4> not...so 20180531 10:21:43<+discordbot4> we always been able 20180531 10:21:47<+discordbot4> ^ 20180531 10:21:59<+discordbot4> it's just that rebuilding the required libraries takes time 20180531 10:22:00<+discordbot4> most linux distros are 64-bit for example and package wesnoth as 64bit 20180531 10:22:17<+discordbot4> but since loony is on mingw it might be easier than revuilding for VS 20180531 10:22:19<+discordbot4> rebuilding* 20180531 10:22:22< zookeeper> oh, okay. i thought there was some actual technical reason why we haven't provided them. 20180531 10:22:32<+discordbot4> I didn't make windows bits 64bit only retain compatibility with existing 32-bit systems 20180531 10:22:44<+discordbot4> *to 20180531 10:40:47<+discordbot4> but we don't have 64 bit windows builds at all 20180531 10:54:23<+discordbot4> I'll work on setting up 64-bit variant of my build stuff 20180531 11:48:29-!- ToBeFree [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180531 12:06:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180531 12:08:44-!- irker723 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180531 12:35:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20180531 12:40:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180531 12:41:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180531 12:49:50-!- irker152 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180531 12:49:50< irker152> wesnoth/wesnoth:master Pentarctagon 0b7ca63a86 Updated goblin spearman description. AppVeyor: All builds passed 20180531 13:38:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180531 13:40:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180531 13:40:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180531 13:45:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 13:46:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 13:49:58-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180531 13:57:38-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180531 14:17:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 14:18:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 14:57:03< irker152> wesnoth: gfgtdf wesnoth:1.14 b0dffebe809d / src/whiteboard/move.cpp: wb: fixup "fix incorrect handling of skirmisher." https://github.com/wesnoth/wesnoth/commit/b0dffebe809d6c24eb685f4641f78f95a0bf5cf2 20180531 15:00:36< irker152> wesnoth: gfgtdf wesnoth:master 9cc32ebc46a0 / src/whiteboard/move.cpp: wb: fixup "fix incorrect handling of skirmisher." https://github.com/wesnoth/wesnoth/commit/9cc32ebc46a006b70916572594c08cacfaad6571 20180531 15:00:38< irker152> wesnoth: Charles Dang wesnoth:master 2503ac88978c / src/game_initialization/lobby_data.cpp: MP Lobby: added translation hints for C/S markers https://github.com/wesnoth/wesnoth/commit/2503ac88978c8332085b2964154a6af4738cf610 20180531 15:01:03< irker152> wesnoth: Charles Dang wesnoth:1.14 3abea03b42db / src/game_initialization/lobby_data.cpp: MP Lobby: added translation hints for C/S markers https://github.com/wesnoth/wesnoth/commit/3abea03b42dbd57e32dcffb597e57eedf6b15b29 20180531 15:06:47<+discordbot4> I'm rather curious if other languages will actually have a translation for those now 20180531 15:10:20<+discordbot4> now when I want to try to repro the "MP lobby chat scrolling to top on new message if not focused at bottom" bug no one is talking in the lobby 20180531 15:10:21<+discordbot4> >_< 20180531 15:15:31< irker152> wesnoth/wesnoth:1.14 loonycyborg ee638bc892 Typo fix AppVeyor: All builds passed 20180531 15:41:45<+discordbot4> In German the C will be switched out with an K 20180531 15:57:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 15:57:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 16:10:01<+discordbot4> TFW you wait a month for an email and then realize it's been in spam since the beginning of the month 20180531 16:10:02<+discordbot4> 😐 20180531 16:10:19<+discordbot4> 🤦 20180531 16:13:53<+discordbot4> Google's spam filter it too zealous sometimes... 20180531 16:14:57<+discordbot4> tho 20180531 16:15:06<+discordbot4> in this case it might be a problem on the sender's end 20180531 16:37:55-!- gallaecio [~quassel@220.red-79-150-211.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180531 16:43:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 16:49:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 16:51:21< irker152> wesnoth: loonycyborg wesnoth:master d35f22e0773a / src/SConscript: scons: fix issue #3132 https://github.com/wesnoth/wesnoth/commit/d35f22e0773abffdf54b591b75d6ffb75f3ff6a6 20180531 16:51:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 16:55:19< irker152> wesnoth: loonycyborg wesnoth:1.14 0c6885d4e892 / src/SConscript: scons: fix issue #3132 https://github.com/wesnoth/wesnoth/commit/0c6885d4e8920e839ae9e0fd0d724a29173d9022 20180531 17:05:47-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180531 18:01:18< irker152> wesnoth/wesnoth:master loonycyborg 8b1a5c0dde Enable ASLR and NX bit security features AppVeyor: All builds passed 20180531 19:22:30-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 19:33:15-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 260 seconds] 20180531 19:35:19< irker152> wesnoth: gfgtdf wesnoth:1.14 47bdab511406 / src/game_initialization/mp_game_utils.cpp: fix possible 'manditory child missing' when loading mp campaign games https://github.com/wesnoth/wesnoth/commit/47bdab5114067a30b5ef4a62359e0aad592c77e7 20180531 19:39:11-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180531 19:48:00-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 256 seconds] 20180531 19:50:45-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180531 19:54:46-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 20:05:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180531 20:05:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180531 20:19:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 20:32:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 20:46:07-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180531 21:37:11<+discordbot4> Okay. 20180531 21:37:56<+discordbot4> I have a situation where characters speak in their last breath event right before the die event signals defeat. 20180531 21:38:23<+discordbot4> For some reason their death animation doesn't play betweeb last breath and die. 20180531 21:38:40<+discordbot4> I do literally nothing in last breath other than show a [message]. 20180531 21:39:40<+discordbot4> This is arguably minor in my case but I think it may be pretty annoying if the death animation is supposed to be more elaborate than the default frame fade out. 20180531 21:44:05< irker152> wesnoth/wesnoth:master Charles Dang 2503ac8897 MP Lobby: added translation hints for C/ AppVeyor: All builds passed 20180531 21:53:04<+discordbot4> Also, I feel like perhaps [message] should use wrap for the option list elements @Vultraz 20180531 21:53:05<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/451865724508700687/unknown.png 20180531 21:53:30<+discordbot4> I believe I actually tried out that change once but didn't commit it because I wasn't sure if anyone out there might be relying on it to not wrap elements across multiple lines. 20180531 21:54:13<+discordbot4> But in hindsight I don't feel that can possibly be the case since you'd have to be crazy to find horizontal scrollbars to be anything other than a nuisance for this. 20180531 22:14:53-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180531 22:50:01-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180531 22:51:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180531 22:57:34< irker152> wesnoth/wesnoth:master loonycyborg d35f22e077 scons: fix issue #3132 AppVeyor: All builds passed 20180531 23:31:34< zookeeper> @shadowm, sounds like the bug i kept complaining about ([message] swallowing up a following animation) but... i could have sworn it was fixed. dunno, off to bed right now -> 20180531 23:31:57<+discordbot4> Does it swallow any animation? o_O 20180531 23:33:55< irker152> wesnoth: sigurdfdragon wesnoth:1.14 c7371ac71263 / data/campaigns/Secrets_of_the_Ancients/scenarios/09_Training_Session.cfg: SotA S09: Fix #3192 https://github.com/wesnoth/wesnoth/commit/c7371ac7126307e504edc412293f5790e25eaa47 20180531 23:33:57< irker152> wesnoth: sigurdfdragon wesnoth:1.14 1a18d698aea4 / changelog.md players_changelog.md: Update changelogs https://github.com/wesnoth/wesnoth/commit/1a18d698aea4bb69c8a0b02397f12bbb65e81bc1 20180531 23:35:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20180531 23:42:21< irker152> wesnoth: sigurdfdragon wesnoth:master 047ededd9efa / data/campaigns/Secrets_of_the_Ancients/scenarios/09_Training_Session.cfg: SotA S09: Fix #3192 https://github.com/wesnoth/wesnoth/commit/047ededd9efa9008d931ca483e71b9cc0e582f6b 20180531 23:42:23< irker152> wesnoth: sigurdfdragon wesnoth:master 03d0e5deeecc / changelog.md players_changelog.md: Update changelogs https://github.com/wesnoth/wesnoth/commit/03d0e5deeeccf3bd6d3371a17ef22b922ad01d54 20180531 23:53:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180531 23:53:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180531 23:58:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Fri Jun 01 00:00:47 2018