--- Log opened Sat Jun 02 00:00:48 2018 20180602 00:08:55-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180602 00:48:51-!- gfg [~androirc@x4e32b2bb.dyn.telefonica.de] has quit [Remote host closed the connection] 20180602 00:49:02-!- gfg [~androirc@x4e32b2bb.dyn.telefonica.de] has joined #wesnoth-dev 20180602 01:12:21-!- gfg [~androirc@x4e32b2bb.dyn.telefonica.de] has quit [Remote host closed the connection] 20180602 01:24:13-!- irker085 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180602 02:17:06-!- TheJJ [~rofl@ipbcc05d72.dynamic.kabel-deutschland.de] has quit [Quit: løl] 20180602 02:21:38-!- irker344 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180602 02:21:38< irker344> wesnoth/wesnoth:1.14 loonycyborg 8ff65117c5 scons: don't let pkg-config to add prefi AppVeyor: All builds passed 20180602 02:31:04-!- TheJJ [~rofl@ipbcc05d72.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20180602 03:14:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 03:14:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 04:24:25< irker344> wesnoth/wesnoth:1.14 Charles Dang af16289678 NR S11 - 13: reduced enemy starting gold AppVeyor: All builds passed 20180602 04:54:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180602 05:03:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 05:03:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 05:15:04-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180602 05:57:42-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 265 seconds] 20180602 06:05:30< irker344> wesnoth: Charles Dang wesnoth:master 5adb931b2aaf / / (5 files in 2 dirs): NR S11 - 13: reduced enemy starting gold and income (resolves #3198) https://github.com/wesnoth/wesnoth/commit/5adb931b2aafa1747dda62fad05a0b24754eedbd 20180602 06:05:49<+discordbot4> actually 10 - 13, messed up the commit message 20180602 06:27:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Remote host closed the connection] 20180602 06:27:24-!- Ivanovic_ [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180602 06:29:18-!- Ivanovic_ is now known as Ivanovic 20180602 06:34:17-!- Nobun [~user@51.179.104.35] has joined #wesnoth-dev 20180602 07:05:09-!- Nobun [~user@51.179.104.35] has left #wesnoth-dev ["WeeChat 2.1-dev"] 20180602 07:44:05-!- zookeeper [~lmsnie@95.175.104.72] has joined #wesnoth-dev 20180602 07:44:06-!- zookeeper [~lmsnie@95.175.104.72] has quit [Changing host] 20180602 07:44:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180602 08:12:37<+discordbot4> @Vultraz I profiled rendering in 1.14. The mutex you added takes about 5,2 % of the execution time of game_display::draw_invalidated(). 20180602 08:12:52<+discordbot4> I see... 20180602 08:34:18<+discordbot4> yeah thanks 20180602 08:40:55-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180602 08:40:55-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180602 08:53:42-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180602 08:56:35< irker344> wesnoth: loonycyborg wesnoth:master 2bc7cc3e6106 / scons/boost.py: scons: workaround for msys2's build's of sdl "#define main" breaking non-sdl che https://github.com/wesnoth/wesnoth/commit/2bc7cc3e6106d089f168510a2a12cc53bfd48007 20180602 08:56:37< irker344> wesnoth: loonycyborg wesnoth:master d8743f8e6e51 / scons/cross_compile.py: scons: set env["PLATFORM"] to "win32" on msys https://github.com/wesnoth/wesnoth/commit/d8743f8e6e51a30f0b039d40dc053b8e4dbf34b3 20180602 08:56:39< irker344> wesnoth: loonycyborg wesnoth:master aa925e1fc6f6 / scons/sdl.py: scons: use pkg-config on msys platform for sdl https://github.com/wesnoth/wesnoth/commit/aa925e1fc6f64266b66fe63f16c19ef08a34362c 20180602 08:56:41< irker344> wesnoth: loonycyborg wesnoth:master b347bc70b163 / SConstruct scons/cairo.py scons/pango.py scons/pkgconfig.py scons/sdl.py: scons: don't let pkg-config to add prefix on msys2 https://github.com/wesnoth/wesnoth/commit/b347bc70b163a572751b7ac72f23e472c3ac9238 20180602 08:56:43< irker344> wesnoth: loonycyborg wesnoth:master d96d5c506c2d / SConstruct: scons: add missing winapi lib dependencies to mingw build https://github.com/wesnoth/wesnoth/commit/d96d5c506c2d8c8f47984b2e1d4bf13111e195a2 20180602 08:58:32-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 276 seconds] 20180602 09:10:12-!- gfgtdf [~chatzilla@x4e363ab2.dyn.telefonica.de] has joined #wesnoth-dev 20180602 09:13:34< gfgtdf> 20180602 08:12:37<+discordbot4> @Vultraz I profiled rendering in 1.14. The mutex you added takes about 5,2 % of the execution time of game_display::draw_invalidated(). 20180602 09:14:02< gfgtdf> hmm do you know how often that lock is uesd while drawing one hex 20180602 09:14:36< gfgtdf> alos it' should not be too hard to use the lock only while the loadingscreen is up. 20180602 09:15:59<+discordbot4> Seems to be about twice per hex on average. 20180602 09:21:10< gfgtdf> and still 5.2% of the cpu usage? that's reall suporising. 20180602 09:22:52< gfgtdf> also iirc each malloc/new call has to use locks internally, also each shared_ptr copy / dtor operation uses locks. 20180602 09:24:08< gfgtdf> so in theory that lock call cannot bw slower than doing any new/delete pair inside that fuction. 20180602 09:24:56< gfgtdf> that is unless the drawoing cod eis multithreaded (which it probably was at one point with openmp) and the actuall 'lock' soemthign in there 20180602 09:30:46<+discordbot4> Windows Heap Manager probably uses some lock-free algorithm, or a faster primitive than a mutex. 20180602 09:41:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180602 09:47:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 09:48:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 10:14:10-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180602 11:19:25<+discordbot4> btw 20180602 11:19:28<+discordbot4> reduce by how much? 20180602 11:28:12< Ravana_> open that link and you see 20180602 11:31:20<+discordbot4> what link 20180602 11:38:25-!- discordbot5 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180602 11:38:28-!- mode/#wesnoth-dev [+v discordbot5] by ChanServ 20180602 11:38:56<+discordbot5> https://github.com/wesnoth/wesnoth/commit/5adb931b2aafa1747dda62fad05a0b24754eedbd I guess 20180602 11:39:43<+discordbot5> oh 20180602 11:39:54<+discordbot5> wasn't sure what flameheart was referring to 20180602 11:41:48<+discordbot5> heh 20180602 11:41:56<+discordbot5> i just realized i got one side backwards. 20180602 11:42:59-!- discordbot4 [~discordbo@baldras.wesnoth.org] has quit [Ping timeout: 256 seconds] 20180602 11:57:02-!- irker344 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180602 12:13:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 12:13:56-!- gfgtdf [~chatzilla@x4e363ab2.dyn.telefonica.de] has quit [Remote host closed the connection] 20180602 12:14:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 12:54:57-!- APic [apic@apic.name] has quit [Ping timeout: 256 seconds] 20180602 12:59:04-!- APic [apic@apic.name] has joined #wesnoth-dev 20180602 13:28:39<+discordbot5> k thanks bro 20180602 13:28:42<+discordbot5> you are the hero 20180602 13:29:52<+discordbot5> 1600 still bit too much tbh 20180602 13:30:02<+discordbot5> because your gold drops from 3000-4000 to 900+ 20180602 13:30:11<+discordbot5> while theirs go from 2500 to 1600 20180602 13:44:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180602 13:48:55<+discordbot5> @Flameheart ^ 20180602 13:49:00-!- irker271 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180602 13:49:00< irker271> wesnoth: Charles Dang wesnoth:1.14 e9639b58a4be / data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg: NR S13: further reduce enemy gold https://github.com/wesnoth/wesnoth/commit/e9639b58a4be87b3ba86aa916245142f2c8fb75c 20180602 13:49:00<+discordbot5> yep? 20180602 13:49:27<+discordbot5> wait me a bit bro 20180602 13:49:31<+discordbot5> let me finish off the nubs on isar 20180602 14:12:03<+discordbot5> fucking isar nubs 20180602 14:12:07<+discordbot5> 😦 20180602 14:23:01<+discordbot5> Okay thanks bro 20180602 14:23:06<+discordbot5> 👍 20180602 14:38:59-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 255 seconds] 20180602 14:43:55-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180602 15:04:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180602 15:19:45<+discordbot5> I'd prefer if the mutex was done away with and the cache purge was deferred and delegated back to the main thread. 20180602 15:20:13<+discordbot5> It shouldn't be too hard to accomplish that if you already know how that code works. 20180602 15:22:53<+discordbot5> I don't think it's that simple 20180602 15:24:42<+discordbot5> Colour me curious then. 20180602 15:25:18<+discordbot5> Because the main thread is required to know what the worker thread is up to either way. 20180602 15:25:48<+discordbot5> well, two reasons, the latter of which is I noticed something very odd... 20180602 15:25:50<+discordbot5> very very odd 20180602 15:26:14<+discordbot5> the flush_cache call should already be in the main thread 😐 20180602 15:26:54<+discordbot5> the only explanation is that another loading screen instance has a worker thread of its own that calls load_game_config_for_game 20180602 15:27:24<+discordbot5> Have you confirmed it with a breakpoint? 20180602 15:27:46<+discordbot5> confirmed what? 20180602 15:28:34<+discordbot5> That flush_cache() is being called via load_game_config_for_game(), and that's the way it ends up being called in a worker thread. 20180602 15:28:46<+discordbot5> ....um 20180602 15:28:49<+discordbot5> I can read the code. 20180602 15:29:06<+discordbot5> and it's already been confirmed that this specific call is the issue 20180602 15:29:15<+discordbot5> it comes after the call to load_game_config_with_loadscreen 20180602 15:29:33<+discordbot5> ergo, this function itself must be part of another instance... 20180602 15:29:39<+discordbot5> Not quite. We confirmed that patching it solves the issue. 20180602 15:30:10<+discordbot5> shadowm - Last Tuesday at 12:45 PM Yep. It doesn't happen if I comment it out. The one at line 573, specifically. I didn't touch the other one. Sooo... yeah, good job, you are a visionary AND a gambler. 20180602 15:30:18<+discordbot5> Yes. 20180602 15:30:33<+discordbot5> We did not confirm that it causes the issue. 20180602 15:30:46<+discordbot5> here's the thing... 20180602 15:30:55<+discordbot5> You're still thinking in terms of a single thread of execution in your head. 20180602 15:31:34<+discordbot5> What I found was clearly a data race since so many people hadn't yet. 20180602 15:31:37<+discordbot5> when I investigated this bug: https://github.com/wesnoth/wesnoth/issues/2395 I realized the loading screen interaction with the game initialization process is messy as hell. 20180602 15:31:44<+discordbot5> there are at least.. 20180602 15:31:49<+discordbot5> 3 instances created 20180602 15:31:56<+discordbot5> God knows exactly what the conditions to cause the race to happen are. 20180602 15:32:26<+discordbot5> so it's very possible this function is itself being called by another thread 20180602 15:32:31<+discordbot5> er 20180602 15:32:36<+discordbot5> yes 20180602 15:32:50<+discordbot5> in another thread, created as part of a previously-created loading screen instance 20180602 15:33:12<+discordbot5> and that the load_game_config_with_loadscreen call we see here does not create a new ls instance. 20180602 15:33:18<+discordbot5> When it comes to this kind of theorizing, setting up a breakpoint and waiting it to be hit for a few times takes barely any effort. 20180602 15:33:21<+discordbot5> meaning the flush_cache call is indeed in a worker thread 20180602 15:33:29<+discordbot5> It's much safer than attempting to fix bugs based on guesses. 20180602 15:33:38< irker271> wesnoth/wesnoth:master loonycyborg d96d5c506c scons: add missing winapi lib dependenci AppVeyor: All builds passed 20180602 15:33:46<+discordbot5> GOD DAMMIT THIS O KEY KEEPS POPPING UP EVERY TIMEI TOUCH IT 20180602 15:34:04<+discordbot5> shitty-ass keyboard 20180602 15:34:09<+discordbot5> >_> 20180602 15:35:03<+discordbot5> moving on... 20180602 15:35:25<+discordbot5> yes, my theory is correct. I've found the parent loading screen instance 20180602 15:35:32<+discordbot5> via code-read 20180602 15:36:08<+discordbot5> https://github.com/wesnoth/wesnoth/blob/master/src/game_launcher.cpp#L945-L956 20180602 15:36:09<+discordbot5> it's here 20180602 15:36:33<+discordbot5> so, indeed, that call is in a worker thread 20180602 15:37:05-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 248 seconds] 20180602 15:37:31<+discordbot5> .........HMMMMMMMMMMMMMMMMMMMMMMMMMMMM 20180602 15:37:52<+discordbot5> @jyrkive what if I wrap the flush_cache call in call_in_main_thread? 20180602 15:39:02<+discordbot5> I think it should work. 20180602 15:50:24<+discordbot5> @shadowm can you see if reverting 0eb27e246bfc842655ee5ee4d3e1ddc326e87ebb and then replacing src/game_config_manager.cpp:573 with events::call_in_main_thread([]() { image::flush_cache(); }); works? 20180602 16:10:54<+discordbot5> It does. 20180602 16:14:08<+discordbot5> just dled 1.14.2 20180602 16:14:14<+discordbot5> the music clips a little less than in 1.14.1 20180602 16:14:24<+discordbot5> but is still suuuuper loud 20180602 16:14:34<+discordbot5> Again, the sound code hasn't changed at all. 20180602 16:15:07<+discordbot5> well then it might be worth looking into changing it or seeing if something else has affected it 20180602 16:15:10<+discordbot5> Have you looked at the volumje sliders on your taskbar? 20180602 16:15:17<+discordbot5> yes 20180602 16:15:19<+discordbot5> it's down at 8 20180602 16:15:31<+discordbot5> and in preferences 20180602 16:15:42<+discordbot5> We can't change something we can't reproduce. 20180602 16:15:45<+discordbot5> https://cdn.discordapp.com/attachments/259976436490829825/452505614212530186/unknown.png 20180602 16:15:54<+discordbot5> I said on your taskbar. 20180602 16:16:03<+discordbot5> Windows' own volume controls, not Wesnoth's. 20180602 16:16:05<+discordbot5> yes 20180602 16:16:09<+discordbot5> I just told you it's down at 8 20180602 16:16:23<+discordbot5> I put both at very low and now it's manageable 20180602 16:16:35<+discordbot5> it seems like I'm not the only person with this issue 20180602 16:16:36<+discordbot5> https://steamcommunity.com/profiles/76561198055519132/recommended/599390/ 20180602 16:17:16<+discordbot5> disregarding the second half of the review, I am inclined to agree with the first part, the music volume is too much 20180602 16:17:40<+discordbot5> I wonder why it's gotten so loud if the sound code hasn't changed 🤔 20180602 16:19:35<+discordbot5> What in hell is this person talking about 20180602 16:19:38<+discordbot5> seriously 20180602 16:19:50<+discordbot5> "the button to create this so called account does not exist." It's right there! 20180602 16:20:03<+discordbot5> "Once you are there you have to create a thread and fill out this application form. " what??? 20180602 16:20:10<+discordbot5> "Then you have to wait a few days for some admin to come along and approve or disapprove your application." since when! 20180602 16:20:26<+discordbot5> It's one of the people who believe they need to register a wiki account. 20180602 16:21:10<+discordbot5> how do they possibly get that notin 20180602 16:21:13<+discordbot5> on 20180602 16:21:50<+discordbot5> I'd suspect that it's a bug in SDL 2. 20180602 16:22:05<+discordbot5> It uses DirectSound on Windows I believe. 20180602 16:22:08<+discordbot5> I'm going to write a response to this review because it's totally inaccurate 20180602 16:22:24<+discordbot5> And IIRC there's a way to make it not use DirectSound. 20180602 16:22:40<+discordbot5> hrrrrr 20180602 16:23:02<+discordbot5> I'll open an issue for this 20180602 16:23:56<+discordbot5> @Yumi Go into a command line prompt, and do this: SET SDL_AUDIODRIVER=winmm 20180602 16:24:16<+discordbot5> Then change into the directory where Wesnoth is installed and run wesnoth from the same prompt. 20180602 16:24:56<+discordbot5> (e.g. `CD "C:\Program Files (x86)\Wesnoth" 20180602 16:25:29<+discordbot5> I don't remember the path but I reckon by now you know how to find out. 20180602 16:33:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 16:33:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 16:34:29<+discordbot5> it works 20180602 16:35:30<+discordbot5> Are your sound drivers up to date? 20180602 16:36:07<+discordbot5> Also what SDL and SDL_mixer versions does Wesnoth report in the version info dialog? 20180602 16:40:40<+discordbot5> SDL 2.0.8 20180602 16:40:48<+discordbot5> SDL_mixer 2.0.2 20180602 16:41:42<+discordbot5> device manager seems to think my drivers are up to date 20180602 16:48:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180602 16:55:11<+discordbot5> looks like one can use SDL_AudioInit to specify driver 20180602 16:56:55-!- gfgtdf [~chatzilla@x4e363ab2.dyn.telefonica.de] has joined #wesnoth-dev 20180602 17:30:10-!- DeFender1031 [~DeFender1@89-138-79-9.bb.netvision.net.il] has joined #wesnoth-dev 20180602 17:36:50<+discordbot5> The thing is there should be no reason not to use DSound by default. 20180602 17:39:10<+discordbot5> @Vultraz msys2 compiled wesnoth master started to work after I enabled opengl accel in virtualbox 20180602 17:40:14<+discordbot5> with basic virtualbox virtual card it seems it segfaults during sdl's video init 20180602 17:40:35<+discordbot5> why can't it fail in more user friendly way 😛 20180602 17:42:36<+discordbot5> VirtualBox's hardware acceleration is dodgy to say the least. 20180602 17:42:44<+discordbot5> I would test on real hardware instead. 20180602 17:43:46<+discordbot5> but we don't even use anything opengl yet anyway.. 20180602 17:43:55<+discordbot5> No, but it messes up everything in my experience. 20180602 17:44:34<+discordbot5> Also I believe SDL uses DirectDraw which uses the video drivers anyway. 20180602 17:44:53<+discordbot5> (Unless you explicitly request it to use GDI via an environment variable like the sound driver case above.) 20180602 17:45:12<+discordbot5> it worked with 1.14 without opengl support 20180602 17:45:45<+discordbot5> The master branch sets SDL to use a hardware accelerated backend. 20180602 17:46:21<+discordbot5> yeah, I think this change made it crash 20180602 17:47:06<+discordbot5> also bt was useless 20180602 17:47:20<+discordbot5> somehow it was pointing to 0x000000.. 20180602 17:47:38<+discordbot5> so I stepped through code manually 20180602 17:48:04<+discordbot5> to get to that sdl video init call 20180602 17:55:12<+discordbot5> Master doesn’t not require ogl 20180602 17:55:17<+discordbot5> It might use ogl 20180602 17:55:35<+discordbot5> Depends on what SDL asks for 20180602 17:56:41<+discordbot5> I didn't set a preferred driver 20180602 17:57:58<+discordbot5> @shadowm is that different from DirectX/D3D? 20180602 17:59:29< celticminstrel> That's Windows-only. 20180602 17:59:45< celticminstrel> But like OpenGL it's graphics acceleration. 20180602 17:59:58<+discordbot5> I know what DX is 20180602 17:59:58<+discordbot5> DirectDraw is an API older than Direct3D, intended to speed up 2D blitting. 20180602 18:00:05<+discordbot5> It's deprecated now. 20180602 18:00:12< celticminstrel> I guess the drivers implement the DX/GL API. 20180602 18:00:16< celticminstrel> Or something like that. 20180602 18:00:32<+discordbot5> is Steam using DirectDraw? 20180602 18:00:51<+discordbot5> Steam client? Probably not. 20180602 18:01:04<+discordbot5> the client has absolutely horrible rendering behavior 20180602 18:01:21<+discordbot5> I've noticed redraws "window shade" at times 20180602 18:01:34<+discordbot5> like this was the CRT days 😐 20180602 18:01:41<+discordbot5> I got a DirectDraw error the last time I tried to play AoE 1 through wine, for example. 20180602 18:02:04<+discordbot5> it's pretty old 20180602 18:02:43<+discordbot5> and I've had issues recently where the app doesn't draw until I re-maximize it. 20180602 18:02:48<+discordbot5> (steam) 20180602 18:03:00<+discordbot5> but beside the point here... 20180602 18:03:30<+discordbot5> master does use accelerated rendering, and that might utilize dx or ogl drivers under the hood. 20180602 18:03:44<+discordbot5> so it might be a problem with your VM 20180602 18:09:57-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180602 18:15:29< gfgtdf> is there a way to clear the lobby chat window without restarting wesnoth ? 20180602 18:16:27<+discordbot5> No, there isn't. 20180602 18:17:15< irker271> wesnoth: Charles Dang wesnoth:1.14 4f7e789f2d78 / data/campaigns/Northern_Rebirth/maps/ (5 files): NR S10 - 14: minor cosmetic map tweaks https://github.com/wesnoth/wesnoth/commit/4f7e789f2d78d38def8e10594060847c0eeb1af9 20180602 18:17:18< irker271> wesnoth: Charles Dang wesnoth:1.14 47618948444c / data/gui/window/campaign_dialog.cfg: Campaign Dialog: renamed Deterministic Mode label to "Save random seed" https://github.com/wesnoth/wesnoth/commit/47618948444cf04d8a61a465216e4b0cb72f37ea 20180602 18:17:21< irker271> wesnoth: Charles Dang wesnoth:1.14 757629846483 / src/image.cpp: Revert "Fixed an occasional crash resulting from multi-thread access of the imag https://github.com/wesnoth/wesnoth/commit/7576298464831410f3c283b06470754cf7666258 20180602 18:17:24< irker271> wesnoth: Charles Dang wesnoth:1.14 287775c7879e / src/game_config_manager.cpp: Game Config Manager: handle clearing image cache in main thread https://github.com/wesnoth/wesnoth/commit/287775c7879e74be2e4a02df6f744649034caef2 20180602 18:17:40< gfgtdf> hmm will post a fr for it them. 20180602 18:17:59<+discordbot5> why? 20180602 18:18:02<+discordbot5> do you want that 20180602 18:19:30< Ravana_> it gets so long, I want it too 20180602 18:20:11< gfgtdf> in my particular case because i testing for adding a new query command, i admd that it's a rare case, but i think it migth be useful for playersaswell when there are a lot of chat messages. 20180602 18:21:18< Ravana_> 1.14.2 crashed from mp lobby with out of memory, https://github.com/wesnoth/wesnoth/issues/3004#issuecomment-394106419 20180602 18:21:19< irker271> wesnoth: Charles Dang wesnoth:master a46eaa28749e / data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg: NR S13: further reduce enemy gold https://github.com/wesnoth/wesnoth/commit/a46eaa28749e48cf4027d1ec4523439b8407bc9b 20180602 18:21:22< irker271> wesnoth: Charles Dang wesnoth:master 20af37d527ef / data/campaigns/Northern_Rebirth/maps/ (5 files): NR S10 - 14: minor cosmetic map tweaks https://github.com/wesnoth/wesnoth/commit/20af37d527efdd476aa96cbe57aff071bf8b7dd5 20180602 18:21:25< irker271> wesnoth: Charles Dang wesnoth:master bf92dbbfd2c1 / data/gui/window/campaign_dialog.cfg: Campaign Dialog: renamed Deterministic Mode label to "Save random seed" https://github.com/wesnoth/wesnoth/commit/bf92dbbfd2c1699a9af11e6ddc1b850e154d16f9 20180602 18:21:28< irker271> wesnoth: Charles Dang wesnoth:master b8ad791a1d8d / src/image.cpp: Revert "Fixed an occasional crash resulting from multi-thread access of the imag https://github.com/wesnoth/wesnoth/commit/b8ad791a1d8d1e76d921d4f48a6fd57aee3c134e 20180602 18:21:31< irker271> wesnoth: Charles Dang wesnoth:master 011cbfe3b8fd / src/game_config_manager.cpp: Game Config Manager: handle clearing image cache in main thread https://github.com/wesnoth/wesnoth/commit/011cbfe3b8fd2d634e3294484f4cb9b255eac029 20180602 18:21:57<+discordbot5> how nice 20180602 18:24:12<+discordbot5> https://wiki.libsdl.org/FAQUsingSDL 20180602 18:24:21<+discordbot5> DDraw is the default on Windows. 20180602 18:24:29<+discordbot5> Oh wait, that's SDL 1.2. 20180602 18:24:44<+discordbot5> Looks like they use something entirely different in 2.0 and there are no other options. 20180602 18:25:42< gfgtdf> vultraz: the new patch clearly has performnace downsied aswell, as call_in_main_thread is really slow (it add an event and wait for it to handled in the main thread). I trhink better fix would be to to make the loadingscreen create the surface for that image before the workerthreead rund and use that surface during the loadingscreen so that the loadingscreen does not need to use the... 20180602 18:25:43< gfgtdf> ...imagecahce at all whiel the workerthread runs. 20180602 18:25:59< celticminstrel> What's the "how nice" about 20180602 18:29:59< gfgtdf> '/query status' waruting the ip adress, right? 20180602 18:32:51< Ravana_> seems that /query status and /query sl do same thing currently 20180602 18:32:54< gfgtdf> i want to add a command to show people the wesnoth version of other players, i coudl eigher add it to 'status' and change status to be available for everyone but show ip adress only in mods or i coudl add a new command, any opinions? 20180602 18:33:35< Ravana_> it already is available, > When used as a non-administrator it just returns the entry of the user. 20180602 18:34:51< gfgtdf> that also works for administrator, 20180602 18:35:36< gfgtdf> leaving out username is an alias for status and status is not allows for other player than unless admin. 20180602 18:37:04< gfgtdf> ok new command it is. 20180602 18:38:19< Ravana_> should /q status be changed to not show IP, but allow using it on anyone when used by normal user? or should I document current behavior in https://wiki.wesnoth.org/ServerAdministration#Available_commands 20180602 18:38:48<+discordbot5> gfgtdf: I don't see how the performance downside you're mentioning is actually a downside? 20180602 18:39:01<+discordbot5> The cache doesn't need to be cleared instantly, it just needs to be cleared before launching a game. 20180602 18:39:21<+discordbot5> The exact timing is not important as long as it happens and doesn't cause the game to do anything stupid. 20180602 18:39:30< Ravana_> actually, current description works, no need to change 20180602 18:41:19< gfgtdf> shadowm; call_in_main_thread is just slow becasue it involves quite some waiting time, so calling image::flush_cache in call_in_main_thread is slower than just calling image::flush_cache directly, 20180602 18:41:42< gfgtdf> shadowm: call_in_main_thread will always wait until it's passed function is finished. 20180602 18:42:49<+discordbot5> Indeed 20180602 18:42:52<+discordbot5> It spins 20180602 18:44:23<+discordbot5> I wonder if there would be problems if there were an option for it not to spin? 20180602 18:46:11< gfgtdf> Vultraz: well the other uasecases of call_in_main_thread probabl rely on it waiting (those are basicially the erromessages when parsing the cfg filed), but you can try to add an option and use it only for image::flush_cache 20180602 18:49:31<+discordbot5> That’s what I mean 20180602 18:50:18<+discordbot5> In this case it doesn’t really matter I think since pump is called very frequently in the main thread 20180602 18:52:29< gfgtdf> was there a reasonw hy you do the call_in_main_thread in lua gui2 show_dialog ? 20180602 18:54:14< gfgtdf> (a somewhat unrelated issue) 20180602 18:59:01<+discordbot5> What? 20180602 18:59:06<+discordbot5> I didn’t commit that 20180602 18:59:30< gfgtdf> ye, my question was why, did it have bugs ? 20180602 18:59:40<+discordbot5> Shadowm said it changed nothing 20180602 18:59:43<+discordbot5> I think 20180602 18:59:56< gfgtdf> hmm 20180602 19:00:47<+discordbot5> Her thread sanitizer output wasn’t really much different 20180602 19:01:43<+discordbot5> Though actually we should probably get some new tsan output with this fix? 20180602 19:02:32< gfgtdf> hmm though this doesn't mean that this it didn't fix something, if you ahve 15 bugs and fix one the result will probably still loosk similar. 20180602 19:03:06< gfgtdf> i think we shoudl put it in, it vertainly makes sense to handle the gui massages the same way as we do for wesnoth internal error messages. 20180602 19:03:44-!- travis-ci [~travis-ci@ec2-23-22-14-66.compute-1.amazonaws.com] has joined #wesnoth-dev 20180602 19:03:45< travis-ci> gfgtdf/wesnoth#1139 (1.14 - 80350d0 : gfgtdf): The build was broken. 20180602 19:03:45< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/387183203 20180602 19:03:45-!- travis-ci [~travis-ci@ec2-23-22-14-66.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180602 19:04:31<+discordbot5> I suppose 20180602 19:10:11< celticminstrel> Yay Vultraz ignored me. Though I guess it wasn't something important at least. 20180602 19:11:27<+discordbot5> celmin: in reponse to ravana 20180602 19:19:48-!- travis-ci [~travis-ci@ec2-54-80-134-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20180602 19:19:49< travis-ci> gfgtdf/wesnoth#1140 (1.14 - e8329e9 : gfgtdf): The build is still failing. 20180602 19:19:49< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/387187700 20180602 19:19:49-!- travis-ci [~travis-ci@ec2-54-80-134-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180602 19:50:40-!- travis-ci [~travis-ci@ec2-184-73-67-158.compute-1.amazonaws.com] has joined #wesnoth-dev 20180602 19:50:41< travis-ci> gfgtdf/wesnoth#1141 (1.14 - 634e887 : gfgtdf): The build was fixed. 20180602 19:50:41< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/387191140 20180602 19:50:41-!- travis-ci [~travis-ci@ec2-184-73-67-158.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180602 19:51:01-!- gfgtdf [~chatzilla@x4e363ab2.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.8.0/20180430140610]] 20180602 19:58:02< irker271> wesnoth/wesnoth:1.14 Charles Dang e9639b58a4 NR S13: further reduce enemy gold AppVeyor: All builds passed 20180602 20:09:11-!- travis-ci [~travis-ci@ec2-23-22-14-66.compute-1.amazonaws.com] has joined #wesnoth-dev 20180602 20:09:12< travis-ci> gfgtdf/wesnoth#1142 (1.14 - b828281 : gfgtdf): The build was fixed. 20180602 20:09:12< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/387194702 20180602 20:09:12-!- travis-ci [~travis-ci@ec2-23-22-14-66.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180602 20:32:45-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:b9ae:260:cdfc:7f3a] has joined #wesnoth-dev 20180602 20:43:13-!- travis-ci [~travis-ci@ec2-54-80-134-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20180602 20:43:14< travis-ci> gfgtdf/wesnoth#1145 (1.14 - 993eb97 : gfgtdf): The build was broken. 20180602 20:43:14< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/387208083 20180602 20:43:14-!- travis-ci [~travis-ci@ec2-54-80-134-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180602 21:41:01-!- travis-ci [~travis-ci@ec2-54-80-134-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20180602 21:41:02< travis-ci> gfgtdf/wesnoth#1146 (1.14 - d5ed36a : gfgtdf): The build was fixed. 20180602 21:41:02< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/387221347 20180602 21:41:02-!- travis-ci [~travis-ci@ec2-54-80-134-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180602 22:15:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 22:15:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 22:34:20-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180602 22:41:45<+discordbot5> 1.13.10. 20180602 22:42:11<+discordbot5> That's great (irc users: I'm referring to the description of #3204). 20180602 22:51:20-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:b9ae:260:cdfc:7f3a] has quit [Quit: Leaving] 20180602 22:58:22-!- irker271 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180602 23:03:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180602 23:03:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180602 23:18:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180602 23:30:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] --- Log closed Sun Jun 03 00:00:49 2018