--- Log opened Tue Jun 05 00:00:35 2018 --- Day changed Tue Jun 05 2018 20180605 00:00:35< celticminstrel> Well, if they do drop OpenGL I imagine someone could come along and implement the OpenGL API on top of Metal. 20180605 00:00:42<+discordbot5> vk and metal aren't replacements for opengl 20180605 00:00:47<+discordbot5> those are lower level apis 20180605 00:00:59< celticminstrel> From what I saw, Apple seems to see them as replacements. 20180605 00:01:21<+discordbot5> I think opengl will be eventually replaced by some higher level libs based on those lower level apis 20180605 00:01:27<+discordbot5> if it will be replaced 20180605 00:01:51< celticminstrel> ...wait, this seems like a bug. https://wiki.wesnoth.org/index.php?title=EventWML&curid=1389&diff=59749&oldid=59240#unit_placed_.28Version_1.13.3_and_later_only.29 20180605 00:03:16< celticminstrel> This kinda seems a little bad too, is there a way around it? https://wiki.wesnoth.org/index.php?title=DirectActionsWML&curid=1365&diff=59751&oldid=59712 20180605 00:06:15< gfgtdf> well those functions are exactly the functions that are used for human actions so adding flags for allowwing invalid moves would allow people to cheat in mp. 20180605 00:06:33< gfgtdf> there is a falg to disable the interruot on enemy sighted though. 20180605 00:06:57< celticminstrel> gfgtdf: It's the interrupt on enemy sighted that I'm talking about, yes. 20180605 00:08:41< gfgtdf> you can add skip_sighted=all in the move command to disble the interrupt on sighted behviour 20180605 00:10:55< celticminstrel> Please document that somewhere? Probably in the ReplayWML page, I guess? 20180605 00:15:50< Ravana_> finished compiling, seems that simple redirection (>) does not work with wesnoth, had to use nohup to get log to file 20180605 00:16:18< celticminstrel> Windows? 20180605 00:17:13< Ravana_> linux 20180605 00:17:16<+discordbot5> You need to redirect file descriptor 2 (stderr). 20180605 00:17:29<+discordbot5> wesnoth 2> file.txt 20180605 00:20:06< Ravana_> gfgtdf: with your branch I still get "20180605 03:16:23 warning engine: User betrok has unknown game_id: 769" around 30 times per min 20180605 00:21:55< Ravana_> and wesnoth is not responding either 20180605 00:22:30< gfgtdf> so no performcne gain ? 20180605 00:23:22< gfgtdf> hmm 20180605 00:23:26< Ravana_> doesn't seem so - it is not responding 20180605 00:23:56< gfgtdf> but you ran wesnoth just for a few minutes 20180605 00:23:58< Ravana_> 100% cpu 20180605 00:24:44< gfgtdf> i mean even the normal wesnoth does nto give 100% to me there. i thought it was something that woudl stack up slowly and onyl hppen after a few hours after started 20180605 00:26:59< Ravana_> it keeps logging warnings, but stays unresponsive https://vgy.me/rYX28t.png 20180605 00:27:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180605 00:28:26< Ravana_> kicking it with another client worked immediately though 20180605 00:28:54< Ravana_> and after kick it is responding again 20180605 00:29:43< gfgtdf> theese warnins are likely a server side error though 20180605 00:30:21< gfgtdf> it=betrok ? 20180605 00:31:42< Ravana_> checking him with normal release https://vgy.me/FXm4Xj.png 20180605 00:32:02< gfgtdf> so are you saying that the lag disappears when you kick that player ? 20180605 00:32:16< Ravana_> no, when I kicked myself 20180605 00:32:51< gfgtdf> well i don't think that errormessage is relates to the lag that you get. 20180605 00:33:06< gfgtdf> the erromessag hints to a datacorruption on serverside 20180605 00:33:46< gfgtdf> for the client this need to secial handing other than generating the errormessage. 20180605 00:38:28< Ravana_> I tested with local wesnothd too, without any other users, and is still not responding 20180605 00:39:54< gfgtdf> gee i made astupid mistake in my code 20180605 00:42:44< gfgtdf> i pushed another commir to that branch please try again. ()t chnges ust one file to rebuiding should go really fast) 20180605 00:45:22< Ravana_> it is responding at least 20180605 00:46:01< Ravana_> but not sure really how to determine if it is better than with release 20180605 00:46:49< gfgtdf> hmm 20180605 00:47:03< gfgtdf> how often do you freezes with the release 20180605 00:47:39< Ravana_> when I keep other games list closed, very rarely 20180605 00:49:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 00:50:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180605 00:50:05< gfgtdf> hmm 20180605 00:51:13< Ravana_> with 50 users like now I don't expect problems either way 20180605 00:52:17< gfgtdf> ye 20180605 00:56:20< Ravana_> I am in lobby twice with same name, but again server problem 20180605 00:56:41< gfgtdf> hm ? 20180605 00:57:45< gfgtdf> you mean the 'has unknown game_id' thing? 20180605 01:00:19< Ravana_> no, https://github.com/wesnoth/wesnoth/issues/2989 20180605 01:00:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 01:26:44-!- travis-ci [~travis-ci@ec2-54-81-40-192.compute-1.amazonaws.com] has joined #wesnoth-dev 20180605 01:26:45< travis-ci> gfgtdf/wesnoth#1149 (plobby - e7366d9 : gfgtdf): The build passed. 20180605 01:26:45< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/388059602 20180605 01:26:45-!- travis-ci [~travis-ci@ec2-54-81-40-192.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180605 01:33:19< mattsc> While it’s quiet here, I have another basic git question that has been bugging me for a while. 20180605 01:33:25< mattsc> I have two remotes: the default (origin) is my fork, and upstream is the main Wesnoth repo. 20180605 01:33:33< mattsc> Assume I have a simple commit that I want to push directly to upstream. So I pull from upstream, make the change, commit, and then try to push. Now, since the pull somebody else happens to have pushed another commit, so git (CL) refuses to push to upstream and tells me to merge first. 20180605 01:33:57< mattsc> I know how to do that, but since it’s such a simple commit, I just want to push it directly (that’s why I did not go through a brnach or PR in the first place), I don’t want a merge commit also. 20180605 01:34:03< mattsc> So how do I deal with that? 20180605 01:36:15<+discordbot5> use git pull --rebase to pull the new changes 20180605 01:38:04< mattsc> @sevu Hmm, I thought I had tried that and that gave me a merge commit. But it’s been a while and it is quite likely that I misremember. Thanks. 20180605 02:04:13-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180605 02:04:13-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Disconnected by services] 20180605 02:04:13-!- celmin is now known as celticminstrel 20180605 02:04:33-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180605 02:04:51-!- Ivanovic_ [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180605 02:05:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer] 20180605 02:06:46-!- Ivanovic_ is now known as Ivanovic 20180605 02:49:39-!- irker106 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180605 03:15:42-!- irker989 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180605 03:15:42< irker989> wesnoth/wesnoth:1.14 Iris Morelle 79812a853e Don't allow [kill] animate=yes to scroll AppVeyor: All builds passed 20180605 03:28:57< mattsc> Huh. Looks like I don’t need to speed up ai_helper.get_units_with_moves() any more. gfgtdf’s fix already seems to have taken care of that. Cool. 20180605 03:29:11< celticminstrel> Hmm? 20180605 03:29:38< celticminstrel> Are you talking about the [and] [or] [not] fix? 20180605 03:29:45< mattsc> Actually, that might only be for enclave’s test case ... 20180605 03:29:53< mattsc> Yes. 20180605 03:30:20< mattsc> I guess I need to create my own test case. 20180605 03:36:44< mattsc> To clarify, the “Yes.” refers to “Are you talking about the [and] [or] [not] fix?”, not my line after that. 20180605 03:53:38< irker989> wesnoth: sigurdfdragon wesnoth:1.14 36dd2a0f2d0f / data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg: DW: Fix #3207 https://github.com/wesnoth/wesnoth/commit/36dd2a0f2d0f93cad86a7ba2cba81e386a56168b 20180605 03:53:40< irker989> wesnoth: sigurdfdragon wesnoth:1.14 c1d522afa2f2 / changelog.md players_changelog.md: Update changelogs https://github.com/wesnoth/wesnoth/commit/c1d522afa2f28901de0107f8e8b44986c5f0356d 20180605 03:54:16< celticminstrel> Oh nice. 20180605 03:55:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180605 03:58:53< irker989> wesnoth: sigurdfdragon wesnoth:master 85ba7797b23f / data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg: DW: Fix #3207 https://github.com/wesnoth/wesnoth/commit/85ba7797b23fd2a98af33b61bfe22ea3e5f56f94 20180605 03:58:55< irker989> wesnoth: sigurdfdragon wesnoth:master c9c689da668e / changelog.md players_changelog.md: Update changelogs https://github.com/wesnoth/wesnoth/commit/c9c689da668e40d17e54cb8b2d8479a9df7149fc 20180605 04:10:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180605 04:10:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180605 04:29:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180605 04:43:28<+discordbot5> If you’re taking that bug, do recall my proposed fix (that I didn’t commit) was adding a force parameter to that function with the problematic if block and using it to bypass the first condition when loading a scenario. But I didn’t really like it since it blocked the UI at a weird place when loading from the fadeout. 20180605 04:45:04<+discordbot5> I'll debug it and look for other possibilities. 20180605 05:02:38<+discordbot5> WEAK POINTERS 20180605 05:02:43<+discordbot5> that's what I need 20180605 05:02:53-!- 07IAC5JRZ [~quassel@188.79.96.255] has joined #wesnoth-dev 20180605 05:02:53-!- 7GHAAWPP3 [~quassel@188.79.96.255] has joined #wesnoth-dev 20180605 05:03:12<+discordbot5> sleep indeed improves thinking 20180605 05:07:03<+discordbot5> or actually, no, maybe it is enable_shared_from_this that I need 20180605 05:07:23<+discordbot5> since I'm you're assigning a shared_ptr to this 20180605 05:08:22<+discordbot5> You're reassigning this? It's undefined behavior IIRC. 20180605 05:09:40<+discordbot5> No, I'm assigning this as the value of a shared_ptr object 20180605 05:10:46<+discordbot5> Ah, okay. enable_shared_from_this is indeed one way to do it, although it would be better to get a shared_ptr from the owner of this. 20180605 05:12:44<+discordbot5> well, it's in the tree_view. The tree view has pointers to the root and selected nodes 20180605 05:12:56<+discordbot5> and the nodes do thus: get_tree_view().selected_item_ = this; 20180605 05:13:19<+discordbot5> they're assigning themselves as the value of a pointer in the tree view which owns all nodes 20180605 05:13:42<+discordbot5> so I'm not entirely sure if weak_ptr or enable_shared_from_this is correct 20180605 05:14:11<+discordbot5> It would be better design to have the selected_item_ assignment in the tree_view, not in the node. 20180605 05:14:36<+discordbot5> The nodes don't own themselves and thus shouldn't create owning pointers to themselves. 20180605 05:14:51<+discordbot5> Also, selected_item_ probably shouldn't be an owning pointer. 20180605 05:15:16<+discordbot5> weak_ptr, then 20180605 05:16:20<+discordbot5> Or a raw pointer, if you're certain that it can't end up pointing to a destroyed node. 20180605 05:18:24<+discordbot5> it can't be raw since i need it to be shared in one place 20180605 05:18:34<+discordbot5> well, actually 20180605 05:18:37<+discordbot5> this on ecan be raw 20180605 05:18:47<+discordbot5> it's the root node ptr that can't.. 20180605 05:19:09<+discordbot5> cpp content_grid()->set_child(root_node_, 0, 0, grid::VERTICAL_GROW_SEND_TO_CLIENT | grid::HORIZONTAL_GROW_SEND_TO_CLIENT, 0); 20180605 05:19:20<+discordbot5> set_child now takes ashared_ptr 20180605 05:20:31<+discordbot5> wait 20180605 05:20:40<+discordbot5> what assigns that 20180605 05:21:02<+discordbot5> root_node_ is not assigned outside the class 20180605 05:32:07-!- 07IAC5JRZ [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180605 05:32:07-!- 7GHAAWPP3 [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180605 05:32:33< irker989> wesnoth: Jyrki Vesterinen wesnoth:1.14 1fb9378df14e / src/ (savegame.cpp sound.cpp sound.hpp): Fix #2602: music doesn't change immediately on loading a save https://github.com/wesnoth/wesnoth/commit/1fb9378df14eacd84b416817c283685552577400 20180605 05:32:35< irker989> wesnoth: Jyrki Vesterinen wesnoth:1.14 44c373de74c3 / changelog.md players_changelog.md: Changelog entry for commit 1fb9378df14eacd84b416817c283685552577400 https://github.com/wesnoth/wesnoth/commit/44c373de74c316cc6dd6df54895e9ab0ec2e595b 20180605 05:32:53< irker989> wesnoth/wesnoth:master Iris Morelle 4e37cdc713 Don't allow [kill] animate=yes to scroll AppVeyor: All builds passed 20180605 05:33:07<+discordbot5> oh come on. That simple? 20180605 05:40:44< irker989> wesnoth: Jyrki Vesterinen wesnoth:master 94b69e028125 / src/ (savegame.cpp sound.cpp sound.hpp): Fix #2602: music doesn't change immediately on loading a save https://github.com/wesnoth/wesnoth/commit/94b69e028125f344dbb0e8fc1a76845891b291f2 20180605 05:40:46< irker989> wesnoth: Jyrki Vesterinen wesnoth:master b7c1007f34f6 / changelog.md players_changelog.md: Changelog entry for commit 94b69e028125f344dbb0e8fc1a76845891b291f2 https://github.com/wesnoth/wesnoth/commit/b7c1007f34f6e5ff9c15e14b4cf1334b45749237 20180605 05:40:51<+discordbot5> ok, so the root node should be a shared_ptr 20180605 05:41:04<+discordbot5> then I think ill make selected node weak 20180605 05:41:16<+discordbot5> and the parent_node ptr in the nodes also weak 20180605 05:46:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180605 05:46:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180605 05:52:51< wedge009> For whatever it's worth, my own opinion on the GH acquisition is to take a 'wait and see' approach. I certainly have reservations about MS ownership and while there were a variety of reasons I stopped using Skype but MS ownership definitely contributed there. 20180605 06:11:00-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180605 06:11:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180605 06:12:02<+discordbot5> @jyrkive Okay, now when loading saves with from the same scenario currently being played, the music selection logic runs again and you either get the current track rewound to the start, or have a chance for the game to select another track (with the default of shuffle=yes anyway). 20180605 06:12:18-!- gallaecio [~quassel@220.red-79-150-211.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180605 06:12:29<+discordbot5> 1.12 would continue playing the current track. 20180605 06:13:28< wedge009> I was in the process of testing that as well. That's my recollection of behaviour before 1.12 - I liked that 1.12 didn't reset the track on a load. 20180605 06:14:47<+discordbot5> I'm in the middle of playtesting my own campaign so it's reload central here right now. 20180605 06:28:05<+discordbot5> @shadowm Should I do something to prevent it, then? 20180605 06:28:18<+discordbot5> Preferably? 20180605 06:28:38<+discordbot5> OK, I can have a look today or tomorrow. 20180605 07:13:53-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180605 07:18:20-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 268 seconds] 20180605 07:21:20<+discordbot5> hmmmm....making this a weak_ptr might be a bit unwieldy, though.... 20180605 07:21:33-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180605 07:22:41<+discordbot5> Why? Is there some situation where the selected_node pointer is the only thing keeping a node alive? 20180605 07:22:53<+discordbot5> (If there is, it sounds like horrible design.) 20180605 07:25:25-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 256 seconds] 20180605 07:25:32<+discordbot5> It seems that the tree_view class itself should have the responsibility for handling the locking and managing of the ptr's state. Yet the way it's designed now, the ptr is managed by the nodes through the tree itself. 20180605 07:26:37<+discordbot5> I still don't follow why it should be an owning pointer. 20180605 07:26:59<+discordbot5> no, I think you're right that it shouldn't be 20180605 07:27:22<+discordbot5> this is in the dtor, for one: cpp if(tree_view_ && get_tree_view().selected_item_.get() == this) { get_tree_view().selected_item_ = nullptr; } 20180605 07:27:55<+discordbot5> can be removed if I use a weak_ptr.. 20180605 07:28:23<+discordbot5> Uh. If selected_item_ is a shared_ptr, that if condition can never be true. 20180605 07:28:38<+discordbot5> it's a raw ptr right now 20180605 07:28:56<+discordbot5> If there are any shared_ptrs which point to the node, the node can't be destroyed and its destructor can't be called. 20180605 07:29:14<+discordbot5> right. which is why I say you're right that it should be a weak_ptr 20180605 07:30:18<+discordbot5> I'm just trying to figure out who should handle the locking 20180605 07:31:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 07:34:04-!- fabi [~fabi@200116b82bc32000194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 07:34:04-!- fabi [~fabi@200116b82bc32000194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Changing host] 20180605 07:34:04-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 07:53:04<+discordbot5> It just occurred to me that perhaps the race icons should be displayed in the race pages in the help browser. 20180605 07:54:25<+discordbot5> Also uh. 20180605 07:55:23<+discordbot5> Nameless units are no longer displayed with their type name as the [message] caption. 20180605 07:56:09<+discordbot5> huh 20180605 07:56:14<+discordbot5> oh well 20180605 07:58:00<+discordbot5> it'd be easy enough to restore if you think it's important 20180605 08:02:31<+discordbot5> Yeah it's not exactly trivial it turns out. 20180605 08:02:53<+discordbot5> The code refers to a type_name field that doesn't exist. 20180605 08:03:03<+discordbot5> It also doesn't account for the unit name being an empty string. 20180605 08:06:05<+discordbot5> This patch works but it doesn't take into account the unit's gender and I don't see any obvious way (according to the wiki at least) to get gender variations of unit types: https://gist.github.com/shikadiqueen/79b48b7a3ae1b2719d0629c458f2907b 20180605 08:08:17<+discordbot5> good enough, I think 20180605 08:08:57<+discordbot5> No. 20180605 08:09:02<+discordbot5> :\ 20180605 08:09:29<+discordbot5> many places in the game use unit_type::type_name() without accounting for gender 20180605 08:10:15<+discordbot5> And that's unfortunate because while it often doesn't make a difference in English (but see Dark Sorcerer vs. Dark Sorceress), it makes a hell of a lot of difference in romance languages and others. 20180605 08:14:16<+discordbot5> It seems like internally there's a way to get the gendered unit type variation (but not unit type variations or gendered variations of unit type variations). 20180605 08:14:32<+discordbot5> But I don't understand the code well enough to understand what the user-facing side of this is. 20180605 08:14:58<+discordbot5> src/scripting/lua_unit_type.cpp line 209. 20180605 08:15:43<+discordbot5> Okay, it seems to account for variations but not variation gender variations. 20180605 08:16:04<+discordbot5> And they're all lumped together in the same parameter making male and female special cases of the variation id? 20180605 08:16:36<+discordbot5> seems so 20180605 08:16:52<+discordbot5> But how is impl_unit_type_lookup called? 20180605 08:17:17<+discordbot5> What causes it to be called? 20180605 08:18:03<+discordbot5> Oh, it's the index function. 20180605 08:18:51<+discordbot5> So that means wesnoth.unit_types["Dark Sorcerer", "female"].name should do what I think it should do... 20180605 08:19:31<+discordbot5> Except the [] syntax does not allow more than 1 parameter. 20180605 08:19:34<+discordbot5> What is the point then? 20180605 08:20:24<+discordbot5> jyrki is more familiar with this code than I am 20180605 08:21:30<+discordbot5> Hang on... 20180605 08:21:36<+discordbot5> I don't know why it accepts multiple parameters, either. 20180605 08:21:41<+discordbot5> btw I have a question 20180605 08:21:58<+discordbot5> legend of wesmere has a super hard mission where you team a human vs thousands of orcs 20180605 08:22:01<+discordbot5> if(const unit_type* base = *static_cast(luaL_testudata(L, 1, UnitTypeTable))) { 20180605 08:22:05<+discordbot5> is that mission fixed past few years 20180605 08:22:19<+discordbot5> What is parameter 1 in the context of the index method again? 20180605 08:22:31<+discordbot5> the type name? 20180605 08:22:54<+discordbot5> No, in general. 20180605 08:23:19<+discordbot5> "If it is a function, it is called with table and key as arguments" 20180605 08:23:33<+discordbot5> So parameter 1 is the table itself. 20180605 08:24:04-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180605 08:25:05<+discordbot5> It sounds like wesnoth.unit_types["Dark Sorcerer"].female.name is supposed to work but it doesn't. 20180605 08:26:31<+discordbot5> I'm so confused. I'll just file a bug. 20180605 08:27:05-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 265 seconds] 20180605 08:27:26-!- fabi_ [~fabi@200116b82b87e300194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 08:28:03-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180605 08:35:08<+discordbot5> Ohhhhhhh I found the solution. 20180605 08:36:35<+discordbot5> yes? 20180605 08:40:38<+discordbot5> (would it be weird to call shared_from_this() via a raw pointer?) 20180605 08:41:02<+discordbot5> No. 20180605 08:41:29<+discordbot5> It's preferable to only use owning pointers to construct more owning pointers, though. 20180605 08:43:53<+discordbot5> I'm moving the assignment logic to tree_view 20180605 08:43:56<+discordbot5> cpp void tree_view::set_selected_node_to(tree_view_node* new_node, const bool deselect_previous) { if(deselect_previous) { auto node_lock = selected_item_.lock(); if(node_lock && node_lock->label_) { node_lock->label_->set_value(false); } } #ifdef HAVE_CXX17 selected_item_ = new_node->weak_from_this(); #else selected_item_ = new_node->shared_from_this(); #endif } 20180605 08:44:43< irker989> wesnoth: Iris Morelle wesnoth:1.14 1b7557a2ca06 / changelog.md data/lua/wml/message.lua: Fall back to the unit type name for [message] captions for nameless units https://github.com/wesnoth/wesnoth/commit/1b7557a2ca06dce19a8484b1c5f23d2b8a0161bb 20180605 08:44:53< irker989> wesnoth: Iris Morelle wesnoth:master 051182fa1c6f / changelog.md data/lua/wml/message.lua: Fall back to the unit type name for [message] captions for nameless units https://github.com/wesnoth/wesnoth/commit/051182fa1c6fa75184d991920ff4e8e84831a848 20180605 08:45:17<+discordbot5> It would be better to receive new_node directly as a weak_ptr if possible. 20180605 08:45:34<+discordbot5> Also, node_lock isn't a good name because the object isn't a lock. 20180605 08:46:29<+discordbot5> reason I used a raw ptr is so I can conditionally use either weak_from_this or shared_from_this 20180605 08:47:08<+discordbot5> That's not a good reason. 20180605 08:47:59<+discordbot5> If your point is that you'd otherwise have to duplicate the weak_from_this()/shared_from_this() choice in other places, just use shared_from_this() unconditionally. 20180605 08:48:14<+discordbot5> You don't win any prizes for using C++17 whenever possible. 20180605 08:49:01<+discordbot5> (And of course, the point would be to completely avoid using shared_from_this() anywhere. If possible, owning pointers should only be constructed from other owning pointers.) 20180605 08:50:03<+discordbot5> this->shared_from_this() is frowned upon? 20180605 08:50:12<+discordbot5> Yes. 20180605 08:50:28<+discordbot5> even if this is managed by an owning ptr? 20180605 08:50:44<+discordbot5> Yes. Just copy the original owning pointer instead. 20180605 08:51:34<+discordbot5> It doesn't make much sense that you hand ownership of an object somewhere when you don't even have it yourself. 20180605 08:53:17<+discordbot5> copying the shared ptr that owns this would be complicated 20180605 08:53:42<+discordbot5> In that case you can use shared_from_this(). 20180605 08:54:05<+discordbot5> I'd need to search the parent node's children until I found this 20180605 08:59:46<+discordbot5> ok, now, for the parent_node_ ptr. I'm thinking that one should also be a weak_ptr, since child nodes shouldn't prevent the destruction of a parent node. 20180605 09:00:06<+discordbot5> Agreed. 20180605 09:00:41<+discordbot5> And, again, it can also be a raw pointer if you know for sure that the parent can't be destroyed before the children. 20180605 09:14:11-!- fabi [~fabi@200116b82b9ea400194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 09:14:11-!- fabi [~fabi@200116b82b9ea400194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Changing host] 20180605 09:14:11-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 09:14:17-!- fabi_ [~fabi@200116b82b87e300194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Ping timeout: 260 seconds] 20180605 09:28:34-!- fabi_ [~fabi@200116b82bae4f00194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 09:29:00-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds] 20180605 09:36:22-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer] 20180605 09:37:07-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20180605 09:53:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 10:03:35< irker989> wesnoth/wesnoth:1.14 sigurdfdragon c1d522afa2 Update changelogs AppVeyor: All builds passed 20180605 10:03:39-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.] 20180605 10:09:44-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180605 10:11:13< gfgtdf> why do you want to use shared_ptr there in the first place? 20180605 10:24:28-!- zookeeper_ [~lmsnie@95.175.104.23] has joined #wesnoth-dev 20180605 10:25:37-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 248 seconds] 20180605 10:28:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180605 10:53:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180605 10:53:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180605 11:03:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 11:30:30< irker989> wesnoth: loonycyborg wesnoth:master a25180893344 / src/server/ (server.cpp server.hpp): wesnothd: avoid needlessly casting pointer to long int https://github.com/wesnoth/wesnoth/commit/a25180893344c6a99013e6b94eb3cb7110b1d987 20180605 11:30:32< irker989> wesnoth: loonycyborg wesnoth:master 0c0bf7f91d76 / src/server/forum_user_handler.cpp: wesnothd: fix server terminating in response to unregistered login https://github.com/wesnoth/wesnoth/commit/0c0bf7f91d7654a7ac83861236b5e0589e1bbcaf 20180605 11:33:55< irker989> wesnoth: loonycyborg wesnoth:1.14 608d39f45ad8 / src/server/ (server.cpp server.hpp): wesnothd: avoid needlessly casting pointer to long int https://github.com/wesnoth/wesnoth/commit/608d39f45ad8c6029037f25a89baa0e33d31ef8e 20180605 11:33:57< irker989> wesnoth: loonycyborg wesnoth:1.14 65643adab840 / src/server/forum_user_handler.cpp: wesnothd: fix server terminating in response to unregistered login https://github.com/wesnoth/wesnoth/commit/65643adab840d1ad09e4dc5d366bb5c9da0c1a06 20180605 11:34:29<+discordbot5> FYI, here is some analysis about what Microsoft will likely do soon after the GitHub acquisition: https://siliconangle.com/blog/2018/06/04/microsofts-github-takeover-sends-shockwaves-open-source-developer-ecosystem/ 20180605 11:50:15-!- fabi [~fabi@200116b82becd200194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 11:50:15-!- fabi [~fabi@200116b82becd200194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Changing host] 20180605 11:50:15-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 11:51:08-!- fabi_ [~fabi@200116b82bae4f00194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Ping timeout: 255 seconds] 20180605 11:55:19-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180605 11:56:38-!- fabi_ [~fabi@200116b82b0e7300194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 11:57:49-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180605 11:58:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 12:00:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 12:03:01-!- fabi [~fabi@200116b82b232f00194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 12:03:01-!- fabi [~fabi@200116b82b232f00194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Changing host] 20180605 12:03:01-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 12:03:08-!- fabi_ [~fabi@200116b82b0e7300194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Ping timeout: 265 seconds] 20180605 12:07:59-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection] 20180605 12:08:43-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180605 12:12:24-!- fabi_ [~fabi@200116b82b6d1900194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 12:12:47-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20180605 12:21:23< irker989> wesnoth/wesnoth:1.14 Jyrki Vesterinen 44c373de74 Changelog entry for commit 1fb9378df14ea AppVeyor: All builds passed 20180605 12:24:28-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection] 20180605 12:36:47-!- fabi [~fabi@200116b82b855f00194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 12:36:47-!- fabi [~fabi@200116b82b855f00194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Changing host] 20180605 12:36:47-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 12:36:58-!- fabi_ [~fabi@200116b82b6d1900194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Ping timeout: 265 seconds] 20180605 12:46:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180605 12:55:09-!- fabi_ [~fabi@200116b82b8f0600194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 12:55:20-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180605 13:21:46-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180605 13:26:46-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 264 seconds] 20180605 13:33:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180605 13:34:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180605 13:45:06-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180605 13:50:57<+discordbot5> how nice. somewhere since my last compile I introduced something that causes the game to crash at the main menu with release builds, but not debug.... 20180605 13:51:31<+discordbot5> guess that usually means it's use after free.... 20180605 13:54:16<+discordbot5> Exception thrown at 0x77AE8012 (ntdll.dll) in wesnoth.exe: 0xC0000005: Access violation reading location 0x00000001. 20180605 13:54:18<+discordbot5> uhhh.... 20180605 13:54:36-!- fabi [~fabi@200116b82b9e2700194cb6385a78b8c0.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 13:54:36-!- fabi [~fabi@200116b82b9e2700194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Changing host] 20180605 13:54:36-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 13:54:56-!- fabi_ [~fabi@200116b82b8f0600194cb6385a78b8c0.dip.versatel-1u1.de] has quit [Ping timeout: 276 seconds] 20180605 13:55:04<+discordbot5> Release-specific crashes are often undefined behavior. 20180605 13:56:04-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Client Quit] 20180605 14:04:17-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 14:09:31<+discordbot5> oh. huh. it actually crashes mid-loading screen.... not at the main menu. 20180605 14:09:32<+discordbot5> great 20180605 14:13:10<+discordbot5> does VS have some ubsan equivalent 20180605 14:13:27<+discordbot5> No, it doesn't. 20180605 14:13:41<+discordbot5> this is unfortunate 20180605 14:15:13<+discordbot5> hm 20180605 14:15:18<+discordbot5> perhaps this is the error I want 20180605 14:15:25<+discordbot5> Unhandled exception at 0x77B78E79 (ntdll.dll) in wesnoth.exe: 0xC0000374: A heap has been corrupted (parameters: 0x77BB5890). 20180605 14:22:40-!- fabi_ [~fabi@200116b82bbe97003069960b7a0f6e97.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 14:22:49-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180605 14:27:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180605 14:27:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 14:28:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20180605 14:28:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 14:33:56-!- fabi_ [~fabi@200116b82bbe97003069960b7a0f6e97.dip.versatel-1u1.de] has quit [Quit: Konversation terminated!] 20180605 14:38:05-!- fabi [~fabi@200116b82bbe9700fdecde50f7ddbe22.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 14:38:05-!- fabi [~fabi@200116b82bbe9700fdecde50f7ddbe22.dip.versatel-1u1.de] has quit [Changing host] 20180605 14:38:05-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 14:55:28-!- fabi_ [~fabi@200116b82beb7300fdecde50f7ddbe22.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 14:55:34< irker989> wesnoth/wesnoth:1.14 Iris Morelle 1b7557a2ca Fall back to the unit type name for [mes AppVeyor: All builds passed 20180605 14:56:10-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180605 15:22:50-!- fabi [~fabi@200116b82b17ad00fdecde50f7ddbe22.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 15:22:50-!- fabi [~fabi@200116b82b17ad00fdecde50f7ddbe22.dip.versatel-1u1.de] has quit [Changing host] 20180605 15:22:50-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 15:23:20-!- fabi_ [~fabi@200116b82beb7300fdecde50f7ddbe22.dip.versatel-1u1.de] has quit [Ping timeout: 276 seconds] 20180605 15:32:36-!- gallaecio [~quassel@220.red-79-150-211.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180605 15:58:06-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180605 15:58:10-!- gallaecio_ [~quassel@188.79.96.255] has joined #wesnoth-dev 20180605 17:08:16-!- fabi_ [~fabi@200116b82b9faa00fdecde50f7ddbe22.dip.versatel-1u1.de] has joined #wesnoth-dev 20180605 17:08:36-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180605 17:14:20-!- fabi [~fabi@mue-88-130-62-114.dsl.tropolys.de] has joined #wesnoth-dev 20180605 17:14:20-!- fabi [~fabi@mue-88-130-62-114.dsl.tropolys.de] has quit [Changing host] 20180605 17:14:20-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180605 17:15:35-!- fabi_ [~fabi@200116b82b9faa00fdecde50f7ddbe22.dip.versatel-1u1.de] has quit [Ping timeout: 255 seconds] 20180605 17:19:15<+discordbot5> I'm completely at a loss how to debug this further 20180605 17:19:18<+discordbot5> 😦 20180605 17:29:35-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180605 17:29:42-!- gallaecio_ is now known as gallaecio 20180605 17:31:58-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180605 17:35:14< irker989> wesnoth/wesnoth:master loonycyborg 0c0bf7f91d wesnothd: fix server terminating in resp AppVeyor: All builds passed 20180605 17:43:10< irker989> wesnoth: Jyrki Vesterinen wesnoth:1.14 91d35e3d8666 / src/ (savegame.cpp sound.cpp sound.hpp): Revert "Fix #2602: music doesn't change immediately on loading a save" https://github.com/wesnoth/wesnoth/commit/91d35e3d8666478c34d31f734c63c04a17d9584c 20180605 17:43:12< irker989> wesnoth: Jyrki Vesterinen wesnoth:1.14 544b68d7a7cc / src/ (5 files in 2 dirs): Fix #2602: music doesn't change immediately on loading a save https://github.com/wesnoth/wesnoth/commit/544b68d7a7ccafbde150356de332bbadd6669580 20180605 17:45:26< irker989> wesnoth: Jyrki Vesterinen wesnoth:master cafede479c70 / src/ (savegame.cpp sound.cpp sound.hpp): Revert "Fix #2602: music doesn't change immediately on loading a save" https://github.com/wesnoth/wesnoth/commit/cafede479c70cbc2d70d052fd0c51e5c5440fa57 20180605 17:45:28< irker989> wesnoth: Jyrki Vesterinen wesnoth:master 91afbfd58685 / src/ (5 files in 2 dirs): Fix #2602: music doesn't change immediately on loading a save https://github.com/wesnoth/wesnoth/commit/91afbfd5868595e29a3147748c78652c88d6323e 20180605 17:46:09<+discordbot5> @shadowm The new fix doesn't restart the music when you reload a save from the same scenario (or any scenario which has the currently playing track in its playlist). 20180605 17:56:59<+discordbot5> ok, this makes no sense. I modified no files besides the tree view after last confirmed i could launch the game successfully. And there are no tree views in the loading screen 20180605 18:01:57-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180605 18:33:39<+discordbot5> Was there still a plan to convert to OpenGL, or not really? 20180605 18:36:23-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:386f:1a31:142d:aaad] has joined #wesnoth-dev 20180605 18:36:37<+discordbot5> The plan is to convert the rendering pipeline to OpenGL. 20180605 18:39:55-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180605 18:44:35<+discordbot5> Did you see Apple is deprecating OGL starting with macOS 10.14? 20180605 18:45:13<+discordbot5> Yep. 20180605 18:46:06<+discordbot5> What does that mean for us? 20180605 18:46:33<+discordbot5> Nothing yet. Deprecation isn't the same thing as removal. 20180605 18:47:18<+discordbot5> And it's possible that someone will develop an OpenGL-on-Metal wrapper, similar to ANGLE or MoltenVK. 20180605 18:47:23<+discordbot5> I am aware, but I want to be forward-thinking here. 20180605 18:48:27<+discordbot5> Ie, can we rely on our engine using OGL without losing Mac support in the next few years 20180605 18:48:38<+discordbot5> Support for wesnoth, that is. 20180605 18:49:46<+discordbot5> At the same time, we don't have anywhere near enough manpower to also develop a Metal backend. 20180605 18:50:06<+discordbot5> Indeed 20180605 18:50:22< aeth> You might wind up with OpenGL-on-Vulkan-on-Metal. 20180605 18:53:22< aeth> Well, there's this for OpenGL ES. https://chromium.googlesource.com/angle/angle/+/master/README.md 20180605 18:53:38< aeth> In progress Vulkan support. No Metal column. 20180605 18:54:16-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection] 20180605 18:54:19<+discordbot5> It's likely that Google will start working on a Metal backend now. 20180605 18:54:45<+discordbot5> They don't exactly want WebGL to break in Chrome on macOS because of Apple's whims. 20180605 19:01:01-!- zookeeper_ is now known as zookeeper 20180605 19:01:03-!- zookeeper [~lmsnie@95.175.104.23] has quit [Changing host] 20180605 19:01:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180605 19:08:22-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Read error: Connection reset by peer] 20180605 19:08:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180605 19:15:52-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180605 19:19:20<+discordbot5> OH 20180605 19:19:56<+discordbot5> maybe the bug is here.. 20180605 19:20:34<+discordbot5> oh, but wait, no, that's not used 20180605 19:20:36<+discordbot5> dammit! 20180605 19:25:46<+discordbot5> I di dnotice this... 20180605 19:25:48<+discordbot5> Exception thrown at 0x75DED722 in wesnoth.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x0353D0C8. 20180605 19:27:25<+discordbot5> ok, I figured out how to get VS to break on that.. 20180605 19:27:31<+discordbot5> let's see what's going on with that..... 20180605 19:28:08<+discordbot5> doesn't seem like anything important... 20180605 19:28:30<+discordbot5> what is the rgb value for experience? 20180605 19:28:40<+discordbot5> 255,0,255? 20180605 19:28:45-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:386f:1a31:142d:aaad] has quit [Remote host closed the connection] 20180605 19:28:45<+discordbot5> eh? 20180605 19:28:59<+discordbot5> like hp is completely green, I think 20180605 19:29:07<+discordbot5> damage is fully red 20180605 19:29:23<+discordbot5> it varies 20180605 19:29:33< Ravana_> just like hp, xp depends on its current % 20180605 19:29:52<+discordbot5> I'll just use solid violet and see how it looks 20180605 19:32:43<+discordbot5> perhaps I need a ReleaseDebug build 20180605 19:34:09<+discordbot5> worth a try 20180605 19:58:32< irker989> wesnoth/wesnoth:1.14 loonycyborg 65643adab8 wesnothd: fix server terminating in resp AppVeyor: All builds passed 20180605 20:41:06<+discordbot5> OH COME ON. 20180605 20:41:12<+discordbot5> the RD build works too 20180605 20:42:54<+discordbot5> ...............and now the regular one seems to work too 20180605 20:42:56<+discordbot5> WHAT THE HELL 20180605 20:43:07<+discordbot5> bugs don't just magically vanish 20180605 20:43:34<+discordbot5> Maybe it's timing-related and thus only occurs randomly? 20180605 20:44:07<+discordbot5> it was consistently occurring 20180605 20:44:53<+discordbot5> i suppose it's possible there was some issue in the cached compiled files 20180605 20:45:47<+discordbot5> since the RD build basically rebuilt everything 20180605 20:46:09<+discordbot5> anyway 20180605 20:46:17<+discordbot5> I'm not gonna question it further 20180605 20:46:24<+discordbot5> >_> 20180605 20:46:29<+discordbot5> moving on 20180605 20:46:40<+discordbot5> you said i should use dynamic_pointer_cast for downcasting? 20180605 20:47:06<+discordbot5> That's what I tend to use personally. 20180605 20:47:36<+discordbot5> However, you can also use static_pointer_cast if you know for sure that the object is of the right type. 20180605 20:47:54<+discordbot5> (If it's not, static_pointer_cast results in UB.) 20180605 20:51:34<+discordbot5> oh hell. now it looks like my crash is back...just in a different place. 20180605 20:51:48<+discordbot5> it's always during the loading screen...... 20180605 20:52:13<+discordbot5> Access violation reading location 0x00000000 20180605 20:59:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180605 20:59:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180605 21:37:46-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180605 21:38:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180605 21:40:17<+discordbot5> Um. 20180605 21:40:51<+discordbot5> I just attacked a Soulless bat with an archer and it played the defense/hit sound for every arrow despite all of them missing. 20180605 22:24:00<+discordbot5> # Do not change to SOUND:HIT, this has to remain a hit_sound_frame 20180605 22:24:27<+discordbot5> This is the difference between the DEFENSE_ANIM macro and the bats sound 20180605 22:24:49<+discordbot5> unfortunatelr the comment doesn't go into details 20180605 22:28:51<+discordbot5> the bat uses SOUND:HIT, which in turn places an [attack_sound_frame], the DEFENSE_ANIM would place a [hit_sound_frame]. I read in the wiki that the preoix to frame can be arbitary, although I guess that this is not fully documented, as [missile_frame] is treate differently than other frame 20180605 22:29:11<+discordbot5> *prefix 20180605 22:29:23<+discordbot5> Is it? 20180605 22:29:31<+discordbot5> Also remember this is the Soulless bat, not the regular bats. 20180605 22:29:56<+discordbot5> I looked into the soulless one 20180605 22:30:22<+discordbot5> it has a custom [defend] animation 20180605 22:32:42<+discordbot5> the regular one uses in it's (as well custom) [defend] anim a [frame] tag for sound instead 20180605 22:33:08-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180605 22:39:10<+discordbot5> https://github.com/wesnoth/wesnoth/commit/01cd01a661f0b29a92a30ceffbcf77009f035306 20180605 22:44:19<+discordbot5> the fix would probably be to use any other frame than [attack_sound_frame] in [defense] animations .... though why... 20180605 22:59:35-!- irker989 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180605 23:48:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 23:49:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 23:53:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180605 23:53:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 23:54:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 23:55:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 23:56:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 23:57:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180605 23:58:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180605 23:59:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] --- Log closed Wed Jun 06 00:00:15 2018