--- Log opened Fri Jun 08 00:00:00 2018
20180608 00:14:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180608 01:10:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180608 01:10:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180608 01:12:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20180608 01:16:37<+discordbot5> <Vultraz> so
20180608 01:17:00<+discordbot5> <Vultraz> after a complete rebuild of my changes, the crash seems to have gone away in all cases
20180608 01:17:12<+discordbot5> <Vultraz> I'm beginning to wonder if it was some compiler screwup
20180608 01:17:57<+discordbot5> <Vultraz> I hadn't been doing a clean rebuild
20180608 01:32:24-!- gfgtdf_ [~gfgtdf@134.76.63.8] has quit [Read error: Connection reset by peer]
20180608 02:21:34-!- irker851 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180608 02:47:40<+discordbot5> <Vazl> Yeah, couldn't figure out how to do what I want via a trait definition, so I got it done via an object instead.
20180608 03:29:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180608 03:50:31-!- irker196 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180608 03:50:31< irker196> wesnoth/wesnoth:1.14 ln-zookeeper ff7aa38e35 Restructured WC/Soulless bat variation d AppVeyor: All builds passed
20180608 04:06:27-!- fabi [~fabi@200116b82b1afd00119a80d610ee1f9b.dip.versatel-1u1.de] has joined #wesnoth-dev
20180608 04:06:27-!- fabi [~fabi@200116b82b1afd00119a80d610ee1f9b.dip.versatel-1u1.de] has quit [Changing host]
20180608 04:06:27-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20180608 04:15:13<+discordbot5> <shadowm> I find myself mystified by the fact that somehow the solution of simply not purging the cache from a thread other than the main thread is somehow not the best one.
20180608 04:16:21<+discordbot5> <shadowm> Bypassing the cache for that dialog alone would probably win a prize in a hacks competition.
20180608 04:16:48< celticminstrel> Sure, sounds good to me.
20180608 04:17:09<+discordbot5> <shadowm> That's not a good thing.
20180608 04:17:35< celticminstrel> No I mean, bypassing the cache sounds good.
20180608 04:17:45<+discordbot5> <shadowm> Nope, it's not.
20180608 04:17:54< celticminstrel> Meh.
20180608 04:18:00<+discordbot5> <shadowm> Because that means giving GUI2 special knowledge about the loading screen's requirements.
20180608 04:18:30<+discordbot5> <shadowm> Basically making it a big design exception and therefore kind of defeating the point of making it a GUI2 dialog in the first place.
20180608 04:19:05<+discordbot5> <shadowm> I mean, sure by all means, it's not an unacceptable solution, but it's not elegant and it doesn't answer the question of why the cache needs to be purged by threads other than the main one.
20180608 04:20:07< celticminstrel> That's true too.
20180608 04:20:33<+discordbot5> <shadowm> It's cleaner from a purely abstract standpoint to just solidify in our API contract that no-one should be calling the image cache API from other threads, than to decide "okay this dialog should be specifically prepared for the possibility of someone calling the image cache API from another thread".
20180608 04:20:57< celticminstrel> I can agree with that.
20180608 04:22:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180608 04:31:48-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev
20180608 05:26:40-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.]
20180608 05:58:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180608 05:58:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180608 06:01:50<+discordbot5> <Vultraz> @jyrkive so, after a total rebuild of clean master and then a total rebuild of my changes (plus 2 cache purges) all the crashes are gone. Do you think it's possible I had run into some weird, insidious compiler issue that screwed up my binary and therefor caused the crash?
20180608 06:02:09<+discordbot5> <jyrkive> Yes, it's one possibility.
20180608 06:02:41<+discordbot5> <jyrkive> Another possibility is that the crash was caused by the linking order the linker used, and will thus randomly occur in future builds.
20180608 06:02:57<+discordbot5> <jyrkive> (But in that case it may not even be caused by your changes to begin with.)
20180608 06:03:07<+discordbot5> <Vultraz> Indeed
20180608 06:03:34<+discordbot5> <Vultraz> I shall proceed... finally.
20180608 06:03:43<+discordbot5> <Vultraz> I've been working on this since Monday 😬
20180608 06:13:14-!- gallaecio [~quassel@4.red-81-39-199.dynamicip.rima-tde.net] has joined #wesnoth-dev
20180608 06:25:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180608 06:34:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180608 06:34:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180608 06:39:11< irker196> wesnoth/wesnoth:master ln-zookeeper 131868581d Restructured WC/Soulless bat variation d AppVeyor: All builds passed
20180608 06:44:18< irker196> wesnoth: Charles Dang wesnoth:1.14 8722221ed498 / src/events.cpp: Ensure events::call_in_main_thread is thread-safe https://github.com/wesnoth/wesnoth/commit/8722221ed4981724fded82aedc8fad2ef99c53c5
20180608 06:49:10<+discordbot5> <Vultraz> is it acceptable to use std::move to assign something if your function takes an object by a copy?
20180608 06:50:08<+discordbot5> <jyrkive> Yes. The function has a private copy and can trash it if it wants.
20180608 07:17:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180608 07:17:45<+discordbot5> <Vultraz> next I shall tackle the vptr errors
20180608 07:18:22<+discordbot5> <Vultraz> I'm just going to add a static type() function that get_control_type() calls
20180608 07:20:08<+discordbot5> <Vultraz> (if someone wants me to use a different name than type() do suggest it now)
20180608 07:25:20-!- travis-ci [~travis-ci@ec2-54-204-112-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 07:25:21< travis-ci> wesnoth/wesnoth#18505 (1.14 - 8722221 : Charles Dang): The build was broken.
20180608 07:25:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389584322
20180608 07:25:21-!- travis-ci [~travis-ci@ec2-54-204-112-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 07:25:50<+discordbot5> <Vultraz> broken, you say
20180608 07:26:21<+discordbot5> <Vultraz> ah
20180608 07:27:03<+discordbot5> <Vultraz> need to include<atomic>
20180608 07:40:21<+discordbot5> <Vultraz> wait, does this static function need be public if I want to access it from elsewhere?
20180608 07:40:39<+discordbot5> <Vultraz> I can't remember if public/private affects static functions...
20180608 07:40:46<+discordbot5> <jyrkive> Yes, it does.
20180608 07:41:02<+discordbot5> <Vultraz> blaaahhh
20180608 08:02:25-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection]
20180608 08:05:56<+discordbot5> <Pentarctagon> by the vptr errors, you mean https://github.com/wesnoth/wesnoth/issues/2400 ?
20180608 08:06:00<+discordbot5> <Vultraz> yes
20180608 08:06:09<+discordbot5> <Pentarctagon> cool
20180608 08:06:26-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20180608 08:06:29<+discordbot5> <Pentarctagon> will be interesting to see if that fixes the boost tests segfaulting with LTO
20180608 08:06:44<+discordbot5> <Vultraz> ¯_(ツ)_/¯
20180608 08:18:09< irker196> wesnoth: Charles Dang wesnoth:master 3d894faf11bb / src/gui/ (86 files in 4 dirs): GUI2: made widget initialization process more secure against memory leaks https://github.com/wesnoth/wesnoth/commit/3d894faf11bba1b214914a7af565f4c712e29a5a
20180608 08:18:11< irker196> wesnoth: Charles Dang wesnoth:master 52f7fcf5cc3d / src/gui/ (64 files in 2 dirs): GUI2: added a public static type getter to all widgets implementing get_control_ https://github.com/wesnoth/wesnoth/commit/52f7fcf5cc3d7446904df90381f467d15d4f5aad
20180608 08:18:14< irker196> wesnoth: Charles Dang wesnoth:master 34195ae65481 / src/gui/ (4 files in 3 dirs): GUI2: removed now-redundant type parameter from build_single_widget_and_cast_to https://github.com/wesnoth/wesnoth/commit/34195ae6548131ef00aa894b4f82c7312fa140da
20180608 08:18:18< irker196> wesnoth: Charles Dang wesnoth:master 58d3cad31581 / src/gui/ (89 files in 4 dirs): Merge branch 'gui2_widget_ptr_init_refactor' https://github.com/wesnoth/wesnoth/commit/58d3cad315817d55e18aba6c79f850ed016d2ebb
20180608 08:18:21<+discordbot5> <Vultraz> @Pentarctagon ^
20180608 08:20:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180608 08:21:28-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180608 08:21:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180608 08:22:23< vn971> I wonder, does [remove_object] work on `apply_to=image_mod` ? It seems that the answer is "no".
20180608 08:23:44<+discordbot5> <Vultraz> I think there’s a bug about that?
20180608 08:24:23< vn971> @Vultraz: can't find any: https://github.com/wesnoth/wesnoth/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+remove_object
20180608 08:25:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20180608 08:25:55< vn971> BTW, I did more tests and I'm now sure it's indeed broken. I've added 1000HP to the same object, and I see units getting their extra HP and losing it when object is removed. The "image_mod" stays forever though.
20180608 08:26:10<+discordbot5> <Pentarctagon> hmm
20180608 08:26:25<+discordbot5> <Pentarctagon> rc/events.cpp:57:7: error: ‘atomic_bool’ in namespace ‘std’ does not name a type   std::atomic_bool finished = false;        ^ src/events.cpp: In constructor ‘{anonymous}::invoked_function_data::invoked_function_data(const std::function<void()>&)’: src/events.cpp:48:5: error: class ‘{anonymous}::invoked_function_data’ does not have any field named ‘finished’    , finished(false)      ^ src/events.cpp: In
20180608 08:26:25<+discordbot5> member function ‘void {anonymous}::invoked_function_data::call()’: src/events.cpp:73:3: error: ‘finished’ was not declared in this scope    finished = true;    ^ src/events.cpp: In function ‘void events::call_in_main_thread(const std::function<void()>&)’: src/events.cpp:740:15: error: ‘struct {anonymous}::invoked_function_data’ has no member named ‘finished’   while(!fdata.finished) {
20180608 08:26:51<+discordbot5> <Vultraz> Oops
20180608 08:26:54<+discordbot5> <Vultraz> Didn’t fix that yet
20180608 08:30:10<+discordbot5> <Vultraz> well i pushed a commit but i dont' see the notif
20180608 08:30:34<+discordbot5> <Vultraz> still, you can pull now
20180608 08:31:52< irker196> wesnoth: Charles Dang wesnoth:1.14 3d93fd3d53aa / src/events.cpp: Added missing <atomic> include https://github.com/wesnoth/wesnoth/commit/3d93fd3d53aa52e5bb50311c5efa0c606d84442d
20180608 08:32:04<+discordbot5> <Vultraz> well that one worked...
20180608 08:32:42<+discordbot5> <Pentarctagon> src/events.cpp:58:30: error: use of deleted function ‘std::atomic<bool>::atomic(const std::atomic<bool>&)’   std::atomic_bool finished = false;                               ^ In file included from src/events.cpp:29:0: /usr/include/c++/5/atomic:66:5: note: declared here      atomic(const atomic&) = delete;      ^ /usr/include/c++/5/atomic:70:15: note:   after user-defined conversion: constexpr
20180608 08:32:42<+discordbot5> std::atomic<bool>::atomic(bool)      constexpr atomic(bool __i) noexcept : _M_base(__i) { }                ^
20180608 08:32:50<+discordbot5> <Vultraz> oh come on
20180608 08:33:14<+discordbot5> <Vultraz> try removing the inline assignment?
20180608 08:33:38<+discordbot5> <Vultraz> ie just make it std::atomic_bool finished;
20180608 08:34:56<+discordbot5> <Pentarctagon> https://pastebin.com/mZQ0vKYW
20180608 08:35:03<+discordbot5> <Pentarctagon> did get farther though
20180608 08:35:30<+discordbot5> <Vultraz> oh. fuck
20180608 08:35:33<+discordbot5> <Vultraz> I forgot to update the tests
20180608 08:35:35<+discordbot5> <Vultraz> gdi
20180608 08:40:49< vn971> wrote down the [remove_object]/"image_mod" issue: https://github.com/wesnoth/wesnoth/issues/3220
20180608 08:43:43< irker196> wesnoth: Charles Dang wesnoth:master 79adc68ef60f / src/tests/gui/ (fire_event.cpp iterator.cpp visitor.cpp): Attempt to update tests for 3d894fa https://github.com/wesnoth/wesnoth/commit/79adc68ef60fbbc7312f19a570c45095f594b61b
20180608 08:43:44<+discordbot5> <Vultraz> @Pentarctagon ^
20180608 08:44:27<+discordbot5> <Pentarctagon> whoa
20180608 08:44:50<+discordbot5> <Pentarctagon> hm
20180608 08:45:13<+discordbot5> <Pentarctagon> do I still need to have just std::atomic_bool finished;?
20180608 08:45:23<+discordbot5> <Vultraz> yes
20180608 08:45:27-!- travis-ci [~travis-ci@ec2-54-90-238-126.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 08:45:28< travis-ci> wesnoth/wesnoth#18506 (master - 58d3cad : Charles Dang): The build is still failing.
20180608 08:45:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389612560
20180608 08:45:28-!- travis-ci [~travis-ci@ec2-54-90-238-126.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 08:46:09< irker196> wesnoth: Charles Dang wesnoth:master 424e0e0ab44f / src/events.cpp: Fixup this atomic_bool again https://github.com/wesnoth/wesnoth/commit/424e0e0ab44f51932c25e7bad364a9602f6c8bc5
20180608 08:47:15< irker196> wesnoth: Charles Dang wesnoth:1.14 9ea4363145a6 / src/events.cpp: Fixup this atomic_bool again https://github.com/wesnoth/wesnoth/commit/9ea4363145a6a13d9f4339791e6f689aeb28279a
20180608 08:47:55<+discordbot5> <Pentarctagon> yeah, whoa
20180608 08:48:23<+discordbot5> <Pentarctagon> https://cdn.discordapp.com/attachments/259976436490829825/454567353393610753/log.log
20180608 08:49:49<+discordbot5> <Vultraz> can you try changing std::make_shared<grid> to std::make_shared<gui2::grid>
20180608 08:49:59<+discordbot5> <Vultraz> in iterator.cpp and fire_event.cpp
20180608 08:51:11<+discordbot5> <Pentarctagon> iterator under src/gui/ or src/tests/?
20180608 08:51:17<+discordbot5> <Vultraz> latter
20180608 08:52:34<+discordbot5> <Pentarctagon> https://cdn.discordapp.com/attachments/259976436490829825/454568410412482560/log.log
20180608 08:53:15<+discordbot5> <Vultraz> same treatment for  gui2::build_single_widget_and_cast_to<label>() -> gui2::build_single_widget_and_cast_to<gui2::label>()
20180608 08:53:25<+discordbot5> <Pentarctagon> same files?
20180608 08:53:44<+discordbot5> <Vultraz> iterator.cpp and visitor.cpp
20180608 08:54:56<+discordbot5> <Pentarctagon> https://cdn.discordapp.com/attachments/259976436490829825/454569004112281600/log.log
20180608 08:55:48<+discordbot5> <Vultraz> yeah just remove that ; in the middle of line 187
20180608 08:55:53<+discordbot5> <Vultraz> in iterator.cpp
20180608 08:57:05<+discordbot5> <Pentarctagon> https://cdn.discordapp.com/attachments/259976436490829825/454569547031379991/log.log
20180608 09:00:23<+discordbot5> <Vultraz> gaaaah
20180608 09:01:28<+discordbot5> <Vultraz> I don't know what's going on here
20180608 09:01:46<+discordbot5> <Vultraz> oh wait
20180608 09:02:12-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20180608 09:02:12-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 09:02:13< travis-ci> wesnoth/wesnoth#18507 (1.14 - 3d93fd3 : Charles Dang): The build is still failing.
20180608 09:02:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389617680
20180608 09:02:13-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 09:02:30<+discordbot5> <Vultraz> @Pentarctagon ok, the lines BOOST_REQUIRE_NE(widget, static_cast<gui2::widget*>(nullptr)); in the three files (fire_event.cpp, visitor.cpp, iterator.cpp`
20180608 09:02:32<+discordbot5> <Vultraz> replace them with
20180608 09:02:38<+discordbot5> <Vultraz> BOOST_REQUIRE_NE(widget.get(), static_cast<gui2::widget*>(nullptr));
20180608 09:05:45<+discordbot5> <Vultraz> does that work?
20180608 09:05:48<+discordbot5> <Pentarctagon> build succeeded
20180608 09:05:50<+discordbot5> <Pentarctagon> 😄
20180608 09:05:55<+discordbot5> <Vultraz> yay!
20180608 09:05:57<+discordbot5> <Vultraz> thanks
20180608 09:06:25< irker196> wesnoth: Charles Dang wesnoth:master ea5945b35785 / src/tests/gui/ (fire_event.cpp iterator.cpp visitor.cpp): Fixup 79adc68 https://github.com/wesnoth/wesnoth/commit/ea5945b357852750c1b72cc08733e8af7eac4601
20180608 09:06:40<+discordbot5> <Vultraz> now, the question is whether it fixes the segfaults
20180608 09:07:12<+discordbot5> <Pentarctagon> looks like it
20180608 09:07:25<+discordbot5> <Pentarctagon> 10 million other gui/draw errors
20180608 09:07:30<+discordbot5> <Pentarctagon> but the segfault is gone
20180608 09:07:49<+discordbot5> <Pentarctagon> ie: 20180608 04:06:50 error gui/draw: Image: 'buttons/scrollbars/scrollbottom.png' not found and won't be drawn.
20180608 09:08:01<+discordbot5> <Vultraz> yeah ignore that
20180608 09:08:13<+discordbot5> <Vultraz> I have no idea why it happens
20180608 09:09:16<+discordbot5> <Vultraz> might be worth noting on the vptr bug the crash is gone
20180608 09:09:26<+discordbot5> <Vultraz> and does this mean we can restore lto to default?
20180608 09:09:53<+discordbot5> <Pentarctagon> it means it would be feasible to add an LTO travis job at -Og
20180608 09:10:00-!- discordbot5 [~discordbo@baldras.wesnoth.org] has quit [Remote host closed the connection]
20180608 09:10:27-!- discordbot1 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev
20180608 09:10:30-!- mode/#wesnoth-dev [+v discordbot1] by ChanServ
20180608 09:10:40<+discordbot1> <Vultraz> Blah
20180608 09:10:57<+discordbot1> <Pentarctagon> what clang, out of curiousity?
20180608 09:12:13<+discordbot1> <Pentarctagon> I want to say it worked on travis' clang at least, as long as lld was installed
20180608 09:14:06<+discordbot1> <jyrkive> 5.0, from Debian Sid repositories.
20180608 09:14:17<+discordbot1> <Pentarctagon> huh
20180608 09:14:18<+discordbot1> <Pentarctagon> weird
20180608 09:14:40<+discordbot1> <jyrkive> Correction: 4.0.
20180608 09:15:58-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 09:15:59< travis-ci> wesnoth/wesnoth#18509 (master - 424e0e0 : Charles Dang): The build is still failing.
20180608 09:15:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389623214
20180608 09:15:59-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 09:16:47<+discordbot1> <Pentarctagon> even stranger, in that case, since travis' docker image has 3.8
20180608 09:18:07<+discordbot1> <jyrkive> LTO is quite fragile on all compilers except MSVC.
20180608 09:18:40<+discordbot1> <jyrkive> (Correspondingly, MSVC relies more on LTO to reach good performance, and the other compilers don't need it as much.)
20180608 09:19:31-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20180608 09:19:44<+discordbot1> <Pentarctagon> maybe something to check again prior to 1.16 then, depending on how long that takes.
20180608 09:20:29<+discordbot1> <jyrkive> I guess I can recheck when I get a major Clang update next time.
20180608 09:20:50<+discordbot1> <jyrkive> But even if it fixes the linking error, LTO would still be too fragile to enable by default.
20180608 09:21:34<+discordbot1> <jyrkive> Sid is the cutting-edge version. Even if it was upgraded to Clang 5.0 today, older versions of Debian would still be stuck with 4.0 for a couple of years.
20180608 09:21:54<+discordbot1> <jyrkive> And users would continue to use those older versions for a couple of years after that.
20180608 09:22:19<+discordbot1> <jyrkive> Mid-2020s is the earliest when we'd be able to consider enabling LTO by default.
20180608 09:23:38<+discordbot1> <Pentarctagon> maybe it could be enabled for gcc?  I haven't had any LTO-specific problems at all with gcc since I started using LTO.
20180608 09:24:10<+discordbot1> <jyrkive> IIRC, doofus-01 got build errors with GCC when LTO was enabled by default.
20180608 09:24:18<+discordbot1> <Pentarctagon> >.<
20180608 09:24:19<+discordbot1> <jyrkive> (Or maybe it was some other board member.)
20180608 09:25:03<+discordbot1> <Pentarctagon> oh well
20180608 09:26:41<+discordbot1> <Pentarctagon> remembered the problem with clang+LTO+travis right after I logged out
20180608 09:26:45<+discordbot1> <Pentarctagon> it timed out
20180608 09:27:03<+discordbot1> <Pentarctagon> mainly because clang+LTO doesn't support -Og
20180608 09:27:34<+discordbot1> <Pentarctagon> gcc+LTO at -O1 also timed out, but it's able to use -Og, so that was able to finish within the time limit
20180608 09:27:50<+discordbot1> <Pentarctagon> anyway, now I'm off
20180608 09:28:47<+discordbot1> <jyrkive> Wasn't -Og an GCC-exclusive option anyway?
20180608 09:32:19<+discordbot1> <shadowm> Can somebody explain to me the maths behind this default attack selection choice?https://cdn.discordapp.com/attachments/363898479552102433/454113095745404931/unknown.png
20180608 09:33:43<+discordbot1> <shadowm> The fate of a whole AMLA branch for this unit depends on the justification for this nonsense.
20180608 09:34:15<+discordbot1> <jyrkive> See https://github.com/wesnoth/wesnoth/blob/1.14/src/actions/attack.cpp#L488
20180608 09:35:09< Soliton> doesn't make sense to me. looks like a bug.
20180608 09:35:58<+discordbot1> <shadowm> I faintly recall seeing this in 1.12 as well, but it was quite a while ago so I'm not sure.
20180608 09:36:38< Soliton> does on of the attacks have an attack_weight?
20180608 09:36:50<+discordbot1> <shadowm> No.
20180608 09:37:27<+discordbot1> <shadowm> And it seems to me like attack_weight does nothing for the UI, because I tried using it on a special item on a different unit and it didn't make a difference.
20180608 09:37:47< Soliton> i thought it might but not sure.
20180608 09:39:32<+discordbot1> <Vultraz> It’s always possible I messed something up on the UI side.
20180608 09:40:17-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 09:40:18< travis-ci> wesnoth/wesnoth#18510 (1.14 - 9ea4363 : Charles Dang): The build was fixed.
20180608 09:40:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389623659
20180608 09:40:18-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 09:40:38<+discordbot1> <shadowm> I can give you a save if you want, since you know how to install IftU in its present state.
20180608 09:44:38<+discordbot1> <shadowm> Hm. 1.12 has a different idea.
20180608 09:44:38<+discordbot1> <shadowm> https://cdn.discordapp.com/attachments/259976436490829825/454581508850843649/unknown.png
20180608 09:46:12<+discordbot1> <shadowm> The enemy unit doesn't have dextrous but I somehow don't expect that to tip the results in favour of ranged attacks.
20180608 09:48:41<+discordbot1> <shadowm> @Vultraz (you will need IftU and Naia from Git).
20180608 09:48:42<+discordbot1> <shadowm> https://cdn.discordapp.com/attachments/259976436490829825/454582531375890433/IftU-Into_the_Lair_Turn_10.gz
20180608 09:49:06<+discordbot1> <shadowm> I'm going to sleep now.
20180608 09:51:22-!- travis-ci [~travis-ci@ec2-54-204-112-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 09:51:23< travis-ci> wesnoth/wesnoth#18511 (master - ea5945b : Charles Dang): The build failed.
20180608 09:51:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389630621
20180608 09:51:23-!- travis-ci [~travis-ci@ec2-54-204-112-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 10:04:56-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev
20180608 10:08:05<+discordbot1> <shadowm> Why on earth are non-main threads calling the image API again?
20180608 10:08:30<+discordbot1> <shadowm> I thought the only thing the worker thread needed to do was to purge the cache.
20180608 10:08:31< gfgtdf> for construction units & terrain.
20180608 10:08:43<+discordbot1> <shadowm> Oh crap.
20180608 10:08:53<+discordbot1> <shadowm> Yeah I just remembered how the terrain builder works.
20180608 10:09:14<+discordbot1> <shadowm> Units? Those shouldn't require loading images until they are actually instantiated and rendered though.
20180608 10:09:59<+discordbot1> <shadowm> So yeah I guess making the loading screen multithreaded wasn't such a good idea in hindsight, huh?
20180608 10:10:02< gfgtdf> well that was takesnfrom the tsan log you generated (yesterday?)
20180608 10:10:44< gfgtdf> see the frst stacktrace in #3218
20180608 10:11:19<+discordbot1> <shadowm> Would it be possible somehow to swap the implementation of the image cache code in certain situations so that it normally doesn't use mutexes and it only does so during the game initialization sequence?
20180608 10:12:15<+discordbot1> <shadowm> Or set a flag if that proves too cumbersome?
20180608 10:13:12< gfgtdf> yes you cna, see for example the discussion in https://github.com/wesnoth/wesnoth/commit/b780da48e70e1139075890256bb089e40368b363#diff-1cb60fbde939583713114657db58a5b8
20180608 10:13:35<+discordbot1> <shadowm> (I reckon it's not code where we want to add extra checks or function calls, hence I'm being rather literal when I say "swap".)
20180608 10:14:12<+discordbot1> <shadowm> Uh no that's just acquiring mutexes.
20180608 10:14:36<+discordbot1> <shadowm> Vultraz already implemented that solution and jyrkive pointed out that it does have a non-negligible performance impact.
20180608 10:14:37< gfgtdf> well i dont think comaring a bool issomething wher you shoul worry about errformance.
20180608 10:15:20<+discordbot1> <shadowm> Anyway I'm off now.
20180608 10:15:27< gfgtdf> no that was a different solution since vultraz solution did always use locks
20180608 10:18:07< gfgtdf> and don't foget that the threaded loadingscreen did actuall fix somethingthat is, that is previously wesnoth was just unrepronsive and froze if a loading step took too long.
20180608 10:21:26< Soliton> at what cost though. threading is not the only way to fix that anyway.
20180608 10:43:16-!- sevu [~Shiki@p54854C5A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180608 11:19:37-!- sevu [~Shiki@p54854C5A.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20180608 11:37:06< irker196> wesnoth: Charles Dang wesnoth:master eade3dd494dc / src/tests/gui/fire_event.cpp: Fixup ea5945b (fixes #3221) https://github.com/wesnoth/wesnoth/commit/eade3dd494dc6e83af0d9cc423a89b1e98fa831f
20180608 11:55:55-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180608 12:01:22-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 12:01:23< travis-ci> wesnoth/wesnoth#18512 (master - eade3dd : Charles Dang): The build was fixed.
20180608 12:01:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389684079
20180608 12:01:23-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 12:01:38-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20180608 12:03:54-!- gallaecio [~quassel@4.red-81-39-199.dynamicip.rima-tde.net] has quit [Remote host closed the connection]
20180608 12:08:43-!- fabi [~fabi@200116b82b1afd001d27fedccc6b4f78.dip.versatel-1u1.de] has joined #wesnoth-dev
20180608 12:08:43-!- fabi [~fabi@200116b82b1afd001d27fedccc6b4f78.dip.versatel-1u1.de] has quit [Changing host]
20180608 12:08:43-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20180608 12:11:10<+discordbot1> <Vultraz> hmm
20180608 12:12:06<+discordbot1> <Vultraz> how is it that I can save a ptr like so; T* ptr = &vec[i];, but when iterating over vec with for(const auto& foo : vec), ptr == &foo is never true 🤔
20180608 12:12:43<+discordbot1> <jyrkive> It's supposed to work. You're doing something wrong.
20180608 12:13:18<+discordbot1> <Vultraz> alright
20180608 12:18:12-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 260 seconds]
20180608 12:18:51-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180608 12:21:09-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180608 12:21:21-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 264 seconds]
20180608 12:22:54-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev
20180608 12:23:02-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20180608 12:23:25-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180608 12:23:34-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20180608 12:23:47-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20180608 12:24:57-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev
20180608 12:57:37-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection]
20180608 13:05:46<+discordbot1> <jyrkive> Another analysis about GitHub's acquisition: https://www.linuxfoundation.org/blog/microsoft-buys-github-the-linux-foundations-reaction/
20180608 13:16:35-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20180608 13:47:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180608 14:08:06-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev
20180608 14:26:49<+discordbot1> <Vultraz> I've noticed a serious flaw in the attack dialog that's been sitting there since 2016
20180608 14:27:36<+discordbot1> <Vultraz> Ever since I skipped disabled weapons, the list indices don't necessarily match the vector indices
20180608 14:31:48<+discordbot1> <Vultraz> ...OH
20180608 14:31:57<+discordbot1> <Vultraz> @shadowm found your problem, I have.
20180608 14:38:05-!- irker196 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180608 14:40:31-!- irker754 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180608 14:40:31< irker754> wesnoth: Thom Diment wesnoth:master 7feb9aee113d / data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg: UtBS 5: changes to scenario locations (#3104) https://github.com/wesnoth/wesnoth/commit/7feb9aee113def823d506f987d0bee737da60ed7
20180608 14:42:07< irker754> wesnoth: Thom Diment wesnoth:1.14 bf28cc7d762e / data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg: UtBS 5: changes to scenario locations (#3104) https://github.com/wesnoth/wesnoth/commit/bf28cc7d762ec6708f3e3d5e6077958dec5ae1b9
20180608 14:58:44-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Ping timeout: 268 seconds]
20180608 15:02:27-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev
20180608 15:09:31< irker754> wesnoth/wesnoth:1.14 Charles Dang 9ea4363145 Fixup this atomic_bool again AppVeyor: All builds passed
20180608 15:22:09<+discordbot1> <Vultraz> hmmmm
20180608 15:22:21<+discordbot1> <Vultraz> I have a way to solve both problems at once
20180608 15:22:22<+discordbot1> <Vultraz> but
20180608 15:22:29<+discordbot1> <Vultraz> it's a little risky
20180608 15:23:04<+discordbot1> <Vultraz> basically, moving the if(attacker.disable) check to fille_weapons_list so those attacks don't get added in the first place
20180608 15:23:09<+discordbot1> <Vultraz> thing is
20180608 15:23:43<+discordbot1> <Vultraz> I'm not entirely sure what that variable does...and if including the check would mess up mouse_handler::attack_enemy_
20180608 15:24:10<+discordbot1> <Vultraz> gfgtdf: what say you?
20180608 15:27:21< gfg> i'm on my phone, so can't really look at code to be sure. But i think that that index might be used even later when the attack is executed. so you have to make sure that one is correct aswell.
20180608 15:28:51<+discordbot1> <Vultraz> basically if i move the check i wanted to make it so the best index is never an attack with the disable flag set
20180608 15:29:50<+discordbot1> <Vultraz> right now the thing with shadowm's case is there's an attack not shown in the dialog because attacker.disable is true, but the code already determined it was the best attack, and since the dialog selectes min(num items, best_index), the wrong item got selected
20180608 15:30:14<+discordbot1> <Vultraz> if i add the check to fill_weapon_choices then the logical best attack is selected
20180608 15:31:37<+discordbot1> <Vultraz> i think it's also very important since then the code isn't working with an index that may not match the displayed options
20180608 15:36:30< gfg> sry i'd have to look at the code give a strong opinion here.
20180608 15:36:46< gfg> on the current code i mean.
20180608 16:00:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180608 16:00:55< irker754> wesnoth: Severin Glöckner wesnoth:1.14 ba487c852f91 / data/campaigns/tutorial/lua/character_selection.lua: Tutorial: show the female fighteress in the help (if she is chosen) https://github.com/wesnoth/wesnoth/commit/ba487c852f9139ecfa8090dcdd4f549434dbfcbf
20180608 16:00:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180608 16:01:27< irker754> wesnoth: Severin Glöckner wesnoth:master 18a101be6650 / data/campaigns/tutorial/lua/character_selection.lua: Tutorial: show the female fighteress in the help (if she is chosen) https://github.com/wesnoth/wesnoth/commit/18a101be6650fa19da900e680a29a39049ce69c0
20180608 16:07:44-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection]
20180608 16:07:50-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev
20180608 16:07:51-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.]
20180608 16:13:50-!- DeFender [~DeFender1@89-138-13-24.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20180608 16:18:05<+discordbot1> <Pentarctagon> @jyrkive after a bit of googling, it looks like clang does support -Og, but it's a more recent addition.
20180608 16:18:56<+discordbot1> <Pentarctagon> perhaps available for whichever version comes with Ubuntu 18.04
20180608 16:23:58-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev
20180608 16:32:57< irker754> wesnoth: Charles Dang wesnoth:1.14 5f58cd7c6d39 / changelog.md src/gui/dialogs/unit_attack.cpp src/mouse_events.cpp: Unit Attack: fixed issues arising from displayed items potentially not equally a https://github.com/wesnoth/wesnoth/commit/5f58cd7c6d39c35dcefa6fb9f71777a42ea5cb5e
20180608 16:34:13<+discordbot1> <Vultraz> @shadowm ^ gfgtdf ^
20180608 16:34:28<+discordbot1> <shadowm> Ohhh.
20180608 16:34:39< irker754> wesnoth: Charles Dang wesnoth:master 00e58f12f9a5 / changelog.md src/gui/dialogs/unit_attack.cpp src/mouse_events.cpp: Unit Attack: fixed issues arising from displayed items potentially not equally a https://github.com/wesnoth/wesnoth/commit/00e58f12f9a57b2e25dd4f67efb1255b177e173b
20180608 16:34:41<+discordbot1> <shadowm> Yeah she has the union at that point.
20180608 16:34:55<+discordbot1> <Vultraz> @shadowm in essence, the game was choosing the union as the best attack
20180608 16:35:26<+discordbot1> <Vultraz> looking back at my commits from September 2016, I think I ran into an issue where the best attack was out-of-bounds of the displayed attacks
20180608 16:35:32<+discordbot1> <Vultraz> but I mitigated it with a std::min call
20180608 16:35:32<+discordbot1> <Vultraz> >_>
20180608 16:36:02< gfg> did you test that? In particular if the first session is disabled and you select to attack with the second weapon, does it really attack with the second weapon?
20180608 16:36:21<+discordbot1> <Vultraz> session?
20180608 16:36:30<+discordbot1> <shadowm> Selection.
20180608 16:36:43< gfg> weapon
20180608 16:36:53<+discordbot1> <Vultraz> if the attacker's attack is disabled it's not even added to the weapon list now
20180608 16:37:04<+discordbot1> <Vultraz> before it was, but hidden in the dialog
20180608 16:37:28<+discordbot1> <Vultraz> meaning it's almost certain if you tried to attack with the first displayed attack the game would think you wanted to attack with the hidden attack
20180608 16:38:12< gfg> and you tested that it's fixed now?
20180608 16:38:16<+discordbot1> <Vultraz> i didn't confirm that, and it's possible there's further mitigation later down the pipeline, but it would only certainly arise as an issue if there wasn't
20180608 16:38:31<+discordbot1> <Vultraz> gfgtdf: i did confirm the expected atack is now selected initally
20180608 16:38:53<+discordbot1> <Vultraz> i didn't test the other thing since like i said i didn't try to repro it butfrom reading the code i could see where it wuld break
20180608 16:38:58<+discordbot1> <Vultraz> and now it can't
20180608 16:42:01<+discordbot1> <Vultraz> @shadowm so, thanks for brining this to my attention, since the selection issue turned out to be a symptom of a deeper issue.
20180608 16:43:28<+discordbot1> <shadowm> Okay np
20180608 16:47:15<+discordbot1> <jyrkive> @Pentarctagon Okay, I see. Apparently Clang got -Og support in version 4.0.
20180608 16:47:16<+discordbot1> <jyrkive> https://www.phoronix.com/scan.php?page=news_item&px=LLVM-Clang-Og
20180608 17:10:39-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180608 17:15:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180608 17:16:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180608 17:16:09-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 256 seconds]
20180608 17:37:41-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 17:37:42< travis-ci> wesnoth/wesnoth#18515 (1.14 - 5f58cd7 : Charles Dang): The build has errored.
20180608 17:37:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389807068
20180608 17:37:42-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 17:41:42-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection]
20180608 17:46:02-!- gallaecio [~quassel@188.79.96.255] has quit [Ping timeout: 245 seconds]
20180608 18:06:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180608 18:06:53-!- travis-ci [~travis-ci@ec2-54-90-238-126.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 18:06:54< travis-ci> Pentarctagon/wesnoth#48 (copyright-tracking - f53237b : loonycyborg): The build has errored.
20180608 18:06:54< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/389831704
20180608 18:06:54-!- travis-ci [~travis-ci@ec2-54-90-238-126.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 18:16:36< irker754> wesnoth/wesnoth:master Charles Dang eade3dd494 Fixup ea5945b (fixes #3221) AppVeyor: All builds passed
20180608 18:20:09-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev
20180608 18:30:04< irker754> wesnoth: Nils Kneuper wesnoth:master ca25c0dc5c51 / po/ (wesnoth-lib/es.po wesnoth-manpages/es.po wesnoth-units/es.po wesnoth/es.po): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/ca25c0dc5c519a66f19146240273712a2264b81a
20180608 18:30:06< irker754> wesnoth: Nils Kneuper wesnoth:master e464082e0629 / po/wesnoth-tutorial/fr.po: updated French translation https://github.com/wesnoth/wesnoth/commit/e464082e0629522330eefcabcca5da811e4b316f
20180608 18:30:08< irker754> wesnoth: Nils Kneuper wesnoth:master f8742ccce40e / po/ (wesnoth-lib/gd.po wesnoth/gd.po): updated Scottish Gaelic translation https://github.com/wesnoth/wesnoth/commit/f8742ccce40ecf3be3eaf1afa437de7d7ed4d733
20180608 18:30:11< irker754> wesnoth: Nils Kneuper wesnoth:1.14 0ce76c9354b0 / / (6 files in 5 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/0ce76c9354b0a2ffe25d2595bd9c8ac0d02ed39f
20180608 18:30:13< irker754> wesnoth: Nils Kneuper wesnoth:1.14 c8d715058e5a / po/wesnoth-tutorial/fr.po: updated French translation https://github.com/wesnoth/wesnoth/commit/c8d715058e5a468542c1e1e938fbc3660bd6cd8d
20180608 18:30:15< irker754> wesnoth: Nils Kneuper wesnoth:1.14 cdc0256fb920 / changelog.md players_changelog.md po/wesnoth-lib/gd.po po/wesnoth/gd.po: updated Scottish Gaelic translation https://github.com/wesnoth/wesnoth/commit/cdc0256fb920c91184e970763e9ec541bcbdb68a
20180608 18:31:16-!- gfgt [~androirc@x4e36341e.dyn.telefonica.de] has joined #wesnoth-dev
20180608 18:34:34-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Read error: Connection reset by peer]
20180608 18:36:21-!- gfgt [~androirc@x4e36341e.dyn.telefonica.de] has quit [Ping timeout: 264 seconds]
20180608 18:42:05-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Max SendQ exceeded]
20180608 18:42:23-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev
20180608 18:54:32-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 18:54:33< travis-ci> wesnoth/wesnoth#18517 (master - f8742cc : Nils Kneuper): The build passed.
20180608 18:54:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389852934
20180608 18:54:34-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 19:12:52-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20180608 19:12:53< travis-ci> wesnoth/wesnoth#18518 (1.14 - cdc0256 : Nils Kneuper): The build passed.
20180608 19:12:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/389852984
20180608 19:12:53-!- travis-ci [~travis-ci@ec2-54-157-238-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20180608 19:21:38-!- ToBeFree [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180608 20:09:27< Ravana_> gfgtdf: I found that https://github.com/wesnoth/wesnoth/commit/ee50171d13c7f20a3c8147201c2b78ab54fafae3 is reponsible for https://github.com/wesnoth/wesnoth/issues/3201
20180608 20:15:40<+discordbot1> <hrubymar10> Should I ignore this error or? There are about 200 more errors of same type. /Users/user/xcode/wesnoth_1.14/src/serialization/preprocessor.hpp:93:15: Field has incomplete type 'version_info'
20180608 20:20:11-!- gfgtdf [~chatzilla@x4e36341e.dyn.telefonica.de] has joined #wesnoth-dev
20180608 20:53:25< irker754> wesnoth/wesnoth:master Thom Diment 7feb9aee11 UtBS 5: changes to scenario locations (# AppVeyor: All builds passed
20180608 21:25:37< irker754> wesnoth: stevecotton wesnoth:1.14 cf6bb49fae9e / data/campaigns/Descent_Into_Darkness/scenarios/02_Peaceful_Valley.cfg: DiD S2: When ambushed by goblins, cancel any pending attack (#3227) https://github.com/wesnoth/wesnoth/commit/cf6bb49fae9e13c22ef45d922cea7f04480573e3
20180608 21:28:52-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20180608 21:30:41-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180608 22:11:09< irker754> wesnoth: stevecotton wesnoth:master 8d055bf03862 / data/campaigns/Descent_Into_Darkness/scenarios/02_Peaceful_Valley.cfg: DiD S2: When ambushed by goblins, cancel any pending attack (#3227) https://github.com/wesnoth/wesnoth/commit/8d055bf038624fc61d965049832722555711af8a
20180608 22:17:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180608 22:22:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20180608 22:27:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180608 22:27:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180608 22:38:08< irker754> wesnoth/wesnoth:1.14 Charles Dang 5f58cd7c6d Unit Attack: fixed issues arising from d AppVeyor: All builds passed
20180608 23:51:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180608 23:53:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
--- Log closed Sat Jun 09 00:00:01 2018