--- Log opened Sun Jun 10 00:00:03 2018 20180610 00:01:05< zookeeper> of course i can't say it won't affect gameplay in some unfortunate manner 20180610 00:02:05<+discordbot1> I tried to insert here cancel_action but it has no effect? Any idea why? https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg#L620 20180610 00:02:20<+discordbot1> zookeeper ^ 20180610 00:03:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180610 00:03:09< zookeeper> anyways, i don't have anything more for 1.14.3 so i'm off to bed 20180610 00:03:23< zookeeper> @sevu, nope, no idea 20180610 00:04:24< irker038> wesnoth: Charles Dang wesnoth:1.14 e20b84d95a82 / players_changelog.md: Updated players_changelog https://github.com/wesnoth/wesnoth/commit/e20b84d95a826396ba4093e7786cdc75a6f243db 20180610 00:04:27< irker038> wesnoth: Charles Dang wesnoth:1.14 51609d2cef4e / / (5 files in 3 dirs): Pre-release version bump https://github.com/wesnoth/wesnoth/commit/51609d2cef4e42e067d09ebba7b0b0a30b7bce01 20180610 00:04:30< irker038> wesnoth: Charles Dang wesnoth:1.14 1174da36c05c / Doxyfile changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/1174da36c05c9234063da75ec3a553cc5bd1ce1f 20180610 00:04:33< irker038> wesnoth: Vultraz wesnoth: 51609d2cef4e tagged as 1.14.3 20180610 00:04:39<+discordbot1> There's a mistake in the manpage source. 20180610 00:04:48<+discordbot1> I didn't include a new header in the p_c in the post-release bump since I think we should retire the p_c from hence. 20180610 00:04:53<+discordbot1> @Packagers 1.14.3 tagged 20180610 00:05:03<+discordbot1> @Packagers as always, please upload to Steam first. 20180610 00:05:29<+discordbot1> I just realized it says "B defaults to none" when it should really say "B defaults to B" since "none" is a keyword in this context. 20180610 00:05:44<+discordbot1> That mistake probably helped make the Spanish translation awkward af. 20180610 00:05:52< octalot> @sevu what do you expect cancel_action to do there? It's in a moveto rather than an enter_hex, so (unless there was an enemy adjacent to that hex and the player was going to attack), there's no further actions to cancel. 20180610 00:06:04<+discordbot1> (Awkward and incorrect.) 20180610 00:08:46<+discordbot1> The intend is to abort an potential attack which would happen after the moveto event. Sth. similar is done here, in a capture event though https://github.com/wesnoth/wesnoth/commit/cf6bb49fae9e13c22ef45d922cea7f04480573e3 20180610 00:10:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20180610 00:10:39<+discordbot1> Alright 20180610 00:10:54<+discordbot1> From 1.14.3+dev on, I say let's ditch the players_changelog 20180610 00:11:19<+discordbot1> Yes, please. 20180610 00:12:20<+discordbot1> and as for the master/1.14 changelog divergence, I'm going to copy all the version sections since the branch split to master, and we'll continue to maintain each 1.14 release's changes in its own sections. Makes management much easier. 20180610 00:12:42<+discordbot1> later (not right this minute) I'll go in and remove all the duplicate entries now under the 1.15.0-dev heading 20180610 00:14:10<+discordbot1> maybe for master the players_changelog still makes sense, as there are much more changes 20180610 00:15:52< irker038> wesnoth: Charles Dang wesnoth:master 556d088e5754 / changelog.md: Added 1.13.13 - 1.14.3 changelog sections https://github.com/wesnoth/wesnoth/commit/556d088e5754ef8197e47c82a828e7fadbc5f93c 20180610 00:16:32<+discordbot1> From now on, when copying an entry over from 1.14, don't put it under 1.15.0-dev, put it under its appropriate heading 20180610 00:17:08-!- octalot [~steve@91.141.3.100.wireless.dyn.drei.com] has quit [Read error: Connection reset by peer] 20180610 00:17:22-!- octalot [~steve@91.141.3.100.wireless.dyn.drei.com] has joined #wesnoth-dev 20180610 00:17:40<+discordbot1> @sevu ehhh... not that many that it's really necessary 20180610 00:18:16< octalot> @sevu does it still fail if you remove the UNDO_REMINDER? I'm wondering if there's an interaction with allow_undo. 20180610 00:18:42<+discordbot1> I don't think players_changelog has ever stopped making sense @sevu, the problem is that in practice it's useless because half of the devs forget it even exists. 20180610 00:19:52<+discordbot1> It's already a waste of energy making sure people remember to update the main changelog in the first place, so having to remind them about players_changelog or fix it yourself is exasperating. 20180610 00:20:27<+discordbot1> I see 20180610 00:22:02< octalot> I suggest changing the workflow on the stable branch so that *everything* goes through a pull request, even for people with commit access. Then the work of reminding them to update the changelogs can be handled by the peanut gallery. 20180610 00:22:28<+discordbot1> No 20180610 00:23:45<+discordbot1> Haha no. 20180610 00:24:06<+discordbot1> People have been consistently neglecting to tell people posting PRs for the first time to add changelog or credits entries for the last 2 years. 20180610 00:25:34<+discordbot1> What I'm saying is, they can't be trusted to do that for existing devs anymore that they can be for new contributors. 20180610 00:26:00<+discordbot1> Not to mention that most devs tend to focus on their own stuff and ignore everyone else's. 20180610 00:26:35<+discordbot1> I don't think I've ever added a players_changelog entry myself 20180610 00:26:36<+discordbot1> ever 20180610 00:28:53<+discordbot1> anyway, good work team on the 1.14.3 changes 👍 20180610 00:35:55< octalot> @sevu adding [cancel_action][/cancel_action] after line 620 (and before the UNDO_REMINDER) works for me. Did you refresh the cache? 20180610 00:36:55<+discordbot1> Oh, I tried that too... maybe not ... 20180610 00:37:46<+discordbot1> Ahhh...I tested the wrong event 20180610 00:40:50<+discordbot1> octalot, works both ways, thanks. this is one of the stupid mistakes when writing code.... 20180610 00:41:33< octalot> sometimes, it works as soon as you've asked someone else 20180610 00:43:24< octalot> For the changelog, would it make sense to have a skeleton so that pull requests can add stuff with less chance of merge conflicts? For a start, creating headings for all the campaigns. 20180610 00:43:48< octalot> (I'll open a PR for that if it sounds logical) 20180610 00:44:49<+discordbot1> No, please don't 20180610 00:52:46< octalot> Should changelog entries be included in pull requests? Normally I'd expect a PR with a merge conflict to be less likely to get reviewed. 20180610 00:53:31<+discordbot1> Yes. 20180610 00:54:26<+discordbot1> People have to either look at the diff or apply the PR locally either way. 20180610 00:54:52<+discordbot1> And the assumption is that all devs with push access already know how to deal with merge conflicts (otherwise what are they doing with their lives). 20180610 01:04:28< irker038> wesnoth: Severin Glöckner wesnoth:1.14 9cac36e6b858 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial Part2: Give the player a canche to undo his move https://github.com/wesnoth/wesnoth/commit/9cac36e6b858cc9344674f5c90aa872e12e5ba9d 20180610 01:04:30< irker038> wesnoth: Severin Glöckner wesnoth:1.14 df8ac3cbb0be / data/ (3 files in 2 dirs): add / remove some comments https://github.com/wesnoth/wesnoth/commit/df8ac3cbb0be62929d654108bfb28ae36c0b41ad 20180610 01:17:56< octalot> having a merge conflict means an automatic fail of the CI tests 20180610 01:18:36<+discordbot1> so? 20180610 01:19:06-!- gfgtdf_ [~chatzilla@x4e36309f.dyn.telefonica.de] has joined #wesnoth-dev 20180610 01:20:18< irker038> wesnoth/wesnoth:master Jyrki Vesterinen f0896bdf8c Remove game_events::wml_event_pump::wml_ AppVeyor: All builds passed 20180610 01:21:17-!- gfgtdf [~chatzilla@x4e36341e.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20180610 01:21:31-!- gfgtdf_ is now known as gfgtdf 20180610 01:21:32< octalot> meaning that asking for changelog entries in PRs, without making it easier to avoid merge conflicts, decreases the usefulness of the CI reports 20180610 01:22:34<+discordbot1> The CI tests work btw only for C++ stuff, most PRs are out of that scope 20180610 01:25:09<+discordbot1> (that's why it is useful to place an [ci skip] somewhere in commit messages) 20180610 01:42:27< gfgtdf> @vultraz i think 'reproducable random results' would be easier to understand fopr non technical users than 'save random seed' 20180610 01:42:54<+discordbot1> If Civ uses the Random Seed nomenclature it's good enough for us 20180610 01:43:10<+discordbot1> gfgtdf: Please stop this. 20180610 01:43:20< gfgtdf> what? 20180610 01:43:23<+discordbot1> You had plenty of time to continue the debate before the string freeze. 20180610 01:43:31<+discordbot1> We can't be changing the same string over and over. 20180610 01:44:09<+discordbot1> Currently I am the one who has to inform translators of changes. What am I supposed to tell them if we decide to change it again? 20180610 01:44:18<+discordbot1> Indeed. 20180610 01:44:20<+discordbot1> "Sorry but we can't ever agree on anything so yeah we're changing this string again." 20180610 01:44:31<+discordbot1> Save Random Seed is fine. 20180610 01:44:39<+discordbot1> Players aren't stupid. 20180610 01:44:55<+discordbot1> What the feature needs is to be shoved into the attic. 20180610 01:45:16<+discordbot1> It's not user-friendly by definition, no matter how you phrase the UI string. 20180610 01:45:55<+discordbot1> like, imagine if Minecraft decided to use "Random worldspace number" or something for its Seed input field. 20180610 01:45:56<+discordbot1> If you want to know what "Reproducible random results" looks like in Spanish, I can tell you this much: it looks like something ripped out of a scientific whitepaper. 20180610 01:46:03<+discordbot1> It's a lateral move compared to "Save random seed". 20180610 01:47:01<+discordbot1> You can either dumb down the phrasing to the point it's misleading (e.g. "deterministic saves" or whatever it was previously), or be clear at the expense of semantic accessibility. 20180610 01:48:25<+discordbot1> This was one of my concerns back when you came up with it and that's why I tried to get you to guard it behind -d (since your primary intention was to be able to get deterministic behaviour with certain actions performed on loaded saves), but you didn't accede to that and we got stuck with a highly-visible shiny red button that no-one without a degree can properly understand what it does. 20180610 01:49:21<+discordbot1> And this issue extends to pretty much any option that lifts the green curtain to reveal Wesnoth's inner workings. 20180610 01:49:39<+discordbot1> Yes, Vultraz, I'm pointing at Dave's RNG switch here. 20180610 01:49:57<+discordbot1> At least that one is going into Preferences → Advanced I believe. 20180610 01:51:04<+discordbot1> yes 20180610 01:54:17< gfgtdf> other languages can set the string to whats fits best in their language indpendent of whether the english version says save random seed, deterministic mode or whatever, as we are not changing what it does. Actuall the reason why i came up with this is that the current german version is somhow hard to understand (and it really long) and would be better replaced with what literally means... 20180610 01:54:18< gfgtdf> ...'reproducable random results' and i thought the same thing might apply to english aswell. 20180610 01:55:16<+discordbot1> I just said that there is no way to phrase it that isn't either misleading or too scientific for the general crowd. 20180610 01:55:26<+discordbot1> Both in English and Spanish. 20180610 01:55:56-!- travis-ci [~travis-ci@ec2-54-161-135-156.compute-1.amazonaws.com] has joined #wesnoth-dev 20180610 01:55:57< travis-ci> wesnoth/wesnoth#18536 (1.14.3 - 51609d2 : Charles Dang): The build passed. 20180610 01:55:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/390258600 20180610 01:55:57-!- travis-ci [~travis-ci@ec2-54-161-135-156.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180610 01:56:25<+discordbot1> I feel like you just skimmed past that wall of text. 20180610 01:56:53< irker038> wesnoth: Charles Dang wesnoth:1.14 09d94b03f56b / / (4 files in 3 dirs): Statistics Dialog: remove mode toggle in favor of an All Scenarios menu entry https://github.com/wesnoth/wesnoth/commit/09d94b03f56bc51ff8b8eadbb1bf3a3e958097b9 20180610 01:56:56< irker038> wesnoth: Charles Dang wesnoth:1.14 e9f7952408f1 / data/gui/window/statistics_dialog.cfg src/gui/dialogs/statistics_dialog.cpp: Statistics Dialog: merge unit name and count labels https://github.com/wesnoth/wesnoth/commit/e9f7952408f1af9b6b210c1466242fd2784513f9 20180610 01:57:55<+discordbot1> Anyway, tl;dr: 1) no way to reduce the option's semantic density without making it misleading/dedicating a whole PARAGRAPH to it; 2) there's a point where the bikeshedding needs to stop so we stop harassing translators with string changes over the same string. 20180610 01:58:01< irker038> wesnoth: Charles Dang wesnoth:master b5f1e1a48a9d / / (4 files in 3 dirs): Statistics Dialog: remove mode toggle in favor of an All Scenarios menu entry https://github.com/wesnoth/wesnoth/commit/b5f1e1a48a9d817d1d68a5868903bb3e518cba3d 20180610 01:58:04< irker038> wesnoth: Charles Dang wesnoth:master 142a2f20ca70 / data/gui/window/statistics_dialog.cfg src/gui/dialogs/statistics_dialog.cpp: Statistics Dialog: merge unit name and count labels https://github.com/wesnoth/wesnoth/commit/142a2f20ca70deaf4d6a71c918de47aef366fc47 20180610 01:58:19<+discordbot1> So no, it's not going to change, and I'd even advise that if it continues to be a point of contention the feature should be hidden by default. 20180610 01:59:55<+discordbot1> about that second commit: I recall we swapped the order of the count label and the unit names due to a request by someone regarding translations 20180610 02:00:11<+discordbot1> now it's a single label so anyone can tweak the order if they want on a per-language basis 20180610 02:00:39<+discordbot1> not that I anticipate anyone will change "$count|× $name" but they can now if they wanted. 20180610 02:09:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180610 02:09:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180610 02:10:58<+discordbot1> @Vultraz Should I omit mentions of the players changelog in the announcement then? 20180610 02:11:43<+discordbot1> ehhhh... 20180610 02:11:53<+discordbot1> sure, why not. it was barely curated this release anyway 20180610 02:17:59< celticminstrel> We could ask people submitting PRs to add a changelog entry as part of the PR description? 20180610 02:18:15< celticminstrel> So then whoever merges it can also update the changelog. 20180610 02:18:32< celticminstrel> (I mean, they can do that anyway, but that would make things easier.) 20180610 02:19:45<+discordbot1> That sounds good to me. 20180610 02:22:00< irker038> wesnoth: Charles Dang wesnoth:master 70a1cdd3e694 / changelog.md: Removed duplicate changelog entries under the 1.15.0-dev header https://github.com/wesnoth/wesnoth/commit/70a1cdd3e6949a765cead1b31fa6504d44b99b90 20180610 02:22:13<+discordbot1> there we go 20180610 02:22:16<+discordbot1> all cleaned up 20180610 02:24:05<+discordbot1> I wonder when all those WML engine changes went into master.. 20180610 02:24:07<+discordbot1> I can't remember 20180610 02:24:23<+discordbot1> gonna assume they're all stuff celmin did at some point 20180610 02:24:38< celticminstrel> ??? 20180610 02:25:31< celticminstrel> Um... 20180610 02:25:47< irker038> wesnoth: Charles Dang wesnoth:master 92c67f52442f / changelog.md: Removed a duplicate changelog entry I missed https://github.com/wesnoth/wesnoth/commit/92c67f52442f1c334be463409dfda51eb0b70aa6 20180610 02:25:52< celticminstrel> "support location_id in [teleport]" should've been left in? 20180610 02:26:10< celticminstrel> Shouldn't it? 20180610 02:26:19< celticminstrel> Pretty sure that wasn't in 1.14.x? 20180610 02:26:23<+discordbot1> there's already " * Support location_id in [teleport], [recall], [unstore_unit] for the target location" 20180610 02:26:27-!- octalot [~steve@91.141.3.100.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds] 20180610 02:26:48< celticminstrel> Oh so it was listed twice under 1.15? 20180610 02:26:51<+discordbot1> yes 20180610 02:27:02< celticminstrel> Okay. 20180610 02:27:17<+discordbot1> but changes like that 20180610 02:27:22<+discordbot1> I assume you implemented them? 20180610 02:27:23< celticminstrel> Probably most of those WML engine changes were things I added while working on the schema. 20180610 02:27:40< celticminstrel> Or for location_id stuff, while working on my campaign. 20180610 02:28:25< celticminstrel> The voice thing was something I added because the AToTB voice mod thread brought it up. 20180610 02:28:52< celticminstrel> The random_placement thing was just something I noticed was unsupported, so I fixed it. 20180610 02:28:55< irker038> wesnoth: Charles Dang wesnoth:master b27d1c21f5ef / changelog.md: Changelog: moved an entry, fixed a typo https://github.com/wesnoth/wesnoth/commit/b27d1c21f5ef59f1694e95d821a04ab6d0993070 20180610 02:29:37< celticminstrel> BTW I see another duplicate. 20180610 02:29:46-!- gfgtdf [~chatzilla@x4e36309f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.8.1/20180605153619]] 20180610 02:29:47< celticminstrel> to_location in move_unit is mentioned twice. 20180610 02:30:03< celticminstrel> Oh, so is dir in move_unit. 20180610 02:30:17<+discordbot1> ya know what 20180610 02:30:19<+discordbot1> you fix those 20180610 02:30:25< celticminstrel> ... 20180610 02:30:25<+discordbot1> (please) 20180610 02:30:44<+discordbot1> @Vultraz The 1.14.3 announcement draft is up, you might want to check the wording for the changelog in the main post as well as the removal of the second paragraph mentioning the changelogs for the short post. 20180610 02:31:16<+discordbot1> ok 20180610 02:33:00< irker038> wesnoth: Celtic Minstrel wesnoth:master 93d4a1237544 / changelog.md: Remove duplicate changelog entries https://github.com/wesnoth/wesnoth/commit/93d4a1237544dc42c8ed15d646b9f70afd8a9a16 20180610 02:33:02< celticminstrel> Lazy. 20180610 02:33:20<+discordbot1> says the guy who hasn't finished shema 20180610 02:33:29< celticminstrel> It's hard to work in summer. 20180610 02:34:15<+discordbot1> @shadowm recommend: Read on for more details about the most notable fixes and additions in this release. A full list of changes may be found in the changelog. 20180610 02:35:08<+discordbot1> and we should mention The Option That Shall Not Be Named was renamed 20180610 02:35:35<+discordbot1> The changelog didn't say anything. 20180610 02:35:54<+discordbot1> oh 20180610 02:35:58<+discordbot1> 😄 20180610 02:36:19<+discordbot1> Like I was saying earlier about changelogs. 20180610 02:36:31<+discordbot1> I'd suggest 20180610 02:36:43<+discordbot1> "Read on for more details about the most notable fixes and additions since the previous stable release." 20180610 02:37:01<+discordbot1> The reason being that we want to be able to reuse the text when (wheeeeeeeeeeeeeeeeeeeeeen) we start pushing out dev releases. 20180610 02:37:13<+discordbot1> It's best to be explicit in that case. 20180610 02:38:10<+discordbot1> sure 20180610 02:38:19<+discordbot1> Okay, done. 20180610 02:39:00<+discordbot1> We're ahead of the curve 20180610 02:39:07<+discordbot1> Now we wait for the packagers 20180610 02:39:21<+discordbot1> Well you say that but I have no idea if you've done the Steam post. 20180610 02:39:30<+discordbot1> The draft for it, in your drive. Don't publish it yet obvs. 20180610 02:40:12<+discordbot1> Reminds me I wanted to look into writing a script to convert the Markdown section to bbcode. And incidentally, why do we insist on section headings under each version section to have a leading space? 20180610 02:40:28<+discordbot1> The triple pound signs should work just fine as indentation on their own. 20180610 02:41:09<+discordbot1> It was less work to have it that way when i first coverted the changelog to markdown 20180610 02:41:44<+discordbot1> sed -ri 's/^\s+#/#/' changelog.md 20180610 02:42:04<+discordbot1> Barely any work at all. 20180610 02:42:04<+discordbot1> IIRC it allowed me to keep the * aligned with the last # without reindenting every line 20180610 02:42:15<+discordbot1> i did the conversion by hand 20180610 02:42:21<+discordbot1> Hm. That is correct. 20180610 02:42:41<+discordbot1> It just sucks that Kate's Markdown highlighting schema doesn't seem to like the leading whitespace. 20180610 02:43:03<+discordbot1> Although, to be fair, it has issues with a lot of other things that by all means shouldn't be issues. 20180610 03:23:54< irker038> wesnoth: Charles Dang wesnoth:1.14 d117d65cc4af / changelog.md data/advanced_preferences.cfg: Added an advanced preference for the PRNG combat option https://github.com/wesnoth/wesnoth/commit/d117d65cc4af73e72b59816430110a182a6a8a58 20180610 03:24:20< irker038> wesnoth: Charles Dang wesnoth:master 8baeb8457d96 / changelog.md data/advanced_preferences.cfg: Added an advanced preference for the PRNG combat option https://github.com/wesnoth/wesnoth/commit/8baeb8457d96e2048ebdac9188bb95fcfbffd340 20180610 03:26:22<+discordbot1> Another benefit of the changelog changes: commits touching the changelog can now be cherry picked cleanly between 1.14 and master. 20180610 03:34:24< irker038> wesnoth: doofus-01 wesnoth:1.14 0869e20cfd76 / data/core/units/humans/Outlaw_Ruffian.cfg: change ruffian attack anim timings https://github.com/wesnoth/wesnoth/commit/0869e20cfd76f48d82514f2377e7051334495df2 20180610 03:34:26< irker038> wesnoth: doofus-01 wesnoth:1.14 20b2f1b518a8 / data/core/ (8 files in 2 dirs): peasant attack animations https://github.com/wesnoth/wesnoth/commit/20b2f1b518a8eb2a3c5565ac961bf907a65e5399 20180610 03:37:10< irker038> wesnoth: Charles Dang wesnoth:1.14 9a9e6887e284 / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/9a9e6887e284e71bc9c53102ce066c61ef1c9737 20180610 03:37:42< irker038> wesnoth: doofus-01 wesnoth:master c398a8fa8651 / data/core/units/humans/Outlaw_Ruffian.cfg: change ruffian attack anim timings https://github.com/wesnoth/wesnoth/commit/c398a8fa8651411c6d0b9742464c063cd0534a86 20180610 03:37:44< irker038> wesnoth: doofus-01 wesnoth:master 3f3e13c0b437 / data/core/ (8 files in 2 dirs): peasant attack animations https://github.com/wesnoth/wesnoth/commit/3f3e13c0b4375a7cf8df8ee6931c0a850b950863 20180610 03:37:46< irker038> wesnoth: Charles Dang wesnoth:master 802443eaf9a7 / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/802443eaf9a7306fda645742855432d14629ee71 20180610 03:50:00< irker038> wesnoth: Charles Dang wesnoth:1.14 32d650303a94 / src/gui/dialogs/statistics_dialog.cpp: Statistics Dialog: keep the same stat selected between scenario selections https://github.com/wesnoth/wesnoth/commit/32d650303a9457e12d4dcabfadcbcea7c718269e 20180610 03:50:30< irker038> wesnoth: Charles Dang wesnoth:master f1d2f8547965 / src/gui/dialogs/statistics_dialog.cpp: Statistics Dialog: keep the same stat selected between scenario selections https://github.com/wesnoth/wesnoth/commit/f1d2f85479654a0d5e027bd8afc7ae2d7ddd884f 20180610 03:59:02-!- ToBeFree [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180610 04:02:35-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds] 20180610 05:33:44<+discordbot1> @Vultraz Where can I see which bbcode tags are supported by Steam? 20180610 05:33:58<+discordbot1> (bbcode is as much of an anti-standard as Markdown, for the record.) 20180610 05:35:06< celticminstrel> I dunno, BBCode seems more anti-standard than Markdown to me. 20180610 05:35:44< celticminstrel> Because every place using it has its own custom tags, whereas Markdown is basically the same base, just sometimes has extensions. 20180610 05:35:46<+discordbot1> There are several implementations of Markdown. 20180610 05:36:04<+discordbot1> Markdown has a lot of mutually-incompatible extensions all over the place. 20180610 05:36:22<+discordbot1> BBCode does have a few standard tags just like Markdown has a core language subset. 20180610 05:40:57< celticminstrel> I guess. 20180610 05:41:27<+discordbot1> Like which extensions? 20180610 05:42:22< celticminstrel> GitHub extensions for example. 20180610 05:44:21< loonycyborg> What exactly does it add? 20180610 05:44:44< celticminstrel> Lots of stuff? For example the ``` syntax. 20180610 05:44:52< celticminstrel> For extended code blocks. 20180610 05:45:02< celticminstrel> Basic Markdown only supports space-prefixed code blocks IIRC. 20180610 06:04:55<+discordbot1> @shadowm IIRC the only ones I use are [h1], [b], and [list] + [*] 20180610 06:05:31<+discordbot1> There is no [h2] so I use bold for campaign names 20180610 06:05:41<+discordbot1> [h1] for the main headers 20180610 06:05:52<+discordbot1> Lists for each section, or each section under each campaign 20180610 06:08:09-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180610 06:29:51< irker038> wesnoth/wesnoth:1.14.3 Charles Dang 51609d2cef Pre-release version bump AppVeyor: All builds passed 20180610 06:30:46<+discordbot1> Need to rethink the way the lobby handles game filters... 20180610 06:42:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180610 06:48:01<+discordbot1> And I still can't download the VSCode 1.24 update>_< 20180610 06:48:09<+discordbot1> either in-app or manually 20180610 06:48:29<+discordbot1> in-app just won't do anything and manually just constantly fails with "network error" 20180610 06:49:26<+discordbot1> oh, hey, there's a Resume button :thonk: 20180610 06:56:39<+discordbot1> finally 20180610 06:58:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180610 07:16:38<+discordbot1> Random Interesting Stats 20180610 07:16:40<+discordbot1> $ git shortlog 1.13.12..HEAD -s -n 569 Charles Dang 89 Iris Morelle 84 Nils Kneuper 82 Celtic Minstrel 78 gfgtdf 59 Jyrki Vesterinen 58 Severin Glöckner 38 pentarctagon 31 loonycyborg 30 ln-zookeeper 27 mattsc 25 doofus-01 19 Sofartin 13 Gregory A Lundberg 13 Pentarctagon 10 Martin Hrubý (hrubymar10) 20180610 07:18:28<+discordbot1> (master) 20180610 07:18:41<+discordbot1> $ git shortlog 1.13.12..HEAD -s -n 210 Charles Dang 105 Iris Morelle 96 Celtic Minstrel 83 gfgtdf 82 Nils Kneuper 82 Severin Glöckner 59 Jyrki Vesterinen 36 loonycyborg 36 mattsc 33 ln-zookeeper 25 doofus-01 12 Martin Hrubý (hrubymar10) 11 Sofartin 20180610 07:18:43<+discordbot1> (1.14) 20180610 07:20:24<+discordbot1> @Vultraz https://forums.wesnoth.org/viewtopic.php?f=16&t=48326 20180610 07:20:34<+discordbot1> I wrote a script to convert a changelog section to Steam bbCode. 20180610 07:21:33<+discordbot1> The only thing I think you will want me to change is the subsection headings (e.g. "Northern Rebirth"). 20180610 07:21:43<+discordbot1> You currently use bold text and they're not part of a list. 20180610 07:22:09<+discordbot1> It's a bit of a tricky one because technically they can be in the same section as other items. 20180610 07:22:22<+discordbot1> If it's too much trouble I can change fromatting 20180610 07:23:23<+discordbot1> I'd prefer that since otherwise it will be weird if we end up with a section like this: ### Campaigns * A Tale of Two Brothers * Blah blah blah * Some change that is global to all campaigns and therefore is listed like this 20180610 07:23:37<+discordbot1> Alright 20180610 07:23:45<+discordbot1> Really, thanks for working on this 20180610 07:25:36< irker038> wesnoth: Iris Morelle wesnoth:1.14 2d98c936d591 / data/tools/steam-changelog: tools: Add steam-changelog https://github.com/wesnoth/wesnoth/commit/2d98c936d5910a308dd954d5c57cd1f211cbaf35 20180610 07:25:50< irker038> wesnoth: Iris Morelle wesnoth:master a92b83e40466 / data/tools/steam-changelog: tools: Add steam-changelog https://github.com/wesnoth/wesnoth/commit/a92b83e40466c6ea53d9ad98907abb4d9ce4d4ee 20180610 07:25:56<+discordbot1> I believe you can run Python? 20180610 07:26:37<+discordbot1> Just data/tools/steam-changelog changelog.md 1.14.3 will print the bbcode to stdout. 20180610 07:28:23<+discordbot1> Yes. Just need to find where the damn executable is 20180610 07:32:47-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180610 07:37:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180610 07:37:33-!- zookeeper_ [~lmsnie@95.175.104.109] has joined #wesnoth-dev 20180610 07:40:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Disconnected by services] 20180610 07:40:58-!- zookeeper_ is now known as zookeeper 20180610 07:41:01-!- zookeeper [~lmsnie@95.175.104.109] has quit [Changing host] 20180610 07:41:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180610 07:41:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20180610 07:41:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180610 07:51:16<+discordbot1> @Vultraz I'm concerned that somehow I have more commits in 1.14 than in master since the branch point. 20180610 07:51:38<+discordbot1> I doubt I did 16 pot updates, so... 20180610 07:52:11<+discordbot1> you did reverts of several things too 20180610 07:53:34-!- stevendale [~stevendal@unaffiliated/stevendale] has joined #wesnoth-dev 20180610 07:54:02<+discordbot1> Hm, true. 20180610 07:54:37<+discordbot1> And I think there's one or two patches I didn't amend before pushing upstream so they ended up split into two commits. 20180610 07:55:24<+discordbot1> Oh also I committed those theme UI fixes for [change_theme] that you told me to only push to 1.14 since the display engine in master is completely different. 20180610 07:56:06<+discordbot1> Also, the IRC topic for #wesnoth-dev still links to this: https://forums.wesnoth.org/viewtopic.php?t=42911 20180610 08:10:46-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180610 08:30:46< irker038> wesnoth/wesnoth:1.14 Steve Cotton 1c7cfc6f79 DiD S12: Alternative campaign finish by AppVeyor: All builds passed 20180610 08:42:09-!- fabi [~fabi@200116b82b2cd20041d87e74310207ef.dip.versatel-1u1.de] has joined #wesnoth-dev 20180610 08:42:09-!- fabi [~fabi@200116b82b2cd20041d87e74310207ef.dip.versatel-1u1.de] has quit [Changing host] 20180610 08:42:09-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180610 09:03:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180610 09:08:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180610 09:11:33<+discordbot1> macOS package is up on Steam and SourceForge 20180610 09:12:08<+discordbot1> OwO 20180610 10:53:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20180610 10:54:34-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180610 10:54:46-!- fabi [~fabi@i577BCD1D.versanet.de] has joined #wesnoth-dev 20180610 10:54:46-!- fabi [~fabi@i577BCD1D.versanet.de] has quit [Changing host] 20180610 10:54:46-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180610 10:59:30-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20180610 11:06:57-!- fabi [~fabi@i577BCD1D.versanet.de] has joined #wesnoth-dev 20180610 11:06:57-!- fabi [~fabi@i577BCD1D.versanet.de] has quit [Changing host] 20180610 11:06:57-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180610 11:07:25-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180610 11:09:29-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180610 11:18:41< irker038> wesnoth/wesnoth:1.14 Charles Dang 32d650303a Statistics Dialog: keep the same stat se AppVeyor: All builds passed 20180610 11:27:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180610 11:38:46-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Ping timeout: 268 seconds] 20180610 11:44:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180610 11:44:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180610 12:08:05-!- APic [apic@apic.name] has quit [Ping timeout: 240 seconds] 20180610 12:09:08-!- gallaecio [~quassel@188.79.96.255] has quit [Ping timeout: 255 seconds] 20180610 13:19:42-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180610 13:58:27-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 260 seconds] 20180610 14:10:31< irker038> wesnoth/wesnoth:1.14 Iris Morelle 2d98c936d5 tools: Add steam-changelog AppVeyor: All builds passed 20180610 14:20:05< irker038> wesnoth: Steve Cotton wesnoth:1.14 c730c66ef14d / data/core/about.cfg: Update core/about.cfg to use "merfolk" instead of "mermen" (part of #2940) https://github.com/wesnoth/wesnoth/commit/c730c66ef14de1f37ccd5a2455cfd665dd9aa726 20180610 14:22:33< irker038> wesnoth: Steve Cotton wesnoth:master fbc74bf00725 / data/core/about.cfg: Update core/about.cfg to use "merfolk" instead of "mermen" (part of #2940) https://github.com/wesnoth/wesnoth/commit/fbc74bf007258436a65926bf3e3edf9f7aa143f3 20180610 14:41:50-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180610 14:50:57-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection] 20180610 15:32:17<+discordbot1> tfw you mouse suddenly stops working and isn't registering clicks properly >_< 20180610 15:32:27< celticminstrel> >< 20180610 15:33:25<+discordbot1> and even more funny, it happened in the middle of watchin a Buzzfeed Unsolved Supernatural episode 😂 20180610 15:35:16<+discordbot1> and it just seems to be the left mouse button 20180610 15:50:41< celticminstrel> WTH is this https://forums.wesnoth.org/viewtopic.php?p=629395#p629395 20180610 16:19:15< irker038> wesnoth/wesnoth:master Iris Morelle a92b83e404 tools: Add steam-changelog AppVeyor: All builds passed 20180610 16:22:01<+discordbot1> looks like wesnoth 1.14 is on Android now: https://forums.wesnoth.org/viewtopic.php?f=6&t=48327&p=629688#p629683 20180610 16:24:51<+discordbot1> also relatedly @shadowm : I've noticed that on the website the android download link has been added, pointing to 1.12 app. Thank you for that, but now can somebody please update the link moving it to the 1.14 application? 20180610 16:25:12<+discordbot1> Didn't I remove it? 20180610 16:25:31<+discordbot1> Ohhh the 1.14 version is finally out? 20180610 16:25:35<+discordbot1> I still see it 20180610 16:25:37<+discordbot1> yeah 20180610 16:26:39<+discordbot1> @Vultraz everything is uploaded 20180610 16:27:05<+discordbot1> Sweet, thanks 20180610 16:27:24<+discordbot1> We can announce tomorrow (middle of the night right now for me) 20180610 16:28:42< irker038> wesnoth: Iris Morelle wesmere:master 12a147cdd66f / static/docroot/index.php: home: Update Android port link for the newly-released 1.14 version https://github.com/wesnoth/wesmere/commit/12a147cdd66fa2957ad913389cffcc8b9c01d4d7 20180610 16:28:50<+discordbot1> @loonycyborg Can you confirm the things gfgtdf said in the draft thread? 20180610 16:29:54<+discordbot1> linky? 20180610 16:30:07<+discordbot1> https://forums.wesnoth.org/viewtopic.php?p=629679#p629679 20180610 16:31:32<+discordbot1> I'll say this though, I had no idea 32-bit Wesnoth was being ditched entirely. 20180610 16:31:43<+discordbot1> That's not good. 20180610 16:33:17<+discordbot1> There are people with legacy installs of Windows that do not support 64-bit applications even if their CPU does, so this is effectively puling the rug from under their feet without prior warning. 20180610 16:33:52-!- lilinitsy [~lilinitsy@75-168-126-214.mpls.qwest.net] has joined #wesnoth-dev 20180610 16:34:24<+discordbot1> And since Microsoft's licensing system is a byzantine mess I've never properly understood if you can reinstall Windows from scratch (which is the hugest of chores I can think of computer-wise) using the same license for a different CPU arch or you need to purchase a new license. 20180610 16:34:57<+discordbot1> You definitely can't flip a switch and make your 32-bit install 64-bit, because that's not supported by the platform's design or the installer. 20180610 16:35:21< lilinitsy> Windows 10 supports 32 bit? 20180610 16:35:39<+discordbot1> Windows 10 is not the only Windows version that is supported by us or Microsoft at the moment. 20180610 16:35:58<+discordbot1> And yes, there is still a 32-bit version of Windows 10. 20180610 16:36:26<+discordbot1> The only saving grace here is that we can safely assume that Steam users in particular are probably all running 64-bit Windows, at least those who've bought or been gifted games on the store. 20180610 16:36:55<+discordbot1> But not all Windows users are Steam users. 20180610 16:37:16< lilinitsy> There's not much you can run with only 3-3.5gb of RAM :D especially when the OS takes up a few. 20180610 16:37:50<+discordbot1> Microsoft has shown that Windows itself takesonly a couple hundred megabytes of RAM. 20180610 16:38:16<+discordbot1> the point is it still exists though, and changing the minimum requirements during a stable series isn't great, even if it only affects a small number of people. 20180610 16:38:18<+discordbot1> I replied in the forum 20180610 16:39:12<+discordbot1> How about DEP and ASLR? 20180610 16:39:53<+discordbot1> I added those switches to scons so it should be used now 20180610 16:40:01<+discordbot1> Did you make sure though? 20180610 16:40:33<+discordbot1> I think there are ways to check whether the image of a running process really makes use of the features. 20180610 16:40:38< celticminstrel> So Wesnoth is still 32-bit on Windows. 20180610 16:40:46<+discordbot1> yes 20180610 16:41:25<+discordbot1> Also, I strongly believe it'd be preferable for 1.14 to ship both 32-bit and 64-bit binaries. I don't know if Steam can handle that. And I reckon that for the wesnoth.org package it may be possible to write a minilauncher that runs the right version. 20180610 16:42:28<+discordbot1> Although... that means shipping like 32 DLLs in total in the same package. 20180610 16:42:33< celticminstrel> I don't suppose Windows has any equivalent of the "fat" or "universal" packages that Mac has? 20180610 16:42:43< celticminstrel> Or had at least, no idea if it still uses them. 20180610 16:42:53< celticminstrel> Basically bundling both binaries in a single file. 20180610 16:43:04< celticminstrel> In this case, 32-bit and 64-bit. 20180610 16:43:09<+discordbot1> Indeed, Windows doesn't have any way to do that. 20180610 16:43:21< celticminstrel> That's a little surprising TBH, but okay. 20180610 16:43:32<+discordbot1> Indeed... 20180610 16:43:37< celticminstrel> Certainly I've never seen any evidence that it can do it though. 20180610 16:43:58<+discordbot1> does mac have fat libraries too? 20180610 16:44:08< celticminstrel> "too"? 20180610 16:44:31< celticminstrel> "Fat" was used way back in the time of Mac Classic to describe binaries that contained both x86 and PPC code. 20180610 16:44:49< celticminstrel> ... 20180610 16:44:55< celticminstrel> Sorry, not x86, 68k. 20180610 16:45:00<+discordbot1> Back when it was 16-bit Windows vs. 32-bit Windows, people usually wrote their installers so they'd install two different sets of binaries depending on what they were running on. 20180610 16:45:27<+discordbot1> Either that or they actually continued to write 16-bit Windows applications that had special knowledge of Windows 9x's platform in particular. 20180610 16:45:33< celticminstrel> In OSX they switched to calling such binaries "universal", when they contained PPC and x86 code or even x86 and x86_64 code. 20180610 16:45:38<+discordbot1> (And usually wouldn't run on Windows NT as a result.) 20180610 16:46:28<+discordbot1> can universal binary carry ppc, x86 and x86_64 at the same time? 😛 20180610 16:46:36< celticminstrel> Pretty sure it can, yes. 20180610 16:46:47< celticminstrel> And you could probably add ppc_64 too. 20180610 16:46:53< lilinitsy> Do you know this second-hand, or are you telling a "back in my day story" with that? :D 20180610 16:47:09< celticminstrel> Though I don't think there were many ppc_64 macs so it'd probably be kinda a waste of space. 20180610 16:47:30< celticminstrel> lilinitsy: Hmm? I used to have a 68k mac so I did experience this firsthand, if that's what you're asking. 20180610 16:47:55< celticminstrel> And then I switched to a PPC mac, and then I switched to an Intel mac. 20180610 16:48:04< lilinitsy> Ah. I meant Back when it was 16-bit Windows vs. 32-bit Windows, people usually wrote their installers so they'd install two different sets of binaries depending on what they were running on. 20180610 16:48:11< celticminstrel> Oh, okay. 20180610 16:48:13<+discordbot1> First-hand. 20180610 16:51:34<+discordbot1> i really don't know what to do about my mouse breaking... >_> 20180610 16:52:01<+discordbot1> Get a new mouse. 20180610 16:52:11<+discordbot1> But first make sure it's not lint or dirt trapped underneath the button. 20180610 16:52:44< celticminstrel> The problem with modern mice is that they seem to be designed under the assumption that this never happens and you would never need to open the mouse up to clean it. 20180610 16:52:46<+discordbot1> You may need to either carefully slip something thin in there to check, or just do what I do and repeatedly smash your mouse against the desk. 20180610 16:53:00< celticminstrel> The Apple mouse was the worst of this. 20180610 16:53:03<+discordbot1> They are actually designed under the assumption that you will buy a new one when it happens. 20180610 16:53:26<+discordbot1> I mean it's just a $20 bluetooth mouse 20180610 16:53:27< celticminstrel> (Though the newer Apple mouse is probably fine, as it's touch-based.) 20180610 16:53:39<+discordbot1> if I were stateside I would just go to Best Buy and buy a new one 20180610 16:53:41<+discordbot1> I got a lot of mileage of a mouse (that technically still works, but a real mouse chewed on the mouse wheel) by doing this and eventually figuring out how to disassemble. 20180610 16:53:43<+discordbot1> it 20180610 16:53:48<+discordbot1> but I happen not to be stateside >_> 20180610 16:53:52< celticminstrel> Yeah that's a terrible assumption? Why would you want to buy a new one if the only problem with the old one is that it needs to be cleaned? That's wasteful. 20180610 16:54:08<+discordbot1> Because the manufacturer earns more money that way. 20180610 16:54:12<+discordbot1> maybe ill buy some new batteries tomorrow 20180610 16:54:27<+discordbot1> but I did just put in new ones and it still doesn't work... 20180610 16:54:32< celticminstrel> I think my mouse has actual screws that I can take out but they're hidden under stickers. 20180610 16:54:37-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180610 16:54:47< celticminstrel> Ugh, batteries. Why do people like wireless mice so much. 20180610 16:54:57<+discordbot1> I use rechargeable batteries with mine. 20180610 16:54:59<+discordbot1> ease of transport 20180610 16:55:05<+discordbot1> They last quite a while (1-2 months). 20180610 16:55:33<+discordbot1> Back when I used wired mice it was a constant fight with the cable getting in my way. 20180610 16:55:46<+discordbot1> And adding extra drag to the thing in general. 20180610 16:55:47<+discordbot1> the problem seems to be isolated to the left mouse button. But it also seems to be making random phantomc licks 20180610 16:55:54<+discordbot1> clicks 20180610 16:55:58<+discordbot1> Lint. 20180610 16:56:09<+discordbot1> That's definitely lint. 20180610 16:57:26< lilinitsy> Might've missed it, what kind of mouse do you have? 20180610 16:57:51<+discordbot1> a wireless bluetooth mouse, why 20180610 16:58:06< lilinitsy> Which brand / model? 20180610 16:58:18<+discordbot1> does it matter, specifically? 20180610 16:58:33< lilinitsy> All mice are not equal, so maybe. 20180610 16:59:09-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 264 seconds] 20180610 17:00:16<+discordbot1> an HP x4000b 20180610 17:00:39< celticminstrel> HP makes mice? Huh. 20180610 17:01:19<+discordbot1> Ew, HP. 20180610 17:01:23<+discordbot1> Yeah. As far as generic mice, I've had good experiences with Dell's. 20180610 17:01:52< celticminstrel> Mine is Logitech. 20180610 17:02:04<+discordbot1> Same. 20180610 17:02:20< lilinitsy> My brother had a logitech catch fire in the middle of playing some flash game. 20180610 17:02:26< celticminstrel> Wow. 20180610 17:02:37< celticminstrel> That can't be a common occurrence. 20180610 17:02:41<+discordbot1> Faulty batteries? 20180610 17:02:49< lilinitsy> It was the wire, oddly enough. 20180610 17:02:50<+discordbot1> My mouse is SteelSeries Sensei. 20180610 17:02:54< lilinitsy> I'm not sure how that even happens. 20180610 17:03:01< celticminstrel> What an odd name. 20180610 17:03:08< lilinitsy> Oh I tried the Sensei. My hand was a little too small for it then, but it was nice. 20180610 17:03:46<+discordbot1> I like this one since it has a good size and height 20180610 17:04:26<+discordbot1> lot of mice are too low... 20180610 17:06:02< lilinitsy> I came on because I'm jobless and bored and felt like working on something, anyway. I'm looking through the github issues - are there any that pop out as being easy enough to jump into without being familiar with this codebase? 20180610 17:06:58<+discordbot1> See https://github.com/wesnoth/wesnoth/issues?q=is%3Aopen+is%3Aissue+label%3A"Good+first+issue" 20180610 17:07:17<+discordbot1> Um. 20180610 17:07:17<+discordbot1> https://github.com/wesnoth/wesnoth/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22Good+first+issue%22 20180610 17:07:30<+discordbot1> try that link^ 20180610 17:07:33<+discordbot1> 😛 20180610 17:07:41< lilinitsy> :) Right. 20180610 17:07:44<+discordbot1> Yeah I was going to say jyrkive's link came up with an empty list for me. Yours works. 20180610 17:07:53<+discordbot1> same 20180610 17:07:58< lilinitsy> Guess I'll filter out the WML ones 20180610 17:10:34<+discordbot1> anyway, having a touchscreen means the loss of my mouse isn't that bad, but...still very annoying 20180610 17:10:55<+discordbot1> can't program without a mouse 20180610 17:11:24< lilinitsy> I use VS Code, but I have quite a few friends who just use emacs or vim. 20180610 17:11:37< lilinitsy> Inconvienent, but not undoable. 20180610 17:12:01<+discordbot1> Vultraz are you going to try my suggestions or...? 20180610 17:12:18<+discordbot1> i can't take it apart 20180610 17:12:24<+discordbot1> That's not the only suggestion. 20180610 17:12:42<+discordbot1> I can open the top to take out the batteries but I can't take it apart further. and I did try replacing the batteries 20180610 17:12:53<+discordbot1> updating drivers (no updates), restarting my laptop 20180610 17:13:05<+discordbot1> Replacing the batteries or updating the drivers weren't even suggestions. 20180610 17:13:07<+discordbot1> Hello. 20180610 17:13:26<+discordbot1> i did not try smashing it against the desk 20180610 17:13:43<+discordbot1> Get a piece of paper or something in there. 20180610 17:14:28<+discordbot1> Then if that doesn't work, start smashing. Gently. 20180610 17:15:22<+discordbot1> The idea isn't to break the mouse, just move all the garbage around until it either falls off through the gaps or it moves somewhere else where it doesn't cause any trouble. 20180610 17:15:33< lilinitsy> smashing should be the first course of action! 20180610 17:16:16<+discordbot1> And yes you do need a certain technique to smash it. Identify the gaps under the buttons. 20180610 17:17:35<+discordbot1> not helping. I'll go buy some air tomorrow 20180610 17:25:03-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180610 18:05:48-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection] 20180610 18:13:39-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180610 18:27:29< zookeeper> random note: if you can't open it because there's no visible screws, then they might indeed just be hidden. 20180610 18:28:19-!- gfgt [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180610 18:28:34-!- gfg [~androirc@tmo-107-125.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180610 18:29:19<+discordbot1> In my experience they tend to be hidden under stickers like celmin said, and those stickers themselves are often seamless enough to look like they're part of the cover. 20180610 18:29:52<+discordbot1> Sometimes they're in the battery compartment instead of outside. 20180610 18:30:27< zookeeper> oh right, i missed the sticker mention. 20180610 18:32:24< celticminstrel> But the Apple Mighty Mouse was actually glued shut. 20180610 18:32:37< celticminstrel> So that was the worst. 20180610 18:33:25< celticminstrel> It's still technically possible to open, but once open, you need tape or something to keep it closed again. Also, for a wired one, you need to be careful not to cut the wire while opening it. 20180610 18:34:12< celticminstrel> It may not have 360° scroll but at least my Logitech is openable, and it does have horizontal scroll (a standard scroll wheel that can tilt to the side). 20180610 18:34:36< zookeeper> well that's a terribly designed mouse then. 20180610 18:34:52< celticminstrel> Yup. 20180610 18:35:44< celticminstrel> I do kinda wonder if simply removing the stickers on my Logitech would cause problems. 20180610 18:36:56< zookeeper> i've been happily using a second-hand logitech mx518 with all the special buttons disabled (because otherwise i keep accidentally pressing them) for almost 7 years \o/ 20180610 18:41:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180610 18:42:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180610 18:53:16< lilinitsy> I can feel the screws under the stickers on my wmo, but you wouldn't notice them otherwise. 20180610 18:57:11< celticminstrel> Special buttons? Do you have more than five buttons then? 20180610 18:57:31< celticminstrel> Including the scroll wheel as a button. 20180610 19:00:49-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180610 19:03:13< zookeeper> celticminstrel, it has forward/back buttons, then + and - for adjusting dpi, and then one extra 20180610 19:03:30-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180610 19:28:44-!- irker038 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180610 19:42:42-!- APic [apic@apic.name] has joined #wesnoth-dev 20180610 19:49:31< loonycyborg> there are mice with even larger number of buttons 20180610 19:49:39< loonycyborg> they're no longer classified mice 20180610 19:49:47< loonycyborg> they're rats 20180610 19:52:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180610 19:54:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180610 20:12:26< celticminstrel> Not sure how this can work TBH, pcall() will catch errors from eg adding nil values but I don't think there's any way to enrich that error message with a stack trace? 20180610 20:12:47< celticminstrel> Short of actually hacking the C lua_error function. 20180610 20:19:56< gfgt> you can pass an error handler function to pcall that call generate the Trace. 20180610 20:26:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180610 20:26:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180610 20:27:41-!- gallaecio_ [~quassel@188.79.96.255] has joined #wesnoth-dev 20180610 20:27:44-!- gallaecio [~quassel@188.79.96.255] has quit [Ping timeout: 255 seconds] 20180610 20:49:16<+discordbot1> gfgtdf loonycyborg did DEP really have to be enabled in Wesnoth? I thought that was a kernel feature. 20180610 20:49:47<+discordbot1> As in I thought the kernel did it on its own without requiring executables to opt in. 20180610 20:49:52<+discordbot1> program needs to be prepared by linker too 20180610 20:51:14<+discordbot1> And GCC didn't do that by default? 20180610 20:51:27<+discordbot1> That's... questionable. 20180610 20:51:48<+discordbot1> But then again the stack canary isn't enabled by default either so meh. 20180610 20:52:56<+discordbot1> (Which probably means we don't use it either.) 20180610 20:54:24<+discordbot1> (Which probably means we should consider doing so.) 20180610 20:55:01<+discordbot1> (I'm sure someone will point this out if they see me advertising DEP and ASLR in the announcement.) 20180610 20:56:53< celticminstrel> gfgt: AFAIK that only works when calling from C/C++. 20180610 20:58:04<+discordbot1> gfgtdf: Added DEP, ASLR and /query version to the announcement. 20180610 20:59:13-!- gallaecio_ [~quassel@188.79.96.255] has quit [Ping timeout: 248 seconds] 20180610 20:59:20-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180610 21:00:25< gfgt> Ok thx 20180610 21:01:19< gfgt> Celmin: since lus 5.2 the should be xpcall exactly for that purpose. 20180610 21:01:30< celticminstrel> Ah, xpcall. 20180610 21:01:39< celticminstrel> Okay I'll try that. 20180610 21:02:12-!- irker655 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180610 21:02:12< irker655> wesnoth/wesnoth:1.14 Steve Cotton c730c66ef1 Update core/about.cfg to use "merfolk" i AppVeyor: All builds passed 20180610 21:06:05<+discordbot1> loonycyborg: Sorry to be a pest, but I want to know if DEP and ASLR are enabled only for the official builds (i.e. you have a custom flag in your build process) or for all builds with SCons. 20180610 21:06:25< loonycyborg> all scons builds pass it 20180610 21:06:36<+discordbot1> And on Linux, I don't see the stack canary being enabled. 20180610 21:06:52<+discordbot1> /usr/bin/ccache g++ -o build/release/serialization/binary_or_text.o -c -std=c++11 -Wold-style-cast -pipe -march=native -Wall -Wextra -Werror=non-virtual-dtor -pthread -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Werror -O3 -include boost-patched/bind/arg.hpp -DHAVE_MYSQLPP -DHAVE_CONFIG_H -D_X11 -DLOAD_REVISION -DFIFODIR='"/var/run/wesnothd"' -DWESNOTH_PATH='"/usr/local/share/wesnoth"' -DLOCALEDIR='"translations"' 20180610 21:06:53<+discordbot1> -DHAS_RELATIVE_LOCALEDIR -DPREFERENCES_DIR=\".wesnoth-1.14\" -Ibuild -Isrc -isystem /usr/include/mysql src/serialization/binary_or_text.cpp 20180610 21:07:05<+discordbot1> The option is one of several variations on -fstack-protector or so. 20180610 21:07:24<+discordbot1> And yes, it has a performance impact. 20180610 21:07:41<+discordbot1> The precise impact depends on which option you decide to use. 20180610 21:26:23-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180610 21:45:54< irker655> wesnoth: Celtic Minstrel wesnoth:wml_error_recovery ee2331bd020c / data/lua/wml-utils.lua: Don't interrupt the event after a WML error https://github.com/wesnoth/wesnoth/commit/ee2331bd020c8589208dfd10632bfb0566a64ca5 20180610 21:45:55< celticminstrel> gfgt: Seems to work ^ 20180610 21:52:33<+discordbot1> @shadowm I added the harden=yes|no option, which includes that. I think it's only in master, though. 20180610 21:52:38<+discordbot1> https://github.com/wesnoth/wesnoth/pull/3015 20180610 21:52:49<+discordbot1> It's not enabled by default in 1.14, certainly. 20180610 21:53:06<+discordbot1> And also this kind of thing is sort of useless if it isn't enabled by default. <_< 20180610 21:53:25<+discordbot1> yeah, I definitely wouldn't have enabled by default anywhere. I assumed there would need to be more discussion for that. 20180610 21:53:40<+discordbot1> given the potential performance impact, if nothing else 20180610 21:54:02<+discordbot1> PIE shouldn't have any runtime performance impact I think? 20180610 21:54:59<+discordbot1> I haven't read up on it but I assume the relocations are resolved during image initialization. 20180610 21:56:06<+discordbot1> On the other hand, I think compilers are supposed to make it the default these days? 20180610 21:56:32<+discordbot1> I vaguely remember running into a build-time issue with Linux (kernel) because of a related change in Debian 20180610 21:57:27<+discordbot1> I'm not sure about the compiler defaults, but there was also this: https://github.com/wesnoth/wesnoth/pull/3044 20180610 21:58:03<+discordbot1> in which case, the "default" would apparently be silently changed. 20180610 21:58:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20180610 22:01:43<+discordbot1> it definitely wouldn't be difficult to backport either of those changes though, if that's wanted for the Steam/flatpak 1.14 builds. 20180610 22:01:44-!- gfgt [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection] 20180610 22:07:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180610 22:09:58-!- gfgt [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180610 22:20:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180610 22:20:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180610 22:23:46-!- gfgt [~androirc@tmo-107-125.customers.d1-online.com] has quit [Remote host closed the connection] 20180610 22:23:57-!- gfgt [~androirc@tmo-107-125.customers.d1-online.com] has joined #wesnoth-dev 20180610 22:29:02< irker655> wesnoth/wesnoth:master Steve Cotton fbc74bf007 Update core/about.cfg to use "merfolk" i AppVeyor: All builds passed 20180610 22:43:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180610 22:58:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180610 22:59:01-!- janebot_ [~Gambot@206.189.184.60] has joined #wesnoth-dev 20180610 22:59:01-!- janebot_ is now known as janebot 20180610 22:59:07-!- janebot [~Gambot@206.189.184.60] has quit [Changing host] 20180610 22:59:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180610 23:11:28-!- travis-ci [~travis-ci@ec2-54-80-154-148.compute-1.amazonaws.com] has joined #wesnoth-dev 20180610 23:11:29< travis-ci> wesnoth/wesnoth#18551 (wml_error_recovery - ee2331b : Celtic Minstrel): The build failed. 20180610 23:11:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/390515383 20180610 23:11:29-!- travis-ci [~travis-ci@ec2-54-80-154-148.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180610 23:16:49-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180610 23:29:05< vn971> @Pentarctagon so if I want to play with this, I can now write `scons ... harden=yes` ,correct? For master branch only now, right? 20180610 23:29:42<+discordbot1> correct 20180610 23:31:47< vn971> thanks. Good job by the way 👍 20180610 23:32:43<+discordbot1> thanks 😃 20180610 23:39:28-!- gfgt [~androirc@tmo-107-125.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180610 23:58:46< celticminstrel> I think it failed because some WML tests were relying on the event being interrupted? --- Log closed Mon Jun 11 00:00:05 2018