--- Log opened Thu Jun 14 00:00:56 2018 20180614 00:25:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180614 00:26:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit] 20180614 00:27:19-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180614 00:27:27-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit] 20180614 00:27:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180614 00:36:39< irker447> wesnoth/wesnoth:1.14 gfgtdf 74bd575794 allow non hosts to change factions later AppVeyor: All builds passed 20180614 00:38:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180614 01:42:48<+discordbot2> [10:57 AM] BOTIRC: Oh btw sorry I guess I should have posted this in regular chat 20180614 01:42:54<+discordbot2> I think he got that a little bit ago. 20180614 03:05:56-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: No Ping reply in 180 seconds.] 20180614 03:08:33-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20180614 03:28:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180614 03:28:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180614 03:37:15<+discordbot2> https://forums.wesnoth.org/viewtopic.php?f=4&p=629898#p629898 20180614 03:37:39-!- irker447 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180614 03:44:08-!- irker202 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180614 03:44:08< irker202> wesnoth/wesnoth:1.14 Steve Cotton ea35e6a9a9 DW: Change the team name from Merman For AppVeyor: All builds passed 20180614 03:51:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180614 03:51:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180614 04:25:38<+discordbot2> @Vultraz is wesnoth.set_menu_item supported for lua? 20180614 04:32:17< celticminstrel> It might be one of the "undocumented because it's not finalized" parts of the Lua API. 20180614 04:32:32< celticminstrel> I'd recommend using wesnoth.wml_actions.set_menu_item instead. 20180614 04:35:13<+discordbot2> okay 20180614 04:36:18< celticminstrel> I think eventually wesnoth.set_menu_item probably will become part of the public API eventually, but, probably taking different arguments than currently. 20180614 04:37:03<+discordbot2> so with wesnoth.wml_actions.set_menu_item, am I overwriting the default WML tag? 20180614 04:37:13< celticminstrel> Uhh? 20180614 04:37:25<+discordbot2> since [set_menu_item] is already an existing tag 20180614 04:37:30< celticminstrel> If you're calling it, then it's exactly the same as using the tag. 20180614 04:37:38<+discordbot2> ah, never mind 20180614 04:37:43<+discordbot2> I'm not thinking about how I want to do this 20180614 04:37:47< celticminstrel> Overwriting it would mean defining a function called wesnoth.wml_actions.set_menu_item. 20180614 04:41:10-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180614 04:46:27-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180614 04:46:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180614 04:46:58-!- celticminstrel is now known as celmin|sleep 20180614 04:58:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 264 seconds] 20180614 04:58:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180614 05:34:13-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180614 05:49:12-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180614 05:59:45-!- gallaecio [~quassel@188.79.96.255] has quit [Ping timeout: 264 seconds] 20180614 06:13:34< irker202> wesnoth: Nils Kneuper wesnoth:1.14 7f3b4bdc8b4f / changelog.md players_changelog.md po/wesnoth-lib/sk.po: updated Slovak translation https://github.com/wesnoth/wesnoth/commit/7f3b4bdc8b4f6e8a2c383075a66ffbc7978e7664 20180614 06:13:47-!- gallaecio [~quassel@72.red-81-39-199.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180614 06:43:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180614 07:03:50-!- vladimirslavik [vslavik@nat/redhat/x-hlowxhuaolftjftl] has joined #wesnoth-dev 20180614 07:04:43-!- vladimirslavik [vslavik@nat/redhat/x-hlowxhuaolftjftl] has quit [Changing host] 20180614 07:04:43-!- vladimirslavik [vslavik@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev 20180614 07:18:05-!- vladimirslavik [vslavik@wesnoth/translator/VladimirSlavik] has quit [Ping timeout: 240 seconds] 20180614 07:29:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180614 07:31:14-!- vladimirslavik [vslavik@nat/redhat/x-zveipjvwsdqmowzy] has joined #wesnoth-dev 20180614 07:36:14-!- vladimirslavik [vslavik@nat/redhat/x-zveipjvwsdqmowzy] has quit [Ping timeout: 276 seconds] 20180614 07:44:33-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 248 seconds] 20180614 07:52:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180614 07:54:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180614 08:32:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180614 08:47:11-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180614 08:47:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Disconnected by services] 20180614 08:47:11-!- celmin is now known as celticminstrel 20180614 08:58:20< zookeeper> @Yumi so what's the [filter_adjacent] bug? 20180614 09:01:28<+discordbot2> uhm I'll make an issue for it later today 20180614 09:01:35<+discordbot2> it's 5:00 AM here, I need to sleep 20180614 09:04:50<+discordbot2> basically the documentation says that for ability tags like [leadership] 20180614 09:05:03<+discordbot2> it should take [filter_adjacent] as an argument, but it actually doesn't work 20180614 09:05:15<+discordbot2> you have to put the [filter_adjacent] tag in side of a [filter] tag for it to work 20180614 09:05:35<+discordbot2> anyway, time to 💤 20180614 09:41:51< zookeeper> ah, hmm, okay. 20180614 09:49:53< zookeeper> luckily it's a pretty redundant tag in almost all situations, since you can just use [filter] (which, personally, i'd find more comfortable anyway). 20180614 09:53:49-!- irker202 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180614 11:33:58-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180614 12:55:05-!- celticminstrel is now known as celmin|away 20180614 13:03:03-!- irker058 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180614 13:03:03< irker058> wesnoth/wesnoth:1.14 Nils Kneuper 7f3b4bdc8b updated Slovak translation AppVeyor: All builds passed 20180614 13:22:12-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180614 13:25:10-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180614 13:29:50-!- gfg [~androirc@134.76.63.8] has quit [Ping timeout: 260 seconds] 20180614 13:43:14-!- Choicerer [~bodhidhar@213.152.162.74] has joined #wesnoth-dev 20180614 14:03:35-!- gfgt [~androirc@134.76.63.8] has quit [Ping timeout: 265 seconds] 20180614 14:26:17< Choicerer> How are strings marked as translatable in Lua? 20180614 14:34:27< Choicerer> Nevermind 20180614 14:37:54-!- gfgt [~androirc@ersc159.goemobile.de] has joined #wesnoth-dev 20180614 15:03:10-!- gfgt [~androirc@ersc159.goemobile.de] has quit [Ping timeout: 268 seconds] 20180614 15:14:31-!- gfgt [~androirc@ersc159.goemobile.de] has joined #wesnoth-dev 20180614 15:17:02-!- gfgt [~androirc@ersc159.goemobile.de] has quit [Remote host closed the connection] 20180614 15:33:18-!- gallaecio [~quassel@72.red-81-39-199.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180614 15:54:30-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180614 15:59:05-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180614 16:03:07-!- irker058 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180614 16:52:57<+discordbot2> zookeeper: also, do you think my pull request is going to be committed sometime 20180614 16:53:00<+discordbot2> the THoT revision 20180614 16:59:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180614 17:02:18< zookeeper> @Yumi i can't merge something that big without testing, but i guess i can be persuaded to give it a go since you posted the saves and all. 20180614 17:03:30< zookeeper> from a quick glance at the diff, the dash in for example "It is Karrag's doing - his will, and his dark magic" should be the other kind of dash (em dash?) we use everywhere else, and there's a thing that adds 3 max hp to a unit which doesn't look like it'd survive levelups or such. 20180614 17:05:11< zookeeper> (it's also a moveto event so you don't even need to store the unit) 20180614 17:12:16<+discordbot2> yah it should be 20180614 17:12:52<+discordbot2> I'll look at the 3 max hp thing later 20180614 17:13:31<+discordbot2> The dash which is used everywhere would be — 20180614 17:14:44<+discordbot2> okay 20180614 17:48:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180614 17:48:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180614 18:03:35-!- Choicerer [~bodhidhar@213.152.162.74] has quit [Ping timeout: 245 seconds] 20180614 18:03:58-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 264 seconds] 20180614 18:43:05-!- gfgt [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180614 18:43:21-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180614 19:37:40<+discordbot2> What's with the codacy bot? It kept complaining about some unused variable that wasn't unused, but someone eventually deleted its comments. 20180614 20:50:24-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:11e1:bccb:4191:10e4] has joined #wesnoth-dev 20180614 21:02:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20180614 21:11:07-!- irker935 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180614 21:11:07< irker935> wesnoth/wesnoth:master DisherProject b8ab18d9b6 Fix weapon specials marked as inactive i AppVeyor: All builds passed 20180614 21:12:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180614 21:23:41-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180614 21:30:44-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:11e1:bccb:4191:10e4] has quit [Quit: Leaving] 20180614 21:42:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180614 21:43:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180614 21:50:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180614 21:50:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180614 22:22:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180614 22:24:14-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.9.1] 20180614 22:24:23-!- esr [~esr@thyrsus.com] has joined #wesnoth-dev 20180614 22:24:23-!- esr [~esr@thyrsus.com] has quit [Changing host] 20180614 22:24:23-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20180614 22:59:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180614 23:18:41< irker935> wesnoth/wesnoth:master josteph 3e25a9b95d Revert "Excluded data/test/ from tarball AppVeyor: All builds passed 20180614 23:27:33<+discordbot2> @lilinitsy IIRC codacy is a code quality checker bot. @Tad Carlucci could tell you more, if/when he gets back on discord. 20180614 23:28:05<+discordbot2> Oh yeah, I get that. I mean, is there anything known wrong with it? 20180614 23:38:56-!- lilinitsy_ [~lilinitsy@75-168-126-214.mpls.qwest.net] has quit [Ping timeout: 256 seconds] 20180614 23:40:32<+discordbot2> If he deleted the comment it left, I assume everything is fine --- Log closed Fri Jun 15 00:00:57 2018