--- Log opened Sat Jun 16 00:00:58 2018 20180616 00:06:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180616 00:12:14< irker239> wesnoth/wesnoth:1.14 josteph 08c983eb41 help: Prevent line breaks within the "Re AppVeyor: All builds passed 20180616 00:35:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180616 00:49:37-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev 20180616 00:51:04<+discordbot2> Found one of my old mice... 20180616 00:51:18<+discordbot2> It barely works 20180616 00:51:23<+discordbot2> But it'll do for now 20180616 00:51:32<+discordbot2> Left click works, right click barely works 20180616 00:52:36<+discordbot2> I swear, these damn things wear down so easily 20180616 00:53:18<+discordbot2> Right click probably wore down from too much Dota 20180616 00:53:29<+discordbot2> (right click is move in Dota) 20180616 00:53:40< celticminstrel> Maybe you should get a less cheap one. 20180616 00:54:38<+discordbot2> The one I've been using since Jan 2017 is pretty solid 20180616 00:54:46<+discordbot2> It's the one that just broke, though 20180616 00:54:52<+discordbot2> But at least the clicking didn't wear down πŸ‘ 20180616 00:55:05<+discordbot2> (it's ~ $30) 20180616 00:56:52<+discordbot2> The one which I just plugged in was probably cheaper than that 20180616 00:57:47<+discordbot2> I think there might have been one I got after this one, though... 20180616 00:57:51<+discordbot2> But I dunno where it is 20180616 00:58:58<+discordbot2> Another difference between the mouse that broke is it's bluetooth 20180616 00:59:01<+discordbot2> Not wireless 20180616 00:59:41<+discordbot2> doesn't wireless just mean it doesn't have a wire directly to the USB port? 20180616 01:00:04<+discordbot2> By wireless I mean it has a little USB dongle 20180616 01:00:11<+discordbot2> Bluetooth mice have no such thing 20180616 01:00:36< celticminstrel> Bluetooth mice are wireless though, so... 20180616 01:00:48<+discordbot2> Yes 20180616 01:01:52<+discordbot2> I prefer Bluetooth 20180616 01:01:59< celticminstrel> I prefer wires. 20180616 01:02:01<+discordbot2> even though I don't actually need my USB ports for much... 20180616 01:02:15<+discordbot2> Wires. So primitive. 20180616 01:02:37< celticminstrel> They may be primitive but at least you never need to worry about battery running out. 20180616 01:02:43<+discordbot2> insert Okoye meme 20180616 01:04:45<+discordbot2> I think it was Okoye who said that... 20180616 01:05:20<+discordbot2> (you need to have seen Black Panther to know what I'm referring to) 20180616 01:07:11< celticminstrel> Sorry to disappoint. 20180616 01:07:58<+discordbot2> 😐 20180616 01:09:34<+discordbot2> well, this is the scene: https://youtu.be/gVpWZCSqQEA?t=1m16s 20180616 01:09:42<+discordbot2> (time marked) 20180616 01:10:45< celticminstrel> Eh. 20180616 01:11:06< celticminstrel> Way to make me feel bad for not clicking... 20180616 01:11:30<+discordbot2> (Also Black Panther is an amazing movie you should see it) 20180616 01:11:45< celticminstrel> Is that the one with Wakanda BTW? 20180616 01:11:51< celticminstrel> Because I wanted to see that one. 20180616 01:12:24<+discordbot2> Yes 20180616 01:12:47<+discordbot2> I mean, Infinity War also has scenes in Wakanda, but BP is the main one. 20180616 01:13:01< celticminstrel> Infinity Wars is a crossover so it doesn't count. 20180616 01:13:24-!- gfgtdf_ [~chatzilla@x4e363874.dyn.telefonica.de] has joined #wesnoth-dev 20180616 01:13:26< celticminstrel> Also I heard it killed off the green woman so that's like sixty points against it. 20180616 01:13:40<+discordbot2> "the green woman" 20180616 01:13:52<+discordbot2> Her name is Gamora. 20180616 01:13:55< celticminstrel> Sorry I don't remember anyone's name in Guardians of the Galaxy. Well, except Groot. 20180616 01:14:07< celticminstrel> Thank you. 20180616 01:14:43<+discordbot2> Peter Quill, Gamora, Drax, Rocket, Groot, Mantis 20180616 01:14:56< celticminstrel> Uhh which one's the raccoon. 20180616 01:15:11<+discordbot2> Rocket 20180616 01:15:45< celticminstrel> Well obviously Rocket's the best character anyway. 20180616 01:15:57-!- gfgtdf [~chatzilla@x4e363bfd.dyn.telefonica.de] has quit [Ping timeout: 264 seconds] 20180616 01:16:04-!- gfgtdf_ is now known as gfgtdf 20180616 01:16:49< celticminstrel> Even after you've listed them I still don't remember who Drax and Mantis are (assuming Peter = Starlord). 20180616 01:17:53<+discordbot2> Yes 20180616 01:18:03<+discordbot2> Drax is the big strong one who takes everything literally 20180616 01:18:09< celticminstrel> Oh now I remember him. 20180616 01:19:17<+discordbot2> Mantis is the woman with the ability to read minds 20180616 01:19:31< celticminstrel> I don't remember this person... 20180616 01:19:39< celticminstrel> Was she in the first movie? 20180616 01:19:48<+discordbot2> inb4 this becomes MCU spoiler central. 20180616 01:19:49< celticminstrel> Maybe my memory is just bad. 20180616 01:19:57< celticminstrel> XD 20180616 01:20:22<+discordbot2> No the second movie 20180616 01:20:33< celticminstrel> Oh no wonder I had no idea who she was...? 20180616 01:20:39<+discordbot2> there's also Nebula, who's Gamora's sister. 20180616 01:20:40< celticminstrel> I've only seen the first movie. 20180616 01:20:51<+discordbot2> she's the blue half-cyborg woman 20180616 01:20:54< celticminstrel> I think I remember Nebula maybe? Like some shots of her with Thanos? 20180616 01:21:07< celticminstrel> Not sure if that's her or someone else? 20180616 01:21:23<+discordbot2> Probably her 20180616 01:21:35<+discordbot2> Not very easy to mix her up with the blue dude with a giant hammer 20180616 01:21:39< celticminstrel> XD 20180616 01:21:39<+discordbot2> (Ronan) 20180616 01:22:20<+discordbot2> Anyway yes if you want Wakanda you want Black Panther 20180616 01:23:03< celticminstrel> So next time I go DVD-shopping I guess I should look out for WW, BP, GG1, and GG2, huh. >_> 20180616 01:23:13<+discordbot2> ...DVD? 20180616 01:23:14 * celticminstrel is counting blurays under the umbrella of DVD FTR. 20180616 01:23:20<+discordbot2> Ah 20180616 01:23:24<+discordbot2> Ok, that makes more sense 20180616 01:23:34< celticminstrel> It's like, I'll take whichever they have. 20180616 01:24:06<+discordbot2> GG2 is on Netflix BTW 20180616 01:24:18< celticminstrel> Netflix can die in a fire for all I care. 20180616 01:24:26< celticminstrel> Anyway I prefer to have a physical copy. 20180616 01:24:32<+discordbot2> blinks 20180616 01:24:42<+discordbot2> Fair enough 20180616 01:25:28< celticminstrel> Netflix is basically the successor to TV in any case, which means (IIRC) that it's subscription, which means it's almost certainly not worth it for me who rarely watches things. (Though I could probably watch a few anime on there, but...) 20180616 01:25:40< celticminstrel> Well, a successor. 20180616 01:26:10-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180616 01:26:12< celticminstrel> (I actually watched GG1 on Netflix though.) 20180616 01:26:53<+discordbot2> Netflix has much anime 20180616 01:27:07< celticminstrel> But it doesn't have most anime IIUC. 20180616 01:27:20< celticminstrel> Like it would be maybe 30% of what I want to watch, at most? 20180616 01:27:22<+discordbot2> I suppose for that you want Crunchyroll 20180616 01:27:28< celticminstrel> That's a number pulled out of the air mind you. 20180616 01:27:39< celticminstrel> Wasn't Crunchyroll not even an option? 20180616 01:27:43< celticminstrel> ISTR hearing it doesn't work in Canada. 20180616 01:28:13<+discordbot2> Trump must like it, then 20180616 01:28:41< celticminstrel> I don't think garbage is a suitable topic of conversation. 20180616 01:29:04<+discordbot2> πŸ‘Œ πŸ‘Œ πŸ‘Œ 20180616 01:29:08<+discordbot2> 10/10 20180616 01:30:51<+discordbot2> and yes, Netflix is subscription 20180616 01:31:08<+discordbot2> $10-$12/month 20180616 01:31:12< celticminstrel> The other problem with Crunchyroll is that it doesn't have Netflix anime. :P 20180616 01:31:13<+discordbot2> can't remember exactly 20180616 01:31:36< celticminstrel> But again I'd rather have a physical copy. 20180616 01:32:08<+discordbot2> heh 20180616 01:32:12<+discordbot2> I don't even watch anime 20180616 01:32:20< celticminstrel> Shrug! 20180616 01:32:44<+discordbot2> lol anime. 20180616 01:32:52<+discordbot2> eye twitch 20180616 01:33:10< celticminstrel> That's kinda like eye-twitching at eg Pixar. 20180616 01:34:02<+discordbot2> The Incredibles 2 was v good 20180616 01:34:18<+discordbot2> Good for you I guess. 20180616 01:34:19< celticminstrel> I think I might've seen The Incredibles maybe? 20180616 01:34:25< celticminstrel> Not the sequel, the first one. 20180616 01:35:04<+discordbot2> I caught about two thirds of the first movie on TV. 20180616 01:35:17<+discordbot2> The beginning bit and then most of the rest. 20180616 01:35:40< celticminstrel> I might be thinking of a different movie though. IIRC there was a cockroach doctor or something? 20180616 01:36:01< celticminstrel> I could also be confusing two different movies I saw, that can happen sometimes. 20180616 01:36:14<+discordbot2> ...a what? 20180616 01:36:25< celticminstrel> Do I have to say it twice? 20180616 01:36:34<+discordbot2> I remember no such thing 20180616 01:36:55< celticminstrel> Well whatever. 20180616 01:37:37<+discordbot2> not even sure what movie that might be... 20180616 01:37:58<+discordbot2> there was a cockroach in Wall-E...but it wasn't a doctor by any stretch 20180616 01:38:09< celticminstrel> Maybe Wall-E then. 20180616 01:38:18< celticminstrel> I could be making up the doctor part. 20180616 01:47:22<+discordbot2> Wall-E was so cute :) 20180616 01:47:44-!- gfgtdf [~chatzilla@x4e363874.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.8.1/20180605153619]] 20180616 01:54:12-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit [] 20180616 02:06:38<+discordbot2> Indeed 20180616 02:06:40-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180616 02:08:26-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection] 20180616 02:09:35-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 260 seconds] 20180616 02:11:52-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180616 02:20:50-!- Guest83891 [uid51591@gateway/web/irccloud.com/x-xdqeymhdhyqoyioi] has joined #wesnoth-dev 20180616 02:22:01-!- Guest83891 [uid51591@gateway/web/irccloud.com/x-xdqeymhdhyqoyioi] has quit [Client Quit] 20180616 02:23:04-!- ToBeFree [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180616 02:30:43< irker239> wesnoth/wesnoth:1.14 Steve Cotton eba32fd8da DW: Change the team name from Merman For AppVeyor: All builds passed 20180616 03:03:32< irker239> wesnoth: Charles Dang wesnoth:master d7edb83b165c / src/gui/widgets/ (7 files): GUI2: added a bunch of missing virtual specifiers https://github.com/wesnoth/wesnoth/commit/d7edb83b165c5e6225783e1bbb65d1d040bebe6d 20180616 03:03:35< irker239> wesnoth: Charles Dang wesnoth:master 2d9b7d82c6a6 / src/gui/widgets/ (menu_button.cpp menu_button.hpp multimenu_button.cpp multimenu_button.hpp): GUI2/[Multi]Menu Button: removed retval handling https://github.com/wesnoth/wesnoth/commit/2d9b7d82c6a602c0b142bea38cebdb3650db62d6 20180616 03:03:38< irker239> wesnoth: Charles Dang wesnoth:master 55f14ff22cf0 / src/gui/ (10 files in 4 dirs): GUI2/Menu Button: changed callbacks to NOTIFY_MODIFIED ones https://github.com/wesnoth/wesnoth/commit/55f14ff22cf09c8e28da3c97731913349073fcd1 20180616 03:03:41< irker239> wesnoth: Charles Dang wesnoth:master a5169f7c501e / changelog.md src/gui/widgets/menu_button.cpp src/gui/widgets/menu_button.hpp: GUI2/Menu Button: allow changing selections with the scrollwheel (closes #3251)' https://github.com/wesnoth/wesnoth/commit/a5169f7c501ed6675ba814cd86f4f10bf9059544 20180616 03:03:44< irker239> wesnoth: Charles Dang wesnoth:master 0632f91bd649 / src/gui/dialogs/multiplayer/ (faction_select.hpp mp_join_game.cpp mp_staging.cpp): Faction Select: declared an execute() helper https://github.com/wesnoth/wesnoth/commit/0632f91bd6492b8cc6ce34866e6fe76eecc3d8b4 20180616 03:03:47< irker239> wesnoth: Charles Dang wesnoth:master c2c613325b07 / / (3 files in 2 dirs): Faction Select: fixed changes persisting even if you cancel the dialog https://github.com/wesnoth/wesnoth/commit/c2c613325b075a57728e4bf87659fd2606817630 20180616 03:05:10< irker239> wesnoth: Charles Dang wesnoth:1.14 71100769264e / src/gui/widgets/ (7 files): GUI2: added a bunch of missing virtual specifiers https://github.com/wesnoth/wesnoth/commit/71100769264e7e303a6bf9cd2a852782d437daf6 20180616 03:05:13< irker239> wesnoth: Charles Dang wesnoth:1.14 8a26ab093b01 / src/gui/widgets/ (menu_button.cpp menu_button.hpp multimenu_button.cpp multimenu_button.hpp): GUI2/[Multi]Menu Button: removed retval handling https://github.com/wesnoth/wesnoth/commit/8a26ab093b011db10a6fa3edb38b18682b1c97e8 20180616 03:05:16< irker239> wesnoth: Charles Dang wesnoth:1.14 d5233620e420 / src/gui/ (10 files in 4 dirs): GUI2/Menu Button: changed callbacks to NOTIFY_MODIFIED ones https://github.com/wesnoth/wesnoth/commit/d5233620e4200e1bb1199c4a36ec7fab9ba76ce2 20180616 03:05:19< irker239> wesnoth: Charles Dang wesnoth:1.14 880152e9f089 / changelog.md src/gui/widgets/menu_button.cpp src/gui/widgets/menu_button.hpp: GUI2/Menu Button: allow changing selections with the scrollwheel (closes #3251)' https://github.com/wesnoth/wesnoth/commit/880152e9f0893b1247b5f4fe3acc9f6dc6e7a3d2 20180616 03:05:22< irker239> wesnoth: Charles Dang wesnoth:1.14 8d6d3ec8f361 / src/gui/dialogs/multiplayer/ (faction_select.hpp mp_join_game.cpp mp_staging.cpp): Faction Select: declared an execute() helper https://github.com/wesnoth/wesnoth/commit/8d6d3ec8f361a85432c4d66451761365bee8bc4b 20180616 03:05:25< irker239> wesnoth: Charles Dang wesnoth:1.14 12671fa71576 / / (3 files in 2 dirs): Faction Select: fixed changes persisting even if you cancel the dialog https://github.com/wesnoth/wesnoth/commit/12671fa715768b20bd9c5acaafed952cf2e44327 20180616 03:05:39<+discordbot2> celmin: you were mistaken 20180616 03:05:49<+discordbot2> (re "I think currently they scroll the menu view itself (if it's overflowing and has a scroll bar), so doing this would mean losing that. (But maybe that's okay.)") 20180616 03:06:02<+discordbot2> My change only works when the menu is closed 20180616 03:10:46<+discordbot2> @Pentarctagon my memory on that is pretty fuzzy, but I think it came out of some foley me / @DDR / ActionJack did for frogatto quite a while back in the day that just wasn't gonna work out for frogatto, so we stuck it in Wesnoth, instead. As I recall, I've got complete rights to the sounds so we can re-license it however you were hoping to. 20180616 03:11:21< celticminstrel> WTH are you talking about. 20180616 03:11:37< celticminstrel> The change in that issue only makes sense when the menu is open? 20180616 03:11:51< celticminstrel> Or wait, 20180616 03:11:57< celticminstrel> I may have misunderstood what was meant. 20180616 03:12:09< celticminstrel> Well whatever! 20180616 03:12:15<+discordbot2> I made it so you can hover over the menu button and use the scrollwheel to change the selection without ever opening the menu 20180616 03:13:16< celticminstrel> Right, okay. I thought they meant something a bit different. 20180616 03:13:29<+discordbot2> Do you approve of this behavior? 20180616 03:24:02<+discordbot2> (that last bug at the end is something I can't believe I didn't notice earlier 😐 ) 20180616 03:24:28-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 03:24:29< travis-ci> wesnoth/wesnoth#18587 (master - c2c6133 : Charles Dang): The build was broken. 20180616 03:24:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/392975267 20180616 03:24:29-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 03:24:36<+discordbot2> BROKEN, you say 20180616 03:26:35< irker239> wesnoth: Charles Dang wesnoth:master 3526aa8e86ee / src/gui/dialogs/multiplayer/faction_select.cpp: Fixup unused parameter https://github.com/wesnoth/wesnoth/commit/3526aa8e86ee62b1a5fa9732238f55b563d031a8 20180616 03:45:06-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 03:45:07< travis-ci> wesnoth/wesnoth#18588 (1.14 - 12671fa : Charles Dang): The build was broken. 20180616 03:45:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/392975574 20180616 03:45:07-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 03:58:57-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180616 04:07:33< irker239> wesnoth: Charles Dang wesnoth:master e8bd3c26d2df / src/gui/widgets/ (menu_button.cpp menu_button.hpp): GUI2/Menu Button: store selected index as an unsigned int https://github.com/wesnoth/wesnoth/commit/e8bd3c26d2dfaed83edb5f66b55b3ddaa5004911 20180616 04:07:36< irker239> wesnoth: Charles Dang wesnoth:master f95dc40f132a / src/gui/widgets/ (menu_button.cpp multimenu_button.cpp): Cleaned up two emplace_back calls https://github.com/wesnoth/wesnoth/commit/f95dc40f132afb79432d4a73db88406b5c5e7b9d 20180616 04:07:39< irker239> wesnoth: Charles Dang wesnoth:master 23740ea3cfd6 / src/gui/widgets/ (multimenu_button.cpp multimenu_button.hpp): GUI2/Multimenu Button: store max shown count as an unsigned int https://github.com/wesnoth/wesnoth/commit/23740ea3cfd625a6e4c0ab2575db0d1c6f247ff4 20180616 04:07:42< irker239> wesnoth: Charles Dang wesnoth:master f54b3f722515 / src/gui/widgets/multimenu_button.cpp: GUI2/Multimenu Button: fixed maximum_shown defaulting to 0 instead of 1 https://github.com/wesnoth/wesnoth/commit/f54b3f722515c94a96d8ba1694e65ae4697c1c01 20180616 04:10:06-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180616 04:11:01-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180616 04:20:52< irker239> wesnoth: Charles Dang wesnoth:master ea2ae55159ec / src/gui/widgets/window.cpp: Attempt to fix console spam about images not drawing when running the tests https://github.com/wesnoth/wesnoth/commit/ea2ae55159ec3c6d9b69485810d5fee8af560b37 20180616 04:23:14< irker239> wesnoth: Charles Dang wesnoth:1.14 b0d0dd3cb597 / src/gui/dialogs/multiplayer/faction_select.cpp: Fixup unused parameter https://github.com/wesnoth/wesnoth/commit/b0d0dd3cb5971447f9b415296d6e796038834ebb 20180616 04:23:17< irker239> wesnoth: Charles Dang wesnoth:1.14 16d254f1316a / src/gui/widgets/ (menu_button.cpp menu_button.hpp): GUI2/Menu Button: store selected index as an unsigned int https://github.com/wesnoth/wesnoth/commit/16d254f1316a0de9618c3cc44e6507e114b9ef74 20180616 04:23:20< irker239> wesnoth: Charles Dang wesnoth:1.14 ec0499221a1d / src/gui/widgets/ (menu_button.cpp multimenu_button.cpp): Cleaned up two emplace_back calls https://github.com/wesnoth/wesnoth/commit/ec0499221a1d11842199adbb691a4ad945788410 20180616 04:23:23< irker239> wesnoth: Charles Dang wesnoth:1.14 b17ade9f9c79 / src/gui/widgets/ (multimenu_button.cpp multimenu_button.hpp): GUI2/Multimenu Button: store max shown count as an unsigned int https://github.com/wesnoth/wesnoth/commit/b17ade9f9c795027fb38c23c65ce586e3a7cc0c8 20180616 04:23:26< irker239> wesnoth: Charles Dang wesnoth:1.14 73627767db59 / src/gui/widgets/multimenu_button.cpp: GUI2/Multimenu Button: fixed maximum_shown defaulting to 0 instead of 1 https://github.com/wesnoth/wesnoth/commit/73627767db59342f46c5c6b792aab452c9502696 20180616 04:29:52<+discordbot2> well that didn't work 20180616 04:33:11<+discordbot2> oh well 20180616 04:39:40-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180616 04:40:14<+discordbot2> @jyrkive how would you suggest we handle this? https://github.com/wesnoth/wesnoth/issues/3257 20180616 04:40:47<+discordbot2> the problem is that an event is removed outside an event context, and therefor cleanup hasn't happened when entering the inspector 20180616 04:41:42<+discordbot2> event_handlers::remove_event_handler deliberately doesn't run a cleanup pass of its own 20180616 04:42:16<+discordbot2> perhaps we add a cleanup pass only if no event is running? 20180616 04:43:26< irker239> wesnoth/wesnoth:master Steve Cotton ad7bc19dd9 Prose: the Storm Trident's description u AppVeyor: All builds passed 20180616 04:46:56-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 04:46:57< travis-ci> wesnoth/wesnoth#18591 (master - ea2ae55 : Charles Dang): The build passed. 20180616 04:46:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/392983329 20180616 04:46:57-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 04:57:16< celticminstrel> I don't disapprove of the behaviour, at least. 20180616 05:07:24-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 05:07:25< travis-ci> wesnoth/wesnoth#18592 (1.14 - 7362776 : Charles Dang): The build was fixed. 20180616 05:07:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/392983599 20180616 05:07:25-!- travis-ci [~travis-ci@ec2-54-162-131-251.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 05:41:05<+discordbot2> @Jetrel Alright, thanks. Not looking to relicense anything at the moment, I just don't want to assume the committer is also the author. 20180616 05:44:25-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180616 06:04:21-!- celticminstrel is now known as celmin|sleep 20180616 06:15:40<+discordbot2> @Vultraz How about triggering the clean-up manually when the developer removes the event with the inspector? 20180616 06:16:03<+discordbot2> you can't remove it via the inspector, it was via the lua console 20180616 06:16:36<+discordbot2> and adding a special case for that is pretty much impossible 20180616 06:17:14<+discordbot2> and even if it were it doesn't address the larger issue of no cleanup when removing events from a non-event context 20180616 06:17:26<+discordbot2> which is why i suggested adding manual cleanup in case no event is running 20180616 06:17:30<+discordbot2> Hmm... Maybe we should consider every command in Lua console to be an event context, then (and run the cleanup after every Lua console command). 20180616 06:18:09<+discordbot2> that is another possibility 20180616 06:19:31<+discordbot2> (my proposed cleanup would be in manager::remove_event_handler since it would need is_event_running) 20180616 06:21:58<+discordbot2> (or perhaps event_handler_list_lock::none()) 20180616 06:50:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180616 06:50:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180616 07:35:19< irker239> wesnoth/wesnoth:1.14 josteph 27cad3db5f Fix comment marker syntax, expand commen AppVeyor: All builds passed 20180616 07:51:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180616 08:03:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180616 08:03:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180616 08:20:31< Ivanovic> @Pentarctagon: the "hardening" you added is causing a s**tload of warnings when building with cmake on linux 20180616 08:20:41< Ivanovic> are you sure you did it the right way for cmake? 20180616 08:21:06< Ivanovic> basically for every single src file you receive the following warnings: 20180616 08:21:07< Ivanovic> :0:0: warning: "_FORTIFY_SOURCE" redefined 20180616 08:21:09< Ivanovic> : note: this is the location of the previous definition 20180616 08:22:56<+discordbot2> that doesn't happen to me locally, or for the travis builds 20180616 08:23:17<+discordbot2> Ivanovic: which distribution are you using? 20180616 08:23:26< Ivanovic> gentoo with dev-util/cmake-3.11.4 20180616 08:23:51<+discordbot2> Hmm. Maybe your compiler uses _FORTIFY_SOURCE by default. 20180616 08:25:15< Ivanovic> that might be since gentoo is building the full system from the sources and they might have placed some focus on defining that right from the start... 20180616 08:27:24<+discordbot2> do you have the full command run? 20180616 08:28:00< Ivanovic> for creating the cmake build itself or for a single file being compiled? 20180616 08:28:15<+discordbot2> the file being compiled 20180616 08:29:47< Ivanovic> https://pastebin.com/0N01FKQx 20180616 08:32:34< Ivanovic> and you are right, nothing like this happens on archlinux 20180616 08:33:42<+discordbot2> yeah, looks like it's a gentoo issue: https://github.com/dart-lang/sdk/issues/25529#issuecomment-172985195 20180616 08:34:04<+discordbot2> Oh oops. 20180616 08:34:16<+discordbot2> I completely forgot Ivanovic told me to handle a website translation update. 20180616 08:34:26< Ivanovic> :) 20180616 08:34:51< Ivanovic> @shadowm: I guess that extra day is not changing anything... 20180616 08:35:13< Ivanovic> the mail was already sitting in my inbox for "ages" since I was either drowning in work or spening a day in bed with a cold... 20180616 08:57:47< irker239> wesnoth: Charles Dang wesnoth:1.14 2beab91bd2bd / src/gui/dialogs/ (select_orb_colors.cpp select_orb_colors.hpp): Select Orb Colors: cleaned up dialog implementation https://github.com/wesnoth/wesnoth/commit/2beab91bd2bd13544f022f837cb2034df405dd08 20180616 08:58:16< irker239> wesnoth: Charles Dang wesnoth:master 30121aeb9c31 / src/gui/dialogs/ (select_orb_colors.cpp select_orb_colors.hpp): Select Orb Colors: cleaned up dialog implementation https://github.com/wesnoth/wesnoth/commit/30121aeb9c31420564d0249e99cf777098244d83 20180616 08:58:41<+discordbot2> Ivanovic: I'm confused, the zip file in the email you forwarded to me only contains catalogues for the game. 20180616 08:58:47<+discordbot2> wesnoth-ai, wesnoth-editor, wesnoth-lib, wesnoth-nr, wesnoth-trow, wesnoth-utbs, wesnoth. 20180616 09:05:31< Ivanovic> huh? 20180616 09:06:02< Ivanovic> that was slovak, right? 20180616 09:06:11< Ivanovic> did I save and forward the wrong file?! 20180616 09:06:17< Ivanovic> I need to crosscheck... 20180616 09:07:08<+discordbot2> Slovak, yes. 20180616 09:15:01< Ivanovic> then I probably worked on an ancient mail instead but forwarded you the latest one... 20180616 09:15:07< Ivanovic> thanks for pointing this out! 20180616 09:15:59< irker239> wesnoth: Nils Kneuper wesnoth:1.14 7f18e4d3e64a / po/ (6 files in 6 dirs): updated Slovak translation https://github.com/wesnoth/wesnoth/commit/7f18e4d3e64aa0e09464a41b609ccdf985cacd2e 20180616 09:16:08< irker239> wesnoth: Nils Kneuper wesnoth:master 37ccd8321533 / po/ (7 files in 7 dirs): updated Slovak translation https://github.com/wesnoth/wesnoth/commit/37ccd8321533bfcc5cbd53f19dbfdf0f14d1c8d2 20180616 09:17:25<+discordbot2> Sooo I don't need to do anything then? :p 20180616 09:20:17< Ivanovic> correct 20180616 09:30:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180616 09:30:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180616 09:43:47-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180616 10:06:11-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection] 20180616 10:08:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180616 11:01:37< irker239> wesnoth/wesnoth:master Charles Dang ea2ae55159 Attempt to fix console spam about images AppVeyor: All builds passed 20180616 12:18:00-!- fabi [~fabi@200116b82b399b00b5b68d45ce05a490.dip.versatel-1u1.de] has joined #wesnoth-dev 20180616 12:18:00-!- fabi [~fabi@200116b82b399b00b5b68d45ce05a490.dip.versatel-1u1.de] has quit [Changing host] 20180616 12:18:00-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180616 13:07:27< irker239> wesnoth/wesnoth:1.14 Charles Dang 73627767db GUI2/Multimenu Button: fixed maximum_sho AppVeyor: All builds passed 20180616 13:31:36< irker239> wesnoth: doofus-01 wesnoth:1.14 f7c6bb40e30a / data/campaigns/Under_the_Burning_Suns/ (6 files in 2 dirs): UtBS S04 and S05: some variations in scenery items https://github.com/wesnoth/wesnoth/commit/f7c6bb40e30a013cf9f00abb63683d8fb026743b 20180616 13:31:38< irker239> wesnoth: doofus-01 wesnoth:1.14 bd42298f5b8b / data/campaigns/Under_the_Burning_Suns/maps/05_A_Subterranean_Struggle.map: UtBS S05: replace troll camps with actual troll camps instead of orc castles https://github.com/wesnoth/wesnoth/commit/bd42298f5b8b8c1ec1a53568dfdf5c88a305478b 20180616 13:31:40< irker239> wesnoth: doofus-01 wesnoth:1.14 a908fc9d6fd9 / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/kaleh.png: slight tweak to Kalehs base sprite https://github.com/wesnoth/wesnoth/commit/a908fc9d6fd90c5cdc767fe2237165b05fabc679 20180616 13:31:42< irker239> wesnoth: doofus-01 wesnoth:1.14 e071f5a8da07 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Sun_Sylph.cfg: change sun-sylph halo to be warmer, sunny color, instead of clean, holy color https://github.com/wesnoth/wesnoth/commit/e071f5a8da073baf7753ed9da44236ca65405cbb 20180616 13:31:44< irker239> wesnoth: doofus-01 wesnoth:1.14 729a34997322 / data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg: UtBS S06b: make sure dwarf sergeant is facing the right way in comic-relief dial https://github.com/wesnoth/wesnoth/commit/729a3499732292cd84ea755c03d972676a25fa59 20180616 13:31:46< irker239> wesnoth: doofus-01 wesnoth:1.14 ebef8592d279 / data/campaigns/Under_the_Burning_Suns/maps/ (06b_In_the_Domain_of_the_Dwarves.map 07b_Talking_with_Trolls.map): UtBS S06b and S07b: cosmetic changes to maps, to make them more fitting with dia https://github.com/wesnoth/wesnoth/commit/ebef8592d279527f67bdb97a3b34f8b4b22bcb26 20180616 13:31:48< irker239> wesnoth: doofus-01 wesnoth:1.14 2be0ff94013e / data/campaigns/Under_the_Burning_Suns/ (maps/08_Out_of_the_Frying_Pan.map scenarios/08_Out_of_the_Frying_Pan.cfg): UtBS S08: mostly cosmetic changes to map https://github.com/wesnoth/wesnoth/commit/2be0ff94013e6359799302bf109c06008cd565e4 20180616 13:33:12< irker239> wesnoth: doofus-01 wesnoth:master 4b1a06a82da5 / data/campaigns/Under_the_Burning_Suns/ (6 files in 2 dirs): UtBS S04 and S05: some variations in scenery items https://github.com/wesnoth/wesnoth/commit/4b1a06a82da5883bdbe5408a0667c3c1cff893d0 20180616 13:33:14< irker239> wesnoth: doofus-01 wesnoth:master 5fbd494244fc / data/campaigns/Under_the_Burning_Suns/maps/05_A_Subterranean_Struggle.map: UtBS S05: replace troll camps with actual troll camps instead of orc castles https://github.com/wesnoth/wesnoth/commit/5fbd494244fc01cf4f1df0930f92e5f900d95ed0 20180616 13:33:16< irker239> wesnoth: doofus-01 wesnoth:master f0b963a2b168 / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/kaleh.png: slight tweak to Kalehs base sprite https://github.com/wesnoth/wesnoth/commit/f0b963a2b168637206c2ffb7b0a01edbda8b33ce 20180616 13:33:18< irker239> wesnoth: doofus-01 wesnoth:master a3294cd04d6b / data/campaigns/Under_the_Burning_Suns/units/quenoth/Sun_Sylph.cfg: change sun-sylph halo to be warmer, sunny color, instead of clean, holy color https://github.com/wesnoth/wesnoth/commit/a3294cd04d6be0c4badfea84daf0e65a5cc6cd48 20180616 13:33:20< irker239> wesnoth: doofus-01 wesnoth:master ea3ee2a33632 / data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg: UtBS S06b: make sure dwarf sergeant is facing the right way in comic-relief dial https://github.com/wesnoth/wesnoth/commit/ea3ee2a336320d955f4efa171ff862954f8c37cf 20180616 13:33:22< irker239> wesnoth: doofus-01 wesnoth:master 13ec0493fc81 / data/campaigns/Under_the_Burning_Suns/maps/ (06b_In_the_Domain_of_the_Dwarves.map 07b_Talking_with_Trolls.map): UtBS S06b and S07b: cosmetic changes to maps, to make them more fitting with dia https://github.com/wesnoth/wesnoth/commit/13ec0493fc810b184771b937e3b8e3ef67c3c5dc 20180616 13:33:24< irker239> wesnoth: doofus-01 wesnoth:master 41adc41093a4 / data/campaigns/Under_the_Burning_Suns/ (maps/08_Out_of_the_Frying_Pan.map scenarios/08_Out_of_the_Frying_Pan.cfg): UtBS S08: mostly cosmetic changes to map https://github.com/wesnoth/wesnoth/commit/41adc41093a47de4508e093508cbf83cb45ddcf0 20180616 13:46:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds] 20180616 13:56:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180616 14:37:23-!- celmin|sleep is now known as celticminstrel 20180616 14:47:29-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 248 seconds] 20180616 14:55:02<+discordbot2> I think there is a bug with [resistance] for abilities. I have two versions of an ability called "Raindance", which increases the fire resistance and decreases the cold resistance. Version one is +40% fire -20% cold, version two is +60% and -40% cold. If one unit is affected by both versions, some weirdness is happening. 1. fire resistance exceeds the max_value 2. cold resistance seems to take the lesser value, so -20% instead of 20180616 14:55:03<+discordbot2> -40%. Although actually it should be -60% because it is set cumulative. 20180616 14:57:35<+discordbot2> to 1.: it does not seem to exceed max_value+10 though. 20180616 14:58:48< Ravana_> see 3205 20180616 15:01:39<+discordbot2> I will add my testcases as comments there. 20180616 15:10:20<+discordbot2> cumulative does mean that it stacks, right? so if I had a unit affected by 2 auras, the effect would double? 20180616 15:10:45< celticminstrel> That is the idea, yeah. 20180616 15:10:58< celticminstrel> And I think max value is supposed to limit the stacking. 20180616 15:12:00< celticminstrel> Though... what even is the "value" for a [resistance] ability...? 20180616 15:12:08< celticminstrel> Is there even a value key? 20180616 15:12:52<+discordbot2> If I got it right, value= replaces the base resistance, whereas add= adds, and sub= subtracts. 20180616 15:13:09< celticminstrel> Oh so you can only affect one resistance? 20180616 15:13:37<+discordbot2> no. you can have apply_to=fire, cold, blade 20180616 15:13:58< celticminstrel> Ah, right... but you can't apply a different mod to each, right? 20180616 15:14:02<+discordbot2> At least I think so. I saw it somewhere. 20180616 15:14:51<+discordbot2> Well, I do that by having multiple [resistance] tags. It basically has multiple abilities, but just one is visible. 20180616 15:17:06< irker239> wesnoth/wesnoth:1.14 Nils Kneuper 7f18e4d3e6 updated Slovak translation AppVeyor: All builds passed 20180616 15:33:09<+discordbot2> This is super weird. Just selecting an affecting unit changes the resulting resistance on the affected unit. 20180616 15:33:23<+discordbot2> at negative values, that is. 20180616 15:39:37<+discordbot2> Ah, no. Nevermind that last part. I viewed the wrong unit. Selecting does nothing. 20180616 16:04:46-!- Oebele_ [~quassel@143.177.58.202] has joined #wesnoth-dev 20180616 16:39:58-!- lilinitsy_ [~lilinitsy@75-168-157-120.mpls.qwest.net] has quit [Ping timeout: 264 seconds] 20180616 16:56:37< irker239> wesnoth/wesnoth:master Nils Kneuper 37ccd83215 updated Slovak translation AppVeyor: All builds passed 20180616 17:01:19-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev 20180616 17:05:37-!- Oebele_ [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180616 17:06:43-!- lilinitsy_ [~lilinitsy@75-168-157-120.mpls.qwest.net] has joined #wesnoth-dev 20180616 17:25:23-!- gallaecio [~quassel@188.79.96.255] has quit [Quit: http://quassel-irc.org - Converse confortabelmente. En calquera parte.] 20180616 17:29:03<+discordbot2> @Pentarctagon Any idea why I'd get a "ld.exe: unrecognized option '-z'" error with hardening in scons on windows? 20180616 17:30:12< celticminstrel> Linker version too old maybe? 20180616 17:33:31<+discordbot2> I've got mingw64 5.3.0, I guess that means I need to update? 20180616 17:33:50< celticminstrel> No idea. 20180616 17:34:00< celticminstrel> That was just a guess anyway. 20180616 17:34:06<+discordbot2> ok 20180616 17:34:08< celticminstrel> I don't even know what the -z option is. 20180616 17:34:19< celticminstrel> Or what version of ld introduced it. 20180616 17:34:30< celticminstrel> Or what version of MinGW includes that version of ld. 20180616 17:34:39<+discordbot2> It's also possible that MinGW tools have less features than their upstream versions. 20180616 17:34:48< celticminstrel> Sure, I guess that's possible. 20180616 17:35:24-!- DeFender1031 [~DeFender1@89-138-13-24.bb.netvision.net.il] has joined #wesnoth-dev 20180616 17:43:51< Ravana_> what these do? https://github.com/wesnoth/wesnoth/blob/1.14/src/units/attack_type.cpp#L54-L55 20180616 17:46:47< Ravana_> it is from https://github.com/wesnoth/wesnoth/commit/549a29a4fe3f8f3d44224a0b644479b9501059bb, does it actually work? 20180616 17:57:54< celticminstrel> I don't think so. In fact I thought that was removed? 20180616 17:58:11< celticminstrel> Because it didn't work. 20180616 17:58:11< Ravana_> min_range at least works 20180616 17:58:15< celticminstrel> Huh? 20180616 17:58:23< Ravana_> as in it disables attack when target is too close 20180616 17:58:24< celticminstrel> How so? 20180616 17:58:32< celticminstrel> But um... 20180616 17:58:49< celticminstrel> You can't attack a non-adjacent unit anyway, so isn't that just the same as [disable] then? 20180616 17:59:00< Ravana_> seems so yes 20180616 17:59:11< celticminstrel> Unless it's like... 20180616 17:59:20< celticminstrel> You can attack only if you move closer at the same time? 20180616 17:59:23-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit [] 20180616 17:59:27< celticminstrel> Though I bet that wouldn't work. 20180616 17:59:33< Ravana_> doesn't yes 20180616 18:07:29< Ravana_> tried to use it with do_command and got stuck into lua console https://vgy.me/SjeytN.png 20180616 18:08:25<+discordbot2> @sigurdfd it's a hardening option, which it looks like is only supported on linux. 20180616 18:10:35< Ravana_> game thinks it is not open, so I can scroll on map https://vgy.me/lzjKvG.png 20180616 18:14:23< Ravana_> didn't manage to exit it, killing wesnoth 20180616 18:15:20< Ravana_> when using close and pressing no, then it crashed 20180616 18:15:39< Ravana_> still, trying again, but from :lua instead of console then 20180616 18:18:43< Ravana_> nice, it works 20180616 18:19:01< Ravana_> so custom-built wesnoth clients can make use of this feature 20180616 18:19:13< celticminstrel> I guess some things (eg do_command) need to take into account the possibility of being run from the Lua console... 20180616 18:19:16< celticminstrel> What works, exactly? 20180616 18:19:47< Ravana_> attacking from distance https://vgy.me/5KO5sF.jpg 20180616 18:21:51< Ravana_> seems it is actually always allowed 20180616 18:21:57< Ravana_> not related to max_range 20180616 18:24:07< Ravana_> that means either https://wiki.wesnoth.org/index.php?title=DirectActionsWML&type=revision&diff=59751&oldid=59712 is incorrect, or people are actually allowed to start attacks from distance 20180616 18:25:06< celticminstrel> BTW if you want to perform attacks from the console it might be easier to use FormulaAI (press F). 20180616 18:25:29< celticminstrel> So wait, it somehow actually does work? o.O 20180616 18:26:13< Ravana_> I would need to extend my bot with that logic to check if that attacks can be used in mp-safe way by normal player 20180616 18:26:32< Ravana_> do_command allows attacking from distance 20180616 18:27:09< irker239> wesnoth: Pentarctagon wesnoth:1.14 ca008291993c / CMakeLists.txt SConstruct: Fixup hardening options for Windows. https://github.com/wesnoth/wesnoth/commit/ca008291993c86ae95b215b308ec84f4f5de4e20 20180616 18:27:22< Ravana_> I don't know how to do anything from F console 20180616 18:31:12< irker239> wesnoth: Pentarctagon wesnoth:master 277158222200 / CMakeLists.txt SConstruct: Fixup hardening options for Windows. https://github.com/wesnoth/wesnoth/commit/277158222200d4131bbbb385e45a8c6993020b44 20180616 18:32:25< celticminstrel> I think it's like attack(x, y, weapon1, weapon2) 20180616 18:32:29< celticminstrel> But not quite sure. 20180616 18:32:35< celticminstrel> Where weapon1 and weapon2 are indices. 20180616 18:32:53< celticminstrel> Oh wait, it's probably attack(src_x, src_y, dest_x, dest_x, weapon1, weapon2)... 20180616 18:33:07< celticminstrel> It's documented somewhere on the wiki though. 20180616 18:34:42< Ravana_> going to try it on mp server, adding command to send raw wml string to server currently 20180616 18:53:48-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180616 19:06:32< Ravana_> heh, it works 20180616 19:07:44< Ravana_> also allows attacking multiple times per turn 20180616 19:08:04< Ravana_> observe my game to see 20180616 19:08:58-!- gfgtdf [~chatzilla@x4e363874.dyn.telefonica.de] has joined #wesnoth-dev 20180616 19:10:35< gfgtdf> you can also move enemy units that still have mp left iirc. 20180616 19:11:12< gfgtdf> why woudl yu need to send raw wml string to server? can't do_command already do anything ? 20180616 19:11:25< Ravana_> I wanted to see if normal players can do this too 20180616 19:11:41< Ravana_> without synced code execution access 20180616 19:12:25< gfgtdf> normal users can use do_command? i don't unbderstand whyt you mean 20180616 19:13:54< Ravana_> I would expect this result in oos 20180616 19:15:34< gfgtdf> no do_command is synced is can be used form an unsynced coneyxt liek the lua console and will then be sended to the server. (at least that's hwo it is supposed to work, didnt test it recently) 20180616 19:16:13< Ravana_> it is not do_command anymore - I can do it with normal mp commands - [turn][command][attack] 20180616 19:16:49< gfgtdf> well yes that's the same, do_command generates a [turn][command] (unless it was used from a synced context) 20180616 19:22:06< gfgtdf> ye from looking ath the code it seems liek disable (whihc is also used for the range check) is onyl used in the choose_.._weapon functions 20180616 19:22:30< Ravana_> it is curious that these moves are accepted, but only really relevant for do_command documentation 20180616 19:23:24< gfgtdf> i think we should just disallow them. 20180616 19:24:14-!- nemaara [442bb2e7@gateway/web/freenode/ip.68.43.178.231] has joined #wesnoth-dev 20180616 19:24:26-!- Choicerer [~bodhidhar@185.9.19.107] has joined #wesnoth-dev 20180616 19:29:41-!- nemaara [442bb2e7@gateway/web/freenode/ip.68.43.178.231] has left #wesnoth-dev [] 20180616 19:43:12< irker239> wesnoth/wesnoth:1.14 josteph 179b297fa7 Preferences: Improve label and tooltip o AppVeyor: All builds passed 20180616 19:46:11< irker239> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 881bce4d1a20 / src/actions/attack.cpp: disallow attacking with disabled attacks via [do_command] https://github.com/wesnoth/wesnoth/commit/881bce4d1a20d26e92ad9451764a25be8f4c76cf 20180616 19:46:22< gfgtdf> made a pr for 1.14 20180616 19:46:53< gfgtdf> oh just at the same time when you filed the issue. 20180616 20:16:56< Ravana_> I remember https://github.com/wesnoth/wesnoth/blob/e270a7c6656cbebdfe16b782a93acb23a2e0b94e/src/formula/callable_objects.cpp#L694 was supposed to give access to wml variables. How it works? Trying with max_value="$(if(contains_string(wml_vars.era_id,'RPG'),50,99))" 20180616 20:17:59< gfgtdf> this look like its about side variables not global variables. 20180616 20:18:21< gfgtdf> side variabels are variabels stored in [side] similar to [variabels] in [unit] 20180616 20:20:10< Ravana_> I guess I need to do the check in filters then 20180616 20:20:38< celticminstrel> What was the PR that I was supposed to review? 20180616 20:20:42< celticminstrel> Anyone remember? 20180616 20:20:55< celticminstrel> I commented on it saying I'd look at it but now I don't remember which one it was. 20180616 20:21:15< celticminstrel> Unless it was 3241 but I'm pretty sure it was one from someone who's more coherent than that. 20180616 20:21:41< celticminstrel> Oh wait maybe it was 323. 20180616 20:21:44< celticminstrel> 3232 that is 20180616 20:21:56< celticminstrel> Yeah that was it. 20180616 20:24:07< celticminstrel> Oh nice, GitHub now exposes the "ignore whitespace" option in the UI. 20180616 20:25:33< gfgtdf> indeed 20180616 20:27:00< Ravana_> doing the check in lua_function instead would give access to case insensitive matching too, so more useful even 20180616 20:27:19< celticminstrel> Hm? 20180616 20:27:42< Ravana_> formula doesn't support case conversion functions 20180616 20:27:45< celticminstrel> Oh yeah, that's side variables only. 20180616 20:27:51< celticminstrel> Oh, huh. 20180616 20:28:03< celticminstrel> That's a good thing to add then. 20180616 20:28:20< Ravana_> both of them I hope 20180616 20:29:00< celticminstrel> No, we probably won't be adding access to global WML variables in filter formulas. 20180616 20:29:18< celticminstrel> You can just use the variable substitution syntax to hard-code them into the formula though. 20180616 20:29:36< celticminstrel> Or store them as unit/side variables instead, which are accessible. 20180616 20:30:05< Ravana_> I wanted to access variable in [resistance] max_value 20180616 20:30:17< celticminstrel> It is possible to have a formula accessing global WML variables, but currently there are none that can (unless you pass wml.all_vars to a formula from Lua). 20180616 20:30:24< celticminstrel> Huh? 20180616 20:30:39< Ravana_> max value is normally 99, but in rpg it is 50 20180616 20:30:42< celticminstrel> Okay first of all, is this a unit or side filter. 20180616 20:30:58< Ravana_> not filter, value 20180616 20:31:12< celticminstrel> ...oh wait, it's an ability formula. 20180616 20:31:23< gfgtdf> is there any reason against adding acces to global wml vars ? 20180616 20:31:25< celticminstrel> Uhh what's self there... 20180616 20:31:37< Ravana_> like in [attacks] I have multiply="(1 + ((((1.099999 * max_hitpoints) + 0.0) - hitpoints) / max_hitpoints))" 20180616 20:31:42< celticminstrel> gfgtdf: Mainly that it doesn't make sense for the "unit" or "team" object to contain the global variables. 20180616 20:31:59< celticminstrel> gfgtdf: What's "self" in these formulas, is it the unit object or ...? 20180616 20:32:08< celticminstrel> Wait if max_hitpoints works, it must be the unit, right? 20180616 20:32:12< celticminstrel> Okay so... 20180616 20:32:25< gfgtdf> celticminstrel: forumla has 'global' objects right? I think its the unit. 20180616 20:32:26< celticminstrel> From that link you linked, you're working with a unit_callable. 20180616 20:32:35< celticminstrel> gfgtdf: Yeah that's what I was asking. 20180616 20:33:02< celticminstrel> So let's see, there's "abilities"... 20180616 20:33:16< celticminstrel> But I have a feeling that get_ability_list() returns just the names...? 20180616 20:33:36< gfgtdf> celticminstrel: why woudl you want to get abilitites ? 20180616 20:33:42< celticminstrel> Ask Ravana? 20180616 20:33:45< Ravana_> it does 20180616 20:33:51< Ravana_> I tried to use it in 1.10 20180616 20:34:32-!- Oebele_ [~quassel@143.177.58.202] has joined #wesnoth-dev 20180616 20:35:17< celticminstrel> So what exactly were you trying to do again? 20180616 20:35:37< Ravana_> return 50 if $era_id contains 'RPG', otherwise return 99 20180616 20:36:21< celticminstrel> What's wrong with "$(if(contains_string('$era_id','RPG'),50,99))"? 20180616 20:36:24< gfgtdf> i think your best best option is what celmin said erailer to copy the varibl to each side and use side variables. (assumming you can get the side of a unit inf ormula) 20180616 20:36:39< gfgtdf> celticminstrel: this is in abilitites, subsutution does not work. 20180616 20:36:41< celticminstrel> Should work as long as the variable can never contain single quotes or square brackets. 20180616 20:36:45< celticminstrel> Oh. 20180616 20:36:53< celticminstrel> I see, I see. 20180616 20:37:09< celticminstrel> Yeah, probably the best bet is to copy it to the unit/side abilities, sadly... 20180616 20:37:17< celticminstrel> Then what you originally wrote would work. 20180616 20:37:24< celticminstrel> Uhh, variables, not abilities. 20180616 20:37:35< celticminstrel> That's not a nice solution though... 20180616 20:37:51< celticminstrel> I guess in this case it would be the unit variables. 20180616 20:38:10< celticminstrel> Oh yeah, can you get a unit's team in formulas? 20180616 20:38:56< gfgtdf> i don't know, i mena you can get its side number, it would sureley be useful though. 20180616 20:39:08< celticminstrel> The answer appears to be no. (If you could it would be defined here. https://github.com/wesnoth/wesnoth/blob/e270a7c6656cbebdfe16b782a93acb23a2e0b94e/src/formula/function_gamestate.cpp ) 20180616 20:39:31< celticminstrel> Yeah, you can get its side number, but that can't lead to the team object unless you're in FormulaAI. 20180616 20:39:44< celticminstrel> Actually IIRC the side number isn't correct, either. 20180616 20:41:06< gfgtdf> ye i remember that discussion 20180616 20:41:32< gfgtdf> for 1.15 i think it'S be best to change side to return the team_callable instead of the numebr of side does alread not return the correct number. 20180616 20:41:58< celticminstrel> I think that might be too compatibility-breaking. 20180616 20:42:01< Ravana_> celticminstrel: that if(contains_string('$era_id','RPG'),50,99) always gives 99 https://vgy.me/ut1Mt8.png 20180616 20:42:07< Ravana_> and without '' it is syntax error 20180616 20:42:24< celticminstrel> Ravana_: It would work if it was in a place where variable substitution is allowed though. :/ 20180616 20:42:39< celticminstrel> BTW shouldn't you also be omitting the leading $ in that formula substitution? 20180616 20:42:52< celticminstrel> Because that also only works where variable substitution is allowed. 20180616 20:43:11< Ravana_> yes, for f I do so 20180616 20:43:12< gfgtdf> Ravana_: you prorbably have to use two differnt abilitites with distince lua filters. 20180616 20:44:14< Ravana_> I did so yes 20180616 20:45:37< Ravana_> there using wesnoth.game_config.era.id directly instead of over wml variable 20180616 20:46:49< celticminstrel> Can someone with addons server access please grep all *.fai and *.wfl files for the pattern "teams|allies|enemies" 20180616 20:47:29< celticminstrel> I suppose including *.cfg files might be necessary to not miss anything, but hopefully those would only be used in more complicated things that would end up in their own file... 20180616 20:48:21< celticminstrel> I'm a little surprised, but there don't seem to be any occurrences in core? 20180616 20:49:50< celticminstrel> BTW Ravana_, WFL does have case conversion functions - str_upper() and str_lower(). 20180616 20:50:16< Ravana_> not on https://wiki.wesnoth.org/Wesnoth_Formula_Language though 20180616 20:50:35< celticminstrel> I see. 20180616 20:53:15-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 20:53:16< travis-ci> wesnoth/wesnoth#18604 (gfgtdf-patch-1 - 881bce4 : gfgtdf): The build was broken. 20180616 20:53:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/393144633 20180616 20:53:16-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 21:01:43< irker239> wesnoth: Celtic Minstrel wesnoth:wfl_updates d6c9b67e892d / src/ (ai/formula/ai.cpp formula/callable_objects.cpp): Fix WFL unit.side returning one less than the actual side https://github.com/wesnoth/wesnoth/commit/d6c9b67e892daf00667de82c0642ed1a62846e05 20180616 21:01:45< irker239> wesnoth: Celtic Minstrel wesnoth:wfl_updates a10d214f5eeb / src/formula/function_gamestate.cpp: Add get_team() function to get a team_callable from gamestate formulas https://github.com/wesnoth/wesnoth/commit/a10d214f5eeb8662d517439735be5c5a1a853364 20180616 21:01:53< celticminstrel> gfgtdf: How's that function look? (untested) 20180616 21:07:34-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180616 21:28:43<+discordbot2> what is data/test/test/ used for? 20180616 21:30:36<+discordbot2> If my memory serves I added a funny named hierarchy that's used by the filesystem API tests. 20180616 21:31:01<+discordbot2> Or by something related to the preprocessor. It was like 3 years ago. 20180616 21:31:17<+discordbot2> a grep finds it only in src/tests/test_sdl_utils.cpp, which is entirely commented out 20180616 21:31:48<+discordbot2> I'll check when I get on my desktop. 20180616 21:32:21<+discordbot2> thanks 20180616 21:32:47<+discordbot2> there's 49 images that can be removed if it's not used anymore. 20180616 21:33:06< irker239> wesnoth: Celtic Minstrel wesnoth:wfl_updates 87f98d0c2903 / src/formula/function_gamestate.cpp: Add get_team() function to get a team_callable from gamestate formulas https://github.com/wesnoth/wesnoth/commit/87f98d0c29038a34dce25bb1d2df0f73e4869ce1 20180616 21:33:39< celticminstrel> For some reason, with that commit, starting the tutorial and executing get_team('player') from the WFL console causes the game to crash. o.O 20180616 21:33:48< celticminstrel> Seemingly because it's trying to access an invalid side somehow? 20180616 21:34:15< celticminstrel> Like, stepping through in the debugger, it looks like the side's data is corrupted or something. 20180616 21:47:01< gfgtdf> celticminstrel: looks good to me. didn't to a real analysis though. 20180616 21:48:29< gfgtdf> celticminstrel: it has no range check for th integer parmaeter though. 20180616 21:49:02< gfgtdf> celticminstrel: it might not be needed but i don't know how formula handles c++ exxpcetion. 20180616 21:49:51< gfgtdf> celticminstrel: actuall i think a range check migth bebetter wasn't the fomula way to never use exception and just return nil (or the formula equivelent of that)? 20180616 21:51:31< gfgtdf> by the say did we fix the 'if' evaluation issue, that is formula always evaluates both paths even though it doesnt need to? 20180616 21:57:29< celticminstrel> Formulas do catch exceptions and return null, but that's only one type of exception. 20180616 21:57:59< celticminstrel> TBH I don't think it matters that "if" evaluates both paths, but it should be an easy fix if it does and we really want to change that. 20180616 21:58:38-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 255 seconds] 20180616 22:02:04< irker239> wesnoth: Celtic Minstrel wesnoth:wfl_updates ad43efbf66f5 / src/formula/ (function_gamestate.cpp variant.cpp): Add get_team() function to get a team_callable from gamestate formulas https://github.com/wesnoth/wesnoth/commit/ad43efbf66f53f43801eddace797c35f46d3a912 20180616 22:02:48< celticminstrel> gfgtdf: From the code, it doesn't look like it does evaluate both. 20180616 22:03:20< celticminstrel> Best way to test is to use the formula console to evaluate something like if(1, debug_print('yes'), debug_print('no')) 20180616 22:03:23-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 22:03:24< travis-ci> wesnoth/wesnoth#18606 (wfl_updates - a10d214 : Celtic Minstrel): The build has errored. 20180616 22:03:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/393159936 20180616 22:03:24-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 22:06:34< gfgtdf> hmm ok then i either remember something wrongly or someone told me something wrong. 20180616 22:07:55< celticminstrel> @Vultraz https://github.com/jostephd/wesnoth/commit/cc90a4a34153bd5b83a5e8c17d1cce355e3913bd 20180616 22:08:29< celticminstrel> gfgtdf: The thing is, it doesn't really matter because formulas don't have side-effects (except for the debugging functions). 20180616 22:08:37<+discordbot2> What? 20180616 22:08:44< celticminstrel> It's possible though that you're thinking of and and or, which do evaluate both arguments even when not needed. 20180616 22:09:04< celticminstrel> @Vultraz - What's the proper way to do that when there's nothing to do in the callback? 20180616 22:09:14< celticminstrel> Please comment on the PR or something. 20180616 22:09:23< celticminstrel> https://github.com/wesnoth/wesnoth/pull/3258 20180616 22:09:36< celticminstrel> ... 20180616 22:09:40< celticminstrel> Wait never mind. 20180616 22:09:51<+discordbot2> That’s not the current code 20180616 22:09:55< celticminstrel> Why is GitHub showing me the outdated diff!? 20180616 22:09:57<+discordbot2> I already addressed it 20180616 22:10:15< celticminstrel> Yeah I see that now that I'm actually looking at the PR directly. 20180616 22:10:27< celticminstrel> Oh wait, this was just a case of me clicking the wrong link. 20180616 22:10:29 * celticminstrel facepalm. 20180616 22:11:18< celticminstrel> So anyway can we merge it. 20180616 22:11:55< celticminstrel> I don't see why you prefer "factor" over the more descriptive "acceleration factor"? 20180616 22:13:58-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 22:13:59< travis-ci> wesnoth/wesnoth#18607 (wfl_updates - 87f98d0 : Celtic Minstrel): The build has errored. 20180616 22:13:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/393167190 20180616 22:13:59-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 22:27:51< irker239> wesnoth/wesnoth:1.14 doofus-01 2be0ff9401 UtBS S08: mostly cosmetic changes to map AppVeyor: All builds passed 20180616 22:33:02-!- Oebele_ [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180616 22:34:05-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20180616 22:34:06< travis-ci> wesnoth/wesnoth#18608 (wfl_updates - ad43efb : Celtic Minstrel): The build failed. 20180616 22:34:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/393172960 20180616 22:34:06-!- travis-ci [~travis-ci@ec2-54-161-241-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180616 22:34:18<+discordbot2> Shorter 20180616 22:34:29<+discordbot2> Less redundant 20180616 22:35:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20180616 22:38:14< celticminstrel> I don't thin it's as redundant as you think? 20180616 22:38:32< celticminstrel> Yeah sure the word "acceleration" appears twice, but without that, is it really immediately obvious that the settings are related? 20180616 22:38:35< celticminstrel> ^think 20180616 22:38:45< celticminstrel> Repetition isn't automatically bad. 20180616 22:38:51<+discordbot2> what wud yu say 20180616 22:39:04< celticminstrel> I think it's fine as it is. 20180616 22:39:14<+discordbot2> Acceleration Factor? 20180616 22:39:18< celticminstrel> Yeah. 20180616 22:53:30-!- fabi [~fabi@i577BCD83.versanet.de] has joined #wesnoth-dev 20180616 22:53:30-!- fabi [~fabi@i577BCD83.versanet.de] has quit [Changing host] 20180616 22:53:30-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180616 22:58:57-!- Choicerer [~bodhidhar@185.9.19.107] has quit [Ping timeout: 240 seconds] 20180616 23:15:56-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180616 23:17:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180616 23:21:20< irker239> wesnoth/wesnoth:gfgtdf-patch-1 gfgtdf 881bce4d1a disallow attacking with disabled attacks AppVeyor: vs2015/Release Failed 20180616 23:21:21< irker239> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-gfgtdf-patch-1-3884 20180616 23:41:10< irker239> wesnoth: josteph wesnoth:1.14 ddd232655023 / src/gui/dialogs/preferences_dialog.cpp: Preferences: Keep the acceleration speed slider enabled even when the checkbox i https://github.com/wesnoth/wesnoth/commit/ddd23265502398c65d924b4ecc596ec0594124d7 20180616 23:41:12< irker239> wesnoth: josteph wesnoth:1.14 b3667da40614 / data/gui/window/preferences/01_general.cfg: Preferences: Improve label and tooltip of 'Accelerated speed' slider. https://github.com/wesnoth/wesnoth/commit/b3667da406141d654ad4d44f3502030ff0e17012 20180616 23:41:14< irker239> wesnoth: Wedge009 wesnoth:1.14 203dd5757163 / data/gui/window/preferences/01_general.cfg src/gui/dialogs/preferences_dialog.cpp: Merge pull request #3258 from jostephd/turbo_slider https://github.com/wesnoth/wesnoth/commit/203dd5757163232c7abb2fee6672d72fd3ce9439 20180616 23:43:11< irker239> wesnoth: josteph wesnoth:master e126e5ba3672 / src/gui/dialogs/preferences_dialog.cpp: Preferences: Keep the acceleration speed slider enabled even when the checkbox i https://github.com/wesnoth/wesnoth/commit/e126e5ba3672fe87e7045bce8580ac26b1f536aa 20180616 23:43:13< irker239> wesnoth: josteph wesnoth:master d95efd3409f7 / data/gui/window/preferences/01_general.cfg: Preferences: Improve label and tooltip of 'Accelerated speed' slider. https://github.com/wesnoth/wesnoth/commit/d95efd3409f75614c48732dc3532e6fd2f166dd4 20180616 23:55:55-!- gfgtdf [~chatzilla@x4e363874.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.8.1/20180605153619]] --- Log closed Sun Jun 17 00:00:00 2018