--- Log opened Fri Jun 29 00:00:51 2018 20180629 00:39:28-!- sevu [~Shiki@p54854B6F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180629 00:59:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 00:59:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 01:17:00-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180629 01:18:21< irker229> wesnoth/wesnoth:master newfrenchy83 468abb9f61 Update attack.cpp AppVeyor: 2/4 builds failed 20180629 01:18:22< irker229> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3760 20180629 01:18:23< irker229> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4046 20180629 01:21:42-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180629 02:04:08-!- Appleman1234 [~quassel@121.222.147.211] has joined #wesnoth-dev 20180629 02:57:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 02:57:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 03:26:49< irker229> wesnoth/wesnoth:1.14 Gunter Labes b511707c82 Fix line endings AppVeyor: All builds passed 20180629 03:32:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 03:32:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 03:39:06-!- shiki [~Shiki@p54854BC3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180629 03:39:06-!- sevu [~Shiki@p54854B6F.dip0.t-ipconnect.de] has quit [Disconnected by services] 20180629 03:42:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 248 seconds] 20180629 03:55:36< irker229> wesnoth: Charles Dang wesnoth:master 399851d03533 / src/ (scripting/game_lua_kernel.cpp units/types.cpp): Sneaky C-style arrays be hiding https://github.com/wesnoth/wesnoth/commit/399851d0353335d14fce36fa1098f288665ecf10 20180629 04:11:35< irker229> wesnoth: Charles Dang wesnoth:master 226a7f7d0215 / / (5 files in 4 dirs): Removed preference to disable halos https://github.com/wesnoth/wesnoth/commit/226a7f7d02154fe734dbb5395535ca2ef99a83b5 20180629 04:16:44-!- gfgtdf_ [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180629 04:20:27-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 260 seconds] 20180629 05:02:10< irker229> wesnoth/wesnoth:master Gunter Labes 51b5549bd2 Fix line endings AppVeyor: All builds passed 20180629 05:39:59-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180629 06:14:11-!- lilinitsy_ [~demonitsy@75-168-31-203.mpls.qwest.net] has joined #wesnoth-dev 20180629 06:23:25<+discordbot3> accidental click, gotta love that 1am work. Wish they'd have a confirmation for that. 20180629 06:24:13<+discordbot3> no prob 20180629 06:25:08<+discordbot3> I think it would be annoying to ask for confirmation for something you can easily undo. 20180629 06:26:28<+discordbot3> Maybe, but it'd minimize the number of times I look like an idiot and accidentally close. 20180629 06:44:33-!- lilinitsy_ [~demonitsy@75-168-31-203.mpls.qwest.net] has quit [Remote host closed the connection] 20180629 07:09:50< irker229> wesnoth: Charles Dang wesnoth:1.14 bca9266c4a4f / data/gui/window/preferences/02_hotkeys.cfg: Preferences Dialog: drop characters_per_line from hotkey list https://github.com/wesnoth/wesnoth/commit/bca9266c4a4f55713148d0524c40f3952f11a229 20180629 07:10:18< irker229> wesnoth: Charles Dang wesnoth:master cb7a67914215 / data/gui/window/preferences/02_hotkeys.cfg: Preferences Dialog: drop characters_per_line from hotkey list https://github.com/wesnoth/wesnoth/commit/cb7a6791421511f4251f2d1cb31a894fa8de90cf 20180629 07:21:42< irker229> wesnoth: Charles Dang wesnoth:1.14 a4543b519be4 / data/gui/window/preferences/01_general.cfg: Preferences: shifted the Skip AI Moves button around https://github.com/wesnoth/wesnoth/commit/a4543b519be40b7fdb0444b41ca04d1aa17ad9ff 20180629 07:21:45< irker229> wesnoth: Charles Dang wesnoth:1.14 1fa01b3a1e09 / data/gui/window/preferences/01_general.cfg: Preferences: added a mention of the in-game accelerated speed toggle https://github.com/wesnoth/wesnoth/commit/1fa01b3a1e09295d75709e84dd5c04a5d41771ac 20180629 07:22:08< irker229> wesnoth: Charles Dang wesnoth:master 10e663ed6ce4 / data/gui/window/preferences/01_general.cfg: Preferences: shifted the Skip AI Moves button around https://github.com/wesnoth/wesnoth/commit/10e663ed6ce49974e22d4dab5211716210ead6e9 20180629 07:22:11< irker229> wesnoth: Charles Dang wesnoth:master 98ddc311fc1c / data/gui/window/preferences/01_general.cfg: Preferences: added a mention of the in-game accelerated speed toggle https://github.com/wesnoth/wesnoth/commit/98ddc311fc1cfec3c95c2c24cc1e3e48603643a8 20180629 07:24:02-!- Appleman1234 [~quassel@121.222.147.211] has quit [Ping timeout: 260 seconds] 20180629 07:26:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180629 07:35:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180629 07:37:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180629 07:50:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180629 08:17:41< irker229> wesnoth/wesnoth:1.14 gfgtdf 9ae71cd8e2 fix code dublication of mp_join_game::sh AppVeyor: All builds passed 20180629 10:20:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 10:21:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 10:42:55-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving] 20180629 10:51:56< irker229> wesnoth/wesnoth:master Charles Dang 226a7f7d02 Removed preference to disable halos AppVeyor: All builds passed 20180629 10:53:12< gfgtdf_> vultraz: now the hotkey dialog has an ugly horizonal scrollbar in the german translation. 20180629 10:54:10-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev 20180629 10:54:12<+discordbot3> oh fucking hell 20180629 10:54:15<+discordbot3> 😐 20180629 10:54:21< gfgtdf_> also the width of the title row are no longr in sync with the rest somehow 20180629 10:54:31<+discordbot3> what? 20180629 10:55:19< gfgtdf_> the scrollbar is only the content of that listbox so meaning the 'content' is iwder than the titlerow 20180629 10:57:18<+discordbot3> why, why, why, why can't the goddamn layout engine handle simple line wrapping 20180629 10:57:54< gfgtdf_> https://imgur.com/a/y86qcn2 20180629 10:59:19< gfgtdf_> is there alraey a date for the 1.14.4 release ? 20180629 10:59:32<+discordbot3> no 20180629 11:00:19<+discordbot3> I've been putting off doing the one thing I need to get done before the release (lobby filtering options), so... 20180629 11:00:25<+discordbot3> What seems to be the problem in that screenshot besides the green-tinted text? 20180629 11:01:12<+discordbot3> Oh okay, I'm guessing there's an overlong string somewhere in the first column. 20180629 11:01:20<+discordbot3> due to translations 20180629 11:01:32<+discordbot3> without characters_per_line it won't wrap 20180629 11:01:47<+discordbot3> because the accursed layout engine loves scrollbars 20180629 11:02:02<+discordbot3> Of course it does. 20180629 11:02:08<+discordbot3> Or rather the layout code is greedy. 20180629 11:02:11< gfgtdf_> shadown: yes and in particular the first row is nonger in snc with the test of the list 20180629 11:02:18<+discordbot3> Who the hell is shadown. 20180629 11:02:32< gfgtdf_> m 20180629 11:02:35<+discordbot3> It assumes that when you put stuff into a scrollbar container, you actually want the scrollbars to be used. 20180629 11:02:56<+discordbot3> The layout engine isn't magic and can't telepathically determine your intentions. 20180629 11:03:02<+discordbot3> How did the column headers decide to lay themselves out differently to the contents? Aren't they using linked groups? 20180629 11:03:09<+discordbot3> they are 20180629 11:04:44<+discordbot3> im not sure what he's talking about, really 20180629 11:04:49<+discordbot3> the list is just scrolled right 20180629 11:05:19<+discordbot3> The headers don't scroll with the list? (I'm getting a feeling of déjà vu from this question.) 20180629 11:05:38<+discordbot3> no 20180629 11:06:02<+discordbot3> I decided we would never have a horizontally-scrolling list with a header 20180629 11:06:25<+discordbot3> Are you sure I didn't look into that particular issue once and essentially ragequit the project once I realized that the GUI2 event handling code is not from this world? 20180629 11:06:35<+discordbot3> you did 20180629 11:06:42<+discordbot3> but it's not the event handling code that's to blame 20180629 11:06:48<+discordbot3> Oh right. 20180629 11:06:52<+discordbot3> The whatever you call it. 20180629 11:07:02<+discordbot3> The container parent class or sth. 20180629 11:07:12<+discordbot3> About the scrolling bars in preferences, it was already happening in some languages (e.g. Spanish, French) 20180629 11:07:17<+discordbot3> Which involved like three layers of metaprogramming. 20180629 11:07:21<+discordbot3> I mean before this change 20180629 11:07:28<+discordbot3> ah, yes 20180629 11:07:30<+discordbot3> the generator class 20180629 11:07:52<+discordbot3> Yeah I've made Vultraz aware of the horizontal scrollbars syndrome several times. 20180629 11:07:52<+discordbot3> I remember tweeting you at one point informing you I had figured it out 20180629 11:08:01<+discordbot3> the class structure 20180629 11:08:05<+discordbot3> In particular since Spanish has a few bad cases of it. 20180629 11:08:14<+discordbot3> Ok 20180629 11:08:51<+discordbot3> @jyrkive if so, then if the dialog has no scrollbars, it should try to wrap something. That does not happen. If it can't scroll the listbox, it falls back to the window. Remove those, and it crashes the game. 20180629 11:08:56<+discordbot3> (I was QAing the Spanish translation since the translators tend to need a little nudge from time to time to realize that there's simple solutions to some of their problems and/or don't test their translations.) 20180629 11:10:00<+discordbot3> Same with the popup window with info about the release and paths 20180629 11:10:27<+discordbot3> @shadowm this was the bug https://github.com/wesnoth/wesnoth/issues/1499 20180629 11:10:55<+discordbot3> Probably. 20180629 11:10:59<+discordbot3> This commit affects the behavior of the listbox headers: https://github.com/wesnoth/wesnoth/commit/12661c6e8a36aba6bf7dc5a5191fff571499db78 20180629 11:11:11<+discordbot3> "This isn't a perfect solution, since as gfgtdf mentioned, this renders horizontal scrollbars on listboxes with header useless (hopefully a rare occurrence - I can't think of any mainline cases, even) but it will do for now." 20180629 11:11:18<+discordbot3> Not pictured: me pulling my hair out after trying to wrap my head around the templates of template classes. 20180629 11:11:39<+discordbot3> *templates of template classes that are subclasses of multiple template classes 20180629 11:11:51<+discordbot3> yeah.... the generator class is still a mess 20180629 11:12:01<+discordbot3> well, maybe not a mess, but still largely untouched 20180629 11:12:23<+discordbot3> GUI2 is overengineered. The generator template class is a good example. 20180629 11:12:27<+discordbot3> I've simplified the event handling code greatly since then, if that's any consolation 😛 20180629 11:12:46<+discordbot3> using variadic templates and constexpr functions 20180629 11:12:52<+discordbot3> and threw boost::mpl out 20180629 11:12:53<+discordbot3> Don't even get me started on that debugging session involving the event handling code. 20180629 11:13:15<+discordbot3> I have debugged stuff involving GUI2 event handling sometimes. 20180629 11:13:23<+discordbot3> I don't really remember what I was trying to accomplish but I think it eventually turned out I was barking at the wrong tree. 20180629 11:13:26<+discordbot3> It's not impossible, but very hard and very slow. :/ 20180629 11:15:35<+discordbot3> especially what mordante was doing where he set up a pseudo-compile-time evaluation of runtime parameters was just.... insane. 20180629 11:17:18<+discordbot3> I don't know for sure since I didn't bother to check, but it's likely the code was trying to build a different template path for every single event type for every single event category 20180629 11:43:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 11:43:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 11:53:51-!- Appleman1234 [~quassel@121.222.147.211] has joined #wesnoth-dev 20180629 12:02:04-!- gfgtdf_ [~gfgtdf@134.76.63.8] has quit [Read error: Connection reset by peer] 20180629 13:10:24< irker229> wesnoth/wesnoth:1.14 ville 45abb2c864 Adds a preference item for a sound being AppVeyor: All builds passed 20180629 13:34:10-!- DeFender1031 [~DeFender1@93-173-122-186.bb.netvision.net.il] has quit [Read error: Connection reset by peer] 20180629 13:34:28-!- DeFender1031 [~DeFender1@93-173-122-186.bb.netvision.net.il] has joined #wesnoth-dev 20180629 13:39:52-!- shiki [~Shiki@p54854BC3.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180629 13:52:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180629 14:20:59-!- gfg [~androirc@tmo-116-79.customers.d1-online.com] has joined #wesnoth-dev 20180629 14:36:05<+discordbot3> I see 20180629 14:36:29<+discordbot3> well, we need to disable that then 20180629 14:36:42<+discordbot3> no window means no renderer 20180629 14:37:48<+discordbot3> not sure how, though.. 20180629 14:37:54<+discordbot3> do the unit tests run windowless? 20180629 14:37:58<+discordbot3> they should.. 20180629 14:38:12<+discordbot3> no window appears when I run it locally, at least 20180629 14:38:28<+discordbot3> alright 20180629 14:38:36<+discordbot3> well, i tried to disable the UI drawing handle 20180629 14:38:38<+discordbot3> never has, though 20180629 14:38:41<+discordbot3> but i did it wrong 20180629 14:40:55< irker229> wesnoth/wesnoth:1.14 Charles Dang 1fa01b3a1e Preferences: added a mention of the in-g AppVeyor: All builds passed 20180629 15:03:02-!- gfg [~androirc@tmo-116-79.customers.d1-online.com] has quit [Remote host closed the connection] 20180629 15:03:25-!- aidanhs2 [~aidanhs@81.4.110.234] has quit [Ping timeout: 260 seconds] 20180629 15:05:34-!- gfg [~androirc@tmo-116-79.customers.d1-online.com] has joined #wesnoth-dev 20180629 15:15:30-!- DeFender1031 [~DeFender1@93-173-122-186.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180629 15:18:57-!- Appleman1234 [~quassel@121.222.147.211] has quit [Ping timeout: 248 seconds] 20180629 15:34:24-!- aidanhs2 [~aidanhs@81.4.110.234] has joined #wesnoth-dev 20180629 16:09:49-!- Netsplit *.net <-> *.split quits: +discordbot3 20180629 16:14:13-!- 21WAANAI7 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180629 16:14:13-!- ServerMode/#wesnoth-dev [+v 21WAANAI7] by hobana.freenode.net 20180629 16:17:15<+21WAANAI7> what video mode are the tests run in? 20180629 16:17:41-!- louis94 [~~louis94@109.131.34.255] has joined #wesnoth-dev 20180629 16:17:49-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-hopxeprqnsiaisai] has quit [Ping timeout: 245 seconds] 20180629 16:18:00-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-yzxdganfbtqupnuo] has quit [Ping timeout: 240 seconds] 20180629 16:18:09-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-rkktktbiafthhzrx] has quit [Ping timeout: 247 seconds] 20180629 16:18:25<+21WAANAI7> 1024x768. 20180629 16:18:26<+21WAANAI7> https://github.com/wesnoth/wesnoth/blob/master/src/tests/main.cpp#L80 20180629 16:19:16<+21WAANAI7> not what I meant, but gives me the answer nonetheless 20180629 16:20:44<+21WAANAI7> cpp bool CVideo::non_interactive() const { return fake_interactive ? false : (window == nullptr); } 20180629 16:20:50<+21WAANAI7> ok, so that explains why my change failed.. 20180629 16:21:05<+21WAANAI7> cpp if(!video_.faked() && !video_.non_interactive()) { connect_signal(std::bind(&window::draw, this)); } 20180629 16:21:16<+21WAANAI7> under the tests, where fake_interactive is true.. this would...pass 20180629 16:22:36<+21WAANAI7> this logic seems muddled 20180629 16:22:53<+21WAANAI7> we're not noninteractive if we're fake interactive.. 20180629 16:23:01<+21WAANAI7> ie, we're interactive if we're running the tests 20180629 16:23:04<+21WAANAI7> except we're not? 20180629 16:23:06<+21WAANAI7> there's no windw 20180629 16:24:18-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has quit [Quit: poweroff] 20180629 16:24:23<+21WAANAI7> I don't know if the Boost unit tests need the fake interactive mode to begin with. 20180629 16:24:57<+21WAANAI7> hmm... 20180629 16:25:39<+21WAANAI7> alright, let's test that 20180629 16:26:59-!- louis94 [~~louis94@109.131.34.255] has quit [Ping timeout: 255 seconds] 20180629 16:28:57< irker229> wesnoth: Charles Dang wesnoth:master b0be17b398bf / src/tests/utils/fake_display.cpp: Experiment: don't run the unit tests in fake interactive mode https://github.com/wesnoth/wesnoth/commit/b0be17b398bf7a20ebe55826b938f897ff27f49b 20180629 16:29:07<+21WAANAI7> thinking about it, the fake interactive mode had a framebuffer 20180629 16:29:13<+21WAANAI7> but that was removed 20180629 16:29:25<+21WAANAI7> so it's possible the fake interactive mode could be removed 20180629 16:29:37<+21WAANAI7> Some tests need the ability to set the size of the fake display. 20180629 16:29:47<+21WAANAI7> But your commit may give us useful data regardless. 20180629 16:30:18<+21WAANAI7> in which case I can easily add the size arguments to make_fake 20180629 16:30:58-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 264 seconds] 20180629 16:31:59-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20180629 16:39:56<+21WAANAI7> hmmm some failed... 20180629 16:42:22< irker229> wesnoth: Charles Dang wesnoth:master 58110b6818c6 / src/tests/utils/fake_display.cpp: Fixup b0be17b https://github.com/wesnoth/wesnoth/commit/58110b6818c6b5bfac23dbd170e0f8e9779b930f 20180629 16:52:29<+21WAANAI7> hmm... 20180629 16:52:34<+21WAANAI7> ok, I can probably make this work 20180629 16:54:22<+21WAANAI7> The result looks quite bad to me. 20180629 16:54:37<+21WAANAI7> /home/wesnoth-travis/src/tests/gui/test_gui2.cpp(245): fatal error in "test_gui2": critical check window != static_cast(nullptr) failed [0 == 0] 20180629 16:54:54<+21WAANAI7> It's as if GUI2 windows refused to open. 20180629 16:54:54< irker229> wesnoth: Charles Dang wesnoth:master 55caeebffe85 / src/gui/dialogs/ (modal_dialog.cpp modeless_dialog.cpp): More testing... https://github.com/wesnoth/wesnoth/commit/55caeebffe85d8cb21a2db27a0ef0c1e9d1429ec 20180629 16:54:59<+21WAANAI7> yeah, due to that ^ 20180629 16:55:40<+21WAANAI7> Now you're messing with the faked mode that's used by 'all other tests*. 20180629 16:55:55<+21WAANAI7> I have a feeling you just broke everything except the Boost unit tests. 20180629 16:56:08<+21WAANAI7> we shall see. 20180629 16:57:15<+21WAANAI7> if everything blows up I can revert everything and look for another solution 20180629 17:00:57<+21WAANAI7> yeah, that doesn't work. 20180629 17:03:10-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-oeuxelsigmobnyau] has joined #wesnoth-dev 20180629 17:03:15< irker229> wesnoth: Charles Dang wesnoth:master 87ae234022df / src/ (3 files in 2 dirs): Revert recent test changes https://github.com/wesnoth/wesnoth/commit/87ae234022df9e321c7fd0ac90510ddc7a76d115 20180629 17:03:26<+21WAANAI7> will need to think of something else 20180629 17:04:12<+21WAANAI7> i still think the logic of non_interactive() is off... 20180629 17:05:03<+21WAANAI7> The obvious next option to try is that drawning would also be disabled in the fake interactive mode. 20180629 17:17:45-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180629 17:20:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180629 17:30:15-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-bivxvsgfhgmzmkwf] has joined #wesnoth-dev 20180629 17:30:16-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-zniiichkjmcxwojv] has joined #wesnoth-dev 20180629 17:41:50< irker229> wesnoth/wesnoth:master Charles Dang 98ddc311fc Preferences: added a mention of the in-g AppVeyor: All builds passed 20180629 18:10:23<+21WAANAI7> @jyrkive I tried that 20180629 18:10:47<+21WAANAI7> i guess i need to add a new getter... 20180629 18:12:26<+21WAANAI7> or change the logic of non_interactive 20180629 18:12:32<+21WAANAI7> I was thinking of making it uhh 20180629 18:12:43<+21WAANAI7> return fake_interactive || window == nullptr; 20180629 18:12:48<+21WAANAI7> Best to add a new function. 20180629 18:13:06<+21WAANAI7> Something else may be relying on the current behavior of non_interactive(). 20180629 18:13:23<+21WAANAI7> doesn't look like it 20180629 18:13:57<+21WAANAI7> Well, even then I think it would be better to also rename the function when you're changing its semantics. 20180629 18:15:24<+21WAANAI7> I'm saying it seems like a mistake to classify "fake interactive" as "interactive" if it's not meant to draw anything and no window shows up 20180629 18:15:57<+21WAANAI7> it seems like the logic was "an interactive version of fake mode", but it's...not interactive 20180629 18:16:21<+21WAANAI7> Well, in that case you should also rename the variable. 20180629 18:16:52<+21WAANAI7> cpp bool is_interactive() { return !interactive; } 20180629 18:17:14<+21WAANAI7> (Cue a couple dozen years later: "What on earth was that programmer thinking?!" 20180629 18:27:11<+21WAANAI7> let's see what the tests say... 20180629 18:27:12< irker229> wesnoth: Charles Dang wesnoth:master 2ad6b60c9462 / src/video.cpp: CVideo: tweaked non_interactive logic https://github.com/wesnoth/wesnoth/commit/2ad6b60c9462f904bc6fdb105765b59da51f9870 20180629 18:43:07-!- gfg [~androirc@tmo-116-79.customers.d1-online.com] has quit [Ping timeout: 265 seconds] 20180629 18:52:54-!- travis-ci [~travis-ci@ec2-54-162-149-177.compute-1.amazonaws.com] has joined #wesnoth-dev 20180629 18:52:55< travis-ci> wesnoth/wesnoth#18748 (master - 2ad6b60 : Charles Dang): The build passed. 20180629 18:52:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/398370977 20180629 18:52:55-!- travis-ci [~travis-ci@ec2-54-162-149-177.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180629 18:55:38<+21WAANAI7> annndddd the drawing errors stil show up 20180629 18:55:49<+21WAANAI7> oh well 20180629 18:57:13<+21WAANAI7> Then we should probably take the opposite approach and also initialize SDL in the Boost unit test executable. 20180629 19:16:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 19:16:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 19:54:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 19:54:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 19:56:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180629 20:34:47-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection] 20180629 20:35:25< irker229> wesnoth: pentarctagon wesnoth:master 649fdc9a6204 / data/campaigns/Dead_Water/ (46 files in 2 dirs): Remove unused images from Dead Water. https://github.com/wesnoth/wesnoth/commit/649fdc9a6204cc4e2019aac41a79910b493b7d5a 20180629 20:54:43-!- louis94 [~~louis94@109.131.34.255] has joined #wesnoth-dev 20180629 21:00:45-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180629 21:20:51-!- gfg [~androirc@x4e32b47b.dyn.telefonica.de] has joined #wesnoth-dev 20180629 21:31:55-!- Appleman1234 [~quassel@121.222.147.211] has joined #wesnoth-dev 20180629 21:32:44-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: bye] 20180629 21:56:52-!- gfgt [~androirc@x4e32b47b.dyn.telefonica.de] has joined #wesnoth-dev 20180629 21:57:45-!- gfg [~androirc@x4e32b47b.dyn.telefonica.de] has quit [Ping timeout: 245 seconds] 20180629 22:02:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180629 22:02:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180629 22:19:46-!- gfgt [~androirc@x4e32b47b.dyn.telefonica.de] has quit [Remote host closed the connection] 20180629 22:19:59-!- gfgt [~androirc@x4e32b47b.dyn.telefonica.de] has joined #wesnoth-dev 20180629 22:27:21-!- gfgt [~androirc@x4e32b47b.dyn.telefonica.de] has quit [Ping timeout: 264 seconds] 20180629 22:28:18-!- gfgt [~androirc@x4e32b47b.dyn.telefonica.de] has joined #wesnoth-dev 20180629 22:33:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20180629 22:38:30-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20180629 22:41:12-!- gfgt [~androirc@x4e32b47b.dyn.telefonica.de] has quit [Remote host closed the connection] 20180629 22:57:34< irker229> wesnoth: gfgtdf wesnoth:1.14 ef4ae1cf5d54 / / (3 files in 2 dirs): allow non hosts to change factions later. https://github.com/wesnoth/wesnoth/commit/ef4ae1cf5d54cf168c9bd300d374899511071d32 20180629 22:57:36< irker229> wesnoth: gfgtdf wesnoth:1.14 e72a92ac961a / src/ (3 files in 2 dirs): make flg manager not store confg& side_ https://github.com/wesnoth/wesnoth/commit/e72a92ac961a6b5e0b0f3c27c62cdcff4d3e4f4d 20180629 22:57:38< irker229> wesnoth: gfgtdf wesnoth:1.14 b8a119dfc5d4 / src/ (5 files in 2 dirs): cancel faction_select when the game starts https://github.com/wesnoth/wesnoth/commit/b8a119dfc5d4e859dc66adf7df52a956db1366f1 20180629 22:57:40< irker229> wesnoth: gfgtdf wesnoth:1.14 75e0d082523e / src/gui/dialogs/multiplayer/ (mp_join_game.cpp mp_join_game.hpp): mp join: fix crash when the dialog is updated while the flg dialog is open. https://github.com/wesnoth/wesnoth/commit/75e0d082523e720d9b6ecc34147f0c35994cfbe3 20180629 22:57:42< irker229> wesnoth: gfgtdf wesnoth:1.14 50e297fbf1fa / src/gui/core/timer.cpp: add a comment https://github.com/wesnoth/wesnoth/commit/50e297fbf1fa4549f2d90211ead1758cb8cd4b42 20180629 22:57:44< irker229> wesnoth: gfgtdf wesnoth:1.14 9fdf301a530f / src/gui/dialogs/multiplayer/ (mp_join_game.cpp mp_join_game.hpp): fix code dublication of mp_join_game::show_flg_select https://github.com/wesnoth/wesnoth/commit/9fdf301a530ff68a8f4677a146fb2fe8f84e0e29 20180629 23:13:00< irker229> wesnoth: gfgtdf wesnoth:master 26b5ca55e401 / data/test/scenarios/feeding.cfg src/actions/attack.cpp: disallow attacking with disabled attacks via [do_command] https://github.com/wesnoth/wesnoth/commit/26b5ca55e40176f338265b162178df7342ec2882 20180629 23:13:02< irker229> wesnoth: gfgtdf wesnoth:master 5ba389111eaa / / (3 files in 2 dirs): allow non hosts to change factions later. https://github.com/wesnoth/wesnoth/commit/5ba389111eaa5d08f55d60c1b437c250a329bc58 20180629 23:13:04< irker229> wesnoth: gfgtdf wesnoth:master c805897797d7 / src/ (3 files in 2 dirs): make flg manager not store confg& side_ https://github.com/wesnoth/wesnoth/commit/c805897797d7ff22f3ea4fd1ce9c0fb126baefea 20180629 23:13:06< irker229> wesnoth: gfgtdf wesnoth:master 2dd65574498a / src/ (5 files in 2 dirs): cancel faction_select when the game starts https://github.com/wesnoth/wesnoth/commit/2dd65574498a9731b501e18da04c01f959ab6654 20180629 23:13:08< irker229> wesnoth: gfgtdf wesnoth:master c55512755237 / src/gui/dialogs/multiplayer/ (mp_join_game.cpp mp_join_game.hpp): mp join: fix crash when the dialog is updated while the flg dialog is open. https://github.com/wesnoth/wesnoth/commit/c55512755237dc818abc3b6bce4c3d31dbd2449b 20180629 23:13:10< irker229> wesnoth: gfgtdf wesnoth:master 0296b6068cad / src/gui/core/timer.cpp: add a comment https://github.com/wesnoth/wesnoth/commit/0296b6068cad37db4034b1edcc33025e3be82987 20180629 23:13:12< irker229> wesnoth: gfgtdf wesnoth:master a2a4dff05071 / src/gui/dialogs/multiplayer/ (mp_join_game.cpp mp_join_game.hpp): fix code dublication of mp_join_game::show_flg_select https://github.com/wesnoth/wesnoth/commit/a2a4dff050713e96b0b14612486d82cf3f93fa3d 20180629 23:17:08-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Sat Jun 30 00:00:52 2018