--- Log opened Sat Jun 23 00:00:04 2018 20180623 00:14:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 00:14:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 00:19:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 00:19:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 02:22:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 02:22:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 04:06:00< discordbot2> 😐 20180623 04:06:21< discordbot2> I don't approve of connecting this to IRC. 20180623 04:26:07< discordbot2> 😮 20180623 04:26:09< discordbot2> How so? 20180623 04:31:16< discordbot2> Moving on. 20180623 04:31:29< discordbot2> Various reasons, not important. Moving on. 20180623 04:31:38< discordbot2> Is anyone aware of issues with Lua math functions on Android? 20180623 04:31:53< discordbot2> Could be alep uses outdated lua 20180623 04:31:58< discordbot2> (In Wesnoth and otherwise.) 20180623 04:32:06< discordbot2> Why would he? Lua is part of our codebase. 20180623 04:32:27< discordbot2> And it does have local changes (see also the Lua jailbreak exception code). 20180623 04:32:40< discordbot2> ISTR th iOS port shipping with an old copy of lua until recently 20180623 04:32:49< discordbot2> (you'd need to confirm with @sinda ) 20180623 04:33:25< discordbot2> The Android and iOS codebases are maintained by completely different people though. 20180623 04:33:54< discordbot2> Yes. The point being, though, that the ports do not necessarily use the version of Lua we ship. 20180623 04:33:54< discordbot2> So idk if that would mean much. 20180623 04:34:21< discordbot2> Well if that's the case I'd like to know why. 20180623 04:34:46< discordbot2> That said, my code worked in 1.12 and 1.14 without any changes, so we'd be talking of a much older version of Lua. 20180623 04:35:25< discordbot2> atan2 was introduced in 5.1 AFAIK 20180623 04:35:28< discordbot2> (At which point I'd have to question the sanity of whoever decided to swap the Lua library without consulting about the potential ramifications with our dev team.) 20180623 04:36:08< discordbot2> and indecently, atan2 is the function the iOS port was having trouble with 20180623 04:36:45< discordbot2> *Incidentally. 20180623 04:36:54< discordbot2> Indecently means something entirely different. 😛 20180623 04:36:54< discordbot2> oops 20180623 04:37:01< discordbot2> a/c 20180623 04:37:15< discordbot2> well, manual c but i didn't read the list 20180623 04:38:11< discordbot2> I do expect that the solution in my case is to call the engine like you suggested several weeks ago, but I'd expect other people to encounter issues with code that doesn't have that option. 20180623 04:39:15< discordbot2> But you said you didn't want to call the engine 20180623 04:39:46< discordbot2> Did I? 20180623 04:40:13< discordbot2> I think it was just a case of "i cba to touch legacy code". 20180623 04:40:16< discordbot2> Yes 20180623 04:42:20< discordbot2> Okay 😮 20180623 06:59:06< discordbot2> I updated iPad Lua 2 releases ago, should be fine. 20180623 07:04:29< discordbot2> @sinda We want to know why Lua wasn't the mainline version in the first place. 20180623 07:04:50< discordbot2> Or rather I want to know, to better understand why the Android guy might've made the same mistake. 20180623 07:06:03< discordbot2> Not using the exact Lua library Wesnoth ships with (which again, is not the unmodified upstream version) can have disastrous consequences. 20180623 07:10:36< discordbot2> iOS port is a of its own kind. All its dependencies were compiled from sources, and most still are. The only libraries I changed were SDL family, which I replaced with SDL2. Lua was an external one, and stayed such for some time. Others, like pango, are still quite ancient, and I don't touch it while it works. 20180623 07:10:56< discordbot2> After Lua problems came up for the first time, I switched to in-tree Lua sources. 20180623 07:11:48< discordbot2> This was not sufficient, as Lua also needs a compatibility #define to export all the functions like atan2. After I added the define, it should be fine. 20180623 07:11:55< discordbot2> Lua wasn't been an external library since version 1.9.x. 20180623 07:13:08< discordbot2> As they say in Ukraine, "I'm selling it for what I bought it". It was there in iOS port, even though it's Wesnoth 1.10. 20180623 07:15:20< discordbot2> I'm not Ukranian so I'm going to assume that means the build system already forced an external library into Wesnoth when you adopted dailin's port source tree (which I didn't even know was a thing that took place), so you left it that way. 20180623 07:18:40< discordbot2> How has Wesnoth's lua been modified compared to the upstream version? 20180623 07:20:04< discordbot2> It's compiled as C++. 20180623 07:20:30< discordbot2> No idea who or what added it, but there it was: https://github.com/CliffsDover/wesnoth_ios/tree/master/lib/lua 20180623 07:20:33< discordbot2> Previously the lua_jailbreak_exception code was part of it but it appears someone managed to refactor it out of the Lua library proper somehow. 20180623 07:21:00< discordbot2> The library configuration is also nonstandard. 20180623 07:21:59< discordbot2> See https://github.com/wesnoth/wesnoth/blob/ebbc2152feda7ab0f3d2e5bc5f0001309a0d6b21/src/wesnoth_lua_config.md 20180623 07:24:52< discordbot2> https://forums.wesnoth.org/viewtopic.php?p=630277#p630277 20180623 07:24:53< discordbot2> Reported. 20180623 07:27:54< discordbot2> This file in particular contains some Wesnoth-specific changes: https://github.com/wesnoth/wesnoth/blob/ebbc2152feda7ab0f3d2e5bc5f0001309a0d6b21/src/wesnoth_lua_config.h 20180623 07:28:23< discordbot2> It's outside the Lua source code tree, but it's critical that it's #included in every Lua translation unit. 20180623 07:28:41< discordbot2> (Which we're doing via a compiler parameter.) 20180623 07:34:40< discordbot2> interesting, thanks 20180623 09:18:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 09:18:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 09:21:33< discordbot2> credit to tad for sorting out the Lua mess 20180623 09:22:07< discordbot2> it's now almost identical to upstream 20180623 09:24:26< discordbot2> besides being compiled as c++, I think there's only.... 1 change we made to the actual Lua source 20180623 09:24:28< discordbot2> d0100758f855ec0d8f30dff41e8a8b6ff2d45fda 20180623 09:28:28< discordbot2> which is hopefully something they fix in 5.3.5 20180623 12:04:01< discordbot2> Link for anyone who wants to see the commit: https://github.com/wesnoth/wesnoth/commit/d0100758f855ec0d8f30dff41e8a8b6ff2d45fda 20180623 12:06:51< discordbot2> And I have said it's unlikely that Lua developers would "fix" it: https://github.com/wesnoth/wesnoth/pull/2086#issuecomment-335363690 20180623 12:07:34< discordbot2> (From their perspective, there is nothing to fix. Usina g C-style casts isn't exactly discouraged in C, where C++ casts aren't available.) 20180623 13:51:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 13:52:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 18:25:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 18:25:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 18:43:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 18:43:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180623 20:42:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180623 20:42:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev --- Log closed Sun Jun 24 00:00:07 2018