--- Log opened Mon Jul 02 00:00:55 2018 20180702 00:03:57-!- louis94 [~~louis94@109.131.34.255] has quit [Ping timeout: 245 seconds] 20180702 00:14:00-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180702 00:42:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180702 00:42:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180702 00:53:36< irker544> wesnoth/wesnoth:1.14 josteph 2908d36b94 TSG S05: Hide completed objectives. AppVeyor: All builds passed 20180702 01:37:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180702 01:37:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180702 01:44:14< irker544> wesnoth: Severin Glöckner wesnoth:1.14 c7a163e3c66d / po/ (wesnoth-lib/de.po wesnoth-nr/de.po): readd German NR translation https://github.com/wesnoth/wesnoth/commit/c7a163e3c66d28aa71bc391c29b06c2ba11f402b 20180702 01:44:16< irker544> wesnoth: Severin Glöckner wesnoth:1.14 1c708c480190 / po/ (wesnoth-editor/de.po wesnoth-lib/de.po): updated German translation https://github.com/wesnoth/wesnoth/commit/1c708c480190036edf5b2054201f45989e6c31ea 20180702 02:10:07< irker544> wesnoth: Charles Dang wesnoth:master 9fe86315f537 / src/gui/ (core/placer.cpp core/placer.hpp widgets/pane.cpp widgets/pane.hpp): GUI2: dropped a remaining t-prefix from a type https://github.com/wesnoth/wesnoth/commit/9fe86315f5379dcc87e4508e9e5d00d3d8e06880 20180702 02:10:26< celmin> A bit amusing how many t-prefixes were missed. 20180702 02:10:42< celmin> That must be like, the third or fourth commit like that. 20180702 02:13:00-!- Appleman1234 [~quassel@121.222.147.211] has quit [Read error: Connection reset by peer] 20180702 02:13:35-!- Appleman1234 [~quassel@121.222.147.211] has joined #wesnoth-dev 20180702 02:16:57-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 240 seconds] 20180702 02:17:08-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev 20180702 02:22:33<+discordbot1> you caught 99% of them 20180702 02:25:09< irker544> wesnoth: Severin Glöckner wesnoth:master 9a37fe3a072e / po/ (28 files in 28 dirs): copied German translation to maser https://github.com/wesnoth/wesnoth/commit/9a37fe3a072ecd15ba8e196adcfac7e6a12e5444 20180702 03:15:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180702 03:15:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180702 03:34:32-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180702 03:38:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180702 03:41:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180702 03:53:40< irker544> wesnoth/wesnoth:1.14 Pentarctagon d304640f05 Adds the opt/OPT option to scons/cmake. AppVeyor: All builds passed 20180702 04:29:49<+discordbot1> I just built master and I can't click on units... anyone else having this issue? I don't want to make an issue for it if it's just a current me-thing 20180702 04:40:27<+discordbot1> master is a wreck right now. Is there any particular reason you wanted to look at it? 20180702 04:41:58-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180702 04:46:47-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 04:46:47-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 04:46:47-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 04:50:55-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180702 04:56:40<+discordbot1> Nope, I was handling an issue but the code snippet's the same in master as 1.14, I'll just throw it in there. 20180702 04:57:36-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 04:57:36-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 04:57:37-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 05:04:24-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180702 05:07:21-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 05:07:21-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 05:07:21-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 05:25:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180702 05:28:41< zookeeper> @Vultraz you didn't update the unstore coordinates in prestart, i presume: https://github.com/wesnoth/wesnoth/issues/3304 20180702 05:36:31< zookeeper> (have we yet had a single 1.14 release that didn't break something in a mainline campaign?) 20180702 05:39:01-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180702 05:40:35-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 05:40:35-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 05:40:35-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 05:57:39-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180702 05:59:00-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 05:59:01-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 05:59:01-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 06:29:36<+discordbot1> zookeeper: my puulllll requesstttttttt 😂 20180702 06:29:46<+discordbot1> it's languishing in the land of neglect 20180702 06:32:57-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180702 06:37:19-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 06:37:19-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 06:37:19-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 06:38:03< zookeeper> @Yumi i know! i didn't have time when i said i thought i would, and since then i've been bus... i mean bad at managing my time 20180702 06:38:48<+discordbot1> okay D: 20180702 06:39:17<+discordbot1> whenever you have time, then 20180702 06:57:04<+discordbot1> I still don’t like the map 20180702 06:57:09<+discordbot1> I don’t think it should go in 20180702 06:59:31<+discordbot1> play it first 20180702 07:00:09<+discordbot1> and you'll need to offer something more constructive than "I don't like the map" 20180702 07:18:06-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180702 07:24:57-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180702 07:30:23-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 07:30:23-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 07:30:23-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 07:35:35-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180702 07:36:00< irker544> wesnoth/wesnoth:1.14 joeylmaalouf cd5bc3dc3c provide more detail about the Status Tab AppVeyor: All builds passed 20180702 07:37:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180702 08:04:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180702 08:22:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180702 08:23:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180702 10:31:09< irker544> wesnoth/wesnoth:1.14 Severin Glöckner 1c708c4801 updated German translation AppVeyor: All builds passed 20180702 10:55:16-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 10:55:16-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 10:55:16-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 11:00:25<+discordbot1> I've done some digging in the logs, and it seems the experimental "new" GUI2 listbox was added in 2010. However, in 2012, mordante added the pane class, along with partial use of it in his early prototype of the addon manager. I'm just going to remove drop the 2010 version. It's incomplete, rather useless at this point, and the pane stuff looks more promising if we intended to pick it back up. Its interface is cleaner and it 20180702 11:00:25<+discordbot1> doesn't use the generator class. 20180702 11:02:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 256 seconds] 20180702 11:05:47-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180702 11:07:21-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 11:07:21-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 11:07:21-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 11:22:40< irker544> wesnoth: Charles Dang wesnoth:master 458dd284b834 / / (46 files in 8 dirs): GUI2: removed 2010 experimental listbox https://github.com/wesnoth/wesnoth/commit/458dd284b8342b33e6a6359aefbbbdb386b28875 20180702 11:24:18-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180702 11:26:17< irker544> wesnoth: Charles Dang wesnoth:master 162b9de33032 / projectfiles/VC14/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updated VS projectfile https://github.com/wesnoth/wesnoth/commit/162b9de330322edf9723ef2cbed02978b7a38571 20180702 11:48:19-!- travis-ci [~travis-ci@ec2-54-205-60-99.compute-1.amazonaws.com] has joined #wesnoth-dev 20180702 11:48:20< travis-ci> wesnoth/wesnoth#18774 (master - 458dd28 : Charles Dang): The build was broken. 20180702 11:48:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/399083970 20180702 11:48:21-!- travis-ci [~travis-ci@ec2-54-205-60-99.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180702 11:57:32<+discordbot1> Is it possible to distribute themes via add-ons? 20180702 11:58:38<+discordbot1> asking because of r.wesnoth.org/p589619 20180702 12:33:16< irker544> wesnoth/wesnoth:master Severin Glöckner 9a37fe3a07 copied German translation to maser AppVeyor: All builds passed 20180702 12:55:22<+discordbot1> I would be very much interested in how to do that too 20180702 12:57:02<+discordbot1> especially if the theme replaces some images 20180702 13:23:53-!- Appleman1234 [~quassel@121.222.147.211] has quit [Ping timeout: 256 seconds] 20180702 13:50:00-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180702 13:59:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180702 14:02:12< irker544> wesnoth/wesnoth:1.14 ville 5a7b227961 Sort the movement costs in the tooltip i AppVeyor: All builds passed 20180702 15:02:41-!- Oebele_ [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180702 15:15:26< irker544> wesnoth/wesnoth:1.14 ville b083dad525 Sort the movement costs in the tooltip i AppVeyor: All builds passed 20180702 15:36:39<+discordbot1> Has anyone had any problems with the last breath event triggering when the unit doesn't die? 20180702 15:47:25<+discordbot1> Sorry, I realized 'development' refers to the base game. 20180702 15:53:57-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 15:53:58-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 15:53:58-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 16:03:23< irker544> wesnoth/wesnoth:1.14 ville bb29d008da Add an advanced preference item to sort AppVeyor: vs2015/Release Failed 20180702 16:03:24< irker544> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4095 20180702 16:19:53< Soliton> @Varicks: rather than asking a vague question about something perhaps not working somewhere: show wml/lua code you have, explain what it does and what you want it to do instead. and if it's about an add-on you could indeed rather ask in #modding. 20180702 16:27:49< irker544> wesnoth/wesnoth:1.14 josteph 86da5a9a8c TSG S05: Merge all instances of [objecti AppVeyor: All builds passed 20180702 16:44:55<+discordbot1> @hrubymar10 could you update the XCode file 20180702 16:56:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180702 16:59:46< irker544> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master dc6d5850f552 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode project after 458dd284b8342b33e6a6359aefbbbdb386b28875 https://github.com/wesnoth/wesnoth/commit/dc6d5850f552bbccc2b21ea3d7e6d8b4539e1915 20180702 17:00:45<+discordbot1> ty 20180702 17:21:51-!- travis-ci [~travis-ci@ec2-54-91-62-70.compute-1.amazonaws.com] has joined #wesnoth-dev 20180702 17:21:52< travis-ci> wesnoth/wesnoth#18777 (master - dc6d585 : Martin Hrubý (hrubymar10)): The build was fixed. 20180702 17:21:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/399220278 20180702 17:21:52-!- travis-ci [~travis-ci@ec2-54-91-62-70.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180702 17:28:58< celmin> Oh hey 3303. 20180702 17:29:04< celmin> More missing translations. 20180702 17:31:07< celmin> 3300 sounds relatively easy... 20180702 17:34:59< irker544> wesnoth/wesnoth:1.14 josteph ccb69213e6 TSG S05: Merge all instances of [objecti AppVeyor: All builds passed 20180702 17:37:18< celmin> Looks like there's a bug in some of the ThemeWML reports that were used by the widescreen theme. 20180702 17:38:46<+discordbot1> i thought i removed that theme 20180702 17:39:25<+discordbot1> @jyrkive how complete in your estimation is REQUEST_PLACEMENT? 20180702 17:39:26< celmin> You did, but there's nothing preventing someone from remaking it. 20180702 17:39:34< celmin> The underlying support structures for it still exist. 20180702 17:39:48< celmin> In reports.cpp IIRC 20180702 17:40:38<+discordbot1> this check is the last of the code behind --new-widgets cpp if(visible == visibility::visible && new_widgets) { std::cerr << "firing request placement" << std::endl; event::message message; fire(event::REQUEST_PLACEMENT, *this, message); } else { window* window = get_window(); if(window) { window->invalidate_layout(); } 20180702 17:40:39<+discordbot1> } and you were the last one to edit it. 20180702 17:40:49<+discordbot1> d1df341371f8356586cdd3ca2696ad1d0aaf56f0 20180702 17:41:21<+discordbot1> Unconditional replacing with REQUEST_PLACEMENT, like that code does, is not safe. 20180702 17:41:30<+discordbot1> what breaks? 20180702 17:41:46<+discordbot1> I don't recall anything in particular. 20180702 17:43:13<+discordbot1> I can say, though, that in general there are cases where you want the entire window to adjust for something becoming visible, rather than complaining "why can't this stupid layout system use the space that's right there, instead of using scrollbars" or whatever. 20180702 17:44:59< irker544> wesnoth: Charles Dang wesnoth:master e2fd9749a6ec / src/tests/gui/test_gui2.cpp: Re-enable the --new-widgets tests for general dialogs https://github.com/wesnoth/wesnoth/commit/e2fd9749a6ecbe1089258875ee2093147797accc 20180702 17:45:01<+discordbot1> let's see what the tests say 20180702 17:49:19<+discordbot1> I've been looking more at the pane widget 20180702 17:49:44<+discordbot1> it definitely seems like a nicer implementation of a list 20180702 17:49:58< celmin> Is that what the pane is? 20180702 17:50:13< celmin> If so it seems like a weird name for it. 20180702 17:50:26<+discordbot1> * Add a new pane widget. The code is used to experiment with a different approach of the implementation of a listbox. 20180702 17:50:46<+discordbot1> it was added in 2012, and he was experimenting with using it in the addon manager. 20180702 17:51:02<+discordbot1> the old new listbox implementation I removed earlier was added in 2010 20180702 17:51:22<+discordbot1> Also see https://github.com/wesnoth/wesnoth/commit/941e1c2a84319f14dd12596dcdc9bb89c1dda38b 20180702 17:51:24<+discordbot1> so AFAICT, he started a second re-implementation of the listbox 20180702 17:51:37< celmin> …oh wow. 20180702 17:53:11<+discordbot1> looks like the debug clock is totally broken 20180702 17:53:18< celmin> On master or 1.14? 20180702 17:53:33< celmin> And broken how? 20180702 17:53:36<+discordbot1> master but probably 1.14 too 20180702 17:53:46<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/463401915007500308/unknown.png 20180702 17:53:54<+discordbot1> labels in the wrong place 20180702 17:53:59<+discordbot1> constant "could not place grid" spam 20180702 17:54:16< celmin> Oh, here's a good idea https://forums.wesnoth.org/viewtopic.php?p=629652#p629652 20180702 17:54:32<+discordbot1> ignore the duplicate numbers, that somehow has to do with my text texture cache >_> 20180702 17:54:37< celmin> Well, I wouldn't call that screenshot totally broken,,, 20180702 17:54:52< celmin> But something is definitely not right. 20180702 17:55:25<+discordbot1> and jesus our circle rendering tech is so ugly 20180702 17:55:34< celmin> Huh? 20180702 17:55:42< celmin> Seems fine to me> 20180702 17:55:45< celmin> ^? 20180702 17:56:11<+discordbot1> weird diagonal lines... non-aliased borders...gaps in the circle 20180702 17:56:12< celmin> Oh, I guess if I zoom in it's a bit holey. 20180702 17:56:46< celmin> I don't know what you're talking about WRT diagonal lines 20180702 17:57:12<+discordbot1> anyway, console has a million messages like this 20180702 17:57:14<+discordbot1> 20180703 04:55:42 error gui/layout: grid [] gui2::grid::place: Failed to place a grid, we have 250,192 space but we need 35,3774 space. This happened at a grid with the id '' in a 'class gui2::matrix' with the id 'matrix' in a 'class gui2::grid' with the id '_window_content_grid' in a 'class gui2::grid' with the id '_content_grid' in a 'class gui2::scrollbar_panel' with the id '' in a 'class gui2::grid' with the id '' in a 'class 20180702 17:57:15<+discordbot1> gui2::window' with the id 'debug_clock'. 20180702 17:57:26<+discordbot1> so it definitely got broken sometime in the past few years. 20180702 18:01:01<+discordbot1> unfortunately, there's really no explanation about how the pane is supposed to work 😐 20180702 18:01:27<+discordbot1> in the debug clock, it's used inside a matrix. 20180702 18:01:32<+discordbot1> why? who knows 20180702 18:02:10<+discordbot1> it breaks if you use it in a regular grid like a listbox 20180702 18:02:12<+discordbot1> asserts 20180702 18:02:22<+discordbot1> and if you remove that, nothing draws 20180702 18:02:56<+discordbot1> so I'm not sure where to start if I wanted to revive work on it 20180702 18:05:16<+discordbot1> was the pane class supposed to be used in a listbox? 20180702 18:05:24<+discordbot1> like an implementation detail? 20180702 18:06:11<+discordbot1> the code jyrki removed seemed to indicate that. But why. 20180702 18:06:19<+discordbot1> that doesn't make sense 20180702 18:06:23<+discordbot1> and why was there a viewport 20180702 18:06:35<+discordbot1> is the matrix required? 20180702 18:07:05< celmin> I have absolutely no idea. 20180702 18:07:31<+discordbot1> hmmm 20180702 18:07:41<+discordbot1> "stop replacing listboxes with panes..." 20180702 18:08:01<+discordbot1> actually, that seems to indicate he was using the listbox was a wrapper class for panes to test them out easily 20180702 18:39:51< irker544> wesnoth/wesnoth:master Charles Dang 162b9de330 Updated VS projectfile AppVeyor: All builds passed 20180702 19:16:50<+discordbot1> maybe my new mouse will get here today >_> 20180702 19:17:01<+discordbot1> been such a PITA to use this half-broken one 20180702 19:17:21<+discordbot1> it keeps insisting on losing selection focus 20180702 19:18:09<+discordbot1> @Vultraz what os 20180702 19:18:29<+discordbot1> @Vultraz ^ 20180702 19:18:43<+discordbot1> what? 20180702 19:18:54<+discordbot1> What os are you on 20180702 19:18:59<+discordbot1> windows 10, why 20180702 19:19:28<+discordbot1> Your mouse problem, just enable mouse keys and change the velocity 20180702 19:19:49<+discordbot1> Alt+Shift+Num Lock 20180702 19:20:02<+discordbot1> Iirc 20180702 19:20:07<+discordbot1> it's not a problem with settings, it's a problem with the mouse itself 20180702 19:20:14<+discordbot1> it's cheap and old and worn down 20180702 19:20:50<+discordbot1> Mouse keys let's your keyboard move the mouse, so you can forego using shitty mouse temporarily 20180702 19:21:26<+discordbot1> eh, I'll stick with it. thanks for the suggestion, though 20180702 19:26:02< zookeeper> @Vultraz you didn't seem to notice the DiD breakage i linked you to some 14 hours ago 20180702 19:26:16<+discordbot1> i saw you mentioned it 20180702 19:32:51<+discordbot1> pokes celmin 20180702 19:32:54< celmin> ? 20180702 19:33:57<+discordbot1> lua local foo = wml.variables.bar foo = nil does this clear the WML variable bar as if you used wml_actions.clear_variable or only set the local variable foo to nil? 20180702 19:34:30< celmin> No. 20180702 19:34:44<+discordbot1> no what? 20180702 19:34:46< celmin> wml.variables.bar.foo = nil will clear it 20180702 19:34:49< celmin> foo = nil won't 20180702 19:34:56<+discordbot1> ok 20180702 19:34:58< celmin> Oh wait, drop the foo in the first example 20180702 19:35:00< celmin> Duh 20180702 19:42:45<+discordbot1> what's going on here 20180702 19:43:02<+discordbot1> lua local saved_orc_leader = wml.variables.orc_leader_store if saved_orc_leader != nil then "then expected near '!'" 20180702 19:43:29< Ravana_> != is not allowed in Lua 20180702 19:43:38<+discordbot1> oh 20180702 19:43:48< celmin> ~= 20180702 19:43:58<+discordbot1> ....ah 20180702 19:44:04<+discordbot1> too much c++ 20180702 19:44:07< celmin> :P 20180702 19:44:14<+discordbot1> ty 20180702 19:48:41< irker544> wesnoth: Charles Dang wesnoth:1.14 8659c32afc90 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: fixed previously stored orc leader ending up in the wrong place (fixes # https://github.com/wesnoth/wesnoth/commit/8659c32afc9081c53db6aa620dee1fd94e5d71ea 20180702 19:49:16< irker544> wesnoth: Charles Dang wesnoth:master 78076941a07a / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: fixed previously stored orc leader ending up in the wrong place (fixes # https://github.com/wesnoth/wesnoth/commit/78076941a07a15d4b3b2e99cbc200730567e4fe3 20180702 19:49:25<+discordbot1> @zookeeper ^ 20180702 19:50:39< zookeeper> that's an odd thing to luaify for no particular reason, but whatever floats your boat. hopefully you tested it :J 20180702 19:51:25<+discordbot1> I used lua because I wanted to use the starting position 20180702 19:52:05<+discordbot1> in lua that's one line 20180702 19:52:11<+discordbot1> in WML it's not 20180702 19:52:13<+discordbot1> and yes, i did 20180702 19:52:17< zookeeper> oh, right 20180702 19:52:46< Ravana_> I don't expect https://github.com/wesnoth/wesnoth/commit/8659c32afc9081c53db6aa620dee1fd94e5d71ea#diff-37d34da1ba63c68d5d3f61dcb134eecdR207 work (correctly) 20180702 19:53:12<+discordbot1> hmm.... 20180702 19:53:25<+discordbot1> ah, yes, I guess I want "se" 20180702 19:53:40<+discordbot1> odd there was no error... 20180702 19:54:50< Ravana_> it is in conditional 20180702 19:55:06<+discordbot1> i tested with the save attached to the bug report 20180702 19:55:51<+discordbot1> i guess in lua that would just fallback to nil since no se variable exists 20180702 19:55:59< zookeeper> what would you expect the error be? wouldn't se just evaluate to ni... yeah, something like that 20180702 19:56:13< celmin> No, it would give an error. 20180702 19:56:16< celmin> Because of ilua. 20180702 19:56:23<+discordbot1> but it didn't 20180702 19:56:26<+discordbot1> at least not visibly 20180702 19:56:36< celmin> Something like "se must be assigned to before being read" 20180702 19:56:59<+discordbot1> ...oh, now it shows up 20180702 19:57:05<+discordbot1> .... I guess I tested before I added that line 20180702 19:57:07< Ravana_> it might only be visible in lua console 20180702 19:57:17< celmin> It's an error so I'd expect it to show in chat. 20180702 19:57:32<+discordbot1> yeah, i tested and it shows up in chat 20180702 19:57:43<+discordbot1> thanks for catching that 20180702 19:57:56< irker544> wesnoth: Charles Dang wesnoth:1.14 2e0fb3c0331b / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: Fixup 8659c32 https://github.com/wesnoth/wesnoth/commit/2e0fb3c0331bd96a6b21d85918cc2e0722df97fa 20180702 19:58:07-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180702 19:58:20< celmin> Personally I have a convention of using single quotes for that sort of thing, but it really doesn't matter. 20180702 19:58:45< celmin> By "that sort of thing" I mean places where strings are used like an enum. 20180702 19:58:47<+discordbot1> what sort of thing? 20180702 19:58:48< irker544> wesnoth: Charles Dang wesnoth:master c39aa72f5693 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: Fixup 7807694 https://github.com/wesnoth/wesnoth/commit/c39aa72f56930f9d8d062250f55c5b97883c5007 20180702 19:58:55< celmin> Heh, timing. :P 20180702 19:58:59<+discordbot1> as opposed to? 20180702 19:59:05< celmin> As opposed to using them as a string? 20180702 19:59:08<+discordbot1> i see 20180702 19:59:19< celmin> Like, in string.format, or parsing something, or whatever. 20180702 19:59:23<+discordbot1> ill keep that in mind 20180702 19:59:23< celmin> Or something to be printed. 20180702 19:59:43< celmin> It's just a convention I use in languages that don't distinguish between the quote types. 20180702 19:59:51< celmin> Got started with it in Python IIRC. 20180702 20:00:04<+discordbot1> i didn't realize initially that c++ did 20180702 20:00:21< celmin> So you didn't realize that 'BANG' in C++ is a long int? 20180702 20:00:48<+discordbot1> what the hell 20180702 20:00:49<+discordbot1> O_O 20180702 20:01:17< celmin> Well, on a big-endian machine, you could probably get away with using 'BANG' when you meant "BANG", as long as you didn't rely on the null terminator... 20180702 20:01:33< celmin> If you do that on a little-endian machine (like Intel) you'll end up reading "GNAB". 20180702 20:03:10< celmin> Classic Mac used these four-letter specifiers extensively to identify file types and many other things. 20180702 20:03:31< celmin> (I think in modern C/C++ you can also use eight-letter ones.) 20180702 20:03:37-!- Oebele_ [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection] 20180702 20:03:43< celmin> (Though it seems like it's generally not recommended these days.) 20180702 20:05:14<+discordbot1> geez...talk about confusing 20180702 20:05:22< celmin> I suppose it could be a bit confusing. 20180702 20:05:33< celmin> If you're not used to the idea. 20180702 20:06:39-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 20:06:39-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 20:06:39-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 20:06:47< celmin> Even though I wasn't really programming yet when I used a Classic Mac (apart from a little fiddling with the Glypha III source code in CodeWarrior Lite), I messed around a lot in ResEdit so I kinda got used to the idea... 20180702 20:07:12< celmin> (Oh also, I guess playing around with Logo also counts as programming.) 20180702 20:07:23< celmin> (And that game maker program.) 20180702 20:07:27< celmin> (And HyperCard.) 20180702 20:08:06-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180702 20:08:10< celmin> (But four-letter codes aren't very relevant there.) 20180702 20:09:34-!- fabi [~fabi@i577BCD96.versanet.de] has joined #wesnoth-dev 20180702 20:09:34-!- fabi [~fabi@i577BCD96.versanet.de] has quit [Changing host] 20180702 20:09:34-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180702 20:11:48-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:95ca:55fc:315b:66c6] has joined #wesnoth-dev 20180702 21:00:16< Ravana_> is there any important difference between closing wesnoth with SIGINT, SIGTERM and SIGKILL? 20180702 21:03:23< irker544> wesnoth/wesnoth:1.14 ville bb29d008da Add an advanced preference item to sort AppVeyor: 2/4 builds failed 20180702 21:03:24< irker544> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4095 20180702 21:03:25< irker544> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-3809 20180702 21:06:39<+discordbot1> I don't think SIGKILL can be captured by the receiver. 20180702 21:06:58<+discordbot1> Handled they say. 20180702 21:07:48<+discordbot1> You could check the code for a treatment of SIGTERM, and likely there is not, but it could be. 20180702 21:08:27<+discordbot1> Why would you care? 20180702 21:10:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180702 21:10:15<+discordbot1> If the database is transactional, the transaction will just rollback somehow. 20180702 21:13:24<+discordbot1> SIGKILL cannot be handled. 20180702 21:14:31<+discordbot1> That's an actual POSIX requirement. If a process receives SIGKILL it's not supposed to be able to do anything about it and the OS must terminate it immediately without allowing any cleanup operations to take place. 20180702 21:15:48<+discordbot1> SIGINT is generated by a keyboard sequence on the attached terminal (e.g. CTRL-C) and I believe we currently handle that the same way as if the Close button on the game window was clicked. 20180702 21:16:28< Ravana_> none of those results in saving preferences, so when there is no difference, I can just use sigkill which is quickest 20180702 21:16:36<+discordbot1> So the first time it should ask for confirmation before quitting if in a game, and the second time it should quit normally if the confirmation prompt is up. 20180702 21:17:08<+discordbot1> If preferences aren't being saved that's that's a bug I'm afraid. 20180702 21:18:16<+discordbot1> Don't get into the habit of SIGKILLing programs just for the sake of it by the way. 20180702 21:18:58<+discordbot1> You will regret it sooner or later once the full extent of the "no cleanups" clause becomes relevant and obvious. 20180702 21:22:30<+discordbot1> As a trivial example, if the program is in the middle of writing something to disk you are almost guaranteed to cause data loss. 20180702 21:24:37<+discordbot1> If it acquires resources in a way that they are not bound to the process' lifetime (or the resource provider is not very smart, which happens sometimes with graphics drivers), those resources will not be released after the process terminates. 20180702 21:45:20< Ravana_> does flatpak version support using wesnoth -p? 20180702 21:54:25< Ravana_> seems it understand it must use different data path when I use --data-dir, but it doesn't take the new path 20180702 22:00:39< Ravana_> that might be pythons fault actually 20180702 22:08:16< Ravana_> seems the bug workaround I have been using doesn't work on linux 20180702 22:09:51< Ravana_> Macro/file 'FLY_DEFENSE' is missing 20180702 22:10:09< Ravana_> it doesn't get added to _MACROS_.cfg either 20180702 22:18:05< Ravana_> and that one too was caused by missing expanduser() 20180702 22:20:23< Ravana_> strange how some macro traces use full path and some use addon-relative path https://pastebin.com/sj6JiCzd 20180702 22:30:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180702 22:34:10-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:95ca:55fc:315b:66c6] has quit [Quit: Leaving] 20180702 22:41:28-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180702 22:45:36< irker544> wesnoth: josteph wesnoth:1.14 aae5057dbdc7 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05: Hide completed objectives. https://github.com/wesnoth/wesnoth/commit/aae5057dbdc741358ca2ff04cdfbe55dccb49757 20180702 22:45:38< irker544> wesnoth: josteph wesnoth:1.14 00c637d5df0c / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05: Merge all instances of [objectives]. https://github.com/wesnoth/wesnoth/commit/00c637d5df0c66fcf7263b18ab95f3effb2eec8b 20180702 22:48:24< irker544> wesnoth: josteph wesnoth:master f4ba5cbcb846 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05: Hide completed objectives. https://github.com/wesnoth/wesnoth/commit/f4ba5cbcb84684907e0617df763814016563eeaa 20180702 22:48:26< irker544> wesnoth: josteph wesnoth:master ea62caadf0b2 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05: Merge all instances of [objectives]. https://github.com/wesnoth/wesnoth/commit/ea62caadf0b23d61accf56f66611d4c781a424f1 20180702 22:55:24-!- Appleman1234 [~quassel@121.222.147.211] has joined #wesnoth-dev 20180702 22:59:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180702 23:13:11-!- travis-ci [~travis-ci@ec2-54-197-190-52.compute-1.amazonaws.com] has joined #wesnoth-dev 20180702 23:13:12< travis-ci> wesnoth/wesnoth#18781 (1.14 - 00c637d : josteph): The build was fixed. 20180702 23:13:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/399350933 20180702 23:13:12-!- travis-ci [~travis-ci@ec2-54-197-190-52.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180702 23:43:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180702 23:57:08< irker544> wesnoth/wesnoth:master Charles Dang e2fd9749a6 Re-enable the --new-widgets tests for ge AppVeyor: All builds passed --- Log closed Tue Jul 03 00:00:57 2018