--- Log opened Fri Jul 06 00:00:27 2018 20180706 00:06:12-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180706 00:17:08-!- Appleman1234 [~quassel@58.165.195.1] has joined #wesnoth-dev 20180706 00:41:14<+discordbot1> wait 20180706 00:41:15<+discordbot1> .... 20180706 00:41:22<+discordbot1> .....idea.. 20180706 00:41:49< celmin> ? 20180706 00:42:15<+discordbot1> i have an idea about the crash 20180706 00:42:48< celmin> Oh fun. 20180706 00:44:10<+discordbot1> damn 20180706 00:44:11<+discordbot1> didn't work 20180706 00:44:13<+discordbot1> ;_; 20180706 00:44:14< celmin> Aww. 20180706 00:48:00<+discordbot1> even worse i've gotten a cold 20180706 00:48:02<+discordbot1> somehow 20180706 00:48:06< celmin> :( 20180706 00:53:10<+discordbot1> I really got nothing 20180706 00:53:13<+discordbot1> nothing makes sense 20180706 00:53:18 * celmin hugs Vultraz 20180706 00:53:40<+discordbot1> thanks, but that doesn't fix the bug 😬 20180706 00:53:43< celmin> :P 20180706 00:56:57<+discordbot1> this is the line that crashes... 20180706 00:57:04<+discordbot1> cpp func(*dispatcher, event, handled, halt, std::forward(params)...); 20180706 00:57:17<+discordbot1> dispatcher here is corrupt 20180706 00:57:20<+discordbot1> random data 20180706 00:58:43< celmin> But not null? 20180706 00:59:15<+discordbot1> no 20180706 00:59:24<+discordbot1> and that persists up the stack 20180706 00:59:35< celmin> ? 20180706 00:59:44< celmin> What do you mean by "persists up the stack"? 20180706 01:00:21<+discordbot1> working up the callstack, that random data is still there 20180706 01:00:25<+discordbot1> it didn't get corrupted at that step 20180706 01:00:47< celmin> I get the impression that you might be misunderstanding something here. 20180706 01:00:58-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180706 01:00:59< celmin> But it could also be me who's misunderstanding something/ 20180706 01:01:32<+discordbot1> the bad widget is passed down the event pipeline 20180706 01:02:26<+discordbot1> it's definitely responding to the ENTER key 20180706 01:02:53< celmin> So you mean if you set a breakpoint right at the point where the event begins propagating… the widget is already bad there? 20180706 01:06:01-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Leaving] 20180706 01:06:14<+discordbot1> i didn't set a breakpoint but yeah 20180706 01:06:27< celmin> Then what did you do 20180706 01:06:43<+discordbot1> im just examining the call stack 20180706 01:06:47<+discordbot1> it's bad in dispatcher::fire 20180706 01:06:52<+discordbot1> and the previous frame is 20180706 01:06:54< celmin> "examining the call stack" 20180706 01:07:01<+discordbot1> sdl_event_handler::key_down 20180706 01:07:09<+discordbot1> I'm looking at it in VS 20180706 01:07:12< celmin> Yeah um. 20180706 01:07:13<+discordbot1> how is that confusing 20180706 01:07:16<+discordbot1> I have a debug build 20180706 01:07:22<+discordbot1> i produced the crash 20180706 01:07:24< celmin> I don't think that proves what you think it proves? 20180706 01:08:08<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/464598387694764042/unknown.png 20180706 01:08:12<+discordbot1> looks pretty broken to me 20180706 01:08:33< celmin> That's a snapshot of the call stack at the point when the crash occurred. 20180706 01:08:48<+discordbot1> no 20180706 01:08:49<+discordbot1> well 20180706 01:08:51<+discordbot1> ok? 20180706 01:08:53< celmin> I'm pretty sure it doesn't say anything about when the pointer became invalid? 20180706 01:09:08<+discordbot1> it doesn't? 20180706 01:09:20< celmin> Since it's invalid at the point of the rash, how on earth would going up the call stack suddenly make it valid? 20180706 01:09:32<+discordbot1> 🤔 20180706 01:09:35< celmin> ? 20180706 01:09:39<+discordbot1> :thonk: 20180706 01:09:54<+discordbot1> HMMMMMMMMMMMMMMMM 20180706 01:10:10<+discordbot1> well then how the hell do I find where it's broken 20180706 01:10:18< celmin> Basically - navigating up the call stack is not the same as navigating back in time. 20180706 01:10:28<+discordbot1> blah 20180706 01:10:29< celmin> I suggest setting breakpoints in places. 20180706 01:10:30<+discordbot1> ;_; 20180706 01:11:07<+discordbot1> ok, let's try 20180706 01:13:24<+discordbot1> INTERESTING 20180706 01:13:35< celmin> :O 20180706 01:13:38<+discordbot1> dispatcher::fire seems to be hit . 20180706 01:13:48<+discordbot1> 4 times for a key press 20180706 01:14:00<+discordbot1> first time after pressing enter, the target is the window 20180706 01:14:11<+discordbot1> the second time, the target is the input field (the text box) 20180706 01:14:15<+discordbot1> then the crash happens 20180706 01:14:50<+discordbot1> without it being hit again... 20180706 01:15:54<+discordbot1> let's see what gets hit for a regulat key resssssss 20180706 01:16:39<+discordbot1> ok, key is f 20180706 01:16:42<+discordbot1> first target 20180706 01:16:43<+discordbot1> the window 20180706 01:16:53<+discordbot1> second target, the text box 20180706 01:17:27<+discordbot1> third target... the window 20180706 01:17:31<+discordbot1> fourth target, the text box 20180706 01:18:05<+discordbot1> whaaa?? 20180706 01:19:23< celmin> Fun. 20180706 01:19:38< celmin> I guess that's the problem, huh? 20180706 01:21:39<+discordbot1> BUT WHY IS IT SO 20180706 01:22:06< celmin> Is one keydown and the other keyup? 20180706 01:23:07<+discordbot1> no, it's the same event i think 20180706 01:51:23<+discordbot1> 🤔 20180706 01:51:28< celmin> ? 20180706 01:59:56-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180706 02:25:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180706 02:30:02<+discordbot1> that emoji is :thinking: 20180706 02:30:08<+discordbot1> the one you keep missing out on 20180706 02:32:34< celticminstrel> It's the sort of emoticon that I would use a lot actually. 20180706 02:33:14<+discordbot1> come to discord, we have the thinking emoji 20180706 02:33:35< celticminstrel> Meh. 20180706 02:33:55<+discordbot1> we also have :thonk: 20180706 02:33:59< celticminstrel> Anyway it looks like it's in Unicode so I don't really need Discord to get a thinking emoji. 20180706 02:34:12< celticminstrel> I don't even know what thonk is (if you showed me before I forgot). 20180706 02:34:17<+discordbot1> :thonk: 20180706 02:34:28<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/464620117184086026/unknown.png 20180706 02:43:14<+discordbot1> :thonk: :thonk: :thonk: :thonk: 20180706 02:43:31<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/464622391545561088/bigthonker.jpg 20180706 02:44:13< celticminstrel> Yeah I can definitely live without thonk. 20180706 02:44:36<+discordbot1> sadness 20180706 02:50:46-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180706 02:56:27-!- gfg [~androirc@134.76.63.8] has quit [Ping timeout: 240 seconds] 20180706 03:12:20<+discordbot1> IT'S. TEXT. INPUT 20180706 03:12:38<+discordbot1> 😡 20180706 03:12:47<+discordbot1> text input can go to hell 20180706 03:13:04<+discordbot1> those 4 events? 20180706 03:13:18<+discordbot1> keydown, keydown, text input, text input 20180706 03:15:06<+discordbot1> why in hell do we do this 20180706 03:16:29<+discordbot1> @jyrkive you were right 20180706 03:20:06< celticminstrel> Um, so. 20180706 03:20:11<+discordbot1> though... 20180706 03:20:14< celticminstrel> Wouldn't the solution be to handle key up instead? 20180706 03:20:20<+discordbot1> it actually looks like they're supposed to separate... 20180706 03:20:22< celticminstrel> For the enter key that is. 20180706 03:20:37<+discordbot1> foo 20180706 03:20:40<+discordbot1> So what are you breaking this time? 20180706 03:20:41<+discordbot1> that's not consistent 20180706 03:20:51<+discordbot1> I mean fixing. 20180706 03:21:07<+discordbot1> gui2 "command console" 20180706 03:21:20<+discordbot1> (master only) 20180706 03:21:23<+discordbot1> crashes when you close it 20180706 03:21:23<+discordbot1> Ohhhhhhhhhhhkay good luck with that. 20180706 03:22:17<+discordbot1> I'm sure you'll figure out a way to fix it even if it involves lots of duct tape and rope. 20180706 03:22:19<+discordbot1> it worked when i first implemented it a year ago 20180706 03:22:37<+discordbot1> but the use of bloody text input apparently broke it since then 20180706 03:24:40< celticminstrel> Well, this isn't one of the situations where we could do away with textinput. 20180706 03:25:11< celticminstrel> Because you're typing. 20180706 03:25:18< celticminstrel> That's what textinput is for. 20180706 03:25:31< celticminstrel> I guess the enter key is triggering a textinput? 20180706 03:25:37< celticminstrel> Which makes sense if you think about it. 20180706 03:28:40<+discordbot1> sadly, reverting https://github.com/wesnoth/wesnoth/commit/5d9cd6d4851de73e1691ea563f86ace3693a0595 doesn't fix it 20180706 03:29:33<+discordbot1> was really hoping it would 20180706 03:30:53<+discordbot1> celmin: and ESC? 20180706 03:31:09< celticminstrel> Well, it's very unlikely that that would yield textinput. 20180706 03:31:19<+discordbot1> LET US SEE 20180706 03:31:43< celticminstrel> It does have a Unicode representation, mind you. 20180706 03:31:46< celticminstrel> 0x07 IIRC 20180706 03:32:20< celticminstrel> No that's bell, what was it then... 20180706 03:32:55< celticminstrel> 0x1b apparently 20180706 03:33:44<+discordbot1> I'm curious why no-one thought of that when designing the WML archive format. 20180706 03:34:07< celticminstrel> But it's not a printable character so I wouldn't expect it to trigger a textinput... on the other hand, IIRC backspace triggers a textinput despite not being printable... 20180706 03:34:15<+discordbot1> it doesn't seem to 20180706 03:34:21<+discordbot1> (This, to be specific: https://wiki.wesnoth.org/CampaignServerWML#Archive_format ) 20180706 03:34:21<+discordbot1> instead, it seems to trigger 3 keydowns 20180706 03:34:26< celticminstrel> @shadowm You mean about it being nonprintable? I'd just assume they weren't worried about it. 20180706 03:34:53<+discordbot1> No, about using ESCAPE instead of START OF HEADING. 20180706 03:35:12< celticminstrel> Where exactly? 20180706 03:35:19<+discordbot1> See the link above. 20180706 03:35:27< celticminstrel> They're using START OF HEADING. 20180706 03:35:32<+discordbot1> Yes. 20180706 03:35:40< celticminstrel> You think they should've used ESCAPE? 20180706 03:35:41<+discordbot1> Hello. 20180706 03:35:44<+discordbot1> Yeah. 20180706 03:35:47< celticminstrel> Why? 20180706 03:36:00<+discordbot1> Because it's literally a escape sequence. 20180706 03:36:12< celticminstrel> Oh, I suppose. 20180706 03:37:08<+discordbot1> anyway, I have no fix for this 20180706 03:37:35< celticminstrel> Aw. 20180706 03:38:04< celticminstrel> Well, you got some useful data, at least. 20180706 04:01:45-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180706 04:10:27<+discordbot1> I see "jamming" referenced in various places in the code, though I've never seen it in game. I see A unit can feature some jamming ability, the attribute jamming = is similar to vision But what exactly is it? 20180706 04:11:12<+discordbot1> I think it's inverse vision. 20180706 04:11:32<+discordbot1> Not sure though. It was the creation of somebody who's been inactive since ages ago. 20180706 04:12:08<+discordbot1> I literally don't see it anywhere, so maybe I'll just pretend it doesn't exist. 20180706 04:12:20<+discordbot1> Are you working with code that involves supporting it? 20180706 04:12:36<+discordbot1> It's referenced in help_topic_generators.cpp 20180706 04:12:40<+discordbot1> Because if so it might prove more productive to file a bug and let someone who's actually interested in it to figure it out. 20180706 04:13:22<+discordbot1> It comes up in the code I'm working on for https://github.com/wesnoth/wesnoth/pull/3305 20180706 04:15:06<+discordbot1> Does reading the commit that introduced it help? https://github.com/wesnoth/wesnoth/commit/fbbfadfc6b8cc6ba1323a5fd7b7908f0c98e1d25 20180706 04:16:17<+discordbot1> 20120508 02:08:08< jamit> What does the jamming do? 20120508 02:08:17< fendrin> it jams :-) 20120508 02:09:04< fendrin> jamit: http://forums.wesnoth.org/viewtopic.php?p=527926#p527926 20180706 04:17:42<+discordbot1> You can see more of the conversation here: https://www.wesnoth.org/irclogs/2012/05/%23wesnoth-dev.2012-05-08.log 20180706 04:18:12<+discordbot1> Looks like it's related to fog? 20180706 04:18:31<+discordbot1> Fog and shroud just like vision, yes. 20180706 04:19:33<+discordbot1> Sounds cool, guess I'll acknowledge its existence. 20180706 04:19:38<+discordbot1> How did you search those up so quickly, by the way? 20180706 04:20:15<+discordbot1> I did git log, searched for jamming until I found the earliest commit referencing it. 20180706 04:20:25<+discordbot1> In the commit message itself, that is. 20180706 04:21:12<+discordbot1> And since the commit date is included in the command's output the rest is just me entering numbers into my address bar. 20180706 04:21:33<+discordbot1> Ahh alright, thanks. 20180706 04:35:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 04:35:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 05:42:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 05:42:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 05:55:54-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 05:55:54-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 05:55:54-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 06:07:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180706 06:15:41-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180706 06:32:14-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 06:32:14-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 06:32:14-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 06:34:01<+discordbot1> @jyrkive do you have any idea what to do about the keydown/textinput prob;em? 20180706 06:34:58<+discordbot1> It's obvious. 20180706 06:35:05<+discordbot1> The text input is a separate event. 20180706 06:35:40<+discordbot1> When it's dispatched, the GUI2 event dispatch system should not pass it to dispatchers which have already been destroyed. 20180706 06:36:00<+discordbot1> In fact, it's a bug that it's passed to the destroyed window. 20180706 06:36:36<+discordbot1> I think we're caching the dispatcher in a local variable or something, instead of rechecking the dispatchers_ vector. 20180706 06:36:46<+discordbot1> well I'm sorry, it's not obvious to me 😐 20180706 06:37:24<+discordbot1> I spent hours looking at this 20180706 06:37:38<+discordbot1> Well, it may be more clear if you think about a more extreme example. 20180706 06:37:49<+discordbot1> Say, if a window is destroyed, and the player presses A five hours later. 20180706 06:38:03<+discordbot1> Is the keypress passed to the destroyed window? Of course not. 20180706 06:40:36<+discordbot1> that's true... 20180706 06:47:11<+discordbot1> well 20180706 06:47:15<+discordbot1> hmm 20180706 06:47:23<+discordbot1> yeah, that seems like it could be the only thing 20180706 06:47:38<+discordbot1> the widget is removed from dispatchers_ in its dtor 20180706 07:40:06-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180706 07:48:51-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180706 07:56:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 07:56:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 08:14:27-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 240 seconds] 20180706 08:34:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180706 08:43:52-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 08:43:52-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 08:43:52-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 08:45:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180706 09:15:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 09:15:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 09:27:23-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180706 09:43:30-!- irker330 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180706 09:43:30< irker330> wesnoth/wesnoth:master newfrenchy83 5be574958d Update attack.cpp AppVeyor: vs2017/Release Failed 20180706 09:43:31< irker330> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3853 20180706 09:48:00-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180706 10:07:18-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 10:07:18-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 10:07:18-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 10:23:14< irker330> wesnoth/wesnoth:master DisherProject be8fd3bec8 DM: add some TODOs AppVeyor: vs2015/Release Failed 20180706 10:23:15< irker330> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4139 20180706 10:33:51-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 256 seconds] 20180706 10:35:52-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180706 10:45:15<+discordbot1> ya know, the more I look at this it seems like the problem might be at the place events are fired itself... 20180706 10:45:20<+discordbot1> ie, in the execution of event 2 20180706 10:45:25<+discordbot1> not the beginning of even 3 20180706 10:46:06<+discordbot1> What do you mean? 20180706 10:46:56<+discordbot1> If the game survives event 2 and crashes while attempting to handle event 3, it would be logical to determine that the handling of event 3 is incorrect. 20180706 10:48:18<+discordbot1> SEH key down main handling SEH key down SUB handling returning dispatcher wants keyboard focus cc ikpc handling command callback end window dor disconnecting dispatcher: Caught general 'class std::bad_function_call' exception: bad function call Press enter to continue... Look at this. It's showing the ENTER event is handling, the dialog callback run, the console command callback run, the window widget destroyed and removed from 20180706 10:48:18<+discordbot1> the dispatcher list.. and then the crash. And I know the crash is in event::implementation::fire_event. So the lack of any more SDL event handling shows it must be while the loop is being run through for event 2. Ie, It does not entirely survive event 2... 20180706 10:48:58<+discordbot1> its dispatcher pointer now points to garbage data. 20180706 10:49:02<+discordbot1> likely 20180706 10:49:08<+discordbot1> but there's no way to check that 😐 20180706 10:51:32<+discordbot1> let me add a breakpoint right before the crash to confirm this... 20180706 10:52:52<+discordbot1> In that case I don't follow what the issue has to do with text input events. 20180706 10:53:51<+discordbot1> I may have been mistaken 20180706 10:54:20-!- Appleman1234 [~quassel@58.165.195.1] has quit [Ping timeout: 260 seconds] 20180706 10:55:47<+discordbot1> Hmm. It's indeed possible that an event dispatcher code (or the calling code) isn't able to handle when an event dispatcher destroys itself. 20180706 10:56:46<+discordbot1> both widget pointers here (in implementation::fire_event) at the time of the crash seem corrupted. 20180706 11:13:53<+discordbot1> ....this makes no sense 20180706 11:14:28<+discordbot1> I set a breakpoint here https://github.com/wesnoth/wesnoth/blob/master/src/gui/core/event/dispatcher_private.hpp#L318 20180706 11:14:31<+discordbot1> it's triggered 20180706 11:14:48<+discordbot1> yet if i continue, the crash happens, and it says line 317 is the next bit of code to be executed 20180706 11:14:55<+discordbot1> how is that even possible 20180706 11:15:35<+discordbot1> Continue? Instead of step over? 20180706 11:15:49<+discordbot1> yes 20180706 11:16:33<+discordbot1> "Continue" allows the game to run freely. Most likely it finishes handling the event, starts handling the next event, and crashes in line 315. 20180706 11:16:39<+discordbot1> handled and halt are true when my breakpoint was hit...but now they're false 20180706 11:16:42<+discordbot1> so that must be so 20180706 11:18:12<+discordbot1> So fire_event() returned in between, but was then re-entered for the next event. 20180706 11:18:29<+discordbot1> right... so that would seem to indicate it indeed breaks in event 3... 20180706 11:18:47<+discordbot1> but that seems to break my previous testing... 20180706 11:21:08<+discordbot1> the event that crashes is indeed a SDL_KEY_DOWN event (the GUI2 event enum, not the SDL enum) 20180706 11:24:20<+discordbot1> I'm really at a loss. Checking the call stack shows it's an SDL_KEYDOWN (SDL enum) event, too, just to double-confirm.... 20180706 11:24:27<+discordbot1> that means my earlier testing was wrong 20180706 11:24:44<+discordbot1> ENTER and ESC must both fire 4 key down events 20180706 11:24:54<+discordbot1> as opposed to the 2 key down, 2 text input for character keys 20180706 11:25:24-!- grzywacz [~karol@host-93.179.231.1.static.3s.pl] has joined #wesnoth-dev 20180706 11:25:49<+discordbot1> but then why did no logging show up for the third event... 20180706 11:26:43<+discordbot1> any new key down event from sdl should have triggered the cerr logging in either of the sdl_event_handler::key_down overloads 20180706 11:27:02<+discordbot1> but it doesn 20180706 11:27:04<+discordbot1> 't 20180706 11:27:05<+discordbot1> 😐 20180706 11:28:50<+discordbot1> And if it is the third event, nothing should execute on it since the window removed itself from the dispatcher list 20180706 11:29:19<+discordbot1> And also unconditionally clearing the keyboardfocus ptr doesn’t help 20180706 12:02:43-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180706 12:24:12-!- Guest64119 [uid51591@gateway/web/irccloud.com/x-jzhzflzgyxmicqnp] has joined #wesnoth-dev 20180706 12:24:37-!- Guest64119 [uid51591@gateway/web/irccloud.com/x-jzhzflzgyxmicqnp] has quit [Client Quit] 20180706 12:25:43-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180706 12:31:35-!- grzywacz [~karol@host-93.179.231.1.static.3s.pl] has quit [Quit: Lost terminal] 20180706 12:46:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 12:46:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 13:23:27-!- irker330 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180706 13:27:38-!- irker276 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180706 13:27:38< irker276> wesnoth/wesnoth:1.14 ville 122c32a12c Sort alphabetically / by ascending movem AppVeyor: All builds passed 20180706 13:42:08< irker276> wesnoth/wesnoth:master newfrenchy83 d1e1b9f41f Update attack.cpp AppVeyor: vs2015/Release Failed 20180706 13:42:09< irker276> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4141 20180706 14:43:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180706 14:43:30< irker276> wesnoth/wesnoth:master newfrenchy83 5be574958d Update attack.cpp AppVeyor: 2/4 builds failed 20180706 14:43:31< irker276> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3853 20180706 14:43:32< irker276> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4138 20180706 15:13:00< irker276> wesnoth/wesnoth:master newfrenchy83 43a03667f1 Update attack.cpp AppVeyor: vs2017/Release Failed 20180706 15:13:01< irker276> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3857 20180706 15:22:48-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180706 15:23:14< irker276> wesnoth/wesnoth:master DisherProject be8fd3bec8 DM: add some TODOs AppVeyor: 1/4 builds failed 20180706 15:23:15< irker276> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4139 20180706 15:24:26-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 15:24:26-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 15:24:26-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 15:24:32-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Client Quit] 20180706 15:26:06-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 15:26:06-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 15:26:06-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 16:07:05-!- DeFender1031 [~DeFender1@93-173-122-186.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180706 16:21:57-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180706 16:22:02< Ravana_> curious how going to chat log page 1 scrolls it to bottom, but going to any other page scrolls it to top 20180706 16:40:03-!- Appleman1234 [~quassel@58.165.195.1] has joined #wesnoth-dev 20180706 16:40:48-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180706 17:20:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180706 18:06:05-!- Appleman1234 [~quassel@58.165.195.1] has quit [Ping timeout: 240 seconds] 20180706 18:12:38-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has joined #wesnoth-dev 20180706 18:12:38-!- fabi [~fabi@mue-88-130-62-183.dsl.tropolys.de] has quit [Changing host] 20180706 18:12:38-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180706 18:24:44-!- irker276 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180706 18:42:15-!- irker359 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180706 18:42:15< irker359> wesnoth/wesnoth:master newfrenchy83 d1e1b9f41f Update attack.cpp AppVeyor: 2/4 builds failed 20180706 18:42:15< irker359> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4141 20180706 18:42:15< irker359> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3856 20180706 19:04:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 19:04:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 19:29:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 19:29:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 19:33:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180706 19:53:26< irker359> wesnoth: Jyrki Vesterinen wesnoth:1.14 ec54b761bc18 / src/attack_prediction.cpp: Damage prediction: round very close slow probabilities to 0 or 1 https://github.com/wesnoth/wesnoth/commit/ec54b761bc1868451984c6582cc8a88a57e691de 20180706 19:55:33< irker359> wesnoth: Jyrki Vesterinen wesnoth:master 00d8548c24a7 / src/attack_prediction.cpp: Damage prediction: round very close slow probabilities to 0 or 1 https://github.com/wesnoth/wesnoth/commit/00d8548c24a70365f1b02116e129c8835dff206a 20180706 20:13:00< irker359> wesnoth/wesnoth:master newfrenchy83 43a03667f1 Update attack.cpp AppVeyor: 2/4 builds failed 20180706 20:13:01< irker359> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3857 20180706 20:13:02< irker359> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4142 20180706 20:20:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180706 20:29:18-!- Appleman1234 [~quassel@121.222.11.31] has joined #wesnoth-dev 20180706 20:32:22< irker359> wesnoth: Severin Glöckner wesnoth:1.14 1b2a6b96c121 / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG 04: Better implementation to protect the magican https://github.com/wesnoth/wesnoth/commit/1b2a6b96c12196c9b5b24e6284695818a3a9bc6d 20180706 20:33:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180706 20:33:37< irker359> wesnoth: Severin Glöckner wesnoth:master 7ea951d5b9cf / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG 04: Better implementation to protect the magican https://github.com/wesnoth/wesnoth/commit/7ea951d5b9cf36986c51d1d8d603bc87ae559286 20180706 20:36:34-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180706 20:47:39-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180706 21:02:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20180706 21:32:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180706 21:32:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180706 21:35:04< Ravana_> is there any way to use 1.13 builtin version check to achieve these requirements https://github.com/ProditorMagnus/Ageless-for-1-14/issues/7 ? it is not compatible enough to use addon_min_version, but is compatible enough that only some oos is expected when observing 20180706 21:35:17< Ravana_> could be covered by https://github.com/wesnoth/wesnoth/issues/2324 20180706 21:57:59< irker359> wesnoth/wesnoth:master newfrenchy83 4a8fcb4a19 Update attack.cpp AppVeyor: All builds passed 20180706 22:00:22-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180706 22:00:28< Ravana_> actually, I don't even manage to have addon_min_version work 20180706 22:00:34-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180706 22:01:41< Ravana_> after adding addon_min_version="0.0.0" still can't observe 20180706 22:23:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180706 22:25:14< Ravana_> tried to ignore that error, compiling 20180706 22:28:38<+discordbot1> I really don't know 20180706 22:30:27<+discordbot1> where did you put it? 20180706 22:56:47< Ravana_> tried it in [info], in [era], and in toplevel 20180706 22:59:15< Ravana_> adding accidental symbol to cpp file results in huge amount of error messages 20180706 22:59:26< Ravana_> seems scons was not smart enough to stop after first syntax error 20180706 23:05:17< Ravana_> changing cpp file worked, now I can observe games 20180706 23:33:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180706 23:48:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180706 23:53:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Sat Jul 07 00:00:29 2018