--- Log opened Sat Jul 07 00:00:29 2018 20180707 00:10:25<+discordbot1> how? 20180707 00:11:43< celticminstrel> ? 20180707 00:12:11<+discordbot1> how did you edit source 20180707 00:12:44< celticminstrel> ? 20180707 00:13:04<+discordbot1> did you just show up? 20180707 00:13:12< celticminstrel> Yes. 20180707 00:13:18< celticminstrel> The first thing I see is "how?" 20180707 00:13:19<+discordbot1> " changing cpp file worked, now I can observe games" 20180707 00:13:46< celticminstrel> I assume he means he rebuilt it? 20180707 00:14:40<+discordbot1> I don't know what he's doing 20180707 00:18:07<+discordbot1> also i still have no fix for that thing 20180707 00:18:11<+discordbot1> the console thing 20180707 00:18:27-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180707 00:18:55< celticminstrel> Aw. 20180707 00:19:10< celticminstrel> Maybe I can get back to the schema stuff this weekend, it's quite a bit cooler today. 20180707 00:19:48-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180707 00:23:26<+discordbot1> I can't fix the issue because i can't even track down where it breaks 20180707 00:26:27<+discordbot1> it's not that handled and halt don't work 20180707 00:26:28<+discordbot1> they do 20180707 00:26:37<+discordbot1> but then it comes back around and tries to execute another event 20180707 00:26:55<+discordbot1> even though it shouldn't be able to since the window should have been removed from the dispatchers list 20180707 00:34:49< Ravana_> I made this change https://github.com/ProditorMagnus/Ageless-for-1-14/issues/7 20180707 00:35:03< Ravana_> so that higher version can join game hosted by lower version 20180707 00:37:03<+discordbot1> why would you want that 20180707 00:37:12<+discordbot1> the host doesn't have an up-to-date copy 20180707 00:37:49< Ravana_> because I want to observe that game 20180707 00:38:25< Ravana_> oos, even complete oos where no units are in correct places, is good enough 20180707 00:39:21< Ravana_> otherwise I would need to change _info.cfg and reload wml every time 20180707 00:39:36<+discordbot1> whose game? 20180707 00:40:15< Ravana_> cenario="Etherdrifter\xe2\x80\x99s game" 20180707 00:40:41<+discordbot1> why do you want to observe this game 20180707 00:41:13< Ravana_> because I like observing games that use my addons 20180707 00:41:51<+discordbot1> at the cost of OOS... 20180707 00:42:20< Ravana_> 4.20 and 4.21 are very similar 20180707 00:42:34< Ravana_> only few units have oos worthy changes 20180707 00:42:52<+discordbot1> I should really add some mechanism to force people to update their addons before they can host a game with them 20180707 00:45:32< irker359> wesnoth/wesnoth:1.14 ville 36015b0630 Move comparison structs to lambda's AppVeyor: All builds passed 20180707 00:46:10< celticminstrel> Maybe it's not yet removed? Or maybe those events are somehow already queued up? 20180707 00:46:32< celticminstrel> In some way that wouldn't matter whether it's already removed from the list. 20180707 00:48:08<+discordbot1> then WHERE 20180707 00:48:20< celticminstrel> I don't know. 20180707 00:50:07<+discordbot1> I'd think it might have to do with the event_chain but no, there's nothing there that would call fire_event again 20180707 01:01:45<+discordbot1> would be really useful if I had some tool to walk back the program state 20180707 01:05:42<+discordbot1> You mean like a... debugger? 20180707 01:07:30<+discordbot1> nevermind 20180707 01:09:53<+discordbot1> hMMMMMM 20180707 01:11:17<+discordbot1> the distributor is involved with event 2 20180707 01:13:01<+discordbot1> which is bad 20180707 01:13:06<+discordbot1> that class is black magic 20180707 01:13:27< celticminstrel> It's not involved with the other events? 20180707 01:13:52< celticminstrel> Isn't the distributor basically responsible for dispatching events to the widget that holds keyboard focus? 20180707 01:14:23< celticminstrel> Maybe I'm getting the classes mixed up, I dunno. 20180707 01:14:24<+discordbot1> maybe? 20180707 01:14:28<+discordbot1> I don't understand it 20180707 01:14:41-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 248 seconds] 20180707 01:14:53<+discordbot1> events 1 and 3 take the straightforward path through the dispatcher 20180707 01:15:16<+discordbot1> ie, get SDL event, fire the appropriate UI event 20180707 01:15:25-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180707 01:15:36<+discordbot1> but event 2 involves the ditributor... 20180707 01:15:39<+discordbot1> and signal_handler_sdl_key_down 20180707 01:28:35<+discordbot1> there's an absolutely massive textwall of documentation here... 20180707 01:28:39<+discordbot1> but it's confusing >_> 20180707 02:16:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180707 02:17:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180707 02:24:47-!- Appleman1234 [~quassel@121.222.11.31] has quit [Ping timeout: 245 seconds] 20180707 02:39:27< irker359> wesnoth/wesnoth:1.14 Severin Glöckner 1b2a6b96c1 TSG 04: Better implementation to protect AppVeyor: All builds passed 20180707 04:36:34-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 268 seconds] 20180707 05:21:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180707 05:21:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180707 05:25:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180707 05:40:56-!- irker359 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180707 05:43:39-!- irker262 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180707 05:43:39< irker262> wesnoth/wesnoth:master Severin Glöckner 7ea951d5b9 TSG 04: Better implementation to protect AppVeyor: All builds passed 20180707 05:51:56-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving] 20180707 06:02:49-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev 20180707 06:27:57<+discordbot1> @jyrkive recursively? 🤔 well that’s not good... 20180707 06:29:14<+discordbot1> I have an idea about a possible fix. (We simply need to set handled and halt to true in the outer event handler as well.) 20180707 06:29:46<+discordbot1> Not sure if it's the right thing to do, though. We may want to continue to run the other event handlers (if any) if we can. 20180707 06:31:51<+discordbot1> Yes, it fixes the crash you're getting. Although tah game still crashes, just in a different place. 20180707 07:01:17<+discordbot1> hmmmm... your patch looks pretty specialized to this specific case of keyboard callbacks. Not sure if it's needed in other areas of the distributor? 20180707 07:03:50<+discordbot1> Yeah, I just threw together something that fixes this specific crash. 20180707 07:09:58<+discordbot1> Thanks for looking at this, tho. I’ll see what I can do with the patch. 20180707 07:13:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180707 07:25:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180707 08:31:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180707 08:42:09-!- kallaballa [~amir@62.178.166.233] has joined #wesnoth-dev 20180707 08:42:35-!- kallaballa [~amir@62.178.166.233] has quit [Client Quit] 20180707 08:45:22-!- irker262 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180707 10:31:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20180707 10:31:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180707 10:32:36-!- stikonas_ is now known as stikonas 20180707 10:42:49<+discordbot1> When will be the string freeze today? 20180707 10:49:21-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180707 10:58:24<+discordbot1> Probably 20180707 11:08:05-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 11:08:05-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 11:08:05-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 11:55:56-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180707 12:12:36-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 12:12:36-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 12:12:36-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 12:18:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180707 12:18:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180707 12:19:57-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180707 12:21:57-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 12:21:57-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 12:21:57-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 12:22:30-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180707 12:34:39-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 12:34:39-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 12:34:39-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 12:43:27-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180707 12:45:28-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 12:45:28-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 12:45:29-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 12:46:32-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Client Quit] 20180707 12:51:31-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 12:51:31-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 12:51:31-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 13:18:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180707 13:20:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180707 13:42:42-!- Appleman1234 [~quassel@121.222.11.31] has joined #wesnoth-dev 20180707 14:24:15-!- Appleman1234 [~quassel@121.222.11.31] has quit [Ping timeout: 268 seconds] 20180707 14:54:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180707 15:27:08< Ravana_> should wesnoth/wesnoth repository topics include "wesnoth"? 20180707 15:39:50-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 260 seconds] 20180707 15:57:32-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20180707 15:59:07-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180707 15:59:29-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 15:59:29-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 15:59:30-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 16:04:33-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 264 seconds] 20180707 16:20:35-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180707 16:21:05-!- irker122 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180707 16:21:05< irker122> wesnoth/wesnoth:1.14 josteph 2ed5a4e974 THoT S7: Select Darchas so the narrator' AppVeyor: All builds passed 20180707 16:21:05-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: No Ping reply in 180 seconds.] 20180707 16:22:15-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20180707 16:23:47-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 16:23:49-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 16:23:49-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 16:26:30<+discordbot1> topic as in a forum topic? 20180707 16:33:33< Ravana_> no, github repository topic 20180707 16:34:22< celticminstrel> Oh, the summary? 20180707 16:34:22<+discordbot1> I think it wouldn't make any sense to add such a repository topic. 20180707 16:34:40< celticminstrel> Do you mean the summary that appears at the top of the main repo page? 20180707 16:34:48<+discordbot1> If someone wants to find the Wesnoth repository, it's wesnoth/wesnoth. Couldn't be simpler. 20180707 16:35:18< celticminstrel> Still not sure what we're actually talking about here... 20180707 16:37:17< Ravana_> only for finding other repositories that have this topic 20180707 16:39:06<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/465195060737343539/repo-topics.png 20180707 16:39:20<+discordbot1> celticminstrel: I think those are what we're talking about. 20180707 16:42:49< celticminstrel> Ohhh. I'd call those tags, not topics, but okay. 20180707 16:43:59<+discordbot1> If you click (or hover, depending on browser), you can see that they have URLs like https://github.com/topics/opensource 20180707 16:44:06< celticminstrel> Ah. 20180707 16:44:35<+discordbot1> (And for that matter, "opensource" is a rather strange topic. Every public GitHub project is open source. It's implied.) 20180707 16:45:05< celticminstrel> XD 20180707 16:45:10< celticminstrel> Is it though? 20180707 16:46:47< Ravana_> some repositories could only have issues, documentation, or some other parts 20180707 16:47:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180707 16:50:09<+discordbot1> Hmm. I took a closer look at the GitHub ToS, and it looks like they indeed don't require public projects to be open source, even for non-paying users. 20180707 16:50:10<+discordbot1> https://help.github.com/articles/github-terms-of-service/#d-user-generated-content 20180707 16:50:48<+discordbot1> So it would be technically allowed to store e.g. intermediate code in a GitHub repository instead of the original source code. 20180707 16:51:25<+discordbot1> Although the situation is still that nearly every public GitHub project is open source. 20180707 16:52:52< celticminstrel> Some of mine aren't. 20180707 16:53:29< celticminstrel> I think there was one I just put up as a sample to show someone, for example. 20180707 16:53:57<+discordbot1> Got a link? 20180707 16:54:29< celticminstrel> And technically my Wesnoth addon's repo isn't open ATM (though that's more because I haven't chosen a license, it will probably be open eventually). 20180707 16:55:00< celticminstrel> The first one I mentioned should be obvious just from looking at my profile, it has WIP in the repo name. 20180707 16:55:41<+discordbot1> Even without a license, you still grant everyone the right to view the source code and fork the repository, as per GitHub ToS D.5. 20180707 16:55:46< celticminstrel> Right. 20180707 16:55:55<+discordbot1> So I'd argue that it is open source. 20180707 17:00:33< celticminstrel> That forking requirement seems kinda questionable huh... 20180707 17:01:05< celticminstrel> Not sure if it's quite enough to claim it's open source, but I definitely see what you mean. 20180707 17:01:40< celticminstrel> I should probably take down that WIP one anyway, it doesn't really need to be there. 20180707 17:05:28< celticminstrel> Done. Along with a couple obsolete forks. 20180707 17:39:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180707 17:45:08-!- DeFender1031 [~DeFender1@93-173-122-186.bb.netvision.net.il] has joined #wesnoth-dev 20180707 17:52:14-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180707 17:55:51-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has joined #wesnoth-dev 20180707 17:55:51-!- fabi [~fabi@mue-88-130-62-185.dsl.tropolys.de] has quit [Changing host] 20180707 17:55:51-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20180707 18:22:23-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180707 18:37:27-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 240 seconds] 20180707 19:14:59-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180707 19:21:58-!- irker122 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180707 19:24:20< celticminstrel> So @lilinitsy is that PR finished AFAYK? 20180707 19:25:10-!- gfgtdf [~chatzilla@x4e3375ac.dyn.telefonica.de] has joined #wesnoth-dev 20180707 19:25:56< gfgtdf> does anyone know how unit.loc is supposed to be used? local loc = {unit.loc} doesnt seem to work as expected 20180707 19:26:36< celticminstrel> gfgtdf: Well for starters, "local x,y = unit.loc" should work, right? 20180707 19:26:45< celticminstrel> Does that work? 20180707 19:26:49< gfgtdf> no 20180707 19:26:55< celticminstrel> Huh... 20180707 19:27:08< celticminstrel> Okay, what do you get when you write "unit.loc" in the Lua console? 20180707 19:27:31< gfgtdf> the x value 20180707 19:27:39< celticminstrel> ... 20180707 19:28:56< celticminstrel> The implementation looks correct to me... https://github.com/wesnoth/wesnoth/blob/master/src/scripting/lua_unit.cpp#L277 20180707 19:29:33<+discordbot1> I think a table lookup isn't allowed to return multiple values. 20180707 19:29:38< celticminstrel> Why not? :( 20180707 19:30:06< celticminstrel> Didn't that work before? 20180707 19:30:08<+discordbot1> It would violate how regular Lua tables work. 20180707 19:30:15< celticminstrel> How so? 20180707 19:30:34< celticminstrel> Did unit.loc exist in 1.12, I can't remember... 20180707 19:30:43<+discordbot1> http://www.lua.org/manual/5.3/manual.html#2.4 20180707 19:31:03<+discordbot1> "Despite the name, the metamethod for this event can be either a function or a table. If it is a function, it is called with table and key as arguments, and the result of the call (adjusted to one value) is the result of the operation." 20180707 19:32:10< celticminstrel> http://www.lua.org/manual/5.2/manual.html#2.4 20180707 19:32:22< celticminstrel> Looks like that's a change from 5.2? 20180707 19:32:40<+discordbot1> No, it doesn't. 20180707 19:32:56<+discordbot1> The 5.2 pseudocode has parentheses around the function call. 20180707 19:33:04< celticminstrel> Hmm, okay. 20180707 19:33:13<+discordbot1> IIRC,. parentheses throw away all values except the first. 20180707 19:34:01< celticminstrel> Annoying. 20180707 19:34:18<+discordbot1> But consistent with normal tables. 20180707 19:34:27<+discordbot1> IMO, it's the right decision. 20180707 19:34:30< celticminstrel> I don't see why it needs to be consistent with normal tables. 20180707 19:34:50< celticminstrel> In fact, I don't see why it couldn't make sense to even allow unit.loc = 5, 7 20180707 19:37:23< celticminstrel> Looks like unit.loc was added 8 years ago by Crab of all people. 20180707 19:37:28< celticminstrel> https://github.com/wesnoth/wesnoth/commit/a6ba907523032f623aeffd845520e564e7a6901c 20180707 19:37:43-!- irker610 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180707 19:37:43< irker610> wesnoth/wesnoth:1.14 josteph 3a87a95ced UI: Prefix tooltips with what kind of in AppVeyor: All builds passed 20180707 19:38:11< celticminstrel> So it was in version 1.10. Surely it's not possible that it has been broken this entire time? 20180707 19:39:27<+discordbot1> wait what? 20180707 19:40:29<+discordbot1> oh 20180707 19:40:33<+discordbot1> he added it to get 20180707 19:40:36<+discordbot1> I added it to set 20180707 19:40:37<+discordbot1> https://github.com/wesnoth/wesnoth/commit/883b4f1856a835173ce61b774a0e54ecd26c5b60 20180707 19:40:45<+discordbot1> didnt even realize it was an existing key in get 20180707 19:40:59< celticminstrel> Did you test it works there? 20180707 19:41:08<+discordbot1> yes 20180707 19:41:18< celticminstrel> Oh, but only as unit.loc = {x,y} right? 20180707 19:41:38<+discordbot1> yes? 20180707 19:41:55<+discordbot1> as opposed to? 20180707 19:42:26< celticminstrel> ... 20180707 19:42:43< celticminstrel> Okay testing on 1.12 suggests it doesn't work. I don't have 1.10 handy to try that too though... 20180707 19:43:53< celticminstrel> @Vultraz, as opposed to unit.loc = x,y 20180707 19:44:15<+discordbot1> Oh. Yeah, I think you said that wouldn’t work 20180707 19:44:47< celticminstrel> So the way it currently is, even if unit.loc worked for read, unit1.loc = unit2.loc would not work. 20180707 19:44:56< celticminstrel> So that's obviously bad. 20180707 19:45:21< celticminstrel> I wonder if anyone has blindly used unit.loc without realizing it's broken... 20180707 19:46:02< celticminstrel> Okay, I have 1.10.7 now to try it. 20180707 19:47:42< celticminstrel> IMO it would be nicer if locations were an actual userdata type rather than just a bare table with conventions. 20180707 19:48:16< celticminstrel> Though I think we'd always need to accept all the forms we already accept, so maybe it's not really worth the extra effort. 20180707 19:48:49< celticminstrel> Presumably this thing will remember my ancient 1.10 settings that are still hanging around in my preferences folder... >_> 20180707 19:49:27< celticminstrel> Whoa I actually forgot the main menu used to look like this. 20180707 19:49:50< celticminstrel> Still has the campaign wreathes! \o/ 20180707 19:50:05< celticminstrel> HTTT, AToTB, AOI, TSG, and DW. 20180707 19:51:18< celticminstrel> Let me just compare this to a function in vanilla Lua to make sure my test is actually valid... 20180707 19:52:17<+discordbot1> Why can’t unit.loc return a table? 20180707 19:53:46< celticminstrel> Yeah, seems like the test was valid; unit.loc didn't even work in 1.10 20180707 19:53:57< celticminstrel> FTR @jyrkive I tested with :lua wesnoth.message(wesnoth.get_units({side=1,canrecruit=true})[1].loc) 20180707 19:53:57<+discordbot1> ANCIENT BUG 20180707 19:54:01< celticminstrel> That seems correct, right? 20180707 19:54:21<+discordbot1> Looks valid to me. 20180707 19:54:24< celticminstrel> If unit.loc returning multiple values worked, you'd get "<9> 6" or the like in chat. 20180707 19:54:29< celticminstrel> But I get " 9". 20180707 19:55:03< celticminstrel> (This is because wesnoth.message has an optional parameter, if present the first is the name and the second is the actual message.) 20180707 19:55:33< celticminstrel> Given that it was always broken, I think what @Vultraz said is fine - making it return a table. 20180707 19:55:42< celticminstrel> Preferably using luaW_pushlocation() 20180707 19:55:59<+discordbot1> That would allow unit.loc = other.loc, yes? 20180707 19:56:05< celticminstrel> Yes. 20180707 19:56:17< celticminstrel> IIRC luaW_pushlocation uses the {x,y} format. 20180707 19:56:30< celticminstrel> Or maybe it goes redundant and uses {x, y, x=x, y=y} 20180707 19:56:49< celticminstrel> So that it'll work with things that assume {x,y} but also with things that assume {x=x,y=y}. 20180707 19:59:01<+discordbot1> Can you implememt this fix 20180707 19:59:10< celticminstrel> Maybe. 20180707 20:01:09< celticminstrel> I looked at that several times thinking something was off, but only just now did I spot the typo. 20180707 20:01:36< celticminstrel> (In Vultraz's message that is.) 20180707 20:04:27-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 240 seconds] 20180707 20:25:07<+discordbot1> @zookeeper Did you create the familiar unit sprites here? https://github.com/wesnoth/wesnoth/commit/a30cbb61693bee71f7593c29998f2d2ba59a6bb6 20180707 20:28:56<+discordbot1> Well you have a week celmin 20180707 20:39:58< celticminstrel> ...what are you talking about Vultraz. 20180707 20:40:25<+discordbot1> probably "Can you implememt this fix" 20180707 20:40:37< celticminstrel> Not what I meant. 20180707 20:57:34< gfgtdf> hmm wesnoth.add_modification doesnt give an aeeor when the third (cfg) parameter is nil, i think it'd be better to give an error in that case. 20180707 20:59:22-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20180707 21:29:02< zookeeper> @Pentarctagon yes 20180707 21:47:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180707 21:47:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180707 21:50:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180707 21:54:29-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180707 22:07:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180707 22:25:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180707 22:32:34-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180707 22:37:54-!- irker610 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180707 23:05:09-!- gfgtdf [~chatzilla@x4e3375ac.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.9.0/20180621064021]] 20180707 23:14:23<+discordbot1> thanks --- Log closed Sun Jul 08 00:00:30 2018