--- Log opened Sun Jul 08 00:00:30 2018 20180708 00:09:27-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180708 00:21:05-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has quit [Remote host closed the connection] 20180708 00:22:03-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev 20180708 00:58:34-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 264 seconds] 20180708 01:00:19-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20180708 01:30:50-!- louis94 [~~louis94@91.178.69.90] has quit [Remote host closed the connection] 20180708 01:31:20-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180708 01:53:29-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 260 seconds] 20180708 02:04:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180708 02:04:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180708 02:20:02-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180708 02:20:50-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180708 02:22:18-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Client Quit] 20180708 02:23:01-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180708 02:46:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180708 03:09:45-!- Appleman1234 [~quassel@121.222.11.31] has joined #wesnoth-dev 20180708 03:25:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180708 03:56:01<+discordbot1> [2:24 PM] BOTIRC: So @lilinitsy is that PR finished AFAYK? Yup, just updated with what the consensus of the changes seemed to be,, looks about done now. 20180708 04:09:00<+discordbot1> This PR is going to be a PITA to port to master... 20180708 04:10:57<+discordbot1> Why's that? 20180708 04:12:13<+discordbot1> The function I modified in reports.cpp looks untouched. 20180708 04:12:58<+discordbot1> Oh how nice, master cleaned up src/help/ 20180708 04:13:03<+discordbot1> yup 20180708 04:13:05<+discordbot1> extensively 20180708 04:13:26<+discordbot1> and the custom formatting is no longer used either, it uses pango. 20180708 04:13:42<+discordbot1> Well the good news is two of the files look more or less the same. 20180708 04:13:51<+discordbot1> Yeah but I didn't touche the formatting. 20180708 04:14:29<+discordbot1> I dunno, just ping me when master's in a state where the GUI works and I'll try to port it over :P 20180708 04:24:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180708 04:25:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180708 04:42:27<+discordbot1> celmin: I said a week because 1.14.4 is supposed to come out next week 20180708 04:42:46<+discordbot1> and there's supposed to be a string freeze today... and I didn't get the lobby stuff done again 😐 20180708 04:46:30-!- irker655 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180708 04:46:30< irker655> wesnoth: josteph wesnoth:1.14 12d0d65e955d / data/campaigns/The_Hammer_of_Thursagan/scenarios/07_Mages_and_Drakes.cfg: THoT S7: Select Darchas so the narrator's reference to him isn't dangling. https://github.com/wesnoth/wesnoth/commit/12d0d65e955d63530735ebeb2f3106309f97a077 20180708 04:52:16< irker655> wesnoth: josteph wesnoth:1.14 234d9983a8a0 / src/help/help_topic_generators.cpp: Help: Use `female_name` and `name` as fallback when `male_name` is empty and don https://github.com/wesnoth/wesnoth/commit/234d9983a8a01f674069d3a338df32c9ef9ba831 20180708 04:52:18< irker655> wesnoth: josteph wesnoth:1.14 a3d564ce4381 / src/help/help_topic_generators.cpp: Help: only use male_name/female_name if the unit has male/female variants. https://github.com/wesnoth/wesnoth/commit/a3d564ce43812367473abab7ec944b73dd5b4d46 20180708 04:57:46< irker655> wesnoth: josteph wesnoth:master 29e814d8f4b1 / data/campaigns/The_Hammer_of_Thursagan/scenarios/07_Mages_and_Drakes.cfg: THoT S7: Select Darchas so the narrator's reference to him isn't dangling. https://github.com/wesnoth/wesnoth/commit/29e814d8f4b15a4edae973837e81e85295494bb4 20180708 04:57:48< irker655> wesnoth: josteph wesnoth:master a4b0de5ece5a / src/help/topic_text_generators.cpp: Help: Use `female_name` and `name` as fallback when `male_name` is empty and don https://github.com/wesnoth/wesnoth/commit/a4b0de5ece5a9bf1edac3b6f49dfac647ff1194f 20180708 04:57:50< irker655> wesnoth: josteph wesnoth:master dcbdac8ab5d5 / src/help/topic_text_generators.cpp: Help: only use male_name/female_name if the unit has male/female variants. https://github.com/wesnoth/wesnoth/commit/dcbdac8ab5d593d31faa04f6069da8ae5c6744c5 20180708 04:58:17<+discordbot1> @shadowm I don't think I have any more string changes just right this minute. Could you run the pot? 20180708 05:01:34<+discordbot1> When you get a minute @Vultraz take a look at 3305, made those emplace changes 20180708 05:02:38<+discordbot1> @lilinitsy somehow the advanced pref entry is back? 20180708 05:03:53<+discordbot1> Hmm... yeah looks like I accidentally merged something when squashing 20180708 05:05:00<+discordbot1> That's weird though, VS Code isn't finding the updated version of that file, but it is of all the rest? 20180708 05:09:16<+discordbot1> I'm just not gonna squash that back into one, since it looks like much of it will have to be a manual port anyway. 20180708 05:35:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180708 05:36:21-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Excess Flood] 20180708 05:37:07-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180708 05:39:31<+discordbot1> oh, blah 20180708 05:42:25<+discordbot1> or...hm 20180708 06:44:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180708 06:44:26-!- zookeeper_ [~lmsnie@95.175.104.115] has joined #wesnoth-dev 20180708 06:44:26-!- zookeeper_ [~lmsnie@95.175.104.115] has quit [Client Quit] 20180708 06:48:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20180708 06:49:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180708 06:53:27<+discordbot1> @Vultraz Is the intention to not have the 1st iOS PR merged prior to 1.14.4? 20180708 06:54:56<+discordbot1> i can merge it, but it's going to be a huge problem to port it to master 20180708 06:56:25<+discordbot1> the UI stuff specifically 20180708 06:58:26<+discordbot1> that's why I'm hesitant 20180708 07:00:20<+discordbot1> @sinda do you have any plans for that? 20180708 07:01:19<+discordbot1> ie, do you plan a port to master now? 20180708 07:01:26<+discordbot1> in 6 months? 20180708 07:02:14<+discordbot1> Is master already working? If so, then yes. 20180708 07:03:07<+discordbot1> master "works", except there's no in-game UI 20180708 07:03:15<+discordbot1> the map draws mostly fine (sans stuff like ToD) 20180708 07:03:27<+discordbot1> and since I hid the broken HUD you can interact with the map 20180708 07:03:37<+discordbot1> Have a hot period, it’s going to end in a week. Will resume work on iPhone version, can do master too. 20180708 07:04:04<+discordbot1> I will then. 20180708 07:04:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180708 07:04:39<+discordbot1> I'm simplified a lot of stuff in the dispatcher code 20180708 07:04:47<+discordbot1> moved a bunch of it around 20180708 07:06:05<+discordbot1> Simplification is good 😃 Will be happy to port onto a simpler dispatcher. 20180708 07:32:49-!- Appleman1234 [~quassel@121.222.11.31] has quit [Ping timeout: 248 seconds] 20180708 07:58:25-!- irker655 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180708 08:08:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180708 08:11:59<+discordbot1> Grumble grumble. 20180708 08:16:09<+discordbot1> grumble? 20180708 08:17:50<+discordbot1> Groan. 20180708 08:18:51<+discordbot1> I'm finding issues while reviewing the pot update diff for the announcement. 20180708 08:26:07<+discordbot1> [+time] # po: Use the same translation as for the string in the wesnoth-help textdomain. name= _ "The Long Dark" [/time] 20180708 08:26:09<+discordbot1> Really. 20180708 08:27:09<+discordbot1> Oh, right, the core strings have that number suffix attached. 20180708 08:56:57-!- irker052 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180708 08:56:57< irker052> wesnoth: Iris Morelle wesnoth:master b8b403185eb8 / data/ (advanced_preferences.cfg gui/window/preferences/01_general.cfg): gui2/preferences: Use curly quotes in quoted text in tooltips https://github.com/wesnoth/wesnoth/commit/b8b403185eb81a239b5ab130fcf32698ac3de1d1 20180708 08:56:58< irker052> wesnoth: Iris Morelle wesnoth:master de8d468b1411 / data/ (5 files in 5 dirs): Fix excessive dots in ellipses in several mainline scenarios https://github.com/wesnoth/wesnoth/commit/de8d468b14119d7486bbbb782a2aabce1b650991 20180708 08:56:59< irker052> wesnoth: Iris Morelle wesnoth:master aa1976f090a2 / / (298 files in 6 dirs): pofix: Add rules for whitespace/dot count-changing commits https://github.com/wesnoth/wesnoth/commit/aa1976f090a2d9fc80b6f8d564a6fc855dee2c28 20180708 08:57:01< irker052> wesnoth: Iris Morelle wesnoth:1.14 da20cce6c0fa / data/ (advanced_preferences.cfg gui/window/preferences/01_general.cfg): gui2/preferences: Use curly quotes in quoted text in tooltips https://github.com/wesnoth/wesnoth/commit/da20cce6c0faad81dfa39322831ff0b74c567b6a 20180708 08:57:03< irker052> wesnoth: Iris Morelle wesnoth:1.14 95f819557a7c / data/ (5 files in 5 dirs): Fix excessive dots in ellipses in several mainline scenarios https://github.com/wesnoth/wesnoth/commit/95f819557a7cfa1333878588160815a97f32025f 20180708 08:57:06< irker052> wesnoth: Iris Morelle wesnoth:1.14 f1a5728463d4 / / (298 files in 6 dirs): pofix: Add rules for whitespace/dot count-changing commits https://github.com/wesnoth/wesnoth/commit/f1a5728463d441c91a1c601543bfcac66bec39cc 20180708 08:57:09< irker052> wesnoth: Iris Morelle wesnoth:1.14 6fb813ba80a9 / / (1545 files in 29 dirs): pot and documentation update https://github.com/wesnoth/wesnoth/commit/6fb813ba80a91b890b597290f1863485469170ec 20180708 09:04:44<+discordbot1> @Vultraz Done. 20180708 09:04:50<+discordbot1> Also announced in the translators ML. 20180708 09:26:36-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180708 09:38:18-!- kallaballa [~amir@62.178.166.233] has joined #wesnoth-dev 20180708 09:38:40-!- kallaballa [~amir@62.178.166.233] has quit [Client Quit] 20180708 10:00:21-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 264 seconds] 20180708 10:48:22<+discordbot1> @shadowm you forgot to mention the important new PRNG advanced preference string. 20180708 10:48:32<+discordbot1> Meh. 20180708 10:48:42<+discordbot1> Mention it yourself in a follow-up if you want. 20180708 10:48:52<+discordbot1> I guess it's not that important, they'll see it 20180708 10:48:55<+discordbot1> I'm not going to bother trying to explain it. 20180708 11:10:10< irker052> wesnoth/wesnoth:1.14 joeylmaalouf cbf13025f3 updated contributors list AppVeyor: All builds passed 20180708 11:33:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180708 11:33:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180708 11:48:26-!- Skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20180708 11:49:14-!- Skyfaller [~skyfaller@wikipedia/Skyfaller] has left #wesnoth-dev [] 20180708 11:56:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180708 11:56:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180708 11:58:04-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180708 12:02:54-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180708 12:03:48-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180708 12:10:23-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180708 13:00:29< celticminstrel> @Vultraz 20180708 13:00:44< celticminstrel> https://github.com/wesnoth/wesnoth/pull/3305 20180708 13:00:50< celticminstrel> The block at the bottom 20180708 13:00:53< celticminstrel> "approve changes" 20180708 13:00:58< celticminstrel> (if applicable) 20180708 13:05:52< celticminstrel> So this is kinda terrible, did whoever implement jamming simply forget to support it in the unit and unit_type constructors, or did someone accidentally remove it? 20180708 13:09:06< celticminstrel> It's there in the original commit: https://github.com/wesnoth/wesnoth/commit/fbbfadfc6b8cc6ba1323a5fd7b7908f0c98e1d25#diff-af3fd7e884f8ab9f39f9088ca4010d0dR1739 20180708 13:09:31< celticminstrel> Similarly for unit types: https://github.com/wesnoth/wesnoth/commit/fbbfadfc6b8cc6ba1323a5fd7b7908f0c98e1d25#diff-5c3015c1ec6963a9da9a75fff346f390R788 20180708 13:10:20< celticminstrel> Maybe it's just GitHub's search that's not seeing it though... 20180708 13:11:30< celticminstrel> Okay, this is interesting... 20180708 13:11:42< celticminstrel> That line in unit types does exist on master, but I can't find the line in units on master. 20180708 13:13:26< celticminstrel> Wait, no, I think I misinterpreted it... 20180708 13:13:46< celticminstrel> Yeah, it looks like it was never supported in [unit]. 20180708 13:15:54< celticminstrel> I wonder if that was intentional on fabi's part though. 20180708 13:16:07< celticminstrel> Anyway it should definitely be added. 20180708 13:21:27-!- Appleman1234 [~quassel@124.185.42.197] has quit [Ping timeout: 244 seconds] 20180708 13:23:18< irker052> wesnoth/wesnoth:1.14 josteph a3d564ce43 Help: only use male_name/female_name if AppVeyor: All builds passed 20180708 13:30:16-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180708 13:33:14< Ravana_> is it intentional that reloaded games look same as normal games in lobby now? 20180708 13:33:38< Ravana_> it is visible from hovering, so might well be 20180708 13:44:42-!- Appleman1234 [~quassel@124.185.42.197] has quit [Ping timeout: 244 seconds] 20180708 13:56:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180708 14:01:45< celticminstrel> Well, I think I jsut found a bug in MicroAIs. 20180708 14:01:48< celticminstrel> ^just 20180708 14:03:14< celticminstrel> Though I'm not quite sure, it could be something in my code. 20180708 14:05:18< celticminstrel> Basically the problem is that, for some reason, it's looking for my custom CAs in the same place as the standard MicroAI CAs. 20180708 14:07:21< celticminstrel> Rather than finding them in my addon. 20180708 15:03:56-!- octalot [~steve@91.141.2.117.wireless.dyn.drei.com] has joined #wesnoth-dev 20180708 15:14:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180708 15:40:40< irker052> wesnoth/wesnoth:1.14 ville 15f0525e15 Remove advanced preference item for alph AppVeyor: All builds passed 20180708 15:47:05<+discordbot1> @Ravana reloaded games with vacant slots have their title colored yellow, but once they start there's really no need to further differentiate them 20180708 15:48:20< Ravana_> right 20180708 16:02:40< octalot> is there documentation anywhere about how jamming is meant to work (as in, what do the terrain costs for it mean)? (asking again in the right channel this time) 20180708 16:21:40-!- travis-ci [~travis-ci@ec2-54-92-247-212.compute-1.amazonaws.com] has joined #wesnoth-dev 20180708 16:21:41< travis-ci> Pentarctagon/wesnoth#71 (hardening2 - 3420212 : Pentarctagon): The build failed. 20180708 16:21:41< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/401461481 20180708 16:21:41-!- travis-ci [~travis-ci@ec2-54-92-247-212.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180708 16:34:58< zookeeper> octalot, apparently not, but when you figure it out, please do update the wiki :J 20180708 16:36:31< octalot> zookeeper: that's mostly what I though, except I was hoping that people chatting in PR #3327 would know :J 20180708 16:37:46 * octalot pokes celticminstrel 20180708 16:42:02< celticminstrel> ? 20180708 16:45:59< octalot> if you want to put jamming values in the UI, please would you document what jamming is? 20180708 16:52:35< Ravana_> parry and accuracy are in UI, but not really explained 20180708 17:02:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180708 17:02:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180708 17:09:33<+discordbot1> we should probably remove jammin 20180708 17:09:34<+discordbot1> g 20180708 17:12:17< octalot> maybe it's just that I don't understand what jamming is meant to be, but without documentation I can think of multiple ways in which it could interact with vision 20180708 17:13:05< octalot> and when looking at refactoring the movement cost code, it seemed to be adding complexity without any way to know what it was meant to do 20180708 17:14:19< octalot> I think it could be really neat, having guards blocking vision without needing to simulate it by having impassible hexes change to flat when the guard dies.. 20180708 17:23:15<+discordbot1> @Jetrel Did you create TRoW's noble-command/noble-lord/noble-youth/noble-fighter sprites? 20180708 17:27:33< zookeeper> if not, then perhaps you can discern it from https://forums.wesnoth.org/viewtopic.php?t=2238 somehow 20180708 17:28:47< zookeeper> in other words, might have been Shade 20180708 17:29:03< celticminstrel> @Vultraz Please don't. 20180708 17:29:15<+discordbot1> Why not? 20180708 17:29:41< celticminstrel> I don't know if the implementation is good (haven't actually tried it) but conceptually it seems perfect for a more sci-fi era. 20180708 17:29:51< celticminstrel> And if the implementation is bad we can just improve it, right? 20180708 17:30:48< celticminstrel> I actually want to use it, just haven't gotten a chance to yet. 20180708 17:31:39< celticminstrel> I definitely would like jamming to be better documented. Can anyone actually understand fabi's code? 20180708 17:33:37< celticminstrel> Also @Vultraz did you see what I said earlier about approving changes. 20180708 17:34:06<+discordbot1> I did. I know about approving changes. I just hadn’t yet 20180708 17:34:34<+discordbot1> Because I noticed he wasn’t using icompare 20180708 17:34:43< celticminstrel> Ah, good point, hmm. 20180708 17:34:50<+discordbot1> And I was wondering if we should ask him to use icompare 20180708 17:35:00< celticminstrel> Let me check something quickly. 20180708 17:35:11<+discordbot1> Then, I wondered if perhaps we should implement operator<() for t_string using icompare 20180708 17:37:42< celticminstrel> I think we should probably just remove operator< from t_string. 20180708 17:37:52<+discordbot1> Oh? 20180708 17:38:05< celticminstrel> It never gives the right result from what I can see. If I'm not mistaken, it's only there so that you can use it as a map key. 20180708 17:38:18< celticminstrel> Which is a good thing to have, mind you. 20180708 17:38:32< celticminstrel> But if we can get it to work as a map key without that, that would be better. 20180708 17:38:47<+discordbot1> How would we do that 20180708 17:38:52< celticminstrel> I don't think it's often used as a map key, right? Or at least, the one common use of it as a map key is a typedef? 20180708 17:39:45<+discordbot1> Hmm... 20180708 17:39:57< celticminstrel> Enabling it to be used as a map key in arbitrary maps requires defining operator<; but if it's only needed in one case which is a typedef anyway, then that's easy to do - just define a comparator struct and use that in the typedef for the comparator template argument. 20180708 17:39:59<+discordbot1> I know it’s used as a value... 20180708 17:40:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180708 17:40:12< celticminstrel> IIRC isn't it the key type for string_map? I could be mistaken though. 20180708 17:40:41< celticminstrel> I guess the easiest (though not quickest) way to find out if it's used as a map key (ir in a set) would be to just delete operator< and see if the game still compiles. 20180708 17:40:51< celticminstrel> (And delete > <= >= too if they're there.) 20180708 17:41:15< celticminstrel> (== and != can stay though, they may occasionally give surprising results but generally would give the expected result.) 20180708 17:45:28<+discordbot1> string_map is 20180708 17:45:32< celticminstrel> Ah. 20180708 17:45:58< celticminstrel> If we do remove operator< and co, it should be replaced with a comment explaining that there's intentionally no operator<. 20180708 17:46:06< celticminstrel> Otherwise someone will inevitably just add it back later. 20180708 17:46:19< celticminstrel> We can't define operator< in terms of compare/icompare IIUC. 20180708 17:46:47< celticminstrel> Because if someone changes the language, that would mean the tree is suddenly unsorted. 20180708 17:47:10< celticminstrel> Which would inevitably mess up all the algorithms that search it under the assumption that it is sorted. 20180708 17:47:43< celticminstrel> (This is assuming t_string were used as a map or set key somewhere.) 20180708 17:48:28< celticminstrel> There's another alternative if it is used as a key somewhere - define a hash function and make the maps or sets unordered. Then it would be usable as a key in any hashmap but not for the treemaps. 20180708 17:48:39< celticminstrel> (Assuming you also delete operator<) 20180708 17:49:56<+discordbot1> let us see. 20180708 17:50:28< irker052> wesnoth/wesnoth:master Iris Morelle aa1976f090 pofix: Add rules for whitespace/dot coun AppVeyor: All builds passed 20180708 17:50:30<+discordbot1> ISTG, who added all the "/** Default implementation, but defined out-of-line for efficiency reasons. */" comments all over the codebase >_< 20180708 17:50:45< celticminstrel> No idea. 20180708 17:51:09< celticminstrel> It doesn't even make sense, how can an explicit default definition possibly be more efficient than a compiler-generated default definition? 20180708 17:51:29<+discordbot1> I have no idea. 20180708 17:51:31< celticminstrel> If it's default, just remove it. Or if you want to make it explicitly clear that it's default, add =default 20180708 17:51:50<+discordbot1> I recall that someone said here that the explicit definitions shortened compile times. 20180708 17:52:00< celticminstrel> Is that really true? 20180708 17:52:01<+discordbot1> There are many places where such comments are applied to dtors and the dtors are empty. 20180708 17:52:16< celticminstrel> BTW, another thing, why does every constructor explicitly initialized every single member? 20180708 17:52:33<+discordbot1> whose? 20180708 17:53:02< celticminstrel> I guess it makes sense for numbers and such, because otherwise they might be filled with gibberish (though, for C++11 or 14, my preferred solution for that would be adding =0 after every integer or float variable definition). 20180708 17:53:17< celticminstrel> But for class types, it's entirely redundant. 20180708 17:53:35< celticminstrel> This is of course assuming it's explicitly default initialized. 20180708 17:53:44< celticminstrel> Obviously if it's initialized with something, it's not redundant. 20180708 17:53:52<+discordbot1> yeah, I've heard it's only relevant for integral types and pointers. 20180708 17:53:56< celticminstrel> Not quite. 20180708 17:53:59<+discordbot1> but I guess I've gotten into the habit? 20180708 17:54:02< celticminstrel> Numeric types and pointers. 20180708 17:54:08< celticminstrel> Floats are not integral types. 20180708 17:54:17< celticminstrel> I count bool as a numeric type too FTR. 20180708 17:54:18<+discordbot1> Also booleans and enums. 20180708 17:54:31< celticminstrel> Yeah, I guess counting enums as numeric is questionable. 20180708 17:54:37<+discordbot1> :thonk: I thought all these were integral types. 20180708 17:54:45< celticminstrel> You thought floats were integral types? 20180708 17:54:51< celticminstrel> Do you understand what "integral" means? 20180708 17:55:00< celticminstrel> It means it's an integer. 20180708 17:55:18<+discordbot1> I thought the term referred to core language-defined types. 20180708 17:55:21< celticminstrel> (FTR when I say floats I'm assuming that to include double too, because that's just a double-size float.) 20180708 17:55:24< celticminstrel> Ah. 20180708 17:55:30< celticminstrel> No, pretty sure it refers to integers. 20180708 17:55:37< celticminstrel> short, long, char, etc. 20180708 17:56:49<+discordbot1> Unless I'm utterly stupid, there is a definition of "integral" that generally means "fundamental to the function of", is there not? 😐 20180708 17:57:01< celticminstrel> I think that's true, yeah. 20180708 17:57:08< celticminstrel> So your assumption is reasonable. 20180708 17:59:32<+discordbot1> So my assumption has been, essentially, all the language-specific types need explicit initialization because they have no ctors. 20180708 17:59:55< celticminstrel> Yes, pretty much. 20180708 18:00:02<+discordbot1> because they aren't classes 20180708 18:00:42< celticminstrel> For some reason UE also makes certain class types do this. 20180708 18:00:59< celticminstrel> So if you use a vector you have to make sure to explicitly initialized it. 20180708 18:01:11< celticminstrel> (Mathematical vector, so basically the same as our point class.) 20180708 18:01:21< celticminstrel> IMO it's dumb, but whatever. 20180708 18:01:28< celticminstrel> Not like I can do anything about it. 20180708 18:02:04<+discordbot1> (though I have no idea how the "default 0 value" for integers in a map is handled when using operator[]) 20180708 18:02:25< celticminstrel> IIRC maps explicitly default-initialize their values. 20180708 18:02:41<+discordbot1> but integers have no default initialization 20180708 18:03:10< celticminstrel> I mean they explicitly default-construct the value. 20180708 18:03:19< celticminstrel> Like, T value = T() 20180708 18:03:36< celticminstrel> T() returns 0 when T is a numeric type. 20180708 18:03:41<+discordbot1> then why doesn't that work in a class 20180708 18:03:43<+discordbot1> https://en.cppreference.com/w/cpp/container/map/operator_at 20180708 18:03:50< celticminstrel> What do you mean? 20180708 18:03:57<+discordbot1> "When the default allocator is used, this results in the key being copy constructed from key and the mapped value being value-initialized." 20180708 18:04:12< celticminstrel> Yeah, value-initialized is the official term for what I'm saying here. 20180708 18:04:20<+discordbot1> For primitive types, value initialization is zero initialization. 20180708 18:04:24<+discordbot1> we were just saying that integers need to be initialized in the ctor list else their value is random 20180708 18:04:29-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180708 18:04:45< celticminstrel> Primitive types are never initialized by default (unless they're file-static). 20180708 18:05:08< celticminstrel> That goes for class members just as much as function locals. 20180708 18:05:29< celticminstrel> They don't need to be initialized in the ctor though. They can be initialized inline at definition time. 20180708 18:05:33< celticminstrel> int x = 0; 20180708 18:05:36<+discordbot1> Meanwhile, class members not mentioned in the initializer list are default initialized, and default initialization for primitive types means no initialization at all. 20180708 18:05:37< celticminstrel> Even as a class member. 20180708 18:06:10<+discordbot1> hm.. you mean , int_member() and , int_member(0) in the ctor list do the same thing? 20180708 18:06:20< celticminstrel> Yes. 20180708 18:06:26<+discordbot1> 🤔 20180708 18:06:28<+discordbot1> huh 20180708 18:06:40<+discordbot1> I thought you always needed the latter form 20180708 18:06:44< celticminstrel> And int int_member = 0; in the class body is equivalent to adding that to every ctor initializer list that doesn't otherwise explicitly mention int_member. 20180708 18:07:08<+discordbot1> ok, but then why do pointers explicitly need nullptr initilization 20180708 18:07:13<+discordbot1> initialization 20180708 18:07:20< celticminstrel> Pointers are also a primitive type IIUC 20180708 18:07:28< celticminstrel> So default-initialization is no initialization. 20180708 18:07:47< celticminstrel> Not sure about pointers-to-members though. 20180708 18:08:52<+discordbot1> map is used in 3 places in help 20180708 18:09:00< celticminstrel> Fuuuun! 20180708 18:09:08< celticminstrel> So what are we gonna do about it? 20180708 18:09:13< celticminstrel> Are they all different value types? 20180708 18:09:48<+discordbot1> AFAIK, ptr_member() in an initializer list should provide a null pointer. 20180708 18:10:01< celticminstrel> Yeah, pretty sure that'll work. 20180708 18:10:05<+discordbot1> yes. map, map, and map 20180708 18:10:16< celticminstrel> ...WTH is string_less? 20180708 18:10:29< celticminstrel> Okay, so what are we gonna do about it? 20180708 18:10:39< celticminstrel> There's basically two possibilities if we want to remove operator< 20180708 18:10:55<+discordbot1> set comparator wrapping translation::compare 20180708 18:11:01< celticminstrel> 1. Change those to unordered_map and define a specialization of std::hash for t_string (see map_location if you need an example). 20180708 18:11:17< celticminstrel> 2. Explicitly set the map comparator to translation::compare 20180708 18:11:31< celticminstrel> Don't use icompare for a map key BTW, that could give bad results. 20180708 18:12:11<+discordbot1> I can probably refactor this code 20180708 18:12:38< celticminstrel> (FTR, a hash for t_string is probably not a bad idea in general, it could just return the hash of value.) 20180708 18:13:11<+discordbot1> ...trait ids aren't translatable are they 20180708 18:13:17< celticminstrel> Nope. 20180708 18:13:23< celticminstrel> Trait names are though. 20180708 18:14:12<+discordbot1> ok, this is an incorrect use of t_string 20180708 18:14:28< celticminstrel> So it could just be std::string, huh. 20180708 18:15:33<+discordbot1> possibly had something to do with the help browser displaying ids or something? 20180708 18:15:45< celticminstrel> No idea. 20180708 18:16:02< celticminstrel> But string is implicitly convertible to t_string so, if that was the reason, it's not needed. 20180708 18:16:06<+discordbot1> oh, no 20180708 18:17:01<+discordbot1> these other cases are more complicated 20180708 18:17:51< celticminstrel> If it's complicated, I really don't think it's worth refactoring them. 20180708 18:18:09< celticminstrel> Just take one of the simple options - change to unordered_set, or explicitly pass translation::compare as the comparator. 20180708 18:18:40< celticminstrel> (I forget, does translation::compare take t_string or std::string? It shouldn't matter though since they're implicitly convertible to each other.) 20180708 18:46:07<+discordbot1> string 20180708 18:52:03< celticminstrel> Wait wait wait. 20180708 18:52:11< celticminstrel> I just realized, you can't use translation::compare as the map comparator. 20180708 18:53:45< celticminstrel> @Vultraz ^ 20180708 18:53:58<+discordbot1> set 20180708 18:54:04< celticminstrel> For a map you need to comapre the untranslated value, just like the existing operator< already does. 20180708 18:54:08< celticminstrel> What? 20180708 18:54:24< celticminstrel> map, set, they're basically the same thing anyway. 20180708 18:55:12<+discordbot1> well we've been doingit for ages and it's worked.. 20180708 18:55:50< celticminstrel> What? Since when have we been doing it? 20180708 18:56:08< celticminstrel> We haven't ever passed an explicit comparator to a t_string map, right? 20180708 18:56:16< celticminstrel> So that means it was comparing the untranslated value, which is fine. 20180708 18:56:29<+discordbot1> the use of string_less in help 20180708 18:56:33< celticminstrel> The only problem is that in cases other than a map, you don't generally want to compare the untranslated value. 20180708 18:56:38< celticminstrel> What is string_less? 20180708 18:57:05<+discordbot1> oh, wait, it's used as a comparator for a string set 20180708 18:57:10<+discordbot1> nevermind 20180708 18:57:19< celticminstrel> What even is string_less? 20180708 18:57:33<+discordbot1> cpp bool string_less::operator()(const std::string& s1, const std::string& s2) const { return translation::compare(s1, s2) < 0; } 20180708 18:57:50<+discordbot1> std::map> special_units; 20180708 18:58:21< celticminstrel> Ah. 20180708 18:58:37< celticminstrel> So it's just a way of using translation::compare without explicitly passing the comparator to the set constructor. 20180708 18:58:52< celticminstrel> Which I guess is necessary when it's the value type of a map, because the set is default-initialized there. 20180708 18:58:56<+discordbot1> you can do that? 20180708 18:59:14< celticminstrel> IIRC, yes 20180708 18:59:34< celticminstrel> ...wait, hold on, what you're saying is that we have been using translation::compare as a set comparator. 20180708 18:59:38< celticminstrel> That's kinda... not good? 20180708 18:59:41< celticminstrel> I think? 20180708 19:00:16< celticminstrel> I mean, sure, it'll work. As long as you can guarantee that the set is emptied anytime the language changes. 20180708 19:00:21< celticminstrel> But it's not good IMO. 20180708 19:00:39<+discordbot1> this is a temporary set 20180708 19:00:53< celticminstrel> Okay, so it's fine in this case, I guess. 20180708 19:01:01< celticminstrel> Not a good thing to get into a habit of doing though. 20180708 19:01:10<+discordbot1> I think help is cleared when you change langages? 20180708 19:01:12<+discordbot1> not sure 20180708 19:03:37-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180708 19:04:33<+discordbot1> weapon special ids are not unique 20180708 19:04:33<+discordbot1> hm 20180708 19:06:01< celticminstrel> I guess that's technically true... 20180708 19:06:14< celticminstrel> But I think they're supposed to be as unique as possible, aren't they? 20180708 19:16:10< irker052> wesnoth/wesnoth:1.14 Iris Morelle 6fb813ba80 pot and documentation update AppVeyor: All builds passed 20180708 19:33:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180708 19:33:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180708 19:37:05-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 256 seconds] 20180708 20:03:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180708 20:14:09<+discordbot1> celmin: don't forget the unit.loc fix 20180708 20:43:26< Ravana_> curious 20180708 20:43:33< Ravana_> in lua console, print("!*t") fails 20180708 20:44:38< Ravana_> [string "print("( "! *t" )t")"]:1: ')' expected near '!' 20180708 20:44:48< Ravana_> something gets replaced when it shouldn't 20180708 20:45:56< Ravana_> concatenating it as "!".."*t" works 20180708 20:48:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180708 20:51:05<+discordbot1> @shadowm how would one go about merging wesnoth-lib and wesnoth? 20180708 20:51:29-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180708 20:57:47<+discordbot1> celmin: do you think it's inefficient to use the map> format for setting up widgets? 20180708 20:57:54<+discordbot1> specifically, the t_string part 20180708 20:58:13<+discordbot1> it makes sense when you're setting a displayed text value (such as for labels)... 20180708 20:58:18<+discordbot1> but less for other values 20180708 20:58:27<+discordbot1> then again, there are very rarely other values.. 20180708 20:58:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180708 20:58:49-!- gfg [~androirc@tmo-119-133.customers.d1-online.com] has joined #wesnoth-dev 20180708 21:00:25< gfg> Ravana: we had similar issues like that in the past please file a gh issue 20180708 21:01:15< Ravana_> oh, thought it was intended, I was even getting ready to add issue but decided against it 20180708 21:02:56< irker052> wesnoth: Victor Sergienko wesnoth:1.14 9ec8589ef311 / .gitignore: .gitignore for CLion https://github.com/wesnoth/wesnoth/commit/9ec8589ef3113f6e7ba62cd21cad1b3323277821 20180708 21:02:58< irker052> wesnoth: Victor Sergienko wesnoth:1.14 30262b8227f3 / src/gui/core/event/ (dispatcher.cpp dispatcher.hpp dispatcher_private.hpp handler.cpp handler.hpp): 3 kinds of touch event compiled: up/down (combined with mouse), swipe and multi- https://github.com/wesnoth/wesnoth/commit/30262b8227f36fa6f406089fdd8c1903bb1a24b8 20180708 21:03:00< irker052> wesnoth: Victor Sergienko wesnoth:1.14 20e4a6e2078f / / (14 files in 6 dirs): iOS: Touch interface implemented, and a RMB emulation of such on PC. https://github.com/wesnoth/wesnoth/commit/20e4a6e2078f73d29cdb0c86ea7377c9fbb33f63 20180708 21:03:02< irker052> wesnoth: Victor Sergienko wesnoth:1.14 d21f643d7436 / src/mouse_handler_base.cpp: std::chrono::high_resolution_clock didn't work (do I have different versions of https://github.com/wesnoth/wesnoth/commit/d21f643d74363f31cf2ec0acd2bdf8e3cc4781e1 20180708 21:03:04< irker052> wesnoth: Victor Sergienko wesnoth:1.14 0238d1529f3b / src/filesystem_boost.cpp: iOS document directories. Might use these on other platforms as well. https://github.com/wesnoth/wesnoth/commit/0238d1529f3b13874488306c55ec3e6b162c705d 20180708 21:03:06< irker052> wesnoth: Victor Sergienko wesnoth:1.14 c59987753c2a / / (11 files in 3 dirs): iOS: Touch-hex action added. https://github.com/wesnoth/wesnoth/commit/c59987753c2adaaec9dc4c259179e7a31bdabfcb 20180708 21:03:08< irker052> wesnoth: Victor Sergienko wesnoth:1.14 ccb5ccdaf74f / src/ (8 files in 3 dirs): iOS: finger scrolling in controls. https://github.com/wesnoth/wesnoth/commit/ccb5ccdaf74fa51822a54ba6af6b177c6f6fc38e 20180708 21:03:10< irker052> wesnoth: Victor Sergienko wesnoth:1.14 6f515d39ed41 / src/mouse_events.cpp: iOS: panning https://github.com/wesnoth/wesnoth/commit/6f515d39ed41661452bab52e99f1da0fd9091357 20180708 21:03:11< gfg> i mean, not sure if this behavior makes sense it can stay, but i just dont see that being the case. 20180708 21:03:12< irker052> wesnoth: Victor Sergienko wesnoth:1.14 1845a978c666 / src/gui/core/ (event/distributor.cpp timer.cpp): iOS: trying 2 fixes in gui2::execute_timer() and gui2::timer_callback(): timer t https://github.com/wesnoth/wesnoth/commit/1845a978c6661f69d2dd3cb8f76b2771b544a727 20180708 21:03:14< irker052> wesnoth: Victor Sergienko wesnoth:1.14 8f28f8d968a7 / src/ (6 files in 2 dirs): iOS: Long-touch context menu. Work around event queue delays. https://github.com/wesnoth/wesnoth/commit/8f28f8d968a79e8cea8a4c7c8ebf5c10a80745b3 20180708 21:03:16< irker052> wesnoth: Victor Sergienko wesnoth:1.14 fe630e1f5989 / src/ (controller_base.cpp events.cpp sdl/userevent.hpp): iOS: double-tap for context menu https://github.com/wesnoth/wesnoth/commit/fe630e1f5989e11dbec67580941022cbf7430c6d 20180708 21:05:32< irker052> wesnoth: Charles Dang wesnoth:master 19c78fc1c217 / src/help/topic_generators.cpp: Help: removed an unnecessary use of t_string as a map key https://github.com/wesnoth/wesnoth/commit/19c78fc1c217a59d62b93ee7822efe0f772cd9f4 20180708 21:05:34<+discordbot1> celmin ^ there's one 20180708 21:05:56<+discordbot1> @Vultraz For the catalogues we'd need to do what I did with Naia except backwards. 20180708 21:07:25<+discordbot1> But that also means that both textdomains would become a very special case to handle when updating translations until 1.14 reaches EOL. 20180708 21:09:20<+discordbot1> So you recommend we wait? 20180708 21:11:09<+discordbot1> That's one option. 20180708 21:12:04<+discordbot1> The other option is to merge both textdomains in 1.14 as well at the start of the next string freeze. 20180708 21:12:35<+discordbot1> The problem is 20180708 21:12:44<+discordbot1> This would break UMC. 20180708 21:12:51<+discordbot1> oh? 20180708 21:13:03<+discordbot1> you mean those that use mainline strings? 20180708 21:14:00<+discordbot1> Unless we internally aliased the wesnoth-lib textdomain to wesnoth. 20180708 21:14:38<+discordbot1> also a possibility 20180708 21:15:47<+discordbot1> Your call. I don't work with translations (you have/do), so you're in a better position to know what to do. 20180708 21:17:25<+discordbot1> If master wasn't such a wreck right now... 20180708 21:17:46-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 264 seconds] 20180708 21:17:47<+discordbot1> master is mostly usable. You just don't have the in-game UI. 20180708 21:17:54<+discordbot1> I disabled it so you can interact with the map 20180708 21:18:46<+discordbot1> (the code has been decoupled enough that I can hide the HUD by commenting out a single line of code) 20180708 21:18:56<+discordbot1> I might experiment with a PR against 1.14 to see what people think and to make sure things work as expected. 20180708 21:19:42<+discordbot1> Might need to extract a list of strings duplicated in both textdomains as well just in case. 20180708 21:20:21<+discordbot1> sounds good to me 20180708 21:21:14< celticminstrel> Ravana_: Pretty sure there already was a GitHub issue about the ! behaviour? It's a feature of the GNU history library. 20180708 21:21:31< celticminstrel> [Jul 08@4:57:47pm] discordbot1: celmin: do you think it's inefficient to use the map> format for setting up widgets? 20180708 21:21:32< celticminstrel> I don't really understand why you're asking? 20180708 21:21:46<+discordbot1> nevermind 20180708 21:21:54< celticminstrel> ? 20180708 21:22:26<+discordbot1> perhaps you mean this glorious back-and-forth https://github.com/wesnoth/wesnoth/issues/1542 20180708 21:22:38< Ravana_> might be, I was just told to create that issue 20180708 21:22:41< celticminstrel> For Ravana_ yeah 20180708 21:24:53<+discordbot1> @sinda touch changes seem to be working pretty well 20180708 21:25:16< irker052> wesnoth: Nils Kneuper wesnoth:1.14 df423aa5e319 / / (30 files in 29 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/df423aa5e3194b0075bb27856ceb1842fe2608ba 20180708 21:25:24< irker052> wesnoth: Nils Kneuper wesnoth:master 8b7410317af0 / po/ (28 files in 28 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/8b7410317af0555eb54c96c45f737d62810021a6 20180708 21:25:46< celticminstrel> Ohh, that was the touch PR getting merged, nice. 20180708 21:26:36<+discordbot1> @sinda would definitely be nice if scrolling had the standard post-touch easing, though. 20180708 21:34:31-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20180708 21:35:10< gfgtdf> Ravana: please check whether you use a self-compiled wesnoth with outdated libs in which case it might actually already be fixed 20180708 21:37:12< Ravana_> would that comment have the relevant version? 20180708 21:39:03< gfgtdf> Ravana_, i only see 'Checking for C library history... (cached) yes' whihc doesnt tell the version, the comment in #1708 suggeted that Readline version 7.0 is needed 20180708 21:39:25< Ravana_> do you know command to check its version? 20180708 21:39:33< gfgtdf> or at lest that it works with readline 7.0 20180708 21:39:48< gfgtdf> no i don't sry. 20180708 21:40:31< Ravana_> happens with flatpak version too 20180708 21:45:21-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 256 seconds] 20180708 21:46:18-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180708 21:46:25< Ravana_> using /sbin/ldconfig -p | grep history shows names ending with 5 and 6 20180708 21:47:10-!- octalot [~steve@91.141.2.117.wireless.dyn.drei.com] has quit [] 20180708 21:48:32< gfgtdf> > Wesnoth 1.13.8 for windows comes with ancient GNU Readline 5.0 (2004), while this problem was fixed in 6.3 (2014) 20180708 21:51:07-!- gfg [~androirc@tmo-119-133.customers.d1-online.com] has quit [Remote host closed the connection] 20180708 21:59:17-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180708 22:00:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180708 22:22:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180708 23:07:05-!- Appleman1234 [~quassel@124.185.42.197] has quit [Ping timeout: 240 seconds] 20180708 23:26:26<+discordbot1> agh. so messy 20180708 23:26:31<+discordbot1> if(config::const_child_itors cfg_range = cfg.child_range("abilities")) { --- Log closed Mon Jul 09 00:00:32 2018