--- Log opened Mon Jul 09 00:00:32 2018 20180709 00:26:18-!- irker052 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180709 00:28:59<+discordbot1> blah. was trying to finish expanding that abilities_metadata thing I added to unit... not looking like I can 20180709 01:06:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180709 01:14:50-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180709 01:58:17<+discordbot1> I'm not understanding the differene between translation::compare and translation::icompare. Is one preferable to the other? 20180709 01:59:03<+discordbot1> translation::icompare() is case insensitive. 20180709 02:00:05<+discordbot1> Oh I see, I only saw that in the OSX preprocessor block. Thanks. 20180709 02:18:24-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180709 02:42:51-!- irker937 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180709 02:42:51< irker937> wesnoth: Charles Dang wesnoth:master c41da8255d60 / src/ (105 files in 10 dirs): GUI2: cleaned up a whole bunch of widget-related includes https://github.com/wesnoth/wesnoth/commit/c41da8255d608916edfcf56409cc9506b7b6b7af 20180709 03:23:28<+discordbot1> hmm... 20180709 03:25:48<+discordbot1> I wonder if that thing where a helper function was used to implement sorting by multiple factors in Unit List and Unit Recall could instead be done using std::tie... 20180709 03:27:11<+discordbot1> would be good to know... 20180709 03:27:44<+discordbot1> I think these two functions would return the same result cpp bool unit_recall::default_compare(const unit_const_ptr first, const unit_const_ptr second) { if (first->level() > second->level()) return true; if (first->level() < second->level()) return false; if (first->experience_to_advance() < second->experience_to_advance()) return true; return false; } bool unit_recall::default_compare(const unit_const_ptr lhs, 20180709 03:27:44<+discordbot1> const unit_const_ptr rhs) { return std::tie(lhs->level(), lhs->experience_to_advance()) < std::tie(rhs->level(), rhs->experience_to_advance()) } 20180709 03:27:45<+discordbot1> 🤔 20180709 03:28:08<+discordbot1> in which case... 20180709 03:29:16<+discordbot1> cpp list.register_sorting_option(2, [this](const int i) { return std::tie(recall_list_[i]->level(), recall_list_[i]->experience_to_advance()); }); 20180709 03:29:18<+discordbot1> You're reversing the order. 20180709 03:29:39<+discordbot1> Also, I think first and second are better names than lhs and rhs. 20180709 03:30:17<+discordbot1> well, I'd do away with default_compare entirely if I could use register_sorting_option + std::tie. 20180709 03:30:19< irker937> wesnoth/wesnoth:1.14 Nils Kneuper df423aa5e3 updated Chinese (Simplified) translation AppVeyor: All builds passed 20180709 03:30:46<+discordbot1> I'm trying to figure if that would work, since that provides a simple reference for multi-criteria sorting if it's needed elsewhere. 20180709 03:31:30<+discordbot1> Ah, right. The comparison function also uses opposite orders for level and experience_to_advance. 20180709 03:31:41<+discordbot1> You'd need to negate one of them. 20180709 03:32:30<+discordbot1> negate? 20180709 03:32:45<+discordbot1> The unary - operator. 20180709 03:35:33<+discordbot1> ah 20180709 03:40:53<+discordbot1> looks like std::tie doesn't work here since tie takes references. 20180709 03:41:26<+discordbot1> but make_tuple works 20180709 03:41:37<+discordbot1> You can use std::make_tuple() instead. 20180709 03:41:45<+discordbot1> (Ah, you were faster.) 20180709 03:48:44< irker937> wesnoth: Charles Dang wesnoth:master 94db6ba8c5b7 / src/gui/dialogs/ (unit_list.cpp unit_recall.cpp unit_recall.hpp): Unit List/Unit Recall: simplified level sorting functionality https://github.com/wesnoth/wesnoth/commit/94db6ba8c5b75d7c916ba7003b5720d6dc353a2e 20180709 03:48:47< irker937> wesnoth: Charles Dang wesnoth:master 60950a797f03 / src/gui/dialogs/unit_recall.cpp: Unit Recall: marked some sorting options as translatable https://github.com/wesnoth/wesnoth/commit/60950a797f034e6d6608f803809b3a7061a304b1 20180709 03:50:32< irker937> wesnoth: Charles Dang wesnoth:1.14 7c93690fa757 / src/gui/dialogs/ (unit_list.cpp unit_recall.cpp unit_recall.hpp): Unit List/Unit Recall: simplified level sorting functionality https://github.com/wesnoth/wesnoth/commit/7c93690fa757373450c0d1ec22fc5c2372cb833a 20180709 03:50:35< irker937> wesnoth: Charles Dang wesnoth:1.14 f268b7747ba8 / src/gui/dialogs/unit_recall.cpp: Unit Recall: marked some sorting options as translatable https://github.com/wesnoth/wesnoth/commit/f268b7747ba893f30b5e74b4be29eec922faa8a9 20180709 03:57:47< irker937> wesnoth: Charles Dang wesnoth:1.14 7da1c5673e8b / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/7da1c5673e8b143d8db3863758d52ad56585bd44 20180709 03:58:39< irker937> wesnoth: Charles Dang wesnoth:master d8426ac37adf / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/d8426ac37adf046d980fc7aaf3952ca0d965ad51 20180709 04:11:30<+discordbot1> Just a tidbit, if it only has 2 elements and you know that it won't ever have more, std::pair gives nicer accessors (first, second) instead of std::get(tuple_name) 20180709 04:14:09<+discordbot1> I am aware 20180709 04:14:15<+discordbot1> The point isn’t to access them 20180709 04:14:34<+discordbot1> The point is to utilize tuple comparison 20180709 04:15:38<+discordbot1> Though, yes, since a pair is a specialized form of a tuple it would have worked just as well here 20180709 04:50:32< celmin> I assume you made sure that gives the same result. 20180709 04:50:40< celmin> As opposed to the opposite result. 20180709 04:53:42-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180709 05:03:31<+discordbot1> @Vultraz scrolling inertia is a registered feature request. Not as if I had much time for them recently... 20180709 05:53:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180709 05:53:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180709 06:04:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180709 06:12:18< irker937> wesnoth/wesnoth:master Nils Kneuper 8b7410317a updated Chinese (Simplified) translation AppVeyor: All builds passed 20180709 06:14:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180709 06:14:23-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180709 06:42:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180709 06:43:06-!- zookeeper_ [~lmsnie@95.175.104.93] has joined #wesnoth-dev 20180709 06:47:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20180709 06:49:32-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180709 06:50:09-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180709 06:54:57-!- Appleman1234 [~quassel@124.185.42.197] has quit [Ping timeout: 240 seconds] 20180709 07:20:54-!- zookeeper_ is now known as zookeeper 20180709 07:20:55-!- zookeeper [~lmsnie@95.175.104.93] has quit [Changing host] 20180709 07:20:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180709 08:04:55-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-tayhdajhcdorumxa] has quit [Ping timeout: 240 seconds] 20180709 08:21:08-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180709 08:29:16-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-mqjoxvykqqkhkcpv] has joined #wesnoth-dev 20180709 08:43:05< irker937> wesnoth/wesnoth:master Charles Dang c41da8255d GUI2: cleaned up a whole bunch of widget AppVeyor: All builds passed 20180709 09:55:11<+discordbot1> Apparently wesnoth.get_terrain_info is rather lenient until you actually try to get info about an illegal (as opposed to nonexistent) terrain. 20180709 09:55:12<+discordbot1> https://cdn.discordapp.com/attachments/259976436490829825/465818190749106176/unknown.png 20180709 10:02:36<+discordbot1> (That quits to the titlescreen, so there isn't any possibility to do error handling on the author's part.) 20180709 10:32:29< irker937> wesnoth/wesnoth:1.14 ville 386341aea7 Sort using translation::icompare for t_s AppVeyor: All builds passed 20180709 10:34:26< irker937> wesnoth/wesnoth:1.14 josteph 688050c4da Sidebar: Add jamming to the vision toolt AppVeyor: vs2015/Release Failed 20180709 10:34:27< irker937> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4171 20180709 10:39:11-!- gfg [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180709 11:03:32-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180709 11:11:05-!- Appleman1234 [~quassel@124.185.42.197] has quit [Ping timeout: 255 seconds] 20180709 11:24:44-!- gfgt [~androirc@tmo-119-133.customers.d1-online.com] has joined #wesnoth-dev 20180709 11:29:09-!- gfg [~androirc@134.76.63.8] has quit [Ping timeout: 264 seconds] 20180709 11:43:17-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180709 11:53:35-!- Appleman1234 [~quassel@124.185.42.197] has quit [Ping timeout: 245 seconds] 20180709 12:44:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20180709 12:50:06< irker937> wesnoth/wesnoth:1.14 Charles Dang 7da1c5673e Updated changelog AppVeyor: All builds passed 20180709 13:31:44-!- gfgt [~androirc@tmo-119-133.customers.d1-online.com] has quit [Ping timeout: 244 seconds] 20180709 13:34:24-!- gfgt [~androirc@tmo-119-133.customers.d1-online.com] has joined #wesnoth-dev 20180709 13:47:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180709 13:47:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180709 14:00:41-!- gfgt [~androirc@tmo-119-133.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180709 14:01:24-!- gfgt [~androirc@ersc142.goemobile.de] has joined #wesnoth-dev 20180709 14:09:27-!- gfgt [~androirc@ersc142.goemobile.de] has quit [Ping timeout: 244 seconds] 20180709 14:09:38-!- gfgt [~androirc@tmo-119-133.customers.d1-online.com] has joined #wesnoth-dev 20180709 14:21:38< irker937> wesnoth/wesnoth:master Charles Dang d8426ac37a Updated changelog AppVeyor: All builds passed 20180709 15:20:46-!- gfgt [~androirc@tmo-119-133.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180709 15:34:27< irker937> wesnoth/wesnoth:1.14 josteph 688050c4da Sidebar: Add jamming to the vision toolt AppVeyor: 2/4 builds failed 20180709 15:34:28< irker937> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4171 20180709 15:34:29< irker937> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-3886 20180709 16:14:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180709 16:15:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180709 16:25:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180709 16:25:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180709 16:45:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180709 16:48:34< irker937> wesnoth/wesnoth:1.14 josteph 374d4ab7c6 WML: Support the the 'jamming' key in [u AppVeyor: All builds passed 20180709 18:33:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180709 18:36:56< Ravana_> where to find documentation for wmlindent commands like "wmlxgettext"? 20180709 19:13:24< irker937> wesnoth/wesnoth:1.14 josteph 8473a1a199 THoT S9: Implement a victory condition c AppVeyor: All builds passed 20180709 19:15:25<+discordbot1> I think wmlindent has no options. for wmlxgettext, call it without arguments. Or here https://wmlxgettext-unoff.readthedocs.io/en/latest/enduser/index.html 20180709 19:23:42< Ravana_> these commands https://github.com/inferno8/wesnoth-Era_of_Magic/commit/669561795eb9cc7919505d8f3dd5bfc3f867c199#diff-f73bcbd58ca4ecf647eabd6334e2f566L38 20180709 19:32:53< Ravana_> looks like "# wmlindent: stop ignoring" is also possible 20180709 19:48:22< irker937> wesnoth: Severin Glöckner wesnoth:1.14 f595e4f75a8d / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S4: improve magican's movement behaviour https://github.com/wesnoth/wesnoth/commit/f595e4f75a8d11e899cbf35cc6be4edde1b649ab 20180709 20:09:23< Ravana_> I suspect [unit_type][variation][event] does not work, creating test case 20180709 20:23:27< irker937> wesnoth/wesnoth:1.14 josteph 695988b706 THoT S9: Implement a victory condition c AppVeyor: All builds passed 20180709 20:30:56< Ravana_> using ./run_wml_tests -c still results in 20180709 23:30:09 warning config: add-on 'DBG_Modification' has no _info.cfg; cannot read version info 20180709 20:37:27< Ravana_> unit test passed, so something else then 20180709 21:30:49< irker937> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) e90ddcd67d I forgot these AppVeyor: All builds passed 20180709 22:12:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180709 22:32:56-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180709 23:14:57<+discordbot1> wmlindent and wmllint's directives are almost all documented in the huge comment block at the start of both programs. 20180709 23:15:49<+discordbot1> At one point there were a couple of wmllint directives that weren't documented so you had to read the full source to find out they even existed. No idea if that's still the case with those or others. 20180709 23:24:40-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 260 seconds] 20180709 23:25:39-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180709 23:27:44< Ravana_> only those that are mentioned in the beginning are there now 20180709 23:28:43< Ravana_> doesn't explain why "wmlxgettext" comment affected wmlindent though 20180709 23:29:57-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 240 seconds] 20180709 23:31:28-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 256 seconds] 20180709 23:40:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180709 23:40:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180709 23:41:06< Ravana_> as "wmlxgettext" string is not included in wmlindent file 20180709 23:43:04< Ravana_> it has to work though, since it is used in 14 different ageless parts 20180709 23:49:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180709 23:53:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180709 23:55:05-!- Appleman1234 [~quassel@124.185.42.197] has joined #wesnoth-dev 20180709 23:57:58-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180709 23:59:17-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180709 23:59:42< irker937> wesnoth: Severin Glöckner wesnoth:master d4a6df034e9c / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S4: improve magican's movement behaviour https://github.com/wesnoth/wesnoth/commit/d4a6df034e9c67a17c84615a3306eaedd1905be2 --- Log closed Tue Jul 10 00:00:33 2018