--- Log opened Fri Jul 13 00:00:32 2018 20180713 00:17:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180713 00:17:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180713 00:17:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180713 00:24:49-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180713 00:32:29< celticminstrel> So what exactly was wrong with that dialogue sample in LoW, again? 20180713 00:47:08-!- irker832 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180713 01:26:44<+discordbot1> celmin: it's incredibly cringe-worthy 20180713 01:26:52< celmin> Do elaborate. 20180713 01:28:09<+discordbot1> and if @Yumi is correct, it's just one example of extreme "gushing useless damsel" on Cleodil's part. 20180713 01:28:42< celmin> Hmm. 20180713 01:28:50<+discordbot1> Well, not so much useless damsel, because she's useful (although her introduction is through the classic damsel in distress trope). 20180713 01:29:12<+discordbot1> But she's by all means a satellite character defined solely by her completely unexplained infatuation with Kalenz. 20180713 01:29:22< celmin> I see. 20180713 01:29:26< celmin> That is, indeed, not good. 20180713 01:29:34< celmin> But I don't see it as a grounds for dropping the campaign. 20180713 01:29:48<+discordbot1> I don't agree fully with Vultraz in dropping the campaign, I think it can be saved 20180713 01:29:58<+discordbot1> but I also wouldn't mind seeing it go for yet another reason 20180713 01:30:03< celmin> Oh? 20180713 01:30:06<+discordbot1> We can do better, certainly, and I'd rather see it improved rather than remove part of the backbone of the mainline epoch's timeline. 20180713 01:30:12< celmin> ^ 20180713 01:30:12<+discordbot1> celmin: remember that steam review that bashed the writing in wesnoth 20180713 01:30:15<+discordbot1> regarding the different races 20180713 01:30:20<+discordbot1> and specifically the elves? 20180713 01:30:25< celmin> Yeah. 20180713 01:30:39<+discordbot1> (I haven't seen that review incidentally, if anyone has a link in hand.) 20180713 01:30:49<+discordbot1> LoW is a far worse offender of elf-philia compared to the unit descriptions 20180713 01:30:54<+discordbot1> or even HttT 20180713 01:30:57< celmin> I see. 20180713 01:31:04<+discordbot1> Is it? 20180713 01:31:09<+discordbot1> at least to me it is 20180713 01:31:21< celmin> FTR, i haven't played it, so everything I know about it is by osmosis. 20180713 01:31:22<+discordbot1> in LoW the elves eradicate a huge number of saurians (as shadowm put it, basically a genocide) 20180713 01:31:32<+discordbot1> The elves are definitely portrayed in LoW (much like in UtBS) as a force that can be easily swayed into genocide. 20180713 01:31:44<+discordbot1> right, but you don't get that sense that it's a bad thing from the writing 20180713 01:32:02<+discordbot1> the only thing that anyone says is, we won't kill things with you anymore, Kalenz (Cleodil) 20180713 01:32:05< celmin> My impression was that elves have never gotten along too well with saurians. 20180713 01:32:07<+discordbot1> but you go ahead and do it, npnp 20180713 01:32:34<+discordbot1> and we're not supposed to hate Kalenz for literally trying to wipe out an entire race, or at least cripple them severely 20180713 01:32:39<+discordbot1> I'll say I don't remember exactly what drove Kalenz to take action against Landar at the end. 20180713 01:32:45<+discordbot1> Landar attacked him 20180713 01:32:46<+discordbot1> lol 20180713 01:33:02<+discordbot1> Oh. 20180713 01:34:24<+discordbot1> and that's after wiping out the Ka'lian (or maybe it was just some elvish council) off screen, and not even in story text 20180713 01:34:47<+discordbot1> one scenario, the council goes hey Kalenz, we know you did all these things, and great, but we should have been the ones to make that decision, not you 20180713 01:34:48<+discordbot1> you can go now 20180713 01:34:59<+discordbot1> next scenario, council is dead and Landar attacks Kalenz 20180713 01:35:25< celmin> …WTH 20180713 01:35:31< celmin> Why is the council suddenly dead 20180713 01:35:35<+discordbot1> right? 20180713 01:35:41<+discordbot1> so they say 20180713 01:35:44<+discordbot1> Landar seized control of the army 20180713 01:35:48<+discordbot1> and killed the council 20180713 01:36:17<+discordbot1> [message] id=Galenor message= _ "My lord Kalenz, you are in great danger! You must leave here immediately." [/message] [message] id=Kalenz message= _ "What?!" [/message] [message] id=Galenor message= _ "Landar has seized control of the army. He has eliminated the council and proclaimed himself High Warlord of the Elves. What is 20180713 01:36:17<+discordbot1> worse, there is word out that he has already ordered your assassination." [/message] [message] id=Crintil message= _ "Too late! All traitors will die!" [/message] [message] id=Kalenz message= _ "Listen to me! We have fought and bled side by side. We must trust in each other and face the Orcs together!" [/message] [message] id=Oblil 20180713 01:36:18<+discordbot1> message= _ "Do not listen to this traitor! You have all heard the order!" [/message] 20180713 01:36:40< celmin> . . . 20180713 01:36:48<+discordbot1> and a sample of text from the end of the previous scenario 20180713 01:36:50<+discordbot1> the very previous thing we read 20180713 01:36:53<+discordbot1> [part] background="story/characters/lord.png" scale_background=no story={CAPTION ( _ "El’Isomithir")} + _ "The council is not blind to these benefits. But, still, you cannot decide high matters of statecraft on behalf of the Elves. We cannot allow it." [/part] [part] background="story/characters/galtrid.png" scale_background=no story={CAPTION ( 20180713 01:36:54<+discordbot1> _ "Galtrid")} + _ "If it weren’t for Kalenz and his men, none of us would be here to argue the point today." [/part] [part] background="story/characters/uradredia.png" scale_background=no story={CAPTION ( _ "Uradredia")} + _ "I agree. What’s done is done. Let us concentrate on the future, not the past." [/part] [part] background="portraits/dionli.png" 20180713 01:36:54<+discordbot1> scale_background=no story={CAPTION ( _ "Lady Dionli")} + _ "Kalenz, the council has decided that you are to be stripped of all military authority. You may now go." [/part] [part] background="story/characters/kalenz.png" scale_background=no story={CAPTION ( _ "Kalenz")} + _ "I lay down my burden humbly and gladly. But we need to have a strong army, as the orcs will return!" 20180713 01:36:55< celmin> (I'm beginning to think maybe I didn't miss much by not playing it.) 20180713 01:36:55<+discordbot1> [/part] [part] background="story/characters/landar.png" scale_background=no story={CAPTION ( _ "Landar")} + _ "Cowards and traitors!" [/part] 20180713 01:37:05<+discordbot1> so we transition from this 20180713 01:37:07<+discordbot1> into instantly 20180713 01:37:14<+discordbot1> Landar took control of the army and now the council is dead! 20180713 01:37:35<+discordbot1> there is this transition 20180713 01:37:38< celmin> Yeah that's… utterly crazy. 20180713 01:37:42<+discordbot1> [part] story= _ "After the council’s decision, Kalenz and Cleodil retired in the North." delay=4000 {LOW_BIGMAP} {CIVILWAR_STAGE1} [/part] [part] story= _ "Free of the pressure of war, they took delight in each other. The heart-bond they had formed amidst peril and death grew closer, and all but vanquished the remnant evil Crelanu’s philter had left in 20180713 01:37:42<+discordbot1> Kalenz. The two began to think of having children." delay=8000 [/part] [part] story= _ "But their peace was not to last. In the outer world, the blood tides were rising. And in the heart of Landar, who had once been their friend, evil was not vanquished, but festered and grew..." delay=8000 [/part] 20180713 01:38:00 * celmin almost considered adding another word to that which means the same thing as "guano". 20180713 01:38:02<+discordbot1> sooo maybe you can argue that Landar did some amazing machinations in those years 20180713 01:38:10<+discordbot1> but yeah 20180713 01:38:15<+discordbot1> this is why I wouldn't miss it 20180713 01:38:19< celmin> Yeah okay, so there was a time-skip, huh. 20180713 01:38:21<+discordbot1> if Vultraz decided to say byebye to LoW 20180713 01:38:30<+discordbot1> this writing... 20180713 01:38:34< celmin> I still think it would be better to rewrite it. 20180713 01:38:40<+discordbot1> I'm not against that either 20180713 01:38:42< celmin> Make Cleodil a co-protagonist. 20180713 01:38:46<+discordbot1> however 20180713 01:38:52< celmin> Maybe eliminate Landar altogether, I dunno, 20180713 01:38:56<+discordbot1> No-one seems to acknowledge the need to consolidate the timeline. :p 20180713 01:38:59< celmin> High Warlord of the Elves? Seriously? 20180713 01:39:03<+discordbot1> that would be the reason to keep LoW 20180713 01:39:08<+discordbot1> to consolidate the timeline, precisely 20180713 01:39:15<+discordbot1> however, I would suggest shortening it 20180713 01:39:20< celmin> How long is it now? 20180713 01:39:26<+discordbot1> remember, there's 24 scenarios 20180713 01:39:26< celmin> Five chapters IIRC... 20180713 01:39:28<+discordbot1> of a story like this 20180713 01:39:36<+discordbot1> they aren't all short either 20180713 01:39:38< celmin> That's still shorter than HTTT though, right? 20180713 01:39:44<+discordbot1> HTTT is 23, I think 20180713 01:39:47< celmin> Oh, okay. 20180713 01:39:53< celmin> Is the 24 counting cutscene scenarios? 20180713 01:39:56<+discordbot1> yes 20180713 01:39:58< celmin> (And the 23 for that matter) 20180713 01:39:59<+discordbot1> There's only so much you can do on the writing side before you also need to get onto the scenarios 20180713 01:40:08<+discordbot1> but even with cutscene scenarios 20180713 01:40:16<+discordbot1> I feel like LoW could easily just be a 12 scenario campaign, tops 20180713 01:40:22< celmin> Half the length, huh. 20180713 01:40:30<+discordbot1> for comparison 20180713 01:40:42<+discordbot1> UtBS is 13 20180713 01:40:44< celmin> That's almost gonna be "scrap everything and start over from scratch", isn't it? 20180713 01:40:48< celmin> Though... 20180713 01:40:49<+discordbot1> and covers substantially more story than LoW 20180713 01:40:58<+discordbot1> SoF is only 9 20180713 01:40:59< celmin> If we did that it could be redesigned as an MP campaign from square one. 20180713 01:41:03<+discordbot1> yes 20180713 01:41:25<+discordbot1> we have an option of 20180713 01:41:34<+discordbot1> also ignoring the NR rewrite 20180713 01:41:36< celmin> A co-op, probably one player takes Cleodil and the other takes Kalenz; though for that to really work, every scenario needs to have both of them present. 20180713 01:41:37<+discordbot1> and doing a LoW rewrite 20180713 01:41:50< celmin> How bad is NR in comparison? 20180713 01:41:51<+discordbot1> but 20180713 01:42:00<+discordbot1> I have to confess that it's even less appealing to work on LoW 20180713 01:42:01<+discordbot1> than NR 20180713 01:42:09<+discordbot1> I'd rather just drop LoW because other campaigns could use rewrites first 20180713 01:42:10< celmin> Why's that? 20180713 01:42:15<+discordbot1> in NR 20180713 01:42:26< celmin> That's at Yumi not Vultraz FTR 20180713 01:42:28<+discordbot1> despite there being male!Mary Sue and harem!co 20180713 01:42:36< celmin> Huhwhat? 20180713 01:42:41<+discordbot1> namely 20180713 01:42:49< celmin> BTW male!Mary Sue = Marty Stu 20180713 01:42:49<+discordbot1> perfect, can do nothing wrong, confident, Tallin 20180713 01:42:59<+discordbot1> and his supporting group who fangirls over him endlessly 20180713 01:43:04< celmin> I see... 20180713 01:43:07<+discordbot1> I still feel that they are characters that can be worked wit 20180713 01:43:08<+discordbot1> h 20180713 01:43:12<+discordbot1> well that's a term i haven't heard before 20180713 01:43:13<+discordbot1> and that are somewhat memorable 20180713 01:43:19< celmin> What, Vultraz? 20180713 01:43:20<+discordbot1> the plot is also reasonably good, even in the original 20180713 01:43:21< celmin> Marty Stu? 20180713 01:43:22<+discordbot1> I thought it was Gary 20180713 01:43:32 * celmin shrugs. 20180713 01:43:55<+discordbot1> gameplay-wise, it fills the niche of large-scale battles 20180713 01:44:04<+discordbot1> (obviously as is, they're a bit... crazy) 20180713 01:44:04< celmin> So are Cleodil, Kalenz, and Landar the only characters in LoW? 20180713 01:44:17<+discordbot1> in LoW 20180713 01:44:27<+discordbot1> the only (half) character is basically Landar 20180713 01:44:32<+discordbot1> the rest are mannequins with names 20180713 01:44:47< celmin> Don't both Kalenz and Cleodil appear in other campaigns though? 20180713 01:44:57<+discordbot1> Kalenz in httt 20180713 01:45:01<+discordbot1> don't think Cleodil appears elsewhere 20180713 01:45:04< celmin> DM? 20180713 01:45:09<+discordbot1> 🤔 20180713 01:45:20< celmin> Unless that was a different shyde. 20180713 01:45:37<+discordbot1> I don't remember, DM was not a particularly great campaign either 20180713 01:45:42< celmin> I think she actually appeared in HTTT1 too as an allied leader, so maybe that was a different shyde. 20180713 01:45:47<+discordbot1> but not quite as.... eh... as LoW 20180713 01:45:57< celmin> I liked DM up to, well… the point where the king appears, I think? 20180713 01:46:00<+discordbot1> i think she appears in httts1 20180713 01:46:16< celmin> Are these both Cleodil then? 20180713 01:46:20<+discordbot1> no that would be Chantal 20180713 01:46:22<+discordbot1> in Httt S1 20180713 01:46:24< celmin> Ah, Chantal. 20180713 01:46:29< celmin> Okay, different shyde, got it. 20180713 01:46:45<+discordbot1> I'm afraid I can't recall the shyde in DM 20180713 01:46:46<+discordbot1> anyway 20180713 01:46:54< celmin> Pretty sure it was Chantal. 20180713 01:46:56<+discordbot1> Chantal. 20180713 01:47:01< celmin> Since ISTR it being the same as in HTTT. 20180713 01:47:08<+discordbot1> NR would be vastly more enjoyable to work with than LoW for me 20180713 01:47:17<+discordbot1> She was also retconned to be Kalenz's grand-daughter. 20180713 01:47:20<+discordbot1> and I'm sure you already know how I feel about NR 20180713 01:47:22< celmin> Then, I'd suggest doing NR. 20180713 01:47:27<+discordbot1> so that just tells you 20180713 01:47:33<+discordbot1> how - eh - LoW is 20180713 01:47:33< celmin> Don't work on what you don't want to, basically. 20180713 01:47:35<+discordbot1> to me 20180713 01:47:47<+discordbot1> in that case 20180713 01:47:50<+discordbot1> I would just work on my campaign 20180713 01:47:52<+discordbot1> lol 20180713 01:48:08<+discordbot1> we have some Good Ideas for NR 20180713 01:48:09< celmin> Maybe I could like… put together a "skeleton" of a new LoW if someone provided a plot outline. 20180713 01:48:13<+discordbot1> oh yeah 20180713 01:48:26<+discordbot1> celmin: do you know the plot of NR more or less 20180713 01:48:29< celmin> Like something that's playable on medium difficulty or something. 20180713 01:48:33<+discordbot1> don't remember if you played it 20180713 01:48:40< celmin> I haven't played NR. 20180713 01:48:47< celmin> I probably don't know more than the synopsis. 20180713 01:48:51<+discordbot1> we are considering introducing Mal Keshar into NR 20180713 01:48:53<+discordbot1> in place of Malifor 20180713 01:48:59<+discordbot1> not sure if that means anything to you 20180713 01:49:13< celmin> Which is like, the north Wesnothians rise up against the crown and join the dwarves and orcs in the Knalgan Alliance, right? 20180713 01:49:20< celmin> Isn't Mal Keshar the DiD protag? 20180713 01:49:23<+discordbot1> yes 20180713 01:49:32< celmin> And Malifor is just a randonecro? 20180713 01:49:35<+discordbot1> yes 20180713 01:49:46< celmin> Well, continuity is great, so that sounds fine to me. 20180713 01:49:53<+discordbot1> 😄 20180713 01:50:03< celmin> I haven't played DiD either, mind you. 20180713 01:50:08<+discordbot1> celmin 20180713 01:50:13< celmin> ? 20180713 01:50:14<+discordbot1> What mainline campaigns have you actually played? 20180713 01:50:28< celmin> HTTT, TSG, AOI, AToTB, DW, part of DM, part of SotBE. 20180713 01:50:40<+discordbot1> Okay, I see. 20180713 01:51:16< celmin> Why do you ask? 20180713 01:51:24<+discordbot1> No particular reason. 20180713 01:51:31< celmin> I do want to finish SotBE but that'll probably mean starting over. 20180713 01:52:15< celmin> In DM I think I got to the point where the king appears or something. 20180713 01:52:33< celmin> SotBE… IIRC I had just reached the coast or something. 20180713 02:07:07<+discordbot1> @Vultraz revised some of the intro text for NR 20180713 02:07:49<+discordbot1> oh wait 20180713 02:07:51<+discordbot1> I need to push it first 20180713 02:08:17<+discordbot1> https://raw.githubusercontent.com/nemaara/Northern-Rebirth-Reborn/master/S00_Cutscene.txt 20180713 02:28:38<+discordbot1> @Yumi it looks alright so far (haven't read the dialog) but the last story block seems a bit too matter-of-factly 20180713 02:36:47<+discordbot1> dialog looking alright 20180713 03:31:16-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180713 03:43:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 03:43:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 04:10:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 04:11:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 04:20:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 04:21:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 04:24:45-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180713 04:32:08-!- irker683 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180713 04:32:08< irker683> wesnoth/wesnoth:master DisherProject 0374a80482 DM: add some TODOs AppVeyor: All builds passed 20180713 04:49:27< irker683> wesnoth: Charles Dang wesnoth:master ce85c170200a / src/ (build_info.cpp config.cpp tstring.cpp): Convert a few remaining C-style casts (for char) too static_cast https://github.com/wesnoth/wesnoth/commit/ce85c170200aee86ebd0b7a98ef7102a03e62dd5 20180713 04:51:10<+discordbot1> I'd prefer 't' instead of static_cast(9). 20180713 04:51:43<+discordbot1> isn't that tab? 20180713 04:51:54<+discordbot1> Yes, the tab character. 20180713 05:08:54-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 05:08:55< travis-ci> wesnoth/wesnoth#18853 (master - ce85c17 : Charles Dang): The build is still failing. 20180713 05:08:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403407533 20180713 05:08:55-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 05:11:35-!- lilinitsy_ [~demonitsy@75-168-31-203.mpls.qwest.net] has joined #wesnoth-dev 20180713 05:14:51<+discordbot1> Yumi, the dialogue voice seems a lot better. 20180713 05:16:40< irker683> wesnoth: Charles Dang wesnoth:master 4c29a0dd5895 / src/config.cpp: Use '\t' instead of static_cast(9) https://github.com/wesnoth/wesnoth/commit/4c29a0dd5895784b94a2393feddf0613742f3a0c 20180713 05:16:43< irker683> wesnoth: Charles Dang wesnoth:master f7cf73307beb / src/ (4 files in 3 dirs): Convert some more C arrays to std::array https://github.com/wesnoth/wesnoth/commit/f7cf73307bebe7acabe2bd54b240915f27d0a349 20180713 05:35:49-!- travis-ci [~travis-ci@ec2-54-224-184-15.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 05:35:50< travis-ci> wesnoth/wesnoth#18854 (master - f7cf733 : Charles Dang): The build is still failing. 20180713 05:35:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403412640 20180713 05:35:50-!- travis-ci [~travis-ci@ec2-54-224-184-15.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 05:37:18<+discordbot1> Dunno why one of he XCode builds is failing 20180713 05:48:58<+discordbot1> It broke when you removed players_changelog. 20180713 05:49:21<+discordbot1> Probably some script tries to convert line endings or text encoding or something. 20180713 05:54:05<+discordbot1> @hrubymar10 could you take a look? 20180713 05:58:17< irker683> wesnoth: Charles Dang wesnoth:1.14 7e5902beedaf / utils/travis/check_utf8.sh: Remove reference to players_changelog https://github.com/wesnoth/wesnoth/commit/7e5902beedafd73c2ed16f09c1efc4c301dfa579 20180713 05:58:38< irker683> wesnoth: Charles Dang wesnoth:master 5bb72d7c8987 / utils/travis/check_utf8.sh: Remove reference to players_changelog https://github.com/wesnoth/wesnoth/commit/5bb72d7c8987ba4bb3ff734efe54d9c33c0d19b5 20180713 06:00:18<+discordbot1> @hrubymar10 nevemind 20180713 06:02:37<+discordbot1> (looks like 1.14 isn't set to fail) 20180713 06:04:40<+discordbot1> celmin: new mac book pros are out 20180713 06:05:53<+discordbot1> The pricing is even more insane than before. 😐 20180713 06:05:56<+discordbot1> https://www.reddit.com/r/hardware/comments/8y9elz/apple_updates_macbook_pro_lineup_with_8th_gen/e294aeu 20180713 06:06:40<+discordbot1> dayumn 20180713 06:06:54< irker683> wesnoth/wesnoth:1.14 Charles Dang 79173e4faf Removed players_changelog.md AppVeyor: All builds passed 20180713 06:39:44-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 06:39:45< travis-ci> wesnoth/wesnoth#18856 (master - 5bb72d7 : Charles Dang): The build is still failing. 20180713 06:39:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403420579 20180713 06:39:45-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 06:46:53-!- zookeeper_ [~lmsnie@95.175.104.73] has joined #wesnoth-dev 20180713 06:51:05-!- zookeeper_ is now known as zookeeper 20180713 06:51:08-!- zookeeper [~lmsnie@95.175.104.73] has quit [Changing host] 20180713 06:51:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180713 07:11:45<+discordbot1> I swear I will never understand the rules for std::array initialization 20180713 07:14:51<+discordbot1> it seems to require many extraneous brackets 20180713 07:17:08<+discordbot1> and the exact ones required differ by compiler 20180713 07:20:17< irker683> wesnoth: Charles Dang wesnoth:master 64067dde09aa / src/ (display.cpp generators/default_map_generator_job.cpp): Attempt to fixup f7cf733 https://github.com/wesnoth/wesnoth/commit/64067dde09aa5a802bd48b0e0fad39678a021892 20180713 07:25:22<+discordbot1> actually, hang on 20180713 07:25:24<+discordbot1> 🤔 20180713 07:25:33<+discordbot1> I think i messed that up 20180713 07:26:33<+discordbot1> @jyrkive what exactly does const int castle_array[13][2] mean? I think I might have converted it wrong. 20180713 07:27:13<+discordbot1> I think I made it "2 arrays of 13 length", but I think it might mean "13 arrays of 2 length" 20180713 07:28:06<+discordbot1> Judging from the previous code, it indeed means "13 arrays of length 2". 20180713 07:28:38<+discordbot1> ok, then I was correct 20180713 07:28:41<+discordbot1> std::array, 13> 20180713 07:31:09< irker683> wesnoth: Charles Dang wesnoth:master 8abb1965cb79 / src/image_modifications.cpp: Fixup f7cf733 again https://github.com/wesnoth/wesnoth/commit/8abb1965cb79d64d3172d578ac539fc5f675323f 20180713 07:38:33<+discordbot1> looks like arrays always need double brackets 20180713 07:39:36<+discordbot1> though SO says single is allowed in cases like for ints...? 20180713 07:39:42<+discordbot1> but that just raised an error 20180713 07:39:44<+discordbot1> oh well 20180713 07:39:45<+discordbot1> ¯_(ツ)_/¯ 20180713 07:40:37<+discordbot1> It was only the macOS SCons build that failed. 20180713 07:41:03<+discordbot1> Maybe the single-brace extension isn't supported in the version of Clang that build uses. 20180713 07:46:00-!- Appleman1234 [~quassel@1.120.98.249] has quit [Ping timeout: 268 seconds] 20180713 07:53:08-!- lilinitsy_ [~demonitsy@75-168-31-203.mpls.qwest.net] has quit [Remote host closed the connection] 20180713 07:55:59-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 07:56:00< travis-ci> wesnoth/wesnoth#18858 (master - 8abb196 : Charles Dang): The build passed. 20180713 07:56:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403443056 20180713 07:56:00-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 07:56:19<+discordbot1> finally 20180713 07:59:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180713 08:04:12-!- valdar [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180713 08:11:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180713 08:21:38< irker683> wesnoth: Charles Dang wesnoth:Lua_5.3.5 e9fddd4f22ef / / (60 files in 3 dirs): Upgrade to Lua 5.3.5 https://github.com/wesnoth/wesnoth/commit/e9fddd4f22ef8020a8f9fd25c0a60922c8bd0151 20180713 08:21:41< irker683> wesnoth: Charles Dang wesnoth:Lua_5.3.5 c6a1b2cd59b7 / src/lua/luaconf.h: Reapply d0100758f855ec0d8f30dff41e8a8b6ff2d45fda https://github.com/wesnoth/wesnoth/commit/c6a1b2cd59b706855b00d2ebf9da6dd740640957 20180713 08:58:34< irker683> wesnoth/wesnoth:master Charles Dang 5595c12e93 Removed players_changelog.md AppVeyor: All builds passed 20180713 09:23:48-!- hryniuk [~hryniuk@dynamic-78-8-64-227.ssp.dialog.net.pl] has joined #wesnoth-dev 20180713 09:38:21-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 09:38:21< travis-ci> wesnoth/wesnoth#18859 (Lua_5.3.5 - c6a1b2c : Charles Dang): The build passed. 20180713 09:38:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403455781 20180713 09:38:21-!- travis-ci [~travis-ci@ec2-54-167-158-100.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 09:41:43-!- vladimirslavik [vslavik@nat/redhat/x-uuaapaxbkyxatshv] has joined #wesnoth-dev 20180713 10:01:41< irker683> wesnoth: Charles Dang wesnoth:1.14 e9fddd4f22ef / / (60 files in 3 dirs): Upgrade to Lua 5.3.5 https://github.com/wesnoth/wesnoth/commit/e9fddd4f22ef8020a8f9fd25c0a60922c8bd0151 20180713 10:01:44< irker683> wesnoth: Charles Dang wesnoth:1.14 c6a1b2cd59b7 / src/lua/luaconf.h: Reapply d0100758f855ec0d8f30dff41e8a8b6ff2d45fda https://github.com/wesnoth/wesnoth/commit/c6a1b2cd59b706855b00d2ebf9da6dd740640957 20180713 10:03:12-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180713 10:04:45< irker683> wesnoth: Charles Dang wesnoth:master 264389807c1c / / (60 files in 3 dirs): Upgrade to Lua 5.3.5 https://github.com/wesnoth/wesnoth/commit/264389807c1cb789a3cfc3c386da049becdfbe67 20180713 10:04:48< irker683> wesnoth: Charles Dang wesnoth:master 8fcd3f2a8336 / src/lua/luaconf.h: Reapply d0100758f855ec0d8f30dff41e8a8b6ff2d45fda https://github.com/wesnoth/wesnoth/commit/8fcd3f2a833682a95c7d175d6a48cc42fa5e0c2d 20180713 10:04:51< irker683> wesnoth: Charles Dang wesnoth:master d5972c6f43e7 / changelog.md: Synced 1.14.3+dev changelog section with the 1.14 branch https://github.com/wesnoth/wesnoth/commit/d5972c6f43e7cf8da54f02083b11b1d35451b509 20180713 10:05:43<+discordbot1> deleted the gfgtdf-patch-1 branch. 20180713 10:06:59<+discordbot1> (and the Lua_5.3.5 branch, ofc) 20180713 10:18:19-!- Appleman1234 [~quassel@1.120.98.249] has joined #wesnoth-dev 20180713 10:43:41-!- DeFender1031 [~DeFender1@93-173-122-186.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180713 10:46:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180713 10:46:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Client Quit] 20180713 10:57:27-!- louis94 [~~louis94@91.178.69.90] has quit [Ping timeout: 240 seconds] 20180713 10:57:51-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Excess Flood] 20180713 11:07:09-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180713 11:51:05-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 240 seconds] 20180713 11:59:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180713 12:01:02< irker683> wesnoth/wesnoth:1.14 Charles Dang 7e5902beed Remove reference to players_changelog AppVeyor: All builds passed 20180713 12:18:13<+discordbot1> what's the proper way to have an rvalue reference drop down to a second function? 20180713 12:18:22< celticminstrel> What do you mean. 20180713 12:18:31< celticminstrel> Like passing it on to a second function? 20180713 12:18:39< celticminstrel> Is this a generic (template) function? 20180713 12:18:45< celticminstrel> The one calling, not the one being called. 20180713 12:19:48<+discordbot1> say you have T foo; and a function func(T&& a) { func2(a); } where func2 also takes T&& 20180713 12:20:12< celticminstrel> IIRC you want std::forward(a) for perfect forwarding. 20180713 12:23:04<+discordbot1> Prefer std::move(a) if it's not a template function. 20180713 12:23:23< celticminstrel> If func isn't a template, or if func2 isn't a template? 20180713 12:23:33< celticminstrel> IIRC you don't really need forward ever if func is not a template. 20180713 12:23:35<+discordbot1> func. 20180713 12:23:48< celticminstrel> Okay, that's pretty much what I thought too. 20180713 12:24:19<+discordbot1> ah, so move is to be used on rvalue references too... 20180713 12:24:34<+discordbot1> std::forward() is intended for situations where a can be either an lvalue or an rvalue reference, which is possible if func() is a template. 20180713 12:24:55<+discordbot1> std::move() does nothing else than casting a value to an rvalue. 20180713 12:25:25< celticminstrel> Note that a variable declared as an rvalue reference is not an rvalue. 20180713 12:25:46< celticminstrel> Which is why you need to use move or forward when passing it on to another function. 20180713 12:29:16<+discordbot1> is working on that "move nodes instead of deleting them" thing for MP Staging and Join Game 20180713 12:30:23<+discordbot1> seems to work \o/ 20180713 12:31:05<+discordbot1> with about 10 std::move calls 😬 20180713 12:36:04<+discordbot1> Does it provide a noticeable performance improvement? 20180713 12:36:11<+discordbot1> If not, it's kind of pointless... 20180713 12:41:20<+discordbot1> Didn't benchmark, but likely. Setting up a new side node and its contents is a long process (~250 lines long involving the construction of a large number of widgets). Not to mention while it isn't an issue right now (since there's a way around it), it also avoids pitfalls in the future regarding callbacks destroying the widgets to which they were bound, such as gfgtdf was originally experiencing. 20180713 12:42:51<+discordbot1> and plus I intended to do this originally when I wrote the dialog anyway 20180713 12:42:58<+discordbot1> just didn't get the implementation right 20180713 12:49:02< celticminstrel> I think it's not pointless for a reason completely separate from performance? 20180713 12:49:11< celticminstrel> The thing about the callbacks. 20180713 12:49:32< celticminstrel> It may no 100% avoid that (not sure) but it would certainly make it less likely. 20180713 12:50:47<+discordbot1> it's also a useful thing to have in general 20180713 12:51:09<+discordbot1> basically i'm adding an interface that allows you to move a node to a new parent 20180713 12:52:05< celticminstrel> Could you even move it from one tree view to a different tree view? 20180713 12:52:28< celticminstrel> Might want to consider whether that can be allowed and, if not, add checks for it. 20180713 12:52:59<+discordbot1> not as of now 20180713 12:53:21<+discordbot1> could be allowed easily enough if a use was found for it 20180713 12:53:34< celticminstrel> I have a feeling that that wouldn't work very well, so if you're not explicitly supporting it, I suggest adding checks to ensure it doesn't happen by mistake. 20180713 12:54:36< celticminstrel> (Maybe my feeling is unfounded, I dunno; certainly it's very unlikely that the new tree view has a matching definition for the node, but maybe it doesn't actually need a definition for a node that has already been constructed.) 20180713 12:54:49<+discordbot1> only thing a little iffy about my implementation is is_root_node() would return true for a detached node 20180713 12:55:24<+discordbot1> though i could just avoid clearning parent_node_ 20180713 12:55:27<+discordbot1> that would solve that 20180713 12:55:31<+discordbot1> In a way, a detached node indeed is a root node. 20180713 12:55:42<+discordbot1> alright, I'll just add a doc note 20180713 12:55:52<+discordbot1> I think leaving parent_node_ set would be worse. 20180713 12:57:10< celticminstrel> Yeah an orphaned node would be a root node though. 20180713 12:57:33< celticminstrel> I think the way to distinguish an orphaned node from the root node of an actual tree view would be that there's no pointer to a tree view anywhere. 20180713 12:57:54< celticminstrel> (I think nodes do have a pointer to the parent tree view, don't they? I could be mistaken.) 20180713 12:58:00<+discordbot1> they do 20180713 12:58:14<+discordbot1> should i clear it too? 20180713 12:58:28< celticminstrel> Uhh. Not if you're moving the node around within that tree view. 20180713 12:58:48<+discordbot1> it could be re-set later 20180713 12:58:55<+discordbot1> (what I do with the parent node) 20180713 12:58:57<+discordbot1> (ptr) 20180713 12:59:03< celticminstrel> But if you wanted to detach the node from the tree view, maybe move it to a different tree view? Of course clear it. (And add an is_orphaned() function that checks if it's null, if you do want to go that way.) 20180713 12:59:18< celticminstrel> Yeah but why clear and re-set it when you basically know it'll just be re-set to the same value? 20180713 12:59:37<+discordbot1> in caase iw as supporting moving to a different tree view 20180713 13:00:01< celticminstrel> Anyway if you're planning to support moving to another tree view and you think that would be useful then sure I guess you can do that. 20180713 13:00:24< celticminstrel> Don't forget is_orphaned(). 20180713 13:00:40< celticminstrel> Especially if that's something that's likely to happen. 20180713 13:00:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180713 13:01:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180713 14:35:46< irker683> wesnoth/wesnoth:master Charles Dang 8abb1965cb Fixup f7cf733 again AppVeyor: All builds passed 20180713 15:41:20-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180713 16:04:13-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:04:16-!- vladimirslavik [vslavik@nat/redhat/x-uuaapaxbkyxatshv] has quit [Quit: Leaving] 20180713 16:08:48-!- Ivanovic_ [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:08:48-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20180713 16:09:35-!- Ivanovic_ [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Client Quit] 20180713 16:10:51< irker683> wesnoth/wesnoth:Lua_5.3.5 Charles Dang c6a1b2cd59 Reapply d0100758f855ec0d8f30dff41e8a8b6f AppVeyor: All builds passed 20180713 16:12:10-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:16:52-!- Ivanovic_ [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:18:57-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20180713 16:19:03-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:19:11-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 16:19:11-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 16:21:34-!- Ivanovic_ [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 20180713 16:26:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 16:26:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 16:31:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 16:31:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 16:38:44-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180713 16:39:47-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:39:48-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 16:39:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 16:41:03-!- gfg [~androirc@tmo-119-133.customers.d1-online.com] has joined #wesnoth-dev 20180713 16:43:07-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit] 20180713 16:45:42-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:45:42-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 16:45:42-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 16:50:39-!- gfg [~androirc@tmo-119-133.customers.d1-online.com] has quit [Remote host closed the connection] 20180713 16:52:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180713 16:52:34-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:52:46-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 16:52:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 16:58:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180713 16:58:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180713 16:58:44-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 16:58:45-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 16:58:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 17:03:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 17:03:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 17:13:17-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180713 17:13:54-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 17:13:55-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 17:13:55-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 17:15:10-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit] 20180713 17:15:46-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180713 17:15:46-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180713 17:15:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180713 17:34:14-!- hryniuk [~hryniuk@dynamic-78-8-64-227.ssp.dialog.net.pl] has quit [Quit: Leaving] 20180713 18:20:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180713 18:21:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180713 18:28:16-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev 20180713 18:47:50<+discordbot1> @zookeeper Do you know who created the mounted general sprites from TSG? https://github.com/wesnoth/wesnoth/commit/f5517b69944c1c23a766015a94702b124860856b 20180713 18:54:07<+discordbot1> @Vultraz , what do you think? Should I rebase this PR or close? https://github.com/wesnoth/wesnoth/pull/3332 20180713 19:21:34<+discordbot1> could you rebease just to remove players_changelog 20180713 19:32:08< irker683> wesnoth: Charles Dang wesnoth:1.14 e247892616ac / src/gui/ (5 files in 2 dirs): GUI2/Tree View: added interface for moving nodes between parent nodes https://github.com/wesnoth/wesnoth/commit/e247892616aca160fea8df5d34fcca52c891baf2 20180713 19:32:11< irker683> wesnoth: Charles Dang wesnoth:1.14 59195f0274b8 / src/gui/dialogs/multiplayer/ (mp_staging.cpp mp_staging.hpp): MP Staging: move side nodes when changing teams instead of recreating them https://github.com/wesnoth/wesnoth/commit/59195f0274b8432d80bcfcb6bece18c47aa34c36 20180713 19:38:30< irker683> wesnoth: Charles Dang wesnoth:master fa7c967c0a36 / src/gui/ (5 files in 2 dirs): GUI2/Tree View: added interface for moving nodes between parent nodes https://github.com/wesnoth/wesnoth/commit/fa7c967c0a3645734d93d56c1ade8ca394d20846 20180713 19:38:33< irker683> wesnoth: Charles Dang wesnoth:master ae7d05e8fc86 / src/gui/dialogs/multiplayer/ (mp_staging.cpp mp_staging.hpp): MP Staging: move side nodes when changing teams instead of recreating them https://github.com/wesnoth/wesnoth/commit/ae7d05e8fc8618aa247aae04b3a03431f7b0f0a7 20180713 19:38:36< irker683> wesnoth: Charles Dang wesnoth:master 8da9f0cc04e8 / src/gui/widgets/tree_view_node.hpp: GUI2/Tree View Node: used std::make_shared when possible https://github.com/wesnoth/wesnoth/commit/8da9f0cc04e8cdca1c98aa42bbfbc7d8ba02ab9f 20180713 19:38:40<+discordbot1> All the std::move is a bit excessive on master since nodes use shared_ptrs now, but meh 20180713 20:00:46< zookeeper> @Pentarctagon those must be frankensteins by me 20180713 20:01:55<+discordbot1> any idea who the original creator was? 20180713 20:02:38-!- travis-ci [~travis-ci@ec2-184-73-70-128.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 20:02:39< travis-ci> wesnoth/wesnoth#18863 (1.14 - 59195f0 : Charles Dang): The build passed. 20180713 20:02:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403699619 20180713 20:02:39-!- travis-ci [~travis-ci@ec2-184-73-70-128.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 20:03:20< zookeeper> i mean they seem like they were the same as horseman-commander, except with some bits of what i presume to be the core knight sprite 20180713 20:04:08<+discordbot1> yeah, those were committed by Eleazar, but I wasn't able to find anything more specific on the forums about them. 20180713 20:04:17< zookeeper> so, uh, the original ones... no idea 20180713 20:04:30<+discordbot1> alright 20180713 20:05:03< zookeeper> ah, hmm, probably by aelius himself 20180713 20:07:45<+discordbot1> 0 20180713 20:08:57< zookeeper> oh wow, it's pretty cool to have attachments like this from 2004 still visible: https://forums.wesnoth.org/viewtopic.php?p=55725#p55725 20180713 20:11:29<+discordbot1> huh 20180713 20:11:31<+discordbot1> neat 20180713 20:17:59-!- travis-ci [~travis-ci@ec2-184-73-70-128.compute-1.amazonaws.com] has joined #wesnoth-dev 20180713 20:18:00< travis-ci> wesnoth/wesnoth#18864 (master - 8da9f0c : Charles Dang): The build passed. 20180713 20:18:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/403701807 20180713 20:18:00-!- travis-ci [~travis-ci@ec2-184-73-70-128.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180713 20:54:16-!- gfg [~androirc@x55b27883.dyn.telefonica.de] has joined #wesnoth-dev 20180713 20:57:46< irker683> wesnoth/wesnoth:master Charles Dang d5972c6f43 Synced 1.14.3+dev changelog section with AppVeyor: All builds passed 20180713 21:01:51-!- gfg [~androirc@x55b27883.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20180713 21:02:25-!- gfg [~androirc@x55b27883.dyn.telefonica.de] has joined #wesnoth-dev 20180713 21:15:30-!- gfg [~androirc@x55b27883.dyn.telefonica.de] has quit [Ping timeout: 244 seconds] 20180713 21:25:19-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection] 20180713 21:44:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20180713 22:18:01-!- louis94 [~~louis94@91.178.69.90] has joined #wesnoth-dev 20180713 23:15:47< irker683> wesnoth: Nils Kneuper wesnoth:master 3a3bf21e3772 / / (5 files in 5 dirs): updated Hungarian translation https://github.com/wesnoth/wesnoth/commit/3a3bf21e3772fed706b1887fdfecc588f51cc409 20180713 23:15:53< irker683> wesnoth: Nils Kneuper wesnoth:1.14 0eb0409145b0 / changelog.md po/wesnoth-lib/hu.po po/wesnoth-tutorial/hu.po po/wesnoth/hu.po: updated Hungarian translation https://github.com/wesnoth/wesnoth/commit/0eb0409145b08b4b4a06ab495f09401fac0ea83b 20180713 23:22:04< irker683> wesnoth/wesnoth:master DisherProject d06a7e4511 DM: add some TODOs AppVeyor: All builds passed 20180713 23:22:18< irker683> wesnoth: Nils Kneuper wesnoth:master fb4dbb3fcee8 / po/ (8 files in 8 dirs): updated Japanese translation https://github.com/wesnoth/wesnoth/commit/fb4dbb3fcee878f427897469a26bab3536857a9c 20180713 23:22:24< irker683> wesnoth: Nils Kneuper wesnoth:1.14 487b7baa466e / / (9 files in 9 dirs): updated Japanese translation https://github.com/wesnoth/wesnoth/commit/487b7baa466ede1e5d3aa6f8437dc7814a458756 20180713 23:26:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180713 23:27:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180713 23:46:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180713 23:53:35-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Sat Jul 14 00:00:33 2018