--- Log opened Sun Jul 22 00:00:08 2018
20180722 00:02:13< celmin> I dunno, that doesn't have the same ability though.
20180722 00:02:35< celmin> The ability to splice custom units into the mainline unit advancement trees seems kinda important to me.
20180722 00:05:54< gfgtdf> i think there shodul be a sperate mechanics for changing advancement trees that does use macros, iirc there is also already a featurerequest for that on our tracker
20180722 00:08:38< gfgtdf> that does _not_ use macros i meant
20180722 00:11:23< celmin> Doesn't need to be advancefrom specifically, mind you.
20180722 00:17:45-!- gfgtdf [~chatzilla@x55b3b7a5.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20180722 00:18:12-!- gfgtdf [~chatzilla@x55b3b7a5.dyn.telefonica.de] has joined #wesnoth-dev
20180722 00:22:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180722 00:28:58< Ravana_> it doesn't make sense that unit types are mostly immutable, but advancefrom can later change them
20180722 00:29:31< Ravana_> when allowing changing advancements, then why not allow changing everything
20180722 00:29:35< celmin> I don't exactly like them being immutable, yeah.
20180722 01:06:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 01:06:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 01:12:17-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180722 01:13:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Client Quit]
20180722 01:50:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 01:50:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 02:05:28-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 268 seconds]
20180722 02:05:56-!- gfgtdf_ [~chatzilla@x4e337874.dyn.telefonica.de] has joined #wesnoth-dev
20180722 02:06:08-!- gfgtdf_ [~chatzilla@x4e337874.dyn.telefonica.de] has quit [Client Quit]
20180722 02:08:14-!- gfgtdf [~chatzilla@x55b3b7a5.dyn.telefonica.de] has quit [Ping timeout: 276 seconds]
20180722 02:12:28< irker774> wesnoth/wesnoth:master Elvish_Hunter af63d17e32 wmlindent: fixed crash on non-existent p AppVeyor: All builds passed
20180722 02:43:05-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20180722 03:01:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 03:02:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 03:55:59-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180722 03:56:59-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Client Quit]
20180722 04:16:07< irker774> wesnoth/wesnoth:1.14 Elvish_Hunter ceecbe4bc7 Backported fix for #3346 to 1.14 AppVeyor: All builds passed
20180722 04:26:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180722 04:49:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 04:49:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 06:54:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180722 07:13:02< irker774> wesnoth/wesnoth:1.14 joeylmaalouf fbc31a97fc NR S7: give Stalrag traits for consisten AppVeyor: All builds passed
20180722 07:53:41<+discordbot> <shadowm> @ everyone: Make sure Wesnoth 1.14 is releasable within the next 4 hours.
20180722 07:53:58<+discordbot> <shadowm> No excuses allowed this time.
20180722 08:09:09-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180722 08:14:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 08:14:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 08:23:09< irker774> wesnoth/wesnoth:1.14 joeylmaalouf 7c088b8136 NR S7: give Stalrag traits for consisten AppVeyor: All builds passed
20180722 08:24:21-!- Appleman1234 [~quassel@1.121.100.204] has quit [Ping timeout: 264 seconds]
20180722 09:25:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180722 09:34:47<+discordbot> <Vultraz> waits
20180722 10:25:13<+discordbot> <Vultraz> waits some more
20180722 10:27:05<+discordbot> <shadowm> Vultraz you'll have to keep waiting for gfgtdf.
20180722 10:27:17<+discordbot> <shadowm> Patience is a virtue, but you already know that.
20180722 10:27:55<+discordbot> <Vultraz> You're telling that to the person who's been pouring over CSS docs for the last 10 hours
20180722 10:30:58<+discordbot> <Vultraz> I've probably visited mdn 500 times today
20180722 10:38:31-!- gfgtdf [~chatzilla@x4e337874.dyn.telefonica.de] has joined #wesnoth-dev
20180722 10:42:27<+discordbot> <Vultraz> why did no one tell me <template> was a thing 😐
20180722 10:56:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 10:56:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 11:04:25< irker774> wesnoth: gfgtdf wesnoth:1.14 d911268a7834 / / (6 files in 4 dirs): disallow loading lua bytecode via load/dofile (CVE-2018-1999023) https://github.com/wesnoth/wesnoth/commit/d911268a783467842d38eae7ac1630f1fea41318
20180722 11:06:16<+discordbot> <shadowm> Pot update in progress now.
20180722 11:10:28<+discordbot> <shadowm> That http -> https commit breaks the string freeze.
20180722 11:10:31<+discordbot> <shadowm> 😐
20180722 11:10:40<+discordbot> <shadowm> -"span> at http://wiki.wesnoth.org/Micro_AIs for more information." +"span> at https://wiki.wesnoth.org/Micro_AIs for more information."
20180722 11:12:25<+discordbot> <shadowm> There is another commit breaking the string freeze.
20180722 11:13:13<+discordbot> <shadowm> @Vultraz https://github.com/wesnoth/wesnoth/commit/986f440f21c18cc940c3fd39186c8b5313dcf2e9
20180722 11:13:36<+discordbot> <shadowm> Wait.
20180722 11:13:54<+discordbot> <Vultraz> .....oops
20180722 11:13:57<+discordbot> <shadowm> Never mind.
20180722 11:14:11<+discordbot> <shadowm> Let me double-check first.
20180722 11:14:35<+discordbot> <shadowm> Yes it breaks the string freeze.
20180722 11:15:04<+discordbot> <shadowm> OH.
20180722 11:15:28<+discordbot> <shadowm> @Vultraz The auhtor marked the strings as translatable but didn't make them translatable.
20180722 11:15:37<+discordbot> <shadowm> cpp +       const std::string dialog_title(N_("Rename Unit")); +       const std::string dialog_label(N_("Name:"));
20180722 11:15:45<+discordbot> <Vultraz> ....ah....
20180722 11:15:46<+discordbot> <shadowm> Let me fix that quickly.
20180722 11:18:53<+discordbot> <shadowm> @Vultraz It does break the string freeze anyway.
20180722 11:19:09<+discordbot> <shadowm> The Rename button on the GUI2 Recall Unit dialog doesn't have a existing string in either wesnoth or wesnoth-lib.
20180722 11:19:16<+discordbot> <Vultraz> blahh...
20180722 11:19:37<+discordbot> <Vultraz> wait, the button?
20180722 11:19:41<+discordbot> <shadowm> Yes.
20180722 11:19:41<+discordbot> <Vultraz> just "Rename"?
20180722 11:19:44<+discordbot> <shadowm> Yes.
20180722 11:19:49<+discordbot> <Vultraz> odd...
20180722 11:20:08<+discordbot> <shadowm> It's not really odd.
20180722 11:20:18<+discordbot> <shadowm> There weren't any UI elements requiring the string "Rename" before.
20180722 11:20:32<+discordbot> <shadowm> "Rename Unit", yes. But not "Rename".
20180722 11:20:54<+discordbot> <Vultraz> is it acceptable to leave that one in
20180722 11:21:31<+discordbot> <shadowm> ...
20180722 11:22:39<+discordbot> <shadowm> Would it kill you to use "Rename Unit" for the button for 1.14.4?
20180722 11:22:55<+discordbot> <shadowm> Either that or the commit gets reverted.
20180722 11:23:17<+discordbot> <Vultraz> it is acceptable
20180722 11:26:35<+discordbot> <shadowm> Now I need a pofix for the http/https change in wesnoth-ai.
20180722 11:26:45<+discordbot> <shadowm> Even though by all means the whole textdomain shouldn't exist grrrrrrrr.
20180722 11:31:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180722 11:31:44< irker774> wesnoth: Iris Morelle wesnoth:master bb86afcb728f / src/gui/dialogs/unit_recall.cpp: gui2/unit_recall: Fix i18n issues https://github.com/wesnoth/wesnoth/commit/bb86afcb728feef091d17a3156f1873f49fe8da7
20180722 11:31:47< irker774> wesnoth: Iris Morelle wesnoth:master 74cbae01c453 / / (57 files in 2 dirs): pofix: Rule for an http:// → https:// conversion in translatable strings https://github.com/wesnoth/wesnoth/commit/74cbae01c453f4fb99876c52e15c04d9ce28fd6c
20180722 11:31:50< irker774> wesnoth: Iris Morelle wesnoth:1.14 306ebb9a87dc / data/gui/window/unit_recall.cfg src/gui/dialogs/unit_recall.cpp: gui2/unit_recall: Fix i18n issues https://github.com/wesnoth/wesnoth/commit/306ebb9a87dc6258d7da9ce5e9e4b66ed32ffef9
20180722 11:31:53< irker774> wesnoth: Iris Morelle wesnoth:1.14 634acd03a92d / / (60 files in 2 dirs): pofix: Rule for an http:// → https:// conversion in translatable strings https://github.com/wesnoth/wesnoth/commit/634acd03a92d365dbcaf94953800b4b0602531a0
20180722 11:34:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180722 11:35:43<+discordbot> <shadowm> Well.
20180722 11:35:48<+discordbot> <shadowm> The pofix rule isn't all inclusive.
20180722 11:36:05<+discordbot> <shadowm> Screw it, it's a superfluous textdomain that no-one needs to care about.
20180722 11:36:41<+discordbot> <Vultraz> anything else?
20180722 11:36:45<+discordbot> <shadowm> Can this serve as a lesson for people to not merge string-changing PRs willy-nilly during a string freeze though?
20180722 11:36:57<+discordbot> <Vultraz> it was me
20180722 11:37:09<+discordbot> <Vultraz> wasn't thinking
20180722 11:38:24< irker774> wesnoth: Iris Morelle wesnoth:1.14 e7658df0682e / / (592 files in 11 dirs): pot and documentation update https://github.com/wesnoth/wesnoth/commit/e7658df0682eae53b6987fae13e027f742d62c74
20180722 11:39:01<+discordbot> <shadowm> @Vultraz You do your part but do not push the version bump after tagging because my script doesn't handle that.
20180722 11:39:14<+discordbot> <shadowm> Already tested everything.
20180722 11:41:30< irker774> wesnoth: Vultraz wesnoth: 4cf379b2aab4 tagged as 1.14.4
20180722 11:41:33< irker774> wesnoth: Charles Dang wesnoth:1.14 6c1d9b926ba0 / changelog.md: Minor changelog updates https://github.com/wesnoth/wesnoth/commit/6c1d9b926ba03722aa12f3212fbb989c26d0bff6
20180722 11:41:36< irker774> wesnoth: Charles Dang wesnoth:1.14 4cf379b2aab4 / Doxyfile changelog.md projectfiles/Xcode/Info.plist src/wesconfig.h: Pre-release version bump https://github.com/wesnoth/wesnoth/commit/4cf379b2aab482a4a1fd96e29e1ad8b7e7829d0b
20180722 11:47:07<+discordbot> <shadowm> Already working on it.
20180722 11:47:32<+discordbot> <loonycyborg> are you planning to ping me or hruby about new tag?
20180722 11:47:41<+discordbot> <shadowm> When the source tarball is done.
20180722 11:47:45<+discordbot> <shadowm> Already working on it.
20180722 11:48:24<+discordbot> <loonycyborg> well I got my own script for that too 😛
20180722 11:48:35<+discordbot> <shadowm> I had my own script first and I'm already working on it.
20180722 11:49:06<+discordbot> <Vultraz> This isn’t a script measuring contest.
20180722 11:49:19<+discordbot> <shadowm> My script is bigger and has more lines.
20180722 11:49:30<+discordbot> <shadowm> Also I already stayed up for this.
20180722 11:53:48<+discordbot> <loonycyborg> well maybe we should share them then. mine is this: https://gist.github.com/loonycyborg/ee2a9397566608a84230e9b4f5a2b84c
20180722 11:54:02<+discordbot> <loonycyborg> though it requires manually updating version numbers each time
20180722 11:55:52<+discordbot> <shadowm> I posted mine back in the day.
20180722 11:58:53<+discordbot> <loonycyborg> drat it I don't remember where or when
20180722 11:59:05<+discordbot> <loonycyborg> so would be cool if you linked it
20180722 12:00:11<+discordbot> <shadowm> https://gist.github.com/shikadiqueen/d79b07c7cd5a5ee248ba553916669258
20180722 12:02:28<+discordbot> <shadowm> @loonycyborg The list of emails in /scratch is up to date, right?
20180722 12:02:42<+discordbot> <shadowm> Because I have some extra words for the packagers this time around.
20180722 12:06:07<+discordbot> <shadowm> @Vultraz You can bump now
20180722 12:06:20<+discordbot> <Vultraz> I’ll do it in the morning
20180722 12:06:30<+discordbot> <shadowm> I'll do it then.
20180722 12:07:01<+discordbot> <shadowm> @Packagers Need you to package 1.14.4 for general distribution and Steam ASAP because of the Lua bug fix. The source tarball is out on SF.net.
20180722 12:07:12<+discordbot> <Vultraz> Info.plist doesn’t get updated in the post bump
20180722 12:07:20<+discordbot> <shadowm> I'll just copy your last bump.
20180722 12:07:26<+discordbot> <loonycyborg> now we're supposed to use packegers mailing list
20180722 12:07:27<+discordbot> <shadowm> Post-bump.
20180722 12:07:28<+discordbot> <Vultraz> Ok
20180722 12:07:31<+discordbot> <shadowm> Uhhh.
20180722 12:07:41<+discordbot> <shadowm> Okay so I need to send the email there then?
20180722 12:07:46<+discordbot> <Vultraz> @loonycyborg what?
20180722 12:07:50<+discordbot> <Vultraz> Since when
20180722 12:08:23<+discordbot> <shadowm> I see I got a message from it for 1.14.3.
20180722 12:08:48<+discordbot> <Vultraz> Well, I still ping packagers here
20180722 12:08:59<+discordbot> <shadowm> VULTRAZ NOT ALL PACKAGERS ARE HERE
20180722 12:09:06<+discordbot> <shadowm> We've been over this at least a dozen times!
20180722 12:09:47<+discordbot> <loonycyborg> also don't ping me right now, discord for some reason hangs if ran on lxde when trying to send notification
20180722 12:09:59<+discordbot> <loonycyborg> and I'll be on lxde in middle of a system upgrade
20180722 12:10:06<+discordbot> <Vultraz> I know
20180722 12:10:23<+discordbot> <Vultraz> I’m saying I just won’t forego pinging the people here
20180722 12:10:39<+discordbot> <loonycyborg> that's fine
20180722 12:10:48<+discordbot> <Vultraz> Since it seeemd loony implied one should forego it
20180722 12:10:54<+discordbot> <loonycyborg> I didn't
20180722 12:10:55<+discordbot> <shadowm> I didn't read it that way.
20180722 12:10:58<+discordbot> <Vultraz> I did
20180722 12:11:03<+discordbot> <loonycyborg> I was responding to shadowm
20180722 12:11:08<+discordbot> <loonycyborg> and it came late
20180722 12:11:09<+discordbot> <Vultraz> Apologies
20180722 12:11:16<+discordbot> <loonycyborg> because I was restarting discord 😛
20180722 12:11:20<+discordbot> <shadowm> I was asking him about the emails lol
20180722 12:12:23<+discordbot> <hrubymar10> So I should create macOS package of 1.14.4 now, right?
20180722 12:12:34<+discordbot> <shadowm> Yes, asap like I said.
20180722 12:13:05<+discordbot> <hrubymar10> same way as always, because lua fixes are applied in src, so I don't have to do anything else
20180722 12:13:40<+discordbot> <shadowm> Yes, like all other changes and fixes it's part of the vanilla source distribution.
20180722 12:13:57<+discordbot> <hrubymar10> ok, thx
20180722 12:18:43<+discordbot> <hrubymar10> um
20180722 12:19:05<+discordbot> <hrubymar10> players_changelog.md was removed and replaced by changelog.md?
20180722 12:19:10<+discordbot> <shadowm> Yes.
20180722 12:19:42<+discordbot> <Vultraz> Removed, not really replaced since both have always existed
20180722 12:36:16-!- travis-ci [~travis-ci@ec2-54-198-90-124.compute-1.amazonaws.com] has joined #wesnoth-dev
20180722 12:36:17< travis-ci> gfgtdf/wesnoth#1198 (1.14 - 5f04779 : gfgtdf): The build passed.
20180722 12:36:17< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/406799229
20180722 12:36:17-!- travis-ci [~travis-ci@ec2-54-198-90-124.compute-1.amazonaws.com] has left #wesnoth-dev []
20180722 12:36:51<+discordbot> <shadowm> Thanks for your work on this gfgtdf
20180722 12:40:45-!- archfate [~Empty@udp252125uds.hawaiiantel.net] has joined #wesnoth-dev
20180722 12:41:56-!- archfate [~Empty@udp252125uds.hawaiiantel.net] has quit [Client Quit]
20180722 12:49:18-!- Appleman1234 [~quassel@1.121.100.204] has joined #wesnoth-dev
20180722 12:54:00<+discordbot> <hrubymar10> uploading to Steam
20180722 12:55:37<+discordbot> <hrubymar10> 41.8MB update in case of macOS package
20180722 12:58:57<+discordbot> <hrubymar10> Shadowm, do you have working 1.14.4 package right now?
20180722 12:59:24<+discordbot> <shadowm> What do you mean?
20180722 12:59:29<+discordbot> <hrubymar10> There is problem with macOS package and I want to know, if it is cross-platform reproducible
20180722 12:59:43<+discordbot> <shadowm> What is the problem? Because I tested 1.14.4 shortly before vultraz tagged it.
20180722 13:00:37<+discordbot> <hrubymar10> in scrollable menus it feels like touch control code is triggered
20180722 13:00:47<+discordbot> <shadowm> Uhh.
20180722 13:00:56<+discordbot> <hrubymar10> menu scrolls while moving mouse over them
20180722 13:00:59<+discordbot> <shadowm> Didn't @Vultraz merge something related to that a couple of weeks ago?
20180722 13:01:04<+discordbot> <hrubymar10> yes
20180722 13:01:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180722 13:01:13<+discordbot> <hrubymar10> PR primary for iOS
20180722 13:01:20<+discordbot> <shadowm> I don't have that issue on Linux.
20180722 13:01:30<+discordbot> <Vultraz> Oh dear
20180722 13:01:39<+discordbot> <Vultraz> Talk to sinda
20180722 13:02:01<+discordbot> <shadowm> (I do not have a touchscreen.)
20180722 13:02:01<+discordbot> <Vultraz> I don’t think I saw that either, on windows
20180722 13:02:10<+discordbot> <Vultraz> I do have a touchscreen
20180722 13:02:37<+discordbot> <Vultraz> (You do mean listboxes and not drop downs right.)
20180722 13:03:15<+discordbot> <Vultraz> (Because for the record I did implement selection changing of drop down entries using the scroll wheel when moused over without opening the menu)
20180722 13:03:22<+discordbot> <Vultraz> (In case that’s relevant )
20180722 13:04:26<+discordbot> <hrubymar10> https://cdn.discordapp.com/attachments/259976436490829825/470576856714838017/Untitled.mov
20180722 13:04:33<+discordbot> <hrubymar10> I will
20180722 13:05:26<+discordbot> <shadowm> Is no-one else regularly building and testing stable on macOS btw?
20180722 13:06:10<+discordbot> <hrubymar10> Sinda did, but I don't know if is it true now
20180722 13:07:33<+discordbot> <hrubymar10> Well I think that this bug is not that bad, because lua fix is more important IMO, but it would be nice to release patch for macOS soon :/
20180722 13:08:28<+discordbot> <jyrkive> This is almost certainly the regressing commit: https://github.com/wesnoth/wesnoth/pull/3270/commits/55af456e56dc5b879a42f1911aa454ab7977da68
20180722 13:09:58<+discordbot> <hrubymar10> BTW 1.14.4 package in steam is not public yet, so I can wait with releasing it for public
20180722 13:53:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 13:53:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 13:55:26-!- Appleman1234 [~quassel@1.121.100.204] has quit [Ping timeout: 276 seconds]
20180722 13:59:30-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20180722 14:32:12< vn971> // confirming that 1.14.4 is fine on Linux (as far as I see).
20180722 14:33:40<+discordbot> <loonycyborg> 1.14.4 steam build is updated
20180722 14:41:47-!- irker774 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180722 15:00:18<+discordbot> <hrubymar10> I'll wait for sinda. I sent him DM. I'll make 1.14.4 macOS package package asap
20180722 15:09:29<+discordbot> <Pentarctagon> should an issue be opened to remind to forward port the CVE fix to master, or will that be happening soon anyway?
20180722 15:28:52< celticminstrel> I think that fix also needs to be added to the Lua upgrade info?
20180722 15:29:09< celticminstrel> Because whenever someone updates the Lua engine they'll need to reapply part of that patch.
20180722 15:47:27-!- gfgtdf [~chatzilla@x4e337874.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20180722 15:52:09<+discordbot> <shadowm> Yeah I told gfgtdf that the other day.
20180722 15:52:25<+discordbot> <shadowm> We can look into it later, now is not the time.
20180722 16:14:21<+discordbot> <sinda> Ouch. Thank you for pointing out, will put some time in it today.
20180722 16:19:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 16:19:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 16:46:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180722 16:49:27-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180722 16:57:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180722 16:57:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180722 17:03:24< sigurdfd> fabi, esr: Is either of you still interested in working on Wings of Victory?
20180722 17:17:05-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180722 17:19:40<+discordbot> <jyrkive> celticminstrel: I believe that in the long run, we need to replace the Lua patch with code in game_lua_kernel.cpp that wraps open() without pathing source code of Lua itself.
20180722 17:20:04<+discordbot> <jyrkive> But like shadowm said, we needed to get the security fix out the door ASAP, so this initial fix has to suffice for now.
20180722 17:20:23< celticminstrel> Yeah, that would be better.
20180722 17:20:29< celticminstrel> Though, what is open()?
20180722 17:20:35< celticminstrel> Do you mean load()?
20180722 17:20:54< celticminstrel> BTW, do we actually need load() when we have loadstring()?
20180722 17:20:58<+discordbot> <jyrkive> Whoops. Yes. I mean load(). 😅
20180722 17:33:33-!- irker022 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180722 17:33:33< irker022> wesnoth/wesnoth:master Iris Morelle 74cbae01c4 pofix: Rule for an http:// → https:// co AppVeyor: All builds passed
20180722 17:45:13<+discordbot> <sinda> Touchpad on Mac generates touch events alongside with mouse events. I have a weak evidence that it's only Mac, but I cannot be sure: https://forums.libsdl.org/viewtopic.php?p=45758 Can anyone please confirm that on Windows and Linux 1.14.4 doesn't do the thing that hrubymar reported? If so, I will just #ifdef them out on Mac, like the forum thread suggests.
20180722 17:54:59< celticminstrel> I don't think any Macs with touchscreen would be paying Wesnoth?
20180722 17:55:18< celticminstrel> I think the only ones I've seen are the search computers at Indigo.
20180722 18:00:17<+discordbot> <Pentarctagon> @sinda vn971 mentioned not seeing it on linux, and I don't see it either.
20180722 18:00:32<+discordbot> <sinda> Good, thanks!
20180722 18:03:34<+discordbot> <hrubymar10> And you can’t reproduce it on linux using touchpad? It is not reproducible using mouse on macOS. Only touchpad.
20180722 18:05:02<+discordbot> <Pentarctagon> I don't have a touchpad
20180722 18:05:30<+discordbot> <hrubymar10> 😦
20180722 18:06:06<+discordbot> <Pentarctagon> The original description was "menu scrolls while moving mouse over them", so that's what I checked.
20180722 18:06:25<+discordbot> <hrubymar10> Anyone with trackpad can try reproduce it?
20180722 18:07:19<+discordbot> <hrubymar10> @Pentarctagon I didn’t know that it is reproducible only using trackpad while typing it
20180722 18:07:58<+discordbot> <Pentarctagon> alright, in that case, me not seeing anything really doesn't prove one way or the other.
20180722 18:12:53< vn971> I have a trackpad, will try now. Not sure what the exact test is though, TBH. Will just try scroll around and move mouse cursor around.
20180722 18:13:34<+discordbot> <jyrkive> The test is moving the mouse cursor in any scrollable area in a GUI window.
20180722 18:14:17< vn971> well, all good as far as I can check. If there's anything specific, I can test that. I checked scroll behavior in lobby game list. UPD: just moving the cursor around scrollable era doesn't lead to any bugs as well.
20180722 18:16:04<+discordbot> <Pentarctagon> maybe try the advanced preferences as well?  hrubymar's video was in the preferences dialog.
20180722 18:16:22<+discordbot> <Pentarctagon> though I don't get the same scrollbars there as he does
20180722 18:17:21<+discordbot> <jyrkive> I guess advanced preferences get scrollbars in Czech but not in English.
20180722 18:19:19< vn971> The video, right!  OK I tested this:  `LC_ALL=ru_RU.UTF-8 wesnoth`   no bugs with either trackpad or mouse. (You get those scroll things with Russian localisation as well.)
20180722 18:26:43-!- gfgtdf [~chatzilla@x4e337874.dyn.telefonica.de] has joined #wesnoth-dev
20180722 18:28:06< vn971> BTW, Czech locale made me see another bug. If you start wesnoth with Czech locale  `LC_ALL=cs_CZ.UTF-8 wesnoth`   and go to settings as in the video, you'll have an area that can be scolled both vertically and horisontally.
20180722 18:28:06< vn971> The vertical one works correctly. The "down" scroll action shows what's on the bottom (=moves viewpoint to the bottom). The same as it works in game map.
20180722 18:28:06< vn971> The horisontal one is broken, however. The "left" scroll action will move viewpoint to the right. Inverted to what happens on game map and inverted to what the user usually expect.
20180722 18:28:22< celticminstrel> Think there's a separate issue for that.
20180722 18:29:37<+discordbot> <sinda> @vn971 The test of  is to have a dialog with scrollbars and to move mouse cursor over with a trackpad.
20180722 18:30:27< vn971> @sinda yes, I tested it (with Czech locale to be sure), everything worked good (no erroneous scrolling because of mouse movements).
20180722 18:31:51< vn971> celticminstrel: can't find the issue. We had one for game map scrolling, with lots of debate etc. But we fixed it! 1.14 was already shipped with the fix IIRC. This one is different though. New one I guess.
20180722 18:32:06< vn971> So in other words, game map scrolling = totally fine, after the fix we've made. Preferences scrolling = broken horizontal scrolling on Linux.
20180722 18:32:22< celticminstrel> The one you mentioned might be the one I was thinking of.
20180722 18:32:43<+discordbot> <jyrkive> It may be that GUI2 compensates somewhere for the inverted scrolling.
20180722 18:32:58<+discordbot> <jyrkive> When it was fixed, horizontal scrolling broke in the GUI.
20180722 18:33:09< celticminstrel> Oh, I see.
20180722 18:34:46< vn971> jyrkive: should I still open the issue for Preferences scrollbar?
20180722 18:34:55< vn971> I mean, I intended to..
20180722 18:35:15<+discordbot> <jyrkive> Go ahead.
20180722 18:35:26-!- fabi [~fabi@i577BCDC7.versanet.de] has joined #wesnoth-dev
20180722 18:35:26-!- fabi [~fabi@i577BCDC7.versanet.de] has quit [Changing host]
20180722 18:35:26-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20180722 18:38:18-!- DeFender1031 [~DeFender1@89-138-231-156.bb.netvision.net.il] has joined #wesnoth-dev
20180722 18:47:27< vn971> // raised here  https://github.com/wesnoth/wesnoth/issues/3362
20180722 18:52:45< celticminstrel> Maybe mattsc should take a quick look at https://github.com/wesnoth/wesnoth/pull/3341
20180722 19:23:11-!- specing [~specing@unaffiliated/specing] has joined #wesnoth-dev
20180722 19:56:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180722 19:57:22-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180722 19:57:22-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host]
20180722 19:57:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180722 19:58:10< irker022> wesnoth/wesnoth:1.14.4 Charles Dang 4cf379b2aa Pre-release version bump AppVeyor: All builds passed
20180722 20:24:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180722 20:24:21-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180722 20:25:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20180722 20:25:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180722 20:26:36< mattsc> celticminstrel: I’ll try to have a look at Issue 3341 later today; need to run errands right now
20180722 20:26:44< celmin> 'kay
20180722 20:28:48-!- specing [~specing@unaffiliated/specing] has left #wesnoth-dev ["WeeChat 1.4"]
20180722 20:51:12<+discordbot> <shadowm> zookeeper: Are there any campaign-related PRs that have been sitting for nearly 2 months that you haven't looked at yet, by any chance?
20180722 21:19:32< zookeeper> @shadowm there sure are ones i've looked at but haven't processed yet. it's decidedly not a good summer WRT my wesnoth time.
20180722 21:21:01<+discordbot> <shadowm> I was reminded of how demotivating it was for me to file a bug to the SDL devs with a complete test case and write-up (which corresponded to a critical bug we couldn't fix on our side without redoing the lobby UI, which vultraz eventually did years later), only to never hear from them until 2 years later when I had already completely lost interest on the issue.
20180722 21:21:10<+discordbot> <shadowm> https://bugzilla.libsdl.org/show_bug.cgi?id=2749
20180722 21:21:28< celmin> I feel the same way as zookeeper 
20180722 21:21:30<+discordbot> <shadowm> (Notice the timestamps comments #8 and #9.)
20180722 21:21:34< celmin> So hot, I can't focus :(
20180722 21:21:52< celmin> And if I go to a place I can focus (like now) then it's really hard to work on Wesnoth.
20180722 21:22:13< celmin> I mean maybe zookeeper's reasoning is different but the end result is the same right
20180722 21:24:53<+discordbot> <shadowm> Also it's nearly a month and still no word on SDL #4205.
20180722 21:25:16<+discordbot> <shadowm> It's kind of sad when you come to expect a complete lack of response from a project.
20180722 21:25:51<+discordbot> <shadowm> (1.14.4 ships with a workaround for that bug. Our bug is #3280.)
20180722 21:28:33-!- Appleman1234 [~quassel@1.121.100.204] has joined #wesnoth-dev
20180722 21:30:32<+discordbot> <galegosimpatico> I don't call this bug https://github.com/anura-engine/anura/pull/263#issuecomment-384596680 but I think it's a surprising gotcha.
20180722 21:31:58<+discordbot> <shadowm> Anyway my point was to illustrate what it feels like for new contributors when their contributions just don't seem to be processed at all.
20180722 21:32:28<+discordbot> <shadowm> It's easy to forget that in projects where you have the power to push code at will without an intermediary.
20180722 21:33:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20180722 21:36:20<+discordbot> <Pentarctagon> lilinitsy's two PRs look like they could be merged as well?  the movement cost sorting one at least looks like it's been approved even.
20180722 21:36:49< celmin> What was the other one?
20180722 21:36:56<+discordbot> <Pentarctagon> https://github.com/wesnoth/wesnoth/pull/3246
20180722 21:37:30< celmin> I was thinking of merging something earlier but thought I should put it off because the release was just tagged and IIRC the post-release version bump hasn't happened yet.
20180722 21:38:24< celmin> I kinda forgot about the movement cost sorting but I do remember it being approved.
20180722 21:38:45<+discordbot> <shadowm> 1.14 is string-frozen atm.
20180722 21:38:51<+discordbot> <shadowm> (Don't do a vultraz.)
20180722 21:42:18< celmin> [Jul 22@5:37:30pm] celmin: I was thinking of merging something earlier but thought I should put it off because the release was just tagged and IIRC the post-release version bump hasn't happened yet.
20180722 21:42:37<+discordbot> <shadowm> Oh thanks for reminding me.
20180722 21:44:47< irker022> wesnoth: Iris Morelle wesnoth:1.14 bca38cda2a0c / Doxyfile changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/bca38cda2a0c0f8fedad26652fc0488ed728a902
20180722 21:45:44< celmin> So does this mean we can merge things now?
20180722 21:45:49< celmin> Provided they don't change strings obviously.
20180722 21:46:29<+discordbot> <shadowm> Yes.
20180722 21:46:47< irker022> wesnoth: josteph wesnoth:1.14 38a85190b81f / src/help/help_impl.cpp: Help: Hide abilities with empty names. https://github.com/wesnoth/wesnoth/commit/38a85190b81fc38106eb82bcdf729b1321a3da61
20180722 21:46:53<+discordbot> <shadowm> As long as it's not untested stuff that would cause problems if we had ot release a 1.14.5.
20180722 21:47:45< celmin> @Pentarctagon - 3246 has new strings so can't be merged quite yet
20180722 21:49:17<+discordbot> <Pentarctagon> does the freeze goes until 1.14.4 is officially announced?
20180722 21:49:26<+discordbot> <shadowm> Yes, same as usual.
20180722 21:49:56< irker022> wesnoth: lilinitsy wesnoth:1.14 b6fad044cabb / src/ (gui/widgets/unit_preview_pane.cpp help/help_topic_generators.cpp reports.cpp): Sort the movement costs in the tooltip in ascending order (#3305) https://github.com/wesnoth/wesnoth/commit/b6fad044cabbab5f873fa58cf20339e055941317
20180722 21:50:31< celmin> Anyone object to merging the new village variations?
20180722 21:50:38< celmin> I guess it can wait a little longer though.
20180722 21:51:24< irker022> wesnoth: Toom wesnoth:1.14 739df85e1d0e / data/test/scenarios/swarm_disables_upgrades.cfg wml_test_schedule: Add WML unit test for unupgradable (#3336) https://github.com/wesnoth/wesnoth/commit/739df85e1d0e7f382bc5c5664d29c36204ba8d0f
20180722 21:52:13< celmin> Only other one is 3358, but @sevu has claimed it so I thought I should let him take care of it.
20180722 21:52:21< celmin> Also need to cherry-pick these to master now.
20180722 22:47:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180722 22:48:57<+discordbot> <Vultraz> lot to cherry pick
20180722 23:11:54-!- gfgtdf [~chatzilla@x4e337874.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20180722 23:16:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Mon Jul 23 00:00:09 2018