--- Log opened Mon Jul 23 00:00:09 2018
20180723 00:15:14< mattsc> celmin: I had a look at the AI changes in PR 3341.  Syntactically they look okay, but I cannot say if they make sense in the scenario without actually going into the scenario and looking into the posted replays.  I don’t have time to do so for at least the next 3 days.
20180723 00:15:33< mattsc> I can probably give it a shot later during the week.
20180723 00:15:56< mattsc> Since 1.14.4 was just tagged, I assume that that’s okay?
20180723 00:16:07< celmin> Yeah, probably.
20180723 00:16:31< mattsc> Okay.  I’ll try to do that then.
20180723 00:33:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180723 00:36:15<+discordbot> <shadowm> @Vultraz Don't forget to publish the notes on Steam.
20180723 00:36:29<+discordbot> <Vultraz> Later. I'm at work.
20180723 00:36:32<+discordbot> <shadowm> I'll start working on the forum announcement after I'm finished sorting out bills.
20180723 00:36:51<+discordbot> <shadowm> Is there a way I can do it myseolf?
20180723 00:36:55<+discordbot> <shadowm> The Steam notes I mean.
20180723 00:37:06< celmin> Huh? Vultraz has work! O_O
20180723 00:37:10< celmin> ^?
20180723 00:40:53<+discordbot> <Vultraz> yes
20180723 00:51:19<+discordbot> <shadowm> @Pentarctagon idk how I messed up that wording, I think I was cutting and pasting too many things there.
20180723 01:03:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 01:03:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 01:13:30<+discordbot> <shadowm> Oh.
20180723 01:13:38<+discordbot> <shadowm> The macOS touch situation hasn't been solved yet has it?
20180723 01:16:40< celmin> Ask @sinda but I believe not.
20180723 01:17:24<+discordbot> <shadowm> Looks like it has not, because the package isn't up on SF.net yet.
20180723 01:17:43<+discordbot> <shadowm> So yeah, gonna wait for that before announcing.
20180723 01:25:57<+discordbot> <sinda> @hrubymar10 has the fix, but it was too late for him to re-build and test it. He's going to do it the next day.
20180723 01:26:50<+discordbot> <sinda> (I did test it - it works)
20180723 01:27:23<+discordbot> <shadowm> Did anyone confirm it's actually specific to macOS?
20180723 01:27:39<+discordbot> <shadowm> I have a laptop with a touchpad and touchscreen but it doesn't run Linux.
20180723 01:28:01<+discordbot> <shadowm> (It runs Windows 10.)
20180723 01:28:53<+discordbot> <sinda> vn971 tested it (on Linux I think?) and didn't reproduce.
20180723 01:36:43<+discordbot> <sinda> Mac has a extended tradition for touch gestures. This might be the reason why only SDL for Mac supports touch gestures.
20180723 01:57:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 01:57:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 02:30:21<+discordbot> <shadowm> Does attack end no longer have a valid primary unit if the primary unit is about to die?
20180723 02:30:54<+discordbot> <shadowm> 20180722 22:29:13 error engine: failed to auto-store $unit at (23,18) Invalid WML found: [unstore_unit]: variable 'unit' doesn't contain unit data
20180723 02:31:20<+discordbot> <shadowm> I'm getting this when handling attack end for a unit which is at 0 or less HP.
20180723 02:32:24-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20180723 02:34:27<+discordbot> <shadowm> Oh.
20180723 02:34:36<+discordbot> <shadowm> What happens if I unstore a unit with 0 or less HP?
20180723 02:34:48<+discordbot> <shadowm> Will it disappear entirely?
20180723 02:35:55<+discordbot> <shadowm> omg where are the WML people when I need them.
20180723 02:45:37-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 245 seconds]
20180723 02:46:19-!- fabi [~fabi@200116b82b440600804795f86c6be3d7.dip.versatel-1u1.de] has joined #wesnoth-dev
20180723 02:46:19-!- fabi [~fabi@200116b82b440600804795f86c6be3d7.dip.versatel-1u1.de] has quit [Changing host]
20180723 02:46:19-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20180723 03:18:01< celticminstrel> I'm not quite sure but I think the unit would die in that case, since it's at 0 hp or less?
20180723 03:20:06<+discordbot> <shadowm> But the unit is already in the process of dying.
20180723 03:21:03<+discordbot> <shadowm> This is going to be major pain in the bum to debug because it's unit ability events interacting with scenario events in a way that they didn't in 1.12.
20180723 03:30:35< celticminstrel> Oh...
20180723 03:36:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 03:36:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 03:46:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 03:46:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 03:52:43< irker022> wesnoth/wesnoth:1.14 Toom 739df85e1d Add WML unit test for unupgradable (#333 AppVeyor: All builds passed
20180723 04:11:54<+discordbot> <jyrkive> @shadowm You can unstore a unit with <= 0 HP.
20180723 04:12:13<+discordbot> <jyrkive> If it's already dying, it will die. Otherwise it will continue to live with negative HP.
20180723 04:12:24<+discordbot> <shadowm> But when will it die?
20180723 04:12:42<+discordbot> <jyrkive> When anyone deals more damage to it.
20180723 04:12:46<+discordbot> <shadowm> Only between last breath and die as usual?
20180723 04:12:51<+discordbot> <shadowm> Wha uh.
20180723 04:13:06<+discordbot> <shadowm> Uh.
20180723 04:14:01<+discordbot> <shadowm> Well there's a subsequent check in the WML for ≤ 0 HP that kills the units with fire_event=yes...
20180723 04:14:28<+discordbot> <shadowm> Honestly I'm just speculating at some point. Something definitely changed but I don't know yet exactly where the problem is.
20180723 04:18:33<+discordbot> <jyrkive> https://github.com/wesnoth/wesnoth/blob/1.14/src/actions/attack.cpp#L1343
20180723 04:19:26<+discordbot> <jyrkive> That's the final check for unit HP in the dying sequence. If the unit has positive HP after executing the die event, its death is averted. Otherwise it's going to die, and it can no longer be avoided.
20180723 04:24:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 04:24:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 04:58:01-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20180723 05:01:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180723 05:37:57-!- Appleman1234 [~quassel@1.121.100.204] has quit [Ping timeout: 240 seconds]
20180723 05:45:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180723 06:48:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 06:48:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 06:54:58-!- irker022 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180723 07:39:21<+discordbot> <hrubymar10> macOS package of 1.14.4 with scroll issue patch applied is done. Uploading right now
20180723 07:39:30<+discordbot> <hrubymar10> sha256: 151f9e1be1d16e224a5d7f2a923f0ac69e3dce7952ed558375cdf3b7455df0e3
20180723 07:40:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180723 07:41:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180723 07:41:47-!- irker109 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180723 07:41:47< irker109> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 963890afb32a / projectfiles/Xcode/README.md: Update README.md for Xcode builds https://github.com/wesnoth/wesnoth/commit/963890afb32a71cbb75bdafe1c6ada85a16e116d
20180723 07:42:12< irker109> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 87332aa8b099 / projectfiles/Xcode/Resources/SDLMain.nib/ (designable.nib keyedobjects.nib): Updated changelog in Xcode https://github.com/wesnoth/wesnoth/commit/87332aa8b0990536dc5a8cc9956e539c07b1ddff
20180723 07:47:27< irker109> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 097c89f916e2 / projectfiles/Xcode/README.md: Update README.md for Xcode builds https://github.com/wesnoth/wesnoth/commit/097c89f916e2237bf5713c35accc932efaa96d77
20180723 07:56:44-!- archfate [~Empty@udp252125uds.hawaiiantel.net] has joined #wesnoth-dev
20180723 07:58:05-!- archfate [~Empty@udp252125uds.hawaiiantel.net] has left #wesnoth-dev ["Leaving"]
20180723 07:59:03-!- vladimirslavik [vslavik@nat/redhat/x-fwxchapmrhhzjjyg] has joined #wesnoth-dev
20180723 08:02:37<+discordbot> <shadowm> Is it up on Steam yet?
20180723 08:12:27<+discordbot> <shadowm> Also, for that matter, @loonycyborg is the Windows build up on Steam?
20180723 08:12:31<+discordbot> <shadowm> (I saw the Linux build.)
20180723 08:35:18-!- Appleman1234 [~quassel@1.121.100.204] has joined #wesnoth-dev
20180723 08:37:09<+discordbot> <hrubymar10> Yes, all 3 platforms are up on steam
20180723 08:52:21<+discordbot> <loonycyborg> yes
20180723 09:45:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 09:45:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 10:48:11-!- irker109 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180723 12:13:04-!- irker893 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180723 12:13:04< irker893> wesnoth: Jyrki Vesterinen wesnoth:1.14 b21284709804 / changelog.md: Changelog: fix issue #3277 being mistyped as 3722 https://github.com/wesnoth/wesnoth/commit/b212847098047890b02b41ec25a22289e28f6db4
20180723 12:14:19< irker893> wesnoth: Jyrki Vesterinen wesnoth:master aea5d67f93f1 / changelog.md: Changelog: fix issue #3277 being mistyped as 3722 https://github.com/wesnoth/wesnoth/commit/aea5d67f93f1924a4a1520e10e05c117bf892596
20180723 12:51:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 12:52:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 13:34:13< irker893> wesnoth: Jyrki Vesterinen wesnoth:1.14 0c5f1cadaf82 / / (6 files in 5 dirs): Create a named struct for terrain name and movement pair https://github.com/wesnoth/wesnoth/commit/0c5f1cadaf82efd7e1ba64349d162f0c322e3dd2
20180723 13:41:31<+discordbot> <jyrkive> celticminstrel: You only merged #3305 to the 1.14 branch, it's not present in master.
20180723 13:41:50<+discordbot> <jyrkive> If you merge a pull request, it's your responsibility to also copy it to the other branch.
20180723 13:42:01<+discordbot> <jyrkive> Don't merge it if you're not willing to do that.
20180723 13:46:02-!- gfgtdf [~chatzilla@x4dbaff94.dyn.telefonica.de] has joined #wesnoth-dev
20180723 13:50:09< irker893> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) 87332aa8b0 Updated changelog in Xcode AppVeyor: All builds passed
20180723 13:59:11< irker893> wesnoth: gfgtdf wesnoth:1.14 3339dfbf4d68 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/3339dfbf4d687a389d7f056289ac82d6374f02b8
20180723 14:02:46<+discordbot> <jyrkive> Also, Vultraz. You have made #3305 difficult to merge by changing spacing and line break positions in  master.
20180723 14:03:11< irker893> wesnoth: gfgtdf wesnoth:1.14 6b64ef610a21 / changelog.md: fixup update changelog.md https://github.com/wesnoth/wesnoth/commit/6b64ef610a21198531bedd5cc8b979ff83a70caa
20180723 14:03:22<+discordbot> <jyrkive> Please try to refrain from that kind of useless whitespace changes which accomplish nothing other than making merging and cherry-picking harder.
20180723 14:17:19< irker893> wesnoth: lilinitsy wesnoth:master 61b7e7298b99 / src/ (gui/widgets/unit_preview_pane.cpp help/topic_text_generators.cpp reports.cpp): Sort the movement costs in the tooltip in ascending order (#3305) https://github.com/wesnoth/wesnoth/commit/61b7e7298b99e11746501e435e6301c7360e2d1c
20180723 14:25:56< irker893> wesnoth: Jyrki Vesterinen wesnoth:master d8e2498dded1 / / (6 files in 5 dirs): Create a named struct for terrain name and movement pair https://github.com/wesnoth/wesnoth/commit/d8e2498dded14e9df5abcd5e20ac8c8c252dca3a
20180723 14:31:41< irker893> wesnoth: Toom wesnoth:1.14 b16c8e1c4c93 / changelog.md: Fix 3339dfbf4d687a389d7f056289ac82d6374f02b8 typos https://github.com/wesnoth/wesnoth/commit/b16c8e1c4c936a888de70f9088bfe3726ddf3b00
20180723 14:32:27-!- vladimirslavik [vslavik@nat/redhat/x-fwxchapmrhhzjjyg] has quit [Ping timeout: 240 seconds]
20180723 14:34:58< irker893> wesnoth: gfgtdf wesnoth:master 4801629ab1b2 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/4801629ab1b265028c7b05c7bf7f7cd204990c1c
20180723 14:35:00< irker893> wesnoth: gfgtdf wesnoth:master b684c8b3aac7 / changelog.md: fixup update changelog.md https://github.com/wesnoth/wesnoth/commit/b684c8b3aac75b986b016ce4e04ecfcc62e9bb31
20180723 14:35:02< irker893> wesnoth: Toom wesnoth:master c0727bacf3df / changelog.md: Fix 4801629ab1b265028c7b05c7bf7f7cd204990c1c typos https://github.com/wesnoth/wesnoth/commit/c0727bacf3df30bd235b2048a3b8f9c2ab7cc9b8
20180723 14:35:35<+discordbot> <jyrkive> @Ravana BTW, please try to avoid using commit hashes in commit messages like that next time.
20180723 14:35:51<+discordbot> <jyrkive> I needed to manually fix-up the hash for the master branch (where commit hashes are different).
20180723 14:46:58-!- Appleman1234 [~quassel@1.121.100.204] has quit [Ping timeout: 268 seconds]
20180723 15:58:30< irker893> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 097c89f916 Update README.md for Xcode builds AppVeyor: All builds passed
20180723 16:05:55< gfgtdf> i cannot get 'addon_min_version' to work, i added an older addon_min_version to ym ocal addon, bu i still cannot join older games.
20180723 16:09:40< Ravana_> I noticed same
20180723 16:10:01< Ravana_> instead changed cpp file locally
20180723 16:12:28< gfgtdf> so you found the cause of the bug ?
20180723 16:13:07< gfgtdf> or just disabled the vesion check altogether ?
20180723 16:22:33< Ravana_> just version check https://github.com/ProditorMagnus/wesnoth/commit/9186281fe5d22fa57de477a3f99e86640c5bb4f8
20180723 16:27:52<+discordbot> <blarumyrran> hi
20180723 16:28:52<+discordbot> <blarumyrran> do you still give $$$ for anims? Sea Serpent currently has no animations, for $$$ i could give it attack, defend, death animations with huge framecount
20180723 16:29:25<+discordbot> <blarumyrran> i once took a commission (dwarf guardsman anims), long ago, and failed, but that's because it was on a sprite whose base frame was not done by me
20180723 16:31:07<+discordbot> <blarumyrran> https://i.imgur.com/jRt0bRL.gif sample of work
20180723 16:31:40<+discordbot> <blarumyrran> (blurry due to poor gif compression...)
20180723 16:51:26<+discordbot> <shadowm> PM vultraz directly.
20180723 17:11:11-!- travis-ci [~travis-ci@ec2-54-159-251-131.compute-1.amazonaws.com] has joined #wesnoth-dev
20180723 17:11:12< travis-ci> gfgtdf/wesnoth#1201 (1.14 - 6e73d29 : gfgtdf): The build was fixed.
20180723 17:11:12< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/407234619
20180723 17:11:12-!- travis-ci [~travis-ci@ec2-54-159-251-131.compute-1.amazonaws.com] has left #wesnoth-dev []
20180723 17:29:42< gfgtdf> Ravana_: ok i did some test and found out that the casue was that the addopn version check is also applied for addons that have require_era/modification=no when you ahve them installed.
20180723 17:30:46< gfgtdf> ok seems liek this one applies to eras only
20180723 17:34:41-!- gfgtdf [~chatzilla@x4dbaff94.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.9.0/20180621064021]]
20180723 17:38:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180723 18:58:55-!- irker893 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180723 19:21:45-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20180723 19:24:05-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 276 seconds]
20180723 19:40:00-!- aeth_ is now known as aeth
20180723 20:46:31-!- gfg [~androirc@x4dbaff94.dyn.telefonica.de] has joined #wesnoth-dev
20180723 20:52:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180723 20:57:51-!- irker606 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180723 20:57:51< irker606> wesnoth/wesnoth:1.14 Toom b16c8e1c4c Fix 3339dfbf4d687a389d7f056289ac82d6374f AppVeyor: All builds passed
20180723 21:17:12< irker606> wesnoth: Nils Kneuper wesnoth:master 36ecc030a6c7 / po/ (wesnoth-ai/en_GB.po wesnoth-lib/en_GB.po): updated British English translation https://github.com/wesnoth/wesnoth/commit/36ecc030a6c7eb88c3e11f1cb274518125b14262
20180723 21:17:18< irker606> wesnoth: Nils Kneuper wesnoth:1.14 05cf17d1391f / changelog.md po/wesnoth-ai/en_GB.po po/wesnoth-lib/en_GB.po: updated British English translation https://github.com/wesnoth/wesnoth/commit/05cf17d1391f02d23c5aa03cb2183e06787f09f2
20180723 21:31:27<+discordbot> <Vultraz> @jyrkive what file?
20180723 21:32:33<+discordbot> <jyrkive> src/help/topic_text_generators.cpp
20180723 21:33:08<+discordbot> <jyrkive> Specifically in this commit: https://github.com/wesnoth/wesnoth/commit/23e78abb20b00786ad58bbefda08904742974f8e
20180723 21:33:19<+discordbot> <Vultraz> most of that file is commented out 😐
20180723 21:33:38<+discordbot> <jyrkive> Well, Git doesnt care about code being commented out when merging changes.
20180723 21:33:44<+discordbot> <Vultraz> but i probably ran clang formatting.
20180723 21:33:47<+discordbot> <jyrkive> Git doesnt even know what commenting out is.
20180723 21:34:11<+discordbot> <Vultraz> really, if I do a big refactor I'm going to clean up the code, formatting included.
20180723 21:34:35<+discordbot> <jyrkive> But you did not refactor the code in that function.
20180723 21:34:48<+discordbot> <jyrkive> It has only whitespace changes.
20180723 21:35:16<+discordbot> <Vultraz> fair neough
20180723 22:05:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20180723 22:09:35-!- lilinitsy_ [~demonitsy@75-168-156-222.mpls.qwest.net] has joined #wesnoth-dev
20180723 22:15:05-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 240 seconds]
20180723 22:17:07-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180723 22:20:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180723 22:22:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180723 22:36:14-!- gfg [~androirc@x4dbaff94.dyn.telefonica.de] has quit [Remote host closed the connection]
20180723 22:37:59-!- Appleman1234 [~quassel@1.121.100.204] has joined #wesnoth-dev
20180723 22:38:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180723 22:58:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 22:58:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 23:09:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180723 23:09:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180723 23:40:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180723 23:49:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180723 23:52:51-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180723 23:56:15< irker606> wesnoth/wesnoth:master Toom c0727bacf3 Fix 4801629ab1b265028c7b05c7bf7f7cd20499 AppVeyor: All builds passed
--- Log closed Tue Jul 24 00:00:10 2018