--- Log opened Fri Jul 27 00:00:24 2018 20180727 00:06:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20180727 00:25:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 00:25:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 00:42:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 00:43:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 01:23:07-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20180727 01:26:49-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 268 seconds] 20180727 01:58:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 01:58:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 02:01:47<+discordbot> well, hard drives won't power back on 20180727 02:03:18<+discordbot> oh dear 20180727 02:04:16< celticminstrel> :( 20180727 02:20:49<+discordbot> and this is why you don't have single points of failure, I suppose, no matter how well planned they are 20180727 02:22:06<+discordbot> [insert picture of wesnoth.org here] 20180727 02:24:56<+discordbot> lol 20180727 02:48:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 02:48:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 02:50:50-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev 20180727 02:52:29-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Client Quit] 20180727 03:17:33< celticminstrel> Oh huh, GitHub now hilites the linked-to comment. 20180727 03:21:37-!- Appleman1234 [~quassel@101.162.145.198] has joined #wesnoth-dev 20180727 03:26:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180727 03:46:38<+discordbot> highlights 20180727 04:04:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 04:04:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 04:08:30-!- irker245 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180727 04:08:30< irker245> wesnoth/wesnoth:1.14 Andras Szell 94db98cadb Minor fixes (unit_id --> student_team_me AppVeyor: All builds passed 20180727 04:28:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 04:28:15-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 04:28:15-!- janebot_ is now known as janebot 20180727 05:38:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 05:38:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 06:15:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180727 06:15:42-!- valdar [~atarocch@31.159.220.15] has joined #wesnoth-dev 20180727 06:21:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 06:21:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 06:34:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180727 06:35:57-!- Appleman1234 [~quassel@101.162.145.198] has quit [Ping timeout: 244 seconds] 20180727 06:49:33-!- Appleman1234 [~quassel@101.162.145.198] has joined #wesnoth-dev 20180727 07:08:35-!- irker245 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180727 07:24:20-!- vladimirslavik [~vslavik@95.82.135.160] has joined #wesnoth-dev 20180727 07:26:30-!- irker049 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180727 07:26:30< irker049> wesnoth: jostephd wesnoth:1.14 4bee02422fd3 / src/gui/dialogs/ (unit_list.cpp unit_recall.cpp): Fix sorting of units by level in Recall List and Unit List (#3370) https://github.com/wesnoth/wesnoth/commit/4bee02422fd3fb3fcfc309cc462c3f34103018a5 20180727 07:29:22< irker049> wesnoth: jostephd wesnoth:master 6e31c83c644b / src/gui/dialogs/ (unit_list.cpp unit_recall.cpp): Fix sorting of units by level in Recall List and Unit List (#3370) https://github.com/wesnoth/wesnoth/commit/6e31c83c644b7265d68b999f9a5c763a03aee501 20180727 08:06:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 08:06:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 08:35:23< irker049> wesnoth: Jyrki Vesterinen wesnoth:1.14 cbb7edb0ed82 / src/gui/dialogs/ (unit_list.cpp unit_recall.cpp): Fix: we negate an unsigned integer https://github.com/wesnoth/wesnoth/commit/cbb7edb0ed8202737ca4552195fbd894da095e15 20180727 08:36:16< irker049> wesnoth: Jyrki Vesterinen wesnoth:master e961cc08993b / src/gui/dialogs/ (unit_list.cpp unit_recall.cpp): Fix: we negate an unsigned integer https://github.com/wesnoth/wesnoth/commit/e961cc08993bb2b796891530d084da73ec212351 20180727 09:20:21-!- travis-ci [~travis-ci@ec2-54-221-101-66.compute-1.amazonaws.com] has joined #wesnoth-dev 20180727 09:20:22< travis-ci> wesnoth/wesnoth#18970 (master - e961cc0 : Jyrki Vesterinen): The build was broken. 20180727 09:20:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/408848159 20180727 09:20:22-!- travis-ci [~travis-ci@ec2-54-221-101-66.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180727 09:32:22< irker049> wesnoth/wesnoth:1.14 joeylmaalouf 68560af4f2 NR S7-8: avoid re-creating Stalrag from AppVeyor: All builds passed 20180727 10:26:28< irker049> wesnoth: doofus-01 wesnoth:1.14 a55e5228b2ea / data/core/ (9 files in 2 dirs): Additional village variations (#3342) https://github.com/wesnoth/wesnoth/commit/a55e5228b2ea0248cee7cd78ee35d26cb407536e 20180727 10:29:11< zookeeper> oh bugger. i didn't notice it was going to 1.14 instead of master. 20180727 10:34:15< irker049> wesnoth: doofus-01 wesnoth:master 9042b0beb75e / data/core/ (9 files in 2 dirs): Additional village variations (#3342) https://github.com/wesnoth/wesnoth/commit/9042b0beb75e637b786a659eb674cccc6d92be28 20180727 10:49:12< zookeeper> now, should i keep the changes to the existing snowy hut images or not... 20180727 10:51:30< zookeeper> i guess that makes sense 20180727 10:53:34< irker049> wesnoth: ln-zookeeper wesnoth:1.14 556d9ffb91cd / data/core/ (7 files in 2 dirs): Partially revert "Additional village variations (#3342)" https://github.com/wesnoth/wesnoth/commit/556d9ffb91cdf0376336366c1176009169dd6d5b 20180727 10:58:12<+discordbot> I'm planning to not implement support for passing a function to the replacement load() function. It would technically be a backwards-incompatible change, but I doubt anyone is passing functions to load() anyway. 20180727 10:58:19<+discordbot> Doi you think it would be okay? 20180727 10:59:25<+discordbot> (From Lua's documentation: "If chunk is a string, the chunk is this string. If chunk is a function, load calls it repeatedly to get the chunk pieces. Each call to chunk must return a string that concatenates with previous results. A return of an empty string, nil, or no value signals the end of the chunk." 20180727 11:01:27< irker049> wesnoth: ln-zookeeper wesnoth:1.14 94b6c3dc4e1e / data/core/images/terrain/village/ (hut-snow-hills-tile.png hut-snow-tile.png): Updated snowy hut tile icons https://github.com/wesnoth/wesnoth/commit/94b6c3dc4e1e847767c5e86b9ba7d16da63f6b12 20180727 11:02:33< irker049> wesnoth: ln-zookeeper wesnoth:master 386493790e1d / data/core/images/terrain/village/ (hut-snow-hills-tile.png hut-snow-tile.png): Updated snowy hut tile icons https://github.com/wesnoth/wesnoth/commit/386493790e1df329a7b98f384ee00366f3625ff1 20180727 11:12:19-!- travis-ci [~travis-ci@ec2-54-167-199-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180727 11:12:20< travis-ci> wesnoth/wesnoth#18972 (master - 9042b0b : doofus-01): The build was fixed. 20180727 11:12:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/408886523 20180727 11:12:20-!- travis-ci [~travis-ci@ec2-54-167-199-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180727 11:19:50<+discordbot> @Pentarctagon you sure -DFORTIFY_SOURCE=2 is really needed? For me it breaks strict compilation 20180727 11:20:02<+discordbot> it ends up emitting warning about redefinition 20180727 11:20:11<+discordbot> because it appears to be a builtin define somehow 20180727 11:21:13<+discordbot> Could you upload the exact error message to Gist or something? 20180727 11:21:31<+discordbot> Also, which compiler do you use? 20180727 11:24:16<+discordbot> /usr/bin/ccache g++ -o build/release/wesnoth.o -c -std=c++11 -fopenmp -Wold-style-cast -Wall -Wextra -Werror=non-virtual-dtor -pthread -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Werror -fPIE -O3 -march=bdver3 -include boost-patched/bind/arg.hpp -D_REENTRANT -DHAVE_LIBDBUS -DHAVE_FRIBIDI -DHAVE_HISTORY -DHAVE_CONFIG_H -D_FORTIFY_SOURCE=2 -D_X11 -DFIFODIR='"/var/run/wesnothd"' -DWESNOTH_PATH='"/tmp/app/share/wesnoth"' 20180727 11:24:16<+discordbot> -DLOCALEDIR='"translations"' -DHAS_RELATIVE_LOCALEDIR -Ibuild -Isrc -isystem /usr/include/SDL2 -isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/pixman-1 -isystem /usr/include/uuid -isystem /usr/include/freetype2 -isystem /usr/include/libdrm -isystem /usr/include/libpng16 -isystem /usr/include/pango-1.0 -isystem /usr/include/harfbuzz -isystem /usr/include/dbus-1.0 -isystem 20180727 11:24:16<+discordbot> /usr/lib64/dbus-1.0/include -isystem /usr/include/fribidi src/wesnoth.cpp :0:0: error: "_FORTIFY_SOURCE" redefined [-Werror] : note: this is the location of the previous definition 20180727 11:24:44<+discordbot> Ah, right. You're using Gentoo. 20180727 11:25:01<+discordbot> g++ (Gentoo 7.3.0-r3 p1.4) 7.3.0 Copyright (C) 2017 Free Software Foundation, Inc. 20180727 11:25:41<+discordbot> It looks like Gentoo enables _FORTIFY_SOURCE implicitly, which causes a conflict if the project in question also enables it explicitly. 20180727 11:26:32<+discordbot> IMHO, it's okay if strict compliation isbroken on Gentoo. It would be worse if source fortification wasn't used on other distributions. 20180727 11:27:08<+discordbot> perhaps it can be fixed with a config check 20180727 11:27:38<+discordbot> It would be best if you made the check in question, since you can test it easily. 20180727 11:36:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 11:36:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 12:03:39-!- travis-ci [~travis-ci@ec2-54-204-99-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180727 12:03:40< travis-ci> wesnoth/wesnoth#18975 (master - 3864937 : ln-zookeeper): The build is still failing. 20180727 12:03:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/408894907 20180727 12:03:40-!- travis-ci [~travis-ci@ec2-54-204-99-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180727 12:05:35-!- Appleman1234 [~quassel@101.162.145.198] has quit [Ping timeout: 244 seconds] 20180727 12:15:52< irker049> wesnoth: loonycyborg wesnoth:1.14 47b902033df0 / SConstruct scons/cplusplus.py: scons: fix strict hardened builds on Gentoo https://github.com/wesnoth/wesnoth/commit/47b902033df0442460b7fe04d99da140e41f5474 20180727 12:16:13<+discordbot> @jyrkive this fixes it for me 20180727 12:16:55<+discordbot> Excellent. Thank you. 👍 20180727 12:30:35< irker049> wesnoth: Jyrki Vesterinen wesnoth:1.14 cc57f98cb6cd / src/ (lua/lbaselib.cpp scripting/lua_kernel_base.cpp): Lua: implement our own load() instead of monkey-patching Lua code https://github.com/wesnoth/wesnoth/commit/cc57f98cb6cd2553150432ad343e9e20e7e3691a 20180727 12:36:34<+discordbot> working with CSS grids, it occurs to me something wesnoth's grid system could really use is a mechanism to allow items to span multiple cells 🤔 20180727 12:37:17< irker049> wesnoth: gfgtdf wesnoth:master 2554c166dd45 / / (6 files in 4 dirs): disallow loading lua bytecode via load/dofile (CVE-2018-1999023) https://github.com/wesnoth/wesnoth/commit/2554c166dd45bfdee8ee24431224bd25e52bab12 20180727 12:37:19< irker049> wesnoth: gfgtdf wesnoth:master 6b13a63bb099 / / (4 files in 2 dirs): wml test for cve-2018-1999023 https://github.com/wesnoth/wesnoth/commit/6b13a63bb0999e1c494a4236a5d565306db5a0b9 20180727 12:37:21< irker049> wesnoth: Jyrki Vesterinen wesnoth:master 52ae31efb21b / src/ (lua/lbaselib.cpp scripting/lua_kernel_base.cpp): Lua: implement our own load() instead of monkey-patching Lua code https://github.com/wesnoth/wesnoth/commit/52ae31efb21b31f5bb0763d1da24709e90393c59 20180727 13:18:02-!- travis-ci [~travis-ci@ec2-54-197-163-36.compute-1.amazonaws.com] has joined #wesnoth-dev 20180727 13:18:03< travis-ci> wesnoth/wesnoth#18978 (master - 52ae31e : Jyrki Vesterinen): The build is still failing. 20180727 13:18:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/408926598 20180727 13:18:03-!- travis-ci [~travis-ci@ec2-54-197-163-36.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180727 13:36:48<+discordbot> @loonycyborg Would changing -D_FORTIFY_SOURCE=2 TO -U_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 work as well? Not sure if that would be effective since GCC is configured to apply it automatically in gentoo, but it'd be a lot simpler. 20180727 13:38:36<+discordbot> not sure, but it would definitely make command lines hairier 20180727 13:38:59<+discordbot> It's just U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 (the =2 isn't used for undefining). 20180727 13:39:22<+discordbot> And I agree with loonycyborg, I prefer shorter commands. 20180727 13:52:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180727 14:53:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 14:53:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 15:08:38-!- vladimirslavik [~vslavik@95.82.135.160] has quit [Quit: Leaving] 20180727 15:35:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 15:35:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 15:36:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180727 15:38:18-!- irker049 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180727 15:58:57-!- lilinitsy_ [~demonitsy@75-168-156-222.mpls.qwest.net] has joined #wesnoth-dev 20180727 16:12:19<+discordbot> Vultraz, wow, that's a big task. Here's an even more complex idea. Another thing that HTML tables are missing and what people ended up re-implementing en masse is - Bootstrap grid-style ability to change the number of columns depending on screen width, and to put cells either in one row or in multiple depending on the cell's settings. 20180727 16:13:41<+discordbot> Quite selfish of me, because it's mobile devices will primarily benefit from re-layout on narrow screens. 20180727 16:16:21<+discordbot> Like this: https://vestride.github.io/Shuffle/bootstrap3-grid (try changing the browser's width) 20180727 16:19:00-!- DeFender1031 [~DeFender1@89-138-231-156.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180727 16:39:07-!- gfg [~androirc@tmo-081-125.customers.d1-online.com] has joined #wesnoth-dev 20180727 16:43:03-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180727 16:55:29-!- irker782 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180727 16:55:29< irker782> wesnoth: loonycyborg wesnoth:master 0c3ba36d6875 / SConstruct scons/cplusplus.py: scons: fix strict hardened builds on Gentoo https://github.com/wesnoth/wesnoth/commit/0c3ba36d68754acc2328fd704e1b8df17383e8cd 20180727 17:11:45< irker782> wesnoth/wesnoth:1.14 ln-zookeeper 94b6c3dc4e Updated snowy hut tile icons AppVeyor: All builds passed 20180727 17:16:30-!- travis-ci [~travis-ci@ec2-54-204-99-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180727 17:16:31< travis-ci> wesnoth/wesnoth#18979 (master - 0c3ba36 : loonycyborg): The build is still failing. 20180727 17:16:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/409026177 20180727 17:16:31-!- travis-ci [~travis-ci@ec2-54-204-99-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180727 17:19:28-!- irker782 [~irker@uruz.ai0867.net] has quit [Read error: Connection timed out] 20180727 17:24:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180727 17:56:57-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds] 20180727 18:15:30-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180727 18:17:15-!- gfg [~androirc@tmo-081-125.customers.d1-online.com] has quit [Remote host closed the connection] 20180727 18:42:42-!- irker748 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180727 18:42:43< irker748> wesnoth/wesnoth:1.14 Jyrki Vesterinen cc57f98cb6 Lua: implement our own load() instead of AppVeyor: All builds passed 20180727 18:53:28-!- Appleman1234 [~quassel@101.162.145.198] has joined #wesnoth-dev 20180727 19:02:10-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180727 19:04:07<+discordbot> gfgtdf: how is the unit test cve_2018_1999023_2 supposed to work? 20180727 19:04:37<+discordbot> Looking at its code in a hex editor, it looks like you're assigning Lua bytecode to a variable... but you never try to actually load or run it. 20180727 19:07:52<+discordbot> Ah, I get it. The "code = " part is WML, not Lua. It's implicitly executed (except that it's not, because it's raw bytecode and it's blocked). Sorry, I mixed it up. 20180727 19:16:48<+discordbot> Aargh. I feel like pulling my hair out. I'm trying to find the code that maps the unit test names to filenames (in other words, opens "test_cve_2018_1999023_2.cfg" when you run Wesnoth with -ucve_2018_1999023_2). I placed a breakpoint to filesystem.cpp:istream_file() that fires whenever Wesnoth tries to open any file with "cve_2018_1999023" in its name. 20180727 19:16:55<+discordbot> The breakpoint is not hit. 20180727 19:17:31<+discordbot> Wesnoth is bypassing filesystem_boost in this case in some way, and I have no idea what it's using isnetad. I think it will be a long evening to figure it out... 20180727 19:47:26-!- Appleman1234 [~quassel@101.162.145.198] has quit [Remote host closed the connection] 20180727 19:50:27<+discordbot> Okay, it's using the config cache instead of actually reading the scenario from disk. 20180727 19:54:02<+discordbot> Also got the answer about how we map unit test names to filenames: we don't. We just read the WML in every file and get the test ID from [test] id= (usually via the GENERIC_UNIT_TEST macro). 20180727 19:54:55<+discordbot> (Might cause some sort of performance loss that we load absolutely everything in data/ regardless of what the player plays. Yes, including the unit tests.) 20180727 20:20:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 20:20:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 20:39:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 20:39:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 20:49:46< irker748> wesnoth: Jyrki Vesterinen wesnoth:1.14 ad90f368a351 / / (4 files in 2 dirs): check_utf8.sh: don't check the Lua bytecode file https://github.com/wesnoth/wesnoth/commit/ad90f368a351a5cb8784db6311a5299f53231b8d 20180727 20:49:48< irker748> wesnoth: Jyrki Vesterinen wesnoth:1.14 b869b760c4bd / utils/travis/check_utf8.sh: check_utf8.sh: don't check the second Lua bytecode test scenario https://github.com/wesnoth/wesnoth/commit/b869b760c4bdcb273ddc86c7307e4690ea58cb7c 20180727 20:54:24< irker748> wesnoth: Jyrki Vesterinen wesnoth:master 8dc60ae98fa4 / / (4 files in 2 dirs): check_utf8.sh: don't check the Lua bytecode file https://github.com/wesnoth/wesnoth/commit/8dc60ae98fa472d7a5fa124002f7b1a2f552e0f3 20180727 20:54:26< irker748> wesnoth: Jyrki Vesterinen wesnoth:master 212601deab6b / utils/travis/check_utf8.sh: check_utf8.sh: don't check the second Lua bytecode test scenario https://github.com/wesnoth/wesnoth/commit/212601deab6ba803db3e0b4ed8ee5d0cbc3f3018 20180727 21:01:06< irker748> wesnoth: josteph wesnoth:1.14 c7834f79db00 / data/campaigns/The_Hammer_of_Thursagan/scenarios/10_The_Siege_of_Kal_Kartha.cfg: THoT S10: Clarify objectives. https://github.com/wesnoth/wesnoth/commit/c7834f79db0074d2cdf53a6be270975ad08fa06d 20180727 21:01:08< irker748> wesnoth: josteph wesnoth:1.14 4e1290af6569 / data/campaigns/The_Hammer_of_Thursagan/scenarios/06_High_Pass.cfg: THoT S6: Rephrase Ratheln cue. https://github.com/wesnoth/wesnoth/commit/4e1290af65693019843f077132bd9db8133ecd21 20180727 21:03:22< irker748> wesnoth: josteph wesnoth:master 5758c900e248 / data/campaigns/The_Hammer_of_Thursagan/scenarios/06_High_Pass.cfg: THoT S6: Rephrase Ratheln cue. https://github.com/wesnoth/wesnoth/commit/5758c900e248baf3fc581e9932a2553d92120ac2 20180727 21:03:24< irker748> wesnoth: josteph wesnoth:master a08b7c3ab360 / data/campaigns/The_Hammer_of_Thursagan/scenarios/10_The_Siege_of_Kal_Kartha.cfg: THoT S10: Clarify objectives. https://github.com/wesnoth/wesnoth/commit/a08b7c3ab36047050872a0e4797a4b280bd2d22e 20180727 21:29:03-!- foxxo [57af8b86@gateway/web/freenode/ip.87.175.139.134] has joined #wesnoth-dev 20180727 21:29:52-!- foxxo [57af8b86@gateway/web/freenode/ip.87.175.139.134] has quit [Client Quit] 20180727 21:38:35-!- travis-ci [~travis-ci@ec2-54-167-199-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180727 21:38:36< travis-ci> wesnoth/wesnoth#18983 (master - 212601d : Jyrki Vesterinen): The build was fixed. 20180727 21:38:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/409113498 20180727 21:38:36-!- travis-ci [~travis-ci@ec2-54-167-199-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180727 21:39:12-!- valdar [~atarocch@31.159.220.15] has quit [Ping timeout: 265 seconds] 20180727 21:53:14<+discordbot> Was it decided that something is going to change regarding add-on icon validation? Or should I open a Github issue for it? Either way I'm very much leaning towards removing the add-ons server rule about it, since this really doesn't seem like something that should be handled manually, especially given that there's often no way to actually contact the uploader. 20180727 22:28:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180727 22:29:03-!- janebot [~Gambot@206.189.184.60] has joined #wesnoth-dev 20180727 22:29:05-!- janebot [~Gambot@206.189.184.60] has quit [Changing host] 20180727 22:29:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180727 22:34:16-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Leaving] 20180727 23:02:23< irker748> wesnoth/wesnoth:master loonycyborg 0c3ba36d68 scons: fix strict hardened builds on Gen AppVeyor: All builds passed 20180727 23:06:16< irker748> wesnoth: Iris Morelle wesnoth:1.14 7fef13f54e65 / / (5 files in 4 dirs): UtBS: New graphics for Eloh by me https://github.com/wesnoth/wesnoth/commit/7fef13f54e652265de93058ffbe5a84d108bd4ea 20180727 23:08:46< irker748> wesnoth: Iris Morelle wesnoth:master 6e1a861bdab9 / data/campaigns/Under_the_Burning_Suns/ (4 files in 3 dirs): UtBS: New graphics for Eloh by me https://github.com/wesnoth/wesnoth/commit/6e1a861bdab92edcd24c297aa97367dfcb6c0876 20180727 23:08:49< irker748> wesnoth: Iris Morelle wesnoth:master c56e8aa69538 / changelog.md: Sync 1.14 changelog https://github.com/wesnoth/wesnoth/commit/c56e8aa69538f119bb89c5a1683770b165e75f5d 20180727 23:09:03<+discordbot> @Vultraz 20180727 23:09:21<+discordbot> And no I cba to report the animation engine crash. 20180727 23:09:46<+discordbot> Maybe later if you remind me it exists. 20180727 23:20:27<+discordbot> \o/ 20180727 23:24:56<+discordbot> Now go and change all scenarios where she appears so that her team colour is teal xoxo 20180727 23:25:19<+discordbot> (inb4 random dev "why" -- vultraz knows why.) 20180727 23:30:49<+discordbot> "Unfortunately, for some reason, using a standing animation that's nothing but conditionals causes the game to crash at the moment." ^^ 20180727 23:32:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180727 23:32:42< irker748> wesnoth: Iris Morelle wesnoth:master 3b91481a0cba / data/campaigns/Under_the_Burning_Suns/units/quenoth/Divine_Avatar.cfg: UtBS: Improve Eloh's attack animation timings https://github.com/wesnoth/wesnoth/commit/3b91481a0cba943812bb8c629217f266be5f4e05 20180727 23:32:47< irker748> wesnoth: Iris Morelle wesnoth:1.14 11fe903ec5a0 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Divine_Avatar.cfg: UtBS: Improve Eloh's attack animation timings https://github.com/wesnoth/wesnoth/commit/11fe903ec5a0bdf12a2a0e7cd412802ccee78f1e 20180727 23:35:22<+discordbot> Floating text in animations speeds up once all animations have finished playing. 20180727 23:35:32<+discordbot> I rather doubt that's intentional. 20180727 23:40:26<+discordbot> @Vultraz If I implement a command to prevalidate .pbl metadata before uploading an add-on pack, would you be willing to work on the client-side end of it? 20180727 23:41:04<+discordbot> sure 20180727 23:41:30<+discordbot> And also, do you think this would be useful? 20180727 23:41:49<+discordbot> Because personally I'd rather see the error messages after uploading 2 KiB of metadata rather than a whole 90 MiB pack (TLU). 20180727 23:42:32<+discordbot> Someone complained about this back in the 1.10.x days I believe. 20180727 23:42:49<+discordbot> yes. --- Log closed Sat Jul 28 00:00:25 2018