--- Log opened Sat Jul 28 00:00:25 2018
20180728 00:00:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 00:00:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 00:00:52< irker748> wesnoth: DisherProject wesnoth:1.14 668202ebd2f0 / data/campaigns/Liberty/scenarios/ (05_Hide_and_Seek.cfg 06_The_Grey_Woods.cfg): Liberty S5-S6: Replace deprecated keys https://github.com/wesnoth/wesnoth/commit/668202ebd2f0a5290483be21afa1aec7cae8e36c
20180728 00:00:54< irker748> wesnoth: DisherProject wesnoth:1.14 ce2f82698c39 / data/campaigns/Liberty/scenarios/01_The_Raid.cfg: Liberty S1: Filter event by condition instead of using an https://github.com/wesnoth/wesnoth/commit/ce2f82698c3955b0386a7d251f19c7b88fa15334
20180728 00:00:56< irker748> wesnoth: DisherProject wesnoth:1.14 2218c94a9559 / data/campaigns/Liberty/scenarios/ (01_The_Raid.cfg 07_The_Hunters.cfg): Liberty S1-S7: Fire victory when enemies are defeated https://github.com/wesnoth/wesnoth/commit/2218c94a95597fb8a9ceb44abe322b87970740c1
20180728 00:00:58< irker748> wesnoth: DisherProject wesnoth:1.14 908c85eaaf67 / data/campaigns/Liberty/scenarios/08_Glory.cfg: Liberty S8: General fix and cleanup to the AI goals https://github.com/wesnoth/wesnoth/commit/908c85eaaf6753324ec8a3e6782ef3e55189e7ac
20180728 00:01:00< irker748> wesnoth: DisherProject wesnoth:1.14 5031d2077de7 / data/campaigns/Liberty/ (maps/08_Glory.map scenarios/08_Glory.cfg): Liberty S8: Remove unnecessary hidden side https://github.com/wesnoth/wesnoth/commit/5031d2077de7ca28ee9ac606af2f6ad7e7e31254
20180728 00:01:02< irker748> wesnoth: DisherProject wesnoth:1.14 ed88bd907c41 / data/campaigns/Liberty/scenarios/08_Glory.cfg: Liberty S8: Fix some event filters https://github.com/wesnoth/wesnoth/commit/ed88bd907c41c3d6424b4cd882eeb8a75350509f
20180728 00:01:32< irker748> wesnoth: DisherProject wesnoth:master ddf9949cffbd / data/campaigns/Liberty/scenarios/ (05_Hide_and_Seek.cfg 06_The_Grey_Woods.cfg): Liberty S5-S6: Replace deprecated keys https://github.com/wesnoth/wesnoth/commit/ddf9949cffbd7cf18704c0af95e75ad412dd0499
20180728 00:01:34< irker748> wesnoth: DisherProject wesnoth:master cbe2bcef6b64 / data/campaigns/Liberty/scenarios/01_The_Raid.cfg: Liberty S1: Filter event by condition instead of using an https://github.com/wesnoth/wesnoth/commit/cbe2bcef6b647a1cf4bba683f3c32a35b77d24e6
20180728 00:01:36< irker748> wesnoth: DisherProject wesnoth:master 4ced6c752630 / data/campaigns/Liberty/scenarios/ (01_The_Raid.cfg 07_The_Hunters.cfg): Liberty S1-S7: Fire victory when enemies are defeated https://github.com/wesnoth/wesnoth/commit/4ced6c752630d7703c1b73290417add9abb7e19e
20180728 00:01:38< irker748> wesnoth: DisherProject wesnoth:master e63a15fc913d / data/campaigns/Liberty/scenarios/08_Glory.cfg: Liberty S8: General fix and cleanup to the AI goals https://github.com/wesnoth/wesnoth/commit/e63a15fc913de1d51ea8caf4330409109e1b2f0f
20180728 00:01:40< irker748> wesnoth: DisherProject wesnoth:master f32dfaa9170a / data/campaigns/Liberty/ (maps/08_Glory.map scenarios/08_Glory.cfg): Liberty S8: Remove unnecessary hidden side https://github.com/wesnoth/wesnoth/commit/f32dfaa9170a998dbbacb54d73346cb67a32dd05
20180728 00:01:42< irker748> wesnoth: DisherProject wesnoth:master d13c451afb54 / data/campaigns/Liberty/scenarios/08_Glory.cfg: Liberty S8: Fix some event filters https://github.com/wesnoth/wesnoth/commit/d13c451afb544db67732adc0af269e764068bec6
20180728 00:27:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180728 00:49:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 00:49:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 00:54:03< irker748> wesnoth: Celtic Minstrel wesnoth:1.14 abb754cd8bee / src/ai/default/ca.cpp: Fix AI ignoring teleport locations when moving leader to leader goals https://github.com/wesnoth/wesnoth/commit/abb754cd8beed72a6aa2bdae06fafd173df1a312
20180728 01:36:15< celticminstrel> Eh?
20180728 01:36:47< celticminstrel> Oh, okay.
20180728 01:42:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 01:42:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 01:47:24<+discordbot> <sevu> Do you mean the backport? Please revert if you have doubts about it
20180728 02:00:17< celticminstrel> No, just took me by surprise. Once I looked at it I remembered.
20180728 02:00:41< celticminstrel> I think there might be a couple of things that I need to forward port actually...
20180728 02:01:16< irker748> wesnoth/wesnoth:1.14 josteph 77d78abc94 Fix various typos. AppVeyor: All builds passed
20180728 02:13:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 02:13:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 02:52:03<+discordbot> <Vultraz> many
20180728 03:37:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 03:38:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 04:15:31< irker748> wesnoth/wesnoth:1.14 josteph 6bc947d29e Liberty S8: Fix family reference. AppVeyor: All builds passed
20180728 05:07:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180728 05:10:09< irker748> wesnoth: Jyrki Vesterinen wesnoth:1.14 7f5ae378162a / data/test/scenarios/test_cve_2018_1999023.cfg: Extend the first CVE-2018-1999023 unit test to also try loadstring() https://github.com/wesnoth/wesnoth/commit/7f5ae378162a866fc3bfc6201b01c3e708327d64
20180728 05:10:11< irker748> wesnoth: Jyrki Vesterinen wesnoth:1.14 f4305cde33db / src/scripting/lua_kernel_base.cpp: Lua: also implement our own loadstring() https://github.com/wesnoth/wesnoth/commit/f4305cde33dbafa8818af2f75d35c61617cf81df
20180728 05:10:13< irker748> wesnoth: Jyrki Vesterinen wesnoth:1.14 a793bce96942 / run_wml_tests wml_test_schedule: WML unit tests: disable strict mode for the first CVE-2018-1999023 test https://github.com/wesnoth/wesnoth/commit/a793bce969429c4c7993e6a5f96e6f36f06b1489
20180728 05:19:28< irker748> wesnoth: Jyrki Vesterinen wesnoth:master aa73b836009c / data/test/scenarios/test_cve_2018_1999023.cfg: Extend the first CVE-2018-1999023 unit test to also try loadstring() https://github.com/wesnoth/wesnoth/commit/aa73b836009ca98cade2d0dfca6b99cbf8d19e76
20180728 05:19:30< irker748> wesnoth: Jyrki Vesterinen wesnoth:master 6450bada57f9 / src/scripting/lua_kernel_base.cpp: Lua: delete loadstring() https://github.com/wesnoth/wesnoth/commit/6450bada57f95af55c490f9d7601ef5e073cdaf1
20180728 05:19:32< irker748> wesnoth: Jyrki Vesterinen wesnoth:master 74d8cfa98e0f / run_wml_tests: WML unit tests: port ability to override strict mode from 1.14 https://github.com/wesnoth/wesnoth/commit/74d8cfa98e0f61ee22a536fc06c2019c9c89aede
20180728 05:32:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20180728 06:24:06-!- valdar [~atarocch@31.157.118.184] has joined #wesnoth-dev
20180728 06:33:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 06:37:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180728 06:39:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 06:42:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180728 07:34:01< irker748> wesnoth/wesnoth:master DisherProject d13c451afb Liberty S8: Fix some event filters AppVeyor: All builds passed
20180728 07:35:36-!- gallaecio [~quassel@89.96.79.188.dynamic.jazztel.es] has joined #wesnoth-dev
20180728 07:40:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180728 07:46:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 07:46:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 07:46:18<+discordbot> <Vultraz> @jyrkive ok, so, IIUC, with your changes, we no longer need to worry about applying another patch on top of Lua when we upgrade?
20180728 07:47:00<+discordbot> <jyrkive> Indeed.
20180728 07:47:04<+discordbot> <Vultraz> 👍
20180728 08:12:48-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20180728 08:13:02-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 244 seconds]
20180728 08:48:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 08:49:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 09:08:30< irker748> wesnoth/wesnoth:1.14 Celtic Minstrel abb754cd8b Fix AI ignoring teleport locations when  AppVeyor: All builds passed
20180728 09:35:26-!- valdar [~atarocch@31.157.118.184] has quit [Ping timeout: 256 seconds]
20180728 10:17:36-!- valdar [~atarocch@31.157.246.181] has joined #wesnoth-dev
20180728 10:40:41-!- gallaecio [~quassel@89.96.79.188.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
20180728 10:41:58-!- gallaecio [~quassel@89.96.79.188.dynamic.jazztel.es] has joined #wesnoth-dev
20180728 11:10:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 11:10:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 11:12:50< irker748> wesnoth/wesnoth:1.14 Jyrki Vesterinen a793bce969 WML unit tests: disable strict mode for  AppVeyor: All builds passed
20180728 11:22:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 11:22:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 11:47:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180728 13:21:53-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180728 14:10:33< irker748> wesnoth/wesnoth:master Jyrki Vesterinen 74d8cfa98e WML unit tests: port ability to override AppVeyor: All builds passed
20180728 14:22:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180728 15:52:29-!- travis-ci [~travis-ci@ec2-54-80-126-90.compute-1.amazonaws.com] has joined #wesnoth-dev
20180728 15:52:30< travis-ci> gfgtdf/wesnoth#1204 (1.14 - 9d3c480 : gfgtdf): The build was broken.
20180728 15:52:30< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/409310946
20180728 15:52:30-!- travis-ci [~travis-ci@ec2-54-80-126-90.compute-1.amazonaws.com] has left #wesnoth-dev []
20180728 15:58:11< vn971> Are there any design decisions on why "faction" and "faction_name" is read-only?  https://wiki.wesnoth.org/LuaWML:Sides#wesnoth.sides
20180728 15:58:59< vn971> I wonder if it'll be appropriate to feature-request the ability to change them.
20180728 16:21:45-!- travis-ci [~travis-ci@ec2-54-197-148-20.compute-1.amazonaws.com] has joined #wesnoth-dev
20180728 16:21:46< travis-ci> gfgtdf/wesnoth#1205 (1.14 - 5ed296b : gfgtdf): The build is still failing.
20180728 16:21:46< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/409317267
20180728 16:21:46-!- travis-ci [~travis-ci@ec2-54-197-148-20.compute-1.amazonaws.com] has left #wesnoth-dev []
20180728 16:26:19< celticminstrel> vn971: Not quite sure but IIUC faction is more of an initialization-only property - it has no effect during gameplay, only during game setup.
20180728 16:31:10< vn971> celticminstrel: oh, indeed. I somewhy assumed that recruits is a function from faction. But it's not, it's decoupled. Thanks, that actually solves my problem.
20180728 16:31:28< celticminstrel> somewhy o.o
20180728 16:35:18-!- travis-ci [~travis-ci@ec2-54-197-148-20.compute-1.amazonaws.com] has joined #wesnoth-dev
20180728 16:35:19< travis-ci> gfgtdf/wesnoth#1206 (1.14 - 242deac : gfgtdf): The build is still failing.
20180728 16:35:19< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/409320186
20180728 16:35:19-!- travis-ci [~travis-ci@ec2-54-197-148-20.compute-1.amazonaws.com] has left #wesnoth-dev []
20180728 16:42:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 16:42:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 16:51:50< vn971> celticminstrel: "somewhy" is a word that should exist! IDK why it doesn't. Makes total sense to me, "some why" is basically a combination of words with a very specific meaning. Other than that, I acknowledge the typo. Thx for the correction.
20180728 16:52:37< celticminstrel> Most people in that context would use "somehow" instead.
20180728 16:53:33< celticminstrel> I guess "somewhy" can only possibly mean "for some reason" though, whereas "somehow" is more like "in some manner".
20180728 16:54:15-!- travis-ci [~travis-ci@ec2-54-197-148-20.compute-1.amazonaws.com] has joined #wesnoth-dev
20180728 16:54:16< travis-ci> gfgtdf/wesnoth#1207 (1.14 - 60c1bc5 : gfgtdf): The build was fixed.
20180728 16:54:16< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/409322155
20180728 16:54:16-!- travis-ci [~travis-ci@ec2-54-197-148-20.compute-1.amazonaws.com] has left #wesnoth-dev []
20180728 17:01:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 17:01:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 17:02:07<+discordbot> <sevu> r.wesnoth.org/p592254
20180728 17:03:21<+discordbot> <sevu> I think the [role] tag should fail silently, and probably did earlier too. Similar to the message tag not printing messages  if the speaker doesn't exist. (And role is often used to determine a speaker)
20180728 17:03:48<+discordbot> <sevu> Not sure how up to date that erros is though
20180728 17:04:28<+discordbot> <sevu> And, the [role] tag in this example could be better (going to change that someday)
20180728 17:11:02-!- irker748 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180728 17:11:30<+discordbot> <sevu> Nevermind, this must habe been fixed since then.
20180728 18:11:16-!- gfgtdf [~chatzilla@x4e320767.dyn.telefonica.de] has joined #wesnoth-dev
20180728 18:32:09-!- gallaecio [~quassel@89.96.79.188.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
20180728 18:33:27-!- gallaecio [~quassel@89.96.79.188.dynamic.jazztel.es] has joined #wesnoth-dev
20180728 18:42:35< celticminstrel> So according to the wiki the [resource] tag and [modification] tag cannot add extra defines?
20180728 18:42:51< celticminstrel> (Didn't check [era] but I'm guessing it's also the same.)
20180728 18:43:10< celticminstrel> Does that means a terrain pack doesn't need an addon tag at all?
20180728 18:43:19 * celticminstrel pokes at gfgtdf 
20180728 18:46:13< gfgtdf> mods and eras can use extra defines, it shodul onyl be used for big addons though as it will always require an eras config reload which might take muhc longer than the little time safed by not parsing that config part by default
20180728 18:46:59< celticminstrel> While you're here, do you happen to know where in the source code editor group icons are parsed?
20180728 18:47:07< gfgtdf> [resource] cannot iirc.
20180728 18:47:15< celticminstrel> I'm pretty sure there should be a way to set a custom one and I'm trying to remember how.
20180728 18:47:43< gfgtdf> what do you mean by 'source code editor ' ?
20180728 18:48:14< celticminstrel> "where in the source code" "editor group icons are parsed" But I found it actually, so it's good.
20180728 18:50:15< gfgtdf> heh, misunderstood that.
20180728 18:51:03-!- irker873 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180728 18:51:03< irker873> wesnoth: gfgtdf wesnoth:1.14 0917a78c0257 / src/ (game_initialization/lobby_data.cpp server/server.cpp): fix require_scenario & require_era https://github.com/wesnoth/wesnoth/commit/0917a78c0257e317114828d23c0e7818bc6183d2
20180728 18:51:03< irker873> wesnoth: gfgtdf wesnoth:1.14 b107a26dd11a / src/game_initialization/playcampaign.cpp: fix skip replay being active in later scenarios https://github.com/wesnoth/wesnoth/commit/b107a26dd11a1d1e70dfa07783a977b3c4f4588a
20180728 18:51:04< irker873> wesnoth: gfgtdf wesnoth:1.14 02804c1482f6 / src/server/ (server.cpp server.hpp): add server notifications about outdated wesnoth versions. https://github.com/wesnoth/wesnoth/commit/02804c1482f6ea7cd4e8f081d57e8fe7b18296ff
20180728 18:51:05< gfgtdf> i'd be habby if someone could review the textstrings in my last commit.
20180728 18:51:41< gfgtdf> happy*
20180728 19:18:40< celticminstrel> Got it working, I needed to rename the icon to include _30 in the filename.
20180728 19:19:12< celticminstrel> BTW we should replace all instances of [editor_group] in master with the new [terrain_group] that allows use of images in arbitrary paths (rather than only in the terrains folder).
20180728 19:19:28< celticminstrel> I'll probably do that soon™.
20180728 19:40:00< celticminstrel> Why is the terrain rule not matching?
20180728 19:40:58< celticminstrel> Its map is 1 \n ,. \n 2, position 1 is *^ZSw*, position 2 is ZSwa^ZSde, and I have a map with those two terrains adjacent.
20180728 19:42:07< celticminstrel> It worked when it was ZSwa^ZSw* instead.
20180728 19:42:42< celticminstrel> Oh right, it was ^* not ^ZSw*, but still...
20180728 19:45:01<+discordbot> <sevu> Maybe sth alike ^xyz helps?
20180728 19:45:04< celticminstrel> Ooh, it must be the flag.
20180728 19:45:19<+discordbot> <sevu> Wait, the bot ate the stars
20180728 19:45:27-!- sevu [~Shiki@p54854E7C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180728 19:45:34< celticminstrel> So if I want a separate terrain for the river mouth I need to find a way to set the flag appropriately...
20180728 19:45:37< sevu> *^xyz*
20180728 19:46:03< celticminstrel> How do terrain flags even work...
20180728 19:46:28< celticminstrel> I think all I need to do is make it set each flag if a particular terrain is adjacent in a particular direction.
20180728 19:49:59< celticminstrel> Yeah, I got it working.
20180728 19:50:27< celticminstrel> Instead of testing for the flag I'm now setting it.
20180728 19:50:37< celticminstrel> \o/
20180728 19:50:53< celticminstrel> Now I just need one more thing and I should be able to replicate Wussel's screenshot.
20180728 19:51:58< celticminstrel> I think basically all I need is a terrain that has no images but just sets a bunch of flags...
20180728 19:52:06< celticminstrel> So EDITOR_OVERLAY I guess?
20180728 19:53:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 19:56:18-!- sevu [~Shiki@p54854E7C.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20180728 20:03:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180728 20:07:59-!- DeFender1031 [~DeFender1@89-138-231-156.bb.netvision.net.il] has joined #wesnoth-dev
20180728 20:08:24< zookeeper> celticminstrel, what screenshot and/or what's the problem?
20180728 20:08:44< celticminstrel> zookeeper: I got it working with two extra terrain types.
20180728 20:09:31< celticminstrel> ...link is coming once Firefox behaves.
20180728 20:09:47< celticminstrel> https://forums.wesnoth.org/viewtopic.php?f=23&t=37375&start=15
20180728 20:10:33< celticminstrel> lipk's code for it used a set of 3 river terrains, I've augmented it with a terrain for the river mouth and a terrain for the river's source.
20180728 20:12:50< zookeeper> oh, nice.
20180728 20:19:19< zookeeper> remind me, who's jostephd here?
20180728 20:20:05< celticminstrel> What's the size of an add-on icon, 72x72?
20180728 20:20:58< zookeeper> should be, anyway.
20180728 20:21:06<+discordbot> <jyrkive> zookeeper: I think he doesn't use IRC or Discord.
20180728 20:21:19< zookeeper> oh.
20180728 20:50:44< celticminstrel> I can't figure out why my test scenario isn't showing up in the multiplayer list...
20180728 20:52:23-!- vn971 [~vasya@94.158.103.15] has left #wesnoth-dev ["Leaving."]
20180728 21:01:40< celticminstrel> gfgtdf: Please clarify, is [multiplayer] supposed to support extra_defines?
20180728 21:01:54< celticminstrel> I thought it was but the game crashes if a scenario has it.
20180728 21:02:16< gfgtdf> iirc the mianline scenario 'a new land' useds that.
20180728 21:02:44< gfgtdf> the one where you have to survive by changing terrain.
20180728 21:03:31< celticminstrel> Hmm, I'll look at that one, I guess. But the one I'm trying to do is consistent - if I comment out extra_defines, it doesn't crash.
20180728 21:03:42< celticminstrel> The crash is in MP create, before I've even selected it.
20180728 21:04:04< celticminstrel> Just showing the list of scenarios causes a crash. It's a failed assert in the bitset.
20180728 21:06:42< gfgtdf> i thought that those attributes are procecced _after_ the mp create dialog. (or at the end of it, when you click the conformation)
20180728 21:07:26< celticminstrel> FTR, ANL uses define=, not extra_defines=
20180728 21:07:37< celticminstrel> But I get the crash with both on this scenario.
20180728 21:08:43< gfgtdf> so you used the wrong attribtue name which shoudl have no effect al all and it crashed ?
20180728 21:09:05< gfgtdf> that sounds extremely unlikely.
20180728 21:11:53< celticminstrel> Maybe the crash isn't directly related to what I've actually done?
20180728 21:12:05< gfgtdf> i'd assume its something different, maybe a bug in the mp create when filtering the list and recreating or similar. 
20180728 21:12:17< celticminstrel> I just know that adding extra_defines or define triggers it, and removing those doesn't.
20180728 21:13:26< celticminstrel> Oh wait, now it's crashing even without that... :|
20180728 21:13:31< celticminstrel> Yeah, I dunno.
20180728 21:15:23< gfgtdf> if you have a way to reproduce the crash please file a bugreport on wesnoth issue tracker.
20180728 21:15:46-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-izhbjadklhfkjyic] has quit [Quit: PanicBNC - https://PanicBNC.net - currently sucks]
20180728 21:16:05< gfgtdf> or mabe it is already there ? https://github.com/wesnoth/wesnoth/issues/3149
20180728 21:16:10< gfgtdf> please check whether its that one
20180728 21:16:15< gfgtdf> celticminstrel: ^
20180728 21:16:35< celticminstrel> Ah! Yeah it's probably that one.
20180728 21:16:58< celticminstrel> The map uses custom terrains, and the define is supposed to bring them into scope.
20180728 21:18:22-!- aidanhs2 [~aidanhs@81.4.110.234] has quit [Ping timeout: 264 seconds]
20180728 21:22:29< celticminstrel> So gfgtdf are you saying that extra_defines doesn't work in an MP scenario?
20180728 21:22:50-!- aidanhs2 [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20180728 21:23:42< gfgtdf> seems like that, i do support making define= accept a comma seperated list there though, if someone wants to implement that.
20180728 21:24:08-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ptcetqehlrdpofcy] has joined #wesnoth-dev
20180728 21:24:29< gfgtdf> (which probably won't help you though if you targert 1.14)
20180728 21:24:32-!- matthiaskrgr is now known as Guest37760
20180728 21:29:52-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20180728 21:30:29-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20180728 21:37:14-!- valdar [~atarocch@31.157.246.181] has quit [Ping timeout: 256 seconds]
20180728 21:51:52-!- irker873 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180728 21:52:27-!- Guest37760 [matthiaskr@gateway/shell/panicbnc/x-ptcetqehlrdpofcy] has quit [Changing host]
20180728 21:52:27-!- Guest37760 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180728 21:52:27-!- Guest37760 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20180728 21:52:27-!- Guest37760 [matthiaskr@gateway/shell/panicbnc/x-ptcetqehlrdpofcy] has joined #wesnoth-dev
20180728 22:00:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20180728 22:04:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 22:08:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180728 22:08:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20180728 22:10:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 22:14:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20180728 22:15:39-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 22:17:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180728 22:18:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180728 23:23:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180728 23:32:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 23:32:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180728 23:49:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180728 23:50:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
--- Log closed Sun Jul 29 00:00:27 2018