--- Log opened Tue Aug 07 00:00:10 2018 --- Day changed Tue Aug 07 2018 20180807 00:00:10<+wesdiscordbot> Yeah I can't say I'm not fed up with everyone and their dog deciding to ship their own version of frameworks like Electron and resulting in hundreds of megabytes of wasted non-shareable memory. 20180807 00:00:29<+wesdiscordbot> On top of the additional hundreds of megabytes used by said applications. 20180807 00:07:05<+wesdiscordbot> The part whioch worries me is that they package the app with an electron version which they used when writing it... and don't update it -.- 20180807 00:08:09<+wesdiscordbot> electron is basically the cromium browser – browser related security holes appear all time, and are usually followed by quick fixes 20180807 00:13:03<+wesdiscordbot> @shadowm I got some feedback to the relese anouncement (wesnoth.org/start) 20180807 00:13:14<+wesdiscordbot> 🤔 20180807 00:13:22<+wesdiscordbot> With regards to more technically-oriented aspects, Wesnoth’s WML, Lua, and Formula Language engines have seen a great number of improvements and changes IN / DURING this release cycle. 20180807 00:13:45<+wesdiscordbot> ^ should such a word as written in caps be added to that sentence? 20180807 00:14:12<+wesdiscordbot> it could but it's not necessary 20180807 00:14:33<+wesdiscordbot> I think so too, it's up to shadowm 20180807 00:14:40<+wesdiscordbot> uhhh 20180807 00:14:41<+wesdiscordbot> No, it's up to Vultraz. 20180807 00:14:42<+wesdiscordbot> why 20180807 00:14:44<+wesdiscordbot> it's up to me 20180807 00:14:53<+wesdiscordbot> I wrote the draft for him to save time and he did the final version. 20180807 00:15:19<+wesdiscordbot> The draft was really a glorified outline. 20180807 00:16:39<+wesdiscordbot> 2) the link to the user's manual leads to the english version – there should be a translators hint to replace it with the lamgue specific link 20180807 00:16:50<+wesdiscordbot> if that is even possible… 20180807 00:17:36<+wesdiscordbot> i don't thin there is 20180807 00:20:34<+wesdiscordbot> For the above quotes line – what do you think about having a separate paragraph there? At least the translator wanted to do that 20180807 00:37:25<+wesdiscordbot> And, another thing: the deterministic mode (must be renamed to random seed in the RA too), it's not explained anywhere... not necessary in the RA, rather in the ingame help 20180807 00:37:49<+wesdiscordbot> (though there exists it's tooltip) 20180807 00:46:38<+wesdiscordbot> Oh, and I have been asked about suport for localized images in the Release Anouncement 20180807 01:07:57-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 240 seconds] 20180807 01:09:00-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180807 01:33:45-!- sevu [~sevu@p548546E4.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180807 01:38:35<+wesdiscordbot> "It should be possible to instruct po4a-gettextize to make image URLs translatable at the expense of breaking the string freeze. The primary concern here is whether it’s worth it, because it means that some translations will bother with going through the effort of replicating the screenshots provided (and their thumbnails, which aren’t trivial to produce since some are carefully framed and cropped) while others 20180807 01:38:36<+wesdiscordbot> won’t." @sevu 20180807 01:38:45<+wesdiscordbot> What's what I told Konrad2 when he asked me the same question a while ago. 20180807 01:42:21<+wesdiscordbot> i doubt they will. 20180807 01:42:24<+wesdiscordbot> so let's not 20180807 01:55:07-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180807 02:07:39< sevu> If they don't make new images, can't they just reuse the english ones then? 20180807 02:12:33<+wesdiscordbot> Yes? 20180807 02:12:40<+wesdiscordbot> That's what eeryone else does. 20180807 02:14:18< sevu> I mean you could offer the possibility then to allow custom images. (Some hints like they exist for making manual images may be of help) 20180807 02:22:16< sevu> It's just that I've been asked that question a few times, so there seems to be interest in it at least 20180807 02:22:34 * sevu falls asleep 20180807 02:22:36-!- sevu [~sevu@p548546E4.dip0.t-ipconnect.de] has quit [Quit: Verlassend] 20180807 02:35:07<+wesdiscordbot> Could you make up your mind 20180807 02:35:20<+wesdiscordbot> Are you asking about allowing custom images or about using the English ones? 20180807 02:35:29<+wesdiscordbot> And in either case we already answered the question? 20180807 02:47:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 02:47:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 02:55:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 02:55:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 03:51:20< celticminstrel> ... 20180807 03:51:27< celticminstrel> Seeing PR 2440 makes me think. 20180807 03:51:36< celticminstrel> Is there any good reason not to have something like... 20180807 03:51:54< celticminstrel> difficulty=_"Hard" | _"Novice" | _"Intermediate" etc 20180807 03:52:10< celticminstrel> And maybe also num_scenarios=9 or whatever 20180807 03:52:56< celticminstrel> And use that to automatically add a note on the end of each campaign's description that says _"($difficulty level, $num_scenarios scenarios.)" 20180807 03:52:58< celticminstrel> ??? 20180807 03:53:31< celticminstrel> For master only obviously. 20180807 03:54:15< celticminstrel> I guess it would only add it if the keys are present; if you only have one of the keys it would just add that info without the other info. Maybe it could even auto-calculate the number of scenarios, but that seems rather error-prone especially when you have branches. 20180807 04:31:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180807 06:04:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180807 06:31:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 07:05:42-!- valdar [~atarocch@93.68.190.216] has joined #wesnoth-dev 20180807 07:39:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 07:39:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 07:56:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180807 07:59:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180807 08:58:13-!- You're now known as lobby 20180807 09:03:20-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180807 09:35:51-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds] 20180807 10:44:35-!- valdar [~atarocch@93.68.190.216] has quit [Ping timeout: 240 seconds] 20180807 11:19:27-!- valdar [~atarocch@31.157.53.243] has joined #wesnoth-dev 20180807 11:46:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 11:46:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 12:24:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds] 20180807 12:45:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 12:51:11-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 244 seconds] 20180807 13:38:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20180807 14:34:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 14:34:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 15:19:31<+wesdiscordbot> gfgtdf: Rebuilt and restarted the mp server 20180807 15:20:00<+wesdiscordbot> Wait. 20180807 15:20:05<+wesdiscordbot> Is he even able to join the channel? 20180807 15:20:31<+wesdiscordbot> I just realized I haven't seen him in a while, does he not have a registered account? 20180807 15:20:41<+wesdiscordbot> good question... 20180807 15:20:42<+wesdiscordbot> Oh ffs. 20180807 15:20:44<+wesdiscordbot> He doesn't. 20180807 15:20:54<+wesdiscordbot> Whaaaaaaaat is wroooooon with you peeeeeeeople. 20180807 15:21:35<+wesdiscordbot> And no I'm not going to lift that restriction because he crap that comes out of the spam bots is really nasty. 20180807 15:25:18<+wesdiscordbot> Why am I not seeing map previews in the lobby now? 20180807 15:25:33<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/476410578995511296/unknown.png 20180807 15:26:04<+wesdiscordbot> Okay, observing that first game crashed the server. 20180807 15:27:29<+wesdiscordbot> Or the server otherwise coincidentally crashed after that but the last log message is 20180807 15:27:39<+wesdiscordbot> 20180807 15:25:38 info server: xxx.xxx.xxx.xxx ShikadiQueen joined game: "kacproc’s game" (2) as an observer. (socket: 0x559fb66d0100) 20180807 15:28:46<+wesdiscordbot> Okay, it keeps happening with that game in particular so I've rolled back to the previous build. 20180807 15:29:07<+wesdiscordbot> Hm. 20180807 15:31:40<+wesdiscordbot> And map previews are back as well. 20180807 15:32:03<+wesdiscordbot> So definitely something since 1.14.3-64-g6e81ae330f broke more than one thing. 20180807 15:32:18<+wesdiscordbot> oh dear 20180807 15:58:25<+wesdiscordbot> @sevu Yes, they can translate paths but we're not taking in new images so they should leave the image paths intact in the translation. 20180807 16:01:22< Soliton> i'm guessing the map_data change from https://github.com/wesnoth/wesnoth/commit/0917a78 is what broke map previews. 20180807 16:04:42-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-elegdaoudulxomsl] has quit [Quit: removing from IRC because user idle on matrix for 30+ days] 20180807 16:18:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 16:33:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180807 16:43:32< Soliton> @shadowm: did gfgtdf say anything about what to set recommended_version to? it doesn't look like it's set to anything so far and those new version messages on login will not make much sense without it. 20180807 16:43:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180807 16:44:13< Soliton> i guess we should just set it to the current released version. 20180807 16:44:50< Soliton> and we need to remember to update that each release then. 20180807 16:45:32<+wesdiscordbot> Hm no I don't think he said anything about it. 20180807 16:45:54-!- gfgtdf [~chatzilla@x4dba4ca7.dyn.telefonica.de] has joined #wesnoth-dev 20180807 16:46:03<+wesdiscordbot> But it's going to default to 0.0.0 so it's not going to say anything about it. 20180807 16:46:07< Soliton> not that that should account for the crashes though. 20180807 16:46:11< gfgtdf> test 20180807 16:46:33< Soliton> greetings. 20180807 16:46:39<+wesdiscordbot> As for the "secure version" message, the code has it set to 1.14.4 and it's not configurable. 20180807 16:47:17< Soliton> yeah, i noticed that. not sure if that's good or bad for the future. 20180807 16:47:43< gfgtdf> recommended_version is for 1.14.4 of littel use as those get already the 'secure version' warnings. its intended for later versions 20180807 16:48:40< Soliton> ah, indeed that message does not tell you what to upgrade to. 20180807 16:48:41< gfgtdf> i could have made the 'secure version' warning configurable aswell, but the idea was that other mp server get the wanring even if they are not configured properly. 20180807 16:48:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180807 16:48:55< Soliton> not particularly helpful. 20180807 16:49:31< Soliton> it'd be better to use defaults when a config key is not set. 20180807 16:49:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit] 20180807 16:51:07< Soliton> i would change the secure_version warning to also include the recommended_version and make it so we always update recommended_version appropriately. 20180807 16:51:44< Soliton> and it can default to wesnoth::version or whatever we have that gives the current release version. 20180807 16:51:49< gfgtdf> shadowm: do you know how tpo reproduce the crash on a local wesnothd ? 20180807 16:52:40< Soliton> gfgtdf: why did you change how map_data is read here https://github.com/wesnoth/wesnoth/commit/0917a78 ? 20180807 16:52:59< gfgtdf> 'wesnoth::version or whatever' is often a +dev version though, and we dont want to give people a 'version 1.14.4+dev is out while you are using 1.14.4' 20180807 16:53:18< Soliton> and as i said we won't. 20180807 16:53:52< Soliton> but that can not be fixed in code either way. it needs to be encoded in the release process. 20180807 16:54:08< gfgtdf> i think it's a mistake, not sure hwo it happens. 20180807 16:54:17< gfgtdf> (the map_data issue) 20180807 16:54:39< Soliton> well, it's fairly surely that commit. so the question is why you changed it there. 20180807 16:55:23< gfgtdf> 'it' = the mistake 20180807 16:55:34< Soliton> unfortunately i cannot decipher the fixme that you added there. 20180807 16:56:14< gfgtdf> the code just wanted to move the wesnothd::game::starting_pos out of the if, so that it can reuse 's' later `(if(s["require_scenario"].to_bool(false)) {)` 20180807 16:56:14< Soliton> oh you did not mean to commit that part? 20180807 16:56:37< gfgtdf> no i think i made a mistake when copying things. 20180807 16:56:38< Soliton> ah, so you meant to leave it as data.root()? 20180807 16:56:43< gfgtdf> ye 20180807 16:56:50< Soliton> ok, makes sense. 20180807 16:57:37< Soliton> so the only other stuff i see is the std::pair commit and the translation stuff. 20180807 16:58:21< Soliton> i'm guessing the std::pair change is simple enough so i guess the crash must be related to the preserve translations commit. 20180807 16:59:11< gfgtdf> ye the translation stuff is clearly the most complicated commit, (of the commits that i did i mean) so i'ts possily caused by that. 20180807 16:59:26< gfgtdf> it woudl be nice to have a way to reproduce the crash. 20180807 16:59:31< Soliton> perhaps we should just revert that for now and confirm that the other stuff works as expected. 20180807 16:59:43< Soliton> then we can take a closer look. 20180807 17:01:33< gfgtdf> hmm ye we could do that. 20180807 17:02:30<+wesdiscordbot> gfgtdf: I don't know how to reproduce the crash because it was with a specific (albeit vanilla) game. 20180807 17:02:39<+wesdiscordbot> The first one in the screenshot. 20180807 17:02:54< Soliton> might have something to do with what translation the host used. 20180807 17:04:39< gfgtdf> > Okay, it keeps happening with that game in particular 20180807 17:05:29< gfgtdf> do you mean you restarted the server multiple times,. then each time the player restarted that particular game you and tried to join and made the server crash each time ? 20180807 17:05:45<+wesdiscordbot> Yep. 20180807 17:07:05< Soliton> it looks like maybe_change_textdomain() is called with a null pointer and it does not check for that. 20180807 17:07:19< Soliton> or rather can be called with one. 20180807 17:08:51< gfgtdf> you mean endline2 at https://github.com/wesnoth/wesnoth/commit/20128ac9914c971d759399dff6f7ed8edcb960c8#diff-be5b1592dd6f3dfe11fd6f648158ffee ? 20180807 17:09:25< Soliton> yes. 20180807 17:10:39< gfgtdf> hmm ye that is posible and should be fixed but i don't really think it's the cause of shadowm crashes, since as i see it it would mena that the client is sending invalid wml. 20180807 17:10:46< Soliton> either the function should bail out or not be called with a null pointer. 20180807 17:11:27< Soliton> well, it's the first thing i noticed from the commit. haven't looked through all of it yet. 20180807 17:14:00< gfgtdf> ok have to go be i'll be back in the evening. 20180807 17:17:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 18:04:49-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180807 18:38:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 18:39:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 18:50:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 18:53:10-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 256 seconds] 20180807 19:02:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 19:07:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 19:16:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 19:31:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 19:35:54-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180807 19:37:23-!- sevu [~sevu@p54855848.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180807 19:47:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 20:20:18< gfgtdf> Soliton might have something to do with what translation the host used 20180807 20:20:45< gfgtdf> Soliton: in his screenshot the first game ends with `' game` though so it's probably english. 20180807 20:39:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 20:39:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 20:44:52< gfgtdf> hmm i cannot see anything special about that game, it had no mods, mainline scenario with mainline era, host was using wesnoth 1.14.4, a 2 players vs 2 ai game in a 4p map. 20180807 20:52:00< gfgtdf> @shaodwm: did it tell what type of crash it was? (assertion failure, segfault, uncaught exception, out of memory or something else) ? 20180807 21:13:40<+wesdiscordbot> It certainly wasn't an assertion failure or uncaught exception. 20180807 21:13:56<+wesdiscordbot> The console for the process was detached so I have no idea. 20180807 21:17:35<+wesdiscordbot> gfgtdf: https://pastebin.com/DkkawKhe 20180807 21:18:21< gfgtdf> thx 20180807 21:23:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 21:23:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 21:28:33< gfgtdf> maybe the problme is that the textdomain of an atibute is not updated in 'node::shift_buffers' 20180807 21:31:16-!- valdar [~atarocch@31.157.53.243] has quit [Ping timeout: 256 seconds] 20180807 21:31:27< gfgtdf> ye i think that could be it. 20180807 21:35:26-!- sevu [~sevu@p54855848.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 20180807 21:38:18< gfgtdf> i wonder whether i should keep the typo in the whe i name the commit `fixup 'preserve traslatable strings in simple_wml.'` 20180807 21:38:33< gfgtdf> keeping it might make it easier to find the commit referenced to. 20180807 21:42:21< gfgtdf> hmm i guess irker is unregistered too. 20180807 21:50:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180807 21:53:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds] 20180807 22:11:53-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180807 22:16:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 22:16:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 22:35:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 22:49:42-!- TheJJ is now known as jj 20180807 22:50:00-!- jj is now known as TheJJ 20180807 22:58:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180807 22:58:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180807 23:13:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180807 23:36:42<+wesdiscordbot> i hope someone's ensuring all these commits get forward-ported 20180807 23:39:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180807 23:39:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Wed Aug 08 00:00:41 2018