--- Log opened Mon Aug 13 00:00:00 2018 20180813 00:03:45<+wesdiscordbot> It works – I must have made sth. wrong the last time. Thanks for support 😃 20180813 00:05:12< irker418> wesnoth/wesnoth:1.14 josteph 22277ac40f HttT S6: Support unlikely player behavio AppVeyor: vs2015/Release Failed 20180813 00:05:13< irker418> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4517 20180813 00:12:39< irker418> wesnoth/wesnoth:1.14 Celtic Minstrel 543d35447f Merge pull request #3451 from wesnoth/Fi AppVeyor: 2/4 builds failed 20180813 00:12:40< irker418> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-4229 20180813 00:12:41< irker418> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4514 20180813 00:26:39< irker418> wesnoth/wesnoth:Fix_Xcode_10_building_master Martin Hrubý (hrubymar10) 965aeb36ad Fix building with Xcode 10 - #3458 AppVeyor: vs2015/Release Failed 20180813 00:26:40< irker418> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-Fix_Xcode_10_building_master-4518 20180813 00:31:15< irker418> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 2deaddae92 Fixed typo AppVeyor: vs2015/Release Failed 20180813 00:31:16< irker418> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4524 20180813 00:43:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 00:43:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 00:55:27-!- travis-ci [~travis-ci@ec2-54-167-243-48.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 00:55:28< travis-ci> gfgtdf/wesnoth#1227 (1.14 - df1ed19 : gfgtdf): The build was broken. 20180813 00:55:28< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415245037 20180813 00:55:28-!- travis-ci [~travis-ci@ec2-54-167-243-48.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 01:03:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 01:03:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 01:07:17-!- travis-ci [~travis-ci@ec2-54-197-152-157.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 01:07:18< travis-ci> gfgtdf/wesnoth#1228 (1.14 - 614700c : gfgtdf): The build was broken. 20180813 01:07:18< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415247930 20180813 01:07:18-!- travis-ci [~travis-ci@ec2-54-197-152-157.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 01:12:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180813 01:25:05-!- gfgtdf [~chatzilla@x2f6124b.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20180813 01:35:59-!- travis-ci [~travis-ci@ec2-54-197-152-157.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 01:36:00< travis-ci> gfgtdf/wesnoth#1229 (1.14 - 6a75bfb : gfgtdf): The build is still failing. 20180813 01:36:00< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415252537 20180813 01:36:00-!- travis-ci [~travis-ci@ec2-54-197-152-157.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 01:41:57< irker418> wesnoth/wesnoth:illuminating_campfire Celtic Minstrel 1f8c7d3fef Make the fire terrains actually illumina AppVeyor: All builds passed 20180813 01:48:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 01:49:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 02:04:56-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 02:04:57< travis-ci> gfgtdf/wesnoth#1230 (1.14 - 0e1c7fb : gfgtdf): The build was fixed. 20180813 02:04:57< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415256280 20180813 02:04:57-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 02:22:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 02:22:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 02:54:50< irker418> wesnoth/wesnoth:1.14 Elvish_Hunter eb65a44de0 wmllint: added [lua] to the allowed chil AppVeyor: vs2017/Release Failed 20180813 02:54:51< irker418> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-4241 20180813 02:59:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 02:59:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 03:34:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 03:35:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 03:42:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 03:42:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 04:15:50-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!] 20180813 04:21:04< irker418> wesnoth/wesnoth:master Celtic Minstrel a2daff2b5c Make the fire terrains actually illumina AppVeyor: All builds passed 20180813 04:22:27< celticminstrel> ...wow I actually forgot I did that. 20180813 04:50:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180813 05:05:12< irker418> wesnoth/wesnoth:1.14 josteph 22277ac40f HttT S6: Support unlikely player behavio AppVeyor: 2/4 builds failed 20180813 05:05:13< irker418> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4517 20180813 05:05:14< irker418> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-4232 20180813 05:26:39< irker418> wesnoth/wesnoth:Fix_Xcode_10_building_master Martin Hrubý (hrubymar10) 965aeb36ad Fix building with Xcode 10 - #3458 AppVeyor: 2/4 builds failed 20180813 05:26:40< irker418> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-Fix_Xcode_10_building_master-4518 20180813 05:26:41< irker418> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-Fix_Xcode_10_building_master-4233 20180813 05:31:15< irker418> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 2deaddae92 Fixed typo AppVeyor: 2/4 builds failed 20180813 05:31:16< irker418> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4524 20180813 05:31:17< irker418> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-4239 20180813 06:24:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 06:24:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 06:32:07-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180813 06:32:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180813 06:34:30< irker418> wesnoth/wesnoth:master Elvish_Hunter b1ec52cab8 wmllint: added [lua] to the allowed chil AppVeyor: All builds passed 20180813 06:36:08< irker418> wesnoth: Jyrki Vesterinen wesnoth:Fix_Xcode_10_building_master bb72d55a01d8 / projectfiles/VC14/ (4 files): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/bb72d55a01d8fdda2d28519331155a3abd945dfd 20180813 06:36:32<+wesdiscordbot> @hrubymar10 Visual Studio update cherry-picked to that Xcode 10 branch. 20180813 06:36:44<+wesdiscordbot> Untested. I'm at work and don't have VS2015 installed here. 20180813 07:07:53<+wesdiscordbot> Thank you 20180813 07:52:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180813 07:53:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180813 07:54:51< irker418> wesnoth/wesnoth:1.14 Elvish_Hunter eb65a44de0 wmllint: added [lua] to the allowed chil AppVeyor: 2/4 builds failed 20180813 07:54:52< irker418> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-4241 20180813 07:54:53< irker418> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4526 20180813 08:18:20< irker418> wesnoth/wesnoth:master Jyrki Vesterinen 6d2c4529be Update Visual Studio project AppVeyor: vs2017/Release Failed 20180813 08:18:21< irker418> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-4243 20180813 09:21:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180813 09:40:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 09:40:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 11:18:42-!- irker418 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180813 11:55:54-!- irker223 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180813 11:55:54< irker223> wesnoth/wesnoth:master Pentarctagon c5fc954cdc Fixes track titles not being set from WM AppVeyor: All builds passed 20180813 12:04:57-!- valdar [~atarocch@2.43.176.228] has joined #wesnoth-dev 20180813 12:24:05-!- gfgtdf [~chatzilla@x55b2a678.dyn.telefonica.de] has joined #wesnoth-dev 20180813 12:24:11< gfgtdf> zookeeper: online ? 20180813 12:25:01< zookeeper> gfgtdf, very very briefly right now, what's up? 20180813 12:26:08< gfgtdf> i want to add a new key to [terrain_mask] to sepcify whether the data is in the odd or the even format, see https://github.com/gfgtdf/wesnoth/commit/4d11cf3fbef2a9354138433721768c8b73ab7275, do you think 'alignment' is a good name for such a key ? 20180813 12:26:57< gfgtdf> (currently i have it names is_odd=yes/no which i somehow don't really like) 20180813 12:28:20< zookeeper> yeah... both alignment= and is_odd= seem okay to me. 20180813 12:29:38< gfgtdf> k 20180813 12:59:37< irker223> wesnoth/wesnoth:master Pentarctagon 5216f2a89f Fixes track titles not being set from WM AppVeyor: All builds passed 20180813 13:18:21< irker223> wesnoth/wesnoth:master Jyrki Vesterinen 6d2c4529be Update Visual Studio project AppVeyor: 2/4 builds failed 20180813 13:18:22< irker223> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-4243 20180813 13:18:23< irker223> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4528 20180813 13:28:46< irker223> wesnoth: gfgtdf wesnoth:master 7bf37a1e6438 / src/playsingle_controller.cpp: fix game crashing on 'reset replay' https://github.com/wesnoth/wesnoth/commit/7bf37a1e64388304d583cdaa1fbba97fd61f9658 20180813 13:28:48< irker223> wesnoth: gfgtdf wesnoth:master 02bed5c03358 / src/server/game.cpp: fix oos when undoing after ally chat https://github.com/wesnoth/wesnoth/commit/02bed5c0335893542f5f3732ea013ab1ca705c55 20180813 13:28:50< irker223> wesnoth: gfgtdf wesnoth:master c685031d1c41 / src/replay.cpp: fix oos when undoing after ally chat 2 https://github.com/wesnoth/wesnoth/commit/c685031d1c41d89897bbd380b50ef3e02984bcde 20180813 13:28:52< irker223> wesnoth: gfgtdf wesnoth:master 7e0d63d7c32b / src/server/simple_wml.cpp: fix segfault in wesnothd https://github.com/wesnoth/wesnoth/commit/7e0d63d7c32b4c280baa63cb60dc32c565ea0eae 20180813 13:28:54< irker223> wesnoth: gfgtdf wesnoth:master 9a3917dc3518 / src/server/server.cpp: fix missing map previews in the lobby https://github.com/wesnoth/wesnoth/commit/9a3917dc3518455b0b8fa03f95ea71217a23550c 20180813 13:28:56< irker223> wesnoth: gfgtdf wesnoth:master bd16aeec02ce / src/server/server.cpp: improve wesnoth version warning 3 https://github.com/wesnoth/wesnoth/commit/bd16aeec02ceeeca42b281cfe2bf46a5f3791bca 20180813 13:28:58< irker223> wesnoth: gfgtdf wesnoth:master f03e3e8d6df8 / src/gui/dialogs/multiplayer/ (mp_join_game.cpp mp_join_game.hpp): fix 'start game' locked when other players abort flg dialog #3452 https://github.com/wesnoth/wesnoth/commit/f03e3e8d6df84163f403d5860be7638084bd1481 20180813 13:29:00< irker223> wesnoth: gfgtdf wesnoth:master 7e2dc296ba2f / src/actions/ (undo.cpp undo.hpp): boost::ptr_vector -> std::vector https://github.com/wesnoth/wesnoth/commit/7e2dc296ba2fd3900a46ab3a0bbb120e856e0ada 20180813 13:29:02< irker223> wesnoth: gfgtdf wesnoth:master 1646a7b90672 / src/actions/ (undo.cpp undo.hpp): fix game freezes on droiding when using dsu #3453 https://github.com/wesnoth/wesnoth/commit/1646a7b90672435551436c1fe272f5546f151ffb 20180813 13:29:04< irker223> wesnoth: gfgtdf wesnoth:master e90f0fce13e7 / src/terrain/translation.cpp: remove outdated code https://github.com/wesnoth/wesnoth/commit/e90f0fce13e74b53dbac92d7a588909948f6a93f 20180813 13:29:06< irker223> wesnoth: gfgtdf wesnoth:master 9bb601e2da02 / src/map/map.cpp: add debug info https://github.com/wesnoth/wesnoth/commit/9bb601e2da02b3b627b6673897c67c9c6f67a950 20180813 13:29:08< irker223> wesnoth: gfgtdf wesnoth:master 8d6524c6e21a / src/ (7 files in 5 dirs): deploy string_view https://github.com/wesnoth/wesnoth/commit/8d6524c6e21a4c5bfc99963fe0b95b9f8956f8ce 20180813 13:29:10< irker223> wesnoth: gfgtdf wesnoth:master a3367ee84896 / src/ (6 files in 3 dirs): add wesnoth.terrain_mask lua function https://github.com/wesnoth/wesnoth/commit/a3367ee8489608a6fff42a69fb026933571848b7 20180813 13:29:12< irker223> wesnoth: gfgtdf wesnoth:master 6cd9de1202d1 / src/ (scripting/game_lua_kernel.cpp team.cpp team.hpp): fix villages after terrain_mask https://github.com/wesnoth/wesnoth/commit/6cd9de1202d1f4f90d56ba9b7950aecfc1e5f3f4 20180813 13:29:14< irker223> wesnoth: gfgtdf wesnoth:master 09c56ef2fe40 / / (7 files in 5 dirs): move [terrain_mask] to lua https://github.com/wesnoth/wesnoth/commit/09c56ef2fe40eaec53311918288431256aac63ff 20180813 13:46:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20180813 14:20:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 14:20:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 14:29:17< irker223> wesnoth/wesnoth:master gfgtdf 09c56ef2fe move [terrain_mask] to lua AppVeyor: vs2017/Release Failed 20180813 14:29:18< irker223> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-4244 20180813 14:30:41-!- travis-ci [~travis-ci@ec2-54-226-151-241.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 14:30:42< travis-ci> gfgtdf/wesnoth#1233 (1.14 - 1f67e43 : gfgtdf): The build has errored. 20180813 14:30:42< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415443725 20180813 14:30:42-!- travis-ci [~travis-ci@ec2-54-226-151-241.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 14:39:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 14:39:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 15:46:30< irker223> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 7217ebf1cc81 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Remove garbage from Xcode project https://github.com/wesnoth/wesnoth/commit/7217ebf1cc81491f68ae473d4c1f691f9077abe5 20180813 15:54:05-!- travis-ci [~travis-ci@ec2-54-226-151-241.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 15:54:06< travis-ci> gfgtdf/wesnoth#1235 (1.14 - 9b22603 : gfgtdf): The build passed. 20180813 15:54:06< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415489370 20180813 15:54:06-!- travis-ci [~travis-ci@ec2-54-226-151-241.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 15:54:13< irker223> wesnoth: gfgtdf wesnoth:master 7d44782e5c02 / data/lua/wml-tags.lua: fixup [terrain_mask] https://github.com/wesnoth/wesnoth/commit/7d44782e5c027c3aee6b0b0bf89cac3f874cd672 20180813 15:54:54< irker223> wesnoth: Martin Hrubý (hrubymar10) wesnoth:update_check 9586dfabaf04 / / (7 files in 4 dirs): --no-update-check argumment added and backed for update checking added https://github.com/wesnoth/wesnoth/commit/9586dfabaf0405432095f4ea20e579a6e1ec095b 20180813 16:07:09< irker223> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) 7217ebf1cc Remove garbage from Xcode project AppVeyor: vs2017/Release Failed 20180813 16:07:10< irker223> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-4245 20180813 16:08:01-!- valdar [~atarocch@2.43.176.228] has quit [Ping timeout: 248 seconds] 20180813 16:11:37< gfgtdf> @hrubymar10 i once tried something similar https://github.com/wesnoth/wesnoth/pull/558/files 20180813 16:11:47< gfgtdf> @hrubymar10 maybe that helps you 20180813 16:12:27<+wesdiscordbot> If that's implemented, it will ONLY be to the extent of notifying players as to a new available version. 20180813 16:12:36<+wesdiscordbot> NO hand-rolled automatic updaters. 20180813 16:16:41< gfgtdf> @hrubymar10 the main challenge there was really to talk to people to do the serversided stuff like actuall putting the files with the version info to the server, in the end i gave up and came to the conclusion that my time is best spend on projects that i can do completely on my own. 20180813 16:17:05<+wesdiscordbot> Yes, I want to only inform players that there is update available. 20180813 16:18:03<+wesdiscordbot> gfgtdf: I am macOS packager so I already have to put sha256 sum on f.w.o so I'll bump version number myself here 20180813 16:21:16< gfgtdf> @hrubymar10 hmm in that case it'll be easier, i think that code will still work, (most of is is copied form a boost sync samplecode) 20180813 16:22:19< gfgtdf> @hrubymar10 i think it is realyl important that the code doesn not wait for the version query to be complte at startup, but rather does that version check in the background so that you will ahev no lags on startup when you do the version cehck. 20180813 16:22:57<+wesdiscordbot> It's not hard to spawn a thread for the version check. 20180813 16:23:29<+wesdiscordbot> Another open source project of mine has an asynchrnonous youtube-dl updater. 20180813 16:23:30< gfgtdf> yes i know (or use asio and a pump handler liek my linked code does) 20180813 16:24:06<+wesdiscordbot> Can I somehow update GUI label dynamically? 20180813 16:24:46<+wesdiscordbot> I'll spawn new thread for update checking and once it will be done, title screen will be probably already rendered 20180813 16:26:24<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/7217ebf1cc81491f68ae473d4c1f691f9077abe5/src/gui/widgets/styled_widget.hpp#L217 20180813 16:26:48<+wesdiscordbot> Call it with run_in_main_thread(), GUI2 isn't thread-safe. 20180813 16:34:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180813 16:52:57-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 16:52:58< travis-ci> wesnoth/wesnoth#19176 (master - 7d44782 : gfgtdf): The build passed. 20180813 16:52:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/415513637 20180813 16:52:58-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 17:16:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180813 17:20:43-!- valdar [~atarocch@2.43.196.14] has joined #wesnoth-dev 20180813 17:24:38< irker223> wesnoth: Jyrki Vesterinen wesnoth:Fix_Xcode_10_building_master 873390f9e538 / / (9 files in 3 dirs): Also rename gui/dialogs/game_version.hpp https://github.com/wesnoth/wesnoth/commit/873390f9e538aead0c92ecfe85e4f577df2e2ed3 20180813 17:32:12< irker223> wesnoth: Jyrki Vesterinen wesnoth:1.14 3ebdfe75d0fc / / (9 files in 3 dirs): Also rename gui/dialogs/game_version.hpp https://github.com/wesnoth/wesnoth/commit/3ebdfe75d0fca571b990b032f868bc4b34cc4488 20180813 17:32:42-!- valdar [~atarocch@2.43.196.14] has quit [Quit: Leaving] 20180813 17:33:03-!- valdar [~atarocch@2.43.196.14] has joined #wesnoth-dev 20180813 17:33:37<+wesdiscordbot> Why 20180813 17:33:49<+wesdiscordbot> Doesn't build otherwise. 20180813 17:34:07<+wesdiscordbot> Why?? I didn't think there was anything else using game_version as a namestem. 20180813 17:34:21<+wesdiscordbot> ``14:33:48 shadowm@hanacore ~/src/wesnoth git:master % find src -name game_version.* src/gui/dialogs/game_version.hpp src/gui/dialogs/game_version.cpp ``` 20180813 17:34:50<+wesdiscordbot> Yep, there isn't. 20180813 17:35:07<+wesdiscordbot> There is as of https://github.com/wesnoth/wesnoth/commit/49f6736798842c4613e2ab8a7c7c1dfafa734422 20180813 17:35:32<+wesdiscordbot> What 20180813 17:35:46<+wesdiscordbot> What kind of fix is this in the first place? 20180813 17:36:22<+wesdiscordbot> Discussion starting from this comment: https://github.com/wesnoth/wesnoth/issues/3350#issuecomment-412264873 20180813 17:36:51<+wesdiscordbot> Why didn't you rename the widget instead? 20180813 17:36:57<+wesdiscordbot> Not the widget, the widget's code files. 20180813 17:37:09<+wesdiscordbot> That' 20180813 17:37:16<+wesdiscordbot> s what I renamed. 20180813 17:37:18<+wesdiscordbot> Also version should've become version_info. 20180813 17:37:39<+wesdiscordbot> " Fix building with Xcode 10 by renaming image, version and settings in root of src" 20180813 17:37:55<+wesdiscordbot> src/{image.cpp => picture.cpp} | 2 +- 20180813 17:38:25<+wesdiscordbot> Top-level version.hpp was first renamed to game_version.hpp (to fix conflict with desktop/version.hpp and spirit_po/version.hpp). Then I renamed gui7dialogs/game_version.hpp to game_version_dialog.hpp. 20180813 17:38:31<+wesdiscordbot> game_version is a terrible name because the game isn't the only user of version_info and it really should've been named version_info in the first place anyway but I didn't think of that when I wrote my patch back then. 20180813 17:38:48<+wesdiscordbot> Ugh. 20180813 17:39:24<+wesdiscordbot> Here's why picture is the worst name you could possibly come up with: because there's no picture class or picture namespace declared in it. 20180813 17:39:50<+wesdiscordbot> Most coders do not think of using their internal thesaurus when looking up where something is declared/defined. 20180813 17:39:53<+wesdiscordbot> Eh, I think the originally suggested image_general.hpp was worse. 20180813 17:40:32<+wesdiscordbot> image_api, image_manager, image_locator, image_cache, image_loader 20180813 17:40:47<+wesdiscordbot> Those are the first context-relevant options that spring to mind. 20180813 17:42:40<+wesdiscordbot> gfgtdf: I rebuilt and restarted trunk btw. 20180813 17:43:36<+wesdiscordbot> Not that it's particularly useful as long as the game is unplayable because of the half-baked UI implementation switchover, I guess. 20180813 17:46:09-!- valdar [~atarocch@2.43.196.14] has quit [Ping timeout: 248 seconds] 20180813 17:50:35-!- vn971 [~vasya@94.158.103.15] has left #wesnoth-dev ["Leaving."] 20180813 17:50:46-!- valdar [~atarocch@2.43.196.14] has joined #wesnoth-dev 20180813 18:05:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 18:05:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 18:07:13-!- travis-ci [~travis-ci@ec2-54-159-178-1.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 18:07:14< travis-ci> wesnoth/wesnoth#19177 (update_check - 9586dfa : Martin Hrubý (hrubymar10)): The build passed. 20180813 18:07:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/415513970 20180813 18:07:14-!- travis-ci [~travis-ci@ec2-54-159-178-1.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 18:07:29-!- valdar [~atarocch@2.43.196.14] has quit [Quit: Leaving] 20180813 18:16:33< irker223> wesnoth: gfgtdf wesnoth:1.14 a3cccc1ff1a0 / src/terrain/translation.cpp: remove outdated code https://github.com/wesnoth/wesnoth/commit/a3cccc1ff1a0782c53044032e8fad8f4d780be6c 20180813 18:16:35< irker223> wesnoth: gfgtdf wesnoth:1.14 e46a77b21861 / src/map/map.cpp: add debug info https://github.com/wesnoth/wesnoth/commit/e46a77b2186142de193fda2443585d2be2c434a0 20180813 18:16:37< irker223> wesnoth: gfgtdf wesnoth:1.14 00d19c87aa5c / src/ (7 files in 5 dirs): deploy string_view https://github.com/wesnoth/wesnoth/commit/00d19c87aa5c1d26bc803dea3edfc41676f7a2ed 20180813 18:41:18< irker223> wesnoth: gfgtdf wesnoth:1.14 a28fb945205e / src/editor/palette/location_palette.cpp: fix editor cannot add starting location for > 9 players. https://github.com/wesnoth/wesnoth/commit/a28fb945205ef970107c6b55023d312d4c1c0b9e 20180813 18:44:50-!- travis-ci [~travis-ci@ec2-54-159-178-1.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 18:44:51< travis-ci> wesnoth/wesnoth#19179 (Fix_Xcode_10_building_master - 873390f : Jyrki Vesterinen): The build was broken. 20180813 18:44:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/415553813 20180813 18:44:51-!- travis-ci [~travis-ci@ec2-54-159-178-1.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 19:01:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 19:01:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 19:07:40-!- travis-ci [~travis-ci@ec2-54-226-151-241.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 19:07:41< travis-ci> gfgtdf/wesnoth#1236 (master - 7d44782 : gfgtdf): The build failed. 20180813 19:07:41< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/415572554 20180813 19:07:41-!- travis-ci [~travis-ci@ec2-54-226-151-241.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 19:08:29< irker223> wesnoth/wesnoth:update_check Martin Hrubý (hrubymar10) 9586dfabaf --no-update-check argumment added and ba AppVeyor: vs2015/Release Failed 20180813 19:08:30< irker223> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-update_check-4532 20180813 19:23:51-!- behaleba- [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180813 19:25:20-!- Netsplit *.net <-> *.split quits: behalebabo, vihta, Elvish_Hunter 20180813 19:25:22-!- behaleba- is now known as behalebabo 20180813 19:29:17< irker223> wesnoth/wesnoth:master gfgtdf 09c56ef2fe move [terrain_mask] to lua AppVeyor: 2/4 builds failed 20180813 19:29:18< irker223> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-4244 20180813 19:29:19< irker223> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4529 20180813 19:31:19-!- Netsplit over, joins: Elvish_Hunter 20180813 19:31:24-!- gfgtdf [~chatzilla@x55b2a678.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.9.0/20180621064021]] 20180813 19:33:22-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 256 seconds] 20180813 19:50:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180813 19:50:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180813 19:54:01-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 19:54:02< travis-ci> wesnoth/wesnoth#19183 (1.14 - a28fb94 : gfgtdf): The build failed. 20180813 19:54:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/415585035 20180813 19:54:02-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 19:56:35< irker223> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) 21577325e1 --no-update-check argumment added and ba AppVeyor: vs2015/Release Failed 20180813 19:56:36< irker223> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4533 20180813 20:48:37< irker223> wesnoth: Martin Hrubý (hrubymar10) wesnoth:Fix_Xcode_10_building_master d7330b297616 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/d7330b297616612ac2294491c8b0a459a69de53a 20180813 21:07:10< irker223> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) 7217ebf1cc Remove garbage from Xcode project AppVeyor: 2/4 builds failed 20180813 21:07:11< irker223> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-4245 20180813 21:07:12< irker223> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4530 20180813 21:11:20-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has joined #wesnoth-dev 20180813 21:11:21< travis-ci> wesnoth/wesnoth#19184 (Fix_Xcode_10_building_master - d7330b2 : Martin Hrubý (hrubymar10)): The build is still failing. 20180813 21:11:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/415635739 20180813 21:11:21-!- travis-ci [~travis-ci@ec2-54-160-231-174.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180813 21:21:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180813 21:58:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20180813 22:08:03-!- vihta [sid239753@gateway/web/irccloud.com/x-akeyezaalleygynd] has joined #wesnoth-dev 20180813 22:09:27-!- TheJJ [~rofl@ipbcc05d72.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds] 20180813 22:38:40< irker223> wesnoth/wesnoth:master gfgtdf 7d44782e5c fixup [terrain_mask] AppVeyor: All builds passed 20180813 22:46:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180813 22:50:56-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Read error: Connection reset by peer] 20180813 22:52:40-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180813 23:09:26<+wesdiscordbot> [has_attack], part of SUFs, is not listed in the sidebar of the WML Reference… it belongs there, or? 20180813 23:31:26<+wesdiscordbot> Yeah. 20180813 23:45:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180813 23:54:01<+wesdiscordbot> just catched me pressing shift during loading screen … 🤦 --- Log closed Tue Aug 14 00:00:02 2018