--- Log opened Fri Aug 17 00:00:34 2018 20180817 00:37:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 00:42:35-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180817 00:46:13-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 268 seconds] 20180817 02:24:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 02:24:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 03:08:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20180817 03:08:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180817 03:18:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 03:18:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 03:23:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180817 03:24:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180817 03:35:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 03:42:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180817 03:44:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 03:46:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180817 03:52:30-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180817 05:06:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 06:00:34-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20180817 07:29:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 07:29:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 07:35:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180817 08:34:53-!- Nobun [~user@51.179.108.149] has joined #wesnoth-dev 20180817 10:53:53-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180817 11:52:39-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 244 seconds] 20180817 12:45:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180817 12:46:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180817 12:57:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180817 13:00:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180817 13:05:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit] 20180817 14:08:41-!- irker248 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180817 14:08:41< irker248> wesnoth/wesnoth:master newfrenchy83 975830fff3 Merge branch 'master' into patch-18 AppVeyor: All builds passed 20180817 14:55:50<+wesdiscordbot> Would it be alright if I merged joeylmaalouf's PRs? They all seem pretty straight forward, and have been around for more than a week now: https://github.com/wesnoth/wesnoth/pulls?q=is%3Aopen+is%3Apr+author%3Ajoeylmaalouf+sort%3Aupdated-desc 20180817 15:02:04< Soliton> i already wanted to merge the tie one but got distracted. 20180817 15:02:56< Soliton> the NR one should be trivial as well. 20180817 15:04:54< Soliton> not sure if the re-ranking is controversial. haven't looked in detail. 20180817 15:06:42< Soliton> haven't looked at the burner one either. i guess you should know that one. 20180817 15:11:54< irker248> wesnoth: joeylmaalouf wesnoth:1.14 b6a36652eda8 / data/campaigns/Northern_Rebirth/maps/14a_Epilogue.map: NR S14: Update epilogue map to match previous scenario (fixes #3385) https://github.com/wesnoth/wesnoth/commit/b6a36652eda8d5375f05992eb7cdd4c2cbaa47bf 20180817 15:11:56< irker248> wesnoth: Wedge009 wesnoth:1.14 009fb103cbc5 / data/campaigns/Northern_Rebirth/maps/14a_Epilogue.map: Merge pull request #3446 from joeylmaalouf/issue-3385 https://github.com/wesnoth/wesnoth/commit/009fb103cbc52db9b8cccfdb9ea5d775f22c8193 20180817 15:14:50<+wesdiscordbot> the burner just replaces the dunefolk burner line's current naptha attack icon(torch/fireball) with fireblast, which I think is fine. 20180817 15:34:16-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180817 15:59:03<+wesdiscordbot> I was first confused why one would remove the torch, but yes, makes sense 20180817 16:03:11<+wesdiscordbot> oh, someone added a 1.14.5 milestone 20180817 16:16:26< irker248> wesnoth/wesnoth:1.14 josteph 319090696f Liberty S8: Use a less anachronistic ter AppVeyor: All builds passed 20180817 16:28:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 16:37:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 16:37:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 16:47:01-!- sevu [~sevu@141.57.61.193] has joined #wesnoth-dev 20180817 16:47:45< sevu> Nobun, you're active again? 20180817 16:49:26< sevu> There was something which I wanted to test but did not yet… Would it be problematic if one uses _ as anonymous variales inside [lua] tags or lua files? 20180817 16:52:44< irker248> wesnoth: Konrad2 wesnoth:master cf999f7365f3 / data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg: Made Thursagens words fit the timeframe https://github.com/wesnoth/wesnoth/commit/cf999f7365f3ba14bf724d34c32cc154d3918b26 20180817 16:54:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180817 16:55:31< irker248> wesnoth: Konrad2 wesnoth:1.14 1540dcf972dd / data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg: Made Thursagens words fit the timeframe https://github.com/wesnoth/wesnoth/commit/1540dcf972dd02f62a594efbd4ef51fc18407597 20180817 17:04:09-!- sevu [~sevu@141.57.61.193] has quit [Remote host closed the connection] 20180817 17:08:07< Nobun> sevu: yes... those days I will be available here 20180817 17:08:52< Nobun> I received the wmlxgettext bug report from Elvish Hunter. I made the change with boundaries, but I still not tested it. I will do test tomorrow, I think 20180817 17:15:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 17:15:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 17:26:45<+wesdiscordbot> Nobun, I have to run wmlxgettext later, and also to sort out things in another add-on, where someone did do strange things like adding the translation mark with a macro instead in front of the string... I could use your not yet tested version while doing so 20180817 17:32:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 17:32:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 18:28:25<+wesdiscordbot> that was fast 20180817 18:43:02-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180817 18:50:33< Nobun> @sevu I didn't committed it yet. But I can say the change you need to do in order to test the change 20180817 18:52:09-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo.ga] 20180817 18:52:34< irker248> wesnoth: Iris Morelle wesnoth:master 36cf8c8d7019 / / (3 files in 3 dirs): gui2/game_load: Constrain leader sprites to 72x72 using image path functions https://github.com/wesnoth/wesnoth/commit/36cf8c8d70198c6090119398f2b52cd542feceb7 20180817 18:52:35< Nobun> on line 80 of pywmlx/state/lua_states.py -> line 80 20180817 18:52:39< irker248> wesnoth: Iris Morelle wesnoth:1.14 14ca6abc0ebd / / (3 files in 3 dirs): gui2/game_load: Constrain leader sprites to 72x72 using image path functions https://github.com/wesnoth/wesnoth/commit/14ca6abc0ebd2185409882e853666cbf5550f3c2 20180817 18:52:51-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180817 18:52:58< Nobun> replace self.regex (on LuaStr80) with this one: 20180817 18:53:08< Nobun> self.regex = re.compile(r'\b_\b\s*\(') 20180817 18:53:54< Nobun> sorry... s/on LuaStr80/on LuaStr00 20180817 18:59:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180817 19:09:39< irker248> wesnoth: Iris Morelle wesnoth:master d3650a78142e / data/core/images/units/monsters/fire-dragon.png: Revert unwanted binary file change in previous commit https://github.com/wesnoth/wesnoth/commit/d3650a78142e2f3cb9e29153c376c211b8776f61 20180817 19:09:44< irker248> wesnoth: Iris Morelle wesnoth:1.14 215bac859e13 / data/core/images/units/monsters/fire-dragon.png: Revert unwanted binary file change in previous commit https://github.com/wesnoth/wesnoth/commit/215bac859e13f4e46704ab714c5146e12603b042 20180817 19:16:28-!- Nobun [~user@51.179.108.149] has quit [Ping timeout: 244 seconds] 20180817 19:17:30< zookeeper> humm. that code doesn't seem to utilize [unit_type] image_icon= (if one is present), right? 20180817 19:21:09< zookeeper> because i suppose that would be preferable anywhere where <=72x72 needs to be forced for a unit sprite. 20180817 19:24:57<+wesdiscordbot> Patches welcome. The affected sprites in mainline do not use that attribute anyway. 20180817 19:27:30-!- Nobun [~user@51.179.108.149] has joined #wesnoth-dev 20180817 19:29:43< zookeeper> the knight line does so i'd imagine TB would be affected, but obviously that's not exactly a pressing issue in any way. 20180817 19:37:21<+wesdiscordbot> Quick fix o.O And so simple 😳 I thought this would lie ages on the bug tracker 20180817 19:48:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 19:48:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 19:58:12<+wesdiscordbot> zookeeper, I recall that the generic animations add-on had an icon with two units. 20180817 19:58:18<+wesdiscordbot> The log shows: 20180817 21:57:31 error display: ~BLIT(): image not found: 'units/khalifate/jundi.png' 20180817 19:58:47<+wesdiscordbot> while it unfortunately doesn't say to which add-on the errors belong, I think it's this one 20180817 19:59:30< zookeeper> ah, indeed 20180817 20:02:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180817 20:03:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 20:03:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180817 20:03:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 20:04:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180817 20:04:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 20:05:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180817 20:05:07-!- TC01 [~quassel@venus.arosser.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 20180817 20:05:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 20:05:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180817 20:06:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 20:06:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180817 20:31:23<+wesdiscordbot> 20180817 22:32:04 error display: ~BLIT(): image not found: 'hits/blade-3.png' this too 20180817 20:36:38< zookeeper> right, no idea how i managed to be so myopic as to miss that one 20180817 20:38:03<+wesdiscordbot> You're not the only experienced WML person with errors in the IPF for the add-on icon 😉 20180817 20:38:24< zookeeper> ohhhh, a good opportunity to finally try out the DataURI thing... 20180817 20:38:45< zookeeper> yeah, i just thought that i originally tested the icon without having the add-on installed. 20180817 20:44:41< zookeeper> i guess "i get a crash" means DataURIs won't work in a ~BLIT :> 20180817 20:56:58< irker248> wesnoth: josteph wesnoth:1.14 d6941a96a33e / src/menu_events.cpp: Fix crash after hitting enter when no units match the recall list filter https://github.com/wesnoth/wesnoth/commit/d6941a96a33e763243c95b902b1dd883dd3f90de 20180817 21:05:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180817 21:18:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20180817 21:23:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180817 21:39:36-!- Nobun [~user@51.179.108.149] has quit [Quit: quot quat] 20180817 21:56:59<+wesdiscordbot> Assuming you upload that everybody would get a crash… 20180817 21:58:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180817 22:00:39<+wesdiscordbot> Yeah, it'd be nice to hear about that in the bug tracker. 20180817 22:05:29<+wesdiscordbot> you should use scale_into_sharp if you want NN 20180817 22:05:34< zookeeper> i didn't investigate it more closely yet, i'll try to do so after i get this new but yet untested version of the add-on i cobbled together uploaded. 20180817 22:06:18<+wesdiscordbot> ftr, I hope someone's been checking all commits by gfgtdf go to both master and 1.14 20180817 22:11:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180817 22:11:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180817 22:12:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180817 22:13:14<+wesdiscordbot> @Vultraz Since the sprites will get downscaled most of the time and there's no guarantee that the actual size is a multiple of 72 (or even 2), I deliberately chose against that option. 20180817 22:13:23<+wesdiscordbot> k 20180817 22:13:24<+wesdiscordbot> It's better for upscaling than downscaling. 20180817 22:13:44<+wesdiscordbot> And only under those specific constraints. Ideally the original size must be a multiple of the target size. 20180817 22:15:33<+wesdiscordbot> zookeeper, you don't need to investigate a crash. 20180817 22:15:54<+wesdiscordbot> Just tell us what specific image path causes the game to crash and that's it. 20180817 22:17:48-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:20:24-!- TC01 [~quassel@venus.arosser.com] has quit [Client Quit] 20180817 22:20:33-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:24:00-!- TC01 [~quassel@venus.arosser.com] has quit [Client Quit] 20180817 22:35:18-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:40:56-!- TC01 [~quassel@venus.arosser.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 20180817 22:41:13-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:41:20-!- TC01 [~quassel@venus.arosser.com] has quit [Remote host closed the connection] 20180817 22:41:28-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:41:51-!- TC01 [~quassel@venus.arosser.com] has quit [Remote host closed the connection] 20180817 22:42:00-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:42:31-!- TC01 [~quassel@venus.arosser.com] has quit [Remote host closed the connection] 20180817 22:42:39-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:43:03-!- TC01 [~quassel@venus.arosser.com] has quit [Remote host closed the connection] 20180817 22:43:12-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180817 22:43:22-!- TC01 [~quassel@venus.arosser.com] has quit [Remote host closed the connection] 20180817 22:43:51< irker248> wesnoth: josteph wesnoth:master a3047f37d3c2 / src/menu_events.cpp: Fix crash after hitting enter when no units match the recall list filter https://github.com/wesnoth/wesnoth/commit/a3047f37d3c2d225dfa403eda5220858be221cc2 20180817 22:55:16<+wesdiscordbot> @hrubymar10 The xcode build is failing: https://travis-ci.org/wesnoth/wesnoth/jobs/417441191#L3315 20180817 22:55:30<+wesdiscordbot> not sure why there aren't alerts about it here though. 20180817 22:56:46<+wesdiscordbot> I thought that I fixed it already. 20180817 22:57:00<+wesdiscordbot> I’ll fix it tommorow 20180817 22:57:18<+wesdiscordbot> (In 10 hours) 20180817 22:58:04< irker248> wesnoth: joeylmaalouf wesnoth:master 3d47ed8ab457 / data/campaigns/Northern_Rebirth/maps/14a_Epilogue.map: NR S14: Update epilogue map to match previous scenario (fixes #3385) https://github.com/wesnoth/wesnoth/commit/3d47ed8ab4570cbf0135ff8cf45f41107b5b8241 20180817 23:01:46< irker248> wesnoth/wesnoth:1.14 josteph 1d79fb718a HttT S17: Explain the lava mechanic AppVeyor: All builds passed 20180817 23:13:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180817 23:36:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180817 23:44:44-!- sevu [~sevu@p5485415E.dip0.t-ipconnect.de] has joined #wesnoth-dev --- Log closed Sat Aug 18 00:00:35 2018