--- Log opened Sun Aug 26 00:00:25 2018 20180826 00:33:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 00:33:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 01:09:39< irker246> wesnoth/wesnoth:1.14 josteph 0a9db3bcb0 GUI2 Schema: Add missing parentheses to AppVeyor: All builds passed 20180826 01:12:57-!- gfgtdf [~chatzilla@x4dbbc6e0.dyn.telefonica.de] has quit [Ping timeout: 244 seconds] 20180826 01:19:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 01:19:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 03:01:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 03:01:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 03:04:35<+wesdiscordbot> celticminstrel: I don't really understand the problem, tbh. how does the current implementation fall short? 20180826 03:28:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 03:28:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 03:48:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 03:48:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 03:56:25< irker246> wesnoth/wesnoth:1.14 josteph 3d8a360a09 HttT S17: Show the 'Comic relief' commen AppVeyor: All builds passed 20180826 05:34:28< celticminstrel> @Pentarctagon - You mean with plague? 20180826 05:34:45< celticminstrel> [Aug 25@12:55:29pm] celticminstrel: If you're making a custom faction, how do you make it play well with standard undead? 20180826 05:34:46<+wesdiscordbot> yes 20180826 05:34:59< celticminstrel> The answer to that question is: you don't. 20180826 05:35:02< celticminstrel> You can't. 20180826 05:35:25< celticminstrel> Unless replacing the vanilla walking corpse and soulless with a custom unit that has additional variations is an option. 20180826 05:35:39< celticminstrel> It would certainly be an option in a campaign, but I'm not sure how well it would work in an era. 20180826 05:36:09< irker246> wesnoth/wesnoth:1.14 josteph 871162613f Game Load: Don't reserve space for the t AppVeyor: All builds passed 20180826 05:36:24< celticminstrel> In order to make plague play nice with a custom non-humanoid faction, you need to edit the walking corpse unit type definition and add a new variation. 20180826 05:36:49< celticminstrel> Thus, idea 1: Create a way to do that with a new [unit_variation] tag that patches a variation into a previously-defined [unit_type]. 20180826 05:37:26< celticminstrel> Mind you, it could cause the same sorts of problems that [advancefrom] already causes, but... well, [advancefrom] already causes them, so IMO they're a thing that needs to be fixed anyway. 20180826 05:39:46< celticminstrel> Idea 2 was a different implementation of the plague ability that dodges the issue altogether, though it has its own problems I guess (it would require one undead variation for every unit instead of one for each general category of units, I think). 20180826 05:39:57<+wesdiscordbot> is it not possible to use the WEAPON_SPECIAL_PLAGUE_TYPE TYPE macro, and define your own base walking corpse type unit for your own faction, that can have your own variations? 20180826 05:40:08< celticminstrel> Yeah, it's possible. 20180826 05:40:32< celticminstrel> I mentioned that a minute ago. 20180826 05:41:32<+wesdiscordbot> you don't need to replace any unit type definitions though, right? just create your own entirely separate unit. 20180826 05:41:46< celticminstrel> Hmm, I suppose what you might be thinking of is defining a walking corpse that only contains the extra variations, not the vanilla variations? 20180826 05:43:08<+wesdiscordbot> yeah 20180826 05:43:11< celticminstrel> Yeah, uh... that won't work, I'm pretty sure? 20180826 05:43:30< celticminstrel> The point is when pitting the default undead faction against your custom faction. 20180826 05:43:45<+wesdiscordbot> what's the point of being able to specify the type field in the plague macro then? 20180826 05:43:59< celticminstrel> You want the vanilla walking corpse to turn your units into a new variation appropriate for your custom faction. 20180826 05:44:10<+wesdiscordbot> ah 20180826 05:44:25< celticminstrel> The point of specifying the type field is for creating new units with a different kind of plague ability. 20180826 05:44:46< celticminstrel> Like I said, I think there are workarounds, but I'm not sure how well they work. 20180826 05:47:54<+wesdiscordbot> it sounds like tying the variation of the turned unit to the unit turning it is the problem then, when really it should be based on the unit that's been turned. 20180826 05:48:54< celticminstrel> Well, that was the basis of idea 2. 20180826 05:49:04< celticminstrel> I think. 20180826 05:49:20< celticminstrel> eg a plague that transforms any unit to its "undead" variation. 20180826 05:49:49< celticminstrel> And a way for a unit variation to inherit from an entirely different base unit, so it can inherit from the unit that causes the plague rather than the unit it belongs to. 20180826 05:50:44< celticminstrel> That would make matching zombies in filters a little trickier though - you wouldn't be able to match by unit type anymore. 20180826 05:50:55< celticminstrel> You'd have to filter by the combination of variation and level. 20180826 05:51:06< celticminstrel> (Or just variation if you want both WCs and soulless.) 20180826 05:51:33< celticminstrel> (Well, unless a unit variation can actually change the unit's type ID, but that would be weird IMO.) 20180826 05:54:06<+wesdiscordbot> it sounds to me like the most flexible solution would be to allow specifying it in the unit type, like: [undead_variation] type=some_undead_unit variation=some_variation [/undead_variation] and then make all units turned by plague have a dummy "Plagued" or "Turned" ability to allow filtering on them. 20180826 05:55:30< celticminstrel> Something like "if killed by this unit, turn into this variation"? 20180826 05:57:47<+wesdiscordbot> I was thinking like: if killed by a plague attack: change into the type defined by [undead_variation] > change into the type defined by [race] > change into a WC 20180826 05:58:54< celticminstrel> This sounds a bit confusing... 20180826 05:59:16<+wesdiscordbot> plague shouldn't be specifying the unit type the dying unit will change into, IMO 20180826 05:59:37< celticminstrel> It sounds like your idea is less flexible in some ways, though. 20180826 06:00:04< celticminstrel> Suppose we had two different plague abilities - one turns you into a zombie, the other turns you into a ghost. 20180826 06:01:26<+wesdiscordbot> argh 20180826 06:06:08<+wesdiscordbot> maybe add a variation_type to [undead_variation]? then have plague's type field match to [undead_variation]'s variation_type field, so you could define multiple undead variations per unit type. 20180826 06:06:11<+wesdiscordbot> I dunno 20180826 06:06:39<+wesdiscordbot> I seems like at some point it'd be easier to just create a die event and manually replace units. 20180826 06:06:58<+wesdiscordbot> at least as far as UMC goes 20180826 06:07:09< celticminstrel> Heh... 20180826 06:31:48-!- celticminstrel is now known as celmin|sleep 20180826 06:49:45< Ravana_> EoMa has extended plague types with different unit type and more variations 20180826 06:51:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180826 08:36:35-!- irker246 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180826 09:08:52-!- irker330 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180826 09:08:52< irker330> wesnoth: josteph wesnoth:1.14 98109f3b66c2 / data/campaigns/Liberty/utils/bigmap.cfg utils/pofix.py: Add pofix entries for the recent typo fixes (#3377). https://github.com/wesnoth/wesnoth/commit/98109f3b66c28473084494caa7e1de0b4bea7875 20180826 09:08:52< irker330> wesnoth: josteph wesnoth:1.14 a8280e62d73d / utils/pofix.py: Add yet more pofix entries. https://github.com/wesnoth/wesnoth/commit/a8280e62d73d032a9c35e92fba672eb408f4ace6 20180826 09:10:39<+wesdiscordbot> @jyrkive You are required to run pofix as well. 20180826 09:10:44<+wesdiscordbot> On it. 20180826 09:10:56<+wesdiscordbot> It would be ideal if you did it in the same commit in the future. 20180826 09:11:17<+wesdiscordbot> That's difficult to do when merging someone else's pull request... 20180826 09:11:33<+wesdiscordbot> (Yes, it means you can't just cherry-pick the full commit across branches, but it makes it much easier to revert when people mess things up.) 20180826 09:11:42<+wesdiscordbot> Also you should've run pofix before merging. 20180826 09:11:50<+wesdiscordbot> Because of the whole "people mess things up" part. 20180826 09:12:11<+wesdiscordbot> Not possible. The branch is in jostephd's personal repository, and I don't have push access there. 20180826 09:12:17<+wesdiscordbot> There's some non-obvious magic involved in pofix substitutions because of po msgstr wrapping. 20180826 09:12:30<+wesdiscordbot> As well as the potential for duplicate matches. 20180826 09:12:45<+wesdiscordbot> Yes, it is possible. 20180826 09:13:14<+wesdiscordbot> You pull the branch into your downstream, do everything there, and only then push upstream after everything has been verified to work correctly. 20180826 09:18:36< irker330> wesnoth: Jyrki Vesterinen wesnoth:1.14 4bb6f6ec3da7 / po/wesnoth-tsg/ (58 files): Run pofix https://github.com/wesnoth/wesnoth/commit/4bb6f6ec3da7fafcb37e3d9fc0924f5827ce4e24 20180826 09:27:13< irker330> wesnoth: Jyrki Vesterinen wesnoth:master 217eba5f97f5 / / (60 files in 3 dirs): Add pofix entries for the recent typo fixes (resolves #3377) https://github.com/wesnoth/wesnoth/commit/217eba5f97f5593375c17daeb2ddb82c7da5f7b3 20180826 09:30:32<+wesdiscordbot> Am I reading that diff wrong or only one of the substitutions worked? 20180826 09:32:15<+wesdiscordbot> Looks like it's indeed the only one that had any effect. 20180826 09:33:13<+wesdiscordbot> Yeah, that's exactly the kind of thing I was alluding to. 20180826 09:34:30<+wesdiscordbot> I'll put it like this: pofix is a glorified plain text find & replace. 20180826 09:34:55<+wesdiscordbot> Do not expect it to understand the intrincacies of the translation catalogue format, because it does not. At all. It just sees plain text files. 20180826 09:35:25<+wesdiscordbot> Direct your words at jostephd, not me. 20180826 09:35:52<+wesdiscordbot> But you merged the PR. 20180826 09:36:50<+wesdiscordbot> That automatically makes you responsible for testing the PR prior to merging. 20180826 10:11:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180826 10:13:57<+wesdiscordbot> Question: what should be done about strings which aren't pofixable? 20180826 10:14:40<+wesdiscordbot> "Asheviere is the Queen of Wesnoth" is such a case. The string is split to two parts, the second part contains only "Queen for Wesnoth." 20180826 10:15:15<+wesdiscordbot> And unfortunately, "queen of Wesnoth." is used legitimately elsewhere, so pofix mass-replacing would affect that one as well. 20180826 10:17:05<+wesdiscordbot> They should just not be included in pofix. 20180826 10:17:30<+wesdiscordbot> OK. Removed. 20180826 10:29:39< irker330> wesnoth: Jyrki Vesterinen wesnoth:1.14 45c4c6b6a5f3 / / (175 files in 4 dirs): Pofix fixes https://github.com/wesnoth/wesnoth/commit/45c4c6b6a5f368873aa1bf2f810ab82444db16d4 20180826 10:38:18< irker330> wesnoth: Jyrki Vesterinen wesnoth:master 3df91c9fc126 / / (175 files in 4 dirs): Pofix fixes https://github.com/wesnoth/wesnoth/commit/3df91c9fc126ac3fd70ab9c0ea9e97eb3d008b33 20180826 10:43:44< irker330> wesnoth: Jyrki Vesterinen wesnoth:master 20bfb35bdda3 / / (59 files in 2 dirs): Fix another pofix mistake https://github.com/wesnoth/wesnoth/commit/20bfb35bdda3dca06a9e997812d50bea0e24f341 20180826 10:53:07-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer] 20180826 10:55:01-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20180826 13:44:12-!- irker330 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180826 14:01:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180826 15:07:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 15:07:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 15:22:17-!- irker724 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180826 15:22:17< irker724> wesnoth/wesnoth:1.14 Jyrki Vesterinen 4bb6f6ec3d Run pofix AppVeyor: All builds passed 20180826 15:55:01-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [] 20180826 16:00:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180826 16:04:11-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20180826 16:20:16-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [] 20180826 16:25:30-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20180826 16:49:40< celmin|sleep> Question @Vultraz - would you deem it acceptable to disallow referencing tags via a derived tag in the schema? That is... suppose you have a tag "some/path/to/super/with_subtag" and you have another tag "another/path/to/derived" that derives from "some/path/to/super", is it acceptable to reject the path "another/path/to/derived/with_subtag", or should that definitely be a valid path due to the inheritance? 20180826 16:52:33<+wesdiscordbot> I don’t know how the schema works 20180826 16:55:09< celmin|sleep> It uses paths to reference tags (which also defines where they're allowed to appear). 20180826 17:07:59< celmin|sleep> ... 20180826 17:08:04< celmin|sleep> I forgot to change my nick. 20180826 17:08:56<+wesdiscordbot> → why I've never used status nicks 20180826 17:10:11< celmin|sleep> Heh. 20180826 17:23:30< irker724> wesnoth/wesnoth:1.14 Jyrki Vesterinen 45c4c6b6a5 Pofix fixes AppVeyor: All builds passed 20180826 18:34:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 18:34:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 18:39:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 18:39:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 19:03:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180826 19:12:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180826 19:13:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180826 19:14:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180826 19:32:49< irker724> wesnoth/wesnoth:master Jyrki Vesterinen 20bfb35bdd Fix another pofix mistake AppVeyor: All builds passed 20180826 19:43:02< irker724> wesnoth/wesnoth:master newfrenchy83 cbe129c5f1 Update heal.cpp AppVeyor: vs2015/Release Failed 20180826 19:43:04< irker724> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-4646 20180826 20:33:38-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180826 21:05:48< irker724> wesnoth/wesnoth:1.14 josteph a98d43e3bc Use an intermediate variable to shorten AppVeyor: All builds passed 20180826 21:14:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180826 21:34:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180826 21:57:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds] 20180826 22:14:09-!- sevu [~sevu@p54855A75.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180826 22:22:58-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 252 seconds] 20180826 22:27:29-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20180826 22:30:41-!- sevu [~sevu@p54855A75.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180826 22:36:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180826 23:48:11-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] --- Log closed Mon Aug 27 00:00:26 2018