--- Log opened Sun Sep 02 00:00:08 2018
20180902 00:16:20<+wesdiscordbot> <Vultraz> @shadowm you can’t hide a column,
20180902 00:16:22-!- gfgtdf [~chatzilla@x4dbbdfc2.dyn.telefonica.de] has joined #wesnoth-dev
20180902 00:22:50<+wesdiscordbot> <loonycyborg> @shadowm does w.initial_open() do anything qt related?
20180902 00:22:58<+wesdiscordbot> <loonycyborg> like opening windows itself
20180902 00:22:58<+wesdiscordbot> <shadowm> Yes
20180902 00:24:11<+wesdiscordbot> <shadowm> https://github.com/shikadiqueen/morningstar/blob/master/src/mainwindow.cpp#L522
20180902 00:29:33<+wesdiscordbot> <loonycyborg> seems it's opening file dialog, not sure if it might be causing this
20180902 00:29:48<+wesdiscordbot> <loonycyborg> since it's in git I can build it and try myself
20180902 00:29:51<+wesdiscordbot> <loonycyborg> but later
20180902 00:29:56<+wesdiscordbot> <loonycyborg> off to sleep now
20180902 00:30:20<+wesdiscordbot> <Vultraz> @shadowm for filtering, though, you can just check data members on the underlying list, and for sorting, you can use std::tie to do lexigographical tuple comparison on multiple values
20180902 00:30:46<+wesdiscordbot> <Vultraz> without adding a new colum
20180902 00:32:01<+wesdiscordbot> <shadowm> Uh
20180902 00:32:11<+wesdiscordbot> <shadowm> std::tie and what else?
20180902 00:33:42<+wesdiscordbot> <Vultraz> actually, sorry, make_tuple. Same difference. There still needs to me some sort of associative list somewhere, though.
20180902 00:33:55<+wesdiscordbot> <shadowm> I'm still lost.
20180902 00:34:10<+wesdiscordbot> <Vultraz> cpp     list.register_sorting_option(2, [this](const int i) {         const unit& u = *recall_list_[i];         return std::make_tuple(u.level(), -static_cast<int>(u.experience_to_advance()));     }); is an example of multi-value sorting.
20180902 00:34:45<+wesdiscordbot> <shadowm> Oh.
20180902 00:34:53<+wesdiscordbot> <shadowm> That sorts by level first and then by XP?
20180902 00:35:06<+wesdiscordbot> <Vultraz> yes.
20180902 00:35:20<+wesdiscordbot> <shadowm> Well, that's good to know but it's not relevant for my problem.
20180902 00:35:47<+wesdiscordbot> <shadowm> The list is supposed to be sorted by visible names and it doesn't make sense to sort by additional criteria.
20180902 00:36:01<+wesdiscordbot> <shadowm> (Unless there's something I'm missing.)
20180902 00:36:16<+wesdiscordbot> <Vultraz> well if it's just for filtering purposes then you'll just need to keep a list somewhere.
20180902 00:45:07< irker716> wesnoth/wesnoth:master josteph bcb6153b89 Liberty S8: Fix family reference AppVeyor: All builds passed
20180902 00:59:48-!- gfgtdf [~chatzilla@x4dbbdfc2.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20180902 03:46:38-!- irker716 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20180902 04:14:37<+wesdiscordbot> <Pentarctagon> Is anything going to happen with the proposed music contribution from Pluft?  If not, it'd be good for someone to tell him that.
20180902 04:14:50< celticminstrel> Yeah I dunno.
20180902 04:15:38<+wesdiscordbot> <Vultraz> I assumed someone was gonna leave feedback
20180902 04:17:16< celticminstrel> People already did...
20180902 04:17:57<+wesdiscordbot> <Vultraz> ok, good
20180902 04:18:36< celticminstrel> I mean, I was one of them?
20180902 04:26:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 04:26:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 04:30:37<+wesdiscordbot> <Vultraz> i didn't check
20180902 04:31:02<+wesdiscordbot> <shadowm> Uh
20180902 04:33:22<+wesdiscordbot> <Vultraz> I haven't really visited the forums at all for weeks
20180902 04:33:32<+wesdiscordbot> <Vultraz> except to check my threads.
20180902 04:38:59-!- irker878 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20180902 04:38:59< irker878> wesnoth/wesnoth:master Iris Morelle b7c7fca8b1 gui2/unit_create: Allow searching by rac AppVeyor: All builds passed
20180902 04:52:14<+wesdiscordbot> <Vultraz> it is pepe, celmin.
20180902 04:52:24< celticminstrel> @Vultraz this isn't really the place to talk about that.
20180902 04:52:53<+wesdiscordbot> <Vultraz> I know, but you aren't in any of the other channels. So I'm only saying it is so.
20180902 04:53:10< celticminstrel> You could've just sent me a PM or something, it would've been better.
20180902 04:53:14< celticminstrel> (I mean a forum PM.)
20180902 04:53:28< celticminstrel> And then poked me to check it without explaining the reason.
20180902 04:53:53<+wesdiscordbot> <Vultraz> Hm, yes, I could do that. It's rather inconvenient, tho.
20180902 04:55:50<+wesdiscordbot> <Vultraz> Nor is it a good long-term solution if something more sensitive need be discussed with you.
20180902 04:56:04< celticminstrel> Uh. It's a totally good long-term solution.
20180902 06:38:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180902 06:53:06< irker878> wesnoth/wesnoth:1.14 Iris Morelle b4e7b5b9af gui2/unit_create: Allow searching by rac AppVeyor: All builds passed
20180902 07:56:01<+wesdiscordbot> <loonycyborg> @shadowm seems I guessed right. Replacing that QFileDialog with a hardcoded string made it exit on window close.
20180902 08:09:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 08:09:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 08:30:16<+wesdiscordbot> <loonycyborg> I think better trigger that initialization along with file dialog from a callback from event loop
20180902 08:30:38<+wesdiscordbot> <loonycyborg> you can accomplish this with QTimer::singleShot(0,...)
20180902 08:31:00<+wesdiscordbot> <loonycyborg> this will trigger an event immediately at start of event loop
20180902 09:00:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180902 09:53:41-!- irker878 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20180902 09:59:35-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20180902 10:08:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 10:08:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 10:10:54-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 272 seconds]
20180902 12:00:41-!- irker070 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20180902 12:00:41< irker070> wesnoth: DisherProject wesnoth:master e07819619c73 / data/campaigns/Eastern_Invasion/ (scenarios/02_The_Escape_Tunnel.cfg utils/animations.cfg): EI: Remove old TODO and add a new one https://github.com/wesnoth/wesnoth/commit/e07819619c73e63dd5986dedb0cda4d971a09ad6
20180902 12:00:41< irker070> wesnoth: DisherProject wesnoth:master 643f1336dd92 / data/campaigns/Eastern_Invasion/scenarios/08_Training_the_Ogres.cfg: EI S8: Fix event not being fired https://github.com/wesnoth/wesnoth/commit/643f1336dd92982850b4f61b9af6ce2d6a8c5d77
20180902 12:00:41< irker070> wesnoth: DisherProject wesnoth:master 50e4cc5d3fdd / data/campaigns/Eastern_Invasion/scenarios/ (12_Evacuation.cfg 16_Weldyn_under_Attack.cfg): EI S12-S16: Split objectives into main and alternative ones https://github.com/wesnoth/wesnoth/commit/50e4cc5d3fddc7f7d47c9437b3133567aa0e3dde
20180902 12:00:42< irker070> wesnoth: DisherProject wesnoth:master 64917b70b5eb / data/campaigns/Eastern_Invasion/scenarios/13_The_Drowned_Plains.cfg: EI S13: Rewrite dragon's AI https://github.com/wesnoth/wesnoth/commit/64917b70b5eb484ed132df2b43ca26b3af47a690
20180902 12:04:51< irker070> wesnoth: DisherProject wesnoth:master 34f417c4eb48 / data/campaigns/An_Orcish_Incursion/scenarios/03_Wasteland.cfg: AOI S3: Clear all enemies on victory https://github.com/wesnoth/wesnoth/commit/34f417c4eb488966a779bcfa9a0e32f933d3960e
20180902 12:04:53< irker070> wesnoth: DisherProject wesnoth:master 240d2350592a / data/campaigns/An_Orcish_Incursion/scenarios/02_Assassins.cfg: AOI S2: Prefer "id" to "speaker" in non-[message]'s SUFs https://github.com/wesnoth/wesnoth/commit/240d2350592a4bd1ea69e5ccea97c39d827f34f7
20180902 12:04:55< irker070> wesnoth: DisherProject wesnoth:master 9086e17b1565 / data/campaigns/An_Orcish_Incursion/scenarios/ (7 files): AOI: General AI rewrite https://github.com/wesnoth/wesnoth/commit/9086e17b1565e8866b2d42eb53fd101cece506e1
20180902 12:35:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 12:35:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 12:59:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 12:59:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 14:44:41-!- wesdiscordbot1 [~wesdiscor@wesnoth/bot/discord-bridge] has joined #wesnoth-dev
20180902 14:44:44-!- mode/#wesnoth-dev [+v wesdiscordbot1] by ChanServ
20180902 14:45:57-!- shadowm [~iris@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20180902 14:46:38-!- shadowm [~iris@wesnoth/developer/shadowm] has joined #wesnoth-dev
20180902 14:48:27-!- wesdiscordbot [~wesdiscor@wesnoth/bot/discord-bridge] has quit [Ping timeout: 240 seconds]
20180902 14:48:34-!- wesdiscordbot1 is now known as wesdiscordbot
20180902 15:05:10-!- irker070 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20180902 16:48:33-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20180902 18:06:19-!- irker099 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20180902 18:06:19< irker099> wesnoth/wesnoth:master DisherProject 9086e17b15 AOI: General AI rewrite AppVeyor: All builds passed
20180902 18:23:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 18:23:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 18:25:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180902 18:30:03-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 245 seconds]
20180902 18:51:52-!- Punsaker is now known as Polsaker
20180902 19:09:30< irker099> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 6b5edeb9a85c / projectfiles/Xcode/Fix_Xcode_Dependencies: Fix bug in Fix_Xcode_Dependencies https://github.com/wesnoth/wesnoth/commit/6b5edeb9a85cb72b7aebc1f6a8f3d1c9366a92b5
20180902 19:09:50< irker099> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 2406b758a237 / projectfiles/Xcode/Fix_Xcode_Dependencies: Fix bug in Fix_Xcode_Dependencies https://github.com/wesnoth/wesnoth/commit/2406b758a237589f86609ec04f3556dd9fc98c91
20180902 19:17:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20180902 20:14:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20180902 20:45:53<+wesdiscordbot> <shadowm> @loonycyborg I don't get it. This is not normally necessary?
20180902 20:46:08<+wesdiscordbot> <loonycyborg> Normally?
20180902 20:46:38<+wesdiscordbot> <loonycyborg> I don't think that showing dialogs before main window is very widespread need
20180902 20:47:09<+wesdiscordbot> <shadowm> How does that affect anything at all?
20180902 20:47:10<+wesdiscordbot> <loonycyborg> and there could be changes in how they work under the hood between qt4 and qt5
20180902 20:47:30<+wesdiscordbot> <shadowm> The QFileDialog ceases to exist once do_open() return.
20180902 20:47:48<+wesdiscordbot> <loonycyborg> it might end up having some side effect
20180902 20:48:01<+wesdiscordbot> <shadowm> Is the problem that it's owned by the window?
20180902 20:48:09<+wesdiscordbot> <shadowm> Before the window is even shown?
20180902 20:48:50<+wesdiscordbot> <loonycyborg> I'm not sure, the only thing I know is that if I replace that QFileDialog() call with hardcoded string it exits on window close
20180902 20:49:16<+wesdiscordbot> <shadowm> Yeah but I'm not a fan of voodoo fixes.
20180902 20:50:12<+wesdiscordbot> <shadowm> The dialog's ownership is not the issue it turns out.
20180902 20:50:28<+wesdiscordbot> <loonycyborg> Dialog must run own event loop to exist
20180902 20:50:50<+wesdiscordbot> <loonycyborg> hmm actually
20180902 20:50:54<+wesdiscordbot> <shadowm> The dialog exists.
20180902 20:50:57<+wesdiscordbot> <loonycyborg> I think it can be done in different way
20180902 20:51:02<+wesdiscordbot> <shadowm> (You probably mean the window.)
20180902 20:51:25<+wesdiscordbot> <loonycyborg> instead of using that helper function, create that dialog manually
20180902 20:51:41<+wesdiscordbot> <loonycyborg> then catch signal it sends on completing
20180902 20:51:47<+wesdiscordbot> <loonycyborg> and continue from there
20180902 20:51:51<+wesdiscordbot> <shadowm> The dialog completes.
20180902 20:51:59<+wesdiscordbot> <shadowm> Otherwise the main window would never be shown.
20180902 20:52:11<+wesdiscordbot> <shadowm> Or rather do_open() would never return.
20180902 20:53:25<+wesdiscordbot> <loonycyborg> But you show this dialog before even starting main event loop
20180902 20:53:35<+wesdiscordbot> <shadowm> And what's the issue with that?
20180902 20:53:40<+wesdiscordbot> <loonycyborg> I think this is what can be considered unusual
20180902 20:53:52<+wesdiscordbot> <loonycyborg> because it's still a gui object
20180902 20:54:08<+wesdiscordbot> <loonycyborg> if it works then it means it runs own event loop
20180902 20:54:26<+wesdiscordbot> <loonycyborg> depending on what happens in qt's internals it could lead to confusion
20180902 20:54:59<+wesdiscordbot> <shadowm> "Generally, no user interaction can take place before calling exec(). As a special case, modal widgets like QMessageBox can be used before calling exec(), because modal widgets call exec() to start a local event loop."
20180902 20:55:14<+wesdiscordbot> <loonycyborg> so basically the greatest mystery to me here
20180902 20:55:23<+wesdiscordbot> <loonycyborg> is why that dialog appears in the first place 😛
20180902 20:55:53<+wesdiscordbot> <shadowm> Don't you mean to ask instead why the main window requires the dialog to appear first instead?
20180902 20:56:07<+wesdiscordbot> <shadowm> Or rather the main window's callee.
20180902 20:56:11<+wesdiscordbot> <shadowm> caller
20180902 20:56:16<+wesdiscordbot> <shadowm> The main window is the callee.
20180902 20:56:31<+wesdiscordbot> <shadowm> That quote is from the documentation by the way.
20180902 20:56:52<+wesdiscordbot> <shadowm> QFileDialog is not a subclass of QMesageBox but it doesn't specify what else is covered by that clause.
20180902 20:57:16<+wesdiscordbot> <loonycyborg> well this functionality could just bug out
20180902 20:58:41<+wesdiscordbot> <shadowm> Argh I guess I'll have to do more research on this before deciding what the best course of action is. Thanks for pointing me in the right direction
20180902 20:58:59<+wesdiscordbot> <loonycyborg> actually I kinda understand that you want to show a file dialog before showing main window
20180902 20:59:08<+wesdiscordbot> <loonycyborg> but that's not mandatory
20180902 20:59:20<+wesdiscordbot> <loonycyborg> you can show main window first and then the file dialog
20180902 20:59:37<+wesdiscordbot> <loonycyborg> it would be less tiny probably
20180902 20:59:45<+wesdiscordbot> <loonycyborg> but still not too bad
20180902 21:00:09<+wesdiscordbot> <loonycyborg> even if you got nothing to show in main window yet, it is blocked by modal dialog anyway
20180902 21:07:00-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20180902 21:18:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180902 21:52:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180902 21:52:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180902 22:09:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180902 22:10:15-!- irker099 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20180902 23:20:22-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 246 seconds]
20180902 23:30:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180902 23:51:20-!- higgins` [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20180902 23:54:19-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Ping timeout: 260 seconds]
--- Log closed Mon Sep 03 00:00:10 2018