--- Log opened Fri Sep 07 00:00:17 2018 20180907 00:45:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180907 00:45:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180907 00:49:07-!- gfgtdf [~Daniel@x4dbb4de7.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20180907 01:01:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180907 01:15:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180907 02:07:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180907 02:13:38< irker396> wesnoth/wesnoth:master Jyrki Vesterinen e63bd35f9d [animate_unit]: clear the animation afte AppVeyor: All builds passed 20180907 03:30:32< mattsc> @gfgtdf: I’ve done some first tests and so far your suggestion has been pretty much spot on. 20180907 03:32:21< mattsc> Just using an empty location filter (meaning one that machtes all hexes) with a map with 1014 hexes total and 888 non-border hexes (Freelands), the second method from your github comment takes twice as long as the first. 20180907 03:33:02< mattsc> By comparison, the Lua loop from what I have in my commit takes ~15% longer than the first. 20180907 03:33:43< mattsc> “machtes” … :P That is actually a work, but not in English. 20180907 03:34:34< mattsc> s/work/word — blargh; there are apparently problems with typing while listening to Finnish heavy metal … 20180907 03:45:18< mattsc> I’ll do some more tests with both fast and slow filters and see what happens. 20180907 03:53:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20180907 04:30:14< irker396> wesnoth/wesnoth:master Łukasz Hryniuk cfd05557e2 gui2: indicate that unit cannot advance AppVeyor: All builds passed 20180907 05:48:50-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180907 07:22:24< irker396> wesnoth/wesnoth:1.14 Pentarctagon 44e7b12af6 Fixes #3518 AppVeyor: All builds passed 20180907 08:05:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180907 08:17:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180907 09:22:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20180907 11:30:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180907 12:47:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180907 12:47:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180907 12:51:40-!- irker396 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180907 12:54:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180907 14:57:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180907 14:57:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180907 15:52:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180907 15:52:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180907 16:29:48-!- irker049 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180907 16:29:48< irker049> wesnoth/wesnoth:1.14 josteph 8bdb6e17dc Commandline: --campaign-skip-story skips AppVeyor: vs2015/Release Failed 20180907 16:29:48< irker049> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4731 20180907 16:35:41< irker049> wesnoth: newfrenchy83 wesnoth:master 354162919741 / data/lua/wml/heal_unit.lua: [heal_unit]: clear the animation after playing it (#3526) https://github.com/wesnoth/wesnoth/commit/354162919741f1b5360120286bf389ecd963be79 20180907 16:38:50< irker049> wesnoth: newfrenchy83 wesnoth:1.14 698066d2d1b5 / data/lua/wml/heal_unit.lua: [heal_unit]: clear the animation after playing it (#3526) https://github.com/wesnoth/wesnoth/commit/698066d2d1b596abb45f2e8f448a0624e5d301c7 20180907 16:41:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180907 16:55:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180907 17:11:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180907 17:40:19< irker049> wesnoth: Pentarctagon wesnoth:master 09fcc6b0519d / CMakeLists.txt SConstruct: Fixes #3518 https://github.com/wesnoth/wesnoth/commit/09fcc6b0519d458cbc3e16788576000a8484020b 20180907 18:00:04-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo.ga] 20180907 18:00:15-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180907 18:22:30-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180907 18:32:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180907 18:32:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180907 19:00:12-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180907 19:06:58< irker049> wesnoth/wesnoth:master newfrenchy83 44916647aa Update heal_unit.lua AppVeyor: All builds passed 20180907 20:27:52-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180907 20:38:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20180907 21:16:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180907 21:29:42< irker049> wesnoth/wesnoth:1.14 josteph 8bdb6e17dc Commandline: --campaign-skip-story skips AppVeyor: 1/4 builds failed 20180907 21:29:43< irker049> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-4731 20180907 21:33:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180907 21:34:39<+wesdiscordbot> @hrubymar10 Hi — I just compiled master for the first time in a couple weeks on a Macbook with retina display. I now get the display at full resolution, but the mouse moving at half (normal) resolution. 20180907 21:34:41<+wesdiscordbot> Is this something I need to change in the Wesnoth or OS settings? 20180907 21:34:46<+wesdiscordbot> (And I am sorry if I should know and missed it.) 20180907 21:35:31<+wesdiscordbot> latest origin/master? 20180907 21:35:43<+wesdiscordbot> Yes, pulled and compiled ~20 min ago 20180907 21:36:45<+wesdiscordbot> I didn't try master for while (trying now) but there are problems with macOS 10.14 . Do you have macOS 10.14 ? 20180907 21:37:06<+wesdiscordbot> I do, but I haven't compiled it recently. I can try. 20180907 21:38:06<+wesdiscordbot> Oh, sorry... completely misread! 20180907 21:38:08<+wesdiscordbot> Regarding to 10.14 https://github.com/wesnoth/wesnoth/issues/3455 20180907 21:38:31<+wesdiscordbot> I saw the 14 and thought you meant Wesnoth 1.14 (blush) 20180907 21:38:40<+wesdiscordbot> 😄 20180907 21:38:52<+wesdiscordbot> Nope, I am using 1.13.6 (macos) 20180907 21:39:03<+wesdiscordbot> So you are using stable macOS 10.13.6 with stable xcode with macOS 10.13 SDK ? 20180907 21:39:38<+wesdiscordbot> Yes on the OsS, and I presume that's the SDK I am using. 20180907 21:39:46<+wesdiscordbot> Let me try to remember how to check that ... 20180907 21:40:34<+wesdiscordbot> Can you try comment this line and recompile it again? https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L137 20180907 21:41:06<+wesdiscordbot> Will do. 20180907 21:41:15<+wesdiscordbot> Also, are you using newest MacCompileStuff? (Over FixXcodeDependencies) 20180907 21:41:32<+wesdiscordbot> Hmm, probably not. How new is it? 20180907 21:43:01<+wesdiscordbot> I updated some libs in MacCompileStuff recently. Try run wesnoth/projectfiles/Xcode/FixXcodeDependencies and it will handle it itself 20180907 21:43:24<+wesdiscordbot> Okay, should I do that first or changing that line in video.cpp? 20180907 21:43:57<+wesdiscordbot> I had some problems with the Dependencies script before, but I think that's because I did something wrong. Let me try. 20180907 21:44:53<+wesdiscordbot> You can do both. I don't think that newest dependencies will fix your problem. Line in video.cpp probably will 20180907 21:45:07< mattsc> Well, let me do it one at a time. 20180907 21:45:35<+wesdiscordbot> ./projectfiles/Xcode/Fix_Xcode_Dependencies Already up to date. ==> DONE ... ==> Operation took 1 seconds ... 20180907 21:45:54<+wesdiscordbot> Good, you were up to date 😄 20180907 21:47:51< mattsc> Currently compiling. Unsurprisingly, it looks like it needs to re-compile almost everything. 20180907 21:48:14<+wesdiscordbot> I am compiling it now too 20180907 21:49:01<+wesdiscordbot> But we have different OS. I am using macOS 10.14 on which master didn't work at all before :/ 20180907 21:49:45<+wesdiscordbot> Well, it at lots of problems for me too, but it ran well enough that I could test the Lua AI changes I've been working on. 20180907 21:50:26<+wesdiscordbot> That was after compiling 2 or 3 weeks ago. 20180907 21:53:48<+wesdiscordbot> @hrubymar10 Huh, that gave me a compile error. 20180907 21:54:27<+wesdiscordbot> undefined symbol get_mem_block() 20180907 21:54:35<+wesdiscordbot> Do you want the full message? 20180907 21:54:51<+wesdiscordbot> yes please 20180907 21:55:13<+wesdiscordbot> and you meant linker error, right? 20180907 21:55:40<+wesdiscordbot> Yes, linker error 20180907 21:56:33<+wesdiscordbot> https://pastebin.com/sCZZaQaw 20180907 21:56:47<+wesdiscordbot> That's the first. There are 7 more like it. 20180907 21:59:36<+wesdiscordbot> weird 20180907 21:59:45<+wesdiscordbot> It passed before 20180907 22:00:09<+wesdiscordbot> Do you want me to undo the video.cpp change and make sure that that was really the reason? 20180907 22:00:40<+wesdiscordbot> It shouldn't be cased by that but let's try also comment #ifdef blocks: https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L136-L138 20180907 22:00:50<+wesdiscordbot> I don't think I did anything else in between, since the dependencies script seems to have done nothing. 20180907 22:01:15<+wesdiscordbot> okay 20180907 22:01:49<+wesdiscordbot> Nope, that did not change anything. 20180907 22:02:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180907 22:03:48<+wesdiscordbot> I just compiled it myself without any problems. Maybe there is problem with old objects or something. I would try clean working directory and try whole process again. (checkout Xcode folder, run FixXcodeDependencies and compile it again). 20180907 22:04:24<+wesdiscordbot> Hmm, ok. 20180907 22:04:58-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds] 20180907 22:06:18<+wesdiscordbot> BTW, in my case (without flag (commented)): 20180907 22:06:18<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/487745451219615745/unknown.png 20180907 22:06:35<+wesdiscordbot> (I see only 1/4 of screen) 20180907 22:08:01<+wesdiscordbot> Okay. 20180907 22:08:10<+wesdiscordbot> And with flag 20180907 22:08:10<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/487745920927006732/unknown.png 20180907 22:08:42<+wesdiscordbot> I can't click anything and whole screen is so small 20180907 22:08:53<+wesdiscordbot> Well, I removed the Xcode/ (moved, actually), am running the script at the moment. This time it is doing something. 20180907 22:09:02<+wesdiscordbot> Then I'll clean the build, and compile. 20180907 22:09:24<+wesdiscordbot> ==> Operation took 1 minutes and 21 seconds ... 20180907 22:11:13<+wesdiscordbot> I think that you accidentally changed anything else because when I comment or uncomment window_flags |= SDL_WINDOW_ALLOW_HIGHDPI; line in video.cpp, it took about 30seconds to recompile 20180907 22:11:29<+wesdiscordbot> Probably you accidentally removed library from xcode project (because you can compile it, but you can't link it) 20180907 22:12:08<+wesdiscordbot> I'm not sure how that would have happened, but maybe. The only thing I did in between other than changing that line was to run the dependencies script. 20180907 22:12:21<+wesdiscordbot> Anyway, I just cleaned and am re-running it. 20180907 22:12:36<+wesdiscordbot> So this one is definitely a full build. 20180907 22:21:28<+wesdiscordbot> Now what ?! 20180907 22:21:32<+wesdiscordbot> Undefined symbols for architecture x86_64: "desktop::apple::os_version()", referenced from: desktop::os_version() in version.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) 20180907 22:21:43-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 245 seconds] 20180907 22:21:54<+wesdiscordbot> Output of git status ? 20180907 22:22:14<+wesdiscordbot> No, output of Xcode as a linker error, at the end of a clean build. 20180907 22:22:55<+wesdiscordbot> I know. Please, open terminal, navigate to wesnoth directory and run git status 20180907 22:23:20<+wesdiscordbot> Oh, that's what you mean. 20180907 22:23:20-!- louis94 [~~louis94@109.49-136-217.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180907 22:23:50<+wesdiscordbot> On branch master Your branch is up to date with 'origin/master'. nothing to commit, working tree clean 20180907 22:24:17<+wesdiscordbot> Note that 'origin' is not the wesnoth repo, that's 'upstream', but the two are synced, I made sure of that. 20180907 22:25:11<+wesdiscordbot> and output of git remote -v? 20180907 22:25:42<+wesdiscordbot> origin https://github.com/mattsc/wesnoth (fetch) origin https://github.com/mattsc/wesnoth (push) upstream git@github.com:wesnoth/wesnoth.git (fetch) upstream git@github.com:wesnoth/wesnoth.git (push) wesnoth https://github.com/wesnoth/wesnoth.git (fetch) wesnoth https://github.com/wesnoth/wesnoth.git (push) 20180907 22:26:48<+wesdiscordbot> Also, just in case: 20180907 22:26:52<+wesdiscordbot> > git pull upstream master From github.com:wesnoth/wesnoth * branch master -> FETCH_HEAD Already up to date. 20180907 22:27:51<+wesdiscordbot> I verified that your for is synced with master 20180907 22:28:07<+wesdiscordbot> Thanks. 😃 20180907 22:28:17-!- specing [~specing@unaffiliated/specing] has left #wesnoth-dev ["WeeChat 1.4"] 20180907 22:28:43<+wesdiscordbot> do you have Xcode project opened? 20180907 22:28:48<+wesdiscordbot> yes 20180907 22:29:05<+wesdiscordbot> Actually, let me just tell you quickly what I did. 20180907 22:29:22<+wesdiscordbot> I moved the Xcode/ folder from projectfiles/ to my Desktop 20180907 22:29:51<+wesdiscordbot> then I ran git checkout projectfiles/Xcode/ and ./projectfiles/Xcode/Fix_Xcode_Dependencies 20180907 22:30:01<+wesdiscordbot> depending on your bandwidth, you could try doing a shallow clone of wesnoth's master and see if the problem persists from building it there. 20180907 22:30:01<+wesdiscordbot> Then I cleaned the build and compiled. 20180907 22:30:41<+wesdiscordbot> In Xcode project, find this file: src/desktop/apple_version.mm 20180907 22:31:24<+wesdiscordbot> oh 😄 It is not in this path in Xcode 20180907 22:31:31<+wesdiscordbot> Okay, good. 20180907 22:31:37<+wesdiscordbot> Because there's no such file. 😃 20180907 22:31:38<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/487751826330877962/unknown.png 20180907 22:31:47<+wesdiscordbot> In Mac-specific 20180907 22:32:15<+wesdiscordbot> Yep, found the file. 20180907 22:32:33<+wesdiscordbot> and on the right side, you should have Wesnoth target checked 20180907 22:32:33<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/487752059140177920/unknown.png 20180907 22:32:38<+wesdiscordbot> In sidebar 20180907 22:32:55<+wesdiscordbot> Yes, looks just like that. 20180907 22:33:23<+wesdiscordbot> But the .hpp file does not. 20180907 22:33:34<+wesdiscordbot> As in, that one is not checked for Wesnoth 20180907 22:33:34<+wesdiscordbot> tell me then, why it doesn't work? If it is checked, then you have all necesarry objects O.o 20180907 22:34:03<+wesdiscordbot> .hpp is header file. It even can't be checked 😃 20180907 22:34:12<+wesdiscordbot> I would tell you if I knew 😉 20180907 22:35:01<+wesdiscordbot> Maybe... But it worked before for you O.o 20180907 22:35:59<+wesdiscordbot> Oh ... (where is the embarrased symbol) 20180907 22:36:08<+wesdiscordbot> This error is for unit_tests ... 20180907 22:36:28<+wesdiscordbot> 😳 😨 20180907 22:36:34<+wesdiscordbot> Indeed. 20180907 22:37:27<+wesdiscordbot> that's the problem 😄 I don't have much time now so unit_tests target is currently broken on mac 😄 20180907 22:37:41<+wesdiscordbot> please switch to Wesnoth target 😄 20180907 22:37:48<+wesdiscordbot> I'm sorry for wasting your time ... 😛 20180907 22:37:58<+wesdiscordbot> yes, compiling already 20180907 22:38:15<+wesdiscordbot> My only thought is: what the ... ?! 20180907 22:38:44<+wesdiscordbot> np 😄 At least I will have feedback from macOS 10.13 20180907 22:39:18<+wesdiscordbot> Yep. 20180907 22:39:26<+wesdiscordbot> Btw, I did see now that I am using the 1.13 SDK. 20180907 22:39:44<+wesdiscordbot> Which I figured I did, but it's good to have the confirmation. 20180907 22:40:17<+wesdiscordbot> Yep 😃 20180907 22:44:06<+wesdiscordbot> Well, now I am back to the mem_block error ... 20180907 22:45:41<+wesdiscordbot> @hrubymar10 ^ I'll have to move on to other things now though. I'll get back to this later. 20180907 22:45:47<+wesdiscordbot> Thanks for the help so far. 20180907 22:45:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180907 22:46:30<+wesdiscordbot> By the way, this is without modifying the video.cpp line. 20180907 22:46:43<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/487755625024061451/unknown.png 20180907 22:47:17<+wesdiscordbot> Verify if you have libboost_regex in linked libraries 20180907 22:47:33<+wesdiscordbot> and if it is NOT marked red (as missing) 20180907 22:48:41<+wesdiscordbot> Yes, it is there and not red. 20180907 22:49:54<+wesdiscordbot> Btw, this error started after I ran the fix_dependencies script the first time. 20180907 22:50:15<+wesdiscordbot> Which, I think, is the only thing I did between my last successful and unsuccessful compiling. 20180907 22:50:31<+wesdiscordbot> Anyway, I really need to be off. Thanks. 20180907 22:57:04<+wesdiscordbot> It is weird. Travis works with same environment and same dependencies as you have: https://travis-ci.org/wesnoth/wesnoth/jobs/425846870#L6004 It works for me and I just verified that symbols exists in libboost_regex. Leave me DM (direct message) once you will be there. 20180907 23:00:15< irker049> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 1af805ecf74b / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix unit tests in Xcode https://github.com/wesnoth/wesnoth/commit/1af805ecf74b1da30c916acac00b924f1016de79 20180907 23:37:07<+wesdiscordbot> @hrubymar10 Still around? 20180907 23:37:51<+wesdiscordbot> So ... Here's what I did. I removed the projectfiles/Xcode directory, and restored it from a backup from this morning. 20180907 23:38:27<+wesdiscordbot> Then I compiled. Compile succeeded and I had the same high-resolution problem. 20180907 23:38:59<+wesdiscordbot> Then I removed the line you pointed to from video.cpp. Compile succeeded (and yes, took about 30 s), and everything looks normal. 20180907 23:39:27<+wesdiscordbot> So, in summary, that flag in video.cpp causes the resolution problem. 20180907 23:39:58<+wesdiscordbot> And the dependencies script messed up something so that I get the compile error. 20180907 23:40:14<+wesdiscordbot> I'll figure out what the latter problem is sometime this weekend. For now I am back in business. 20180907 23:42:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180907 23:44:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180907 23:50:52< irker049> wesnoth/wesnoth:1.14 newfrenchy83 698066d2d1 [heal_unit]: clear the animation after p AppVeyor: All builds passed 20180907 23:58:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Sat Sep 08 00:00:18 2018