--- Log opened Mon Sep 10 00:00:21 2018 20180910 00:04:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180910 00:41:31< celticminstrel> ... 20180910 00:41:36< celticminstrel> WHY 20180910 00:44:34<+wesdiscordbot> i presume you're referring to 3541 20180910 00:45:22< celticminstrel> Yes. 20180910 00:45:37<+wesdiscordbot> ¯_(ツ)_/¯ 20180910 00:45:39<+wesdiscordbot> who knows 20180910 00:45:45<+wesdiscordbot> probably a temp string created somewhere 20180910 00:45:58<+wesdiscordbot> and we're doing comparison on a destroyed object 20180910 00:46:23< celticminstrel> Probably something along those lines. 20180910 00:46:38< celticminstrel> Workaround: add unbalanced overloads. 20180910 00:46:48< celticminstrel> operator==(string,t_string) and operator==(t_string,string). 20180910 00:47:29< celticminstrel> Assuming the cause is what you think. Should probably verify that before attempting any fix. 20180910 00:47:31<+wesdiscordbot> why is there a const char* operator 20180910 00:47:40< celticminstrel> Probably to compare with string literals? 20180910 00:47:56<+wesdiscordbot> cpp bool operator==(const t_string_base &) const; bool operator==(const std::string &) const; bool operator==(const char* string) const; 20180910 00:48:12< celticminstrel> That's probably a bit dangerous though, huh... 20180910 00:48:24< celticminstrel> Still, it couldn't trigger if comparing to a std::string. 20180910 00:48:24<+wesdiscordbot> I can't do any debugging 20180910 00:48:43<+wesdiscordbot> I thought our lua avoided string creation 20180910 00:50:07< celticminstrel> ? 20180910 00:50:38< celticminstrel> OIC, the issue is in Lua, not C++ 20180910 00:51:05< celticminstrel> I forget, does t_string still have an operator I recall suggesting it be removed. 20180910 00:51:18< celticminstrel> But I dunno if anyone actually took that suggestion. 20180910 00:53:19<+wesdiscordbot> i think i did 20180910 00:53:22<+wesdiscordbot> and it wasn't viable 20180910 00:53:52< celticminstrel> Why not? 20180910 00:54:02< celticminstrel> Because they're used as keys in too many places? 20180910 00:54:26<+wesdiscordbot> there are three cases in help 20180910 00:54:46<+wesdiscordbot> I think iw as able to eliminate... one 20180910 00:54:50<+wesdiscordbot> i didn't get to the others 20180910 00:54:58<+wesdiscordbot> IIR 20180910 00:55:05< celticminstrel> Is that partial work uploaded anywhere? 20180910 00:55:19< celticminstrel> (That's not a request though.) 20180910 00:55:31<+wesdiscordbot> I thought i committed it 20180910 00:55:34< celticminstrel> Oh, okay. 20180910 00:56:12<+wesdiscordbot> https://github.com/wesnoth/wesnoth/commit/19c78fc1c217a59d62b93ee7822efe0f772cd9f4 20180910 00:57:24<+wesdiscordbot> that was the trivial case 20180910 01:03:32<+wesdiscordbot> I am barely having time for wesnoth this month. There is one PR — #3365 — I started reviewing, and would actually have been ready to merge at one point, though it has now newer changes. It's a great PR, I would have been awesome if we would have had that already for 1.14.0 — it helps the player when they are about to give up and throw the game in the bin. It has one string change, but instead the already existing undo 20180910 01:03:33<+wesdiscordbot> reminder string (from the macro file) could be used. If someone finds time for testing it it would be great. It's more complex as the casual PRs though. 20180910 01:17:03-!- sevu [~sevu@p54854EA0.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180910 01:22:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180910 01:22:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180910 01:26:40<+wesdiscordbot> well that was fast 20180910 01:29:17<+wesdiscordbot> fwdprt 20180910 02:46:28<+wesdiscordbot> @jyrkive look, I'm willing to work with you or someone to get master back into a usable state. I can't figure it out on my own, but maybe now that I've taken a break from it, and maybe with another set of eyes, I can get it done. I want it fixed as much as the rest of you do. 20180910 02:46:45<+wesdiscordbot> You can tell me the theory, but that doesn't tell me how best to implement that in terms of code. 20180910 02:47:19<+wesdiscordbot> My POV is that master needs to be gotten into a usable state, whatever it takes. 20180910 02:47:51<+wesdiscordbot> I know that reverting your commits would be painful. However, it's still better than leaving master permanently unplayable. 20180910 02:49:33<+wesdiscordbot> Also, the reason why I wrote the technical summary is that Pentarctagon asked for one in the OP. He wanted #3538 to be where the event handling issue is documented. 20180910 02:52:23<+wesdiscordbot> reads 20180910 02:53:11<+wesdiscordbot> "Whenever the player taps the screen, Unity casts a ray." -- This makes sense when the UI can be overlaid on game elements I guess 20180910 02:54:39<+wesdiscordbot> In Wesnoth 1.14 that's not the case because the game map's interactive area does not overlap any other UI elements and when dialogs are displayed the game map can no longer receive events 20180910 02:55:05<+wesdiscordbot> But I take it that's no longer going to be the case in 1.16 20180910 02:55:53<+wesdiscordbot> Indeed, at least in Vultraz's UI mockup UI elements were directly on top of the game area. 20180910 02:56:35<+wesdiscordbot> I think he also got some UI dialogs like the objectives popup to not block gamemap rendering at one point on his branch 20180910 02:58:59<+wesdiscordbot> yes. that is so. 20180910 03:09:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180910 03:09:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180910 03:54:48-!- celticminstrel is now known as celmin|sleep 20180910 05:50:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180910 06:02:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180910 07:56:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180910 08:05:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180910 08:49:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180910 12:22:33-!- celmin|sleep is now known as celmin|away 20180910 12:48:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180910 15:47:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180910 15:47:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180910 16:34:56-!- irker826 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180910 16:34:56< irker826> wesnoth: josteph wesnoth:1.14 d4a7aa281513 / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S6: Allow canceling attack orders. https://github.com/wesnoth/wesnoth/commit/d4a7aa281513ff5373bdb538d308e5dc20af24c4 20180910 16:34:56< irker826> wesnoth: josteph wesnoth:1.14 b7b86c1bf74b / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S6: Trigger the additional undead as soon as the player touches the cave en https://github.com/wesnoth/wesnoth/commit/b7b86c1bf74b77fd59d3344772be49ccb30573fe 20180910 16:34:56< irker826> wesnoth: josteph wesnoth:1.14 0cb4484714c4 / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S6: Support unlikely player behavior. https://github.com/wesnoth/wesnoth/commit/0cb4484714c4c09872c71c21033536d03375c09d 20180910 16:48:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180910 16:57:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180910 16:57:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180910 17:34:06< irker826> wesnoth/wesnoth:master DisherProject 3a3bfd2678 SoF: Postpone Gryphon Riders availabilit AppVeyor: All builds passed 20180910 18:23:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180910 18:23:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180910 18:46:00< irker826> wesnoth/wesnoth:master DisherProject 3227e571cc SoF: Postpone Gryphon Riders availabilit AppVeyor: All builds passed 20180910 20:12:52< irker826> wesnoth: gfgtdf wesnoth:master 08b7d1b1ac2e / src/scripting/game_lua_kernel.cpp: fix #3396 lua_function= doesn't work in [effect][filter] https://github.com/wesnoth/wesnoth/commit/08b7d1b1ac2e469bab55c37fe73a40f0df603b04 20180910 20:12:54< irker826> wesnoth: gfgtdf wesnoth:master 3591e8258689 / / (9 files in 6 dirs): add game_config.combat experience https://github.com/wesnoth/wesnoth/commit/3591e82586896c8923de1d45cf9c30d25c522a3f 20180910 20:12:56< irker826> wesnoth: gfgtdf wesnoth:master 69cdbe8da76e / src/scripting/lua_common.cpp: fix 3541 : crash in lua tstring comparision https://github.com/wesnoth/wesnoth/commit/69cdbe8da76e37d4bb827dad97ce99d4ef16cde2 20180910 21:42:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180910 22:01:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20180910 22:27:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180910 22:28:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180910 22:43:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180910 23:14:16-!- irker826 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180910 23:28:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180910 23:43:08-!- irker486 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180910 23:43:08< irker486> wesnoth/wesnoth:1.14 josteph 0cb4484714 HttT S6: Support unlikely player behavio AppVeyor: All builds passed --- Log closed Tue Sep 11 00:00:06 2018