--- Log opened Sat Sep 29 00:00:14 2018 20180929 00:12:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180929 00:23:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180929 00:23:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180929 01:26:53-!- irker042 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180929 01:26:53< irker042> wesnoth/wesnoth:1.14 josteph a521db8136 Unit Display: When a recruiting unit is AppVeyor: All builds passed 20180929 02:06:46-!- gfgtdf [~Daniel@x55b0ab91.dyn.telefonica.de] has joined #wesnoth-dev 20180929 02:17:46-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180929 02:38:06-!- gfgtdf [~Daniel@x55b0ab91.dyn.telefonica.de] has quit [Quit: Leaving] 20180929 03:12:28< irker042> wesnoth/wesnoth:1.14 Joseph Gelfand a7c0e39127 Made test for invalid BLIT parameters ma AppVeyor: All builds passed 20180929 05:27:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180929 06:04:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180929 06:12:34-!- irker042 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180929 08:52:04-!- irker303 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180929 08:52:04< irker303> wesnoth: Jyrki Vesterinen wesnoth:opengl 671622727977 / src/ (thread_pool.cpp thread_pool.hpp): Thread pool can now receive tasks to do https://github.com/wesnoth/wesnoth/commit/67162272797790083e4acbe0337390a0641bcdf2 20180929 09:05:58-!- travis-ci [~travis-ci@ec2-50-17-65-213.compute-1.amazonaws.com] has joined #wesnoth-dev 20180929 09:05:59< travis-ci> wesnoth/wesnoth#19516 (opengl - 6716227 : Jyrki Vesterinen): The build is still failing. 20180929 09:05:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/434933652 20180929 09:05:59-!- travis-ci [~travis-ci@ec2-50-17-65-213.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180929 09:09:26< irker303> wesnoth: Jyrki Vesterinen wesnoth:opengl df37b11561ea / src/ (thread_pool.cpp thread_pool.hpp): Fix build https://github.com/wesnoth/wesnoth/commit/df37b11561ea8f70afbf7bfd3184003346362e5c 20180929 09:27:08-!- travis-ci [~travis-ci@ec2-54-198-121-239.compute-1.amazonaws.com] has joined #wesnoth-dev 20180929 09:27:09< travis-ci> wesnoth/wesnoth#19517 (opengl - df37b11 : Jyrki Vesterinen): The build is still failing. 20180929 09:27:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/434936738 20180929 09:27:09-!- travis-ci [~travis-ci@ec2-54-198-121-239.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180929 10:15:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180929 10:34:25< irker303> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 8b43b6716d98 / src/desktop/apple_version.mm: Implement iOS version detection https://github.com/wesnoth/wesnoth/commit/8b43b6716d981664a0e97b24bed33fb638eca38d 20180929 10:51:39< irker303> wesnoth: Jyrki Vesterinen wesnoth:opengl c81095ac8b68 / src/thread_pool.hpp: Really fix build https://github.com/wesnoth/wesnoth/commit/c81095ac8b683c537e2ba56190e1f5aa5f717aa9 20180929 10:53:21-!- ShikadiQueen [~iris@wesnoth/developer/shadowm] has joined #wesnoth-dev 20180929 10:56:21-!- shadowm [~iris@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds] 20180929 11:10:34-!- travis-ci [~travis-ci@ec2-50-17-65-213.compute-1.amazonaws.com] has joined #wesnoth-dev 20180929 11:10:35< travis-ci> wesnoth/wesnoth#19519 (opengl - c81095a : Jyrki Vesterinen): The build is still failing. 20180929 11:10:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/434954934 20180929 11:10:35-!- travis-ci [~travis-ci@ec2-50-17-65-213.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180929 11:57:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180929 11:58:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180929 12:28:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180929 12:28:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180929 12:59:09-!- stikonas_ is now known as stikonas 20180929 13:45:29-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180929 13:51:41-!- irker303 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20180929 14:41:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180929 14:45:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180929 15:48:37-!- irker170 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20180929 15:48:37< irker170> wesnoth: sigurdfdragon wesnoth:1.14 ae09b57ea804 / data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg: DM S08: Cleanup & improve ending sequence, fixing #3575 https://github.com/wesnoth/wesnoth/commit/ae09b57ea8041ff94890569070826a9b155e0c89 20180929 15:51:05< irker170> wesnoth: sigurdfdragon wesnoth:master 75ab69d88516 / data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg: DM S08: Cleanup & improve ending sequence, fixing #3575 https://github.com/wesnoth/wesnoth/commit/75ab69d885163dd4bb40259cf91123394e2c12ee 20180929 15:59:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180929 16:00:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180929 16:02:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180929 17:35:49< irker170> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) 8b43b6716d Implement iOS version detection AppVeyor: All builds passed 20180929 18:38:01< celticminstrel> @Vultraz Did you see the talk yesterday or the day before about changing the default branch on GitHub 20180929 18:38:26< celticminstrel> Well, sometime earlier this week at least, I can't remember the exact day. 20180929 18:38:44<+wesdiscordbot> Ah, right, you want 1.14 the default? 20180929 18:39:24< celticminstrel> That would be one possibility, the other would be some new branch branched off of 1.14 or something. 20180929 18:39:40< celticminstrel> Or pre-branch master, I suppose. 20180929 18:39:59< celticminstrel> But those possibilities would require creating the new branch, so setting 1.14 is probably easiest. 20180929 18:57:04<+wesdiscordbot> @jyrkive Yeah, I know that better_combat() is called for both, just didn't think of that in my first comment. Sorry for the confusion. 20180929 18:57:47<+wesdiscordbot> I thought you'd know, but decided to clarify anyway for other people who may be reading the bug report. 20180929 18:58:54<+wesdiscordbot> I figured (and no offense taken, as I hope is obvious). I'd have done the same. 20180929 19:23:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180929 19:49:24< irker170> wesnoth/wesnoth:opengl Jyrki Vesterinen c81095ac8b Really fix build AppVeyor: All builds passed 20180929 19:49:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20180929 20:39:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180929 20:39:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180929 20:44:35<+wesdiscordbot> looking for feedback on the set_dialog_value() change in https://github.com/wesnoth/wesnoth/issues/3572#issuecomment-423777894 20180929 20:45:10<+wesdiscordbot> as I say in a later comment I'm thinking of committing it unless someone has a better idea 20180929 20:46:12<+wesdiscordbot> You can try firing a REQUEST_PLACEMENT event instead. It would be faster. 20180929 20:48:39<+wesdiscordbot> @jyrkive Where would I do that? At the end of intf_set_dialog_value()? Somewhere in the widget class? 20180929 20:48:55<+wesdiscordbot> In the same line. 20180929 20:51:07-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180929 20:54:35<+wesdiscordbot> So, resources::controller->pump().fire() ? 20180929 20:56:45<+wesdiscordbot> No. Like this. 20180929 20:56:45<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/ae09b57ea8041ff94890569070826a9b155e0c89/src/gui/widgets/scrollbar_container.cpp#L585-L586 20180929 20:56:58<+wesdiscordbot> Hmm, no, I need gui2::events::dispatcher, don't I. 20180929 20:57:31<+wesdiscordbot> Right, so where do I get an instance of a class that has the fire member function? 20180929 20:58:03<+wesdiscordbot> GUI2 widgets inherit the dispatcher class, so you already have one (w). 20180929 20:58:34<+wesdiscordbot> Thanks 20180929 21:02:16<+wesdiscordbot> What's the empty event::message argument for? 20180929 21:02:40<+wesdiscordbot> All GUI2 events must have messages. 20180929 21:03:03<+wesdiscordbot> REQUEST_PLACEMENT doesn't use the message for anything, so it's easiest to just give an empty message. 20180929 21:04:29<+wesdiscordbot> OK. 20180929 21:04:34<+wesdiscordbot> I'd tried the fire() overload that doesn't take a message and it died with an assertion. 20180929 21:04:48<+wesdiscordbot> (I'm using the overload that takes a message now.) 20180929 21:09:56<+wesdiscordbot> @jyrkive Using REQUEST_PLACEMENT doesn't fix the issue. 20180929 21:10:13<+wesdiscordbot> If I select 0.0.1 then 3.8.0, it's truncated 20180929 21:10:20<+wesdiscordbot> OK. In that case you apparently need full layout invalidation. 20180929 21:10:27<+wesdiscordbot> if I select 3.8.2 then 3.8.0, the whole text shows (I think) but it's shifted upward 20180929 21:10:35<+wesdiscordbot> ok 20180929 21:10:52<+wesdiscordbot> Thanks for looking into it 20180929 21:11:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180929 21:16:02< irker170> wesnoth: josteph wesnoth:1.14 8f8ec38dfc40 / src/gui/core/event/message.hpp: Fix includes https://github.com/wesnoth/wesnoth/commit/8f8ec38dfc40b0dc447b3aedba5427e7d828b76b 20180929 21:16:04< irker170> wesnoth: josteph wesnoth:1.14 8000a868286d / src/scripting/lua_gui2.cpp: Lua: Invalidate layout in set_dialog_value() https://github.com/wesnoth/wesnoth/commit/8000a868286d374d39c71215de6f376a31e4fe0a 20180929 21:17:29<+wesdiscordbot> 😄 20180929 21:17:34<+wesdiscordbot> recompiles 20180929 21:41:35< irker170> wesnoth: josteph wesnoth:1.14 8603729d1611 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/8603729d1611ffdc9a5311e018377bfff861c0f4 20180929 22:28:48< celticminstrel> ...oh hey, josteph got commit access at some point? 20180929 22:35:46<+wesdiscordbot> yep, a few days ago 20180929 22:36:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180929 22:37:49< celticminstrel> You know, another argument in favour of making 1.15 a stable release (perhaps within a month or so) rather than using rolling release cycles exclusively on 1.14 is that all the experimental 1.15 features have already been added to the wiki as being available first in 1.15.0. Admittedly it's not hard to find all of them and change them if necessary, but... 20180929 22:38:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180929 22:39:15< celticminstrel> Switching topics already, but the wiki page "OOS (Out of Sync)" is extremely terribly named. 20180929 22:39:22<+wesdiscordbot> If rolling releases are what's done, I definitely think it shouldn't be called 1.14.6 or whatever it would be. That's just going to confuse people. 20180929 22:39:26< celticminstrel> Mind you, a lot of Wesnoth pages aren't well-named, but... 20180929 22:39:31< celticminstrel> That one is particularly bad. 20180929 22:39:45< celticminstrel> I forget, do we need @Vultraz for moving pages? 20180929 22:40:13< celticminstrel> A better way to handle that page would be to title it "Out-of-sync Errors" and then have redirects to it from things like "OOS", "OOS Error", etc. 20180929 22:40:27< celticminstrel> (IIRC the wiki really underuses redirects?) 20180929 22:41:49<+wesdiscordbot> I think you need zookeeper or shadowm 20180929 22:43:32< celticminstrel> Vultraz does have moderator priveleges on the wiki (last I heard). 20180929 22:43:58< irker170> wesnoth/wesnoth:1.14 sigurdfdragon ae09b57ea8 DM S08: Cleanup & improve ending sequenc AppVeyor: All builds passed 20180929 22:44:15<+wesdiscordbot> I think it's not necessary to increase version number to 1.15 – that would otherwise wield the question what to do with 1.14, shall it be yet another MP Server (and add-ons server). 20180929 22:44:39<+wesdiscordbot> And if IIRC the api levels would enable rather smaller features… 20180929 22:47:49<+wesdiscordbot> My guess is anyone in the wiki admins group could move a page. 20180929 22:48:04<+wesdiscordbot> I've mostly just been creating wiki accounts for people though. 20180929 23:05:03< celticminstrel> @Vultraz https://forums.wesnoth.org/viewtopic.php?p=633109#p633109 --- Log closed Sun Sep 30 00:00:15 2018