--- Log opened Fri Sep 14 00:00:49 2018 20180914 00:57:09-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 20180914 01:17:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 01:17:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180914 02:14:09-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20180914 05:59:41< vn971> damn, everything seems to be buggy *panics* When I remove an object that only touches "hitpoints" and "attack", I somewhy get the current movement reduced from 10/10 to 7/10 20180914 06:01:32< vn971> Also there is a weird bug when combining "lessrandom" add-on with "afterlife". In the latter case, some AI units that should stop being grayed-out remain grayed-out. What's more, a player with whom I was playing with said that those units I'm thinking are grayed-out are not grayed-out from his point of view, but another AI side is shown as grayed-out. 20180914 06:02:44< vn971> And "lessrandom" has *nothing* to do with neither colors nor image manipulation. At all. It only adds [object]-s to units, removes said objects, and sometimes changes current HP. 20180914 06:03:17< vn971> Wait, I have an explanation. 20180914 06:04:18< vn971> If, imagine, remove_object would be somehow buggy and would remove objects under different id-s, all of said bugs would start to be a different faces of the same one bug. 20180914 06:05:19< vn971> The code that grays out and restores to normal has something to do with object removal, "lessrandom" does object removal and CreepWars do object removal. 20180914 06:07:05< vn971> Also, in CreepWars, I sometimes saw creeps generated at ultra-high HP and ultra-high strikes count -- as if "lessrandom" would be applied twice. I thought it's my bug, but since "lessrandom" uncovered about 5 seemingly unrelated bugs, I'm beginning to suspect this occurence has the same source. 20180914 06:09:08< vn971> Alternatively, if remove_object would work correctly in itself, but would be applied to the wrong units ofthen -- the of the phenomena would be explained as well. 20180914 06:09:17< vn971> *often 20180914 06:09:45< vn971> * to the wrong units often -- all of the phenomena would be explained as well. 20180914 06:10:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20180914 06:17:41< vn971> Yess, I think I'm starting to find something reproducible. I think I caught a case where object was applied twice now (same id). That would be a start. Need to shrink the repro case now. 20180914 06:20:46< vn971> or wait, this sounds like a separate bug. The object is just added twice without any removal.:( Reporting it now then.. 20180914 06:25:20< vn971> raised issue: https://github.com/wesnoth/wesnoth/issues/3549 If when this gets fixed, I'll try to dig in deeper and understand how exactly (the supposed) object removal bug shows up. 20180914 06:47:58< vn971> Dear UMC developers, does anybody have an opinion on this?: https://github.com/wesnoth/wesnoth/issues/3549#issuecomment-421247810 20180914 06:47:58< vn971> In short, current implementation of wesnoth.add_modification(unit, "object", { ...same tags as in [object] allowed here... }) does not hold the "unique id should only be applied once" constraint. 20180914 06:47:58< vn971> If we leave it as-is, UMC developers might assume the constraint and get broken functionality as a result (broken principle of least surprise). If we change it, however, some of the add-ons relying on the ignored "id" constraint might become broken. 20180914 06:50:06<+wesdiscordbot> Changing it for 1.14 is out of the question because we don't change public APIs in bugfix releases. However, changing it in 1.15 would be okay. 20180914 06:54:06< vn971> @jyrkive: I would even add that no matter if you view the current behavior as bug or not, changing in 1.14 would cause OOS. So indeed not possible no matter what. 20180914 06:54:40<+wesdiscordbot> OOS is the main reason for that policy. 20180914 06:55:12<+wesdiscordbot> (Worth mentioning is that bug fixes which technically change the API are allowed.) 20180914 07:26:21-!- vn971 [~vasya@94.158.103.15] has quit [Read error: Connection reset by peer] 20180914 07:26:33-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-umc-dev 20180914 11:55:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 11:55:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180914 12:25:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 12:25:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180914 12:30:00-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-umc-dev 20180914 14:13:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 14:13:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180914 14:35:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 14:36:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180914 20:31:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20180914 20:32:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20180914 21:31:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 21:31:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180914 21:55:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20180914 22:49:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180914 22:49:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev --- Log closed Sat Sep 15 00:00:50 2018