--- Log opened Sun Sep 16 00:00:52 2018 20180916 00:57:12-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 20180916 01:27:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 01:27:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 02:09:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 02:09:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 02:24:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 02:25:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 05:06:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 05:06:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 05:47:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 05:47:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 06:33:12< vn971> hk238: That should be very unlikely in the latest PUA version. Do you have a savegame? Would very much appreciate one. 20180916 06:33:28< vn971> (TODO: resend the message when he/she re-joins.) 20180916 06:34:37< vn971> I'll hijack the channel for 1 off-topic question though: how exactly should I say the phrase above in a gender-neutral matter? Is there a simple for without "he/she" ? 20180916 06:35:11< vn971> * is there a simple form? 20180916 06:58:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20180916 07:41:26<+wesdiscordbot> See https://en.wikipedia.org/wiki/Third-person_pronoun#English 20180916 07:41:40<+wesdiscordbot> Singular they is the most common of these, I think. 20180916 07:48:01<+wesdiscordbot> Is there a way to tell GUI2 to use the available space instead of creating a scrollbar? I have two columns, an icon and then the text, and it uses less width than just the icon: 20180916 07:48:06<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/490790973547347999/Screenshot_from_2018-09-16_02-45-17.png 20180916 07:50:21<+wesdiscordbot> I think it's attempting to avoid wrapping that long line. 20180916 07:50:53<+wesdiscordbot> Try to add wrap=yes or characters_per_line for the text. 20180916 07:56:44<+wesdiscordbot> that is with wrap=true already - otherwise it was creating a horizontal scrollbar for the whole thing instead and putting the long line on one line 20180916 07:58:03<+wesdiscordbot> characters_per_line seems to work though 20180916 07:58:06<+wesdiscordbot> thanks 20180916 08:02:36<+wesdiscordbot> also, before I try getting any further into this, there's no way to directly write out the GUI2 tags like WML, as is done in core, right? 20180916 08:08:01<+wesdiscordbot> it's not exactly hard to work around that, but I'm just curious if I need to or not 20180916 08:17:33<+wesdiscordbot> hey i have an question, regarding tweaking the Rush Mod 20180916 08:18:28<+wesdiscordbot> is it possible to somehow limit it so not all units can get recruited on the same castle tile ? 20180916 08:19:45<+wesdiscordbot> normally as when an unit is recruited it does not have full moves so no further recruitment on that castle tile as its occupied by that unit, with rush mod you can move it out and then recruit again on that same castle tile, id like to prevent that 20180916 08:34:25< zookeeper> the only thing that comes to mind is having a moveto event which triggers when the recruited unit moves away from the castle hex, and then places for example a petrified dummy unit on that hex, and then another event to remove all the dummies when the side ends their turn. 20180916 08:58:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180916 09:36:33-!- sevu [~sevu@p54855520.dip0.t-ipconnect.de] has joined #wesnoth-umc-dev 20180916 10:23:36-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-umc-dev 20180916 10:37:27< vn971> jyrkive: So how would I word it out correctly then? "resend when he/she returns". "resend when it returns"? Sounds weird.. "when they return"? 20180916 10:47:54< hk238> hi :D 20180916 11:10:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 11:10:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 11:32:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 11:32:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 11:48:51-!- sevu [~sevu@p54855520.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180916 12:11:16<+wesdiscordbot> vn971: "resend when they return" would be valid. 20180916 12:23:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 12:23:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 12:59:38< vn971> hk238: hi) 20180916 12:59:59< vn971> Replying to an earlier message. That should be very unlikely in the latest PUA version. Do you have a savegame? Would very much appreciate one. 20180916 13:00:15< vn971> > is it PUA bug possibly when swordsman advances into swordsman? 20180916 13:15:46< hk238> yeah notably I did 'save for all units' first on a spearman, then when it advanced to a swordsman, and leveled up, it became a swordsman again 20180916 13:15:53< hk238> might be something to do with the saving 20180916 13:16:14< hk238> also there were 2 swordsmen and it happened for both of them.. but no I dont have a savefile 20180916 13:16:45< hk238> I'm not sure if I had updated addons before or after this happened, so it's possible I didn't have the latest version 20180916 13:58:34<+wesdiscordbot> @zookeeper the petrified dummy would block pathing, instead will do convert castle tile to fake castle after moved out, then convert back to normal castle at turn end. that should work, probably. 20180916 15:35:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20180916 16:08:43< vn971> hk238: no, I'm not implying that it was due to saving/loading of the game 20180916 16:08:54< vn971> hk238: I'm asking if you have a savegame file that I could see. A replay. 20180916 16:22:16< hk238> I think you misunderstood, I was trying to say that the relevant part was using the PUA command 'save for all units' and that I don't have the savegame to look at 20180916 16:27:23<+wesdiscordbot> Another GUI2 question: I have a piece of text I'd like to display: * Fixed macro includes. * Upgrade option/message to DescriptionWML. * Fixed/removed formulas. * MusicMacros namespace added. * Modify playlist functionality: remove songs generated list not updating correctly after song removal. However, it ends up getting truncated: 20180916 16:27:28<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/490921673634349077/Screenshot_from_2018-09-16_11-25-23.png 20180916 16:27:47<+wesdiscordbot> Why would it do that? 20180916 16:28:17<+wesdiscordbot> the label is defined as: [label] id = "info_text" use_markup = "true" characters_per_line = "40" [/label] 20180916 16:33:22< vn971> hk238: ah, okay. Still, do you have the file? The savegame? 20180916 16:33:37< vn971> oops sorry, ok understood (no file). 20180916 16:35:07< vn971> damn, you actually said it in first messages as well. Damn my reading.:( In my defense, I caught a chill today.:( 20180916 16:35:56< hk238> no problem :o 20180916 17:24:26< vn971> Is there a curated list of add-ons that broke in recent wesnoth versions and would love fixing BTW? 20180916 17:29:10< hk238> I've no idea :o 20180916 17:54:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 17:54:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 18:12:38< hk238> I managed to recreate this, and disabling/enabling PUA makes it go away 20180916 18:12:57< hk238> I mean first tried it with PUA, then without, havent tried if it still happens but probably does 20180916 18:14:50< vn971> hk238: sorry, forgot to write. I had further hints from other players on where/how the bug happens, and I managed to find the bug. 20180916 18:15:04< hk238> oh cool what was it out of curiosity? :D 20180916 18:15:13< vn971> hk238: the quickfix was already being made, it's on the add-ons server. 20180916 18:15:26< hk238> alright I'll download that :d 20180916 18:16:03< vn971> I'm restoring the old smarter logic now that is a bit safer for "wesnoth.remove_modifications" Lua API. Already wrote the functionality, about to commit and upload (after I re-check that it works as I want in game). 20180916 18:17:21< hk238> I find it strange that only one unit would end up having such a bug :D Is it because spearman has 3 advancement classes? 20180916 18:32:57< vn971> hk238: all of the units have it if they have 3 levels I think. 20180916 18:33:11< vn971> hk238: I've published a full proper fix now. 20180916 18:34:56< vn971> > what was it out of curiosity -- my initialization procedure + misuse of permanent objects. In more detail: I moved away from Lua-ish API of having unit.advances_to = { array, of, something } 20180916 18:35:14< vn971> because it was being reset if the unit has `wesnoth.remove_modifications` called on it. 20180916 18:35:33< vn971> so what I used instead is permenent [object][effect]apply_to = "new_advances" 20180916 18:35:45< vn971> but I forgot that it'll stay permanent even if unit levels-up. 20180916 18:36:13< vn971> what's worse, my override functions were never called on a unit that practically reached AMLA 20180916 18:37:07< vn971> so the object remained where it is. And the object continued to work even after unit leveled from the type it originally was appropriate to. 20180916 18:38:29< vn971> damn no, my new fix is incorrect as well :facepalm: 20180916 18:39:23< hk238> darn :d 20180916 18:40:58< vn971> hk238: ok now I think it works. 20180916 18:41:04< vn971> version 1.4.0 20180916 18:41:27-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-umc-dev 20180916 18:41:28< hk238> how did you fix it? :D 20180916 18:42:01< vn971> hk238: now removing the [object] aggressively whenever I see a changed unit type for the same unit. 20180916 18:42:26< vn971> BEFORE remembering the advances and assuming them being natural unit ones. 20180916 18:47:32< hk238> I'm having trouble understanding these lua files also regular expressions :D 20180916 18:54:04-!- gfgtdf [~androirc@dslb-084-062-231-212.084.062.pools.vodafone-ip.de] has joined #wesnoth-umc-dev 20180916 18:55:21< gfgtdf> We wanted to add duration=level that makes the object disappear on level up, maybe we forgot that. 20180916 19:12:55< vn971> gfgtdf: BTW, thanks for the on_change.lua "library".;) I recently started using it and find it very convenient for those who use Lua. 20180916 19:13:22< gfgtdf> you mean on_event ? 20180916 19:13:53< vn971> the ability to prioritize is nice as well. Not used by me yet, but it's a good thing to have for possible future add-on clashes. 20180916 19:13:57< vn971> gfgtdf: right, on_event 20180916 19:14:51< vn971> gfgtdf: also, I did switch to synchronize_choices instead of synchronize_choice loop. Thanks for that hint as well.:) 20180916 19:16:29< gfgtdf> ty, I also use on_event often in my addon, at one place i use the priority where one events refreshes a units mp and abother one increases maximum moves. 20180916 19:20:13< gfgtdf> aslo remeber the priority between different addon only works if you use wesnoth.require to load on_event, if you use wesnith_dofile each addo. will have a copy of that libaray and it will probably not work as intended. 20180916 19:21:01< vn971> gfgtdf: ouch. 20180916 19:21:20< vn971> // I only "require", but it's "ouch" regardless. 20180916 19:21:30< vn971> gfgtdf: maybe I'll PR a fix to that? 20180916 19:22:05< gfgtdf> wesnoth dofile on on_event.lua, using dofile on other files is not problematic. 20180916 19:23:02< vn971> gfgtdf: yes, I understood what you mean, and where the bug comes from.. Gimme a minute or two, I'm writing a PR ATM. 20180916 19:30:17< gfgtdf> I'm on my phone so i cannot write long comments today though. 20180916 19:32:12< hk238> is the PUA addon updated? It seems to be 1.3.2 on addons server 20180916 19:33:35< vn971> hk238: should be 1.4.0... 20180916 19:34:08< vn971> hk238: ok apparently it's 1.3.2. Use it, it's safe. 20180916 19:34:27< hk238> okay 20180916 19:35:10< vn971> I actually re-uploaded 1.3.2 under the name of 1.4.0 so that everyone would understand there was a +- major update. Apparently if you upload exactly the same add-on twice -- wesnoth rejects the newer version. (Doesn't update the version itself.) 20180916 19:35:37< vn971> IDK if that should be counted as add-ons server bug or not. (Maybe not -- again IDK.) 20180916 19:42:07< vn971> gfgtdf: on_event PR: https://github.com/wesnoth/wesnoth/pull/3560 20180916 19:43:42< gfgtdf> will comment tomorrow 20180916 19:47:51< vn971> sure 20180916 19:53:05< vn971> hk238: PUA is indeed somewhat complex on the inside. 20180916 19:53:40< vn971> Lua tables passed around as arguments, non-straightforward user choices accounted for etc. 20180916 19:55:40< vn971> nothing too critical by now though. The most insane days of also using persistent user choices is left behind by now. 20180916 20:06:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20180916 20:07:17< hk238> btw vn971 won against dwarves on UD today in regular afterlife, although opponent was pretty good 20180916 20:07:31< hk238> so that match redefined UD-dwarf a little bit 20180916 20:08:23< hk238> UD strategy was to make lots of WCs from opponents units, recruit 1 ghost and advance it into a shadow, then mass DAs with all of the gold 20180916 20:08:34< hk238> and level up intelligent adepts first, and use non-intelligent ones as openers 20180916 20:09:07< hk238> it was pretty crushing for loyalists, although I did spend a daytime without retreating, and ended up losing units 20180916 20:09:14< hk238> I mean for Dwarves 20180916 20:09:33< hk238> Dwarf Lords are still really tough but UD can win in the early game with mass adepts before dwarf gets too many of them 20180916 20:09:56< hk238> also requires careful management of WCs since they're the only blockers in the strat 20180916 20:12:08< vn971> hk238: nice! 20180916 20:12:42< vn971> shadow is indeed unpleasant for dwarves. And WC can bump your defenses early on. 20180916 20:13:11< hk238> yeah also WCs made from dwarvse have 60% defense on hills and 70% on mountains, and they're reasonably sturdy when advanced 20180916 20:13:28< hk238> but slow :D 20180916 20:14:22< hk238> my opinion pre-game was that dwarves should win easily, but now I think UD at least have a chance 20180916 20:15:10< hk238> and although opponent was pretty good I think he made some mistakes too 20180916 20:23:39-!- sevu [~sevu@141.57.61.193] has joined #wesnoth-umc-dev 20180916 20:30:08-!- gfg [~androirc@dslb-084-062-231-212.084.062.pools.vodafone-ip.de] has joined #wesnoth-umc-dev 20180916 20:30:08-!- gfgtdf [~androirc@dslb-084-062-231-212.084.062.pools.vodafone-ip.de] has quit [Read error: Connection reset by peer] 20180916 20:52:11-!- sevu [~sevu@141.57.61.193] has quit [Remote host closed the connection] 20180916 21:46:13< vn971> advanced question. Is there an API to get some info from the current side without additional delay? For example, there is some delay whenever I use wesnoth.synchronize_choices. 20180916 21:46:56< vn971> Maybe, for current side, there is some method that doesn't add any considerable delays if you want to get info from currently active side. 20180916 21:49:21< vn971> does the normal wesnoth.synchronize_choice already have this property -- being fast if it's called for current side? 20180916 22:31:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180916 22:31:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-umc-dev 20180916 22:32:11< vn971> * decided to get rid of the slow synchronize_choices at game start. Will now show an advertisement at game start if you do not have the add-on at all, or slowly calculate all versions on other side turn-s while in turn 1. On turn2, if you're outdated, you'll get the upgrade suggestion. 20180916 22:33:07< vn971> stuff like that: https://github.com/vgaming/less_random/commit/22a117fcda0ef435845a34bb52867df5f81196f1 --- Log closed Mon Sep 17 00:00:53 2018