--- Log opened Sat Oct 06 00:00:23 2018 --- Day changed Sat Oct 06 2018 20181006 00:00:23-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181006 00:00:54-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 00:52:42-!- travis-ci [~travis-ci@ec2-54-166-8-105.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 00:52:43< travis-ci> gfgtdf/wesnoth#1285 (fix_3594 - 8c82466 : gfgtdf): The build failed. 20181006 00:52:43< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437881265 20181006 00:52:43-!- travis-ci [~travis-ci@ec2-54-166-8-105.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 00:54:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 01:10:00-!- travis-ci [~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 01:10:01< travis-ci> gfgtdf/wesnoth#1286 (fix_3594 - 7527199 : gfgtdf): The build is still failing. 20181006 01:10:01< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437884718 20181006 01:10:01-!- travis-ci [~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 01:23:00-!- travis-ci [~travis-ci@ec2-54-234-224-226.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 01:23:01< travis-ci> gfgtdf/wesnoth#1287 (fix_3594 - 0908ab6 : gfgtdf): The build is still failing. 20181006 01:23:01< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437886781 20181006 01:23:01-!- travis-ci [~travis-ci@ec2-54-234-224-226.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 01:27:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 01:37:05< irker627> wesnoth/wesnoth:1.14 nemaara 5a31dc6212 Made it more clear that Deoran is a knig AppVeyor: All builds passed 20181006 01:47:09-!- Polsaker is now known as Punsaker 20181006 02:28:30-!- travis-ci [~travis-ci@ec2-54-81-128-68.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 02:28:31< travis-ci> gfgtdf/wesnoth#1289 (fix_3594 - 39285c8 : gfgtdf): The build is still failing. 20181006 02:28:31< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437896308 20181006 02:28:31-!- travis-ci [~travis-ci@ec2-54-81-128-68.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 02:40:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 02:55:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 02:58:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 03:24:19-!- travis-ci [~travis-ci@ec2-54-234-151-219.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 03:24:20< travis-ci> gfgtdf/wesnoth#1290 (fix_3594 - 652dc1c : gfgtdf): The build is still failing. 20181006 03:24:20< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437903003 20181006 03:24:20-!- travis-ci [~travis-ci@ec2-54-234-151-219.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 04:38:43-!- irker627 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181006 04:39:23-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20181006 04:50:17-!- irker126 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181006 04:50:17< irker126> wesnoth/wesnoth:1.14 nemaara bc10bd50dd Added some descriptions to S5 story text AppVeyor: All builds passed 20181006 04:54:04-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has quit [Ping timeout: 272 seconds] 20181006 04:55:49-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has joined #wesnoth-dev 20181006 05:20:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer] 20181006 05:23:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 05:23:35-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 05:24:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 05:24:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 05:24:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 05:25:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 05:25:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 05:25:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 05:26:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 05:26:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 05:37:02-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20181006 05:47:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 05:58:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 06:19:50< irker126> wesnoth/wesnoth:master Severin Glöckner ae228b7070 manpage: add missing options AppVeyor: All builds passed 20181006 06:20:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181006 08:39:54< irker126> wesnoth: Nils Kneuper wesnoth:master 9672652a6a67 / po/ (4 files in 4 dirs): updated Chinese (Traditional) translation https://github.com/wesnoth/wesnoth/commit/9672652a6a672a1ac3c094679cd97bbfe3482603 20181006 08:40:00< irker126> wesnoth: Nils Kneuper wesnoth:1.14 5b03a80bc2da / / (5 files in 5 dirs): updated Chinese (Traditional) translation https://github.com/wesnoth/wesnoth/commit/5b03a80bc2daad261116bdd0698311aeb5e53ae8 20181006 08:55:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20181006 08:57:21-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181006 08:58:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 09:07:37-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20181006 09:08:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181006 09:17:49< irker126> wesnoth/wesnoth:1.14 Severin Glöckner 7bc0a421b5 manpage: add missing options AppVeyor: All builds passed 20181006 09:48:50-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181006 09:49:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds] 20181006 09:49:55-!- Ivanovic_ is now known as Ivanovic 20181006 09:50:40-!- travis-ci [~travis-ci@ec2-54-198-0-43.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 09:50:41< travis-ci> gfgtdf/wesnoth#1291 (fix_3594 - aded5dc : gfgtdf): The build is still failing. 20181006 09:50:41< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437952141 20181006 09:50:41-!- travis-ci [~travis-ci@ec2-54-198-0-43.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 10:05:12-!- travis-ci [~travis-ci@ec2-54-90-146-149.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 10:05:13< travis-ci> gfgtdf/wesnoth#1292 (fix_3594 - 552b164 : gfgtdf): The build is still failing. 20181006 10:05:13< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437954545 20181006 10:05:13-!- travis-ci [~travis-ci@ec2-54-90-146-149.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 10:05:23<+wesdiscordbot> When mouse is over any unit, its description is shown in display window, In which file this operation is written? 20181006 10:14:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181006 10:37:19-!- gfgtdf [~Daniel@x4dbbc409.dyn.telefonica.de] has joined #wesnoth-dev 20181006 11:00:30-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20181006 11:02:32< gfgtdf> does anyone has an diea why #3602 crashes with a segfault at battle_context::simulate ? Is is nontrivial or am i just too tired? 20181006 11:07:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20181006 11:07:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20181006 11:39:37-!- travis-ci [~travis-ci@ec2-54-162-83-95.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 11:39:38< travis-ci> gfgtdf/wesnoth#1295 (fix_3594 - 69ac138 : gfgtdf): The build is still failing. 20181006 11:39:38< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437968414 20181006 11:39:38-!- travis-ci [~travis-ci@ec2-54-162-83-95.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 12:03:06-!- Nokuro [~Nokuro@103.242.198.39] has joined #wesnoth-dev 20181006 12:03:49< Nokuro> How is team and unit associated? Unit does not have any reference to team and team does not have any reference to unit. 20181006 12:10:16-!- travis-ci [~travis-ci@ec2-54-166-8-105.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 12:10:17< travis-ci> gfgtdf/wesnoth#1296 (fix_3594 - 450b352 : gfgtdf): The build was canceled. 20181006 12:10:17< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/437981231 20181006 12:10:17-!- travis-ci [~travis-ci@ec2-54-166-8-105.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181006 12:11:08< gfgtdf> every unit belong to exactly one team, every team is associated to an arbitiarly amount of units. 20181006 12:12:04< gfgtdf> also i foudn the bug in my code i asked above, i just forgot to initilize a pointer to nullptr. 20181006 12:12:55<+wesdiscordbot> I think Nokuro means the team in sense of allies/enemy, not side 20181006 12:13:20<+wesdiscordbot> and how it works in C++ rather han WML 20181006 12:14:45< gfgtdf> every 'side'(the c++ 'team' class, i know its confusing) has a 'team_name' attribute that is a list of string ids, two sides are allied iff their 'team_name' attributes intersect. 20181006 12:15:25< Nokuro> I want to find that the unit under my cursor is player or other team, So, I used find_unit function, and it returned me a unit, but now there is no way of telling that the returned unit is of which team, 20181006 12:15:34< Nokuro> as unit has NO reference to team 20181006 12:15:50< Nokuro> team_name is not static 20181006 12:16:01< gfgtdf> it has a side attribute which is the number of the side (the c++ 'team' class ) iot belong to 20181006 12:16:47< Nokuro> yes, I want to know more about it, I want to know, that in a single player game, does human player always have side=1 20181006 12:17:08< gfgtdf> no 20181006 12:17:11< gfgtdf> any side can be human 20181006 12:17:33< Nokuro> then how would I know that the unit under my cursor is my unit? 20181006 12:17:37< gfgtdf> you can check the team::is_human() function to check whetehr a side is human 20181006 12:18:10< Nokuro> I told you, find_unit returns Unit and not team, and unit does not have any team reference, so it is not possible to use team:::is_human 20181006 12:18:11< gfgtdf> for that you best compare the side number with 'viewing_side' (the side number that currently has a the 'point of view') 20181006 12:18:25< gfgtdf> note that there can be multiple human sides in a game 20181006 12:18:42< Nokuro> yes, I thought so, but was afraid what if AI also uses viewing side 20181006 12:19:26< Nokuro> I know, I just want a reliable way of differentiating my units from others 20181006 12:19:41< Nokuro> It wouldn't be much issue if there were any reference of team in unit itself. 20181006 12:19:57< gfgtdf> hmm no it doesn't for checking whether the units are 'yours' use viewing side (which is differnt from current side, the later is the side of which turn it currently is) 20181006 12:20:26< gfgtdf> a reference to the team woudl really not help you there 20181006 12:20:55< Nokuro> why not, then I would have reference to team and then I can easily call team::is_human 20181006 12:21:19< gfgtdf> Nokuro: but i thought you wanted top check whethe rthese are yours and not whether they belong to any human 20181006 12:21:40< gfgtdf> Nokuro: what do you want to do in the first place ? 20181006 12:22:24< Nokuro> When ever I mouse hover over all the units, I want to perform some operations only to my units 20181006 12:23:10< Nokuro> But in single player, since there are only 1 Human controlled, so I thought is_human will also work 20181006 12:24:09< gfgtdf> even in 'singleplayer' its possible that there are more than one human sidem, in some scenarios you for exampel control two differnt armies. 20181006 12:24:41< Nokuro> Oh okay, then what should I do? 20181006 12:25:46< Nokuro> can you tell me more about viewing_side? 20181006 12:25:50< gfgtdf> compare side to display ::get_singleton()->viewing_side(); 20181006 12:38:21< gfgtdf> mattsc: do you know ehether attack_weight in [attack] is used for anything else than disabling attacks= the attack.cpp code doesn't seem to use it except for comparing > 0. 20181006 12:55:55-!- irker126 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181006 13:13:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20181006 13:13:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20181006 13:20:04< mattsc> gfgtdf: I don’t know, but it does not seem to appear in src/ai at all. So my guess is that maybe it was used at some point but then removed? 20181006 13:22:28< mattsc> Or maybe it was intended to be an actual weight at some point, but that never got implemented. 20181006 13:26:15< mattsc> Hmm, yeah, looks like defense_weight is being used, but not attack_weight., and that it’s been like that since they were introduced in 2004 in 9befbee952a 20181006 13:27:32< mattsc> Umm, no, not true … 7a55e229924 20181006 13:42:56< mattsc> gfgtdf: this part of the code has been so heavily refactored that I cannot find what happened to that, but the bottom line seems to be that defender_weight is used as a weight, but attacker_weight only as an effective boolean. 20181006 13:47:00-!- irker521 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181006 13:47:00< irker521> wesnoth: Jyrki Vesterinen wesnoth:1.14 4a23c8bed18d / changelog.md src/theme.cpp: Fix #3599: crash with custom themes on desktop PCs https://github.com/wesnoth/wesnoth/commit/4a23c8bed18d280754f9f4f8ea35486fe7ad48c5 20181006 13:54:07< mattsc> Found it eventually. It was gotten rid of in 2006 when attack choice was switched to a simulation-type method. 20181006 13:54:08< mattsc> https://github.com/wesnoth/wesnoth/commit/64b6b55c03010b72f991c6a35dae5b6519e96468#diff-db869def8f9edca87c157f26f4a1d25bL445 20181006 13:54:25< mattsc> So that was a bit before my time :-P 20181006 14:32:03< irker521> wesnoth: Joseph Gelfand wesnoth:1.14 04674b6ae851 / src/ (image_modifications.cpp tests/test_image_modifications.cpp): Made Blitting more permissive (#3584) https://github.com/wesnoth/wesnoth/commit/04674b6ae8517bf77b000f28ae5e2ab4642689d3 20181006 14:35:22< irker521> wesnoth: Jyrki Vesterinen wesnoth:1.14 07fad7a7b552 / data/core/about.cfg: Add @JGelfand to credits https://github.com/wesnoth/wesnoth/commit/07fad7a7b552761ce37fd0280e25dd7ee8f40c5c 20181006 14:36:56< irker521> wesnoth: Joseph Gelfand wesnoth:master 325a42ee337c / src/ (image_modifications.cpp tests/test_image_modifications.cpp): Made Blitting more permissive (#3584) https://github.com/wesnoth/wesnoth/commit/325a42ee337c2de122ba34a17eee9074ab1bbcaf 20181006 14:36:58< irker521> wesnoth: Jyrki Vesterinen wesnoth:master 110bab74f0cc / data/core/about.cfg: Add @JGelfand to credits https://github.com/wesnoth/wesnoth/commit/110bab74f0cc1faad85fb3ffc60672a131fe26fa 20181006 14:44:41< irker521> wesnoth/wesnoth:master Nils Kneuper 9672652a6a updated Chinese (Traditional) translatio AppVeyor: All builds passed 20181006 15:23:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 15:35:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181006 15:43:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 15:47:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181006 16:32:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 16:32:48-!- Nokuro [~Nokuro@103.242.198.39] has quit [Quit: Leaving] 20181006 16:39:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20181006 16:43:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20181006 16:45:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 17:01:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20181006 17:01:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 17:06:05< irker521> wesnoth/wesnoth:1.14 Nils Kneuper 5b03a80bc2 updated Chinese (Traditional) translatio AppVeyor: All builds passed 20181006 17:17:47-!- Nokuro [~Nokuro@103.242.198.39] has joined #wesnoth-dev 20181006 17:18:13< Nokuro> Debug build is building fine, but release build showing lot of errors in test case 20181006 17:18:42< celticminstrel> 1.14 or master? 20181006 17:19:09< Nokuro> 1.14.5 20181006 17:19:30< Nokuro> I forgot it was master or 1.14 20181006 17:19:38< Nokuro> any way to check it now? 20181006 17:19:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 17:29:59< Nokuro> Can you confirm, it is happening to you and not only me? 20181006 17:30:32< celticminstrel> ...what are you even talking about now? 20181006 17:30:44< celticminstrel> ...oh, wait, I misread something. 20181006 17:30:49<+wesdiscordbot> Nokuro: you can check with git branch 20181006 17:30:49< celticminstrel> I can't check right now. 20181006 17:36:39< Nokuro> I downloaded from git branch, and spent entire day to modify engine to my liking, and when all is done, I thought I will play, but Error WML1: Test '%%H' returned !ERRORLEVEL!, expected %%G these popped up 20181006 17:37:03< Nokuro> till now I was using debug compilation, 20181006 17:37:43<+wesdiscordbot> there are also automated travis-ci builds that have been fine recently: https://travis-ci.org/wesnoth/wesnoth/builds 20181006 17:37:43< Nokuro> but it seems, release is broken, so someone can just compile the code and see it is really broken for everyone or ont 20181006 17:40:26< Nokuro> Wait, I am downloading git again, and retesting, and I will let all know 20181006 17:42:16<+wesdiscordbot> what OS are you on btw? 20181006 17:43:23< Nokuro> Me? Windows 10 x64\ 20181006 17:45:47<+wesdiscordbot> alright, in that case perhaps more relevant to you would be the appveyor builds: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/history 20181006 17:52:19< gfgtdf> mattsc: ok 20181006 17:59:42<+wesdiscordbot> @Pentarctagon how do I download using appveyor.com, 20181006 18:01:59< Nokuro> I confirm, it is not my fault, build is failing for release mode, WML_tests.cmd : error WML1: Test 'set_gold_in_prestart_one' returned 1, expected 0 {Millions of these kinds of errors} 20181006 18:19:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181006 18:20:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 18:38:27< zookeeper> @Yumi github doesn't want to cooperate with me right now, so mentioning a typo here instead of in a line comment: https://github.com/wesnoth/wesnoth/pull/3597/commits/744b286275acf66c4a567d5b8576917f0d29d596#diff-792f8c3dc6aa658f2da473b198217b28R738 "to early to" 20181006 18:39:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 18:49:09-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20181006 19:16:32<+wesdiscordbot> oops. 20181006 19:16:33<+wesdiscordbot> thanks 20181006 19:23:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20181006 19:33:54<+wesdiscordbot> @freiza It isn't something you can download, it's a service that can run automated builds on a variety of configurations. It's meant for catching issues that happen on systems that the devs may not use themselves. 20181006 19:55:17< irker521> wesnoth/wesnoth:1.14 newfrenchy83 20d2fb9fce Update README.md AppVeyor: All builds passed 20181006 20:11:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20181006 20:11:26-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 20:11:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 20:12:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 20:12:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 20:13:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 20:13:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 20:13:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20181006 20:14:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20181006 20:33:37-!- Nokuro [~Nokuro@103.242.198.39] has quit [Quit: Leaving] 20181006 20:49:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181006 20:51:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181006 20:56:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 21:15:39< zookeeper> we wouldn't just happen to have some great need for some abstract hex-tiling magic animations in mainline? https://www.dropbox.com/s/6ig157emefpo3bd/wesnothmagicfielddemopreview.gif?dl=0 20181006 21:15:43< zookeeper> that's just one example, i could make all sorts of different ones. i'm thinking that maybe the land of the dead in DM could benefit from some special fx like that. 20181006 21:21:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181006 21:22:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 21:24:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181006 21:24:51-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181006 21:25:18< celticminstrel> What should we rename failed master to BTW? 20181006 21:25:27< celticminstrel> old_master? 20181006 21:25:31< celticminstrel> failed_master? 20181006 21:25:36< celticminstrel> master_old? 20181006 21:30:02< mattsc> undead_master 20181006 21:30:20< celticminstrel> Haha 20181006 21:30:25<+wesdiscordbot> hehehe 20181006 21:32:07< celticminstrel> The other question is, who has the authority to unprotect the master branch? 20181006 21:32:29< celticminstrel> It should be done at some point soon in any case. No rush. 20181006 21:39:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20181006 22:05:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20181006 22:17:12<+wesdiscordbot> plural of naga, naga or nagas? 20181006 22:17:24< irker521> wesnoth/wesnoth:1.14 gfgtdf 317cf2c6ae dbg1 AppVeyor: All builds passed 20181006 22:19:09< zookeeper> both are used and seemingly valid. 20181006 22:23:21<+wesdiscordbot> okay 20181006 22:45:55<+wesdiscordbot> I'd call it old-master-a_r. "failed" is unnecessarily negative, and just "old" by itself is not very descriptive. 20181006 22:48:35< celticminstrel> I agree on "failed" TBH. 20181006 22:48:51<+wesdiscordbot> "ar-production-try-1" 20181006 22:49:12<+wesdiscordbot> idk I'd just advise against including 'master' in the name to avoid confusion 20181006 22:49:34< celticminstrel> Should I just rename it to accelerated_rendering_old, then? 20181006 22:49:48<+wesdiscordbot> I hate underscores 20181006 22:50:02<+wesdiscordbot> It's an extra keypress on my keyboard since I have to hold shift to get one from a hyphen 20181006 22:50:07< celticminstrel> Seems weird to use hyphens in branch names for some absurd reason. 20181006 22:50:11<+wesdiscordbot> I also hate "new" and "old" in branch names 20181006 22:50:14< celticminstrel> But sure I can use them anyway. 20181006 22:50:23<+wesdiscordbot> I'm just giving my opinion here 20181006 22:50:40<+wesdiscordbot> I don't have energy to be worried about Wesnoth development right now 20181006 22:50:47< celticminstrel> Pent seems to prefer it too. I myself prefer it in some places, so whatever. 20181006 22:55:50< celticminstrel> There. 20181006 23:10:35< celticminstrel> Now we need to: 1) announce that we're going to do a major history rewrite and also 2) unprotect the master branch so we can overwrite it. 20181006 23:10:55< celticminstrel> And also 3) thank jostephd for doing all this work to get a usable master. 20181006 23:11:46<+wesdiscordbot> celticminstrel: josteph's PR would still need to add in all of the 1.14-only commits, wouldn't it? since right now it's the 1.13.12 tag + master-minus-a_r. 20181006 23:11:58< celticminstrel> It might need to add some in. 20181006 23:12:02< celticminstrel> Not sure. 20181006 23:12:31< celticminstrel> Some of those commits were already forward-ported, after all. 20181006 23:12:39<+wesdiscordbot> ie: sinda/singalen's ios-pr-1 (probably not the real name) is 1.14 only. 20181006 23:12:43< celticminstrel> Hopefully, all of them were, but I can't be certain of that. 20181006 23:13:13<+wesdiscordbot> that recent more permissive blitting recently merged by jyrkive is also 1.14-only atm 20181006 23:13:14< celticminstrel> I see, that's certainly a big thing that definitely needs to be added. 20181006 23:13:28< celticminstrel> Pretty sure I saw the permissive blitting on master? 20181006 23:13:31<+wesdiscordbot> I'm sure there are more though 20181006 23:13:33<+wesdiscordbot> oh 20181006 23:13:37<+wesdiscordbot> my bad then 20181006 23:13:50< celticminstrel> "Made Blitting more permissive (#3584)" 20181006 23:14:00< celticminstrel> Just added to master today. 20181006 23:14:16<+wesdiscordbot> never mind about that one, in that case 20181006 23:17:24<+wesdiscordbot> and yeah, definitely a big thanks to @josteph for doing this. 20181006 23:17:51< celticminstrel> I was totally ready to do it my self... if only I could have found some time... but yeah, thanks. 20181006 23:30:50-!- travis-ci [~travis-ci@ec2-54-221-55-174.compute-1.amazonaws.com] has joined #wesnoth-dev 20181006 23:30:51< travis-ci> wesnoth/wesnoth#19569 (accelerated-rendering-attempt - 110bab7 : Jyrki Vesterinen): The build passed. 20181006 23:30:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/438131567 20181006 23:30:51-!- travis-ci [~travis-ci@ec2-54-221-55-174.compute-1.amazonaws.com] has left #wesnoth-dev [] --- Log closed Sun Oct 07 00:00:58 2018