--- Log opened Mon Oct 15 00:00:11 2018 --- Day changed Mon Oct 15 2018 20181015 00:00:11< irker379> wesnoth: pentarctagon wesnoth:master 68db6956d28e / / (6 files in 2 dirs): Revert "Update branch name: master -> development" https://github.com/wesnoth/wesnoth/commit/68db6956d28ebec147dbccfc8ba66e0877d816e3 20181015 00:14:44< irker379> wesnoth: pentarctagon wesnoth:master 9c2eb0fcb999 / docker/Dockerfile-base-1804-master: Re-add libsdl2-ttf to dockerfile. https://github.com/wesnoth/wesnoth/commit/9c2eb0fcb9994be41c0e752ca0acc1c3c9050070 20181015 00:22:53< irker379> wesnoth: Charles Dang wesnoth:master 4a487ad45145 / src/tests/gui/test_gui2.cpp: Update tests for acc3fe8 https://github.com/wesnoth/wesnoth/commit/4a487ad451457e48e4a6348f9db06d38f71506aa 20181015 00:22:56< irker379> wesnoth: Charles Dang wesnoth:master 7f2cf7429219 / src/tests/gui/test_gui2.cpp: Fixup 7767902 https://github.com/wesnoth/wesnoth/commit/7f2cf74292198e2b0e7e5cecb98672448f74bfb8 20181015 00:40:28-!- travis-ci [~travis-ci@ec2-54-90-206-224.compute-1.amazonaws.com] has joined #wesnoth-dev 20181015 00:40:29< travis-ci> wesnoth/wesnoth#19689 (master - 60fd504 : loonycyborg): The build was broken. 20181015 00:40:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/441428774 20181015 00:40:29-!- travis-ci [~travis-ci@ec2-54-90-206-224.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181015 00:47:13< irker379> wesnoth/wesnoth:1.14 josteph c3da7b8510 Merge remote-tracking branch 'jostephd/i AppVeyor: All builds passed 20181015 01:15:16-!- travis-ci [~travis-ci@ec2-54-167-147-211.compute-1.amazonaws.com] has joined #wesnoth-dev 20181015 01:15:17< travis-ci> wesnoth/wesnoth#19694 (master - 7f2cf74 : Charles Dang): The build failed. 20181015 01:15:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/441439417 20181015 01:15:17-!- travis-ci [~travis-ci@ec2-54-167-147-211.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181015 01:25:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181015 01:35:13< irker379> wesnoth/wesnoth:development newfrenchy83 02d5a87d90 Update abilities.cpp AppVeyor: 2/4 builds failed 20181015 01:35:14< irker379> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19500174 20181015 01:35:15< irker379> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19500179 20181015 01:36:00<+wesdiscordbot> alright, the problem is that the -lboost_thread option is missing from the wesnoth and boost_unit_tests linking. 20181015 01:36:19<+wesdiscordbot> which is because the Boost_THREAD_LIBRARY variable is empty 20181015 01:37:07<+wesdiscordbot> which is because that variable only exists in the entire repo at: https://github.com/wesnoth/wesnoth/blob/master/src/CMakeLists.txt#L79 20181015 01:37:19<+wesdiscordbot> no idea why that's the problem 20181015 01:37:35<+wesdiscordbot> or what happened to whatever was setting that variable before 20181015 02:16:02< irker379> wesnoth/wesnoth:development newfrenchy83 7224969f0b Update wesnoth.vcxproj AppVeyor: 2/4 builds failed 20181015 02:16:03< irker379> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19500309 20181015 02:16:04< irker379> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19500310 20181015 02:44:09< irker379> wesnoth: pentarctagon wesnoth:master 617c69529e5e / CMakeLists.txt: Fix cmake linking against libboost_thread. https://github.com/wesnoth/wesnoth/commit/617c69529e5e266aba94c16c1ea3970c755b5431 20181015 02:56:16<+wesdiscordbot> well, now both scons and cmake are getting the same massive segfault across multiple threads while trying to execute the boost unit tests 20181015 02:56:19<+wesdiscordbot> https://travis-ci.org/wesnoth/wesnoth/jobs/441462906#L989 20181015 02:56:33<+wesdiscordbot> https://travis-ci.org/wesnoth/wesnoth/jobs/441462908#L2381 20181015 02:56:52< celticminstrel> Fu~un! 20181015 02:57:27 * celticminstrel checks if there's a stack trace on Travis... 20181015 02:57:51<+wesdiscordbot> the mp tests are also failing with: Caught general 'St12out_of_range' exception: map::at 20181015 02:58:02<+wesdiscordbot> oof 20181015 02:58:04<+wesdiscordbot> https://travis-ci.org/wesnoth/wesnoth/jobs/441462908#L2352 20181015 02:58:36<+wesdiscordbot> the wml tests and play tests are succeeding though 20181015 02:58:45< celticminstrel> Whoa that's some stack trace. 20181015 02:59:05< celticminstrel> Okay so it's the MP Lobby test somehow. 20181015 02:59:24< celticminstrel> Quick-fix would probably be to disable that? 20181015 02:59:34< celticminstrel> Though I don't like that approach. 20181015 02:59:58<+wesdiscordbot> Yeah, there isn't much of a point in having unit tests if the knee-jerk reaction to them failing is to disable them 20181015 03:00:17< celticminstrel> Exactly. 20181015 03:01:00< celticminstrel> The exception doesn't seem to have a stack trace... 20181015 03:01:07-!- travis-ci [~travis-ci@ec2-54-90-206-224.compute-1.amazonaws.com] has joined #wesnoth-dev 20181015 03:01:08< travis-ci> wesnoth/wesnoth#19695 (master - 617c695 : pentarctagon): The build is still failing. 20181015 03:01:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/441462904 20181015 03:01:08-!- travis-ci [~travis-ci@ec2-54-90-206-224.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181015 03:01:35< celticminstrel> Is it because exceptions from the MP tests are not printed on Travis, or is it that the second stack trace overwrites the first? 20181015 03:02:06<+wesdiscordbot> I don't know. 20181015 03:02:10< celticminstrel> If the latter, disabling the MP Lobby test on a branch might reveal more about the out of range exception. 20181015 03:02:55<+wesdiscordbot> looks like the difference is that the mp tests don't use gdb at all 20181015 03:03:05< celticminstrel> I see. 20181015 03:05:50<+wesdiscordbot> the exception happens twice though, so that seems like it would mean it's on the client side 20181015 03:16:23<+wesdiscordbot> ...huh 20181015 03:16:53<+wesdiscordbot> ran the mp tests manually locally through gdb and got: Caught general 'St12out_of_range' exception: map::at [Inferior 1 (process 20859) exited with code 01] (gdb) bt No stack. 20181015 03:17:08< celticminstrel> ??? 20181015 03:17:38< celticminstrel> What does that mean... 20181015 03:18:27<+wesdiscordbot> You need to set gdb to catch the exception on throw 20181015 03:19:40<+wesdiscordbot> Otherwise odds are the program is exiting "normally" by reaching the outermost exception handler (which in the worst case might be in the code that calls main(). 20181015 03:31:03<+wesdiscordbot> I just deleted the catch block out of wesnoth.cpp 20181015 03:31:13<+wesdiscordbot> ended up with this backtrace: https://pastebin.com/UXdxsAzX 20181015 03:32:27<+wesdiscordbot> It's this rethrow: https://github.com/wesnoth/wesnoth/blob/617c69529e5e266aba94c16c1ea3970c755b5431/src/gui/widgets/window.cpp#L591 20181015 03:32:53<+wesdiscordbot> So the exception originates from somewhere else, but GUI2 catches and rethrows it. 20181015 03:34:57<+wesdiscordbot> if it helps, from the host it shows: host: creating a game host: configuring a game terminate called after throwing an instance of 'std::out_of_range' what(): map::at 20181015 03:35:05<+wesdiscordbot> and from the joiner it shows: 20181015 03:35:17<+wesdiscordbot> join: found a test game, joining... id = 1 join: got a leader select dialog... join: got to multiplayer join... terminate called after throwing an instance of 'std::out_of_range' what(): map::at 20181015 04:08:02< irker379> wesnoth/wesnoth:development loonycyborg 60fd504caf Add missing #include AppVeyor: 2/4 builds failed 20181015 04:08:03< irker379> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19502120 20181015 04:08:04< irker379> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19502122 20181015 04:10:35< irker379> wesnoth/wesnoth:master newfrenchy83 bcc022143e Merge pull request #7 from wesnoth/devel AppVeyor: vs2015/Release Failed 20181015 04:10:36< irker379> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19503791 20181015 04:26:46-!- celticminstrel is now known as celmin|sleep 20181015 04:50:18< irker379> wesnoth/wesnoth:master pentarctagon 617c69529e Fix cmake linking against libboost_threa AppVeyor: vs2015/Release Failed 20181015 04:50:19< irker379> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19505651 20181015 05:59:38<+wesdiscordbot> fwiw, local play seems to work fine. 20181015 06:17:53< irker379> wesnoth/wesnoth:1.14 nemaara 3ed6c06870 Elvish Hero: changed short sword name AppVeyor: All builds passed 20181015 06:32:23-!- Bhoren [~Bhoren@147.127.248.1] has joined #wesnoth-dev 20181015 07:05:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181015 07:49:50-!- Bhoren [~Bhoren@147.127.248.1] has quit [Quit: Leaving] 20181015 08:22:11< irker379> wesnoth/wesnoth:old_master_20181015 Iris Morelle 71a6daf961 wesnothd/fuh: Do not consider stale temp AppVeyor: All builds passed 20181015 09:10:36< irker379> wesnoth/wesnoth:master newfrenchy83 bcc022143e Merge pull request #7 from wesnoth/devel AppVeyor: 2/4 builds failed 20181015 09:10:37< irker379> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19503791 20181015 09:10:38< irker379> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19503792 20181015 09:50:19< irker379> wesnoth/wesnoth:master pentarctagon 617c69529e Fix cmake linking against libboost_threa AppVeyor: 2/4 builds failed 20181015 09:50:20< irker379> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19505651 20181015 09:50:21< irker379> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19505652 20181015 12:50:58-!- irker379 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181015 13:11:59-!- irker954 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181015 13:11:59< irker954> wesnoth/wesnoth:master newfrenchy83 986fac503e Update wesnoth.vcxproj AppVeyor: vs2017/Release Failed 20181015 13:11:59< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19510572 20181015 14:07:36< irker954> wesnoth/wesnoth:old_master_20181015 newfrenchy83 c307da4910 Update abilities.cpp AppVeyor: All builds passed 20181015 14:21:47< irker954> wesnoth/wesnoth:master newfrenchy83 f22f36f7b4 Merge pull request #9 from newfrenchy83/ AppVeyor: vs2015/Release Failed 20181015 14:21:48< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19515585 20181015 14:23:30<+wesdiscordbot> About that boost::thread stuff. In 3603 I excluded a change from boost::thread to std::thread because it broke test_gui2 in my build 20181015 14:24:12<+wesdiscordbot> It's possible that there were some other commits related to this one that were included, maybe removing boost::thread from scons/docker or something like that 20181015 15:12:11< irker954> wesnoth/wesnoth:master DisherProject a6c533b371 SotBE: Add [show_if] to the objectives t AppVeyor: vs2017/Release Failed 20181015 15:12:12< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19520159 20181015 15:58:44< irker954> wesnoth/wesnoth:master DisherProject 3070f52834 TRoW S14: Fix sea serpents placement AppVeyor: vs2015/Release Failed 20181015 15:58:45< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19520173 20181015 16:35:36< irker954> wesnoth/wesnoth:1.14 nemaara 96a85d0cbf Elvish Outrider description update AppVeyor: All builds passed 20181015 16:42:06< irker954> wesnoth/wesnoth:master josteph a6efc2fce8 Healing: Don't heal on side 1 turn 1. AppVeyor: vs2017/Release Failed 20181015 16:42:07< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19520254 20181015 16:54:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181015 17:16:28<+wesdiscordbot> Got the call stack for the MP test crash. 20181015 17:16:29<+wesdiscordbot> https://gist.github.com/jyrkive/2e44214cb792a9630b9f799d6400646a 20181015 17:16:49<+wesdiscordbot> Looks like some kind of merging mistake for the changes I made for chat message handling. 20181015 17:20:22<+wesdiscordbot> Yeah, the code in question was added in https://github.com/wesnoth/wesnoth/commit/4b84091c8b8c161215000b353e8eb797548cda56 20181015 17:30:44< irker954> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 99032c043ae0 / projectfiles/Xcode/ (Fix_Xcode_Dependencies Wesnoth.xcodeproj/project.pbxproj): Fix Xcode project after changes in master https://github.com/wesnoth/wesnoth/commit/99032c043ae0bdfe58c91af6c67544d56af04fb6 20181015 17:40:23<+wesdiscordbot> @hrubymar10 The Fix_Xcode_Dependencies changes there look wrong? 20181015 17:53:56< irker954> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 99032c043a Fix Xcode project after changes in maste AppVeyor: vs2017/Release Failed 20181015 17:53:57< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19524893 20181015 17:58:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181015 17:59:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181015 18:01:51<+wesdiscordbot> All right, found it. The reason why MP test doesn't pass in the development branch is that this commit is missing: https://github.com/wesnoth/wesnoth/commit/44feb05ae0b8bebbcfeb0b631d5937aff05ab9af 20181015 18:03:32<+wesdiscordbot> To be honest, I'm not sure if it's the right way to fix the tests (simply ignoring logging functionality for messages which appear before attempting to load logs). 20181015 18:10:02<+wesdiscordbot> Thinking about it, it is the correct fix. Will cherry-pick to the development branch. 20181015 18:11:53< irker954> wesnoth/wesnoth:master newfrenchy83 986fac503e Update wesnoth.vcxproj AppVeyor: 2/4 builds failed 20181015 18:11:54< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19510572 20181015 18:11:55< irker954> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19510573 20181015 18:15:00< irker954> wesnoth: Charles Dang wesnoth:master 663da0e0532b / src/gui/widgets/chatbox.cpp: Attempt to fix tests https://github.com/wesnoth/wesnoth/commit/663da0e0532b3c3f4818a55f559896fd290fffaf 20181015 18:15:13<+wesdiscordbot> Fix verified and pushed. 👍 20181015 18:40:08-!- travis-ci [~travis-ci@ec2-174-129-149-194.compute-1.amazonaws.com] has joined #wesnoth-dev 20181015 18:40:09< travis-ci> wesnoth/wesnoth#19709 (master - 663da0e : Charles Dang): The build is still failing. 20181015 18:40:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/441798005 20181015 18:40:09-!- travis-ci [~travis-ci@ec2-174-129-149-194.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181015 18:41:24< irker954> wesnoth/wesnoth:master Charles Dang 663da0e053 Attempt to fix tests AppVeyor: vs2015/Release Failed 20181015 18:41:25< irker954> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19526016 20181015 19:21:48< irker954> wesnoth/wesnoth:master newfrenchy83 f22f36f7b4 Merge pull request #9 from newfrenchy83/ AppVeyor: 2/4 builds failed 20181015 19:21:49< irker954> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19515585 20181015 19:21:50< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19515586 20181015 20:12:11< irker954> wesnoth/wesnoth:master DisherProject a6c533b371 SotBE: Add [show_if] to the objectives t AppVeyor: 2/4 builds failed 20181015 20:12:12< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19520159 20181015 20:12:13< irker954> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19520160 20181015 20:28:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181015 20:28:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181015 20:58:44< irker954> wesnoth/wesnoth:master DisherProject 3070f52834 TRoW S14: Fix sea serpents placement AppVeyor: 2/4 builds failed 20181015 20:58:45< irker954> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19520173 20181015 20:58:46< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19520177 20181015 21:42:07< irker954> wesnoth/wesnoth:master josteph a6efc2fce8 Healing: Don't heal on side 1 turn 1. AppVeyor: 2/4 builds failed 20181015 21:42:08< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19520254 20181015 21:42:09< irker954> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19520258 20181015 22:05:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181015 22:47:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181015 22:53:55< irker954> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 99032c043a Fix Xcode project after changes in maste AppVeyor: 1/2 builds failed 20181015 22:53:56< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19524893 20181015 23:11:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds] 20181015 23:30:43<+wesdiscordbot> I’ll look at std::thread again 20181015 23:41:24< irker954> wesnoth/wesnoth:master Charles Dang 663da0e053 Attempt to fix tests AppVeyor: 2/4 builds failed 20181015 23:41:25< irker954> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19526016 20181015 23:41:27< irker954> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19526018 --- Log closed Tue Oct 16 00:00:42 2018