--- Log opened Sun Oct 21 00:00:48 2018 20181021 00:01:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181021 00:13:00< irker492> wesnoth/wesnoth:1.14 josteph b69be3182b THoT S5: Unhide the villagers side once AppVeyor: All builds passed 20181021 00:23:15<+wesdiscordbot> ah 20181021 00:23:32<+wesdiscordbot> it seems that gregory committed my TSG edits 20181021 00:23:40-!- travis-ci [~travis-ci@ec2-54-224-55-144.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 00:23:41< travis-ci> gfgtdf/wesnoth#1383 (master - 22d6bbb : gfgtdf): The build is still failing. 20181021 00:23:41< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444226800 20181021 00:23:41-!- travis-ci [~travis-ci@ec2-54-224-55-144.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 00:23:43<+wesdiscordbot> in that case, someone could close issue #3499? 20181021 00:24:43<+wesdiscordbot> and possibly #3412 20181021 00:27:43<+wesdiscordbot> possibly? 20181021 00:28:51<+wesdiscordbot> I don't know if it really solves #3412 20181021 00:29:36<+wesdiscordbot> since there was also a discussion on whether thebig enemy should be an ordinary lich or an ancient lich 20181021 00:31:10<+wesdiscordbot> @Yumi At least mention the merge on that issue 20181021 00:31:33<+wesdiscordbot> Not having looked yet at the TSG stuff, I can only say, let's see if the OP there is satisfied 20181021 00:31:58<+wesdiscordbot> uh. 20181021 00:32:03<+wesdiscordbot> so do I just copy paste the commit link? 20181021 00:32:17<+wesdiscordbot> or like the commit id? 20181021 00:32:20<+wesdiscordbot> Link the merge commit, or the issue, whichever works better 20181021 00:32:36<+wesdiscordbot> You can put the commit hash, or the issue number with # in front, and they get autolinked 20181021 00:32:49<+wesdiscordbot> yeah the link worked just fine 20181021 00:33:04<+wesdiscordbot> I think sevu was the one who opened #3499, but the author of that document was a german translator 20181021 00:33:14<+wesdiscordbot> @Konrad2 ^ 20181021 00:33:28<+wesdiscordbot> there was a lot of awkward wording/grammatical errors in #3499, but had overall good suggestions 20181021 00:33:43<+wesdiscordbot> so I mostly just worked through the person's ideas rather than took the wording 20181021 00:33:49<+wesdiscordbot> taking the wording* 20181021 00:34:02<+wesdiscordbot> I see 20181021 00:34:34<+wesdiscordbot> now the only thing left is to finish up that elvish hero description 20181021 00:48:38-!- travis-ci [~travis-ci@ec2-54-211-21-201.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 00:48:40< travis-ci> gfgtdf/wesnoth#1384 (master - 205f0fc : gfgtdf): The build is still failing. 20181021 00:48:40< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444231714 20181021 00:48:40-!- travis-ci [~travis-ci@ec2-54-211-21-201.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 01:06:40< irker492> wesnoth: gfgtdf wesnoth:master dccda8294b94 / src/ (actions/attack.cpp actions/attack.hpp scripting/game_lua_kernel.cpp): allow wesnoth.simulate_combat to have defenders not on the map. https://github.com/wesnoth/wesnoth/commit/dccda8294b94555891b567a81d35da6439c34055 20181021 01:06:42< irker492> wesnoth: gfgtdf wesnoth:master 262549433f11 / src/ (scripting/game_lua_kernel.cpp units/unit.hpp): make wesnoth.simulate_combat a little more save against segfaults https://github.com/wesnoth/wesnoth/commit/262549433f11605bdb8354dc6e7cf9a17ad4004e 20181021 01:06:45< irker492> wesnoth: gfgtdf wesnoth:master 082aa2afe248 / src/ (display.cpp display.hpp overlay.hpp scripting/game_lua_kernel.cpp): add z_order attribute to wesnoth.add_tile_overlay fixes #3156 https://github.com/wesnoth/wesnoth/commit/082aa2afe24815c1c432341e9fa9dd0d84da04a8 20181021 01:06:46< irker492> wesnoth: gfgtdf wesnoth:master 7d93ce1604a4 / src/scripting/ (lua_common.cpp lua_common.hpp push_check.hpp): add luaW_table_get_def https://github.com/wesnoth/wesnoth/commit/7d93ce1604a43f5875c43edd9da1cc766ec7310c 20181021 01:06:49< irker492> wesnoth: gfgtdf wesnoth:master 6bdbcc1644bf / src/ (scripting/lua_unit.cpp units/unit.hpp): make max_moves a modifiable unit property https://github.com/wesnoth/wesnoth/commit/6bdbcc1644bf3dd04b0c8945ed5e3c1361ff82dc 20181021 01:27:51-!- gfgtdf [~Daniel@x4e320041.dyn.telefonica.de] has quit [Quit: Leaving] 20181021 02:25:20-!- travis-ci [~travis-ci@ec2-54-224-55-144.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 02:25:21< travis-ci> wesnoth/wesnoth#19836 (master - 6bdbcc1 : gfgtdf): The build is still failing. 20181021 02:25:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/444237356 20181021 02:25:21-!- travis-ci [~travis-ci@ec2-54-224-55-144.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 02:30:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181021 03:22:23< irker492> wesnoth/wesnoth:master josteph 589adab106 Don't show time of day under shroud AppVeyor: All builds passed 20181021 04:34:09-!- celticminstrel is now known as celmin|sleep 20181021 04:58:07< irker492> wesnoth/wesnoth:1.14 nemaara 75082f9e01 Elvish Sharpshooter: description wording AppVeyor: All builds passed 20181021 06:02:12<+wesdiscordbot> That wasn't me. 20181021 07:11:55< irker492> wesnoth/wesnoth:master newfrenchy83 aeb10b57c2 Update attack.cpp AppVeyor: All builds passed 20181021 08:15:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181021 08:35:33-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181021 08:39:52< irker492> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master e0f2ebeb5cfb / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode build https://github.com/wesnoth/wesnoth/commit/e0f2ebeb5cfb95f4bcab3e08f59740b91feab08a 20181021 09:15:24-!- travis-ci [~travis-ci@ec2-54-159-116-68.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 09:15:25< travis-ci> wesnoth/wesnoth#19840 (master - e0f2ebe : Martin Hrubý (hrubymar10)): The build was fixed. 20181021 09:15:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/444300611 20181021 09:15:25-!- travis-ci [~travis-ci@ec2-54-159-116-68.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 09:20:53< irker492> wesnoth/wesnoth:master DisherProject 9347860aae NR S13a: Improvement to the AIs AppVeyor: All builds passed 20181021 09:32:57-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has quit [Remote host closed the connection] 20181021 09:33:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 09:35:05-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181021 09:45:27-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.] 20181021 09:45:41-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181021 10:48:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds] 20181021 10:49:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 11:02:49-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 11:07:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20181021 11:19:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20181021 11:24:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 12:17:11< irker492> wesnoth/wesnoth:master josteph e8807cee7b fixup! Healing: Perform rest healing on AppVeyor: All builds passed 20181021 12:37:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20181021 12:53:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 13:08:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20181021 13:13:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 13:24:23< irker492> wesnoth: newfrenchy83 wesnoth:master b43c132b7098 / projectfiles/CodeBlocks/wesnoth.cbp: Update Code::Blocks project (#3640) https://github.com/wesnoth/wesnoth/commit/b43c132b7098d93b28319c4b019b46c3e6d1d985 20181021 13:39:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20181021 13:44:49-!- travis-ci [~travis-ci@ec2-54-159-116-68.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 13:44:49< travis-ci> gfgtdf/wesnoth#1386 (master - 2c3b852 : gfgtdf): The build is still failing. 20181021 13:44:49< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444361690 20181021 13:44:49-!- travis-ci [~travis-ci@ec2-54-159-116-68.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 13:48:36< irker492> wesnoth/wesnoth:1.14 josteph 63c972f6c2 Revert "Make the fire terrains actually AppVeyor: All builds passed 20181021 13:54:14-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 14:16:09-!- celmin|sleep is now known as celticminstrel 20181021 14:28:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20181021 14:28:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 14:41:14-!- gfgtdf [~Daniel@x4e3399ac.dyn.telefonica.de] has joined #wesnoth-dev 20181021 14:46:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20181021 14:50:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 14:54:24-!- travis-ci [~travis-ci@ec2-54-159-116-68.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 14:54:25< travis-ci> gfgtdf/wesnoth#1389 (master - e9cc739 : gfgtdf): The build is still failing. 20181021 14:54:25< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444372439 20181021 14:54:25-!- travis-ci [~travis-ci@ec2-54-159-116-68.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 14:56:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20181021 15:01:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 15:07:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20181021 15:07:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 15:12:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181021 15:13:04-!- travis-ci [~travis-ci@ec2-54-198-137-4.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 15:13:05< travis-ci> gfgtdf/wesnoth#1390 (master - ea76466 : gfgtdf): The build failed. 20181021 15:13:05< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444376937 20181021 15:13:05-!- travis-ci [~travis-ci@ec2-54-198-137-4.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 15:35:44-!- travis-ci [~travis-ci@ec2-54-242-123-36.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 15:35:45< travis-ci> gfgtdf/wesnoth#1391 (master - ffd73b8 : gfgtdf): The build is still failing. 20181021 15:35:45< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444383876 20181021 15:35:45-!- travis-ci [~travis-ci@ec2-54-242-123-36.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 15:43:01< irker492> wesnoth: gfgtdf wesnoth:master cfd81d38be3b / src/ (4 files in 2 dirs): add terrain_mask function to lua gamemap object. https://github.com/wesnoth/wesnoth/commit/cfd81d38be3bc40e1081f199a4aa5670eb8beb15 20181021 15:43:03< irker492> wesnoth: gfgtdf wesnoth:master 5d267578f40c / src/scripting/lua_unit.cpp: add goto_x/y to unit lua proxy https://github.com/wesnoth/wesnoth/commit/5d267578f40cdc5d45a22314f107ecb1c0433e72 20181021 15:43:05< irker492> wesnoth: gfgtdf wesnoth:master eee9214e9a42 / src/scripting/game_lua_kernel.cpp: small game_lua_kernel cleanup https://github.com/wesnoth/wesnoth/commit/eee9214e9a42b3681a10a42471399dc98a363521 20181021 15:43:07< irker492> wesnoth: gfgtdf wesnoth:master 0830d776ec71 / src/ (4 files in 2 dirs): sdfsdf https://github.com/wesnoth/wesnoth/commit/0830d776ec715dc22cc74fc1df2f49744e82e8a3 20181021 15:43:14< gfgtdf> fuck 20181021 15:43:19< gfgtdf> mistake during rebase 20181021 15:47:46<+wesdiscordbot> the commit itself, or just the message? 20181021 15:48:15< gfgtdf> 'sdfsdf' was suppsed to be merged into 'add terrain_mask function to lua gamemap object. 20181021 15:57:36< irker492> wesnoth/wesnoth:master nemaara 93a7093919 Added player note for THoT S12 update in AppVeyor: All builds passed 20181021 15:58:34< gfgtdf> hmm it seems like it somehow didnt apply my rebase list and instead gave a 'Could not execute editor' message (which i din't read). 20181021 16:24:02-!- travis-ci [~travis-ci@ec2-54-226-3-125.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 16:24:03< travis-ci> gfgtdf/wesnoth#1392 (master - 0830d77 : gfgtdf): The build was fixed. 20181021 16:24:03< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444393386 20181021 16:24:03-!- travis-ci [~travis-ci@ec2-54-226-3-125.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 17:09:38< irker492> wesnoth: josteph wesnoth:master 23bdbae16139 / changelog.md src/reports.cpp: Don't show time of day under shroud https://github.com/wesnoth/wesnoth/commit/23bdbae16139309409aa3fc7d6d166d4f75b46ca 20181021 17:10:40< irker492> wesnoth: josteph wesnoth:master 9eed54dc9a31 / data/campaigns/The_South_Guard/utils/sg_story.cfg: TSG S1: Punctuation fix https://github.com/wesnoth/wesnoth/commit/9eed54dc9a313658b2f6adbf95380a64f6a4b9b7 20181021 17:12:00< irker492> wesnoth: josteph wesnoth:1.14 5e6865acb408 / changelog.md src/reports.cpp: Don't show time of day under shroud https://github.com/wesnoth/wesnoth/commit/5e6865acb408e4c7eb665ccc1f941d8ce8f67414 20181021 17:12:02< irker492> wesnoth: josteph wesnoth:1.14 a3b2bfd9e30b / data/campaigns/The_South_Guard/utils/sg_story.cfg: TSG S1: Punctuation fix https://github.com/wesnoth/wesnoth/commit/a3b2bfd9e30bfd6cc30782f72bcb87b11312211d 20181021 17:33:32-!- gfgtdf [~Daniel@x4e3399ac.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20181021 17:37:35< irker492> wesnoth: josteph wesnoth:master 6df83fefa7f8 / src/play_controller.cpp: Healing: Do heal on turn 1. https://github.com/wesnoth/wesnoth/commit/6df83fefa7f8f2e8c46ba067a0bf1e2c59126edc 20181021 17:37:37< irker492> wesnoth: josteph wesnoth:master 024f3e1531f4 / src/play_controller.cpp: Healing: Don't heal on side 1 turn 1. https://github.com/wesnoth/wesnoth/commit/024f3e1531f49d997ceaaa8d622794d759326f92 20181021 17:37:39< irker492> wesnoth: josteph wesnoth:master 5ce2f2df37ab / src/ (game_state.cpp game_state.hpp play_controller.cpp play_controller.hpp): Healing: Instead of hardcoding a turn-and-side-number check, indirect through a https://github.com/wesnoth/wesnoth/commit/5ce2f2df37ab8faf7e2e9fa9f3ba46a4c038a4c0 20181021 17:37:41< irker492> wesnoth: josteph wesnoth:master 2f62302dc7cc / data/test/scenarios/heal.cfg wml_test_schedule: Healing: Add a unit test. https://github.com/wesnoth/wesnoth/commit/2f62302dc7cc39a8297ab70b287d1db083a42cce 20181021 17:37:43< irker492> wesnoth: josteph wesnoth:master 00c2ed6aa9af / data/test/scenarios/heal.cfg src/actions/heal.cpp src/play_controller.cpp: Healing: Perform rest healing on turn 2. https://github.com/wesnoth/wesnoth/commit/00c2ed6aa9af4c5f243276b5485625d285ff02ab 20181021 17:37:45< irker492> wesnoth: josteph wesnoth:master 20b76b32c010 / changelog.md: Healing: Update changelog https://github.com/wesnoth/wesnoth/commit/20b76b32c0101cee202ba6946eaa1f2e23b094c8 20181021 18:32:04-!- travis-ci [~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 18:32:05< travis-ci> wesnoth/wesnoth#19854 (master - 20b76b3 : josteph): The build passed. 20181021 18:32:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/444421260 20181021 18:32:05-!- travis-ci [~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 18:48:39< irker492> wesnoth/wesnoth:1.14 nemaara a698ce3f4b Elvish Captain: description wording AppVeyor: All builds passed 20181021 19:31:46< irker492> wesnoth: Steve Cotton wesnoth:1.14 64f7cc02dd2e / / (4 files in 4 dirs): DiD S12: Alternative campaign finish by letting the hero take the book https://github.com/wesnoth/wesnoth/commit/64f7cc02dd2e2d1dd794e70ea7ddd6a8d67f9c99 20181021 19:33:45< irker492> wesnoth: Steve Cotton wesnoth:master 30764fa76475 / / (4 files in 4 dirs): DiD S12: Alternative campaign finish by letting the hero take the book https://github.com/wesnoth/wesnoth/commit/30764fa76475f5f95b3f417e018a9375f3767eac 20181021 19:37:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20181021 19:54:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 20:08:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20181021 20:08:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 20:21:17< irker492> wesnoth/wesnoth:master newfrenchy83 5435359415 Update attack.cpp AppVeyor: All builds passed 20181021 21:20:03-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 245 seconds] 20181021 21:24:52-!- gfgtdf [~gfgtdf@tmo-104-108.customers.d1-online.com] has joined #wesnoth-dev 20181021 21:30:48-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20181021 21:31:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181021 21:40:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 21:44:46-!- gfgtdf [~gfgtdf@tmo-104-108.customers.d1-online.com] has quit [Quit: Leaving] 20181021 21:55:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181021 22:04:31< irker492> wesnoth/wesnoth:master gfgtdf 0830d776ec sdfsdf AppVeyor: All builds passed 20181021 22:15:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181021 22:20:27< irker492> wesnoth: josteph wesnoth:master 1876433e8fc7 / src/reports.cpp: Sidebar: Give vision a tooltip since it shows as "visi…" with no way to see the https://github.com/wesnoth/wesnoth/commit/1876433e8fc74afbce286ac6c3e175d9c5de4d7f 20181021 22:22:45< irker492> wesnoth: josteph wesnoth:1.14 efba33410ea6 / src/reports.cpp: Sidebar: Give vision a tooltip since it shows as "visi…" with no way to see the https://github.com/wesnoth/wesnoth/commit/efba33410ea6c683422bd2f6bd25505cce18644b 20181021 22:35:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181021 22:50:45-!- travis-ci [~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 22:50:46< travis-ci> gfgtdf/wesnoth#1393 (master - 4220658 : gfgtdf): The build was broken. 20181021 22:50:46< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444497938 20181021 22:50:46-!- travis-ci [~travis-ci@ec2-54-205-150-213.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 22:56:24-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20181021 22:57:30< celticminstrel> GitHub isn't letting me comment on the Marshal for some reason... :| 20181021 23:02:15-!- travis-ci [~travis-ci@ec2-54-242-123-36.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 23:02:16< travis-ci> gfgtdf/wesnoth#1394 (master - 68dbf1f : gfgtdf): The build was broken. 20181021 23:02:16< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444499728 20181021 23:02:16-!- travis-ci [~travis-ci@ec2-54-242-123-36.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 23:13:14< irker492> wesnoth/wesnoth:master newfrenchy83 a2d3aab5eb Update abilities.cpp AppVeyor: All builds passed 20181021 23:22:39< celticminstrel> ...even worse, it won't let me submit anything at all. o.O 20181021 23:22:45< celticminstrel> I even tried updating my browser. 20181021 23:27:58< celticminstrel> Looks like it might be a problem with the GitHub servers, so I guess I won't finish this review tonight, most likely. 20181021 23:35:18< irker492> wesnoth: gfgtdf wesnoth:master 50d94b33886e / src/scripting/game_lua_kernel.cpp: modifiable propertly game_config.do_healing https://github.com/wesnoth/wesnoth/commit/50d94b33886ee0f9edb6803e4e6c88d6ee08514b 20181021 23:35:20< irker492> wesnoth: gfgtdf wesnoth:master eba882b957fb / / (6 files in 3 dirs): implement [lua]name=, fixes #3381 https://github.com/wesnoth/wesnoth/commit/eba882b957fbfe6c464c7b23b3cd85771f8754a8 20181021 23:35:22< irker492> wesnoth: gfgtdf wesnoth:master a4b2818bc550 / src/ (9 files in 4 dirs): fix not generating leaders when loading a start of scenario save https://github.com/wesnoth/wesnoth/commit/a4b2818bc550ecda769079b9bb1c2fda4f8c5142 20181021 23:38:03<+wesdiscordbot> gfgtdf: so that would be like [lua] name="abc" code=<<...>> [/lua] ? 20181021 23:39:07< gfgtdf> Pentarctagon: hmm actully i never used it for names that don't start with '@' i think that willworks aswell 20181021 23:40:33<+wesdiscordbot> neat 20181021 23:40:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181021 23:46:43< gfgtdf> its mainly for debugging really, but it can also be used to make relertive directoresin dofile work 20181021 23:48:10< gfgtdf> that is [lua] name="@add-ons/addonname" code = << wesnoth.dofile("./lua/file.lua") >> ( the dofilepth relertive to add-ons/addonname) 20181021 23:49:57< celticminstrel> Wait wait. 20181021 23:50:19< celticminstrel> Is it the base directory for dofile/require/etc, or is it a filename for error messages? 20181021 23:50:34< celticminstrel> Also, why is there an @? 20181021 23:50:56-!- travis-ci [~travis-ci@ec2-54-204-159-67.compute-1.amazonaws.com] has joined #wesnoth-dev 20181021 23:50:57< travis-ci> gfgtdf/wesnoth#1397 (master - 24ee052 : gfgtdf): The build passed. 20181021 23:50:57< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/444508234 20181021 23:50:57-!- travis-ci [~travis-ci@ec2-54-204-159-67.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181021 23:52:06< gfgtdf> its both, the '@' marks it as a 'directory', i think othweise its onyl used as a name for debugging 20181021 23:52:49< celticminstrel> Not sure if I like this anymore... 20181021 23:53:46< celticminstrel> In the example you just gave, what would be used for the error message if the dofile failed (for example lua/file.lua does not exist)? 20181021 23:55:07< celticminstrel> I'm thinking it might be better to have two separate attributes here. 20181021 23:55:08< gfgtdf> hmm my example was wrong it should be [lua] name="@add-ons/addonname/name1" code = << wesnoth.dofile("./lua/file.lua") >> 20181021 23:56:10< celticminstrel> name: Used as the filename in error messages. Ideally, you could just write something like name="{FILE}" and have the name of the WMl file automatically substituted. 20181021 23:56:13< gfgtdf> this is really just passing it to the third arugment to lua load, making it babedifferntly woudl not onyl be totally diffent from what other lua code does it woudl also be harder to implement. 20181021 23:56:26< celticminstrel> basepath: Used as a base path for dofile and related functions. 20181021 23:57:14< gfgtdf> behave* 20181021 23:57:17< celticminstrel> Maybe also add a line attribute so that you can write line={LINE} and then the error messages actually give the true line numbers in the WML file (provided the code attribute is on the line after the line attribute). 20181021 23:57:26< celticminstrel> Though I'm not sure if that one is actually possible in the Lua API. 20181021 23:57:47< celticminstrel> By Lua API here I mean the lua* functions not the Wesnoth API. 20181021 23:58:39< celticminstrel> Is the @ part of said API? 20181021 23:59:30< celticminstrel> I mean, is the @ interpreted by lua_load? --- Log closed Mon Oct 22 00:00:49 2018