--- Log opened Mon Oct 22 00:00:49 2018 20181022 00:02:10< celticminstrel> gfgtdf: ? 20181022 00:03:22< gfgtdf> yes 20181022 00:03:39< celticminstrel> That makes this even worse then – it's exposing an internal implementation detaul. 20181022 00:03:46< celticminstrel> ^detail 20181022 00:04:25< gfgtdf> its not an impmentation detail its part of the lua api 20181022 00:04:38< celticminstrel> It's an implementation detail from the perspective of WML. 20181022 00:04:59< irker492> wesnoth: josteph wesnoth:master 606ac386e119 / data/core/help.cfg: Help: Fix fatal error in the "Recruiting and Recalling" page. https://github.com/wesnoth/wesnoth/commit/606ac386e119a3603fe8df8a4cf81e1ca11b4ef8 20181022 00:05:21<+wesdiscordbot> celticminstrel, Is there an easy way to know if there are more instances of 606ac38 lurking around? 20181022 00:05:24<+wesdiscordbot> the commit I just pushed 20181022 00:05:34<+wesdiscordbot> the @ path doesn't all .., right? 20181022 00:05:40<+wesdiscordbot> *allow 20181022 00:05:48< celticminstrel> Speaking of which, yeah, I would like to merge the PR that allows .. 20181022 00:06:10< celticminstrel> Or at least something else that does the same thing somehow. 20181022 00:06:20< celticminstrel> Someone pointed me to a Boost function I could try that might do the same thing. 20181022 00:06:25< celticminstrel> And be safer about it somehow. 20181022 00:06:51< celticminstrel> @Jostephd – I'm not sure what you're asking. 20181022 00:07:30<+wesdiscordbot> celticminstrel, the symptom of 606ac38 was that a particular help page wouldn't open in the help browser, do to syntax error in the markup 20181022 00:07:52<+wesdiscordbot> I don't know what introduced that syntax error but I'd like to verify that there aren't any more of it.. 20181022 00:07:57< celticminstrel> Ah. 20181022 00:07:59<+wesdiscordbot> .. without manually opening every help page in the game 20181022 00:08:00< celticminstrel> Um... 20181022 00:08:09< celticminstrel> Let's see... 20181022 00:08:16< celticminstrel> I can probably come up with a regex... 20181022 00:08:17<+wesdiscordbot> the accelerated-rendering-attempt branch used a different bold syntax than 1.14 20181022 00:08:26<+wesdiscordbot> I remember having solved conflicts related to this, in 3603 20181022 00:08:51< celticminstrel> <([a-z]+)>[^'<]+ 20181022 00:09:03< celticminstrel> I think that regex should find errors of the sort you fixed in that commit? 20181022 00:09:18< celticminstrel> Might be $1 instead of \1 in some regex flavours. 20181022 00:09:45< celticminstrel> Could also add = to the list of excluded characters, I suppose ... [^'=<] 20181022 00:10:54<+wesdiscordbot> I can deal with regex flavor differences 20181022 00:11:10< celticminstrel> ...WTH does "failing over a data storage system" even mean. https://status.github.com/messages 20181022 00:11:16<+wesdiscordbot> are you running it or should I? 20181022 00:11:32<+wesdiscordbot> "starting to use the slave as master" 20181022 00:11:35< celticminstrel> I wasn't planning to run the grep but I suppose I could if pull is still possible. 20181022 00:11:37<+wesdiscordbot> "to failover" 20181022 00:11:45< celticminstrel> Huh. 20181022 00:11:55<+wesdiscordbot> you don't have to use very latest master for this, anything post 3603 merge is enough 20181022 00:11:58< celticminstrel> Slave/master here refers to RAID stuff? 20181022 00:12:11<+wesdiscordbot> not necessarily 20181022 00:12:31<+wesdiscordbot> They keep all their data in two systems 20181022 00:12:34<+wesdiscordbot> changing over to a backup probably 20181022 00:12:36<+wesdiscordbot> two copies of everything 20181022 00:12:47<+wesdiscordbot> the primary copy is dead 20181022 00:12:57< celticminstrel> The master I currently have here on my Mac is apparently g110bab74f0c. 20181022 00:13:00<+wesdiscordbot> so they're making everything read and write from the secondary location instead 20181022 00:13:07< celticminstrel> And my HEAD is g1167e3e78ba. 20181022 00:13:23< celticminstrel> The former might be the old master branch. 20181022 00:13:48<+wesdiscordbot> eh, I can push it to gitlab for you 20181022 00:13:58< celticminstrel> Or you could run the grep? >_> 20181022 00:14:04<+wesdiscordbot> that too 20181022 00:14:17<+wesdiscordbot> in help.cfg only ? 20181022 00:14:24< celticminstrel> (I think my HEAD might actually be your new branch.) 20181022 00:14:36< celticminstrel> Um... maybe check reports.cpp too just in case? 20181022 00:14:42< celticminstrel> Or whatever the file was called. 20181022 00:14:52< celticminstrel> Where generated help topics are generated. 20181022 00:15:02< celticminstrel> Other than that I think everything is in help.cfg, yes. 20181022 00:15:12< celticminstrel> Except the drakes stuff which isn't even used right now. 20181022 00:15:48<+wesdiscordbot> so 20181022 00:15:51<+wesdiscordbot> tips.cfg uses 20181022 00:15:53<+wesdiscordbot> and it works 20181022 00:16:06< celticminstrel> That's Pango markup, probably. 20181022 00:16:15< celticminstrel> So don't touch it. 20181022 00:16:21<+wesdiscordbot> not planning to 20181022 00:16:26<+wesdiscordbot> Yes, it is Pango 20181022 00:16:27<+wesdiscordbot> but it saturates the signal 20181022 00:16:36< celticminstrel> Only the help uses this pseudo-WML markup. 20181022 00:17:04<+wesdiscordbot> so what tags should we look for? 20181022 00:17:10<+wesdiscordbot> (I call it pseudo-WML because each ... is parsed into a WML config, so eg text='stuff' is like [bold]text=stuff[/bold].) 20181022 00:17:33< celticminstrel> No there are about five or six tags. 20181022 00:17:42< celticminstrel> There's 20181022 00:17:50< celticminstrel> Either or , I forget. 20181022 00:17:58< celticminstrel> Um... what else was there... 20181022 00:18:12< celticminstrel> I think there was something like ? 20181022 00:18:24< celticminstrel> That's probably only used in generated markup though. 20181022 00:18:35< irker492> wesnoth: josteph wesnoth:master 6dacbb9e4646 / data/core/terrain.cfg: help: Fix broken link https://github.com/wesnoth/wesnoth/commit/6dacbb9e4646a7e9f187884bcdba8355ee202936 20181022 00:18:37< irker492> wesnoth: josteph wesnoth:master c9d4dde5aea8 / data/core/encyclopedia/geography.cfg: help: Add "Great River" topic https://github.com/wesnoth/wesnoth/commit/c9d4dde5aea89f5190b1ece8824d7ced3d51bc77 20181022 00:18:39< irker492> wesnoth: josteph wesnoth:master 5e92b8e80d84 / data/core/help.cfg: Help: Fix some broken links in the Gameplay section. https://github.com/wesnoth/wesnoth/commit/5e92b8e80d846cb130db1d3c58543a25fa8507fe 20181022 00:18:39< celticminstrel> Oh, 20181022 00:18:53< irker492> wesnoth: josteph wesnoth:1.14 cce1e5da9655 / data/core/terrain.cfg: help: Fix broken link https://github.com/wesnoth/wesnoth/commit/cce1e5da965560af8756b773bfe681af3caa9f6d 20181022 00:18:53<+wesdiscordbot> just give me one that I can grep the cpp for to find the others 20181022 00:18:55< irker492> wesnoth: josteph wesnoth:1.14 ea6fb9961db6 / data/core/encyclopedia/geography.cfg: help: Add "Great River" topic https://github.com/wesnoth/wesnoth/commit/ea6fb9961db6645592b90aa1d95c2ec7139de7c9 20181022 00:18:57< irker492> wesnoth: josteph wesnoth:1.14 fc6beef866a9 / data/core/help.cfg: Help: Fix some broken links in the Gameplay section. https://github.com/wesnoth/wesnoth/commit/fc6beef866a99b3b66b2cac0713852f6ae9bd74c 20181022 00:19:24< celticminstrel> Try grepping the C++ for "jump" or "ref"? (With the quotes.) 20181022 00:19:43< celticminstrel> It should be in src/help/ somewhere IIRC. 20181022 00:19:46<+wesdiscordbot> no matches for "jump" 20181022 00:19:51<+wesdiscordbot> oh wait 20181022 00:19:56<+wesdiscordbot> yes, no matches 20181022 00:20:07<+wesdiscordbot> "ref" only in theme.cpp 20181022 00:20:12< celticminstrel> Hmmm... 20181022 00:20:14<+wesdiscordbot> I'm grepping in master 20181022 00:21:00< celticminstrel> Oh yeah, when I said reports.cpp the file I was actually thinking of is help_topic_generators.cpp. Whoops! 20181022 00:21:16<+wesdiscordbot> Unless that got reverted along with A_R, all help markup processing is gone in master I think? 20181022 00:21:48< celticminstrel> @jostephd - Try grepping for TRY in src/help/ 20181022 00:22:09< celticminstrel> @shadowm - I imagine it did get reverted. 20181022 00:22:57< celticminstrel> You can probably ignore "text", I don't think that's ever used as a markup tag. 20181022 00:23:13<+wesdiscordbot> celticminstrel, I pushed 1.14 and master to my gitlab 20181022 00:23:37<+wesdiscordbot> TRY matched 20181022 00:23:58<+wesdiscordbot> ok, so what 's the next step 20181022 00:24:24< celticminstrel> Locate any instances of those as where the interior of the tag is not a space-separated sequence of attribute='content'. 20181022 00:24:28<+wesdiscordbot> <(ref|img|bold|italic|header|jump|format)> what after that 20181022 00:24:32< celticminstrel> The = and ' are required. 20181022 00:24:52< celticminstrel> So that's why I said [^'=>]+< 20181022 00:25:12< celticminstrel> Though that would not catch every possible error, but... 20181022 00:25:25< celticminstrel> It would at least catch cases where people thought they were writing HTML/XML. 20181022 00:25:26<+wesdiscordbot> none 20181022 00:26:06< celticminstrel> Just checking, but if you step back a commit does it match the one you just fixed? 20181022 00:26:18<+wesdiscordbot> I added foo in a new file and it did match that. πŸ˜ƒ 20181022 00:26:24< celticminstrel> 'kay. 20181022 00:26:32<+wesdiscordbot> line breaks? 20181022 00:26:37<+wesdiscordbot> between start and end "tag" 20181022 00:26:59< celticminstrel> Not sure if that's allowed, the line breaks might be equivalent to a space... 20181022 00:27:19<+wesdiscordbot> so we're done 20181022 00:27:20<+wesdiscordbot> thanks 20181022 00:27:22<+wesdiscordbot> ugh 20181022 00:27:28< celticminstrel> Hi Vultraz. 20181022 00:27:28<+wesdiscordbot> the old shitty markup is back 20181022 00:27:32< celticminstrel> Obviously. 20181022 00:27:44<+wesdiscordbot> smh 20181022 00:27:52< celticminstrel> I don't even know what that means. 20181022 00:27:58<+wesdiscordbot> shaking my head 20181022 00:27:59<+wesdiscordbot> Shaking my heads 20181022 00:28:02<+wesdiscordbot> *head 20181022 00:28:08< celticminstrel> Heh, multiple heads. 20181022 00:28:13<+wesdiscordbot> Can you two stop acting like an old married couple though 20181022 00:28:13<+wesdiscordbot> :bowman: 20181022 00:28:21< celticminstrel> Haha what. 20181022 00:32:34<+wesdiscordbot> you didn't port my help refactor 20181022 00:32:36<+wesdiscordbot> 😐 20181022 00:33:05<+wesdiscordbot> I worked for an entire week on that and you just threw it out. 20181022 00:33:22< celticminstrel> Well, I do intend to come back to that on a branch though. 20181022 00:33:35< celticminstrel> Not sure if that'll cover what you worked on for that week or not, but it's reasonably likely that it will. 20181022 00:33:45< celticminstrel> That is, providing I can actually find time to commit to it... 20181022 00:33:51<+wesdiscordbot> Are you talking to me or to celmin 20181022 00:34:38<+wesdiscordbot> In 1.14 there's a broken link from "Hitpoints and Experience" to "advancement", and changing the topic id from advancement to advancementx fixes it, any idea why? 20181022 00:34:45<+wesdiscordbot> it's fine in 1.15 20181022 00:35:47< celticminstrel> Nope. 20181022 00:37:01<+wesdiscordbot> I'll just let it be then, as it works in .15 20181022 00:39:24<+wesdiscordbot> Um, the links works for me on 1.14? 20181022 00:40:12<+wesdiscordbot> @shadowm Are you running --debug? 20181022 00:40:18<+wesdiscordbot> You need to run --debug to see broken links 20181022 00:40:21<+wesdiscordbot> No 20181022 00:40:25<+wesdiscordbot> I'm not 20181022 00:40:51<+wesdiscordbot> And the link works for me with or without -d 20181022 00:41:10<+wesdiscordbot> odd 20181022 00:41:30<+wesdiscordbot> I'm talking about the word "advance", the last word of "Hit-points and Experience" 20181022 00:41:43<+wesdiscordbot> Ah 20181022 00:41:46<+wesdiscordbot> It's broken in en_GB 20181022 00:41:48<+wesdiscordbot> Yes, it works for me, but I just found out I was n an older commit 20181022 00:41:51<+wesdiscordbot> Oh okay 20181022 00:42:01<+wesdiscordbot> opens the po file.. 20181022 00:42:52<+wesdiscordbot> is Wedge009 here ? 20181022 00:44:36<+wesdiscordbot> This kind of stuff you can just fix directly since it breaks the game 20181022 00:45:34<+wesdiscordbot> ah, ok 20181022 00:45:40<+wesdiscordbot> do I need to bump po-revision-date manually then? 20181022 00:46:34<+wesdiscordbot> No, just fix the string 20181022 00:46:45<+wesdiscordbot> It doesn't even need to be in a po editor 20181022 00:46:54<+wesdiscordbot> thanks 20181022 00:47:08< celticminstrel> I'd say wedge009 does need to at least be informed so it doesn't get reverted in the next po update. 20181022 00:47:23<+wesdiscordbot> For some reason my mind autocorrects po editor to pos editor 20181022 00:47:29<+wesdiscordbot> >.> 20181022 00:47:31<+wesdiscordbot> well, fixed locally 20181022 00:47:34<+wesdiscordbot> Translators will usually refetch the file but sure 20181022 00:47:38<+wesdiscordbot> I'll push when github are back 20181022 00:47:48<+wesdiscordbot> (Since we are in maintenance, this isn't a dev branch) 20181022 00:47:54< irker492> wesnoth: josteph wesnoth:1.14 ee73d92f4e6a / po/wesnoth-help/en_GB.po: en_GB: Fix broken link https://github.com/wesnoth/wesnoth/commit/ee73d92f4e6acc060899670f9f0f213d2607b269 20181022 00:48:21< irker492> wesnoth: josteph wesnoth:master 1f9a614dbc2d / po/wesnoth-help/en_GB.po: en_GB: Fix broken link https://github.com/wesnoth/wesnoth/commit/1f9a614dbc2d6a15b0655f00d608e0df2695bb02 20181022 00:48:38< celticminstrel> Ah, do they? Okat then. 20181022 00:48:48< celticminstrel> ^Okay 20181022 00:50:52<+wesdiscordbot> They kind of have to 20181022 00:51:05<+wesdiscordbot> link's still not working, odd 20181022 00:51:07<+wesdiscordbot> The expectation is that on the next pot update new strings will get added or stuff 20181022 00:51:22<+wesdiscordbot> You need to rebuild translations if you didn't do that already 20181022 00:51:41<+wesdiscordbot> I haven't. 20181022 00:51:44<+wesdiscordbot> Oops. 20181022 00:52:19<+wesdiscordbot> Fixed! πŸ˜ƒ 20181022 00:52:27<+wesdiscordbot> thanks again. 20181022 00:52:58<+wesdiscordbot> np 20181022 01:14:56< irker492> wesnoth: newfrenchy83 wesnoth:master 7f7217cf1573 / / (11 files in 7 dirs): Implement certain weapon specials in the engine https://github.com/wesnoth/wesnoth/commit/7f7217cf157393fc5fe3526a81181d95aa7fcbe9 20181022 01:50:17<+wesdiscordbot> @josteph duplicate the ID in the link 20181022 01:50:22<+wesdiscordbot> idid_name 20181022 01:50:39<+wesdiscordbot> @Vultraz what ? 20181022 01:50:47<+wesdiscordbot> I did that for the abilities, already pushed 20181022 01:50:54<+wesdiscordbot> nevermind 20181022 01:50:58< celticminstrel> I hope that commit doesn't still include a) any ability definitions in core/macros or b) removal of the commented [defense] implementation. 20181022 01:51:21<+wesdiscordbot> celticminstrel: my implementation was fine except we had no way to wrap around images. 20181022 01:51:37<+wesdiscordbot> and honestly we can design around that 20181022 01:51:42< celticminstrel> FTR I'm referring to newfrenchy's commit that Tad just pushed. 20181022 01:51:44<+wesdiscordbot> please don't throw out my code 20181022 01:52:01<+wesdiscordbot> git never throws out anything 20181022 01:52:03< celticminstrel> @Vultras - The plan with the help stuff was to put it back on a branch for later merging. 20181022 01:53:18<+wesdiscordbot> the code's still there on old_master_20181015. It can be added back to master whenever 20181022 01:53:23<+wesdiscordbot> i know 20181022 01:56:05<+wesdiscordbot> is github broken for anyone else? 20181022 01:56:09< celticminstrel> Yes. 20181022 01:56:14< celticminstrel> https://status.github.com/messages 20181022 01:56:22<+wesdiscordbot> no 20181022 01:56:25<+wesdiscordbot> hrr. 20181022 01:56:35<+wesdiscordbot> celmin: the old Elvish Hero revision had some problems 20181022 01:56:43< celticminstrel> The site seems to work for viewing, but I can't post comments on your PR, among other things. 20181022 01:57:08<+wesdiscordbot> mainly that giving up the shortsword and parrying and extra strikes don't have any in game equivalent 20181022 01:57:12<+wesdiscordbot> so could be misleading for people 20181022 01:57:30< celticminstrel> @Yumi - FTR I think I was slightly confused when I made that comment, seeing your proposed change and thinking it was a change that had actually been applied. 20181022 01:57:35<+wesdiscordbot> ah 20181022 01:57:53< celticminstrel> IOW, it should be read as applying to the change using a Finnish-derived word to describe the Heroes themselves. 20181022 01:58:06< celticminstrel> I have another comment pending on that matter. 20181022 01:58:09<+wesdiscordbot> anyway the new word can be anything 20181022 01:58:22< celticminstrel> So once GitHub works again I'll finish reviewing it and you can look at all my comments. 20181022 01:58:26<+wesdiscordbot> I don't honestly care what it is as long as it has some linguistic basis 20181022 01:58:55<+wesdiscordbot> celticminstrel, would it help if Yumi sent you the current version of the branch 20181022 01:59:00<+wesdiscordbot> so you could review now 20181022 01:59:08< celticminstrel> No, it's not that I can't see it, it's that GitHub won't let me post comments. 20181022 01:59:18< celticminstrel> I could review it now and comment on IRC, I suppose. 20181022 01:59:25< celticminstrel> If you want it to be merged asap. 20181022 01:59:53< celticminstrel> Some of the comments are a little long though so it might be better to see them on GitHub? 20181022 01:59:58<+wesdiscordbot> doesn't matter 20181022 02:00:07< celticminstrel> Then I'll wait for GitHub to be working again, I guess. 20181022 02:00:23<+wesdiscordbot> I'm probably not going to change the other descriptions much more though 20181022 02:00:44<+wesdiscordbot> and I'm not doing an outrider one for the moment, since I really can't think of anything interesting 20181022 02:00:47< celticminstrel> Most of my comments so far were small things, I think. 20181022 02:01:11< celticminstrel> The proposed Sarkan or whatever it was change is the only long one, probably. 20181022 02:01:31<+wesdiscordbot> haihai 20181022 02:02:13<+wesdiscordbot> anyway it hasn't even been sitting around nearly as long as my THoT PR, so waiting a little bit is nbd 20181022 02:17:49< irker492> wesnoth/wesnoth:1.14 Steve Cotton 64f7cc02dd DiD S12: Alternative campaign finish by AppVeyor: All builds passed 20181022 02:27:55< irker492> wesnoth: mattsc wesnoth:1.14 4450da2b807a / data/ai/lua/ai_helper.lua: ai_helper.move_unit_out_of_way: prevent potential for divide-by-zero https://github.com/wesnoth/wesnoth/commit/4450da2b807a2a7972ace2b85034c77359f1012b 20181022 02:31:32< irker492> wesnoth: mattsc wesnoth:master 09e389166826 / data/ai/lua/ai_helper.lua: ai_helper.move_unit_out_of_way: prevent potential for divide-by-zero https://github.com/wesnoth/wesnoth/commit/09e389166826dcb1e622e97fc77dffba68eca305 20181022 02:51:49-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Read error: Connection reset by peer] 20181022 03:37:28< celticminstrel> Guess it's unlikely that I'll finish that review today. I'll try to get to it tomorrow. 20181022 03:39:44-!- celticminstrel is now known as celmin|sleep 20181022 03:54:06< wedge009> Is https://github.com/wesnoth/wesnoth broken for anyone? 20181022 03:54:49< wedge009> Oh, just saw celmin's affirmation. 20181022 03:56:34< wedge009> @josteph What's broken? 20181022 03:57:15< wedge009> Oh, I can see that commit. That should be fine - looks like something that was there before I took over en_GB. 20181022 04:00:46< wedge009> Ditto celticminstrel's remarks about being unable to comment on GH due to the data rebuild. 20181022 04:30:46< irker492> wesnoth/wesnoth:master josteph b47152a6a9 fixup! Show the alignment the selected u AppVeyor: All builds passed 20181022 04:33:42< irker492> wesnoth: Wedge009 wesnoth:master 6ef7dd77ab7f / projectfiles/VC14/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Properly update MSVC project files for 3d1e3b36 and e0234608. https://github.com/wesnoth/wesnoth/commit/6ef7dd77ab7f3e64c74f1153a00b332361197f37 20181022 05:17:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181022 05:44:36-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-bgywucuvteyasckf] has quit [Quit: PanicBNC - https://PanicBNC.net - currently sucks] 20181022 06:56:21-!- valdar [~atarocch@93.56.164.28] has quit [Ping timeout: 252 seconds] 20181022 07:24:18< irker492> wesnoth/wesnoth:master josteph 0e0dbd164d Healing: Display healing animation if th AppVeyor: All builds passed 20181022 08:45:54-!- valdar [atarocch@nat/redhat/x-wahgamxvkssavtgx] has joined #wesnoth-dev 20181022 08:54:00< irker492> wesnoth/wesnoth:1.14 mattsc 4450da2b80 ai_helper.move_unit_out_of_way: prevent AppVeyor: All builds passed 20181022 10:47:48<+wesdiscordbot> what's the difference between user_team_name and side_name? 20181022 11:11:10< irker492> wesnoth/wesnoth:master Wedge009 6ef7dd77ab Properly update MSVC project files for 3 AppVeyor: All builds passed 20181022 11:34:25<+wesdiscordbot> one has to do with MP 20181022 11:34:26<+wesdiscordbot> it's a mess 20181022 11:34:39<+wesdiscordbot> definitely an area for redesign 20181022 11:41:12< zookeeper> side_name is a name for the side, if you want it to be something other than the leader name, no? 20181022 11:44:56<+wesdiscordbot> I thought this is user_team_name. That's at least what gets shown in the statistics, when looking at the teams gold/recruitment numbers and such, to be able to have different names for sides even though they have the same team_name. side_name, according to the reference, is the name of a side that e.g. gets shown in "new turn dialoque", introduced in 1.13.5. I wonder why one of those can't be used for both. 20181022 11:50:17< zookeeper> because you might want the side name to be "monsters" and the team name to be "evil"? 20181022 11:54:16< zookeeper> anyway, it's a new'ish feature someone wanted, i don't recall where everywhere side_name is actually used and whether it should override user_team_name in some other places where it currently doesn't.. 20181022 12:43:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181022 12:47:40-!- gfgtdf [~androirc@ersc159.goemobile.de] has joined #wesnoth-dev 20181022 12:49:09< gfgtdf> user team name is the name dearibing the alliance (team_name) the side is in 20181022 12:55:07-!- valdar [atarocch@nat/redhat/x-wahgamxvkssavtgx] has quit [Ping timeout: 240 seconds] 20181022 12:56:15-!- celmin|sleep is now known as celmin|away 20181022 12:57:51< gfgtdf> Describing* 20181022 13:05:47<+wesdiscordbot> So it counts for all sides of a team? Okay that makes sense, then. 20181022 13:36:40< gfgtdf> tge difference between user_team_name and side_name is logocially quite clear, but it's often confusing because there are no good words for it, 'team', 'side', 'alliance' etc are all somewhat unclear. 20181022 13:52:42< zookeeper> umm. team is a team, side is a side. there is no "alliance". 20181022 14:00:24-!- gfgtdf [~androirc@ersc159.goemobile.de] has quit [Read error: Connection reset by peer] 20181022 14:12:04-!- irker492 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181022 14:45:36<+wesdiscordbot> It's easy to confuse. If one doesn't strictly tie the english words to the game featurs, (or if one has no WML knowledge), one could say a side is the team you play. 20181022 14:46:54<+wesdiscordbot> And side is a strange word, one wouldn't use that intuitively. 20181022 14:48:56<+wesdiscordbot> As team is a term which suits for both, the sides and the 'team', it's avoided in the German translation. Instead another uncommon word – party – is used for side, and alliance for the team. 20181022 15:23:35< zookeeper> sure, my point was only that the terminology in wesnoth is very clear. except in the source code, where AFAIK "team" is (still?) used in a lot of places to refer to sides. 20181022 15:24:53< zookeeper> (of course, it might not be particularly clear to a player with no WML knowledge whatsoever) 20181022 15:29:21<+wesdiscordbot> It may be clear for you, but it’s definitely not objectively clear. 20181022 15:29:29<+wesdiscordbot> Especially when it comes to what is used where 20181022 15:29:36<+wesdiscordbot> Even I have trouble keeping them straight 20181022 15:39:52-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20181022 15:44:52< zookeeper> excepting naming conventions in source code (and perhaps some introduced by translations), what inconsistencies/ambiguities are there? AFAIK the in-game UI consistently calls sides "sides" and never "teams", or vice versa. if you mean that words like "allies" are used a lot (objectives, etc), then sure, i agree that's one source of terminology confusion. 20181022 15:48:45< gfgtdf> i'm qute sure thatnot even the ingame ui is totally conistent with that,. 20181022 15:49:09< gfgtdf> for example this one https://github.com/wesnoth/wesnoth/blob/master/src/hotkey/hotkey_command.cpp#L138 20181022 15:50:14< zookeeper> ah, indeed that should be fixed. 20181022 16:02:48< gfgtdf> ok #3607 just happend to me aswell it is totally annoying. 20181022 17:02:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181022 17:14:47-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 240 seconds] 20181022 17:20:26-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20181022 17:49:29-!- punsaker is now known as Polsaker 20181022 18:49:58-!- irker960 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181022 18:49:58< irker960> wesnoth: newfrenchy83 wesnoth:master f24f10c61414 / src/actions/attack.cpp: Update attack.cpp https://github.com/wesnoth/wesnoth/commit/f24f10c614149bd0a1ac9687f8a6222f9657c287 20181022 18:54:09< irker960> wesnoth: newfrenchy83 wesnoth:master c926f2c71820 / projectfiles/CodeBlocks/wesnoth.cbp: Update wesnoth.cbp https://github.com/wesnoth/wesnoth/commit/c926f2c7182063c7de76b1abe5c56f548542295c 20181022 19:38:08< irker960> wesnoth: Jyrki Vesterinen wesnoth:master cca79afe4b26 / / (4 files in 4 dirs): Add an option to disable FPS limiter https://github.com/wesnoth/wesnoth/commit/cca79afe4b263187a54b73042a9bc7eaa46986e7 20181022 19:50:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181022 19:50:43< irker960> wesnoth: gfgtdf wesnoth:master c70143077c8e / data/multiplayer/scenarios/test_lua_mapgen.lua: fix test_lua_mapgen.lua after and -> all rename https://github.com/wesnoth/wesnoth/commit/c70143077c8ed9c31bd8e609cf544d0b9fdc620e 20181022 22:25:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181022 22:52:47-!- irker960 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] --- Log closed Tue Oct 23 00:00:51 2018