--- Log opened Tue Oct 23 00:00:51 2018 20181023 00:10:44-!- TC01 [~quassel@venus.arosser.com] has quit [Read error: Connection reset by peer] 20181023 00:12:16-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20181023 00:23:32-!- celmin|away is now known as celticminstrel 20181023 00:57:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181023 00:58:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20181023 01:19:04<+wesdiscordbot> celmin celmin celmin, ya here? 20181023 01:19:57< celticminstrel> ? ? ? 20181023 01:21:04<+wesdiscordbot> your fighter description revision 20181023 01:21:18<+wesdiscordbot> Elvish swordsmanship is known for its emphasis on swift, agile strikes, generating less power than human or orcish warriors, but also leaving less time to react and counter. 20181023 01:21:23<+wesdiscordbot> I assume you mean that but -> so 20181023 01:21:36<+wesdiscordbot> ? 20181023 01:23:20< celticminstrel> That doesn't seem like it was what I was thinking of... 20181023 01:24:14<+wesdiscordbot> "Among elves, swordplay is most commonly practiced by rangers and border patrols, who serve primarily as guardians of the forests and more occasionally as small squads for intrusions into other territories. Elvish swordsmanship is known for its emphasis on swift, agile strikes, generating less power than human or orcish warriors, but also leaving less time to react and counter. Most elves can learn the basics of swordplay 20181023 01:24:14<+wesdiscordbot> relatively quickly and will readily pick up the blade when confronted with battle." 20181023 01:24:17<+wesdiscordbot> that's the whole desc 20181023 01:24:22<+wesdiscordbot> I think that's the only but in there 20181023 01:24:45< celticminstrel> ... 20181023 01:24:56< celticminstrel> DId I... post the comment on the wrong description somehow? :S 20181023 01:25:01<+wesdiscordbot> 🤔 20181023 01:25:18<+wesdiscordbot> you probably meant champion 20181023 01:25:25< celticminstrel> Could be. 20181023 01:25:28<+wesdiscordbot> Naturally, most of these warriors live short lives devoted to honing their swordsmanship in an effort to conquer the battlegrounds, but only the most talented thereof are capable of surviving constant combat and earning the title of ‘Champion’. 20181023 01:25:31<+wesdiscordbot> but -> so makes sense 20181023 01:25:41<+wesdiscordbot> well 20181023 01:25:45<+wesdiscordbot> I still prefer but 20181023 01:25:59< celticminstrel> That's likely the one I was thinking of, but just to be sure I'll take another look in a bit. 20181023 01:26:06<+wesdiscordbot> okay 20181023 01:26:23<+wesdiscordbot> I like the original wording in the Avenger more, took care of the other changes you wanted 20181023 01:33:30-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Read error: Connection reset by peer] 20181023 01:42:55< celticminstrel> @Yumi - Confirmed, I meant to post that comment on the champion. 20181023 01:43:22< celticminstrel> Probably messed up because I dismissed the review and started over after the website issues, because it said I had 8 comments when I could only see 5. 20181023 01:43:27< celticminstrel> Or 6. 20181023 01:43:43< celticminstrel> Also noticed another thing in the Avenger description which I commented on. 20181023 02:06:42<+wesdiscordbot> okay 20181023 02:06:51<+wesdiscordbot> I still prefer but 20181023 02:09:20<+wesdiscordbot> I'll think about it, might be better to add a semicolon instead 20181023 02:09:23<+wesdiscordbot> or a colon 20181023 02:11:16 * celticminstrel shrug 20181023 02:53:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181023 04:25:33-!- celticminstrel is now known as celmin|sleep 20181023 06:13:49-!- irker369 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181023 06:13:49< irker369> wesnoth/wesnoth:master newfrenchy83 f24f10c614 Update attack.cpp AppVeyor: All builds passed 20181023 06:54:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181023 08:21:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181023 08:24:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181023 08:46:13< irker369> wesnoth/wesnoth:master newfrenchy83 c926f2c718 Update wesnoth.cbp AppVeyor: All builds passed 20181023 10:34:38-!- valdar [~atarocch@93.56.164.28] has joined #wesnoth-dev 20181023 11:13:48< irker369> wesnoth/wesnoth:master newfrenchy83 f24f10c614 Update attack.cpp AppVeyor: All builds passed 20181023 12:33:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181023 13:05:28-!- celmin|sleep is now known as celmin|away 20181023 13:55:20-!- gfgtdf [~androirc@tmo-122-12.customers.d1-online.com] has joined #wesnoth-dev 20181023 14:14:25-!- gfgtdf [~androirc@tmo-122-12.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20181023 14:14:54-!- irker369 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181023 14:18:35-!- gfgtdf [~androirc@ersc144.goemobile.de] has joined #wesnoth-dev 20181023 14:44:12-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has quit [Remote host closed the connection] 20181023 14:46:21-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181023 14:54:15-!- gfgtdf [~androirc@ersc144.goemobile.de] has quit [Remote host closed the connection] 20181023 14:54:45-!- gfgtdf [~androirc@ersc144.goemobile.de] has joined #wesnoth-dev 20181023 15:14:22-!- gfgtdf [~androirc@ersc144.goemobile.de] has quit [Remote host closed the connection] 20181023 16:17:55-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20181023 16:18:45-!- irker949 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181023 16:18:45< irker949> wesnoth/wesnoth:master newfrenchy83 f24f10c614 Update attack.cpp AppVeyor: All builds passed 20181023 16:41:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181023 16:47:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181023 16:57:56-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 260 seconds] 20181023 17:33:56< irker949> wesnoth/wesnoth:master newfrenchy83 c926f2c718 Update wesnoth.cbp AppVeyor: All builds passed 20181023 18:46:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181023 18:47:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181023 18:52:06<+wesdiscordbot> https://github.com/wesnoth/wesnoth/commit/082aa2afe24815c1c432341e9fa9dd0d84da04a8 causes UB (due to an off-by-one error, it dereferences the end iterator). 20181023 18:53:22<+wesdiscordbot> I thought about just fixing it, but determined that this approach is flawed to begin with. std::multimap (which is what display::get_:overlays() returns) is not supposed to have values for the same key ordered how the programmer wants. 20181023 18:53:35<+wesdiscordbot> I'll try replacing it with a more appropriate container. 20181023 19:00:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181023 19:01:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181023 19:23:02-!- gfgtdf [~androirc@tmo-122-12.customers.d1-online.com] has joined #wesnoth-dev 20181023 19:25:18<+wesdiscordbot> gfgtdf: Let's return to this channel. 20181023 19:25:46<+wesdiscordbot> You're correct that std::multimap guarantees that it retains the original order starting from C++11. 20181023 19:26:11<+wesdiscordbot> Still, from what I can tell, the values are not really supposed to be reordered afterwards. 20181023 19:27:01<+wesdiscordbot> I'm already replacing the multimap with std::map> and many tasks (such as placing the overlay to the right index) are much easier with it. 20181023 19:30:47< gfgtdf> I see no reason why re ordering would not work i mean I'm not even inserting stuff for that and the map should not care what i do to the values, but i agree that the map solution is cleaner. 20181023 19:32:11<+wesdiscordbot> Yeah, it should work. It just feels ugly that you even need to resort to editing the elements themselves because you can't reorder them. 20181023 19:51:54< irker949> wesnoth: Jyrki Vesterinen wesnoth:master fa12518f86df / src/ (display.cpp display.hpp editor/map/map_context.cpp editor/map/map_context.hpp): Changed data type of display::get_overlays() https://github.com/wesnoth/wesnoth/commit/fa12518f86dfb5039d11542450eb8a3116de133c 20181023 20:08:50< gfgtdf> thx for fixing that 20181023 20:14:34-!- gfgtdf [~androirc@tmo-122-12.customers.d1-online.com] has quit [Remote host closed the connection] 20181023 20:52:26< irker949> wesnoth/wesnoth:1.14 nemaara 2d5204703f Elvish Champion: description update AppVeyor: vs2015/Release Failed 20181023 20:52:27< irker949> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19705521 20181023 21:27:48-!- gfgtdf [~androirc@134.76.63.8] has joined #wesnoth-dev 20181023 21:40:35-!- gfgtdf [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20181023 21:40:55-!- gfgtdf [~androirc@134.76.63.8] has joined #wesnoth-dev 20181023 22:00:16-!- gfgtdf [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20181023 22:01:17-!- gfgtdf [~androirc@134.76.63.8] has joined #wesnoth-dev 20181023 22:01:48<+wesdiscordbot> @Yumi In the Avenger description in 3610, could the part about "capable of assassinating enemies from the shadows without ever having to break stealth" be confused for a gameplay mechanic? Sorry for not noticing this in my previous passes. 20181023 22:04:48< irker949> wesnoth/wesnoth:master Jyrki Vesterinen cca79afe4b Add an option to disable FPS limiter AppVeyor: All builds passed 20181023 22:07:43-!- gfgtdf [~androirc@134.76.63.8] has quit [Ping timeout: 246 seconds] 20181023 22:26:08-!- travis-ci [~travis-ci@ec2-54-198-37-57.compute-1.amazonaws.com] has joined #wesnoth-dev 20181023 22:26:09< travis-ci> gfgtdf/wesnoth#1401 (master - 237ffc2 : gfgtdf): The build passed. 20181023 22:26:09< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/445358214 20181023 22:26:09-!- travis-ci [~travis-ci@ec2-54-198-37-57.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181023 22:53:53-!- travis-ci [~travis-ci@ec2-54-87-121-75.compute-1.amazonaws.com] has joined #wesnoth-dev 20181023 22:53:54< travis-ci> gfgtdf/wesnoth#1402 (skip_unit_attribute - 4cb9e95 : gfgtdf): The build passed. 20181023 22:53:55< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/445364583 20181023 22:53:55-!- travis-ci [~travis-ci@ec2-54-87-121-75.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181023 23:12:40-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20181023 23:13:04< gfgtdf> when you get out of sync errors in singleplayer... 20181023 23:18:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20181023 23:38:35-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Wed Oct 24 00:00:52 2018