--- Log opened Wed Oct 24 00:00:52 2018 20181024 00:03:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181024 00:06:25-!- celmin|away is now known as celticminstrel 20181024 01:04:50-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 244 seconds] 20181024 01:05:04-!- irker949 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181024 01:52:32-!- irker674 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181024 01:52:32< irker674> wesnoth/wesnoth:1.14 nemaara 2d5204703f Elvish Champion: description update AppVeyor: 1/4 builds failed 20181024 01:52:32< irker674> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19705521 20181024 02:07:23-!- oldlaptop [~quassel@45.63.78.126] has quit [Remote host closed the connection] 20181024 02:38:36-!- oldlaptop [~quassel@45.63.78.126] has joined #wesnoth-dev 20181024 02:50:16< celticminstrel> Alright, I'm gonna force-push All The Things so shadowm or Soliton or someone may wish to mute/kick irker. 20181024 02:50:24< celticminstrel> @shadowm for Discord notifications 20181024 02:50:36<+wesdiscordbot> no need 20181024 02:50:41<+wesdiscordbot> discord only displays a max of 6 20181024 02:50:48<+wesdiscordbot> It's not about that 20181024 02:50:50<+wesdiscordbot> It's about IRC 20181024 02:50:55 * celticminstrel points at "irker" in my comment. 20181024 02:51:05-!- mode/#wesnoth-dev [+o shadowm] by ChanServ 20181024 02:51:11-!- mode/#wesnoth-dev [+zq irker*!*@*] by shadowm 20181024 02:51:11<@shadowm> Done 20181024 02:51:23<+wesdiscordbot> oh 20181024 02:51:25<+wesdiscordbot> makes sense 20181024 02:51:27<+wesdiscordbot> nvm 20181024 02:52:20<@shadowm> I'm not sure force pushes actually generate notification spam actually but we'll see 20181024 02:52:34<@shadowm> True merges do though 20181024 02:52:51<@shadowm> Okay yeah I see notification spam 20181024 02:55:18<+wesdiscordbot> checks 20181024 02:56:52<+wesdiscordbot> looks like you pulled in a lot of display.cpp changes 20181024 02:57:27< celticminstrel> Did I? 20181024 02:57:38<+wesdiscordbot> yes 20181024 02:57:45< celticminstrel> I doubt that gui2_help branch will even compile ATM in any case. 20181024 02:58:11< celticminstrel> If you see a commit that shouldn't be there, or if you can remember a commit that should be there but isn't, please post it on the PR. 20181024 02:58:21<+wesdiscordbot> rubs her temples 20181024 02:58:28< celticminstrel> I think perhaps the "remove GUI1" commit should not be there. 20181024 02:58:38< celticminstrel> Or maybe it should. I'm not sure. 20181024 02:58:47<+wesdiscordbot> Some day the notifications will stop I hope 20181024 02:58:58< celticminstrel> Oh, #wesnoth-commits spam has stopped. 20181024 02:59:11< celticminstrel> So hopefully irker won't take too much longer either. 20181024 02:59:25<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/504489052591095809/unknown.png 20181024 02:59:59< celticminstrel> Wow. 20181024 03:00:31< celticminstrel> I pushed seven branches simultaneously but I guess schema is the bulk of it (with gui2_help coming in second). 20181024 03:00:52-!- mode/#wesnoth-dev [-qoz irker*!*@* shadowm] by shadowm 20181024 03:00:53< shadowm> Finally omg 20181024 03:04:43< celticminstrel> \o/ 20181024 03:05:38< celticminstrel> And now, sleep calls. 20181024 03:05:42-!- celticminstrel is now known as celmin|sleep 20181024 03:07:26-!- oldlaptop [~quassel@45.63.78.126] has quit [Remote host closed the connection] 20181024 03:08:10-!- oldlaptop [~quassel@45.63.78.126] has joined #wesnoth-dev 20181024 03:46:34-!- travis-ci [~travis-ci@ec2-54-92-131-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20181024 03:46:35< travis-ci> wesnoth/wesnoth#19903 (wml_error_recovery - d0c9bf9 : Celtic Minstrel): The build is still failing. 20181024 03:46:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/445447632 20181024 03:46:35-!- travis-ci [~travis-ci@ec2-54-92-131-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181024 04:38:59-!- travis-ci [~travis-ci@ec2-54-242-11-3.compute-1.amazonaws.com] has joined #wesnoth-dev 20181024 04:39:00< travis-ci> wesnoth/wesnoth#19907 (rel_paths - a1b5890 : Celtic Minstrel): The build is still failing. 20181024 04:39:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/445447682 20181024 04:39:00-!- travis-ci [~travis-ci@ec2-54-242-11-3.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181024 05:06:39< irker674> wesnoth/wesnoth:1.14 nemaara 5aacd0430d TSG S2: updated map AppVeyor: All builds passed 20181024 06:08:04-!- travis-ci [~travis-ci@ec2-54-145-130-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20181024 06:08:04< travis-ci> wesnoth/wesnoth#19909 (lua_reorg - 76a08b1 : Celtic Minstrel): The build has errored. 20181024 06:08:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/445447710 20181024 06:08:05-!- travis-ci [~travis-ci@ec2-54-145-130-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181024 07:11:03-!- travis-ci [~travis-ci@ec2-54-92-131-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20181024 07:11:04< travis-ci> wesnoth/wesnoth#19912 (gui2_help - 713cbca : Charles Dang): The build is still failing. 20181024 07:11:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/445447745 20181024 07:11:04-!- travis-ci [~travis-ci@ec2-54-92-131-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181024 07:28:25-!- travis-ci [~travis-ci@ec2-54-145-130-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20181024 07:28:26< travis-ci> wesnoth/wesnoth#19913 (schema - 4674e97 : Celtic Minstrel): The build is still failing. 20181024 07:28:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/445447822 20181024 07:28:26-!- travis-ci [~travis-ci@ec2-54-145-130-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181024 07:37:55< irker674> wesnoth/wesnoth:master Jyrki Vesterinen fa12518f86 Changed data type of display::get_overla AppVeyor: All builds passed 20181024 07:49:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181024 09:46:43< irker674> wesnoth/wesnoth:master nemaara 42e6ffe207 Revert "Merge branch 'master' of https:/ AppVeyor: All builds passed 20181024 10:39:51-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20181024 10:40:03-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit] 20181024 11:22:09-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev 20181024 11:51:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181024 12:03:04< irker674> wesnoth/wesnoth:master gfgtdf 6d55503eae don't write unchanged unit attributes to AppVeyor: All builds passed 20181024 12:17:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181024 12:35:15-!- celmin|sleep is now known as celmin|away 20181024 13:49:00-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 252 seconds] 20181024 13:53:51-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20181024 14:52:44<+wesdiscordbot> Is it possible in GUI2 to have two columns in the same row with different horizontal_alignment? I have https://pastebin.com/k61WDtiR , but the only alignment that does anything is "center". The "right" and "left" on the sub-columns don't seem to do anything at all. 20181024 15:03:21-!- irker674 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181024 15:07:41-!- irker105 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181024 15:07:42< irker105> wesnoth/wesnoth:1.14 josteph 1a9ee5856b Game Load: Display and the exception's m AppVeyor: All builds passed 20181024 15:44:56<+wesdiscordbot> What are you trying to do? 20181024 15:46:05<+wesdiscordbot> If your goal is to have "Songs" as far left as possible and likewise "Play Playlist" as far right as possible, put a spacer between the buttons, and set grow_factor to zero for the two columns (but not the spacer column). 20181024 15:49:00<+wesdiscordbot> @Pentarctagon Your parent column needs horizontal_grow = true instead of horizontal_alignment = center. 20181024 15:49:40<+wesdiscordbot> Otherwise it's not going to fill up all available space and the grid containing the columns you want laid out spaced apart isn't going to be large enough for that to be necessary 20181024 15:56:46<+wesdiscordbot> @jyrkive yes, that was what I was trying to do. @shadowm that worked, thanks! 20181024 16:17:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181024 16:38:40< irker105> wesnoth/wesnoth:master Celtic Minstrel 8cd1cc3c58 Don't interrupt the event after a WML er AppVeyor: vs2015/Release Failed 20181024 16:38:41< irker105> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19742156 20181024 16:46:50< irker105> wesnoth/wesnoth:1.14 nemaara 83b8f04cb3 Elvish Rider: grammar fix AppVeyor: All builds passed 20181024 17:10:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181024 18:38:38-!- wesdiscordbot1 [~wesdiscor@wesnoth/bot/discord-bridge] has joined #wesnoth-dev 20181024 18:38:41-!- mode/#wesnoth-dev [+v wesdiscordbot1] by ChanServ 20181024 18:40:22-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181024 18:49:14-!- Netsplit *.net <-> *.split quits: Ivanovic 20181024 18:49:21-!- Netsplit *.net <-> *.split quits: +wesdiscordbot 20181024 18:49:32-!- Netsplit *.net <-> *.split quits: vincent_c, commavir 20181024 18:49:35-!- wesdiscordbot1 is now known as wesdiscordbot 20181024 18:50:18-!- Ivanovic_ is now known as Ivanovic 20181024 18:59:04< irker105> wesnoth: Jyrki Vesterinen wesnoth:master 1315ebf2a2c1 / src/attack_prediction.cpp: Fix #3650: rare crash in attack prediction https://github.com/wesnoth/wesnoth/commit/1315ebf2a2c123c79bcdb288ac55620a8fc3a7e3 20181024 19:02:38< irker105> wesnoth: Jyrki Vesterinen wesnoth:1.14 0a8ab11aa76c / src/attack_prediction.cpp: Fix #3650: rare crash in attack prediction https://github.com/wesnoth/wesnoth/commit/0a8ab11aa76c731ecb931e622661f91c4d730d80 20181024 19:02:40< irker105> wesnoth: Jyrki Vesterinen wesnoth:1.14 9a8d4311c82f / changelog.md: Changelog entry for commit 0a8ab11aa76 https://github.com/wesnoth/wesnoth/commit/9a8d4311c82fb32fed902e9eed73c8eb6cd85b20 20181024 19:20:02< irker105> wesnoth/wesnoth:master Celtic Minstrel 694e449af1 Instead of trying to trap absolute paths AppVeyor: vs2015/Release Failed 20181024 19:20:03< irker105> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19742161 20181024 19:27:44< irker105> wesnoth/wesnoth:master Celtic Minstrel 3c7e96347b Move Orcish Shamans to core as a unit li AppVeyor: All builds passed 20181024 19:31:11< gfgtdf> does anyone now what the point of this line is https://github.com/wesnoth/wesnoth/blob/1.14/src/units/unit.cpp#L647 ? 20181024 19:34:12<+wesdiscordbot> if movement is less than 0, make sure the unit can't attack? 20181024 19:34:33< gfgtdf> well but that doesnt make any sense. 20181024 19:34:40<+wesdiscordbot> I guess maybe for cases when a unit is allowed multiple attacks in a turn? 20181024 19:35:59< gfgtdf> still it doenst make sense, if you want to remove the attacks, just write attacks_left=0 20181024 19:43:59< zookeeper> originated in commit ac8c4336a with the message "Bug fixes", so... yeah. hard to say. 20181024 19:44:48< zookeeper> ...or actually i guess in the preceding one, 0006749eb1a "Fix movement bug when loading games" 20181024 19:46:21< zookeeper> so, if i'm blindly guessing correctly, in saves (or in unit building in general?) moves= works as a shorthand for "0 moves and 0 attacks left"? 20181024 19:46:39< zookeeper> which would be something i don't recall ever really being a thing. 20181024 19:48:48< gfgtdf> hmm 20181024 19:49:16< gfgtdf> i think i'll just remove it (in master), seems like an unexpected behaviour. 20181024 19:51:58< gfgtdf> also its quire sure that removing this will not result in a bug when loading saves. 20181024 19:54:01< irker105> wesnoth: nemaara wesnoth:1.14 6f5081967431 / data/core/units/elves/ (13 files): Update Elvish unit descriptions https://github.com/wesnoth/wesnoth/commit/6f508196743162aa1641dff1550cbf48821de00d 20181024 19:55:18< irker105> wesnoth: nemaara wesnoth:master 624872963c84 / data/core/units/elves/ (13 files): Update Elvish unit descriptions https://github.com/wesnoth/wesnoth/commit/624872963c84cad1affcab88a4d83745f68cf1c5 20181024 20:16:47< irker105> wesnoth/wesnoth:gui2_help Charles Dang 713cbca0ad Help Browser: don't generate nodes for h AppVeyor: vs2015/Release Failed 20181024 20:16:48< irker105> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19742164 20181024 20:52:29< irker105> wesnoth/wesnoth:master Celtic Minstrel 674d951b7d Move Orcish Shamans to core as a unit li AppVeyor: All builds passed 20181024 21:14:49<+wesdiscordbot> @Konrad2 wait my rewrite doesn't address that issue 20181024 21:15:17<+wesdiscordbot> I haven't touched anything regarding the gameplay at all 20181024 21:18:36<+wesdiscordbot> There is a so much to read and not as much time. D: 20181024 21:18:55<+wesdiscordbot> sorry sorry, I didn't tell you that 😂 20181024 21:26:06< irker105> wesnoth/wesnoth:master Celtic Minstrel 3cc5565661 Deprecate helper.wml_error and move it t AppVeyor: vs2015/Release Failed 20181024 21:26:07< irker105> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19742167 20181024 21:38:41< irker105> wesnoth/wesnoth:master Celtic Minstrel 8cd1cc3c58 Don't interrupt the event after a WML er AppVeyor: 2/4 builds failed 20181024 21:38:42< irker105> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19742156 20181024 21:38:43< irker105> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19742163 20181024 21:38:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181024 22:31:15-!- irker105 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Ping timeout: 264 seconds] 20181024 22:43:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20181024 22:54:49-!- irker119 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181024 22:54:49< irker119> wesnoth/wesnoth:master Celtic Minstrel 7b63376c3b Fix issue with map generation occasional AppVeyor: All builds passed 20181024 23:26:48< irker119> wesnoth/wesnoth:master Celtic Minstrel 80708beb1a Schema: Add a macro for links (and make AppVeyor: vs2015/Release Failed 20181024 23:26:49< irker119> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19742171 20181024 23:48:57-!- celmin|away is now known as celticminstrel --- Log closed Thu Oct 25 00:00:43 2018