--- Log opened Sat Oct 27 00:00:45 2018 20181027 00:22:38<+wesdiscordbot> https://github.com/wesnoth/wesnoth/labels/Postponed 20181027 00:22:48<+wesdiscordbot> is there anything in that label that can be thawed now ? 20181027 00:33:21< celticminstrel> For my postponed PRs (I think there's 2), I'll probably thaw them myself once I start working on them again. 20181027 00:33:56< celticminstrel> I'm not sure why 3189 is postponed, it can probably be thawed. 20181027 00:34:15< celticminstrel> Maybe 2529 can be. 20181027 00:34:34< celticminstrel> I think 2180 might be related to my rel_paths PR? 20181027 00:34:43< celticminstrel> If so it should be linked to it. 20181027 00:35:14< celticminstrel> 1155 is sort of linked to gui2_help. 20181027 00:35:28< celticminstrel> It can be done without it, but why extend a system you're planning to remove? 20181027 00:36:01< celticminstrel> For 1135 there's simply no clear consensus on how it could be done. 20181027 00:37:03< celticminstrel> I think 1038 is also postponed due to gui2_help, but unlike 1155 it doesn't involve extending the help system (only adding a new topic), so maybe it could be thawed. 20181027 00:37:24< celticminstrel> The rest, I have no idea. 20181027 00:38:09<+wesdiscordbot> thanks for looking 20181027 00:38:24<+wesdiscordbot> I'll thaw 3189 and milestone it 20181027 00:39:36<+wesdiscordbot> 2529 thawed 20181027 00:39:46< celticminstrel> What was that again? 20181027 00:42:13< mattsc> 1307 could be closed as “won’t fix” AFAIC, but I think people did not want me to close it after I enabled vision through tunnels. 20181027 00:43:17<+wesdiscordbot> image= in mp 20181027 00:43:24<+wesdiscordbot> is what 2529 was 20181027 01:07:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181027 01:43:05< irker226> wesnoth/wesnoth:master Charles Dang d940697987 Preferences: tweaked FPS limiter option AppVeyor: 2/4 builds failed 20181027 01:43:06< irker226> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19828678 20181027 01:43:07< irker226> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19828679 20181027 02:52:25< irker226> wesnoth/wesnoth:master DisherProject f636587844 DiD S7: Replace deprecated tag AppVeyor: 2/4 builds failed 20181027 02:52:26< irker226> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19831227 20181027 02:52:27< irker226> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19831232 20181027 03:18:47<+wesdiscordbot> man, I haven't checked our facebook page in ages 20181027 03:19:47<+wesdiscordbot> 🤦 20181027 03:20:43<+wesdiscordbot> we're now big enough that we've been sent 1 abusive, rage-filled DM! 20181027 03:21:08<+wesdiscordbot> Does it by any chance involve the rng? 20181027 03:21:36<+wesdiscordbot> No. It says our coding is shit. 20181027 03:21:43<+wesdiscordbot> And we're the worst strategy game ever 20181027 03:24:25<+wesdiscordbot> And includes some choice insults aimed towards the mother of whoever they expected to read the message. 20181027 03:24:30<+wesdiscordbot> 🙄 20181027 03:29:26<+wesdiscordbot> @shadowm could you translate "me pareció curioso encontrar esa app y que tuviera personajes de su juego." 20181027 03:30:56<+wesdiscordbot> "i found it curious to come across that app and that it had characters from your game" 20181027 03:31:19<+wesdiscordbot> ah 20181027 03:31:21< celticminstrel> ... 20181027 03:31:21<+wesdiscordbot> thanks 20181027 03:31:32< celticminstrel> I don't get it. 20181027 03:31:34<+wesdiscordbot> What's that ellipsis supposed to mean? 20181027 03:31:37< celticminstrel> Maybe because it's out of context. 20181027 03:32:30-!- celticminstrel is now known as celmin|sleep 20181027 03:33:10<+wesdiscordbot> Sounds like someone’s stealing assets from wesnoth for a different game? At least that’s how it sound to me 20181027 03:33:28< celmin|sleep> Ohh. I can see how that's a reasonable reading of it, yeah. 20181027 03:33:30<+wesdiscordbot> Yeah I assume there's more context to this 20181027 03:36:27<+wesdiscordbot> It was 1 of 2 messages talking about that "Everyone's RPG" mobile game that used some of our assets. It was mentioned here on Discord back in August. 20181027 05:09:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181027 05:26:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181027 05:40:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181027 05:52:33-!- irker226 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181027 07:11:19-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer] 20181027 07:11:42-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20181027 08:54:36-!- irker382 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181027 08:54:36< irker382> wesnoth/wesnoth:master newfrenchy83 4dd66a6849 Update utils.cfg AppVeyor: vs2015/Release Failed 20181027 08:54:36< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19841070 20181027 09:25:43< irker382> wesnoth/wesnoth:master newfrenchy83 59078c2300 Update utils.cfg AppVeyor: vs2017/Release Failed 20181027 09:25:44< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19841071 20181027 10:32:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181027 11:44:56-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181027 12:21:18< irker382> wesnoth/wesnoth:master newfrenchy83 0aeaf55a98 Update utils.cfg AppVeyor: vs2015/Release Failed 20181027 12:21:19< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19843049 20181027 12:48:27-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds] 20181027 13:13:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181027 13:51:49-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20181027 13:52:58-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181027 13:54:29< irker382> wesnoth/wesnoth:master newfrenchy83 4dd66a6849 Update utils.cfg AppVeyor: 1/2 builds failed 20181027 13:54:30< irker382> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19841070 20181027 13:54:34-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit] 20181027 13:54:49-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181027 14:23:33-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 252 seconds] 20181027 14:25:43< irker382> wesnoth/wesnoth:master newfrenchy83 59078c2300 Update utils.cfg AppVeyor: 1/2 builds failed 20181027 14:25:44< irker382> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19841071 20181027 14:27:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181027 14:45:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181027 15:30:37-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20181027 15:48:30< irker382> wesnoth: gfgtdf wesnoth:master 783dc0767b80 / src/ (scripting/lua_unit.cpp units/unit.cpp units/unit.hpp): more modifiable attributes to lua units https://github.com/wesnoth/wesnoth/commit/783dc0767b8072cde9666c85eb124f969e0e8d17 20181027 15:48:32< irker382> wesnoth: gfgtdf wesnoth:master cc5aac7009f6 / src/units/unit.cpp: replace impossible check with assert. https://github.com/wesnoth/wesnoth/commit/cc5aac7009f68584e1c05e23674fc10097495e42 20181027 15:48:34< irker382> wesnoth: gfgtdf wesnoth:master e634198a5e9d / src/units/ (filter.cpp filter.hpp): make unit filters a little more safe against nullptr access. https://github.com/wesnoth/wesnoth/commit/e634198a5e9d509da148392b45d4d48d2e240d65 20181027 15:48:36< irker382> wesnoth: gfgtdf wesnoth:master 71118875351a / src/units/unit.cpp: [unit] moves=-1 no longer removes attacks https://github.com/wesnoth/wesnoth/commit/71118875351ac903f1f5e6454c5d8cf12f1c2109 20181027 15:48:38< irker382> wesnoth: gfgtdf wesnoth:master 6c696cd12761 / src/units/unit.cpp: experience modifer no longer applies to [effect] https://github.com/wesnoth/wesnoth/commit/6c696cd127619886959cdb7b4ee7d0084638244e 20181027 16:00:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181027 16:16:14< irker382> wesnoth/wesnoth:master gfgtdf 6c696cd127 experience modifer no longer applies to AppVeyor: vs2017/Release Failed 20181027 16:16:15< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19845850 20181027 16:21:59-!- travis-ci [~travis-ci@ec2-54-160-161-82.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 16:22:00< travis-ci> wesnoth/wesnoth#19951 (master - 6c696cd : gfgtdf): The build was broken. 20181027 16:22:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447122747 20181027 16:22:00-!- travis-ci [~travis-ci@ec2-54-160-161-82.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 16:44:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181027 16:44:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181027 16:45:44-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:54b3:ece:f6b4:7e7f] has joined #wesnoth-dev 20181027 16:48:04-!- travis-ci [~travis-ci@ec2-54-226-111-29.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 16:48:05< travis-ci> gfgtdf/wesnoth#1404 (skip_unit_attribute - 9bca98f : gfgtdf): The build was broken. 20181027 16:48:05< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/447123478 20181027 16:48:05-!- travis-ci [~travis-ci@ec2-54-226-111-29.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 17:15:15< irker382> wesnoth: Jyrki Vesterinen wesnoth:master d5a4946aaad2 / src/units/unit.cpp: Fix build https://github.com/wesnoth/wesnoth/commit/d5a4946aaad295268340a132a23d2ec4e421d4ec 20181027 17:15:17< irker382> wesnoth: Jyrki Vesterinen wesnoth:master 858444b8b3ff / src/ (picture.cpp scripting/lua_terrainfilter.cpp): Fix Visual Studio compiler warnings https://github.com/wesnoth/wesnoth/commit/858444b8b3fff646311a4f3a8677c4e8b6879935 20181027 17:21:18< irker382> wesnoth/wesnoth:master newfrenchy83 0aeaf55a98 Update utils.cfg AppVeyor: 2/4 builds failed 20181027 17:21:19< irker382> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19843049 20181027 17:21:20< irker382> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19843050 20181027 17:42:02-!- travis-ci [~travis-ci@ec2-107-21-178-119.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 17:42:03< travis-ci> wesnoth/wesnoth#19953 (master - 858444b : Jyrki Vesterinen): The build is still failing. 20181027 17:42:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447145584 20181027 17:42:03-!- travis-ci [~travis-ci@ec2-107-21-178-119.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 17:54:30< irker382> wesnoth/wesnoth:master Jyrki Vesterinen 858444b8b3 Fix Visual Studio compiler warnings AppVeyor: vs2015/Release Failed 20181027 17:54:31< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19847022 20181027 17:56:44< irker382> wesnoth: Celtic Minstrel wesnoth:master c4f2e839abac / data/lua/wml/random_placement.lua: Fix [random_placement] executing the code for each element twice (fixes #3663) https://github.com/wesnoth/wesnoth/commit/c4f2e839abac649ba4145227b1af9020ac23d5cd 20181027 18:15:00-!- travis-ci [~travis-ci@ec2-54-144-80-50.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 18:15:02< travis-ci> gfgtdf/wesnoth#1405 (master - a93491b : gfgtdf): The build was broken. 20181027 18:15:02< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/447145569 20181027 18:15:02-!- travis-ci [~travis-ci@ec2-54-144-80-50.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 18:17:43-!- travis-ci [~travis-ci@ec2-107-21-178-119.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 18:17:44< travis-ci> gfgtdf/wesnoth#1406 (skip_unit_attribute - d1bebbf : gfgtdf): The build is still failing. 20181027 18:17:45< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/447146433 20181027 18:17:45-!- travis-ci [~travis-ci@ec2-107-21-178-119.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 18:25:34-!- travis-ci [~travis-ci@ec2-54-163-0-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 18:25:35< travis-ci> wesnoth/wesnoth#19955 (master - c4f2e83 : Celtic Minstrel): The build is still failing. 20181027 18:25:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447156460 20181027 18:25:35-!- travis-ci [~travis-ci@ec2-54-163-0-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 18:29:03< irker382> wesnoth/wesnoth:master gfgtdf bd973f33ec dont write unchanges unit attributes AppVeyor: vs2017/Release Failed 20181027 18:29:04< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19847074 20181027 18:40:39< irker382> wesnoth: Jyrki Vesterinen wesnoth:master bd02a4f2340b / data/gui/window/preferences/03_display.cfg: Remove a stray #endif https://github.com/wesnoth/wesnoth/commit/bd02a4f2340b2be8c8c119bcb5874e609cd03122 20181027 19:09:11< irker382> wesnoth: Gregory A Lundberg wesnoth:1.14 aa2842633d31 / src/ (game_version.cpp game_version.hpp): Codacy: Error-prone Code https://github.com/wesnoth/wesnoth/commit/aa2842633d313f15cf20472c245116a48cfee90f 20181027 19:12:08< irker382> wesnoth: Gregory A Lundberg wesnoth:master c559f9fc68ba / src/ (game_version.cpp game_version.hpp): Codacy: Error-prone Code https://github.com/wesnoth/wesnoth/commit/c559f9fc68baff19428e824190f5167c7e929075 20181027 19:19:14-!- travis-ci [~travis-ci@ec2-23-22-16-199.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 19:19:15< travis-ci> wesnoth/wesnoth#19957 (master - bd02a4f : Jyrki Vesterinen): The build was fixed. 20181027 19:19:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447168916 20181027 19:19:15-!- travis-ci [~travis-ci@ec2-23-22-16-199.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 19:19:36< celticminstrel> \o/ 20181027 19:38:21< irker382> wesnoth: Gregory A Lundberg wesnoth:1.14 9858b39e4169 / src/gui/auxiliary/old_markup.hpp: Codacy: Error-prone Code https://github.com/wesnoth/wesnoth/commit/9858b39e4169e642666acf1e623c09dc7bbf1c8e 20181027 19:38:54< irker382> wesnoth: Gregory A Lundberg wesnoth:master dec0d083c3fe / src/gui/auxiliary/old_markup.hpp: Codacy: Error-prone Code https://github.com/wesnoth/wesnoth/commit/dec0d083c3fe09ed2c87c123e536f2f4f32bebc7 20181027 19:45:26< irker382> wesnoth/wesnoth:master newfrenchy83 2375b39458 Update utils.cfg AppVeyor: vs2017/Release Failed 20181027 19:45:27< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19847937 20181027 19:54:36-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181027 20:36:51-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181027 20:40:19< irker382> wesnoth: josteph wesnoth:master 2f266dde90ea / data/test/scenarios/scatter_units.cfg wml_test_schedule: Add test for #3663 https://github.com/wesnoth/wesnoth/commit/2f266dde90ea627661511308960ab83ebf1861ff 20181027 20:49:15< irker382> wesnoth: josteph wesnoth:1.14 36c796852b65 / data/test/scenarios/scatter_units.cfg wml_test_schedule: Add test for #3663 https://github.com/wesnoth/wesnoth/commit/36c796852b65b4fb8704054cd769ca94ad7c64fd 20181027 20:58:25< irker382> wesnoth: josteph wesnoth:1.14 763be5bece42 / src/gui/dialogs/ (game_load.cpp game_load.hpp): Game Load: The dialog shall be usable even if the auto-selected savefile is inva https://github.com/wesnoth/wesnoth/commit/763be5bece421e58062d21edef5e6f7226e96220 20181027 20:58:27< irker382> wesnoth: josteph wesnoth:1.14 fe23be1f1c4c / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/fe23be1f1c4c8d0bbe18f040242c5cca775894e5 20181027 21:00:19< irker382> wesnoth: josteph wesnoth:master 3dc3428e6270 / src/gui/dialogs/ (game_load.cpp game_load.hpp): Game Load: The dialog shall be usable even if the auto-selected savefile is inva https://github.com/wesnoth/wesnoth/commit/3dc3428e6270598e0cfe76a9f2c0422ac2049c15 20181027 21:00:21< irker382> wesnoth: josteph wesnoth:master c869d9853996 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/c869d9853996f92a0fb1a322a6a0b30fadf0046b 20181027 21:00:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181027 21:00:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181027 21:16:14< irker382> wesnoth/wesnoth:master gfgtdf 6c696cd127 experience modifer no longer applies to AppVeyor: 2/4 builds failed 20181027 21:16:15< irker382> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19845850 20181027 21:16:16< irker382> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19845851 20181027 21:36:23-!- travis-ci [~travis-ci@ec2-54-144-80-50.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 21:36:24< travis-ci> wesnoth/wesnoth#19962 (master - 2f266dd : josteph): The build passed. 20181027 21:36:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447200599 20181027 21:36:25-!- travis-ci [~travis-ci@ec2-54-144-80-50.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 21:42:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181027 22:02:23< irker382> wesnoth: gfgtdf wesnoth:master 5f2fbfb13957 / src/scripting/push_check.hpp: fix #3661 bug in wesnoth.find_path https://github.com/wesnoth/wesnoth/commit/5f2fbfb13957c90f22a3c646d35d94c915f2ebef 20181027 22:06:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20181027 22:10:19< irker382> wesnoth: josteph wesnoth:master 4d8862b46ca3 / src/reports.cpp: New helper function https://github.com/wesnoth/wesnoth/commit/4d8862b46ca33d207d4a3b75a880b69bbcb88ea7 20181027 22:10:21< irker382> wesnoth: josteph wesnoth:master 81b3c3f226f7 / src/actions/ (attack.cpp attack.hpp): Add a new overload to combat_modifier https://github.com/wesnoth/wesnoth/commit/81b3c3f226f7704eb8e0d8a6929298f20bbe389e 20181027 22:10:23< irker382> wesnoth: josteph wesnoth:master 00f5b8822af0 / src/game_display.hpp: Expose attack_indicator_src_ https://github.com/wesnoth/wesnoth/commit/00f5b8822af03b31c5c4a1fa2a5cb06076217aac 20181027 22:10:25< irker382> wesnoth: josteph wesnoth:master 27c9086be77a / src/reports.cpp: Show the alignment the selected unit will have at the mouseover hex, not at its https://github.com/wesnoth/wesnoth/commit/27c9086be77ac95c74d4243c968d7d4b54280909 20181027 22:10:27< irker382> wesnoth: josteph wesnoth:master a03740923f1d / src/reports.cpp: Have unit_weapons use the alignment at the mouseover hex, for consistency with t https://github.com/wesnoth/wesnoth/commit/a03740923f1d8207cb7aeba856590383ca5e783d 20181027 22:10:29< irker382> wesnoth: josteph wesnoth:master 55e3fa366058 / src/ (4 files in 3 dirs): Simplify under_leadership(). https://github.com/wesnoth/wesnoth/commit/55e3fa36605824e64be4a09e4e4f1bac38bc909f 20181027 22:10:31< irker382> wesnoth: josteph wesnoth:master 839c9f37c7ef / src/reports.cpp: Rename formal parameter https://github.com/wesnoth/wesnoth/commit/839c9f37c7ef4aec77c015d19246f9cbf271ca7f 20181027 22:10:33< irker382> wesnoth: josteph wesnoth:master d59dd8fb5ca6 / src/actions/attack.cpp: Simplify under_leadership() further. https://github.com/wesnoth/wesnoth/commit/d59dd8fb5ca600c58d6fc99647d8ae463af12b4a 20181027 22:10:35< irker382> wesnoth: josteph wesnoth:master 80069fa9dd00 / src/ (5 files in 3 dirs): Merge remote-tracking branch 'josteph/report-alignment' https://github.com/wesnoth/wesnoth/commit/80069fa9dd00d38aca626a2c552f962f1f98dc32 20181027 22:11:19-!- travis-ci [~travis-ci@ec2-54-163-142-119.compute-1.amazonaws.com] has joined #wesnoth-dev 20181027 22:11:20< travis-ci> wesnoth/wesnoth#19966 (master - c869d98 : josteph): The build passed. 20181027 22:11:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447205774 20181027 22:11:20-!- travis-ci [~travis-ci@ec2-54-163-142-119.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181027 22:27:54< irker382> wesnoth: josteph wesnoth:1.14 e0b02ea48e2d / src/reports.cpp: New helper function https://github.com/wesnoth/wesnoth/commit/e0b02ea48e2d4a17256e044c59b9e43fea64cc3b 20181027 22:27:56< irker382> wesnoth: josteph wesnoth:1.14 55e592b60ef1 / src/actions/ (attack.cpp attack.hpp): Add a new overload to combat_modifier https://github.com/wesnoth/wesnoth/commit/55e592b60ef19fdea90963903373f094f805df41 20181027 22:27:58< irker382> wesnoth: josteph wesnoth:1.14 bf91032d5747 / src/game_display.hpp: Expose attack_indicator_src_ https://github.com/wesnoth/wesnoth/commit/bf91032d5747edba77c8d7fd98dfd41dc3218b52 20181027 22:28:00< irker382> wesnoth: josteph wesnoth:1.14 e632be058c1b / src/reports.cpp: Show the alignment the selected unit will have at the mouseover hex, not at its https://github.com/wesnoth/wesnoth/commit/e632be058c1b7638c5b47b0e446012fda6c5ccf2 20181027 22:28:02< irker382> wesnoth: josteph wesnoth:1.14 b5c82627d98e / src/reports.cpp: Have unit_weapons use the alignment at the mouseover hex, for consistency with t https://github.com/wesnoth/wesnoth/commit/b5c82627d98e90dc11a091ea99cfa722803e5ceb 20181027 22:28:04< irker382> wesnoth: josteph wesnoth:1.14 631d6b77994c / src/ (4 files in 3 dirs): Simplify under_leadership(). https://github.com/wesnoth/wesnoth/commit/631d6b77994c27d4cb8a83da5ff3e1c5c5b1c099 20181027 22:28:06< irker382> wesnoth: josteph wesnoth:1.14 6f5ee0ba0d00 / src/reports.cpp: Rename formal parameter https://github.com/wesnoth/wesnoth/commit/6f5ee0ba0d004ce15e03736f579ce4a411718134 20181027 22:28:08< irker382> wesnoth: josteph wesnoth:1.14 049541738d2f / src/actions/attack.cpp: Simplify under_leadership() further. https://github.com/wesnoth/wesnoth/commit/049541738d2f22dd61c1b766ee3c87c8b7f2fe9d 20181027 22:29:58< irker382> wesnoth: josteph wesnoth:1.14 43d3a14dd184 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/43d3a14dd1848158db9c2562782c5c268f4804c9 20181027 22:32:57< irker382> wesnoth: josteph wesnoth:1.14 934c158463e5 / changelog.md: Update changelog for #3578 https://github.com/wesnoth/wesnoth/commit/934c158463e533487645a9556d2462396450d012 20181027 22:38:16<+wesdiscordbot> Why is #3588 not marked Upstream? 20181027 22:38:48<+wesdiscordbot> @josteph 20181027 22:40:01<+wesdiscordbot> @shadowm Fixed 20181027 22:50:05-!- stikonas_ is now known as stikonas 20181027 22:54:30< irker382> wesnoth/wesnoth:master Jyrki Vesterinen 858444b8b3 Fix Visual Studio compiler warnings AppVeyor: 1/2 builds failed 20181027 22:54:31< irker382> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19847022 20181027 23:29:03< irker382> wesnoth/wesnoth:master gfgtdf bd973f33ec dont write unchanges unit attributes AppVeyor: 2/4 builds failed 20181027 23:29:04< irker382> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19847074 20181027 23:29:05< irker382> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19847075 --- Log closed Sun Oct 28 00:00:47 2018