--- Log opened Sun Oct 28 00:00:47 2018 20181028 00:39:49<+wesdiscordbot> Vultraz, that Facebook comment is worth a celebration! It means Wesnoth is getting popular! And extending its audience beyond a narrow community of enthusiasts. 20181028 00:44:52<+wesdiscordbot> ? 20181028 00:45:26< irker382> wesnoth/wesnoth:master newfrenchy83 2375b39458 Update utils.cfg AppVeyor: 2/4 builds failed 20181028 00:45:27< irker382> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/19847937 20181028 00:45:28< irker382> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19847938 20181028 00:55:52-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:54b3:ece:f6b4:7e7f] has quit [Remote host closed the connection] 20181028 01:13:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181028 01:13:41<+wesdiscordbot> Oh, hey, RPS put Wesnoth number 6 on a recent Top 50 Free Games list https://www.rockpapershotgun.com/2018/10/19/best-free-pc-games/6/ 20181028 01:25:57<+wesdiscordbot> what facebook post though? 20181028 02:04:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181028 02:15:37<+wesdiscordbot> dunno 20181028 03:11:33< celticminstrel> @jyrkive - Is it my imagination or does the MSVC project not explicitly specify C++14? 20181028 03:12:03< celticminstrel> And should it? I feel like it should so that people using VS2017 don't accidentally add stuff that won't work on C++14. 20181028 03:15:03<+wesdiscordbot> I don't think it does 20181028 03:15:11<+wesdiscordbot> 2014 is the new default tho 20181028 03:15:13<+wesdiscordbot> at least in 2017 20181028 03:15:31< celticminstrel> It's the default in 2017 too? Then maybe not explicitly specifying it is okay. 20181028 03:15:42< celticminstrel> Master is currently building in VSCode, let's hope it works. 20181028 03:15:55<+wesdiscordbot> finally you get around to it... 20181028 03:54:04< celticminstrel> Well the good news is, it works. 20181028 03:55:19<+wesdiscordbot> Maybe mention it anyway so VC2020 will still use C++14 even if the default will have changed by then ? 20181028 03:56:20< celticminstrel> Maybe. 20181028 04:30:02<+wesdiscordbot> We should target 17 I think 20181028 04:30:04<+wesdiscordbot> c++17 20181028 04:30:50< celticminstrel> Maybe once the C++20 standard is finalized. 20181028 04:33:19< irker382> wesnoth/wesnoth:master josteph 80069fa9dd Merge remote-tracking branch 'josteph/re AppVeyor: All builds passed 20181028 04:43:32<+wesdiscordbot> why 20181028 04:59:36< celticminstrel> Only problem with VSCode is that MSBuild is too dumb to give file paths in the correct case and VSCode is too dumb to notice they're the same, so you can easily end up with two versions of the file open and VSCode thinks they're different because one is all lowercase. 20181028 05:43:47<+wesdiscordbot> This is what I meant to celebrate: [8:18 PM] Vultraz: man, I haven't checked our facebook page in ages [8:20 PM] Vultraz: we're now big enough that we've been sent 1 abusive, rage-filled DM! 20181028 05:52:06<+wesdiscordbot> Why is that a cause for celebration 20181028 05:57:32<+wesdiscordbot> Because it means user base is growing, and that the game rouses a strong feelings. It would be much worse if they just didn't care. 20181028 06:00:49<+wesdiscordbot> 🙄 20181028 06:01:13<+wesdiscordbot> If only those feelings translated into more contributors 20181028 06:16:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181028 06:51:49-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20181028 06:54:04-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181028 07:20:46-!- celticminstrel is now known as celmin|sleep 20181028 07:31:30< irker382> wesnoth/wesnoth:1.14 josteph 934c158463 Update changelog for #3578 AppVeyor: All builds passed 20181028 08:08:51-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has quit [Ping timeout: 244 seconds] 20181028 08:09:12-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has joined #wesnoth-dev 20181028 08:13:10<+wesdiscordbot> celticminstrel: C++14 is indeed the default version of the C++ standard in Visual Studio, including VS2017 and likely VS2019. 20181028 08:13:11<+wesdiscordbot> https://docs.microsoft.com/cpp/build/reference/std-specify-language-standard-version 20181028 08:14:02<+wesdiscordbot> C++17 removed some deprecated features, breaking backwards compatibility with some legacy code bases. Microsoft doesn't want to break old code with default settings. 20181028 08:16:03<+wesdiscordbot> I think it's too early for us to require C++17. The standard isn't even an year old. 20181028 08:21:41<+wesdiscordbot> oh, right 20181028 08:21:44<+wesdiscordbot> it was the other 2017 20181028 08:21:53<+wesdiscordbot> we were going to require VS 2017 20181028 08:21:57<+wesdiscordbot> not C++ 17 😬 20181028 08:22:15<+wesdiscordbot> I think requiring VS2017 is reasonable at this point. 20181028 08:22:38<+wesdiscordbot> I'm not confortable requiring the latest version of Visual Studio, but second latest would be okay. 20181028 08:23:10<+wesdiscordbot> Microsoft has already announced VS2019, so it won't be long until VS2017 is no longer the latest version. 20181028 08:23:18<+wesdiscordbot> they did? 20181028 08:23:57<+wesdiscordbot> https://blogs.msdn.microsoft.com/visualstudio/2018/06/06/whats-next-for-visual-studio/ 20181028 08:24:23<+wesdiscordbot> ahh 20181028 08:24:24<+wesdiscordbot> that 20181028 08:24:38<+wesdiscordbot> I thought they had done a more recent announcement 20181028 08:29:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181028 09:00:40< irker382> wesnoth/wesnoth:master newfrenchy83 f2d44d7ab7 Update utils.cfg AppVeyor: All builds passed 20181028 10:47:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181028 11:14:19< irker382> wesnoth/wesnoth:master mattsc c6d7c6a230 ai_helper.get_closest_enemy: change retu AppVeyor: All builds passed 20181028 11:19:43-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has joined #wesnoth-dev 20181028 11:20:37< gfgtdf> we alreade agreed on dropping vs 2015 some time ago https://github.com/wesnoth/wesnoth/issues/2702 20181028 11:31:43<+wesdiscordbot> yes 20181028 11:31:47<+wesdiscordbot> that's what i was referring to 20181028 11:38:31-!- Guest97898 [matthiaskr@gateway/shell/panicbnc/x-ywiqbekhkhpipxas] has joined #wesnoth-dev 20181028 11:40:20-!- Guest97898 is now known as matthiaskrgr 20181028 12:15:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181028 12:16:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181028 12:51:06-!- Nobun [~user@51.179.101.0] has joined #wesnoth-dev 20181028 13:07:38< irker382> wesnoth: gfgtdf wesnoth:master 546cb05d2735 / src/widgets/textbox.cpp: fixes #3245 ctrl+x in gui1 textbox https://github.com/wesnoth/wesnoth/commit/546cb05d273582dab1eaadffa54b9470ab3e2d40 20181028 13:07:40< irker382> wesnoth: gfgtdf wesnoth:master 9966f813b885 / data/multiplayer/scenarios/2p_Dark_Forecast.lua: fix lua error in 2p_Dark_Forecast https://github.com/wesnoth/wesnoth/commit/9966f813b8853f7823ef3c64b673ce35140c9f21 20181028 13:10:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181028 13:10:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181028 13:38:08< irker382> wesnoth/wesnoth:master josteph a219e12367 Liberty S6: Give the cave underground ti AppVeyor: All builds passed 20181028 14:14:17< celmin|sleep> FTR, I'm using the VS2017 build tools anyway, so I don't really care if you want to require VS2017. 20181028 14:14:52< irker382> wesnoth: newfrenchy83 wesnoth:master 0e99c2f2b988 / projectfiles/CodeBlocks/wesnoth.cbp: Fix Code::Blocks project https://github.com/wesnoth/wesnoth/commit/0e99c2f2b988eef033882b9aa5bf2019b4353e60 20181028 14:16:56< celmin|sleep> At least, I think I am. Certainly the MSBuild version, at least, is from 2017. 20181028 14:17:10-!- celmin|sleep is now known as celticminstrel 20181028 14:17:55< celticminstrel> I should have 2015 tools installed too though, so MSBuild might be selecting those since the project is a 2015 project. 20181028 15:45:45< irker382> wesnoth/wesnoth:master gfgtdf d84340add1 don't call invalidate_layout() unless ne AppVeyor: All builds passed 20181028 15:55:21< irker382> wesnoth: sigurdfdragon wesnoth:1.14 6760d985ae1f / data/campaigns/Delfadors_Memoirs/ (4 files in 2 dirs): DM: Remove/update comments https://github.com/wesnoth/wesnoth/commit/6760d985ae1fd24b4c5921cf7d5f476da48642ca 20181028 15:55:23< irker382> wesnoth: sigurdfdragon wesnoth:1.14 252fad3b8bbe / data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg: DM S17: Remove ai code from side https://github.com/wesnoth/wesnoth/commit/252fad3b8bbe1f128f7642a4e0a245c7459cc387 20181028 15:57:45< irker382> wesnoth: sigurdfdragon wesnoth:master 452356691222 / data/campaigns/Delfadors_Memoirs/ (4 files in 2 dirs): DM: Remove/update comments https://github.com/wesnoth/wesnoth/commit/45235669122242aab909401c0502da8f1d6cdea4 20181028 15:57:47< irker382> wesnoth: sigurdfdragon wesnoth:master 19c2c9364fcf / data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg: DM S17: Remove ai code from side https://github.com/wesnoth/wesnoth/commit/19c2c9364fcf54b2169cbac721d3a10d6152777c 20181028 15:58:05<+wesdiscordbot> FYI for people who don't check the forums frequently: https://forums.wesnoth.org/viewtopic.php?f=2&t=49018 @Vultraz in particular for the last sentence. 20181028 16:03:48-!- Nobun [~user@51.179.101.0] has quit [Ping timeout: 246 seconds] 20181028 16:22:17< irker382> wesnoth: Victor Sergienko wesnoth:master ea2e16d251da / src/gui/core/event/ (dispatcher.cpp dispatcher.hpp dispatcher_private.hpp handler.cpp handler.hpp): 3 kinds of touch event compiled: up/down (combined with mouse), swipe and multi- https://github.com/wesnoth/wesnoth/commit/ea2e16d251dab261f0208d26d05432d25dc6ef38 20181028 16:22:18< irker382> wesnoth: Victor Sergienko wesnoth:master aedc081b2eb2 / / (14 files in 6 dirs): iOS: Touch interface implemented, and a RMB emulation of such on PC. https://github.com/wesnoth/wesnoth/commit/aedc081b2eb2b4e519bc59cc28eeaee27c872a0a 20181028 16:22:20< irker382> wesnoth: Victor Sergienko wesnoth:master c9097f4dad21 / src/mouse_handler_base.cpp: std::chrono::high_resolution_clock didn't work (do I have different versions of https://github.com/wesnoth/wesnoth/commit/c9097f4dad2176f476453f06a80dc8cb23073a45 20181028 16:22:22< irker382> wesnoth: Victor Sergienko wesnoth:master 912453df4c00 / src/filesystem.cpp: iOS document directories. Might use these on other platforms as well. https://github.com/wesnoth/wesnoth/commit/912453df4c00e312f03c571ef988bd5bdb626a70 20181028 16:22:24< irker382> wesnoth: Victor Sergienko wesnoth:master b4ef4c9b34ec / / (11 files in 3 dirs): iOS: Touch-hex action added. https://github.com/wesnoth/wesnoth/commit/b4ef4c9b34ec8144e845f496285c83c4643689ee 20181028 16:22:26< irker382> wesnoth: Victor Sergienko wesnoth:master 71481f43de4c / src/ (8 files in 3 dirs): iOS: finger scrolling in controls. https://github.com/wesnoth/wesnoth/commit/71481f43de4c511566d1097fd4c0627b3e3278ae 20181028 16:22:28< irker382> wesnoth: Victor Sergienko wesnoth:master 12bd7d34b656 / src/mouse_events.cpp: iOS: panning https://github.com/wesnoth/wesnoth/commit/12bd7d34b6563619c9c9b08d373b52c6af031ff0 20181028 16:22:30< irker382> wesnoth: Victor Sergienko wesnoth:master 8668b7fcb70a / src/gui/core/ (event/distributor.cpp timer.cpp): iOS: trying 2 fixes in gui2::execute_timer() and gui2::timer_callback(): timer t https://github.com/wesnoth/wesnoth/commit/8668b7fcb70a5380bf4a90f7dbec90bb154bdf6f 20181028 16:22:32< irker382> wesnoth: Victor Sergienko wesnoth:master 941844f14a5b / src/ (6 files in 2 dirs): iOS: Long-touch context menu. Work around event queue delays. https://github.com/wesnoth/wesnoth/commit/941844f14a5bd666d4eee1be61eb39af128c6b28 20181028 16:22:34< irker382> wesnoth: Victor Sergienko wesnoth:master fd2469ba7580 / src/ (controller_base.cpp events.cpp sdl/userevent.hpp): iOS: double-tap for context menu https://github.com/wesnoth/wesnoth/commit/fd2469ba75809e61fcc4fbf20b435ed022ce58a4 20181028 16:22:36< irker382> wesnoth: Victor Sergienko wesnoth:master 559a9cc1fdd5 / src/gui/core/event/handler.cpp: iOS interfering with Mac: Mac touchpad generates touch events too. https://github.com/wesnoth/wesnoth/commit/559a9cc1fdd537cc86522cf7e5f62f82cdf80fd2 20181028 16:28:56< gfgtdf> oh nice, i was already afraid that'd be lost. 20181028 16:29:31<+wesdiscordbot> It was much easier to forward-port now when all the a_r stuff is gone. 20181028 16:32:30< gfgtdf> ye 20181028 16:48:29-!- travis-ci [~travis-ci@ec2-54-167-95-182.compute-1.amazonaws.com] has joined #wesnoth-dev 20181028 16:48:30< travis-ci> gfgtdf/wesnoth#1407 (skip_unit_attribute - c7bdaab : gfgtdf): The build has errored. 20181028 16:48:30< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/447424109 20181028 16:48:30-!- travis-ci [~travis-ci@ec2-54-167-95-182.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181028 17:23:24-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20181028 18:08:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181028 18:12:39-!- Nobun [~user@51.179.101.0] has joined #wesnoth-dev 20181028 18:24:12-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20181028 18:26:33-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181028 18:29:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit] 20181028 18:30:37-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181028 18:40:37-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has quit [Remote host closed the connection] 20181028 18:41:04-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has joined #wesnoth-dev 20181028 18:54:25< irker382> wesnoth/wesnoth:1.14 Victor Sergienko a20f765cb7 Revised timer code due to crashes on som AppVeyor: All builds passed 20181028 19:50:18< irker382> wesnoth/wesnoth:master gfgtdf f226f0fb99 improve modify_unit AppVeyor: vs2015/Release Failed 20181028 19:50:19< irker382> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/19859305 20181028 19:56:50-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20181028 20:28:55< irker382> wesnoth/wesnoth:1.14 nemaara 7e34ccab2a TSG S2: added scenario music AppVeyor: All builds passed 20181028 20:29:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20181028 21:18:32-!- Nobun [~user@51.179.101.0] has quit [Quit: WeeChat 2.1-dev] 20181028 22:11:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181028 22:21:09-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has joined #wesnoth-dev 20181028 22:23:17< irker382> wesnoth: mattsc wesnoth:master c4ebb1cea68d / src/ai/default/ (recruitment.cpp recruitment.hpp): AI recruitment: fix units on recall list interfering with recruiting https://github.com/wesnoth/wesnoth/commit/c4ebb1cea68d612b62c7fd49a2e6c84dd064eaa3 20181028 22:23:19< irker382> wesnoth: mattsc wesnoth:master e1da42ea91f6 / src/ai/default/recruitment.cpp: AI recruitment: use unit-specific recall cost https://github.com/wesnoth/wesnoth/commit/e1da42ea91f6580e4166cd5a675fb74da4578091 20181028 22:39:36< irker382> wesnoth: Celtic Minstrel wesnoth:fix_3647 83cf4e4a4bd1 / src/ (131 files in 26 dirs): WIP remove 'Mandatory WML Child missing but untested for' error https://github.com/wesnoth/wesnoth/commit/83cf4e4a4bd1410025c05c4fd7632f1f08444fd1 20181028 22:45:08-!- travis-ci [~travis-ci@ec2-54-196-166-119.compute-1.amazonaws.com] has joined #wesnoth-dev 20181028 22:45:09< travis-ci> wesnoth/wesnoth#19994 (master - e1da42e : mattsc): The build has errored. 20181028 22:45:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447546061 20181028 22:45:09-!- travis-ci [~travis-ci@ec2-54-196-166-119.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181028 22:46:51-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 260 seconds] 20181028 22:51:24-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20181028 23:00:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181028 23:23:06< irker382> wesnoth/wesnoth:master newfrenchy83 747a852bd4 Fix rare bug in FORCE_CHANCE_TO_HIT AppVeyor: All builds passed 20181028 23:25:49-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has quit [Remote host closed the connection] 20181028 23:25:51-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds] 20181028 23:26:18-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has joined #wesnoth-dev 20181028 23:27:49-!- gfgtdf [~Daniel@x2f203cf.dyn.telefonica.de] has quit [Remote host closed the connection] 20181028 23:28:25-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181028 23:33:49-!- travis-ci [~travis-ci@ec2-54-145-135-224.compute-1.amazonaws.com] has joined #wesnoth-dev 20181028 23:33:51< travis-ci> wesnoth/wesnoth#19995 (fix_3647 - 83cf4e4 : Celtic Minstrel): The build failed. 20181028 23:33:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/447550605 20181028 23:33:51-!- travis-ci [~travis-ci@ec2-54-145-135-224.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181028 23:43:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181028 23:55:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Mon Oct 29 00:00:48 2018