--- Log opened Fri Nov 02 00:00:45 2018 20181102 00:48:05< irker143> wesnoth/wesnoth:1.14 Steve Cotton 861cb642bc Tutorial S2: Hint that it's better to ke AppVeyor: All builds passed 20181102 01:25:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181102 01:42:58-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 268 seconds] 20181102 01:57:28< irker143> wesnoth/wesnoth:1.14 Steve Cotton 49b02592a4 Tutorial S2: Hint that it's better to ke AppVeyor: All builds passed 20181102 02:36:28<+wesdiscordbot> What the hell, celmin. 20181102 02:37:55<+wesdiscordbot> You know I already was in favor of removing the AI controller, no one thinks it’s really good, and Mattsc doesn’t know how to properly fix it. And suddenly I’m the gas guy for decisively saying go ahead get rid of it?? 20181102 02:39:13<+wesdiscordbot> Bad* 20181102 02:43:06< celticminstrel> I have no objection to removing it. I do have an objection to removing it instantly without going through the proper deprecation cycle. 20181102 02:43:20< celticminstrel> (I also don't understand why the issue was closed sincs AFAICT it hasn't actually been removed yet?) 20181102 02:43:58<+wesdiscordbot> It can be removed from scenarios immediately 20181102 02:44:04< celticminstrel> I personlly don't think we should remove it unless we can offer a direct replacement. 20181102 02:44:21< celticminstrel> But I'm still okay with doing it as long as it's merely deprecated. 20181102 02:44:23<+wesdiscordbot> And it was closed because the issue was "decide what to do with the AI controller" 20181102 02:44:25<+wesdiscordbot> we have decided 20181102 02:44:30< celticminstrel> Hmm. 20181102 02:45:01< celticminstrel> IMO it makes more sense to close it when that decision is not only made but also followed through (maybe changing the issue title). 20181102 02:45:21< celticminstrel> Mind if I reopen it and change the title, then? 20181102 02:45:26<+wesdiscordbot> sure 20181102 02:45:40<+wesdiscordbot> as for a replacement, mattsc just told you he doesn't know how to do it 20181102 02:45:43<+wesdiscordbot> and he's the only AI guy 20181102 02:47:23<+wesdiscordbot> the simplest solution is to immediately remove it from all scenarios and deprecate the macro at level 3 and remove it in 1.15 20181102 02:49:22<+wesdiscordbot> There's no need to complicate matters around a feature that sucks, is confusing, and nto very useful 20181102 02:50:01<+wesdiscordbot> @Vultraz Just one nitpicky correction: the AI Controller does not need fixing. It works perfectly for what it is. It's just ... unintuitive. 20181102 02:50:51<+wesdiscordbot> Besides that, I had and offline discussion with @zookeeper, who wrote the thing in the first place, and he has no objections to removing it either. 20181102 02:51:08<+wesdiscordbot> Ideally, all of us would replace it by something better, but there's no easy way to do so. 20181102 02:53:42< celticminstrel> Seems to be used in six campaigns: L, SotB, LoW, EI, NR, TRoW. 20181102 02:54:09< celticminstrel> I wonder to what extent people actually make use of it how much it actually helps. 20181102 02:54:49< celticminstrel> 18 scenarios use it, judging from GitHub's search results. 20181102 02:59:31-!- celticminstrel is now known as celmin|sleep 20181102 02:59:36 * celmin|sleep zzzzzz 20181102 03:08:43< irker143> wesnoth/wesnoth:master newfrenchy83 36f793b6bb Fix halo remain while event don't finish AppVeyor: All builds passed 20181102 04:50:24< irker143> wesnoth/wesnoth:master newfrenchy83 304a0e1f06 Fix halo remain while event don't finish AppVeyor: All builds passed 20181102 07:23:58< irker143> wesnoth/wesnoth:master mattsc 86ac3056de Multipack Wolves MAI: add [avoid] tag fu AppVeyor: All builds passed 20181102 07:35:43-!- buhman [~rewt@c-73-162-194-50.hsd1.ca.comcast.net] has joined #wesnoth-dev 20181102 07:37:10-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 272 seconds] 20181102 07:37:59-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20181102 07:41:52-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20181102 07:43:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds] 20181102 07:43:16-!- wedge010 is now known as wedge009 20181102 07:45:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181102 07:48:28-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181102 08:50:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181102 09:04:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181102 09:42:01<+wesdiscordbot> celticminstrel: there's a way to know how widely used AI_CONTROLLER is. You have to run a grep command on the add-ons server. However, this can be done only by people with admin access to it. 20181102 09:42:36< Soliton> anyone can download all addons. 20181102 09:43:06< Soliton> if you tell me what exactly to look for i can run that grep though. 20181102 09:43:40 * zookeeper is already checking 20181102 09:45:10<+wesdiscordbot> zookeeper: since you're already checking, I'd suggest using grep on both the 1.14 and 1.12 add-ons server, due to the fact that some campaigns aren't ported yet. 20181102 09:46:18<+wesdiscordbot> Once it's finished, can you please copy the output on pastebin or a similar service, so we can look at it? 20181102 09:47:46<+wesdiscordbot> Soliton: I was thinking about something like grep -rn "AI_CONTROLLER" *, but since zookeeper is already on it... 20181102 09:48:16< zookeeper> anyway, unless i've missed something, there's no particular bugs in the AI controller atm and since it's customizable nothing prevents people from using it in ways that are more appealing than the current mainline uses. so i certainly agree it can/should be removed from mainline campaigns (assuming no one fancies spending the time to customize it per-scenario, naturally), deprecating the 20181102 09:48:16< zookeeper> whole thing doesn't seem to logically follow. until there's some kind of replacement, anyway. 20181102 09:52:02< zookeeper> https://git.io/fxxaE 20181102 10:06:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20181102 10:09:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20181102 10:20:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20181102 10:21:39<+wesdiscordbot> Purge it from mainline at least 20181102 10:21:42<+wesdiscordbot> That we can all agree 20181102 10:21:44<+wesdiscordbot> on 20181102 10:24:19-!- irker143 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181102 10:40:55-!- irker019 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181102 10:40:55< irker019> wesnoth/wesnoth:master mattsc d8c631ee2e Return Guardian MAI: support named locat AppVeyor: All builds passed 20181102 10:57:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20181102 12:34:24-!- celmin|sleep is now known as celmin|away 20181102 13:41:02-!- irker019 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181102 17:52:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181102 18:00:08-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo.ga] 20181102 18:00:18-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20181102 18:08:02-!- irker083 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181102 18:08:02< irker083> wesnoth: Jyrki Vesterinen wesnoth:1.14 a76cc6e9ce18 / src/actions/attack.hpp: battle_context: remove move constructor and move assignment operator https://github.com/wesnoth/wesnoth/commit/a76cc6e9ce18ec7594ef16b320526edc5ee3ee0a 20181102 18:36:23< irker083> wesnoth: Jyrki Vesterinen wesnoth:1.14 a0cc8cbdfff8 / src/actions/ (attack.cpp attack.hpp): battle_context: implement move constructor and move assignment operator https://github.com/wesnoth/wesnoth/commit/a0cc8cbdfff8c49ee43dbf59a6dc789f5019642f 20181102 20:42:23< irker083> wesnoth: Jyrki Vesterinen wesnoth:1.14 53126f685645 / src/ (mouse_events.cpp mouse_events.hpp): Mouse events: don't keep around references to fighting units https://github.com/wesnoth/wesnoth/commit/53126f685645da7cc018faf32a4f7b741b7e5e97 20181102 20:45:12< irker083> wesnoth: Jyrki Vesterinen wesnoth:master f8bd38b13c94 / src/ (mouse_events.cpp mouse_events.hpp): Mouse events: don't keep around references to fighting units https://github.com/wesnoth/wesnoth/commit/f8bd38b13c9458af5ed1e65f5e02a98f3bd37c34 20181102 20:48:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181102 21:34:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20181102 21:37:53< irker083> wesnoth/wesnoth:master mattsc 539fa3db91 Animals Micro AIs: only allow despawning AppVeyor: All builds passed 20181102 21:50:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181102 21:50:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181102 23:02:17< irker083> wesnoth: Nils Kneuper wesnoth:1.14 ba6d4bb4fa02 / po/ (4 files in 4 dirs): updated Chinese (Traditional) translation https://github.com/wesnoth/wesnoth/commit/ba6d4bb4fa0239f738770d87716ddc2ebe0e06b2 20181102 23:02:26< irker083> wesnoth: Nils Kneuper wesnoth:master 211447e54ffe / / (19 files in 8 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/211447e54ffe8dac3ee09a40ebc8284083302443 20181102 23:02:28< irker083> wesnoth: Nils Kneuper wesnoth:master 752919e5c3df / utils/pofix.py: removed entry that leads to duplicate strings and breaks po files https://github.com/wesnoth/wesnoth/commit/752919e5c3df5564702b64f7c83cd5565dc3262d 20181102 23:02:30< irker083> wesnoth: Nils Kneuper wesnoth:master 736049680c12 / po/ (4 files in 4 dirs): updated Chinese (Traditional) translation https://github.com/wesnoth/wesnoth/commit/736049680c124faf12c897ba84cc5c7654518434 20181102 23:02:42< Ivanovic> btw pofix.py seems to be a real mess right now 20181102 23:02:52< Ivanovic> 1) the pot files were not fixed with the changes in pofix.py 20181102 23:03:02< Ivanovic> 2) it does create duplicate strings which should never happen 20181102 23:03:22< Ivanovic> 3) it seems to create some change in the pot files that are not reflected in the cfg files 20181102 23:36:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181102 23:54:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181102 23:55:26< celmin|away> Probably because no-one quite seems to understand how to use pofix. :/ 20181102 23:56:15-!- celmin|away is now known as celticminstrel --- Log closed Sat Nov 03 00:00:46 2018