--- Log opened Sun Nov 11 00:00:30 2018 20181111 00:05:24-!- sevu [~sevu@p54854E05.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20181111 00:24:06<+wesdiscordbot> I have an instance of https://github.com/wesnoth/wesnoth/issues/3627 right now 20181111 00:24:29<+wesdiscordbot> a Swordsman uses its own sprite during attacks and in Attack Enemy dialog, but a Spearman's sprite in the main map and in attack enemy 20181111 00:25:00<+wesdiscordbot> is there anything I can do to debug it now while wesnoth is still running? Last time it wasn't reproducible after reload 20181111 00:25:27<+wesdiscordbot> sorry, the second "in attack enemy" should have been "in the sidebar" 20181111 00:32:55-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181111 00:37:36-!- irker303 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181111 00:43:20<+wesdiscordbot> I don't understand the problem 20181111 00:43:25<+wesdiscordbot> or perhaps I'm not encountering it 20181111 00:43:27<+wesdiscordbot> do you have a screenshot? 20181111 00:43:57<+wesdiscordbot> ah nvm 20181111 00:44:32<+wesdiscordbot> I had one of these problems once where the issue would simply go away after reloading, but I couldn't resolve it 20181111 00:44:40<+wesdiscordbot> maybe you can just try using :debug mode and :inspect? 20181111 00:44:52<+wesdiscordbot> not really sure if that will help 20181111 00:46:07<+wesdiscordbot> I can use :inspect or :lua but I don't know what to look for / run 20181111 00:47:47<+wesdiscordbot> maybe the unit's image path 20181111 00:47:48<+wesdiscordbot> ? 20181111 00:47:57<+wesdiscordbot> probably that's not the problem 20181111 00:48:09<+wesdiscordbot> the sprite shows in the Attack Enemy dialog but not in the sidebar 20181111 00:48:13<+wesdiscordbot> the correct sprite* 20181111 00:48:18<+wesdiscordbot> since in your screenshot it looks like it's using the sprite frame from an attack/defend animation 20181111 00:48:19<+wesdiscordbot> aren't both of them supposed to use exactly the same image? 20181111 00:48:30<+wesdiscordbot> 🀷 your guess is probably better than mine 20181111 00:48:30<+wesdiscordbot> haha 20181111 00:48:37<+wesdiscordbot> what happens now is a bit different than what's in the screenshot 20181111 00:48:40<+wesdiscordbot> like yes, they should, but idk where in code those are defined 20181111 00:48:52<+wesdiscordbot> data/core/units/humans/Loyalist_Spearman.cfg 20181111 00:48:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181111 00:49:02<+wesdiscordbot> not that, I mean how the engine chooses which image to display 20181111 00:49:03<+wesdiscordbot> in the gui 20181111 00:49:10<+wesdiscordbot> ah, that's different 20181111 00:49:18<+wesdiscordbot> the Attack Enemy dialog uses unit_preview_pane, I think? 20181111 00:49:20<+wesdiscordbot> I guess it may be a problem there 20181111 00:49:26<+wesdiscordbot> unit_preview_pane.{cfg,cpp} 20181111 00:49:28<+wesdiscordbot> but I have no idea how the gui works 🀷 20181111 00:49:59<+wesdiscordbot> without getting into details, there's a widget that's supposed to be given an image as an argument 20181111 00:50:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181111 00:50:31<+wesdiscordbot> so the attack enemy dialog always has the right unit sprite in it? 20181111 00:50:34<+wesdiscordbot> unit objects know what their portraits are 20181111 00:50:48<+wesdiscordbot> the attack enemy dialog has the right unit sprite in the instance I have open right now 20181111 00:51:07<+wesdiscordbot> don't know if that's always the case. It's 1/1, might be just the RNG playing with me πŸ˜ƒ 20181111 00:51:15<+wesdiscordbot> since 20181111 00:51:21<+wesdiscordbot> what shows up in the sidebar depends on what you hover over 20181111 00:51:38<+wesdiscordbot> so I'm wondering if it's a problem with that widget, or whatever is used to put the sprite there 20181111 00:51:47<+wesdiscordbot> hmm, it's more interesting 20181111 00:51:56<+wesdiscordbot> Spearman have two sprites, facing=n and facing=s 20181111 00:52:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181111 00:52:27<+wesdiscordbot> I have four spearmen on the map, all facing n, but two of them have facing=s in the sidebar 20181111 00:52:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181111 00:52:41<+wesdiscordbot> 🀷 20181111 00:52:42<+wesdiscordbot> that's not counting the swordsman that's sprited as a spearman on the map 20181111 00:52:59<+wesdiscordbot> is the spearman sprite just the regular one, or does it seem to have any animation 20181111 00:53:05<+wesdiscordbot> err like is it an animated frame 20181111 00:53:06<+wesdiscordbot> I hope someone will read this tomorrow and make sense of it all πŸ˜ƒ 20181111 00:53:36<+wesdiscordbot> yah I"m not the right person to be help you with this hahaha πŸ˜‚ 20181111 00:53:37<+wesdiscordbot> wait, I was wrong 20181111 00:53:41<+wesdiscordbot> one of the spearman is a sowrdsman 20181111 00:53:49<+wesdiscordbot> helping* 20181111 00:53:50<+wesdiscordbot> and it doesn't have an idle animation 20181111 00:54:03<+wesdiscordbot> thanks for trying! πŸ‘ 20181111 00:55:02<+wesdiscordbot> okay, saw something more 20181111 00:55:14<+wesdiscordbot> the real spearmen have an idle animation, they move their spear while they're standing 20181111 00:55:43<+wesdiscordbot> the swordsman that's sprited a spearman has a static sprite, but i just caught it facing s and twiddling his sword 20181111 00:56:01<+wesdiscordbot> so it uses the spearman's static sprite but the swordsman's anims 20181111 00:56:23<+wesdiscordbot> screenshot? 20181111 00:58:04<+wesdiscordbot> @josteph the attack dialog uses the UPP yes 20181111 00:59:36<+wesdiscordbot> @Vultraz ok 20181111 00:59:44<+wesdiscordbot> @Yumi One moment, where can I pastebin it ? 20181111 00:59:45<+wesdiscordbot> (I wrote both) 20181111 00:59:58<+wesdiscordbot> just directly in discord? 20181111 01:00:00<+wesdiscordbot> :0 20181111 01:01:24<+wesdiscordbot> 3627 20181111 01:01:25<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/510982336997752842/Screenshot_2018-11-11_01-00-50.png 20181111 01:01:31<+wesdiscordbot> here you go 20181111 01:01:41<+wesdiscordbot> 28,12 and 21,14 are swordsmen 20181111 01:02:16<+wesdiscordbot> huh. 20181111 01:03:08<+wesdiscordbot> since there are other spearmen facing north, I wonder if it's a problem with the widget not updating the image once you hover over a new hex? 20181111 01:03:10<+wesdiscordbot> or something like that 20181111 01:03:47<+wesdiscordbot> 10,14 is also a swordsman 20181111 01:04:36<+wesdiscordbot> @Yumi Hmm. That could explain why they look wrong on the map too 20181111 01:04:56<+wesdiscordbot> I think the main map shows the last frame of the spearman animation.. 20181111 01:05:05<+wesdiscordbot> πŸ€” 20181111 01:08:48<+wesdiscordbot> the spearmen sprites are TC'd green 20181111 01:08:53<+wesdiscordbot> they should be purple 20181111 01:12:31<+wesdiscordbot> (updated the issue) 20181111 01:12:51<+wesdiscordbot> theory: when the green spearmen was killed its sprite was assigned to the purple swordsman due to a bug 20181111 01:13:46<+wesdiscordbot> I think that might explain why save-load fixes the bug, the load process doesn't retrace the steps precisely, it just loads the final snapshot right? 20181111 01:15:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20181111 01:19:35-!- irker268 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181111 01:19:35< irker268> wesnoth: gfgtdf wesnoth:master ed49d27511a2 / src/scripting/ (lua_gui2.cpp lua_gui2.hpp lua_kernel_base.cpp): add wesnoth.set_dialog_tooltip fixes #3692 https://github.com/wesnoth/wesnoth/commit/ed49d27511a25373730fde1b6d7cf3f6aa7714ae 20181111 01:19:37< irker268> wesnoth: gfgtdf wesnoth:master 0aaf9592600b / src/scripting/ (game_lua_kernel.hpp lua_team.cpp): fix #3699 village colors after side.color setter https://github.com/wesnoth/wesnoth/commit/0aaf9592600b913a020169a3074978f5c2701373 20181111 01:19:39< irker268> wesnoth: gfgtdf wesnoth:master e036cadf0bb8 / src/game_initialization/connect_engine.cpp: small connect_engine cleanup https://github.com/wesnoth/wesnoth/commit/e036cadf0bb861a7e609f59c483c07a3f8d16cd0 20181111 01:21:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181111 01:22:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181111 01:26:14<+wesdiscordbot> that might be it 20181111 01:46:48< celmin|away> Basically, saying the 2.0 prototype is going to replace 1.x (which hasn't yet been said yet AFAIK - I mean "will" has not been said yet, only "might") is equivalent to abandoning 1.x. Once you've abandoned 1.x, other people are of course free to do whatever they want with it. 20181111 01:49:16< celmin|away> sevu: The normal phrasing for that in 3702 is "probably more which I didn't run into" just FTR. What you have is technically correct, but almost no-one talks like that. 20181111 03:08:33-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 268 seconds] 20181111 03:08:50-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20181111 04:13:59< irker268> wesnoth: mattsc wesnoth:master e8ccf2a4de16 / changelog.md: Update changelog with AI changes https://github.com/wesnoth/wesnoth/commit/e8ccf2a4de16d6ea4edb8d989ea0e69fd53638c8 20181111 04:29:42< irker268> wesnoth/wesnoth:1.14 Severin GlΓΆckner 545a838525 German translation: spelling fix AppVeyor: All builds passed 20181111 07:30:28-!- irker268 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181111 08:10:13-!- irker386 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181111 08:10:13< irker386> wesnoth/wesnoth:master gfgtdf e036cadf0b small connect_engine cleanup AppVeyor: All builds passed 20181111 08:51:56-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181111 10:45:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181111 10:55:42< irker386> wesnoth/wesnoth:master mattsc e8ccf2a4de Update changelog with AI changes AppVeyor: All builds passed 20181111 12:04:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181111 13:04:20< irker386> wesnoth/wesnoth:1.14 nemaara 6bfc2668bd TSG S2: fixed typo AppVeyor: All builds passed 20181111 14:04:56-!- celmin|away is now known as celticminstrel 20181111 14:16:37-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo.ga] 20181111 14:17:01-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20181111 16:29:44-!- sevu [~sevu@edu243012.nat.uni-leipzig.de] has joined #wesnoth-dev 20181111 16:30:31< irker386> wesnoth: ProditorMagnus wesnoth:master e3da41335e84 / data/lua/wml/modify_unit.lua: fix modify_unit split_to_array function https://github.com/wesnoth/wesnoth/commit/e3da41335e845fb7800c155dfd6ff8cfd0eb38f2 20181111 16:35:34-!- sevu [~sevu@edu243012.nat.uni-leipzig.de] has quit [Remote host closed the connection] 20181111 16:42:53-!- sevu [~sevu@edu243012.nat.uni-leipzig.de] has joined #wesnoth-dev 20181111 17:22:57< irker386> wesnoth/wesnoth:master newfrenchy83 f44acd58d8 Update utils.cfg AppVeyor: All builds passed 20181111 17:23:14-!- sevu [~sevu@edu243012.nat.uni-leipzig.de] has quit [Remote host closed the connection] 20181111 17:41:57< celticminstrel> Gonna merge schema soon, anyone still want to review it first? 20181111 17:49:54< celticminstrel> Also, third opinions on 3672 would be welcome. 20181111 17:50:05< celticminstrel> And fourth and fifth etc opinions too. 20181111 18:21:49< celticminstrel> ... 20181111 18:21:56< celticminstrel> gfgtdf didn't label his new issue. >< 20181111 18:53:51< irker386> wesnoth: Celtic Minstrel wesnoth:master 3a65a14bcb2d / / (44 files in 10 dirs): Implement validation of the core game config WML https://github.com/wesnoth/wesnoth/commit/3a65a14bcb2d9a6868b8a0378bf6c36aa3700f0a 20181111 18:53:53< irker386> wesnoth: Celtic Minstrel wesnoth:master 3365aef28a38 / data/gui/schema.cfg data/schema/gui.cfg src/gui/gui.cpp: Move GUI2 schema into the schema directory https://github.com/wesnoth/wesnoth/commit/3365aef28a38b437e7eac3cd595f6c24d7c629c1 20181111 18:53:55< irker386> wesnoth: Celtic Minstrel wesnoth:master 34604fdff6c2 / / (5 files in 3 dirs): Get game config and schema to use some common types https://github.com/wesnoth/wesnoth/commit/34604fdff6c2d713b8dc8f4ecd7150d4a3096143 20181111 18:53:57< irker386> wesnoth: Celtic Minstrel wesnoth:master 9ab1777851ef / / (5 files in 2 dirs): Enable nesting of [type] tags https://github.com/wesnoth/wesnoth/commit/9ab1777851efd7b3d7af4505771036ba4f386307 20181111 18:53:59< irker386> wesnoth: Celtic Minstrel wesnoth:master 06c13291c257 / src/serialization/tag.hpp: Super-rudimentary documentation... https://github.com/wesnoth/wesnoth/commit/06c13291c257bd5923efa30dfee89022df7b4884 20181111 18:54:02< irker386> wesnoth: Celtic Minstrel wesnoth:master fb30b594b650 / / (9 files in 3 dirs): Support [switch] and [if] in [tag] https://github.com/wesnoth/wesnoth/commit/fb30b594b6502f16f71cd09442c75c4c4e656f71 20181111 18:54:03< irker386> wesnoth: Celtic Minstrel wesnoth:master 7fc359bf1633 / src/serialization/ (tag.cpp tag.hpp): Fix crash if a tag has conditions but no subtags https://github.com/wesnoth/wesnoth/commit/7fc359bf1633b3190046d4f3fec8ec86960dfa72 20181111 18:54:05< irker386> wesnoth: Celtic Minstrel wesnoth:master bebab878e3f6 / / (4 files in 3 dirs): Support multiple super tags and even conditional super tags https://github.com/wesnoth/wesnoth/commit/bebab878e3f6d3f69b87a761d59591f772a68557 20181111 18:54:07< irker386> wesnoth: Celtic Minstrel wesnoth:master ed7c3dbfbc1c / data/schema/units/specials.cfg: Missed a couple weapon special definitions https://github.com/wesnoth/wesnoth/commit/ed7c3dbfbc1c6987cbe354ac7c9a4ff76ef0df3d 20181111 18:54:09< irker386> wesnoth: Celtic Minstrel wesnoth:master 65ef12466dd6 / data/schema/core/addons.cfg: Use a few more conditional tag elements https://github.com/wesnoth/wesnoth/commit/65ef12466dd61b07c2f4619a4bffb8af35e9192e 20181111 18:54:11< irker386> wesnoth: Celtic Minstrel wesnoth:master 6e2ed5f53fb3 / data/schema/game_config.cfg src/serialization/tag.cpp: Fix matching of list types with limits https://github.com/wesnoth/wesnoth/commit/6e2ed5f53fb374e5314a38c9faceb74afeafb931 20181111 18:54:13< irker386> wesnoth: Celtic Minstrel wesnoth:master efa30b38402f / data/schema/units/modifications.cfg src/serialization/tag.cpp: Schema: Accept [elseif] in [if] and change [switch][default] to [else] https://github.com/wesnoth/wesnoth/commit/efa30b38402fa9a6e27f38ef3fbaf6e11ab2d47b 20181111 18:54:15< irker386> wesnoth: Celtic Minstrel wesnoth:master faa8decdc877 / data/schema/ (10 files in 3 dirs): WIP Schema for the AI WML https://github.com/wesnoth/wesnoth/commit/faa8decdc87744f6c63f664c1cd163fdecb67528 20181111 18:54:17< irker386> wesnoth: Celtic Minstrel wesnoth:master 80fb9c01a6f6 / src/serialization/tag.cpp: Schema: Fix [switch] implementation https://github.com/wesnoth/wesnoth/commit/80fb9c01a6f60674f3d8fc8e480a8721492d12f5 20181111 18:54:20< irker386> wesnoth: Celtic Minstrel wesnoth:master ff66583c0d79 / data/schema/units/modifications.cfg: Schema: Fix definition of [effect] tags for removing/modifying attacks https://github.com/wesnoth/wesnoth/commit/ff66583c0d79cf0d4b620445a70736c9d514eaa7 20181111 18:54:22< irker386> wesnoth: Celtic Minstrel wesnoth:master c2716728e5b2 / data/schema/ai/ (_main.cfg aspect_complex.cfg goal.cfg stage.cfg): A few more missing pieces to the AI schema https://github.com/wesnoth/wesnoth/commit/c2716728e5b27c35fb59ce2d1770d409a819a64c 20181111 18:54:23< irker386> wesnoth: Celtic Minstrel wesnoth:master 6d4b789e5bda / data/schema/ai/ (aspect_complex.cfg engine.cfg): Schema: Use the new globbing feature to improve [aspect] definition https://github.com/wesnoth/wesnoth/commit/6d4b789e5bda40496b6c24b46371e65abde5404c 20181111 18:54:25< irker386> wesnoth: Celtic Minstrel wesnoth:master 644ff73c92b1 / data/schema/ai/goal.cfg src/serialization/tag.cpp: Schema: Add feature to [switch] to allow a [case] to match the absence of the ke https://github.com/wesnoth/wesnoth/commit/644ff73c92b19645b0c395858d181d4e1380f0ca 20181111 18:54:27< irker386> wesnoth: Celtic Minstrel wesnoth:master d369368ac30f / src/serialization/tag.cpp: Schema: Extra sanity check for [elseif] tags https://github.com/wesnoth/wesnoth/commit/d369368ac30ffe6bb59377c03de4310e67578dd9 20181111 18:54:29< irker386> wesnoth: Celtic Minstrel wesnoth:master ac3ddf6e524b / src/serialization/tag.cpp: Schema: Fix [elseif] requiring an [then] tag https://github.com/wesnoth/wesnoth/commit/ac3ddf6e524be163e97d8c9c91ecdbb18aa539e1 20181111 18:54:31< irker386> wesnoth: Celtic Minstrel wesnoth:master da7fcaa5e170 / data/schema/ (ai/_main.cfg ai/aspect_complex.cfg ai/modify.cfg game_config.cfg): Schema: Definition of [modify_ai] tag https://github.com/wesnoth/wesnoth/commit/da7fcaa5e17002cbaa436e74916263eb8ccf8974 20181111 18:54:33< irker386> wesnoth: Celtic Minstrel wesnoth:master 3211014428d5 / data/schema/units/modifications.cfg: Fix [effect][set_specials] not correctly allowing special ability tags https://github.com/wesnoth/wesnoth/commit/3211014428d544326d7548db16473d75866f6d8e 20181111 18:54:35< irker386> wesnoth: Celtic Minstrel wesnoth:master 7ab5fabbf249 / data/schema/ (6 files in 4 dirs): Schema: Add all known ActionWML and ConditionalWML tags (based on wiki) https://github.com/wesnoth/wesnoth/commit/7ab5fabbf24976a18e6acb92a270dc0aa3d2ab35 20181111 18:54:37< irker386> wesnoth: Celtic Minstrel wesnoth:master 20a81c06a620 / data/schema/ (core/actionwml.cfg game_config.cfg): Schema: Definition of [micro_ai] tag, including all known MicroAIs https://github.com/wesnoth/wesnoth/commit/20a81c06a6201cf00e7bc5bb98095d24cb5aaf6e 20181111 18:54:39< irker386> wesnoth: Celtic Minstrel wesnoth:master 1e33a6666172 / data/schema/ (core/actionwml.cfg game_config.cfg types/pango.cfg): Schema: Pango formatting keys for [message] https://github.com/wesnoth/wesnoth/commit/1e33a6666172fd95fe42c33f56556288443b5094 20181111 18:54:41< irker386> wesnoth: Celtic Minstrel wesnoth:master 24608d0632bf / data/schema/ (8 files in 4 dirs): Schema ActionWML: Small bugfixes and add undocumented stuff from perusing source https://github.com/wesnoth/wesnoth/commit/24608d0632bf01d5c982953ff70cf813775cf452 20181111 18:54:43< irker386> wesnoth: Celtic Minstrel wesnoth:master c76e5ee69b75 / data/schema/core/config.cfg: Schema: Just allow any key in [language] https://github.com/wesnoth/wesnoth/commit/c76e5ee69b75e74aaea5ad865fadba5887ac2a6f 20181111 18:54:45< irker386> wesnoth: Celtic Minstrel wesnoth:master 703d0c3cf410 / data/ (4 files in 3 dirs): Fix erroneous/useless [event] in [titlescreen_music], [lobby_music], [editor_mus https://github.com/wesnoth/wesnoth/commit/703d0c3cf41064622facd2fd7a0bfd52f0434690 20181111 18:54:47< irker386> wesnoth: Celtic Minstrel wesnoth:master a1ecf1a55964 / / (8 files in 5 dirs): First batch of schema fixes https://github.com/wesnoth/wesnoth/commit/a1ecf1a55964811891b61bc3647c7bea4bdd9db1 20181111 18:54:50< irker386> wesnoth: Celtic Minstrel wesnoth:master 79eed95f98b4 / data/ (60 files in 16 dirs): Embrace turns=unlimited as a way of specifying unlimited turns https://github.com/wesnoth/wesnoth/commit/79eed95f98b46d0f4a231dfc85becc3e480089e7 20181111 18:54:52< irker386> wesnoth: Celtic Minstrel wesnoth:master 12e78df9f407 / data/schema/ (core/actionwml.cfg core/addons.cfg game_config.cfg): Schema: Support for turns=unlimited https://github.com/wesnoth/wesnoth/commit/12e78df9f4072cb164923ccdb3c9e436f8318712 20181111 18:54:54< irker386> wesnoth: Celtic Minstrel wesnoth:master b06259811d27 / data/multiplayer/scenarios/ANL_utils/ (ANL_general_macros.cfg ANL_special_macros.cfg): ANL: Remove needless silent= key from [object]s https://github.com/wesnoth/wesnoth/commit/b06259811d2741b1e775191591482c16ce9899e1 20181111 18:54:55< irker386> wesnoth: Celtic Minstrel wesnoth:master e01567c434f8 / data/schema/ (core/actionwml.cfg units/modifications.cfg): Schema: Promote [object]duration= key to non-ActionWML objects https://github.com/wesnoth/wesnoth/commit/e01567c434f8366b8cfb50f628654b4d591d830b 20181111 18:54:58< irker386> wesnoth: Celtic Minstrel wesnoth:master 902a10426873 / data/schema/ (5 files in 3 dirs): Schema: Fix several more cases of keys failing to accept variable substitutions https://github.com/wesnoth/wesnoth/commit/902a10426873f54813066554cf1ae229b987ae4a 20181111 18:55:00< irker386> wesnoth: Celtic Minstrel wesnoth:master 887b213f1868 / data/campaigns/Legend_of_Wesmere/scenarios/ (8 files in 3 dirs): LoW: Remove redundant AI definitions https://github.com/wesnoth/wesnoth/commit/887b213f186871bd44f2957a739e5fe1de7b7eb7 20181111 18:55:02< irker386> wesnoth: Celtic Minstrel wesnoth:master fe6f34cde998 / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg: LoW7: Fix invalid use of aspects in [unit][ai] https://github.com/wesnoth/wesnoth/commit/fe6f34cde9984ba9dcc7347cf35d68ec81b58123 20181111 18:55:03< irker386> wesnoth: Celtic Minstrel wesnoth:master 229a89418ad3 / data/campaigns/Legend_of_Wesmere/utils/characters.cfg: LoW: Fix erroneous used of unrenamable and canrecruit keys in [side] when there https://github.com/wesnoth/wesnoth/commit/229a89418ad34513a89da04e2606eef6f03e2b84 20181111 18:55:05< irker386> wesnoth: Celtic Minstrel wesnoth:master cfe4d120ee9f / data/schema/core/ (actionwml.cfg addons.cfg): Schema: Some missing [unit] keys and promote some [multiplayer] keys to [scenari https://github.com/wesnoth/wesnoth/commit/cfe4d120ee9f0a7db8b9eb463621683d8310a9e4 20181111 18:55:07< irker386> wesnoth: Celtic Minstrel wesnoth:master 9a966a46f5bd / data/schema/ (ai/modify.cfg game_config.cfg): Schema: Support omitting the final index in [modify_ai] paths https://github.com/wesnoth/wesnoth/commit/9a966a46f5bd243c967bde51445ce1f190f5ba79 20181111 18:55:09< irker386> wesnoth: Celtic Minstrel wesnoth:master 17b11271751f / data/schema/ai/goal.cfg: Schema: Fixup [goal] definition https://github.com/wesnoth/wesnoth/commit/17b11271751f7eee4de1f2f63f435127da92e240 20181111 18:55:11< irker386> wesnoth: Celtic Minstrel wesnoth:master c2c540fa1554 / data/core/macros/ai_controller.cfg: Fix error in AI control core macros https://github.com/wesnoth/wesnoth/commit/c2c540fa155440075f1f138aa3102be151c893df 20181111 18:55:13< irker386> wesnoth: Celtic Minstrel wesnoth:master 151a1fb66c38 / data/schema/ai/aspect_complex.cfg: Schema: Forgot id key in [leader_goal] https://github.com/wesnoth/wesnoth/commit/151a1fb66c383179108e9b38f893a41432d3a51c 20181111 18:55:16< irker386> wesnoth: Celtic Minstrel wesnoth:master 9b9fdf2c52d7 / data/schema/ai/aspect_simple.cfg: Schema: Simplify the simple non-scalar aspect definitions https://github.com/wesnoth/wesnoth/commit/9b9fdf2c52d7e0d476c280126af99f9788c88eee 20181111 18:55:17< irker386> wesnoth: Celtic Minstrel wesnoth:master 67c6de0a4e8d / data/schema/ai/ (aspect_complex.cfg aspect_simple.cfg): Schema: Accept variable substitution in most aspect values https://github.com/wesnoth/wesnoth/commit/67c6de0a4e8dc6782362d54ab6b62685956f57af 20181111 18:55:19< irker386> wesnoth: Celtic Minstrel wesnoth:master 3d05628fcfe7 / data/schema/units/single.cfg: Schema: Accept variable substitution in [unit] https://github.com/wesnoth/wesnoth/commit/3d05628fcfe72357a870d768d6dd909b70a05747 20181111 18:55:21< irker386> wesnoth: Celtic Minstrel wesnoth:master a71ce59a4e1a / data/schema/core/actionwml.cfg: Schema: Accept x,y=recall,recall in [unstore_unit] https://github.com/wesnoth/wesnoth/commit/a71ce59a4e1a8138f5672dae961449522acf5ed1 20181111 18:55:23< irker386> wesnoth: Celtic Minstrel wesnoth:master 36903bd2450a / data/campaigns/Legend_of_Wesmere/ (7 files in 5 dirs): LoW: Several small fixes (misplaced keys mostly) https://github.com/wesnoth/wesnoth/commit/36903bd2450a9890979bb022a4c972df80ac622f 20181111 18:55:25< irker386> wesnoth: Celtic Minstrel wesnoth:master 7bafab286b62 / data/schema/game_config.cfg: Schema: Don't accept omitted [] after all in [modify_ai] paths https://github.com/wesnoth/wesnoth/commit/7bafab286b6295c388a6336c3e83e500228dd4ef 20181111 18:55:28< irker386> wesnoth: Celtic Minstrel wesnoth:master e2bc73b27b19 / data/ (2 files in 2 dirs): Add omitted final [] to [modify_ai] paths in core macros and UtBS https://github.com/wesnoth/wesnoth/commit/e2bc73b27b1964239a57f2b3eb6ef6330441bbcf 20181111 18:55:30< irker386> wesnoth: Celtic Minstrel wesnoth:master 2746f5c2d8ea / src/terrain/filter.cpp: Support time_of_day=liminal in location filters. https://github.com/wesnoth/wesnoth/commit/2746f5c2d8ea5ee0e97b3c1eaa0e31bd197a6ffa 20181111 18:55:32< irker386> wesnoth: Celtic Minstrel wesnoth:master 66a33b2b3d29 / data/schema/filters/ (location.cfg unit.cfg weapon.cfg): Schema: Update filters with undocumented or poorly-documented features https://github.com/wesnoth/wesnoth/commit/66a33b2b3d2929ee3aeb2f28e26b5b639f592cd3 20181111 18:55:33< irker386> wesnoth: Celtic Minstrel wesnoth:master 72d8d300095f / data/schema/filters/weapon.cfg: Schema: Update weapon filter to note that lists are allowed here https://github.com/wesnoth/wesnoth/commit/72d8d300095f3050406cad5f5a7ef21f10779999 20181111 18:55:35< irker386> wesnoth: Celtic Minstrel wesnoth:master 71da996827d4 / data/schema/units/modifications.cfg: Schema: Add undocumented features for EffectWML https://github.com/wesnoth/wesnoth/commit/71da996827d4c91ca5cb2f1965a77310c0c2db9c 20181111 18:55:38< irker386> wesnoth: Celtic Minstrel wesnoth:master b9240e6f5d33 / data/schema/core/actionwml.cfg: Schema: Remove the condition on [endlevel] https://github.com/wesnoth/wesnoth/commit/b9240e6f5d33f013b3c2a36ada6770f8fd6eddf6 20181111 18:55:40< irker386> wesnoth: Celtic Minstrel wesnoth:master 2473bbd23771 / data/schema/core/actionwml.cfg: Schema: Fix incorrect type https://github.com/wesnoth/wesnoth/commit/2473bbd23771a89fb555e2d5ea259425d5e1f281 20181111 18:55:42< irker386> wesnoth: Celtic Minstrel wesnoth:master ffbb0931a03e / data/campaigns/Two_Brothers/scenarios/ (01_Rooting_Out_a_Mage.cfg 02_The_Chase.cfg): TB: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/ffbb0931a03e6faebda5a6bc40c87f458ce60be5 20181111 18:55:44< irker386> wesnoth: Celtic Minstrel wesnoth:master 0fba06c97788 / data/core/macros/unit-utils.cfg: Remove animate=no from {GUARDIAN} https://github.com/wesnoth/wesnoth/commit/0fba06c97788ec23391d84ae15c332abb9281a24 20181111 18:55:46< irker386> wesnoth: Celtic Minstrel wesnoth:master 6845b48697b6 / data/schema/ (core/actionwml.cfg game_config.cfg): Schema: Fix a few more instances of keys not accepting variable substitution https://github.com/wesnoth/wesnoth/commit/6845b48697b6176daa201c21ea6f8f6a54604fb5 20181111 18:55:48< irker386> wesnoth: Celtic Minstrel wesnoth:master cfd109d0ab4a / data/campaigns/The_South_Guard/scenarios/ (05_Choice_In_The_Fog.cfg 06a_Tidings_Good_and_Ill.cfg 06b_The_Long_March.cfg): TSG: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/cfd109d0ab4a63e45d3dd62b88e8e9b16f38bf3a 20181111 18:55:50< irker386> wesnoth: Celtic Minstrel wesnoth:master 90c98cab388b / data/campaigns/Heir_To_The_Throne/units/ (Battle_Princess.cfg Commander.cfg Fighter.cfg Lord.cfg Princess.cfg): HTTT: Unit variations don't need an ID https://github.com/wesnoth/wesnoth/commit/90c98cab388bd9aa61c8077506d7947ad5bd552b 20181111 18:55:52< irker386> wesnoth: Celtic Minstrel wesnoth:master 2232e49aa2b3 / data/schema/units/types.cfg: Schema: Add some undocumented keys and tags in [unit] https://github.com/wesnoth/wesnoth/commit/2232e49aa2b3deccb0314954c353c3212f6a12fe 20181111 18:55:54< irker386> wesnoth: Celtic Minstrel wesnoth:master ea9d4831497b / data/core/macros/items.cfg: [effect]apply_to=new_animation does not support name https://github.com/wesnoth/wesnoth/commit/ea9d4831497bbd08ee483892f4e7714b48deb2f9 20181111 18:55:56< irker386> wesnoth: Celtic Minstrel wesnoth:master 4ba0c2b8fd8f / data/schema/ (filters/location.cfg game_config.cfg units/modifications.cfg units/single.cfg): Schema: Fix a few incorrect types https://github.com/wesnoth/wesnoth/commit/4ba0c2b8fd8f4ba6b2087f499e92c8bf8e0b50cf 20181111 18:55:58< irker386> wesnoth: Celtic Minstrel wesnoth:master defea0679ffc / data/schema/ (core/addons.cfg core/mapgen/default.cfg core/mapgen/lua.cfg game_config.cfg): Schema: Definition of the [generator] tag https://github.com/wesnoth/wesnoth/commit/defea0679ffc9bd343c6393a9049e41c14a84d1b 20181111 18:56:00< irker386> wesnoth: Celtic Minstrel wesnoth:master fb7dce076fb5 / data/core/macros/terrain-utils.cfg: Use WFL instead of Lua code for {SCATTER_EMBELLISHMENTS} https://github.com/wesnoth/wesnoth/commit/fb7dce076fb55efa28465231796e6b0d6912b5a7 20181111 18:56:02< irker386> wesnoth: Celtic Minstrel wesnoth:master c4c6a8f0755c / data/campaigns/Heir_To_The_Throne/scenarios/ (4 files): HTTT: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/c4c6a8f0755cf635b5953bee26ef06faf56d5102 20181111 18:56:04< irker386> wesnoth: Celtic Minstrel wesnoth:master e83371b40cfd / data/schema/core/addons.cfg: Schema: Allow scenarios with no sides (is this expected?) https://github.com/wesnoth/wesnoth/commit/e83371b40cfd2918431c2b6ad5d000ed862495d3 20181111 18:56:06< irker386> wesnoth: Celtic Minstrel wesnoth:master d080c69356dd / data/schema/ (filters/unit.cfg game_config.cfg types/subst.cfg units/single.cfg): Schema: Fix a few more cases of keys and tags not accepting variable substitutio https://github.com/wesnoth/wesnoth/commit/d080c69356dd632878d582fe75cb02e4524cd121 20181111 18:56:08< irker386> wesnoth: Celtic Minstrel wesnoth:master a3d7339871a0 / data/campaigns/Liberty/scenarios/01_The_Raid.cfg: Liberty: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/a3d7339871a0bd72073ea6d8a28d9455ffed0979 20181111 18:56:10< irker386> wesnoth: Celtic Minstrel wesnoth:master eb041ca03425 / data/schema/core/ (actionwml.cfg addons.cfg): Schema: Add some undocumented child tags of ScenarioWML https://github.com/wesnoth/wesnoth/commit/eb041ca03425d05290fb179a5454dd0a6ae66fc1 20181111 18:56:12< irker386> wesnoth: Celtic Minstrel wesnoth:master 70ea5c9aaec9 / data/schema/core/actionwml.cfg: Schema: Another incorrect key type https://github.com/wesnoth/wesnoth/commit/70ea5c9aaec9ced042af9030439d0c93f5dbe65e 20181111 18:56:14< irker386> wesnoth: Celtic Minstrel wesnoth:master 5466a5b726e9 / data/campaigns/Eastern_Invasion/scenarios/ (5 files): EI: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/5466a5b726e9a1ecf6de3ddf3c9f96951ff9d73d 20181111 18:56:16< irker386> wesnoth: Celtic Minstrel wesnoth:master 1b10534e826b / data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg: HoT: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/1b10534e826b808b59d2fc8f731998a16024e7fe 20181111 18:56:18< irker386> wesnoth: Celtic Minstrel wesnoth:master 5da4a6ef5b0d / data/campaigns/Descent_Into_Darkness/scenarios/ (7 files): DiD: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/5da4a6ef5b0d474d4932e36aa6f9c0a67ac942a0 20181111 18:56:20< irker386> wesnoth: Celtic Minstrel wesnoth:master a8f767e88793 / data/schema/core/actionwml.cfg: Schema: Fix a few incorrect types https://github.com/wesnoth/wesnoth/commit/a8f767e887932741263ae63c96e49dd1c50923fa 20181111 18:56:22< irker386> wesnoth: Celtic Minstrel wesnoth:master 16f67880d2a5 / data/campaigns/Delfadors_Memoirs/scenarios/ (12_Terror_at_the_Ford_of_Parthyn.cfg 19_Showdown_in_the_Northern_Swamp.cfg): DM: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/16f67880d2a591c4d3090a4693e7ab16c2c7871d 20181111 18:56:24< irker386> wesnoth: Celtic Minstrel wesnoth:master ffbaa93d6a1b / data/schema/game_config.cfg: Schema: Fix typo https://github.com/wesnoth/wesnoth/commit/ffbaa93d6a1bdf67da0fa92950c25515d05658ac 20181111 18:56:26< irker386> wesnoth: Celtic Minstrel wesnoth:master a4c720fcb27d / data/campaigns/Dead_Water/scenarios/ (01_Invasion.cfg 04_Slavers.cfg): DW: Remove [message]duration key since it does absolutely nothing https://github.com/wesnoth/wesnoth/commit/a4c720fcb27d2971753cdc74ab719667364208e9 20181111 18:56:28< irker386> wesnoth: Celtic Minstrel wesnoth:master c10b7d9daec3 / data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg: DW: Fix a couple more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/c10b7d9daec3621dd3790b5d33670f7ba0cf86d8 20181111 18:56:30< irker386> wesnoth: Celtic Minstrel wesnoth:master 928f19768560 / data/campaigns/Secrets_of_the_Ancients/maps/ (16 files): SotA: Remove obsolete map headers https://github.com/wesnoth/wesnoth/commit/928f19768560f2cf3c3375f327dbc1cb0a2e30c6 20181111 18:56:32< irker386> wesnoth: Celtic Minstrel wesnoth:master 07e45f4158c9 / data/campaigns/Secrets_of_the_Ancients/ (5 files in 2 dirs): SotA: Remove weird terrain='' convention https://github.com/wesnoth/wesnoth/commit/07e45f4158c90e9ab2cac1bf7981f33c59d4879c 20181111 18:56:34< irker386> wesnoth: Celtic Minstrel wesnoth:master 96c705c795c5 / data/schema/core/addons.cfg: Schema: Make [event]name= optional https://github.com/wesnoth/wesnoth/commit/96c705c795c5a22d946fa207bfbc4666f6bba5e8 20181111 18:56:36< irker386> wesnoth: Celtic Minstrel wesnoth:master c7d9b6641ec8 / data/schema/core/actionwml.cfg: Schema: [micro_ai] AI-specific keys are only relevant if action is not delete https://github.com/wesnoth/wesnoth/commit/c7d9b6641ec808529c228ef7edbf09914f84ab25 20181111 18:56:38< irker386> wesnoth: Celtic Minstrel wesnoth:master 63da3ecd2a93 / data/schema/ (game_config.cfg units/modifications.cfg): Schema: Accept variable substitution in EffectWML https://github.com/wesnoth/wesnoth/commit/63da3ecd2a9365ea019dc5f58a862be56ca782a3 20181111 18:56:40< irker386> wesnoth: Celtic Minstrel wesnoth:master d86ac67b60aa / data/schema/core/addons.cfg: Schema: Missed an allowed key in [label] https://github.com/wesnoth/wesnoth/commit/d86ac67b60aa7bd96f101e06abf44a2035aa308f 20181111 18:56:42< irker386> wesnoth: Celtic Minstrel wesnoth:master c648612ed19c / data/campaigns/Secrets_of_the_Ancients/scenarios/ (5 files): SotA: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/c648612ed19cdffccd2f97f353d9a88abf133839 20181111 18:56:44< irker386> wesnoth: Celtic Minstrel wesnoth:master be1f48d940f2 / data/campaigns/Sceptre_of_Fire/scenarios/ (1_A_Bargain_is_Struck.cfg 8_The_Dragon.cfg 9_Caverns_of_Flame.cfg): SoF: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/be1f48d940f2cfe4a10955f9d31d6fd868d04bc5 20181111 18:56:46< irker386> wesnoth: Celtic Minstrel wesnoth:master ed137c1f853c / data/schema/core/actionwml.cfg: Schema: Allow variable substitution for fake unit genders https://github.com/wesnoth/wesnoth/commit/ed137c1f853c66e6bb2ba455e011b67961aee1ef 20181111 18:56:48< irker386> wesnoth: Celtic Minstrel wesnoth:master 67bf120031f1 / data/campaigns/Northern_Rebirth/scenarios/ (9 files): NR: Explicitly specify redundant side parameter in unit macros https://github.com/wesnoth/wesnoth/commit/67bf120031f182304802f29d5a2ac058b794db83 20181111 18:56:50< irker386> wesnoth: Celtic Minstrel wesnoth:master cb5a7b2d27ea / data/campaigns/Northern_Rebirth/scenarios/ (08b_Ray_of_Hope.cfg 10a_Stolen_Gold.cfg 13a_Showdown.cfg): NR: [ai]villages_per_scout= is an integer https://github.com/wesnoth/wesnoth/commit/cb5a7b2d27ea3f47ee6cb5dd1b0dcbaf26ae7c1e 20181111 18:56:52< irker386> wesnoth: Celtic Minstrel wesnoth:master 7b34a843b19c / data/campaigns/Northern_Rebirth/scenarios/ (10a_Stolen_Gold.cfg 12a_Get_the_Gold.cfg 13a_Showdown.cfg): NR: [store_unit] does not support fire_event https://github.com/wesnoth/wesnoth/commit/7b34a843b19c5d849f084f1a3024602722bad66f 20181111 18:56:54< irker386> wesnoth: Celtic Minstrel wesnoth:master 7dff2a1f7e32 / data/campaigns/Northern_Rebirth/scenarios/ (4 files): NR: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/7dff2a1f7e32fb83857f120550131624c89ebc59 20181111 18:56:56< irker386> wesnoth: Celtic Minstrel wesnoth:master d19b4cde5747 / data/campaigns/Under_the_Burning_Suns/scenarios/ (5 files): UtBS: [objectives] does not support show= https://github.com/wesnoth/wesnoth/commit/d19b4cde5747068489bece705b784fe95ff8bfa5 20181111 18:56:58< irker386> wesnoth: Celtic Minstrel wesnoth:master 9225d757d722 / data/campaigns/Under_the_Burning_Suns/scenarios/ (10 files): UtBS: [scenario]snapshot= doesn't seem like it would have any useful effect https://github.com/wesnoth/wesnoth/commit/9225d757d72228836e28d92417c5c97e10f5f898 20181111 18:57:00< irker386> wesnoth: Celtic Minstrel wesnoth:master c53076186355 / data/campaigns/Under_the_Burning_Suns/scenarios/ (06a_In_the_Tunnels_of_Trolls.cfg 06b_In_the_Domain_of_Dwarves.cfg): UtBS: silent= is meaningless in [object][modifications] https://github.com/wesnoth/wesnoth/commit/c53076186355348d5aebae554e550cb5d30dd8a1 20181111 18:57:02< irker386> wesnoth: Celtic Minstrel wesnoth:master 42f8ce442dee / data/campaigns/Under_the_Burning_Suns/scenarios/ (6 files): UtBS: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/42f8ce442dee078311c449532603e8db34bd339f 20181111 18:57:04< irker386> wesnoth: Celtic Minstrel wesnoth:master 9fc1dde19cb0 / data/schema/core/mapgen/lua.cfg: Schema: Apparently config_name IS valid in [generator] https://github.com/wesnoth/wesnoth/commit/9fc1dde19cb0d305c679e5135a65f039f1d2c960 20181111 18:57:06< irker386> wesnoth: Celtic Minstrel wesnoth:master 60b041497fa3 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (21_The_Plan.cfg 23_Epilogue.cfg): TRoW: Fix a couple of issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/60b041497fa332629548b397d77d41aff57369aa 20181111 18:57:08< irker386> wesnoth: Celtic Minstrel wesnoth:master 8d7bfe1bb5c8 / data/campaigns/Heir_To_The_Throne/ (scenarios/01_The_Elves_Besieged.cfg utils/intro.cfg): HTTT: Fix toplevel [story] https://github.com/wesnoth/wesnoth/commit/8d7bfe1bb5c88c9b6fabadd94f873dce13e819ad 20181111 18:57:10< irker386> wesnoth: Celtic Minstrel wesnoth:master f253f7b98a72 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (15 files): TRoW: [scenario] does not support bonus=yes https://github.com/wesnoth/wesnoth/commit/f253f7b98a72f887bfdd15b4c44746f391fc40fa 20181111 18:57:12< irker386> wesnoth: Celtic Minstrel wesnoth:master 631d1e796351 / data/campaigns/The_Rise_Of_Wesnoth/ (scenarios/16_The_Kalian.cfg units/Kalian.cfg): TRoW: [unit]image= is not supported https://github.com/wesnoth/wesnoth/commit/631d1e796351a950cda49dd70dfe52b62e302ca5 20181111 18:57:14< irker386> wesnoth: Celtic Minstrel wesnoth:master c5ec9b1ec148 / data/campaigns/ (2 files in 2 dirs): HTTT, SoF: Fix a couple more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/c5ec9b1ec14856ef78a1ad91ea67f88d4086339a 20181111 18:57:16< irker386> wesnoth: Celtic Minstrel wesnoth:master 8c99f9bafe2d / data/scenario-test.cfg: Test scenario: remove useless [object]silent=yes https://github.com/wesnoth/wesnoth/commit/8c99f9bafe2db2fc48e675df8b58d41a9e52675f 20181111 18:57:18< irker386> wesnoth: Celtic Minstrel wesnoth:master f0bff9473ec7 / data/scenario-test.cfg: Test scenario: Fix invalid [message] key https://github.com/wesnoth/wesnoth/commit/f0bff9473ec7d15f4b8ed36446e6faf12ffdf633 20181111 18:57:20< irker386> wesnoth: Celtic Minstrel wesnoth:master 923e408c7165 / data/scenario-story.cfg: Story test scenario: Fix misplaced duplicate map data https://github.com/wesnoth/wesnoth/commit/923e408c7165a066435a52adb22b2170d5c8a9fc 20181111 18:57:22< irker386> wesnoth: Celtic Minstrel wesnoth:master b2a6f9dacd32 / data/campaigns/Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg: LoW: [scenario]snapshot= is not supported https://github.com/wesnoth/wesnoth/commit/b2a6f9dacd3274dddd4124faa14afe94e0b5390d 20181111 18:57:24< irker386> wesnoth: Celtic Minstrel wesnoth:master 96f154716a25 / data/lua/wml/endlevel.lua: Fix misleading function name in [endlevel] definition https://github.com/wesnoth/wesnoth/commit/96f154716a252b92d8f25a3f40e71b7d922d7ca4 20181111 18:57:26< irker386> wesnoth: Celtic Minstrel wesnoth:master 604a3ec94156 / data/schema/core/actionwml.cfg: Schema: It turns out that [endlevel]bonus= is actually a real number! https://github.com/wesnoth/wesnoth/commit/604a3ec94156422f80b2b2f4462a224f3a173226 20181111 18:57:28< irker386> wesnoth: Celtic Minstrel wesnoth:master 56cbabcae93b / data/campaigns/Legend_of_Wesmere/scenarios/chapter3/12_Revelations.cfg: LoW MP: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/56cbabcae93bfb467a2659978997a512d0584231 20181111 18:57:30< irker386> wesnoth: Celtic Minstrel wesnoth:master 2a5e8c7b4144 / data/schema/ (core/actionwml.cfg game_config.cfg): Schema: side=global is valid in [*_global_variable] https://github.com/wesnoth/wesnoth/commit/2a5e8c7b414462782233f4a9901a2105be2318f7 20181111 18:57:32< irker386> wesnoth: Celtic Minstrel wesnoth:master ebc6285683a9 / data/schema/core/addons.cfg: Schema: Allow variable substitution in [label] https://github.com/wesnoth/wesnoth/commit/ebc6285683a9a1cd031ae1f9a1d1a952791c9259 20181111 18:57:34< irker386> wesnoth: Celtic Minstrel wesnoth:master 66ae7f3b1349 / data/schema/core/actionwml.cfg: Schema: Accept variable substitution in [set_variable] root= and round= https://github.com/wesnoth/wesnoth/commit/66ae7f3b1349ba47723e49dbd5dd0edf91ac0f7d 20181111 18:57:36< irker386> wesnoth: Celtic Minstrel wesnoth:master bc2054ec103c / data/schema/core/actionwml.cfg: Schema: Fix some tags being allowed only once instead of unlimited times https://github.com/wesnoth/wesnoth/commit/bc2054ec103c9b22d386c8304c2849d62258f113 20181111 18:57:38< irker386> wesnoth: Celtic Minstrel wesnoth:master 61ee9bcf6b4b / data/schema/game_config.cfg: Schema: Don't fail if a map contains trailing or leading whitespace on lines https://github.com/wesnoth/wesnoth/commit/61ee9bcf6b4bf9d6c399a8bd4aa43f2b12b7c1ef 20181111 18:57:40< irker386> wesnoth: Celtic Minstrel wesnoth:master 3a3f0d25afe4 / data/schema/units/modifications.cfg: Schema: Accept color ranges/palettes defined in [effect]apply_to=image_mod https://github.com/wesnoth/wesnoth/commit/3a3f0d25afe48555285a38fb6b4232e33f37b422 20181111 18:57:42< irker386> wesnoth: Celtic Minstrel wesnoth:master 51764956e331 / data/schema/game_config.cfg: Schema: Fix typo in [store_unit] https://github.com/wesnoth/wesnoth/commit/51764956e331564592d83460bd5a6647ca085448 20181111 18:57:44< irker386> wesnoth: Celtic Minstrel wesnoth:master d70fee5afcfa / data/schema/ai/aspect_complex.cfg: Schema: Fix issue with matching [modify_ai] for attacks aspect https://github.com/wesnoth/wesnoth/commit/d70fee5afcfacd16ad8476bb5b7abb9401fa18e5 20181111 18:57:46< irker386> wesnoth: Celtic Minstrel wesnoth:master 32a3dc5835c4 / data/schema/game_config.cfg: Schema: Accept logger=log as a synonym for logger=info https://github.com/wesnoth/wesnoth/commit/32a3dc5835c437090d1c7fc1a100c19e70107640 20181111 18:57:48< irker386> wesnoth: Celtic Minstrel wesnoth:master a50a3f399bcc / data/schema/ (core/actionwml.cfg game_config.cfg): Schema: Accept [set_menu_item]use_hotkey=only https://github.com/wesnoth/wesnoth/commit/a50a3f399bcc2f6cbeccda262bf4e180a4f75275 20181111 18:57:50< irker386> wesnoth: Celtic Minstrel wesnoth:master 02da99638a20 / data/ (3 files in 3 dirs): Fix a few schema issues in some of the interactive test scenarios https://github.com/wesnoth/wesnoth/commit/02da99638a20cf8500e36139bf085160791f99e3 20181111 18:57:52< irker386> wesnoth: Celtic Minstrel wesnoth:master bf814914e16e / data/schema/core/actionwml.cfg: Schema: Fix some bugs in the [micro_ai] definition https://github.com/wesnoth/wesnoth/commit/bf814914e16eadd7e004171e291b11ac6e2d2bf0 20181111 18:57:54< irker386> wesnoth: Celtic Minstrel wesnoth:master 2410c9671c5a / data/ai/micro_ais/scenarios/ (7 files): MicroAI Tests: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/2410c9671c5af6b304a9e55be8377a79bfafb194 20181111 18:57:56< irker386> wesnoth: Celtic Minstrel wesnoth:master 68bb024efe96 / data/schema/core/actionwml.cfg: Schema: Accept variable substitution in [do_command] https://github.com/wesnoth/wesnoth/commit/68bb024efe967b1b86349bd8a6711a79bc0d353e 20181111 18:57:58< irker386> wesnoth: Celtic Minstrel wesnoth:master e47ace53a96c / data/schema/core/actionwml.cfg: Schema: Fix a couple more missing details https://github.com/wesnoth/wesnoth/commit/e47ace53a96cc78cb8421f154ef58dd7f9baa627 20181111 18:58:00< irker386> wesnoth: Celtic Minstrel wesnoth:master 8b9d317d720a / data/test/ (maps/pathfind_1.cfg scenarios/test_menu_items.cfg): WML Unit Tests: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/8b9d317d720a705e8e5a537d588040d8f15dbd04 20181111 18:58:02< irker386> wesnoth: Celtic Minstrel wesnoth:master bc0419fc0a3c / src/serialization/ (schema_validator.cpp schema_validator.hpp tag.hpp): Some refactoring of the default schema validator to make it extensible https://github.com/wesnoth/wesnoth/commit/bc0419fc0a3ca670cf6d47ad74b79e660e1b26be 20181111 18:58:04< irker386> wesnoth: Celtic Minstrel wesnoth:master c765bac5d0af / src/serialization/ (schema_validator.cpp schema_validator.hpp): Add a function to the schema validator that I didn't end up needing https://github.com/wesnoth/wesnoth/commit/c765bac5d0af5923f858019e642418aa9887f53a 20181111 18:58:06< irker386> wesnoth: Celtic Minstrel wesnoth:master 844b20da4011 / data/schema/gui.cfg: GUI2 Schema: Use max=infinite instead of max=-1 https://github.com/wesnoth/wesnoth/commit/844b20da401182186db34bb15dd4a07ba448eaf0 20181111 18:58:08< irker386> wesnoth: Celtic Minstrel wesnoth:master e3b17d3e9f75 / data/schema/ (gui.cfg macros.cfg): GUI2 Schema: Make use of the key macros https://github.com/wesnoth/wesnoth/commit/e3b17d3e9f757c1c4e88f86b0cad812f81ecff0c 20181111 18:58:10< irker386> wesnoth: Celtic Minstrel wesnoth:master 4674e97eb6a5 / data/schema/ (14 files in 6 dirs): Schema: Add a macro for links (and make use of it) https://github.com/wesnoth/wesnoth/commit/4674e97eb6a517ccc966d3fb902f756060cea1d9 20181111 18:58:12< irker386> wesnoth: Celtic Minstrel wesnoth:master 52c4dc0e3d13 / / (12 files in 7 dirs): Add a validator subclass specialized for validating WML schemas against the WML https://github.com/wesnoth/wesnoth/commit/52c4dc0e3d130e1d6dfb6b2ca8defb1621cd31c7 20181111 18:58:14< irker386> wesnoth: Celtic Minstrel wesnoth:master 8ef0c1734d71 / / (5 files in 2 dirs): Add several command-line options to invoke the schema validator https://github.com/wesnoth/wesnoth/commit/8ef0c1734d717898c9505dd5fce0ad29898dca49 20181111 18:58:16< irker386> wesnoth: Celtic Minstrel wesnoth:master df4413ae668b / data/schema/ (game_config.cfg types/lists.cfg): Schema: Move list types into a separate config file https://github.com/wesnoth/wesnoth/commit/df4413ae668b68f27af8adba15fbf2c75083444d 20181111 18:58:18< irker386> wesnoth: Celtic Minstrel wesnoth:master a32e279b7cf1 / / (12 files in 4 dirs): Split tag.hpp into three files https://github.com/wesnoth/wesnoth/commit/a32e279b7cf13c23499dfb28dd6d83c1b2de8de7 20181111 18:58:20< irker386> wesnoth: Celtic Minstrel wesnoth:master f13bd92fb1ee / src/serialization/ (8 files in 2 dirs): Rename classes to remove class_ prefix https://github.com/wesnoth/wesnoth/commit/f13bd92fb1eed7b52f7862ad560ab72acba8043b 20181111 18:58:22< irker386> wesnoth: Celtic Minstrel wesnoth:master 639787e1c9d8 / / (264 files in 55 dirs): Merge pull request #2562 from wesnoth/schema https://github.com/wesnoth/wesnoth/commit/639787e1c9d8a8ffca9a10ab0e191513c31306aa 20181111 19:11:17-!- travis-ci [~travis-ci@ec2-54-205-118-94.compute-1.amazonaws.com] has joined #wesnoth-dev 20181111 19:11:18< travis-ci> wesnoth/wesnoth#20155 (master - 639787e : Celtic Minstrel): The build was broken. 20181111 19:11:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453651257 20181111 19:11:18-!- travis-ci [~travis-ci@ec2-54-205-118-94.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181111 19:23:27< celticminstrel> (Working on it.) 20181111 19:45:01< irker386> wesnoth/wesnoth:master ProditorMagnus aa4cb16b68 fix modify_unit split_to_array function AppVeyor: All builds passed 20181111 19:49:22-!- sevu [~sevu@edu243012.nat.uni-leipzig.de] has joined #wesnoth-dev 20181111 19:54:41<+wesdiscordbot> hey does Google still run a summer of code for high school students? 20181111 19:55:08<+wesdiscordbot> Yes 20181111 19:55:14<+wesdiscordbot> whats it called again? 20181111 19:55:19<+wesdiscordbot> Google Code-IN 20181111 19:55:21<+wesdiscordbot> *In 20181111 19:55:53<+wesdiscordbot> thank you. HAve we considered doing Summer of Code since we stopped doing it in 2014 (or whenever)? 20181111 19:56:35<+wesdiscordbot> Considered only insofar I declined to pursue it when it was my turn to decide during Q1 2015, and no-one else made any kind of effort towards that 20181111 19:57:01<+wesdiscordbot> yeah, that's fine. 20181111 19:57:08<+wesdiscordbot> just curious 20181111 19:57:10<+wesdiscordbot> Then in subsequent years Vultraz may or may not have gone with the same reasoning I had when I was project admin 20181111 19:57:33<+wesdiscordbot> Which is that without a development team with capable mentors there was no point to even apply 20181111 19:58:01<+wesdiscordbot> And the people who could've potentially served as mentors had too much on their plates to actually be able to dedicate time to that task without neglecting everything else 20181111 19:58:39<+wesdiscordbot> IMHO, participating wouldn't be a good idea. It tends to lean towards implementing new features instead of bug fixes and improvements which would be what we need more. And it would likely end up causing us even more issues (for example, the whiteboard has been a source for bugs all over the place). And the point about taking time away from actual developers is true, too. 20181111 19:59:30<+wesdiscordbot> I remember saying at some point (possibly in a private convo with vultraz in 2015) that SoC gave us more technical debt than it took away from us, with the only notable exceptions being the AI refactor (Crab) and Map Editor (ilor) 20181111 20:00:18<+wesdiscordbot> Some people tried several times to suggest making "fixing bugs" a project but that's not a thing that can be reasonably carried out within the SoC framework 20181111 20:24:10<+wesdiscordbot> project haldric could use some hands for features. though I'm not sure if it's suitable, because currently it's still mostly just me and I'm not sure if I could maintain / bugfix all the new features afterwards when I haven't wrote the code myself. 20181111 20:27:15-!- sevu [~sevu@edu243012.nat.uni-leipzig.de] has quit [Remote host closed the connection] 20181111 20:32:52< irker386> wesnoth: Celtic Minstrel wesnoth:master 2ee2f4d33f56 / src/ (5 files in 3 dirs): Fix various compiler warnings/errors from Travis https://github.com/wesnoth/wesnoth/commit/2ee2f4d33f56463d19a293eae0ff6cd661bf9acf 20181111 20:47:18-!- travis-ci [~travis-ci@ec2-54-226-93-95.compute-1.amazonaws.com] has joined #wesnoth-dev 20181111 20:47:18< travis-ci> wesnoth/wesnoth#20156 (master - 2ee2f4d : Celtic Minstrel): The build is still failing. 20181111 20:47:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453680783 20181111 20:47:18-!- travis-ci [~travis-ci@ec2-54-226-93-95.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181111 21:01:15< irker386> wesnoth: Celtic Minstrel wesnoth:master 6c54451e2a99 / src/serialization/schema/tag.cpp: fixup https://github.com/wesnoth/wesnoth/commit/6c54451e2a999958d76e82a3828b2cb756c2c87d 20181111 21:01:17< irker386> wesnoth: Celtic Minstrel wesnoth:master 6ed57cdc705f / src/gui/dialogs/lua_interpreter.cpp: Fix crash when invoking Lua console from the main menu https://github.com/wesnoth/wesnoth/commit/6ed57cdc705fab5728b1e9d7718270b9cff00cc7 20181111 21:01:19< irker386> wesnoth: Celtic Minstrel wesnoth:master 20e85aa417ee / changelog.md data/lua/core.lua src/scripting/lua_kernel_base.cpp: Lua API: Add wml.load and wml.parse functions https://github.com/wesnoth/wesnoth/commit/20e85aa417ee993e5d7b00a67295cdd994f486a1 20181111 21:10:10< celticminstrel> Still failing is because I forgot to stage one thing. :/ 20181111 21:11:44< celticminstrel> Apparently no-one ever mentioned on the wiki that [side]no_leader is deprecated. 20181111 21:11:59< celticminstrel> Possibly even obsolete. 20181111 21:12:22< celticminstrel> I forget if it actually still does anything... I think it does though? 20181111 21:13:20<+wesdiscordbot> I think the same like lock_leader=yes 20181111 21:13:33<+wesdiscordbot> gfgtdf implemented it IIRC 20181111 21:13:46< celticminstrel> Yeah. :/ 20181111 21:19:17< irker386> wesnoth/wesnoth:master josteph b3c38f3053 Refine unplagueable/unpoisonable checks AppVeyor: All builds passed 20181111 21:56:49<+wesdiscordbot> @Bitron I'll try to help out more once lua is in. I just have very little interest in GDScript. 20181111 22:10:14-!- travis-ci [~travis-ci@ec2-54-205-206-170.compute-1.amazonaws.com] has joined #wesnoth-dev 20181111 22:10:15< travis-ci> wesnoth/wesnoth#20159 (master - 20e85aa : Celtic Minstrel): The build is still failing. 20181111 22:10:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453689967 20181111 22:10:15-!- travis-ci [~travis-ci@ec2-54-205-206-170.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181111 22:46:49< mattsc> Ugh. Adding [recruit]allow_recall= to the recruitment_instructions aspect will take more changes to the AI recruiting code than I had hoped … 20181111 23:24:08<+wesdiscordbot> @Bitron Making the discussion channel public would help attract developers. 20181111 23:25:28-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181111 23:29:57<+wesdiscordbot> It will be made public again when we actually have something to show. If people are interested, they still can ask for permission for the channel. Also, everyone can see the github channel, iirc, so that's also a point to follow. Currently it's just a mess in a language none of the devs seem to want to write in. x) But there is progress, non the less. 20181111 23:30:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20181111 23:30:20<+wesdiscordbot> Indeed. It's not meant for everyone right now. 20181111 23:31:34<+wesdiscordbot> I specifically do not want it public yet. 20181111 23:34:01<+wesdiscordbot> Fair enough, have fun then πŸ˜„ 20181111 23:34:10-!- valdar [~atarocch@93.56.172.28] has quit [Read error: Connection reset by peer] 20181111 23:34:31<+wesdiscordbot> Vultraz, while you're here, what about releasing 1.15.0 development release from master, now that schema and ai are merged 20181111 23:35:31-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20181111 23:37:40<+wesdiscordbot> the ai controller stuff? 20181111 23:39:54< mattsc> @Vultraz: @josteph probably means the Lua AI PR #3655. But the AI controller is in also. 20181111 23:40:47<+wesdiscordbot> right 20181111 23:50:09< celticminstrel> Not until after I fix Travis obviously. 20181111 23:50:27< celticminstrel> Unless of course someone else fixes it. 20181111 23:50:57< celticminstrel> Oh, looks like it's just -Wreorder again. 20181111 23:51:17< celticminstrel> That's a super-annoying one since cl.exe doesn't seem to have an equivalent. 20181111 23:54:33< celticminstrel> Does anyone know where I can find the WML output functionality... would it be in serialization/parser.cpp? Surely not? 20181111 23:54:53< celticminstrel> I mean the code that writes a config to a file. 20181111 23:55:15<+wesdiscordbot> somewhere in serialization 20181111 23:55:54< celticminstrel> Hmm, binary_or_text.hpp has a config_writer class but that seems not quite what I need... 20181111 23:56:16< celticminstrel> (Also why the hell is the file called binary_or_text.hpp when it literally only contains that class? Shouldn't we rename that file?) 20181111 23:56:16< irker386> wesnoth/wesnoth:1.14 nemaara fb190e5207 TSG S5: reduced enemy income AppVeyor: All builds passed 20181111 23:56:33<+wesdiscordbot> I have no idea 20181111 23:56:42<+wesdiscordbot> the filename was probably correct at some point in the past 20181111 23:56:57<+wesdiscordbot> IVSTR something about that file 20181111 23:56:58<+wesdiscordbot> but idk 20181111 23:57:18< celticminstrel> Looks like the write functionality actually is in parser.cpp. 20181111 23:59:42< celticminstrel> Question: Should I: a) Change wml.tostring() and wesnoth.debug() to do a proper config serialization? b) Change them to take an extra boolean argument to distinguish between proper serialization and quick serialization for debugging? c) Leave wesnoth.debug() as it is but change wml.tostring() as in a)? --- Log closed Mon Nov 12 00:00:32 2018