--- Log opened Mon Nov 12 00:00:32 2018
20181112 00:01:07< celticminstrel> Or maybe d) Add a new wml.* function that does a proper serialization?
20181112 00:02:14<+wesdiscordbot> <Vultraz> not good to have boolean for stuff like that
20181112 00:08:49< celticminstrel> I kinda agree, but that doesn't help me choose between a, c, and d.
20181112 00:09:26< celticminstrel> The only visual difference between "proper" and "quick" serialization is:
20181112 00:09:49< celticminstrel> - Proper serialization includes textdomain declarations if you had translatable strings.
20181112 00:10:09< celticminstrel> - Proper serialization quotes all string values and includes the translation mark if the string was translatable.
20181112 00:10:10<+wesdiscordbot> <Vultraz> since when was tostring for serialization?
20181112 00:10:19< celticminstrel> It wasn't originally.
20181112 00:10:40< celticminstrel> Originally it was wesnoth.debug().
20181112 00:11:03< celticminstrel> Anyway, the quick serialization does neither of those things I mentioned.
20181112 00:12:10< celticminstrel> So it wasn't originally for serialization, but I find it weird if wml.parse(wml.tostring(cfg)) is a lossy operation.
20181112 00:13:09< celticminstrel> Also weird if wml.tostring(wml.parse(some_string)) is lossy, though less weird than the other one.
20181112 00:13:12<+wesdiscordbot> <josteph> how is it currently?
20181112 00:13:20<+wesdiscordbot> <josteph> .tostring() is quick serialization and .debug() is proper serialization?
20181112 00:13:30< celticminstrel> @josteph Currently they are both the quick serialization.
20181112 00:13:38< celticminstrel> Because wml.tostring is just an alias of wesnoth.debug.
20181112 00:14:10< celticminstrel> Is there a point in having both in the Lua API? I'm not sure TBH.
20181112 00:14:24<+wesdiscordbot> <josteph> I assume there are no compatibility considerations for .debug
20181112 00:14:31< celticminstrel> What do you mean?
20181112 00:14:42<+wesdiscordbot> <josteph> We can change .debug in a backwards incompatible manner
20181112 00:14:52<+wesdiscordbot> <josteph> I'm not sure that's also true for .tostring
20181112 00:15:03< celticminstrel> Given that parsing WML from Lua was not possible until now, I think you are correct about wesnoth.debug().
20181112 00:15:24< celticminstrel> And given that wml.tostring is a very-recently-added alias of wesnoth.debug, I'm not sure why the situation would be any different there.
20181112 00:16:56<+wesdiscordbot> <Vultraz> ...haven't we had a tostring for a long time?
20181112 00:17:18< celticminstrel> That depends on what you mean by "a tostring"?
20181112 00:17:34<+wesdiscordbot> <Vultraz> I know I've used a tostring function in the past 🤔
20181112 00:17:40<+wesdiscordbot> <Vultraz> perhaps that's a lua core function...?
20181112 00:17:54< celticminstrel> I'm talking about wml.tostring, not global tostring.
20181112 00:18:05< celticminstrel> Global tostring is indeed a core Lua function.
20181112 00:18:11<+wesdiscordbot> <Vultraz> ah
20181112 00:18:12<+wesdiscordbot> <josteph> is wml.tostring in 1.14 ?
20181112 00:18:15< celticminstrel> Yes.
20181112 00:18:29< celticminstrel> But I doubt it has any use in 1.14 besides dumping configs for debugging.
20181112 00:18:35<+wesdiscordbot> <Vultraz> it's dumb to have two functions that do the same thing
20181112 00:18:48< celticminstrel> If you mean wml.tostring vs tostring, there's no way around it.
20181112 00:19:03< celticminstrel> Unless we make our WML tables have a custom metatable or something.
20181112 00:19:17<+wesdiscordbot> <Vultraz> i meant wml.debug and wml.tostring
20181112 00:19:40< celticminstrel> Well, that's because of the API reorganization and is temporary.
20181112 00:19:47< celticminstrel> wesnoth.debug is deprecated in favour of wml.tostring.
20181112 00:20:40<+wesdiscordbot> <Vultraz> then just make tostring proper
20181112 00:25:57<+wesdiscordbot> <josteph> is there any UMC using wml.tostring that would be affected?
20181112 00:26:18< celticminstrel> Even if there is any UMC using it, I doubt it would be broken.
20181112 00:26:22<+wesdiscordbot> <josteph> also I don't know how .tostring methods are expected to behave in lua in general
20181112 00:26:37< celticminstrel> FTR, changing wml.tostring also affects wesnoth.debug unless I take extra steps to split them.
20181112 00:26:49<+wesdiscordbot> <josteph> then it sounds like there's no compatibility considerations, so just design it however you think is best
20181112 00:27:09<+wesdiscordbot> <josteph> I don't see a problem with making .debug emit more detailed output
20181112 00:44:08< irker386> wesnoth: Celtic Minstrel wesnoth:master 45689305eb6c / src/commandline_options.cpp: fixup -Wreorder https://github.com/wesnoth/wesnoth/commit/45689305eb6cdd1d2138e78eec6bacb66d3f12a2
20181112 00:44:10< irker386> wesnoth: Celtic Minstrel wesnoth:master e692294532f5 / changelog.md src/scripting/lua_kernel_base.cpp: Lua API: Make wml.tostring a lossless conversion https://github.com/wesnoth/wesnoth/commit/e692294532f5b647ad5739614a11c1eebbf50884
20181112 00:44:12< irker386> wesnoth: Celtic Minstrel wesnoth:master 3016d928118b / changelog.md src/scripting/lua_kernel_base.cpp: Lua API: Add wml.clone() https://github.com/wesnoth/wesnoth/commit/3016d928118b8ab42081308c40ae58e6230dcca8
20181112 00:44:14< irker386> wesnoth: Celtic Minstrel wesnoth:master d732ef00c2d5 / src/scripting/lua_kernel_base.cpp: Lua API: Allow specifying a schema for wml.parse() https://github.com/wesnoth/wesnoth/commit/d732ef00c2d58322afd308a7eac1be6a4f42aab5
20181112 00:53:00< irker386> wesnoth: Celtic Minstrel wesnoth:master 40bf04ec8e16 / data/lua/helper.lua: Rewrite helper.move_unit_fake to not use a WML variable https://github.com/wesnoth/wesnoth/commit/40bf04ec8e166f7bdd1b844d7e38a80a151bf450
20181112 00:56:56-!- travis-ci [~travis-ci@ec2-54-163-81-59.compute-1.amazonaws.com] has joined #wesnoth-dev
20181112 00:56:57< travis-ci> wesnoth/wesnoth#20160 (master - d732ef0 : Celtic Minstrel): The build is still failing.
20181112 00:56:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453743193
20181112 00:56:57-!- travis-ci [~travis-ci@ec2-54-163-81-59.compute-1.amazonaws.com] has left #wesnoth-dev []
20181112 01:01:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181112 01:03:11< irker386> wesnoth: Celtic Minstrel wesnoth:master 98859320113e / data/lua/helper.lua: Use wml.tag in helper.get_user_choice https://github.com/wesnoth/wesnoth/commit/98859320113ee6f14688f96c80f7bb4da5fd7ff7
20181112 01:03:13< irker386> wesnoth: Celtic Minstrel wesnoth:master b94ccf902099 / data/lua/helper.lua: Rewrite helper.modify_unit to not use a WML variable https://github.com/wesnoth/wesnoth/commit/b94ccf9020994ce4d8d2b844f20bfec80647451d
20181112 01:04:45<+wesdiscordbot> <sevu> https://cdn.discordapp.com/attachments/259976436490829825/511345568312983552/lua.png
20181112 01:05:20<+wesdiscordbot> <sevu> The line (804) is: bonus = bonus + 0.03 * wesnoth.races[wesnoth.unit_types[recruit_id].__cfg.race].num_traits^2
20181112 01:06:52<+wesdiscordbot> <sevu> It may be due to the race not being properly set up in the add-on
20181112 01:07:12< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg b42c5ba3d3e6 / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module https://github.com/wesnoth/wesnoth/commit/b42c5ba3d3e620b9c64a789745bd3989e36b6873
20181112 01:07:14< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg f45f239e28df / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module deprecations https://github.com/wesnoth/wesnoth/commit/f45f239e28df93626fc8e67fb7b8fa1bcb2fbb67
20181112 01:07:16< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg da1310babd26 / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module https://github.com/wesnoth/wesnoth/commit/da1310babd260df36bc292bf926e2e104e5dcadc
20181112 01:07:18< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg 160f90dceb1b / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module deprecations https://github.com/wesnoth/wesnoth/commit/160f90dceb1ba57d08630cfed75bc566a8a69014
20181112 01:07:20< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg 7b20c6250df6 / data/lua/core.lua: Lua GUI module: minor fix, plus name changes from discussions https://github.com/wesnoth/wesnoth/commit/7b20c6250df684827262c0b8c11e5506801bf7cc
20181112 01:07:22< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg 144c72859c57 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module https://github.com/wesnoth/wesnoth/commit/144c72859c570b2ec6130f746b2a5e753b1a48e6
20181112 01:07:24< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg 7cf27e1522a7 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module deprecations https://github.com/wesnoth/wesnoth/commit/7cf27e1522a7e0d411c34eb6f133941b5ec91a78
20181112 01:07:26< irker386> wesnoth: Celtic Minstrel wesnoth:lua_reorg 1a4df4051b7c / data/lua/ (core.lua helper.lua): Deprecate helper.wml_error and move it to wml.error https://github.com/wesnoth/wesnoth/commit/1a4df4051b7ce7416725b5f2343445005b4a5234
20181112 01:07:33-!- travis-ci [~travis-ci@ec2-54-205-164-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20181112 01:07:34< travis-ci> wesnoth/wesnoth#20161 (master - 40bf04e : Celtic Minstrel): The build is still failing.
20181112 01:07:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453744812
20181112 01:07:34-!- travis-ci [~travis-ci@ec2-54-205-164-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20181112 01:08:16<+wesdiscordbot> <sevu> @mattsc ^
20181112 01:08:23<+wesdiscordbot> <sevu> (1.14 branch)
20181112 01:44:40-!- travis-ci [~travis-ci@ec2-54-198-27-104.compute-1.amazonaws.com] has joined #wesnoth-dev
20181112 01:44:41< travis-ci> wesnoth/wesnoth#20163 (master - b94ccf9 : Celtic Minstrel): The build is still failing.
20181112 01:44:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453746890
20181112 01:44:41-!- travis-ci [~travis-ci@ec2-54-198-27-104.compute-1.amazonaws.com] has left #wesnoth-dev []
20181112 02:02:47-!- travis-ci [~travis-ci@ec2-54-205-118-94.compute-1.amazonaws.com] has joined #wesnoth-dev
20181112 02:02:48< travis-ci> wesnoth/wesnoth#20164 (lua_reorg - 1a4df40 : Celtic Minstrel): The build failed.
20181112 02:02:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453747673
20181112 02:02:48-!- travis-ci [~travis-ci@ec2-54-205-118-94.compute-1.amazonaws.com] has left #wesnoth-dev []
20181112 02:18:02< irker386> wesnoth/wesnoth:master newfrenchy83 9c5c8affea Redesign force cth macro AppVeyor: All builds passed
20181112 02:35:44< celticminstrel> ...
20181112 02:36:08< celticminstrel> Bleh, I'm just gonna let someone who uses gcc/clang fix the -Wreorder.
20181112 02:41:50<+wesdiscordbot> <josteph> https://github.com/wesnoth/wesnoth/commit/c6b2be5ca6d6f242303616a34b98c6495091452f#commitcomment-31257382
20181112 02:42:09<+wesdiscordbot> <josteph> that commit changed behavior for [+foo] tags in toplevel
20181112 02:43:58< celticminstrel> Just add a check for emptiness on line 509?
20181112 02:44:41<+wesdiscordbot> <josteph> what's the correct behavior?
20181112 02:44:47< celticminstrel> Many old addons use [+units] without a preceding [units] tag, so it's probably best for it not to be an error condition.
20181112 02:44:49<+wesdiscordbot> <josteph> is it even valiad WML?
20181112 02:45:01<+wesdiscordbot> <shadowm> It is
20181112 02:45:19<+wesdiscordbot> <josteph> So +foo in toplevel is allowed and equivalent to foo
20181112 02:45:23< celticminstrel> (I think originally the game merged the addon configs into the core config, which was why [+units] was needed, but pretty sure it no longer does.)
20181112 02:45:49< celticminstrel> Yes, [+foo] without preceding [foo] is equivalent to [foo] (not toplevel-specific).
20181112 02:45:49<+wesdiscordbot> <shadowm> Anywhere where you have a [+tag] without a preceding [tag] it's valid and it's considered to be a new [tag]
20181112 02:46:39<+wesdiscordbot> <josteph> Okay, I'll look into it
20181112 02:53:18< irker386> wesnoth: josteph wesnoth:1.14 172d32591b51 / data/tools/wesnoth/wmlparser3.py: wmlparser3: Fix [+foo] without preceding [foo] in toplevel https://github.com/wesnoth/wesnoth/commit/172d32591b51e4e1bdc495b831a048f78488cd39
20181112 02:54:04< irker386> wesnoth: josteph wesnoth:master 711434d571d2 / data/tools/wesnoth/wmlparser3.py: wmlparser3: Fix [+foo] without preceding [foo] in toplevel https://github.com/wesnoth/wesnoth/commit/711434d571d27e54267ae7e785eb90e30bb3e41e
20181112 03:24:32-!- travis-ci [~travis-ci@ec2-54-81-189-217.compute-1.amazonaws.com] has joined #wesnoth-dev
20181112 03:24:33< travis-ci> wesnoth/wesnoth#20167 (master - 711434d : josteph): The build is still failing.
20181112 03:24:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/453769635
20181112 03:24:33-!- travis-ci [~travis-ci@ec2-54-81-189-217.compute-1.amazonaws.com] has left #wesnoth-dev []
20181112 04:14:11<+wesdiscordbot> <mattsc> @sevu any way you can get me a test case, so that I can see which of that long line of indices does not exist?
20181112 04:14:33<+wesdiscordbot> <mattsc> Well, it's almost certainly either race or num_traits, not the others.
20181112 04:21:08< irker386> wesnoth/wesnoth:master Celtic Minstrel 045a48e2af Deprecate helper.wml_error and move it t AppVeyor: vs2015/Release Failed
20181112 04:21:09< irker386> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20219340
20181112 04:36:44< irker386> wesnoth/wesnoth:1.14 nemaara d96243a239 TSG S3: fixed Ethiliel upkeep bug AppVeyor: All builds passed
20181112 04:52:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20181112 05:20:40-!- celticminstrel is now known as celmin|sleep
20181112 07:09:12< irker386> wesnoth/wesnoth:1.14 josteph 840495e918 DiD S12: Typo AppVeyor: All builds passed
20181112 08:06:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20181112 08:12:59-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 276 seconds]
20181112 08:20:19<+wesdiscordbot> <Pentarctagon> so should I open an issue until someone fixes travis, or what?
20181112 08:21:07<+wesdiscordbot> <jyrkive> No need to open an issue.
20181112 08:21:21<+wesdiscordbot> <jyrkive> If no one else gets to it first, I plan to fix Travis builds in the evening.
20181112 08:28:47-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20181112 08:57:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181112 09:21:09< irker386> wesnoth/wesnoth:master Celtic Minstrel 045a48e2af Deprecate helper.wml_error and move it t AppVeyor: 2/4 builds failed
20181112 09:21:10< irker386> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20219340
20181112 09:21:11< irker386> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20219341
20181112 11:23:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20181112 11:36:26< irker386> wesnoth/wesnoth:1.14 josteph 172d32591b wmlparser3: Fix [+foo] without preceding AppVeyor: All builds passed
20181112 13:46:12< Soliton> celmin|sleep: re binary_or_text.hpp: there used to be a binary WML format but it was removed in favour of text WML + standard compression.
20181112 13:48:57< celmin|sleep> I see.
20181112 13:49:02-!- celmin|sleep is now known as celmin|away
20181112 14:32:02< irker386> wesnoth/wesnoth:master josteph 711434d571 wmlparser3: Fix [+foo] without preceding AppVeyor: All builds passed
20181112 14:46:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181112 17:32:17-!- irker386 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181112 17:48:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181112 17:49:01-!- irker250 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181112 17:49:01< irker250> wesnoth: Jyrki Vesterinen wesnoth:master a5ef8d040ce9 / src/ (4 files in 3 dirs): Fix build with GCC and Clang https://github.com/wesnoth/wesnoth/commit/a5ef8d040ce9c71cf3a1f0cefe6181a48f7d44ff
20181112 19:39:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181112 19:42:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181112 19:43:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181112 19:44:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181112 20:01:07-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 246 seconds]
20181112 20:03:10-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20181112 20:49:17-!- irker250 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181112 20:50:07-!- irker368 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181112 20:50:07< irker368> wesnoth: Jyrki Vesterinen wesnoth:master 8ca0534b28bf / projectfiles/VC14/ (4 files): Visual Studio project: move schema code to wesnothlib https://github.com/wesnoth/wesnoth/commit/8ca0534b28bf2552cbf9be64771c36c26a355f13
20181112 20:50:07< irker368> wesnoth: Jyrki Vesterinen wesnoth:master b789c07e3301 / src/serialization/schema/ (tag.cpp tag.hpp): Attempted build fix for Apple Clang https://github.com/wesnoth/wesnoth/commit/b789c07e3301e7d8ad2e4f424647e65f29b4dfc7
20181112 21:14:22-!- travis-ci [~travis-ci@ec2-54-166-10-189.compute-1.amazonaws.com] has joined #wesnoth-dev
20181112 21:14:23< travis-ci> wesnoth/wesnoth#20173 (master - b789c07 : Jyrki Vesterinen): The build is still failing.
20181112 21:14:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454166075
20181112 21:14:23-!- travis-ci [~travis-ci@ec2-54-166-10-189.compute-1.amazonaws.com] has left #wesnoth-dev []
20181112 22:22:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181112 22:54:16< irker368> wesnoth/wesnoth:master newfrenchy83 f311520fff Update utils.cfg AppVeyor: All builds passed
20181112 23:09:19< irker368> wesnoth/wesnoth:1.14 Steve Cotton 124c2f288c Tutorial S2: Hints about whether to leve AppVeyor: vs2015/Release Failed
20181112 23:09:20< irker368> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20244143
20181112 23:43:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20181112 23:46:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
--- Log closed Tue Nov 13 00:00:34 2018