--- Log opened Tue Nov 13 00:00:34 2018
20181113 00:14:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181113 01:18:24-!- celmin|away is now known as celticminstrel
20181113 01:25:34-!- hyp3rbor3ax [~hyp3rbor3@p57B396C0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20181113 01:25:56-!- hyp3rbor3ax [~hyp3rbor3@p57B396C0.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20181113 02:09:44-!- irker368 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181113 03:05:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20181113 03:09:21-!- irker349 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181113 03:09:21< irker349> wesnoth/wesnoth:1.14 Steve Cotton 10233ee44e Tutorial S2: Hints about whether to leve AppVeyor: All builds passed
20181113 03:29:04-!- celticminstrel is now known as celmin|sleep
20181113 04:09:18< irker349> wesnoth/wesnoth:1.14 Steve Cotton 124c2f288c Tutorial S2: Hints about whether to leve AppVeyor: 1/2 builds failed
20181113 04:09:19< irker349> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20244143
20181113 05:31:51< irker349> wesnoth: Jyrki Vesterinen wesnoth:master 7d21a844ad91 / src/serialization/ (schema_validator.cpp schema_validator.hpp): Second attemptm to fix build with Apple Clang https://github.com/wesnoth/wesnoth/commit/7d21a844ad9114fd524cbade7429883edce77323
20181113 05:55:10-!- travis-ci [~travis-ci@ec2-107-20-97-104.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 05:55:11< travis-ci> wesnoth/wesnoth#20174 (master - 7d21a84 : Jyrki Vesterinen): The build is still failing.
20181113 05:55:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454318160
20181113 05:55:11-!- travis-ci [~travis-ci@ec2-107-20-97-104.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 05:58:49<+wesdiscordbot> <jyrkive> @hrubymar10 The Xcode build is the only remaining failing build. Could you update the Xcode project?
20181113 06:12:47< irker349> wesnoth/wesnoth:master Jyrki Vesterinen b789c07e33 Attempted build fix for Apple Clang AppVeyor: All builds passed
20181113 08:17:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181113 08:48:12<+wesdiscordbot> <hrubymar10> @jyrkive ofc, I’ll fix it asap
20181113 09:14:09-!- irker349 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181113 12:27:50-!- irker503 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181113 12:27:50< irker503> wesnoth/wesnoth:master Jyrki Vesterinen 7d21a844ad Second attemptm to fix build with Apple  AppVeyor: All builds passed
20181113 12:29:27< irker503> wesnoth: gfgtdf wesnoth:master 01581d021881 / src/ (gui/dialogs/game_stats.cpp replay.cpp team.cpp): small team.cpp cleanup https://github.com/wesnoth/wesnoth/commit/01581d0218818d9d89ff7283eedc6a2c6a9e3eea
20181113 12:41:14<+wesdiscordbot> <sevu> @mattsc Found the cause, it's if a recruitable unit has a race which doesn't exist; to reproduce it, change the race id in the unit file to an invalid one.
20181113 12:52:10-!- travis-ci [~travis-ci@ec2-54-211-0-138.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 12:52:11< travis-ci> wesnoth/wesnoth#20175 (master - 01581d0 : gfgtdf): The build is still failing.
20181113 12:52:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454461908
20181113 12:52:12-!- travis-ci [~travis-ci@ec2-54-211-0-138.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 13:21:00-!- celmin|sleep is now known as celmin|away
20181113 13:29:55< irker503> wesnoth/wesnoth:master gfgtdf 01581d0218 small team.cpp cleanup AppVeyor: vs2015/Release Failed
20181113 13:29:56< irker503> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20262586
20181113 13:44:26< irker503> wesnoth: gfgtdf wesnoth:master 05a397ddde0d / src/saved_game.cpp: use std::move https://github.com/wesnoth/wesnoth/commit/05a397ddde0d32afacf6f88a3dbd4a8e8f5f0d60
20181113 13:44:27< irker503> wesnoth: gfgtdf wesnoth:master 20b36d2713cf / src/ (7 files in 3 dirs): variables in lua mapgen, fixes #3657 https://github.com/wesnoth/wesnoth/commit/20b36d2713cfc5507cc8ae0a854fd0d9c6939ebb
20181113 14:35:25-!- travis-ci [~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 14:35:26< travis-ci> wesnoth/wesnoth#20176 (master - 20b36d2 : gfgtdf): The build has errored.
20181113 14:35:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454493316
20181113 14:35:26-!- travis-ci [~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 14:59:33< irker503> wesnoth: mattsc wesnoth:1.14 aa93baacbf1c / data/ai/lua/generic_recruit_engine.lua: ExpAI recruiting: fix AI crash for unit type with unknown race https://github.com/wesnoth/wesnoth/commit/aa93baacbf1c27f23d5647a42136f13c8ccdb093
20181113 15:00:34< irker503> wesnoth: mattsc wesnoth:master 59397a40b59a / data/ai/lua/generic_recruit_engine.lua: ExpAI recruiting: fix AI crash for unit type with unknown race https://github.com/wesnoth/wesnoth/commit/59397a40b59aa489c16d7715322c28b25a828513
20181113 15:03:49<+wesdiscordbot> <mattsc> @sevu ^
20181113 15:50:31-!- travis-ci [~travis-ci@ec2-54-91-178-230.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 15:50:32< travis-ci> wesnoth/wesnoth#20177 (1.14 - aa93baa : mattsc): The build has errored.
20181113 15:50:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454528899
20181113 15:50:32-!- travis-ci [~travis-ci@ec2-54-91-178-230.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 16:11:43-!- travis-ci [~travis-ci@ec2-54-204-118-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 16:11:44< travis-ci> wesnoth/wesnoth#20178 (master - 59397a4 : mattsc): The build has errored.
20181113 16:11:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454529319
20181113 16:11:44-!- travis-ci [~travis-ci@ec2-54-204-118-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 17:52:07-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181113 17:54:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181113 17:56:20< irker503> wesnoth: Jyrki Vesterinen wesnoth:master ce3f6ccecc4a / src/generators/ (lua_map_generator.cpp lua_map_generator.hpp): Fix build with -Werror=unused-private-field https://github.com/wesnoth/wesnoth/commit/ce3f6ccecc4aa63148b07ab2001b8f559d95bb84
20181113 18:16:48-!- travis-ci [~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 18:16:49< travis-ci> wesnoth/wesnoth#20179 (master - ce3f6cc : Jyrki Vesterinen): The build failed.
20181113 18:16:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454614638
20181113 18:16:49-!- travis-ci [~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 18:29:55< irker503> wesnoth/wesnoth:master gfgtdf 01581d0218 small team.cpp cleanup AppVeyor: 1/2 builds failed
20181113 18:29:56< irker503> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20262586
20181113 19:09:29< Soliton> loonycyborg: when a new game is created the server first sends out the modified user list with a yet unknown game id. only afterwards it sends an update to the gamelist with the new game.
20181113 19:10:08< Soliton> of course the client does not like that.
20181113 19:12:27< loonycyborg> it happens always or only sometimes?
20181113 19:12:47< Soliton> it always does that.
20181113 19:13:03< Soliton> server::handle_create_game
20181113 19:14:04< Soliton> it's probably just needed to remove the diff stuff from there and put it where the scenario data is received.
20181113 19:16:03< Soliton> https://github.com/wesnoth/wesnoth/blob/master/src/server/server.cpp#L1609  after that line.
20181113 19:16:33< Soliton> above that there is also a duplicate assert, btw.
20181113 19:18:16< Soliton> there might be issues if the game is deleted before we get to that point.
20181113 19:19:00< loonycyborg> ok
20181113 19:19:06< loonycyborg> will look into it later a bit
20181113 19:19:11< loonycyborg> when I'm less distracted
20181113 19:19:25< Soliton> because in delete_game we'll try to make diff with the players removed again.
20181113 19:19:37< Soliton> perhaps the diff making copes with that though.
20181113 19:20:42< loonycyborg> the worst part is that I still have hard time understanding what those diffs exactly do
20181113 19:20:50< loonycyborg> I kept them without change mostly from old code
20181113 19:22:41< Soliton> it's really just about maintaining the list shown here on client and server side: https://wiki.wesnoth.org/MultiplayerServerWML#The_login_procedure
20181113 19:22:58< Soliton> (the [gamelist] thing a little down.)
20181113 19:23:18< Soliton> to avoid sending the whole thing all the time we just send diffs.
20181113 19:24:17< loonycyborg> nice doc, I'll need to update it too
20181113 19:30:41< Ravana_> the page is somewhat incomplete, but it was enough to get stuff working
20181113 19:31:19< Soliton> it's a wiki anyone can add to it.
20181113 19:31:27< Soliton> what is missing?
20181113 19:32:57< Soliton> "Seems that user and game objects should be inserted into 0-based array in the order they arrive."  hmm, when adding stuff it should ideally not be phrased like a guess though.
20181113 19:34:06< Soliton> perhaps that is meant to say that the diff indexes are 0-based.
20181113 19:34:18< Soliton> the diff format is described further down though.
20181113 19:44:00< Ravana_> when I added it, it was a guess
20181113 19:45:03< Ravana_> I ended with users list still being invalid in the end https://github.com/ProditorMagnus/wesbot_public/issues/2
20181113 19:53:09< Soliton> could you please clarify the guess now then?
20181113 19:59:11< Ravana_> I turned bot on again, so will see after a week I guess
20181113 20:01:00< Soliton> no error noticable earlier? that's going to be tough to analyse.
20181113 20:01:23< Soliton> ideally i'd like a full log to check against the server log.
20181113 20:01:46< Ravana_> yes, only index is sent, nothing that can be used to validate it before
20181113 20:02:41< Soliton> sure but if it's a systematic error i'd expect a little less time for it to show up.
20181113 20:03:12< Soliton> i guess it must just happen in some very rare circumstance.
20181113 20:04:02< Ravana_> this is currently a case of proving system is correct, if exception does not happen
20181113 20:04:23< Ravana_> after a week there is still chance it might happen later
20181113 20:04:52< Soliton> oh, if no error occurs, ok.
20181113 20:06:56< Soliton> what does saved/deleted mean in your log?
20181113 20:07:27< Ravana_> saved means assigned to index in array
20181113 20:07:39< Ravana_> and deleted is removing item from that index
20181113 20:08:11< Soliton> so log on and log off?
20181113 20:08:37< Ravana_> yes, but also joining and leaving game
20181113 20:11:04< Soliton> that's confusing. are you saying you don't get a change_child for that?
20181113 20:13:39< Ravana_> no
20181113 20:15:30< Ravana_> http://devdocs.wesnoth.org/server_8cpp_source.html#l00178
20181113 20:17:07< Ravana_> change_child is used for game diffs though
20181113 20:18:19< Ravana_> with 20 min uptime I have received 4.6 MB of wml from server
20181113 20:43:49< Soliton> still very confusing. is the link to show that you should get a change_child?
20181113 20:44:59<+wesdiscordbot> <sevu> @mattsc 👍
20181113 20:50:41< Ravana_> the comment was the main part
20181113 20:50:56< Ravana_> until I found that comment, stuff did not make sense
20181113 20:52:34< Ravana_> https://forums.wesnoth.org/viewtopic.php?p=607066#p607066
20181113 20:53:10< Soliton> there is no comment on line 178. do you mean line 183?
20181113 20:53:28< Ravana_> yes, in 2016 it was that number
20181113 20:53:39< Ravana_> 2017
20181113 20:53:46< Soliton> my apologies for not remembering that.
20181113 20:54:55< Ravana_> I checked this code today, and I guess that the "if(gamelist)" part is what decides that change_child is not used for users
20181113 20:55:31< Soliton> gamelist is a parameter so it depends on the caller.
20181113 20:55:51< Soliton> looks like that is how it's used indeed though.
20181113 20:56:54< Soliton> so it seems the updating lobby state section is not correct or uptodate there.
20181113 21:05:42< Soliton> could you fix that section and add your 0-based comment there? (or explain what it means where it's now.)
20181113 21:12:09< Ravana_> moved index comment
20181113 21:14:04< Ravana_> somewhere client gets info to which game user has moved, can't recall if somewhere is still change_child, or insert_child includes room info
20181113 21:16:22< Ravana_> I save "game_id" in User constructor, so second option
20181113 21:21:21< Ravana_> added the keys to wiki https://github.com/ProditorMagnus/wesbot_public/blob/master/rewritebotSCHEMA.py#L136-L141
20181113 21:21:36< Ravana_> not sure what all of them do anymore
20181113 21:25:13< Soliton> the general structure of the list and its attributes is explained in the login section above.
20181113 21:25:33< Soliton> probably not entirely uptodate though.
20181113 21:26:00< Soliton> the diff structure looks better now, thanks.
20181113 21:28:10< irker503> wesnoth/wesnoth:1.14 mattsc aa93baacbf ExpAI recruiting: fix AI crash for unit  AppVeyor: All builds passed
20181113 21:34:36< Ravana_> actually, maybe it is still bug from my side, I see I do not handle [observer] and [observer_quit] event
20181113 21:34:52< Ravana_> so stuff like observer exiting without returning to lobby might cause issue
20181113 21:40:08< Soliton> pretty sure that should be in addition to a diff.
20181113 21:40:20< Ravana_> but observer leaving or joining game does not send out [observer]/[observer_quit]
20181113 21:41:12< Ravana_> but it is sent out in some case - I have 5 events with them from 2018-06-16
20181113 21:42:13< Soliton> you get those only if you're in the game.
20181113 21:42:33< Soliton> i don't think you should ever get them in the lobby.
20181113 21:42:43< Ravana_> I see, then not relevant for this case, I only rarely join games with bot
20181113 21:43:48< Soliton> probably also worth a note on the wiki. it does seem to imply you get those in the lobby.
20181113 22:09:40-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 244 seconds]
20181113 22:09:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20181113 22:13:05-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20181113 22:17:45< irker503> wesnoth: josteph wesnoth:master 815ded47dd40 / data/themes/default.cfg: Themes: Fix unit status icons not showing https://github.com/wesnoth/wesnoth/commit/815ded47dd40774f596ac3cca0e5523791e19f37
20181113 22:18:03< irker503> wesnoth: josteph wesnoth:1.14 688c31e32520 / data/themes/default.cfg: Themes: Fix unit status icons not showing https://github.com/wesnoth/wesnoth/commit/688c31e325202709ef0f38498fcae3d47cbdc6e7
20181113 22:20:19< irker503> wesnoth: josteph wesnoth:1.14 43097b393320 / changelog.md: Update changelog for last commit https://github.com/wesnoth/wesnoth/commit/43097b393320067528fc350df696295d08c65823
20181113 22:23:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181113 22:39:17-!- travis-ci [~travis-ci@ec2-54-145-14-105.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 22:39:18< travis-ci> wesnoth/wesnoth#20181 (master - 815ded4 : josteph): The build is still failing.
20181113 22:39:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454725607
20181113 22:39:18-!- travis-ci [~travis-ci@ec2-54-145-14-105.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 22:58:56-!- travis-ci [~travis-ci@ec2-54-167-155-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20181113 22:58:57< travis-ci> wesnoth/wesnoth#20183 (1.14 - 43097b3 : josteph): The build passed.
20181113 22:58:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454726645
20181113 22:58:57-!- travis-ci [~travis-ci@ec2-54-167-155-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20181113 23:36:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Wed Nov 14 00:00:35 2018