--- Log opened Wed Nov 14 00:00:35 2018
20181114 00:03:10< irker503> wesnoth/wesnoth:master josteph 815ded47dd Themes: Fix unit status icons not showin AppVeyor: vs2015/Release Failed
20181114 00:03:11< irker503> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20278526
20181114 00:50:31< irker503> wesnoth/wesnoth:master Jyrki Vesterinen ce3f6ccecc Fix build with -Werror=unused-private-fi AppVeyor: All builds passed
20181114 00:55:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181114 01:01:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20181114 01:25:59-!- celmin|away is now known as celticminstrel
20181114 01:36:30< celticminstrel> ...the MultiplayerServerWML page is kinda really bad somehow?
20181114 01:37:15< celticminstrel> It's describing the general WML-diff format as if it's something specific to the MP-WML.
20181114 01:39:02< celticminstrel> Would it not be simpler to just say it's a diff of the gamelist config and then link to documentation of the diff format?
20181114 01:39:11< celticminstrel> (I don't think the diff format is actually documented anywhere, is it?)
20181114 01:48:37< celticminstrel> Does anyone know whether cfg.add_child_at adds before or after the specified index?
20181114 01:53:28< celticminstrel> Hmm... we should add a --diff command-line option to Wesnoth.
20181114 01:55:14< celticminstrel> And maybe --patch as well.
20181114 01:55:31< celticminstrel> I mean, the diff format exists and works well enough, we might as well expose it on the command-line.
20181114 01:56:35< celticminstrel> Mind you it's probably not ideal as a diff format for developers working on scenarios or whatever, since it's diffing the config itself rather than its textual representation, but I'm sure someone could find a use for it.
20181114 02:02:38< celticminstrel> Not 100% confident on its accuracy, but I think it's a good first draft at least: https://wiki.wesnoth.org/DiffWML
20181114 02:12:28< celticminstrel> Someone edited the MultiplayerServerWML to remove the reference of [change_child] being used for users... I don't know if [change_child] is normally used for users, but I'm fairly confident in saying that it can be used for them. The diff format is the diff format after all.
20181114 02:18:52< celticminstrel> I'm going to merge https://github.com/wesnoth/wesnoth/pull/2635 this weekend if no-one comments on it (might change intf to interface first but that's it, unless people comment).
20181114 03:32:21< buhman> celticminstrel: I like "interface" more, if my vote counts
20181114 03:36:48< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg 9e4672fd9519 / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module https://github.com/wesnoth/wesnoth/commit/9e4672fd95190c6d3ea3ce95b34e5d8494e586ea
20181114 03:36:50< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg bfb565904462 / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module deprecations https://github.com/wesnoth/wesnoth/commit/bfb565904462316a840826e4a7718bfc0e2fe78c
20181114 03:36:52< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg 97c67003229f / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module https://github.com/wesnoth/wesnoth/commit/97c67003229fafc4550499592f0c58d7185742aa
20181114 03:36:54< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg 68bbfec69c88 / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module deprecations https://github.com/wesnoth/wesnoth/commit/68bbfec69c8845b60fe1734a6b99ffbf3cd5158d
20181114 03:36:56< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg 1e34a7c7b8b1 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module https://github.com/wesnoth/wesnoth/commit/1e34a7c7b8b1e82bc0ef68d5e4027bfd8ad68a42
20181114 03:36:58< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg b2c735e1c233 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module deprecations https://github.com/wesnoth/wesnoth/commit/b2c735e1c2339b68bf03a38e3c50c88587cbfca4
20181114 03:37:00< irker503> wesnoth: Celtic Minstrel wesnoth:lua_reorg 1e1cf6d6afa7 / data/lua/ (core.lua helper.lua): Deprecate helper.wml_error and move it to wml.error https://github.com/wesnoth/wesnoth/commit/1e1cf6d6afa7506af2ac7c9f18e0c07f789925dd
20181114 03:49:54-!- travis-ci [~travis-ci@ec2-54-204-118-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20181114 03:49:55< travis-ci> wesnoth/wesnoth#20188 (lua_reorg - 1e1cf6d : Celtic Minstrel): The build is still failing.
20181114 03:49:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454812844
20181114 03:49:55-!- travis-ci [~travis-ci@ec2-54-204-118-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20181114 04:00:23< irker503> wesnoth/wesnoth:1.14 nemaara 7e414d8007 TSG S8b: modified starting village captu AppVeyor: All builds passed
20181114 04:21:34< irker503> wesnoth: Celtic Minstrel wesnoth:wml_diff_cl f1fd2312f736 / src/commandline_options.cpp: Add type annotations for the new schema command-line arguments https://github.com/wesnoth/wesnoth/commit/f1fd2312f736d6b080cbf0320e776c5acf8bdd64
20181114 04:21:36< irker503> wesnoth: Celtic Minstrel wesnoth:wml_diff_cl 22d8592164a1 / doc/man/wesnoth.6 src/wesnoth.cpp: Document schema validation short options and make --validate imply --wconsole on https://github.com/wesnoth/wesnoth/commit/22d8592164a1e3f5fc17ce08f631a0fbbb932fe4
20181114 04:21:38< irker503> wesnoth: Celtic Minstrel wesnoth:wml_diff_cl ab7b4950edb0 / / (4 files in 2 dirs): Add a command-line interface to the WML diff functionality https://github.com/wesnoth/wesnoth/commit/ab7b4950edb03e2f941850723c6323a4ee817ef1
20181114 04:22:19< irker503> wesnoth: Celtic Minstrel wesnoth:master f1fd2312f736 / src/commandline_options.cpp: Add type annotations for the new schema command-line arguments https://github.com/wesnoth/wesnoth/commit/f1fd2312f736d6b080cbf0320e776c5acf8bdd64
20181114 04:22:21< irker503> wesnoth: Celtic Minstrel wesnoth:master 22d8592164a1 / doc/man/wesnoth.6 src/wesnoth.cpp: Document schema validation short options and make --validate imply --wconsole on https://github.com/wesnoth/wesnoth/commit/22d8592164a1e3f5fc17ce08f631a0fbbb932fe4
20181114 04:29:37< celticminstrel> Speaking of diffs... does anyone have any idea what a map diff would even look like?
20181114 04:32:31< irker503> wesnoth/wesnoth:master gfgtdf 999815b6f1 f version helper AppVeyor: vs2017/Release Failed
20181114 04:32:32< irker503> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20281892
20181114 04:49:58-!- celticminstrel is now known as celmin|sleep
20181114 05:03:10< irker503> wesnoth/wesnoth:master josteph 815ded47dd Themes: Fix unit status icons not showin AppVeyor: 1/4 builds failed
20181114 05:03:11< irker503> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20278526
20181114 05:12:42-!- travis-ci [~travis-ci@ec2-54-80-165-252.compute-1.amazonaws.com] has joined #wesnoth-dev
20181114 05:12:43< travis-ci> wesnoth/wesnoth#20190 (wml_diff_cl - ab7b495 : Celtic Minstrel): The build failed.
20181114 05:12:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454821162
20181114 05:12:43-!- travis-ci [~travis-ci@ec2-54-80-165-252.compute-1.amazonaws.com] has left #wesnoth-dev []
20181114 05:22:01< irker503> wesnoth/wesnoth:master gfgtdf 7de373be76 f version helper AppVeyor: vs2015/Release Failed
20181114 05:22:02< irker503> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20281893
20181114 05:29:02-!- travis-ci [~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com] has joined #wesnoth-dev
20181114 05:29:03< travis-ci> wesnoth/wesnoth#20191 (master - 22d8592 : Celtic Minstrel): The build is still failing.
20181114 05:29:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454821332
20181114 05:29:03-!- travis-ci [~travis-ci@ec2-54-167-244-83.compute-1.amazonaws.com] has left #wesnoth-dev []
20181114 06:36:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20181114 06:39:49-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 268 seconds]
20181114 08:23:41-!- irker503 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181114 08:25:10-!- irker546 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181114 08:25:10< irker546> wesnoth/wesnoth:1.14 josteph 43097b3933 Update changelog for last commit AppVeyor: All builds passed
20181114 08:48:00< irker546> wesnoth/wesnoth:master Celtic Minstrel b721e3797d Deprecate helper.wml_error and move it t AppVeyor: vs2017/Release Failed
20181114 08:48:01< irker546> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20283735
20181114 09:32:32< irker546> wesnoth/wesnoth:master gfgtdf 999815b6f1 f version helper AppVeyor: 1/2 builds failed
20181114 09:32:33< irker546> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20281892
20181114 09:34:42< Soliton> celticminstrel: yes, a general diff documentation would be nice. the MultiplayerServerWML shows specific examples in the context it is used there. i think that is still useful for people trying to understand it or write mp clients of their own.
20181114 09:35:07< Soliton> ah you already made one, excellent.
20181114 09:37:45< Soliton> change_child cannot be used for users since they're not a subtag of anything.
20181114 09:42:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181114 10:22:03< irker546> wesnoth/wesnoth:master gfgtdf 7de373be76 f version helper AppVeyor: 1/2 builds failed
20181114 10:22:04< irker546> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20281893
20181114 11:04:22-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 268 seconds]
20181114 11:14:23< loonycyborg> Soliton: So it's basically about client getting game in gamelist that isn't fully described yet?
20181114 11:14:36< loonycyborg> I think delaying the send of the list only masks the issue
20181114 11:15:02< loonycyborg> because other clients still can catch the game in initial state
20181114 11:17:46< loonycyborg> of course it's possible to delay updating games_and_users_list_ too but it sounds really fragile to me
20181114 11:17:55< Soliton> no, the issue is sending user updates with a game_id that does not exist.
20181114 11:20:24< loonycyborg> new game_id is allocated exactly when player_connections_.modify(..) is called
20181114 11:20:54< Soliton> the point is updating the list not once create_game is sent but once the accompanying scenario data is also there. so the game is properly created and the host can actually be considered part of that game.
20181114 11:22:02< loonycyborg> yes, and this seems fragile to me
20181114 11:22:48< loonycyborg> I'd prefer if gamelist updates were always at the same place as player_connections_ updates
20181114 11:23:25< loonycyborg> I think if client would just show something like "game creation in progress" in this case
20181114 11:23:39-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20181114 11:23:51< loonycyborg> *it would be better if
20181114 11:23:56< Soliton> that makes no sense.
20181114 11:24:13< Soliton> if you want to consider the game created there then give the client a game.
20181114 11:25:35< loonycyborg> what exactly does this imply?
20181114 11:26:15< Soliton> if you insist on updating the user at that point also update the games list.
20181114 11:27:45< Soliton> you'll probably have to update the games list a second time once all the game data is available.
20181114 11:29:48< loonycyborg> I guess
20181114 11:40:16< irker546> wesnoth/wesnoth:1.14 nemaara 1f988b8734 TSG S1: moved side 2 gold gain AppVeyor: All builds passed
20181114 11:41:01< Soliton> would also need to check how the client handles a game with not all data in it.
20181114 11:47:46< irker546> wesnoth: loonycyborg wesnoth:master 921203803ec9 / src/server/server.cpp: wesnothd: remove redundant assert https://github.com/wesnoth/wesnoth/commit/921203803ec9bf711360cfb527def96b0e1c04f1
20181114 11:50:02< loonycyborg> I'm not even sure where exactly is games_and_users_list_ updated
20181114 11:50:58< loonycyborg> since when porting to asio I was just moving that code in appropriate handlers without looking too deep into it
20181114 11:56:42< loonycyborg> But I guess I get the issue
20181114 12:24:54< loonycyborg> Soliton: https://gist.github.com/loonycyborg/41ff08bbd15f83dcb6b2be92a10d3453 you meaning something like this?
20181114 12:27:42< Soliton> yep.
20181114 12:28:34< Soliton> after that the client should not complain about unknown game ids when a game is created.
20181114 12:30:04< loonycyborg> wow it even works. I just tested it with 3 clients
20181114 12:30:17< loonycyborg> two playing hamlets and third in lobby
20181114 12:30:25< Soliton> need to check what happens if the game is aborted before that and delete_game tries to send a diff.
20181114 12:30:56< Soliton> looking at the code it should work fine but emit an error message.
20181114 12:31:53< Soliton> not sure how easy that is to test though.
20181114 12:32:34< Soliton> probably easier to change the server code to abort early just for a test.
20181114 12:37:31< loonycyborg> you mean after server got [create_game] but before it got [scenario]?
20181114 12:38:06< Soliton> yes.
20181114 12:39:21< Soliton> for a real test you'd have to send [scenario] without [multiplayer].
20181114 12:40:57< loonycyborg> when that could happen in production? when client crashes or dcs before sending [scenario]?
20181114 12:41:36-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev
20181114 12:41:48< Soliton> i think it wouldn't get there then. probably just with a modified client.
20181114 12:42:15< Soliton> it probably can also happen if your scenario is too big so you go over the message size limit.
20181114 12:44:14< Soliton> i mean it wouldn't get to the delete_game call where the scenario data is accepted but i guess the game will also be deleted if the client disconnects? so yeah disconnect should work as well then.
20181114 12:44:46< Soliton> worth a try if you can disconnect quick enough.
20181114 12:45:13< loonycyborg> I could make client crash after sending [create_game]
20181114 12:45:33< Soliton> sounds good.
20181114 12:56:43-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 245 seconds]
20181114 13:02:58-!- irker546 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Ping timeout: 245 seconds]
20181114 13:10:41< loonycyborg> well I tried with some clients that crash using std::terminate after sending [create_game]
20181114 13:10:50< loonycyborg> and saw no distruption for others
20181114 13:11:09< loonycyborg> like even when there was another game with two non-crashing clients
20181114 13:17:00-!- irker618 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181114 13:17:01< irker618> wesnoth: loonycyborg wesnoth:master c4e9c389a699 / src/server/server.cpp: wesnothd: delay sending diff with user moving to game they created https://github.com/wesnoth/wesnoth/commit/c4e9c389a699a75df2a679a4b2b1b23b60db539e
20181114 13:22:02< irker618> wesnoth/wesnoth:master Celtic Minstrel 9ee0847faf Add a command-line interface to the WML  AppVeyor: vs2015/Release Failed
20181114 13:22:04< irker618> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20284341
20181114 13:36:37-!- travis-ci [~travis-ci@ec2-54-159-84-217.compute-1.amazonaws.com] has joined #wesnoth-dev
20181114 13:36:38< travis-ci> wesnoth/wesnoth#20197 (master - c4e9c38 : loonycyborg): The build is still failing.
20181114 13:36:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/454983378
20181114 13:36:39-!- travis-ci [~travis-ci@ec2-54-159-84-217.compute-1.amazonaws.com] has left #wesnoth-dev []
20181114 13:48:01< irker618> wesnoth/wesnoth:master Celtic Minstrel b721e3797d Deprecate helper.wml_error and move it t AppVeyor: 2/4 builds failed
20181114 13:48:02< irker618> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20283735
20181114 13:48:03< irker618> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20283736
20181114 13:54:45-!- celticminstrel is now known as celmin|away
20181114 15:35:38<+wesdiscordbot> <sigurdfd> sigurd
20181114 16:48:12-!- irker618 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181114 17:01:41-!- irker575 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181114 17:01:41< irker575> wesnoth/wesnoth:wml_diff_cl Celtic Minstrel ab7b4950ed Add a command-line interface to the WML  AppVeyor: All builds passed
20181114 17:48:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181114 18:07:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181114 18:22:02< irker575> wesnoth/wesnoth:master Celtic Minstrel 9ee0847faf Add a command-line interface to the WML  AppVeyor: 2/4 builds failed
20181114 18:22:03< irker575> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20284341
20181114 18:22:04< irker575> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20284342
20181114 19:06:59< irker575> wesnoth: josteph wesnoth:1.14 8cf907438256 / data/tools/ (pywmlx/autof.py wmlxgettext): wmlxgettext: Fix crash if no *.cfg file is found https://github.com/wesnoth/wesnoth/commit/8cf9074382562153f2225c79378049b4f2bdce23
20181114 19:07:01< irker575> wesnoth: Severin Glöckner wesnoth:1.14 553b679b29d5 / po/ (wesnoth-multiplayer/de.po wesnoth/de.po): German translation: small changes https://github.com/wesnoth/wesnoth/commit/553b679b29d566b96b6f9cbc21b3755a6acb36db
20181114 19:13:20< irker575> wesnoth: Severin Glöckner wesnoth:1.14 430e2616d2a5 / changelog.md: update changelog https://github.com/wesnoth/wesnoth/commit/430e2616d2a5b99c82f418d37cb20abe31561e27
20181114 19:13:57< irker575> wesnoth/wesnoth:master loonycyborg c4e9c389a6 wesnothd: delay sending diff with user m AppVeyor: vs2015/Release Failed
20181114 19:13:58< irker575> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20294484
20181114 19:15:06< irker575> wesnoth: josteph wesnoth:master e6422230179e / data/tools/ (pywmlx/autof.py wmlxgettext): wmlxgettext: Fix crash if no *.cfg file is found https://github.com/wesnoth/wesnoth/commit/e6422230179ea3a012487acfe5af1c15e412290f
20181114 19:15:08< irker575> wesnoth: Severin Glöckner wesnoth:master 6b744f1ca0f2 / po/ (wesnoth-multiplayer/de.po wesnoth/de.po): German translation: small changes https://github.com/wesnoth/wesnoth/commit/6b744f1ca0f27c07deb9de0b022244b144395e98
20181114 19:21:18<+wesdiscordbot> <sevu> ~150 new commits in master 😯
20181114 19:21:41<+wesdiscordbot> <jyrkive> Yeah, it's celticminstrel's schema validation.
20181114 19:52:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20181114 19:53:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20181114 21:24:19-!- gfgtdf [~gfgtdf@134.76.63.8] has joined #wesnoth-dev
20181114 21:26:41-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Client Quit]
20181114 21:44:16< irker575> wesnoth/wesnoth:1.14 Severin Glöckner 430e2616d2 update changelog AppVeyor: vs2017/Release Failed
20181114 21:44:17< irker575> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20304784
20181114 21:51:31< irker575> wesnoth/wesnoth:master gfgtdf 6541f726da f version helper AppVeyor: All builds passed
20181114 22:42:31< irker575> wesnoth: Severin Glöckner wesnoth:1.14 b6f66510b6ec / data/core/units/ (10 files in 3 dirs): Help: cut portraits of monsters, bats and zombies https://github.com/wesnoth/wesnoth/commit/b6f66510b6ec2337bdd5ca313118f56c91590bf6
20181114 22:44:58< irker575> wesnoth: Severin Glöckner wesnoth:1.14 fcc3662b7ef5 / data/core/units/undead/Corpse_Walking.cfg: fixup – remove typo https://github.com/wesnoth/wesnoth/commit/fcc3662b7ef5c0ae9de763946c8a62f87afd03e2
20181114 22:45:40< irker575> wesnoth: Severin Glöckner wesnoth:master eb1ebe1cd8fa / data/core/units/ (10 files in 3 dirs): Help: cut portraits of monsters, bats and zombies https://github.com/wesnoth/wesnoth/commit/eb1ebe1cd8fa67986cb4c411f86f5f1939dc8416
20181114 22:49:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20181114 23:22:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20181114 23:46:41< irker575> wesnoth/wesnoth:1.14 Severin Glöckner fcc3662b7e fixup – remove typo AppVeyor: vs2015/Release Failed
20181114 23:46:42< irker575> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20309984
--- Log closed Thu Nov 15 00:00:31 2018