--- Log opened Thu Nov 15 00:00:31 2018
20181115 00:13:58< irker575> wesnoth/wesnoth:master loonycyborg c4e9c389a6 wesnothd: delay sending diff with user m AppVeyor: 1/2 builds failed
20181115 00:13:59< irker575> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20294484
20181115 00:55:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181115 01:07:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181115 01:09:55-!- celmin|away [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20181115 01:10:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20181115 01:20:52< mattsc> celticminstrel: I don’t really have any comments on the Lua API reorganization.
20181115 01:21:13< mattsc> It’s going to take a little to get used to, but that’s not a complaint.
20181115 01:44:12< irker575> wesnoth/wesnoth:1.14 Severin Glöckner 430e2616d2 update changelog AppVeyor: 1/4 builds failed
20181115 01:44:13< irker575> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20304784
20181115 01:50:00-!- sevu [~sevu@p5485406D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20181115 01:51:14< sevu> mattsc, I saw your comment, it works in MP, SP I couldn't test, because I get an segfault if I try to load an campaign with the other core
20181115 01:51:46< sevu> unrelated to the AI setting, don't know why.
20181115 01:52:29< mattsc> sevu: okay, same as what I am seeing then (just making sure).
20181115 01:52:46< mattsc> I am going to figure out how to fix it for SP then.
20181115 01:53:31< mattsc> As I say at the end, without having looked to closely yet, I think it would be best to pull the default for ai_algoritm out of C++ and put it into on of the .cfg’s.
20181115 01:54:16< mattsc> … now that ai_algorithm is actually somewhat useful  (thanks to celticminstrel, I think)
20181115 01:55:19< sevu> That's how the file should look, right? https://bpaste.net/show/7da40bc3b1d1
20181115 01:55:40< mattsc> Wrong wording: scratch the “somewhat”
20181115 01:55:57< mattsc> sevu: yes
20181115 01:57:06< mattsc> And I think I want to change it so that that is how it is defined for the RCA AI in the default setup as well.
20181115 01:57:35< mattsc> Which, as a side effect, will make it more obvious that that’s what you need to change.
20181115 01:58:33< sevu> I just realized why I get segfaults. If core has an error, then it segfaults. It was the halfway fix to an bug crashing with errors in UMC a few years ago. So, I probably get the same message as you.
20181115 01:58:54< mattsc> sevu: BTW, in 1.15 the file itself has also been renamed to data/ai/ais/ai_experimental.cfg
20181115 01:59:58< mattsc> I’m sure you do, because nothing has been changed on that part of the code in a long time  (I am doing my tests in 1.15, but that really does not matter for this)
20181115 02:01:21< sevu> How would one actually set the experimental AI as default for SP?
20181115 02:02:09< mattsc> Right now, you can’t, other than with the hack you found yourself (by changing its id=)
20181115 02:02:42< mattsc> Once I have that fixed, the [default_config]ai_algorithm= applies to both MP and SP.
20181115 02:04:11< sevu> What I actually wanted to do is to make it the first one in the drop down list in MP – so people start testing it.
20181115 02:04:35< mattsc> I think those are sorted alphabetically.
20181115 02:04:47< sevu> makes sense
20181115 02:04:56< mattsc> I might be wrong though …
20181115 02:08:15< sevu> Well, I will stick with the default AIs for that core…  
20181115 02:08:50< mattsc> Okay.  I am going to try to make that change anyway.
20181115 02:09:19< mattsc> I don’t think it should be too hard, but RL is really busy at the moment again, so I don’t know what that means in real time.
20181115 02:09:50< sevu> It's 1.15 only anyway, which won't be out for a while
20181115 02:10:13< mattsc> Well, I don’t know.
20181115 02:10:31< mattsc> We could argue that cores being broken is a bug that should be fixed in 1.14 also.
20181115 02:14:08< sevu> I think it won't work for < 1.14.6, so one would still work around it… though, a fix is a fix, and cores haven't been too popular yet 
20181115 02:15:15< irker575> wesnoth/wesnoth:master Severin Glöckner eb1ebe1cd8 Help: cut portraits of monsters, bats an AppVeyor: vs2015/Release Failed
20181115 02:15:16< irker575> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20310009
20181115 02:17:14< sevu> The Experimental AI know which units are not worthy it
20181115 02:17:54< sevu> I have a faction with 2 nearly identical recruits, one more expensive, and the Experimental always chooses the better one
20181115 02:24:24< mattsc> Well, good.  Alarantalara spent a lot of time on it.
20181115 02:24:55< mattsc> That doesn’t mean that there probably aren’t counter examples though.  Nobody’s perfect, not even Ron.
20181115 03:25:10< celticminstrel> Ron?
20181115 03:29:44< mattsc> That was the ExpAI’s name during development.
20181115 03:32:46< celticminstrel> Ah.
20181115 03:39:26< mattsc> celticminstrel: do you have any comments on the [default_config] and ai_algorithm thing in #3718?
20181115 03:39:44< mattsc> Asking since, I think, you are the one who made ai_algorithm generally usable.
20181115 04:02:12< celticminstrel> I don't really understand what's going on here.
20181115 04:02:33< celticminstrel> This is related to sevu's investigation into custom cores, right?
20181115 04:02:49< mattsc> Right.
20181115 04:02:59< celticminstrel> Isn't the default AI config itself part of the core? I don't recall its location being hardcoded in the C++?
20181115 04:03:39< celticminstrel> I guess that does mean that adding ai_algorithm in the default AI config is a way to set the default AI for a core...
20181115 04:03:55< mattsc> It is not, but the algorithm that gets used by default is no AI is specified is hard-coded in C++.
20181115 04:04:26< celticminstrel> Is that in the config parsing function?
20181115 04:04:27< mattsc> Hmm, in there.  That might work.
20181115 04:04:39< celticminstrel> ???
20181115 04:04:45< mattsc> It’s in ai/configuration.cpp IIRC.
20181115 04:04:57< celticminstrel> What might work?
20181115 04:05:04< mattsc> We’re one message out of sync.
20181115 04:05:17< mattsc> Specifying the algorithm in the AI config might work.
20181115 04:05:26< celticminstrel> ...wait, wasn't that what you were suggesting?
20181115 04:05:38< mattsc> I tried in [ais][default_config] and that works only partially.
20181115 04:05:49< celticminstrel> Oh. So what works and what doesn't?
20181115 04:06:01< mattsc> It works for MP, not for SP.
20181115 04:06:08< mattsc> It works meaning:
20181115 04:06:23< mattsc> In MP it finds and uses that AI.
20181115 04:06:41< mattsc> In SP, it finds two [ai] tags with conflicting algorithms and uses the first one.
20181115 04:06:58< celticminstrel> Which is the default or the scenario-specified one?
20181115 04:07:24< mattsc> There was no scenario-specifed one.
20181115 04:07:38< celticminstrel> I'm confused again.
20181115 04:07:51< mattsc> The two were the hard-coded default RCA algorithm, and the ExpAI algorithm I had put into [default_config]
20181115 04:08:26< mattsc> It doesn’t know what to do in that case and uses “the first one”.
20181115 04:08:36< celticminstrel> I wonder what Wesnoth will do if there is no AI configuration at all, ie even the default is missing.
20181115 04:08:57< mattsc> It complains …  and continues with an empty config.
20181115 04:10:07< mattsc> Ah, no, that might only be if [default_config] is missing:
20181115 04:10:08< mattsc> https://github.com/wesnoth/wesnoth/blob/master/src/ai/configuration.cpp#L49
20181115 04:10:24< mattsc> If it finds no AI, it simply does not do anything.
20181115 04:10:31< mattsc> That’s the problem sevu ran into.
20181115 04:12:30< mattsc> So you are suggesting adding ai_algorithm=experimental_ai here:
20181115 04:12:32< mattsc> https://github.com/wesnoth/wesnoth/blob/master/data/ai/ais/ai_experimental.cfg#L10 ?
20181115 04:12:38< celticminstrel> Okay... frankly I think that's what I'd expect anyway.
20181115 04:12:50< celticminstrel> I'm fine with sanctioning [default_config]ai_algorithm
20181115 04:12:51< mattsc> Yes, me too.
20181115 04:13:17< celticminstrel> Huh? Why would we add ai_algorithm=experimental_ai there?
20181115 04:13:40< celticminstrel> (BTW, did we deprecate {EXPERIMENTAL_AI} yet?)
20181115 04:13:56< mattsc> 20181115 04:03:39< celticminstrel> I guess that does mean that adding ai_algorithm in the default AI config is a way to set the default AI for a core...
20181115 04:14:05< mattsc> That’s how I interpreted that ^
20181115 04:14:10< celticminstrel> "default AI config" --> [default_config]
20181115 04:14:22< mattsc> Oh.
20181115 04:14:32< mattsc> I took it as config of the default AI
20181115 04:14:34< celticminstrel> Technically I think [default_config] is parsed identically to [ai]? Not 100% sure though.
20181115 04:14:46< celticminstrel> So adding ai_algorithm there seems reasonable.
20181115 04:14:59< mattsc> Yes, I think so too.
20181115 04:15:05< celticminstrel> As long as it doesn't prevent anyone from ever overriding the AI, obviously.
20181115 04:15:34< mattsc> Hmm.  Good point.  I’ll keep that in mind too.
20181115 04:15:51< celticminstrel> Which is kind of complicated in a way...
20181115 04:16:04< celticminstrel> Is the [default_config] merged in first or last?
20181115 04:16:18< mattsc> Don’t know.
20181115 04:16:32< celticminstrel> If it's last, that makes it easy, since IIRC the first ai_algorithm wins so that the MP engine can override the AI just by pre-inserting an extra [ai] tag...
20181115 04:17:12< mattsc> Yeah.
20181115 04:17:31< mattsc> I’ll have a look sometime in the next few days.  It might be more complicated than I had thought.
20181115 04:20:48< mattsc> On your other question, were we going to deprecate {EXPERIMENTAL_AI} ?
20181115 04:24:03-!- shiki [~sevu@p54855FAA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20181115 04:27:46-!- sevu [~sevu@p5485406D.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20181115 04:27:54< mattsc> celticminstrel: also, looks like the [default_config] is merged last, but then there’s a check later for different ai_algorithms which uses the first one but produces a warning.
20181115 04:28:14< mattsc> It looks like this is something that can be dealt with relatively easily though.
20181115 04:34:46-!- shiki [~sevu@p54855FAA.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20181115 04:40:19< celticminstrel> Yes, I think {EXPERIMENTAL_AI} should be deprecated in favour of ai_algorithm=experimental_ai
20181115 04:43:22< mattsc> Hmm, yeah, makes sense.  Does the standard macro deprecation syntax work for that?
20181115 04:43:30< celticminstrel> Yeah. Maybe do it at level 2?
20181115 04:43:40< mattsc> Okay.
20181115 04:43:47< mattsc> I’ll add it to The List.
20181115 04:44:03-!- celticminstrel is now known as celmin|sleep
20181115 04:46:42< irker575> wesnoth/wesnoth:1.14 Severin Glöckner fcc3662b7e fixup – remove typo AppVeyor: 1/4 builds failed
20181115 04:46:43< irker575> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20309984
20181115 06:25:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20181115 06:56:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20181115 07:15:17< irker575> wesnoth/wesnoth:master Severin Glöckner eb1ebe1cd8 Help: cut portraits of monsters, bats an AppVeyor: 1/4 builds failed
20181115 07:15:18< irker575> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20310009
20181115 07:53:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181115 08:24:18< irker575> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master fee7f00bd267 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode project https://github.com/wesnoth/wesnoth/commit/fee7f00bd26743abe2312d052cf5ea4bb7e685a4
20181115 08:50:02-!- travis-ci [~travis-ci@ec2-54-146-188-98.compute-1.amazonaws.com] has joined #wesnoth-dev
20181115 08:50:03< travis-ci> wesnoth/wesnoth#20198 (master - fee7f00 : Martin Hrubý (hrubymar10)): The build was fixed.
20181115 08:50:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/455382628
20181115 08:50:04-!- travis-ci [~travis-ci@ec2-54-146-188-98.compute-1.amazonaws.com] has left #wesnoth-dev []
20181115 08:50:18<+wesdiscordbot> <jyrkive> 👍
20181115 10:53:46-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 246 seconds]
20181115 11:24:26-!- irker575 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181115 12:13:33-!- sevu [~sevu@p54855FAA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20181115 12:24:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20181115 12:40:32-!- sevu [~sevu@p54855FAA.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20181115 12:55:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20181115 13:29:29< celmin|sleep> \o/
20181115 13:29:35< celmin|sleep> Build fixed, yay!
20181115 13:48:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20181115 13:48:56< celmin|sleep> ...does the replay actually include the timer though...?
20181115 13:49:00< celmin|sleep> https://github.com/wesnoth/wesnoth/issues/1892#issuecomment-439020367
20181115 13:50:30-!- celmin|sleep is now known as celmin|away
20181115 14:07:03-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20181115 14:38:27< Soliton> yes.
20181115 14:38:57< Soliton> seems to me like it might be a misunderstanding how the timer works exactly.
20181115 14:39:42< Soliton> in that game at least only the reservoir time is 300 which does not mean 5 minutes each turn.
20181115 14:39:49-!- irker712 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181115 14:39:49< irker712> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) fee7f00bd2 Fix Xcode project AppVeyor: All builds passed
20181115 14:52:06<+wesdiscordbot> <mattsc> @hrubymar10 Thanks for fixing the Xcode build.  data/schema still needs to be added to the files to be copied.
20181115 14:53:26< irker712> wesnoth: mattsc wesnoth:master 8c8cafaa70ea / data/ (ai/ais/ai_experimental.cfg core/macros/ai.cfg): Deprecate EXPERIMENTAL_AI macro https://github.com/wesnoth/wesnoth/commit/8c8cafaa70ead24ba3f3f496336ac9ebb5d593a8
20181115 14:53:58<+wesdiscordbot> <hrubymar10> @mattsc just data/schema folder?
20181115 14:54:30<+wesdiscordbot> <mattsc> That's the only difference I see between the repo folder and the resources folder.  So yes, I think.
20181115 14:55:31<+wesdiscordbot> <hrubymar10> ok, thank you for mentioning it
20181115 14:55:41<+wesdiscordbot> <mattsc> Thanks for doing the work!
20181115 14:56:33<+wesdiscordbot> <mattsc> I was going to do it, but it asked me about a whole bunch of options that I was not sure about.  😛
20181115 14:56:55< irker712> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 88550b85929e / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Add data/schema into macOS packages https://github.com/wesnoth/wesnoth/commit/88550b85929eabc9e3eb0859a4e41c71257ee157
20181115 14:57:03<+wesdiscordbot> <hrubymar10> Done already 😄 😛
20181115 14:57:27<+wesdiscordbot> <mattsc> Nice!
20181115 14:58:38<+wesdiscordbot> <mattsc> And now I don't see any difference any more, except for one stray .DS_store file.
20181115 14:58:59<+wesdiscordbot> <mattsc> (that's on my side, so nothing needs to be done about that)
20181115 15:31:56< Ravana_> sevu: BrokenPipeError: [Errno 32] Broken pipe
20181115 15:32:51< Ravana_> I see I got 22h before already (Ping timeout: 183 seconds)
20181115 15:34:02< Ravana_> message was logged though, 2018-11-15 14:11:58,040 - IRC - DEBUG - send PRIVMSG #wesnoth-bot :<Shiki> -> <bot_Laela>: Ah, the Bot is back =)
20181115 15:40:24< Ravana_> having bot with 2 bare socket connections is not very reliable
20181115 15:40:31< Ravana_> not using any libraries for that
20181115 15:42:23< Ravana_> started it again
20181115 15:43:13< Ravana_> (added try/catch for that socket.send, but I call it from other places too)
20181115 15:47:33< Ravana_> I added you to trusted users list, don't remember what it does, but I remember I added some dynamic help messages there
20181115 17:50:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181115 17:57:31-!- irker712 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181115 18:12:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20181115 18:13:46<+wesdiscordbot> <sevu> trusted users list… sounds interesting
20181115 18:46:44-!- irker735 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181115 18:46:44< irker735> wesnoth/wesnoth:master mattsc be3f353bf2 AI: deprecate ai_depth related macros AppVeyor: vs2017/Release Failed
20181115 18:46:44< irker735> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20331668
20181115 19:18:46< Ravana_> I checked that this allows you query stats about single user from previous sessions, and send private messages in the name of bot
20181115 19:19:42< Ravana_> I see irc connection has timed out again
20181115 19:23:41< Ravana_> I see I broke the logic of determining if bot has managed to join channel
20181115 19:24:22< Ravana_> I check if I get response that channel gave me +o, but now I get +ao
20181115 19:25:29-!- sevu [~sevu@p54855FAA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20181115 20:19:46< irker735> wesnoth/wesnoth:master newfrenchy83 98e1c984e6 fix indentation AppVeyor: vs2017/Release Failed
20181115 20:19:47< irker735> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20334112
20181115 21:03:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181115 21:04:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181115 21:17:08< irker735> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 88550b8592 Add data/schema into macOS packages AppVeyor: All builds passed
20181115 22:46:30-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181115 22:56:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20181115 22:57:04-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181115 22:57:31-!- stikonas_ is now known as stikonas
20181115 23:46:37< irker735> wesnoth/wesnoth:master mattsc be3f353bf2 AI: deprecate ai_depth related macros AppVeyor: 2/4 builds failed
20181115 23:46:38< irker735> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20331668
20181115 23:46:39< irker735> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20331672
--- Log closed Fri Nov 16 00:00:36 2018