--- Log opened Sun Nov 18 00:00:38 2018 20181118 01:34:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181118 02:06:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds] 20181118 02:18:24-!- irker209 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181118 02:24:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181118 02:56:57-!- irker332 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181118 02:56:57< irker332> wesnoth/wesnoth:master mattsc 39baea9ed0 AI configuration: new optional parameter AppVeyor: vs2015/Release Failed 20181118 02:56:57< irker332> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20380577 20181118 04:10:07< celticminstrel> ...oh, I bet that was me mis-merging. 20181118 04:12:17<+wesdiscordbot> gfgtdf: Restarted 20181118 04:12:25<+wesdiscordbot> (cc Soliton to avoid duplicated effort) 20181118 04:33:18< irker332> wesnoth: Celtic Minstrel wesnoth:master f49a02d839b6 / src/actions/attack.cpp: Fix merge error https://github.com/wesnoth/wesnoth/commit/f49a02d839b62c4b125aeb440c760b462c9d53c3 20181118 04:33:20< irker332> wesnoth: Celtic Minstrel wesnoth:master 9e518a666fc7 / changelog.md: Update changelog for recent merges https://github.com/wesnoth/wesnoth/commit/9e518a666fc7b6fb48e940509d5b2eb5e618a0cb 20181118 04:33:22< irker332> wesnoth: Celtic Minstrel wesnoth:master 1d76a98041f1 / data/core/about.cfg: Update credits for recent merge https://github.com/wesnoth/wesnoth/commit/1d76a98041f1c519620019d2b1f3a7fe7e1389d2 20181118 05:14:38-!- travis-ci [~travis-ci@ec2-54-159-120-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20181118 05:14:39< travis-ci> wesnoth/wesnoth#20224 (master - 1d76a98 : Celtic Minstrel): The build was fixed. 20181118 05:14:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/456527481 20181118 05:14:39-!- travis-ci [~travis-ci@ec2-54-159-120-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181118 05:46:25< irker332> wesnoth: Celtic Minstrel wesnoth:master 9e01b9ecb59c / src/ (serialization/schema_validator.cpp serialization/validator.hpp wesnoth.cpp): Fix several issues with the --validate command-line option https://github.com/wesnoth/wesnoth/commit/9e01b9ecb59c3ed6102858abe31530348a6aa105 20181118 05:46:27< irker332> wesnoth: Celtic Minstrel wesnoth:master 6936c59e17d2 / src/wesnoth.cpp: Fix --validate-core and --validate-addon implying --wconsole https://github.com/wesnoth/wesnoth/commit/6936c59e17d26188577dbe6513329f603868b94c 20181118 05:46:29< irker332> wesnoth: Celtic Minstrel wesnoth:master 90d1aec2f2db / src/serialization/ (parser.cpp schema_validator.cpp): Fix schema validator ignoring toplevel keys https://github.com/wesnoth/wesnoth/commit/90d1aec2f2dbec1f9a5eb8a8988f0a39c0505093 20181118 05:46:31< irker332> wesnoth: Celtic Minstrel wesnoth:master a8367c4bca1a / src/wesnoth.cpp: Add final status message to --validate(-schema) command in addition to the exit https://github.com/wesnoth/wesnoth/commit/a8367c4bca1a7bde54a3aeeefd306b690e16087b 20181118 05:46:33< irker332> wesnoth: Celtic Minstrel wesnoth:master e7903874ece3 / data/schema/core/config.cfg: Add new schema keys for the game config https://github.com/wesnoth/wesnoth/commit/e7903874ece31a4b71b6e5af4cce0f373f9dc2d4 20181118 05:57:42-!- celticminstrel is now known as celmin|sleep 20181118 06:10:07<+wesdiscordbot> we should remove "In many campaign scenarios, you may issue simple instructions for your computer-controlled allies using the right-click context menu." from tips.cfg, right? 20181118 06:10:17<+wesdiscordbot> as the AI controller is deprecated/removed 20181118 06:15:11< irker332> wesnoth/wesnoth:1.14 Victor Sergienko de55e0f0b8 Revised timer code due to crashes on som AppVeyor: All builds passed 20181118 06:32:10<+wesdiscordbot> yes 20181118 06:53:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181118 07:56:53< irker332> wesnoth/wesnoth:master mattsc 39baea9ed0 AI configuration: new optional parameter AppVeyor: 2/4 builds failed 20181118 07:56:54< irker332> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20380577 20181118 07:56:55< irker332> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20380578 20181118 08:20:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181118 09:49:35< irker332> wesnoth: josteph wesnoth:1.14 effc0d17e6ac / data/tips.cfg: AI Controller has been removed https://github.com/wesnoth/wesnoth/commit/effc0d17e6acf4c1130520079ade8a953482d67a 20181118 09:50:33< irker332> wesnoth: josteph wesnoth:master 205c7de0825f / data/tips.cfg: AI Controller has been removed https://github.com/wesnoth/wesnoth/commit/205c7de0825f6dbe633dc0c86619f3341372b25b 20181118 10:00:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181118 10:10:19<+wesdiscordbot> @josteph That's not a good commit message, BTW. The commit message should tell what the commit does. Your commit message looks like that's the commit that removes the AI controller. 20181118 10:23:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181118 10:28:44<+wesdiscordbot> @jyrkive Mea culpa. I could've said "Remove tip ..." in the log message. Next time... 20181118 10:36:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181118 10:36:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20181118 10:37:16-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20181118 10:40:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181118 11:03:56< irker332> wesnoth: josteph wesnoth:master 35828b1d328e / data/core/help.cfg: Help: Document more cases lit terrains. Linkify oasis https://github.com/wesnoth/wesnoth/commit/35828b1d328e8bb0c3a21a6b3e77ce219ef5008a 20181118 11:06:52< irker332> wesnoth: josteph wesnoth:1.14 c580c49df2ed / data/core/help.cfg: Help: Document more cases of lit terrains. Linkify oasis https://github.com/wesnoth/wesnoth/commit/c580c49df2ed48483311e2c1e6dedc2d4eb0dbe6 20181118 11:25:42< irker332> wesnoth: josteph wesnoth:master 42853719b435 / data/core/terrain.cfg: Help: Delete superfluous linebreaks. https://github.com/wesnoth/wesnoth/commit/42853719b4353805af0b277a80871606511827fe 20181118 12:27:34< irker332> wesnoth/wesnoth:master Celtic Minstrel e7903874ec Add new schema keys for the game config AppVeyor: All builds passed 20181118 12:29:46<+wesdiscordbot> https://github.com/wesnoth/wesnoth/issues/3197#issuecomment-439668604 20181118 12:30:41<+wesdiscordbot> question about sidebar ^, how to have an images on the left and text to their right, when the text is taller than the image 20181118 12:58:22<+wesdiscordbot> @shadowm I always wondered why there is a trunk server if the development version use another server. Maybe just use that, and remove the few add-ons currently there? (meaning https://addons.wesnoth.org/trunk/) 20181118 13:43:12< celmin|sleep> I suspect it's not possible. 20181118 13:43:30< celmin|sleep> But I'm not entirely clear on the ThemeWML's internal reports format either... 20181118 13:44:46< celmin|sleep> Doesn't the "indoors" time give a lawful bonus? 20181118 13:46:34<+wesdiscordbot> The code implementing that is refresh_report() in display.cpp 20181118 13:46:59<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/c580c49df2ed48483311e2c1e6dedc2d4eb0dbe6/src/display.cpp#L2857 20181118 14:22:34<+wesdiscordbot> @sevu don't know if you saw this: https://github.com/wesnoth/wesnoth/pull/3723/commits/c731be58a 20181118 14:22:43<+wesdiscordbot> This takes care of what you asked about yesterday. 20181118 14:23:20<+wesdiscordbot> Again, it's only in a PR so far, not merged yet, but it can be cherry-picked to 1.14 once that's done. 20181118 15:21:50<+wesdiscordbot> There are several AI todo comments that refer to an "extended event system". They go back to at least 1.7. For example here: https://github.com/wesnoth/wesnoth/blob/master/src/ai/actions.cpp#L309 Does anybody know what this refers to, and whether it has been done? Or is it not relevant any more and I can just delete the comment? 20181118 15:23:55<+wesdiscordbot> Also, there are a bunch of "refactor this" comments that are around 10 years old. I am tempted to just deleted those ... 20181118 15:26:21<+wesdiscordbot> I ran into the same comment when I made the AI manager a singleton. 20181118 15:27:20<+wesdiscordbot> I investigated it a bit at the time. Turns out that there's a class ai::game_info that exists in order to record recent attack locations and nothing else: https://github.com/wesnoth/wesnoth/blob/master/src/ai/game_info.hpp#L106-L116 20181118 15:28:57-!- irker332 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181118 15:29:09<+wesdiscordbot> In any case, I'm not very familiar with the AI, so I just did the minimum required for my change and made the game_info a member variable of the AI manager object. 20181118 15:30:06< celmin|sleep> Extended event system? Any idea what that could've meant in Wesnoth 1.8? 20181118 15:30:19< celmin|sleep> ...oh, nick. 20181118 15:30:23-!- celmin|sleep is now known as celticminstrel 20181118 15:31:06<+wesdiscordbot> I think the intention with these comments is that 1) there shouldn't be a class for the sole purpose of recording recent attack locations, and 2) the AI should listen for some kind of attack event instead of recording its attacks directly. 20181118 15:31:34<+wesdiscordbot> @jyrkive Yeah, on a quick first look I don't see that this class is being used for anything. 20181118 15:31:58<+wesdiscordbot> The game_info isn't even read anywhere? 20181118 15:32:46<+wesdiscordbot> @sevu The "trunk" add-ons server is used for both experimental add-ons server builds and content 20181118 15:33:03<+wesdiscordbot> So no 20181118 15:33:31<+wesdiscordbot> Look, I'll start the dev server eventually, it's not hard 20181118 15:33:36< celticminstrel> Search for "get_active_ai_info_for_side" and "get_ai_info" @mattsc 20181118 15:33:49<+wesdiscordbot> Sorry, I meant recent_attacks() inside game_info 20181118 15:33:59< celticminstrel> Oh. 20181118 15:34:19<+wesdiscordbot> Well, in that case it's still unused. 20181118 15:34:28<+wesdiscordbot> You have my permission to remove the whole class. 20181118 15:34:32< celticminstrel> src/ai/default/attack.cpp:265 20181118 15:34:53< celticminstrel> It's used in one place. 20181118 15:35:12< celticminstrel> Still, I think it's fine to remove the class and just directly use a vector of map locations. 20181118 15:35:46<+wesdiscordbot> Called attack_close()? At least it should be called attack_close_to_recent() or something more descriptive. 20181118 15:36:34< celticminstrel> Oh, looks like that function isn't even called anywhere? 20181118 15:36:38<+wesdiscordbot> If the class is used, I think it's a reasonable abstraction layer in case the AI needs to store more data in the future. 20181118 15:36:39< celticminstrel> Wait no. 20181118 15:36:50< celticminstrel> Wait... it's only called by itself? 20181118 15:37:21<+wesdiscordbot> attack_analysis::rating() calls it. 20181118 15:37:22<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/master/src/ai/default/attack.cpp#L312-L315 20181118 15:37:54< celticminstrel> Oh, because GitHub only shows the first match in a file, so I didn't see that. 20181118 15:38:24<+wesdiscordbot> So it's a check whether any allied AI has attacked the same target (or more accurately, same hex...) recently. 20181118 15:38:46<+wesdiscordbot> Yeah, I just saw that too. I'd missed that. 20181118 15:39:34<+wesdiscordbot> Also, does anything ever remove hexes from "recent_attacks", or does it simply record every attack the AI has ever done in the scenario? 20181118 15:39:43< celticminstrel> It's cleared somewhere. 20181118 15:39:53<+wesdiscordbot> Yes, they get removed at the beginning of a new turn. 20181118 15:39:53< celticminstrel> I found it a minute ago but I don't remember where that was. 20181118 15:40:15<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/master/src/ai/manager.cpp#L744 20181118 15:40:49<+wesdiscordbot> I see. It looks quite reasonable overall. 20181118 15:41:03<+wesdiscordbot> I think you can just remove the TODO comments and leave it as is. 20181118 15:41:24<+wesdiscordbot> Sounds good. Thanks. 20181118 15:44:19<+wesdiscordbot> If anybody has advice on some of the other TODO comments at the bottom of this list, please let me know: 20181118 15:44:20<+wesdiscordbot> https://github.com/wesnoth/wesnoth/issues/3695 20181118 15:44:47<+wesdiscordbot> I know what to do with most of them, but there's some separated out at the bottom that I don't know enough about. 20181118 15:56:01-!- irker182 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181118 15:56:01< irker182> wesnoth/wesnoth:1.14 josteph effc0d17e6 AI Controller has been removed AppVeyor: All builds passed 20181118 17:43:24<+wesdiscordbot> celticminstrel: https://github.com/wesnoth/wesnoth/issues/3708 should be closed now, right? 20181118 17:52:43< irker182> wesnoth: Jyrki Vesterinen wesnoth:master e9a6b95fd80d / / (5 files in 2 dirs): Better implementation of placing the clock (resolves #3582) https://github.com/wesnoth/wesnoth/commit/e9a6b95fd80dae3b79a713d043c5cff72308d6b6 20181118 18:14:09< irker182> wesnoth/wesnoth:1.14 josteph c580c49df2 Help: Document more cases of lit terrain AppVeyor: All builds passed 20181118 18:30:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181118 18:47:53<+wesdiscordbot> @jyrkive Thanks for the comments. I'll mark those TODOs as "can be deleted". And the same argument can be used for those that say "refactor ...", I think? 20181118 18:51:33<+wesdiscordbot> I don't really have anything to say about them. I commented those two TODOs above because they were about the attack prediction code that I maintain. 20181118 18:52:10<+wesdiscordbot> Fair enough. Thanks. 20181118 19:16:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181118 19:34:43< celticminstrel> This sounds like something that probably should be done if it's not already. https://github.com/wesnoth/wesnoth/blob/master/src/ai/actions.cpp#L804 20181118 19:35:23< celticminstrel> Not sure what is meant by "speculative unit map"? 20181118 19:35:31< celticminstrel> Guessing where units might move? 20181118 19:37:32< celticminstrel> I guess this is about making null a singleton. https://github.com/wesnoth/wesnoth/blob/master/src/ai/contexts.cpp#L581 20181118 19:37:46< celticminstrel> But looking at the variant code... it seems that Vultraz's rework does that, so I'd say it can be removed. 20181118 19:38:08< celticminstrel> It's a singleton variant_value, to be precise; the null variant is not a singleton, but the value it references is. 20181118 19:41:43< celticminstrel> Not sure what these two mean - what history is it referring to? https://github.com/wesnoth/wesnoth/blob/master/src/ai/manager.hpp#L18 20181118 19:42:55< celticminstrel> I guess this could be satisfied by moving the class to the cpp file; might be worth trying it and seeing if it breaks anything, but... if it breaks anything not easily changed, I'd say just remove the todo. https://github.com/wesnoth/wesnoth/blob/master/src/ai/manager.hpp#L51 20181118 19:43:35< celticminstrel> It says it's an implementation detail, so theoretically things shouldn't be depending on its layout... I'd at least be interested to see what things (if any) do depend on it. 20181118 19:44:11< celticminstrel> I see there's a second class in the same file that's also noted as an implementation details, so might be worth trying the same tactic on that (ie, move the class declaration to the cpp and see what breaks). 20181118 19:44:22 * celticminstrel is referring to command_history_item FTR. 20181118 19:47:02< celticminstrel> Not sure on this one; where are these commands even issued? Do they work in the 'f' console or something? I suppose that's the history the earlier pair was referring to, as well... https://github.com/wesnoth/wesnoth/blob/master/src/ai/manager.hpp#L500 20181118 19:48:11< celticminstrel> This seems to be asking something along the lines of, "do we need to calculate all unit move maps in order to calculate map ownership?" https://github.com/wesnoth/wesnoth/blob/master/src/ai/formula/function_table.cpp#L283 20181118 19:48:18< celticminstrel> If I've read the source correctly, anyway. 20181118 19:49:13< celticminstrel> My suggestion is that, unless you know the answer, just ignore it; FAI is in limbo anyway, so it probably doesn't matter that much. 20181118 19:49:49< celticminstrel> I'd hazard a guess that this todo is about removing the "mutable" annotation. https://github.com/wesnoth/wesnoth/blob/master/src/ai/default/contexts.hpp#L289 20181118 19:50:22< celticminstrel> mattsc: That's my thoughts on all the unticked "don't know" todos. (I don't think I missed any, did I?) 20181118 19:50:56< celticminstrel> For this, my reaction is about the same as you: "probably" https://github.com/wesnoth/wesnoth/blob/master/src/ai/contexts.cpp#L1186 20181118 19:51:59< celticminstrel> This seems a reasonable thing to add. I'm not in a position to evaluate how worthwhile it is though. https://github.com/wesnoth/wesnoth/blob/master/src/ai/actions.cpp#L422 20181118 19:54:16< celticminstrel> For this I'd say, try lowering it and see how it affects performance. It's entirely possible that whoever wrote the comment was wrong about the kind of impact it would have.+ https://github.com/wesnoth/wesnoth/blob/master/src/ai/default/ca_move_to_targets.cpp#L405 20181118 19:55:41< celticminstrel> On this, I wonder, under what circumstances is this function even called? I think the equivalent function in engine_fai is called when issuing commands through the 'f' console, but does the Lua version ever get called? https://github.com/wesnoth/wesnoth/blob/master/src/ai/lua/engine_lua.cpp#L380 20181118 19:56:15< celticminstrel> I think there definitely should be some path to that, especially if we plan to deprecate/remove FAI. 20181118 19:56:37< celticminstrel> ...speaking of deprecating... did I ever actually implement deprecation warnings in the schema validator? 20181118 20:23:39< irker182> wesnoth/wesnoth:master josteph 42853719b4 Help: Delete superfluous linebreaks. AppVeyor: All builds passed 20181118 20:43:02< mattsc> celticminstrel: Thanks for all the comments. I’ll try to go through them later today, but I start traveling tomorrow morning for most of the next 4 weeks, so I am pretty busy with preps for that. I copied them to a local file, so at the latest I can look at them tomorrow on the plane. 20181118 21:36:46< celticminstrel> Hmm... 20181118 21:37:22< mattsc> Hmm? 20181118 21:37:31< celticminstrel> data/_main.cfg includes {campaigns/}, but data/campaigns/ has no WML files. What happens in this case? 20181118 21:37:55< celticminstrel> Does it include every subfolder of campaigns, or does it include nothing? 20181118 21:38:23< mattsc> Hmm… 20181118 21:45:45< Ravana_> has to be nothing 20181118 21:46:37< celticminstrel> So, does it load the campaign's WML like an addon then? 20181118 21:48:13< Ravana_> I would say that either campaign path is hardcoded somewhere else, or some other line includes it 20181118 21:48:26< celticminstrel> Just tested: commenting out that line results in Wesnoth reporting that no campaigns are available. 20181118 21:50:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20181118 21:57:20< irker182> wesnoth: Celtic Minstrel wesnoth:master 8d9d5b7b2d32 / src/serialization/preprocessor.cpp: Fix crash if a file tries to pass arguments to a macro defined via --preprocess- https://github.com/wesnoth/wesnoth/commit/8d9d5b7b2d3212ef9c317cdb81f88f08afd2c45c 20181118 21:57:50< celticminstrel> Pentarctagon accidentally discovered this, yay ^ 20181118 22:16:12-!- gfgtdf [~Daniel@x4dbaf8e0.dyn.telefonica.de] has joined #wesnoth-dev 20181118 22:32:18< irker182> wesnoth/wesnoth:master josteph 024204fd8f Sidebar: Reformat trait tooltip AppVeyor: All builds passed 20181118 22:44:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181118 22:53:19<+wesdiscordbot> celticminstrel: Now I'm getting a bunch of errors about Extra tag [story]; there may only be 1 [story] in [scenario] 20181118 22:53:23<+wesdiscordbot> is that expected? 20181118 22:53:41< celticminstrel> Hmm. Not sure. 20181118 22:53:48< celticminstrel> I'd have to check the code. 20181118 22:54:09< celticminstrel> (I saw those errors too when I tried it, FTR) 20181118 22:54:44< celticminstrel> IMO there should only ever be one [story] in [scenario], but perhaps the code has a "grab them all and merge them" approach. 20181118 23:03:33<+wesdiscordbot> looks like there's a [story] tag explicitly in 01_Defend_the_Forest, then another one gets added via the {AOI_TRACK {JOURNEY_01_NEW}} macro 20181118 23:04:00<+wesdiscordbot> the other 4 validation errors are probably similar 20181118 23:04:28< celticminstrel> Question is, should this be fixed by changing the scenarios or by changing the schema... 20181118 23:05:11< celticminstrel> Well, to me, AOI_TRACK sounds like something that should be placed in a [story] tag. 20181118 23:05:46<+wesdiscordbot> I'm not sure why it isn't, to be honest 20181118 23:06:03<+wesdiscordbot> it's literally a [story] with a single [part] 20181118 23:06:08<+wesdiscordbot> story show_title=yes {AOI_BIGMAP} {STAGE} /part 20181118 23:10:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181118 23:15:32< celticminstrel> So it might be an open question whether the schema should be changed, but I think in this case it makes more sense to change the macro and how it's used. 20181118 23:24:55<+wesdiscordbot> I get the same validation error with DW, so my guess right now would be that the schema should be updated. I'll take a look at the rest of the campaigns later tonight though. 20181118 23:27:19< celticminstrel> I assume the track does work in AOI, right? 20181118 23:30:10<+wesdiscordbot> yeah, it's the bigmap [part] that displays the current location. 20181118 23:31:12< celticminstrel> I know what it is, thanks. 20181118 23:32:04< celticminstrel> So sure, we can change the schema. I still think the campaigns shouldn't be doing it that way, but it looks like it's technically valid. I'd recommend changing the campaigns too, since they should serve as a good example. 20181118 23:32:20< celticminstrel> But I suppose the priority is just making sure the schema validation passes for all campaigns. 20181118 23:32:37< celticminstrel> BTW, you should probably also add a difficulty to your --preprocess-defines 20181118 23:33:15< celticminstrel> Ideally we'd check on all difficulties, but it's probably sufficient in most cases to do just one. 20181118 23:33:37< celticminstrel> However, if you don't do any, stuff could definitely be missed, as that would effectively cut out every part that depends on difficulty. 20181118 23:35:01<+wesdiscordbot> yeah, DW actually had a few more errors until I added that, but I'll make sure to add them. validation seems to be quick enough that I don't think there's any reason not to do all the difficulties. 20181118 23:35:38< celticminstrel> It's good that it's quick; for me it was kinda slow. Might be because it's a debug build, though. 20181118 23:38:31<+wesdiscordbot> I'll have it only do the validation on one of the -O3 travis builds then, once everything else is solved. There isn't really a reason to run the validation on every build anyway. 20181118 23:38:45< celticminstrel> Yeah, definitely not. 20181118 23:55:31< celticminstrel> Might be useful to have a conditional so that it starts with one difficulty and only continues to the next difficulty if the first passes, to avoid heaps of duplicate errors in non-difficulty-dependent areas... 20181118 23:58:42<+wesdiscordbot> yeah, that'd be good. --- Log closed Mon Nov 19 00:00:40 2018