--- Log opened Thu Nov 22 00:00:53 2018 20181122 00:14:15< irker360> wesnoth/wesnoth:1.14 josteph 146346b726 fixup! Tips: Add two tips based on discu AppVeyor: All builds passed 20181122 00:52:03< celmin|away> @Pentarctagon - I think that's using new features that newfrenchy added to the engine, so no, it should validate as correct. 20181122 00:53:27-!- celmin|away is now known as celticminstrel 20181122 01:31:48<+wesdiscordbot> What would you suggest, in that case? The full error is: error validation: Tag [filter_opponent] may not be used in [*] at core/macros/utils.cfg:551 included from core/_main.cfg:18 included from data/_main.cfg:18 included from campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg:560 included from campaigns/Descent_Into_Darkness/_main.cfg:72 included from data/_main.cfg:38 20181122 01:35:43< celticminstrel> Since it's a new feature, the schema would need to be updated to allow it. 20181122 01:44:09<+wesdiscordbot> How would that be done? chance_to_hit already has super="units/unit_type/attack/specials/~value~" which has super="units/unit_type/attack/specials/~generic~" which has {FILTER_TAG "filter_opponent" unit {FILTER_TAG "filter_weapon" weapon ()}} 20181122 01:45:25<+wesdiscordbot> oh, that's for weapon specials, not abilities 20181122 01:49:37< celticminstrel> Yeah, indeed. 20181122 01:50:34< celticminstrel> I'm not 100% sure on what's allowed with these new abilities... it might be sufficient to just add a link to the specials tag under abilities? 20181122 02:02:55< celticminstrel> ...what if WML has numeric keys? How does that translate to Lua? 20181122 02:03:43< celticminstrel> Pentarctagon: On the other hand you might need to copy-paste the tag definition from specials and reparent it (ie change super) to the generic ability tag... 20181122 02:04:05<+wesdiscordbot> is [filter_second_weapon] a valid WML tag? 20181122 02:04:25<+wesdiscordbot> I don't see it on the wiki 20181122 02:05:50<+wesdiscordbot> it should be filter_defender, correct? 20181122 02:28:56< celticminstrel> newfrenchy's stuff probably isn't documented yet. 20181122 02:29:04< celticminstrel> [filter_second_weapon] should be valid, IIRC 20181122 02:29:56< celticminstrel> Yup, it's valid. https://github.com/wesnoth/wesnoth/blob/6ef7dd77ab7f3e64c74f1153a00b332361197f37/src/units/abilities.cpp#L419 20181122 02:30:25< celticminstrel> Only in leadership-style abilities IIRC. 20181122 02:30:39< celticminstrel> Which means [leadership], [resistance], and the new ones named after weapon specials. 20181122 02:42:31< celticminstrel> If someone could label this "Docs" that would be great. 20181122 02:42:32< celticminstrel> https://github.com/wesnoth/wesnoth/issues/3735 20181122 03:15:15-!- irker360 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181122 03:16:55-!- irker654 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181122 03:16:56< irker654> wesnoth/wesnoth:master DisherProject f8b1f4b388 UtBS S12: Code refactor AppVeyor: All builds passed 20181122 03:43:42-!- celticminstrel is now known as celmin|sleep 20181122 04:31:13< irker654> wesnoth/wesnoth:master DisherProject 27da7dcb82 UtBS S12: Code refactor AppVeyor: All builds passed 20181122 05:35:51< irker654> wesnoth/wesnoth:master Nils Kneuper d7644f0c83 updated French translation AppVeyor: All builds passed 20181122 07:09:02<+wesdiscordbot> ...are all leaders in LoW supposed to have the name as "name"? 20181122 07:22:19<+wesdiscordbot> looks like it's not just LoW, actually 20181122 07:51:36< irker654> wesnoth/wesnoth:1.14 Nils Kneuper 4be068696b updated French translation AppVeyor: All builds passed 20181122 08:06:12<+wesdiscordbot> What is the armor_color_shift attribute on [object]? 20181122 08:42:04<+wesdiscordbot> random attribute for use by filter_wml 20181122 08:42:23<+wesdiscordbot> it's not used anywhere else except those two instances 20181122 10:52:33-!- irker654 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181122 12:24:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181122 12:34:30< zookeeper> celmin|sleep, @Pentarctagon the functional difference between single and multiple [story] tags was (and probably still is?) that pressing the "skip" button only skipped to the end of the current [story]. so, pressing skip meant during the story text was typically a way to fast-forward directly to the bigmap part (since it was typically a separate [story] tag). 20181122 12:34:51< zookeeper> -meant 20181122 12:49:21<+wesdiscordbot> 🤔 20181122 12:49:35<+wesdiscordbot> I wonder if that remained after I reimplemented it 20181122 13:12:02< zookeeper> doesn't look like it. in 1.14.5 "skip" skips everything. which AFAICT is perfectly fine. 20181122 13:13:35< zookeeper> (in fact, i think we even discussed it sometime earlier and deemed the current behavior at least as good as the old one) 20181122 13:50:38< celmin|sleep> [object] should have {ANY_KEY} ... I thought it already did tho? 20181122 13:50:47< celmin|sleep> @Pentarctagon ^ 20181122 13:51:12-!- celmin|sleep is now known as celmin|away 20181122 13:56:03-!- irker938 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181122 13:56:03< irker938> wesnoth: Celtic Minstrel wesnoth:master 0bf377ab9fe5 / data/lua/helper.lua: Lua API: Fix some deprecations of game-only functions https://github.com/wesnoth/wesnoth/commit/0bf377ab9fe5f4fd44a62d4ff4117a1f133fffc0 20181122 15:25:09< irker938> wesnoth/wesnoth:master pentarctagon 92d805fde8 Run WML schema validation in travis. Fix AppVeyor: All builds passed 20181122 16:19:34<+wesdiscordbot> Are there any plans for 1.14.6 release? 20181122 16:22:02<+wesdiscordbot> celmin|sleep: the object tag does not have ANY_KEY defined for it, and actually both places it exists (units/modifications.cfg and core/actionwml.cfg) have specific key defined for it. 20181122 16:35:33<+wesdiscordbot> key -> keys 20181122 16:35:59<+wesdiscordbot> celmin|sleep: so, let me know where I should change it to ANY_KEY 20181122 16:36:23<+wesdiscordbot> also does doing so remove any need to have specific keys defined? 20181122 18:26:07-!- irker938 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181122 19:46:50< Ravana_> I was finally able to register Ravana for freenode. Should I ask for wesnoth cloak this time? 20181122 19:48:19<+wesdiscordbot> If you want? 20181122 19:48:48< shadowm> Does anyone else want cloaks before I go ask staff? 20181122 19:49:39< shadowm> You registered it in a new account instead of grouping it to your existing one 20181122 19:50:52< Ravana_> going to investigate how to group them 20181122 19:51:14< shadowm> First you need to delete an account 20181122 19:51:20< shadowm> Probably the newest one 20181122 19:51:48< shadowm> And then log into the account to which the nick should belong, /nick to it, and then use /Msg nickserv group 20181122 19:54:55-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [] 20181122 19:56:32-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20181122 19:57:19-!- Ravana [50eb522a@gateway/web/freenode/ip.80.235.82.42] has joined #wesnoth-dev 20181122 19:57:43< Ravana> should be grouped now 20181122 20:19:29< shadowm> You can additionally use /msg nickserv set accountname Ravana 20181122 20:20:19< Ravana_> done 20181122 20:22:44-!- Ravana [50eb522a@gateway/web/freenode/ip.80.235.82.42] has quit [Changing host] 20181122 20:22:44-!- Ravana [50eb522a@wesnoth/mp-mod/ravana] has joined #wesnoth-dev 20181122 20:22:44-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Changing host] 20181122 20:22:44-!- Ravana_ [~Ravana@wesnoth/mp-mod/ravana] has joined #wesnoth-dev 20181122 20:22:49< shadowm> It's done 20181122 20:28:21-!- Ravana [50eb522a@wesnoth/mp-mod/ravana] has left #wesnoth-dev [] 20181122 21:04:49-!- Ravana_ [~Ravana@wesnoth/mp-mod/ravana] has quit [] 20181122 21:05:52-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has joined #wesnoth-dev 20181122 21:09:36-!- irker132 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181122 21:09:36< irker132> wesnoth/wesnoth:master Celtic Minstrel 0bf377ab9f Lua API: Fix some deprecations of game-o AppVeyor: All builds passed 20181122 21:58:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181122 21:59:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds] 20181122 23:35:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Fri Nov 23 00:00:54 2018