--- Log opened Sun Nov 25 00:00:57 2018 20181125 00:20:14-!- travis-ci [~travis-ci@ec2-54-166-160-21.compute-1.amazonaws.com] has joined #wesnoth-dev 20181125 00:20:15< travis-ci> wesnoth/wesnoth#20268 (master - 64279eb : Celtic Minstrel): The build was broken. 20181125 00:20:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/459264072 20181125 00:20:15-!- travis-ci [~travis-ci@ec2-54-166-160-21.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181125 00:20:27< celticminstrel> Whee! 20181125 00:20:52< celticminstrel> Seems like it's probably a schema validation error, since only one build failed... 20181125 00:22:00< celticminstrel> Or... maybe not? 20181125 00:22:43< celticminstrel> Oh there they are. It is indeed a schema validation error. 20181125 00:23:59< celticminstrel> Okay, so basically I guess the fix would be to wrap id= in [filter]...? Technically id= is still valid though, it's just deprecated... 20181125 00:24:21< celticminstrel> TBH I'm surprised there was only a single instance of it. 20181125 00:24:42< celticminstrel> (Maybe I converted all the other instances earlier and this is just a newer one?) 20181125 00:24:50< celticminstrel> Okay two instances, close enough. 20181125 01:31:03< irker157> wesnoth/wesnoth:master newfrenchy83 e9de586309 fix tab AppVeyor: All builds passed 20181125 01:33:06< celticminstrel> I wonder if we should lock this? Or is it still useful for it to continue to accrue occasional responses? https://forums.wesnoth.org/viewtopic.php?p=635623#p635623 20181125 01:54:45<+wesdiscordbot> @PastaSaucey What do you mean? 20181125 01:55:07<+wesdiscordbot> Oh nvm, you got answered in general 20181125 02:29:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181125 04:31:38-!- irker157 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181125 06:01:00-!- irker811 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181125 06:01:00< irker811> wesnoth/wesnoth:master newfrenchy83 88403b9a92 Update attack.hpp AppVeyor: All builds passed 20181125 06:58:26<+wesdiscordbot> celmin, There are some trait icons in icons-abilities.png, but I'm sure LordBob can improve on those 😃 As to my name, either spelling works. 20181125 06:59:00<+wesdiscordbot> celmin, I'm 'jostephd' on github only because 'josteph' was taken. 20181125 06:59:26< celticminstrel> So josteph then. 20181125 07:00:24< celticminstrel> IMO we don't need separate leadership flags for each level. 20181125 07:00:46< celticminstrel> Those traits icons look fairly decent, I guess? 20181125 07:01:43< celticminstrel> Not entirely sure what they're all meant to be, mind you... 20181125 07:01:50< celticminstrel> Some are obvious, others a bit less so. 20181125 07:02:05< celticminstrel> If you wanted to add icons to traits BTW, then it should obviously be a new attribute in [trait]. 20181125 07:02:42< celticminstrel> Ohhh, icons-abilities isn't just traits, I see. There's clearly heals and cures on the fourth line. 20181125 07:03:07< celticminstrel> (And yeah it'd be nice to have icons for abilities too. Maybe a little bigger though.) 20181125 07:11:26<+wesdiscordbot> the leadership flags are for the deprecated LEADERSHIPLEVEL{1..5} abilities 20181125 07:11:48< celticminstrel> Right. Like I said, one icon for leadership is quite enough IMO. 20181125 07:11:56<+wesdiscordbot> yes 20181125 07:12:08<+wesdiscordbot> the crown icon could be used for that 20181125 07:12:19<+wesdiscordbot> though it was actually meant to be 'loyal' 20181125 07:12:41<+wesdiscordbot> https://forums.wesnoth.org/viewtopic.php?f=12&t=47666 https://forums.wesnoth.org/viewtopic.php?f=9&t=21873 https://forums.wesnoth.org/viewtopic.php?f=9&t=35686 20181125 07:12:55<+wesdiscordbot> one of these threads has the legend 20181125 07:13:22< celticminstrel> I mean, there's nothing wrong with the flag icon for leadership. 20181125 07:13:27< celticminstrel> Just no need for a number. 20181125 07:13:38< celticminstrel> Crown for loyal does seem rather inappropriate. 20181125 07:13:54<+wesdiscordbot> by the way, there's also icon-resistances.png (together with icons-numbers.png) 20181125 07:14:12< celticminstrel> I saw that, yeah... 20181125 07:14:27< celticminstrel> I guess icon-resistances isn't really needed? Since it's just the damage types? 20181125 07:14:52< celticminstrel> ...oh yeah, didn't you implement a method to add icons for custom ranges and damage types? 20181125 07:15:18<+wesdiscordbot> I think icons-resistances was intended for the help 20181125 07:15:38<+wesdiscordbot> to add icons for a custom range, just add a png file with the right name, for now 20181125 07:16:53<+wesdiscordbot> would we want trait/ability icons to be in color 20181125 07:17:01< celticminstrel> Not sure... 20181125 07:17:17<+wesdiscordbot> are these greyscale icon supposed to be TC'd or something? 20181125 07:17:39< celticminstrel> I think most of the other icons are monochrome, right? The range icons, the damage type icons, the terrain type icons... 20181125 07:18:08<+wesdiscordbot> range and type icons are two-color, but in a good way 20181125 07:18:25<+wesdiscordbot> they all have the same color so they're immediately recognizable 20181125 07:18:31< celticminstrel> I mean, even "black and white" is technically two-colour, but it would be called monochrome. 20181125 07:18:55<+wesdiscordbot> well, yeah, a nullochrome would be rather boring 😃 20181125 07:19:12< celticminstrel> I guess two-colour is what I meant. 20181125 07:19:31<+wesdiscordbot> I know what you meant, anyway 20181125 07:20:57< celticminstrel> If they were meant to be TCed they probably should've been magenta. 20181125 07:21:02< celticminstrel> Like the terrain type icons. 20181125 07:21:19< celticminstrel> So my guess would be they weren't meant to be. 20181125 07:36:24< irker811> wesnoth/wesnoth:master Celtic Minstrel 64279eb4a3 Fix schema conditionals not working AppVeyor: All builds passed 20181125 07:45:08-!- celticminstrel is now known as celmin|sleep 20181125 08:46:02-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181125 09:36:53-!- TC01 [~quassel@venus.arosser.com] has quit [Quit: No Ping reply in 180 seconds.] 20181125 09:37:02-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20181125 09:47:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181125 10:36:59-!- irker811 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181125 11:18:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181125 14:05:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181125 14:05:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181125 14:06:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181125 15:10:43-!- celmin|sleep is now known as celticminstrel 20181125 16:09:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181125 22:56:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20181125 23:19:51-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Mon Nov 26 00:00:58 2018