--- Log opened Tue Nov 27 00:00:00 2018 20181127 00:42:27< irker052> wesnoth/wesnoth:1.14 nemaara 1fc4698610 TSG S2: changed dialogue wording AppVeyor: All builds passed 20181127 00:50:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181127 01:20:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181127 01:55:25< irker052> wesnoth: gfgtdf wesnoth:master 2dfe3f24b4ff / src/playturn.cpp: clientside fix for #3717 : oos for allies caused by planned recruits https://github.com/wesnoth/wesnoth/commit/2dfe3f24b4ffda06d88b23f1a80c9a8149361342 20181127 01:56:58< irker052> wesnoth: gfgtdf wesnoth:1.14 81661bdfa4b2 / src/playturn.cpp: clientside fix for #3717 : oos for allies caused by planned recruits https://github.com/wesnoth/wesnoth/commit/81661bdfa4b2f47990dea7276c9c8aa71e745b7c 20181127 02:22:39-!- travis-ci [~travis-ci@ec2-54-234-96-152.compute-1.amazonaws.com] has joined #wesnoth-dev 20181127 02:22:40< travis-ci> wesnoth/wesnoth#20279 (master - 2dfe3f2 : gfgtdf): The build is still failing. 20181127 02:22:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/460047846 20181127 02:22:41-!- travis-ci [~travis-ci@ec2-54-234-96-152.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181127 02:23:09< celticminstrel> I guess because no-one fixed the schema validation errors. 20181127 02:29:59<+wesdiscordbot> grid iteration failure 20181127 03:07:30< irker052> wesnoth/wesnoth:master Jyrki Vesterinen 2753b6617b Fix issues with classic theme AppVeyor: All builds passed 20181127 03:34:34< celticminstrel> Oh? 20181127 03:34:41< celticminstrel> You think that's the cause of the failure? 20181127 03:35:07< celticminstrel> It's true that on the last failed build there was all the grid stuff, so maybe there's two things that need fixing. 20181127 03:35:36< celticminstrel> Strange though that it just so happens to occur on the schema validation one... 20181127 03:35:46< celticminstrel> While the schema validation is also failing... 20181127 03:35:49< celticminstrel> Coincidence? 20181127 03:35:52< celticminstrel> Maybe not? 20181127 04:41:22<+wesdiscordbot> The boost unit tests have had that iteration failure message for a while now. 20181127 04:41:43< celticminstrel> Ah. Okay then. 20181127 05:27:28-!- celticminstrel is now known as celmin|sleep 20181127 05:42:44<+wesdiscordbot> not that I think that's good - I don't think it should be printing about failures like that when it's not actually an error - but the return code at least says it completed successfully. 20181127 05:51:08< irker052> wesnoth/wesnoth:1.14 Jyrki Vesterinen bd3d423740 Changelog entry for classic theme fixes AppVeyor: All builds passed 20181127 06:57:48< irker052> wesnoth/wesnoth:master newfrenchy83 43022e7b19 Update heal.cpp AppVeyor: All builds passed 20181127 07:20:52<+wesdiscordbot> was my refactor of the iteration code backported? 20181127 07:24:49<+wesdiscordbot> You mean this? https://github.com/wesnoth/wesnoth/commit/3bc7c6a3a0a69c95a74eda309fa202b9cd071a62 20181127 07:24:54<+wesdiscordbot> It wasn't backported. 20181127 07:39:40<+wesdiscordbot> Blaaaaahhhhhhhhhhhhhhggggggg 20181127 07:40:31<+wesdiscordbot> I need to go back and see if I can port a bunch of my refractors 20181127 07:40:36<+wesdiscordbot> Refractors 20181127 07:40:40<+wesdiscordbot> REFACTORS 20181127 07:40:56<+wesdiscordbot> AFAIK, the reason why Josteph backported almost none of your commits is that commits made to a broken branch can't be trusted (they may have broken things without anyone noticing). 20181127 07:41:27<+wesdiscordbot> Now when we have a working master branch, it would indeed be possible to backport your commits, because we would notice if they break something. 20181127 07:42:55<+wesdiscordbot> Broken branch... 20181127 07:43:17<+wesdiscordbot> The UI was completely functional 20181127 07:44:41<+wesdiscordbot> It was the gamemap and ingame UI that was broken 20181127 07:44:43<+wesdiscordbot> Jostepth probably didn't want to spend the effort of thinking "did this commit affect only things which continued to work in master?" 20181127 07:44:46<+wesdiscordbot> GUI2 worked fine 20181127 07:45:01<+wesdiscordbot> Yes, I know, backporting will take some effort 20181127 07:45:13<+wesdiscordbot> But it was functional code 20181127 07:51:33<+wesdiscordbot> Feels like we can't go two weeks without having a rehash of the AR conversation 20181127 09:19:40< irker052> wesnoth/wesnoth:master gfgtdf 2dfe3f24b4 clientside fix for #3717 : oos for allie AppVeyor: All builds passed 20181127 09:21:08-!- valdar [~atarocch@83.219.38.74] has joined #wesnoth-dev 20181127 12:07:15< irker052> wesnoth/wesnoth:1.14 gfgtdf 81661bdfa4 clientside fix for #3717 : oos for allie AppVeyor: All builds passed 20181127 12:16:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181127 13:26:18< celmin|sleep> "disable Esc existing" XD 20181127 13:29:45-!- celmin|sleep is now known as celmin|away 20181127 15:08:04-!- irker052 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181127 15:45:18<+wesdiscordbot> FYI Ivanovic will be offline for 3 weeks, so if you do decide to start a string freeze before he's back it'd be good if you told people to send me their stuff instead. 20181127 16:00:19-!- gfgtdf [~androirc@tmo-119-151.customers.d1-online.com] has joined #wesnoth-dev 20181127 16:14:53-!- gfgtdf [~androirc@tmo-119-151.customers.d1-online.com] has quit [Remote host closed the connection] 20181127 16:15:08-!- gfgtdf [~androirc@tmo-119-151.customers.d1-online.com] has joined #wesnoth-dev 20181127 16:28:16-!- gfgtdf [~androirc@tmo-119-151.customers.d1-online.com] has quit [Ping timeout: 268 seconds] 20181127 17:24:05-!- irker218 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181127 17:24:05< irker218> wesnoth: Jyrki Vesterinen wesnoth:1.14 c067a8110e61 / src/ (theme.cpp theme.hpp): Hide battery charge indicator on small screens (fixes #3714) https://github.com/wesnoth/wesnoth/commit/c067a8110e614999f392a8b1c098b90a705d7a5e 20181127 17:24:05< irker218> wesnoth: Jyrki Vesterinen wesnoth:1.14 9955e73aec92 / changelog.md: Changelog entry for commit c067a8110e614999f392a8b1c098b90a705d7a5e https://github.com/wesnoth/wesnoth/commit/9955e73aec928e033872c4b02b40b383d39f275a 20181127 17:25:39< irker218> wesnoth: Jyrki Vesterinen wesnoth:master 4e9b2555dfcd / src/ (theme.cpp theme.hpp): Hide battery charge indicator on small screens (fixes #3714) https://github.com/wesnoth/wesnoth/commit/4e9b2555dfcd70dc69b5392c37a80a01395e5264 20181127 17:30:23-!- gfgtdf [~androirc@134.76.63.8] has joined #wesnoth-dev 20181127 18:02:14-!- valdar [~atarocch@83.219.38.74] has quit [Ping timeout: 246 seconds] 20181127 18:10:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181127 18:11:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181127 18:14:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20181127 18:37:55-!- valdar [~atarocch@31.22.2.141] has joined #wesnoth-dev 20181127 18:44:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20181127 18:46:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds] 20181127 18:46:49-!- wedge010 is now known as wedge009 20181127 18:55:58-!- stikonas_ is now known as stikonas 20181127 20:24:06-!- gfgtdf [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20181127 20:26:08-!- irker218 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181127 21:14:16-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20181127 21:47:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20181127 23:07:16-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 250 seconds] 20181127 23:10:44-!- valdar [~atarocch@31.22.2.141] has quit [Ping timeout: 250 seconds] 20181127 23:12:36-!- valdar [~atarocch@31.22.2.141] has joined #wesnoth-dev 20181127 23:46:52-!- irker368 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181127 23:46:52< irker368> wesnoth/wesnoth:1.14 Jyrki Vesterinen 9955e73aec Changelog entry for commit c067a8110e614 AppVeyor: All builds passed --- Log closed Wed Nov 28 00:00:01 2018