--- Log opened Mon Nov 05 00:00:49 2018
20181105 02:11:21-!- gfgtdf [~Daniel@x4dba31d5.dyn.telefonica.de] has quit [Quit: Leaving]
20181105 03:18:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20181105 03:46:58-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-umc-dev
20181105 04:18:22< hk238> Hmm 
20181105 04:18:34< hk238> I was thinking about merging damage and defense into random damage
20181105 04:18:53< hk238> so that the result would depend on the type of the attackers weapon
20181105 04:25:41< hk238> probably too much effort :D
20181105 06:06:41-!- celticminstrel is now known as celmin|sleep
20181105 06:10:58<+wesdiscordbot> <Pentarctagon> hk238: maybe a name with "clans" or something similar in it, given the "multi-faction faction" part? (not sure if you saw my previous comment)
20181105 06:11:19< hk238> YEah that could work
20181105 06:11:23< hk238> Bloodclans
20181105 06:11:24< hk238> :D
20181105 08:17:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev
20181105 08:35:42-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-umc-dev
20181105 09:30:57-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 252 seconds]
20181105 09:44:22-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-umc-dev
20181105 09:58:12< hk238> hmm this color mod seems to work in a strange way
20181105 09:58:32< hk238> I made it not required and now the first player to test it says red player's color has changed to green, but that doesn't make any sense
20181105 09:58:33< hk238> :D
20181105 10:06:32< hk238> so my opponent says that both players nicknames in text are red, village flags are green, and units are pink
20181105 10:06:37< hk238> which doesn't make any sense
20181105 10:06:45< hk238> unless someone can tell what that's about? For me it works fine though
20181105 10:11:24< zookeeper> perhaps everyone needs to have it installed for it to work. just marking it as "not required" doesn't magically make it so.
20181105 10:12:26< zookeeper> it just allows people who don't have it to join (or whatever), whether it actually works then is up to the author.
20181105 10:13:56< hk238> Yeah it seems it doesn't work.. but the behavior is weird, coz I don't see why the colors get crazy when they dont have the addon
20181105 10:14:12< hk238> I wonder if it's because of variable declaration?
20181105 10:15:50< hk238> https://pastebin.com/824EY00V
20181105 10:17:48< hk238> like if I have the color_range defined in the addon and then there's the part that says wesnoth.get_variable
20181105 10:18:07< hk238> but if they don't have the addon, then they dont have color ranges in those variables.? :D
20181105 10:18:40< zookeeper> the other players' clients don't have any knowledge of [color_range] tags defined in some random .cfg file on your computer, so... yeah, they presumably don't have them.
20181105 10:19:46< hk238> could this be fixed by moving the definition inside the lua tags?
20181105 10:20:11< hk238> or the event tags? What kind of stuff actually works if you dont have the mod installed? :o
20181105 10:20:22< hk238> clearly something works if they get messed up, the colors tthat is
20181105 10:20:48< zookeeper> no, and no. anyway, i don't know where you got the idea that wesnoth.get_variable deals with color ranges and not variables.
20181105 10:21:43< hk238> It's actually from Ravana's Color Changer and it works
20181105 10:21:52< hk238> just doesn't work for someone who doesn't have the mod
20181105 10:22:04< hk238> but clearly if the colors get messed up on other clients, it's doing something even if they don't have it
20181105 10:23:21< zookeeper> your prestart event gets executed on other clients, and if your wesnoth.set_side_id calls specify an invalid color then probably it gets reset to none, which in practise would mean magenta for units and green for flags.
20181105 10:24:41< hk238> yeah so the lua code is working
20181105 10:24:50< hk238> so if I Could define the color ranges inside the lua tags it might work then? 
20181105 10:25:18< zookeeper> if only you could, but AFAIK you cannot.
20181105 10:26:13< zookeeper> i wouldn't be surprised if there was a workaround, but i'm not aware of any.
20181105 10:27:32< hk238> dang
20181105 10:27:33< hk238> :D
20181105 10:29:30< vn971> hk238: I think there's some stuff like you can't have a color mod NOT installed by observers.
20181105 10:29:51< vn971> otherwise anyone without the add-on will have broken colors... Which is kinda what happened.
20181105 10:30:00< hk238> yeah but it's strange coz you can use set side command in lua
20181105 10:30:24< hk238> seems like it doesn't make sense not to be able to define a color, while you can set it (and thus end up with broken colors)
20181105 10:30:40< vn971> I see that Ravana_-s mod also sets  [color_range]
20181105 10:31:23< vn971> as a top-level tag. Higher than [multiplayer]
20181105 10:31:35< vn971> Sorry, higher than [modification]
20181105 10:31:42< zookeeper> and that mod requires installation, right?
20181105 10:32:00< vn971> zookeeper: Ravana_-s? Yes.
20181105 10:32:42< vn971> zookeeper: previously it didn't, and you could get a broken picture because of that. VERY broken, like all colors being red.
20181105 10:33:55< zookeeper> in any case, you could surely make such an add-on work so that anyone who doesn't have it installed simply sees no change whatsoever. guard your color-changing code with an if that only passes if some condition is true which can only be true if the add-on is installed, and so on.
20181105 10:35:04< hk238> yeah, but I can also make it required I guess... hmm this is kind of weird :D
20181105 10:36:11< vn971> zookeeper: nice BTW.
20181105 10:36:34< vn971> there's a special WML guard for "file exists" IIRC.
20181105 10:37:00< zookeeper> that's a preprocessor directive, it wouldn't work in this case.
20181105 10:37:34< vn971> #ifhave ~add-ons/My_Addon/_main.cfg
20181105 10:37:35< vn971> {MY_ADDON_MACROS}
20181105 10:37:35< vn971> #endif
20181105 10:37:42< vn971> https://wiki.wesnoth.org/Preprocessorref#.23ifhave_and_.23ifnhave
20181105 10:37:48< vn971> zookeeper: why wouldn't it? I think it would.
20181105 10:38:08< hk238> I set it to require :o
20181105 10:38:20< vn971> oh, there'll be miscommunication in chat then.
20181105 10:38:38< hk238> you could check the contents of the variable? like if it's blank or a color?
20181105 10:38:43< vn971> like " - red should take 11,10 - What red, there's brown?"
20181105 10:38:49< hk238> an OR statement basically?
20181105 10:39:27< zookeeper> vn971, yes, and what happens? the host has that file, host's client ends up with WML/Lua code that sets a side's color to foobar, then other clients get that same code from the host and try to set a side's color to foobar, and their client doesn't know of any such color.
20181105 10:39:43< vn971> hk238: depends on your goal. Are you OK with one player seeing a side as "red", but the other seeing as e.g. "green"?
20181105 10:39:56< zookeeper> instead you might want to use if wesnoth.have_file
20181105 10:41:13< hk238> I like these colors more than the standard :d
20181105 10:41:16< vn971> zookeeper: ah you're right. I forgot the order in which this WML is expanded. Other clients will get the expanded version, *after* preprocessor-s rules.
20181105 10:41:25< zookeeper> yeah
20181105 10:41:35< zookeeper> which is why you need a run-time check
20181105 10:41:44< vn971> yeah, got it.
20181105 10:42:18< vn971> hk238: regarding variables. Yeah, of course you can check if a variable is empty -- at least from Lua.
20181105 10:44:17< vn971> This should work I guess   `if (wesnoth.get_variable("test") or "") == ""`
20181105 10:44:27< vn971> checks if it's either nil or "".
20181105 10:44:45< vn971> If you just want to check for `nil`, the   wesnoth.get_variable("test") == nil
20181105 12:17:13< hk238> Btw if a movetype file is missing defense and resistance definition, will it still work?
20181105 12:17:39< hk238> I thought that for sake of neatness I could strip those bits from the file
20181105 12:31:21-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Ping timeout: 252 seconds]
20181105 12:47:13-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-umc-dev
20181105 12:59:04<+wesdiscordbot> <eurydike> any suggestions for a name of a vampire elf unit?
20181105 12:59:04<+wesdiscordbot> <eurydike> https://cdn.discordapp.com/attachments/442775044590927873/508988615355924481/vampire_elf.png
20181105 13:18:04< hk238> decided to go with 'freya' and 'valfreya'
20181105 13:29:15< hk238> Making WML files is very tedious
20181105 13:29:17< hk238> :D
20181105 13:31:11<+wesdiscordbot> <Pentarctagon> they are verbose.
20181105 13:31:15<+wesdiscordbot> <Pentarctagon> 😃
20181105 13:36:12< hk238> 27 files to go
20181105 13:36:28< hk238> out of 32
20181105 13:39:43< hk238> 26... Although all of these need to be revised since the stats probably don't make any sense whatsoever
20181105 13:41:09< celmin|sleep> Why is Freya a vampire now?
20181105 13:41:21< celmin|sleep> IIRC she's the Norse goddess of love and some other things.
20181105 13:41:50< hk238> Yeah
20181105 13:42:10< hk238> Basically elves are from nordic mythology, and it's a vampire elf, so it makes sense
20181105 13:42:12< celmin|sleep> ...oddly, war and death are also mentioned. Huh.
20181105 13:42:44< hk238> Not a huge amount of sense but some. If you have a better name, then go ahead :D
20181105 13:42:47< celmin|sleep> Well, it's true that elves are from Norse mythology.
20181105 13:43:04< celmin|sleep> Another thing that's from Norse mythology is the draugr.
20181105 13:43:21< celmin|sleep> Which is sort of like a vampire/zombie cross maybe?
20181105 13:43:31< hk238> It is? I thought it's a general name from Old Norse for an undead?
20181105 13:43:48< hk238> We could check
20181105 13:44:05< celmin|sleep> Could be, but it does seem to have specific properties distinct from undead in other mythologies, so...
20181105 13:44:16-!- celmin|sleep is now known as celmin|away
20181105 13:44:46< hk238> You're right it's part of the mythology, but it does seem to refer to undead in a generic sense. Perhaps how they're portrayed in the myths is then key
20181105 13:45:00-!- vn971 [~vasya@94.158.103.15] has left #wesnoth-umc-dev ["Leaving."]
20181105 13:46:13< celmin|away> Based on Wikipedia I think I was specifically thinking of sea-draugr.
20181105 13:48:31< hk238> I still need to do my daily workout before going to sleep so I think I'll stop making this WML stuff for now and instead.. play a game, it's good to do the workout while waiting for opponent to move.. :D
20181105 15:47:37-!- gfgtdf [~Daniel@x55b0e14d.dyn.telefonica.de] has joined #wesnoth-umc-dev
20181105 15:55:45< Ravana_> with 1.12 I solved download requirement with https://github.com/ProditorMagnus/Ageless-for-1-11/blob/master/data/general_data/_data.cfg#L7
20181105 15:56:17< Ravana_> I don't intentionally support people that don't have ageless installed
20181105 15:59:37< Ravana_> "for 1.14 I marked it required, even when it might not be" part was about the fact that with certain settings only core colors will be used
20181105 16:08:02< Ravana_> you could contribute to https://github.com/ProditorMagnus/Color_Modification
20181105 16:08:17< Ravana_> I might add those colors anyways eventually if they look good
20181105 17:21:25< hk238> I think they look pretty good :D 
20181105 17:21:59< hk238> Although some details are a bit off but for now I prefer using them constantly over the default color set which is kind of ugly
20181105 17:29:08-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
20181105 17:39:14-!- gfgtdf [~Daniel@x55b0e14d.dyn.telefonica.de] has quit [Quit: Leaving]
--- Log closed Tue Nov 06 00:00:50 2018